[jira] [Updated] (CASSANDRA-18956) Metadata Loss caused by unchecked rename column when upgrading from 2.x to 3.0.29
[
https://issues.apache.org/jira/browse/CASSANDRA-18956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
miklosovic updated CASSANDRA-18956:
---
Attachment: signature.asc
something like this
https://github.com/apache/cassandra/blob/cassandra-3.0/test/distributed/org/apache/cassandra/distributed/upgrade/MigrateDropColumnsTest.java
Sent from ProtonMail mobile
\
> Metadata Loss caused by unchecked rename column when upgrading from 2.x to
> 3.0.29
> -
>
> Key: CASSANDRA-18956
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18956
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Distributed Metadata
>Reporter: Ke Han
>Priority: Normal
> Attachments: data.tar.gz, signature.asc, signature.asc, signature.asc
>
>
> After migrating data from 2.1.22 (released 2022-06-17) to 3.0.29 (released
> 2023-05-05), if user performs a rename operation to rename the primary key to
> an existing column, it will succeed, and the original column will get lost
> permanently.
> h1. Reproduce
> Start up single cassandra node 2.1.22, create the following table using
> cassandra-cli
> {code:java}
> # bin/cassandra-cli
> create keyspace test with strategy_options = {replication_factor:1} and
> placement_strategy = 'org.apache.cassandra.locator.SimpleStrategy';
> use test;
> create column family foos
> with column_type = 'Standard'
> and comparator = 'BytesType'
> and key_validation_class = 'UTF8Type'
> and column_metadata = [{column_name: '2f', validation_class: 'UTF8Type'}];
> {code}
> Stop the daemon
> {code:java}
> bin/nodetool -h :::127.0.0.1 stopdaemon {code}
> Upgrade, start up new version
> {code:java}
> cqlsh> desc test.foos ;
> CREATE TABLE test.foos (
> key text PRIMARY KEY,
> "2f" text
> ) WITH COMPACT STORAGE
> AND bloom_filter_fp_chance = 0.01
> AND caching = {'keys': 'ALL', 'rows_per_partition': 'NONE'}
> AND comment = ''
> AND compaction = {'class':
> 'org.apache.cassandra.db.compaction.SizeTieredCompactionStrategy',
> 'max_threshold': '32', 'min_threshold': '4'}
> AND compression = {'chunk_length_in_kb': '64', 'class':
> 'org.apache.cassandra.io.compress.LZ4Compressor'}
> AND crc_check_chance = 1.0
> AND dclocal_read_repair_chance = 0.1
> AND default_time_to_live = 0
> AND gc_grace_seconds = 864000
> AND max_index_interval = 2048
> AND memtable_flush_period_in_ms = 0
> AND min_index_interval = 128
> AND read_repair_chance = 0.0
> AND speculative_retry = 'NONE';
> cqlsh> ALTER TABLE test.foos RENAME key TO "2f";
> cqlsh> desc test.foos ;
> CREATE TABLE test.foos (
> "2f" text PRIMARY KEY
> ) WITH COMPACT STORAGE
> AND bloom_filter_fp_chance = 0.01
> AND caching = {'keys': 'ALL', 'rows_per_partition': 'NONE'}
> AND comment = ''
> AND compaction = {'class':
> 'org.apache.cassandra.db.compaction.SizeTieredCompactionStrategy',
> 'max_threshold': '32', 'min_threshold': '4'}
> AND compression = {'chunk_length_in_kb': '64', 'class':
> 'org.apache.cassandra.io.compress.LZ4Compressor'}
> AND crc_check_chance = 1.0
> AND dclocal_read_repair_chance = 0.1
> AND default_time_to_live = 0
> AND gc_grace_seconds = 864000
> AND max_index_interval = 2048
> AND memtable_flush_period_in_ms = 0
> AND min_index_interval = 128
> AND read_repair_chance = 0.0
> AND speculative_retry = 'NONE';
> cqlsh> SELECT * FROM test.foos ;
> 2f
>
> (0 rows) {code}
> h1. Root Cause
> The root cause is a missing check for the existing column when the table
> comparator from the old version is BytesType.
> I have uploaded the data dir, use it to start up 3.0.29 and execute the
> commands will reproduce this bug.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18956) Metadata Loss caused by unchecked rename column when upgrading from 2.x to 3.0.29
[
https://issues.apache.org/jira/browse/CASSANDRA-18956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
miklosovic updated CASSANDRA-18956:
---
Attachment: signature.asc
Any chance you write a test?
\
> Metadata Loss caused by unchecked rename column when upgrading from 2.x to
> 3.0.29
> -
>
> Key: CASSANDRA-18956
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18956
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Distributed Metadata
>Reporter: Ke Han
>Priority: Normal
> Attachments: data.tar.gz, signature.asc, signature.asc
>
>
> After migrating data from 2.1.22 (released 2022-06-17) to 3.0.29 (released
> 2023-05-05), if user performs a rename operation to rename the primary key to
> an existing column, it will succeed, and the original column will get lost
> permanently.
> h1. Reproduce
> Start up single cassandra node 2.1.22, create the following table using
> cassandra-cli
> {code:java}
> # bin/cassandra-cli
> create keyspace test with strategy_options = {replication_factor:1} and
> placement_strategy = 'org.apache.cassandra.locator.SimpleStrategy';
> use test;
> create column family foos
> with column_type = 'Standard'
> and comparator = 'BytesType'
> and key_validation_class = 'UTF8Type'
> and column_metadata = [{column_name: '2f', validation_class: 'UTF8Type'}];
> {code}
> Stop the daemon
> {code:java}
> bin/nodetool -h :::127.0.0.1 stopdaemon {code}
> Upgrade, start up new version
> {code:java}
> cqlsh> desc test.foos ;
> CREATE TABLE test.foos (
> key text PRIMARY KEY,
> "2f" text
> ) WITH COMPACT STORAGE
> AND bloom_filter_fp_chance = 0.01
> AND caching = {'keys': 'ALL', 'rows_per_partition': 'NONE'}
> AND comment = ''
> AND compaction = {'class':
> 'org.apache.cassandra.db.compaction.SizeTieredCompactionStrategy',
> 'max_threshold': '32', 'min_threshold': '4'}
> AND compression = {'chunk_length_in_kb': '64', 'class':
> 'org.apache.cassandra.io.compress.LZ4Compressor'}
> AND crc_check_chance = 1.0
> AND dclocal_read_repair_chance = 0.1
> AND default_time_to_live = 0
> AND gc_grace_seconds = 864000
> AND max_index_interval = 2048
> AND memtable_flush_period_in_ms = 0
> AND min_index_interval = 128
> AND read_repair_chance = 0.0
> AND speculative_retry = 'NONE';
> cqlsh> ALTER TABLE test.foos RENAME key TO "2f";
> cqlsh> desc test.foos ;
> CREATE TABLE test.foos (
> "2f" text PRIMARY KEY
> ) WITH COMPACT STORAGE
> AND bloom_filter_fp_chance = 0.01
> AND caching = {'keys': 'ALL', 'rows_per_partition': 'NONE'}
> AND comment = ''
> AND compaction = {'class':
> 'org.apache.cassandra.db.compaction.SizeTieredCompactionStrategy',
> 'max_threshold': '32', 'min_threshold': '4'}
> AND compression = {'chunk_length_in_kb': '64', 'class':
> 'org.apache.cassandra.io.compress.LZ4Compressor'}
> AND crc_check_chance = 1.0
> AND dclocal_read_repair_chance = 0.1
> AND default_time_to_live = 0
> AND gc_grace_seconds = 864000
> AND max_index_interval = 2048
> AND memtable_flush_period_in_ms = 0
> AND min_index_interval = 128
> AND read_repair_chance = 0.0
> AND speculative_retry = 'NONE';
> cqlsh> SELECT * FROM test.foos ;
> 2f
>
> (0 rows) {code}
> h1. Root Cause
> The root cause is a missing check for the existing column when the table
> comparator from the old version is BytesType.
> I have uploaded the data dir, use it to start up 3.0.29 and execute the
> commands will reproduce this bug.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-staging updated (d0a969bd1 -> c9bf6c9f5)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard d0a969bd1 generate docs for 207dbf1f new c9bf6c9f5 generate docs for 207dbf1f This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (d0a969bd1) \ N -- N -- N refs/heads/asf-staging (c9bf6c9f5) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: site-ui/build/ui-bundle.zip | Bin 4881412 -> 4881412 bytes 1 file changed, 0 insertions(+), 0 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18956) Metadata Loss caused by unchecked rename column when upgrading from 2.x to 3.0.29
[
https://issues.apache.org/jira/browse/CASSANDRA-18956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779291#comment-17779291
]
Ke Han edited comment on CASSANDRA-18956 at 10/26/23 3:30 AM:
--
[~smiklosovic] Thanks for the reply!
(1) The expected situation should be an exception and system should stops this
request.
{code:java}
cqlsh> ALTER TABLE test.foos RENAME key TO "2f";
InvalidRequest: Error from server: code=2200 [Invalid query] message="Cannot
rename column key to 2f in keyspace foos; another column of that name already
exist" {code}
(2) "No enough power to fix this bug." I totally agree. This bug happens
rarely, and 3.0 is going to be deprecated soon.
I have fixed this bug and submitted a PR for fixing. The root cause is: when
renaming column FROM => TO, the system checks whether FROM exists but does not
check TO properly. The fix is simple: also add a check for the TO column.
Do you mind taking a look at my PR? I really appreciate it! The PR is here:
[https://github.com/apache/cassandra/pull/2840]
was (Author: JIRAUSER289562):
[~smiklosovic] Thanks for the reply!
(1) The expected situation should be an exception and system should stops this
request.
{code:java}
cqlsh> ALTER TABLE test.foos RENAME key TO "2f";
InvalidRequest: Error from server: code=2200 [Invalid query] message="Cannot
rename column key to 2f in keyspace foos; another column of that name already
exist" {code}
(2) "No enough power to fix this bug." I totally agree. This bug happens
rarely, and 3.0 is going to be deprecated soon.
I have fixed this bug and submitted a PR for fixing. The fix is simple: when
renaming column FROM => TO, the system checks whether FROM exists but not check
TO properly. This PR adds an additional check.
Do you mind taking a look at my PR? I really appreciate it! The PR is here:
[https://github.com/apache/cassandra/pull/2840]
> Metadata Loss caused by unchecked rename column when upgrading from 2.x to
> 3.0.29
> -
>
> Key: CASSANDRA-18956
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18956
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Distributed Metadata
>Reporter: Ke Han
>Priority: Normal
> Attachments: data.tar.gz, signature.asc
>
>
> After migrating data from 2.1.22 (released 2022-06-17) to 3.0.29 (released
> 2023-05-05), if user performs a rename operation to rename the primary key to
> an existing column, it will succeed, and the original column will get lost
> permanently.
> h1. Reproduce
> Start up single cassandra node 2.1.22, create the following table using
> cassandra-cli
> {code:java}
> # bin/cassandra-cli
> create keyspace test with strategy_options = {replication_factor:1} and
> placement_strategy = 'org.apache.cassandra.locator.SimpleStrategy';
> use test;
> create column family foos
> with column_type = 'Standard'
> and comparator = 'BytesType'
> and key_validation_class = 'UTF8Type'
> and column_metadata = [{column_name: '2f', validation_class: 'UTF8Type'}];
> {code}
> Stop the daemon
> {code:java}
> bin/nodetool -h :::127.0.0.1 stopdaemon {code}
> Upgrade, start up new version
> {code:java}
> cqlsh> desc test.foos ;
> CREATE TABLE test.foos (
> key text PRIMARY KEY,
> "2f" text
> ) WITH COMPACT STORAGE
> AND bloom_filter_fp_chance = 0.01
> AND caching = {'keys': 'ALL', 'rows_per_partition': 'NONE'}
> AND comment = ''
> AND compaction = {'class':
> 'org.apache.cassandra.db.compaction.SizeTieredCompactionStrategy',
> 'max_threshold': '32', 'min_threshold': '4'}
> AND compression = {'chunk_length_in_kb': '64', 'class':
> 'org.apache.cassandra.io.compress.LZ4Compressor'}
> AND crc_check_chance = 1.0
> AND dclocal_read_repair_chance = 0.1
> AND default_time_to_live = 0
> AND gc_grace_seconds = 864000
> AND max_index_interval = 2048
> AND memtable_flush_period_in_ms = 0
> AND min_index_interval = 128
> AND read_repair_chance = 0.0
> AND speculative_retry = 'NONE';
> cqlsh> ALTER TABLE test.foos RENAME key TO "2f";
> cqlsh> desc test.foos ;
> CREATE TABLE test.foos (
> "2f" text PRIMARY KEY
> ) WITH COMPACT STORAGE
> AND bloom_filter_fp_chance = 0.01
> AND caching = {'keys': 'ALL', 'rows_per_partition': 'NONE'}
> AND comment = ''
> AND compaction = {'class':
> 'org.apache.cassandra.db.compaction.SizeTieredCompactionStrategy',
> 'max_threshold': '32', 'min_threshold': '4'}
> AND compression = {'chunk_length_in_kb': '64', 'class':
> 'org.apache.cassandra.io.compress.LZ4Compressor'}
> AND crc_check_chance = 1.0
> AND dclocal_read_repair_chance = 0.1
> AND default_time_to_live = 0
> AND gc_grace_seconds = 864000
> AND max_index_interval = 2048
> AND
[cassandra-website] branch asf-staging updated (71d3b6ed2 -> d0a969bd1)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard 71d3b6ed2 generate docs for 207dbf1f new d0a969bd1 generate docs for 207dbf1f This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (71d3b6ed2) \ N -- N -- N refs/heads/asf-staging (d0a969bd1) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: site-ui/build/ui-bundle.zip | Bin 4881412 -> 4881412 bytes 1 file changed, 0 insertions(+), 0 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] Cassandra 18852: Make bulk writer resilient to cluster resize events [cassandra-analytics]
arjunashok commented on code in PR #17:
URL:
https://github.com/apache/cassandra-analytics/pull/17#discussion_r1372321724
##
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/token/ConsistencyLevel.java:
##
@@ -20,18 +20,43 @@
package org.apache.cassandra.spark.bulkwriter.token;
import java.util.Collection;
+import java.util.Collections;
+import java.util.Set;
+import java.util.stream.Collectors;
import com.google.common.base.Preconditions;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
import org.apache.cassandra.spark.common.model.CassandraInstance;
import org.apache.cassandra.spark.data.ReplicationFactor;
public interface ConsistencyLevel
{
boolean isLocal();
-boolean checkConsistency(Collection
failedInsts, ReplicationFactor replicationFactor, String localDC);
+Logger LOGGER = LoggerFactory.getLogger(ConsistencyLevel.class);
+
+/**
+ * Checks if the consistency guarantees are maintained, given the failed,
blocked and replacing instances, consistency-level and the replication-factor.
+ *
+ * - QUORUM based consistency levels check for quorum using the
write-replica-set (instead of RF) as they include healthy and pending nodes.
+ * This is done to ensure that writes go to a quorum of healthy nodes
while accounting for potential failure in pending nodes becoming healthy.
+ * - ONE and TWO consistency guarantees are maintained by ensuring that
the failures leave us with at-least the corresponding healthy
+ * (and non-pending) nodes.
+ *
+ * For both the above cases, blocked instances are also considered as
failures while performing consistency checks.
+ * Write replicas are adjusted to exclude replacement nodes for
consistency checks, if we have replacement nodes that are not among the failed
instances.
+ * This is to ensure that we are writing to sufficient non-replacement
nodes as replacements can potentially fail leaving us with fewer nodes.
+ *
+ */
+boolean checkConsistency(CassandraRing ring,
+ TokenRangeMapping
tokenRangeMapping,
Review Comment:
Addressed
##
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/token/ConsistencyLevel.java:
##
@@ -82,19 +119,25 @@ public boolean checkConsistency(Collection failedIn
},
QUORUM
{
+// Keyspaces exist with RF 1 or 2
@Override
public boolean isLocal()
{
return false;
}
@Override
-public boolean checkConsistency(Collection failedInsts,
-ReplicationFactor
replicationFactor,
-String localDC)
+public boolean checkConsistency(final CassandraRing ring,
+final TokenRangeMapping tokenRangeMapping,
+final Collection failedInsts,
+final String localDC)
{
-int rf = replicationFactor.getTotalReplicationFactor();
-return failedInsts.size() <= (rf - (rf / 2 + 1));
+Set replacingInstances =
tokenRangeMapping.getReplacementInstances();
+Set failedInstanceIPs =
failedInsts.stream().map(CassandraInstance::getIpAddress).collect(Collectors.toSet());
+final long writeReplicaCount =
maybeUpdateWriteReplicasForReplacements(tokenRangeMapping.getWriteReplicas(),
+
replacingInstances,
+
failedInstanceIPs);
Review Comment:
Addressed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18952) Add metrics and logging to repair retries
[ https://issues.apache.org/jira/browse/CASSANDRA-18952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779677#comment-17779677 ] Caleb Rackliffe commented on CASSANDRA-18952: - +1, w/ a minor comment in the PR > Add metrics and logging to repair retries > - > > Key: CASSANDRA-18952 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18952 > Project: Cassandra > Issue Type: Improvement > Components: Consistency/Repair, Observability/Metrics >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: 5.0.x, 5.x > > Time Spent: 2.5h > Remaining Estimate: 0h > > In CASSANDRA-18816 we added repair message retries but forgot to add logging > and metrics to actually let operators know repairs happened and how often… we > should add such visibility to help operators know how best to tune it for > their environment. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18952) Add metrics and logging to repair retries
[ https://issues.apache.org/jira/browse/CASSANDRA-18952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caleb Rackliffe updated CASSANDRA-18952: Reviewers: Caleb Rackliffe, Maxim Muzafarov (was: Maxim Muzafarov) > Add metrics and logging to repair retries > - > > Key: CASSANDRA-18952 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18952 > Project: Cassandra > Issue Type: Improvement > Components: Consistency/Repair, Observability/Metrics >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: 5.0.x, 5.x > > Time Spent: 2.5h > Remaining Estimate: 0h > > In CASSANDRA-18816 we added repair message retries but forgot to add logging > and metrics to actually let operators know repairs happened and how often… we > should add such visibility to help operators know how best to tune it for > their environment. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-staging updated (f19a9dab2 -> 71d3b6ed2)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard f19a9dab2 generate docs for 207dbf1f new 71d3b6ed2 generate docs for 207dbf1f This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (f19a9dab2) \ N -- N -- N refs/heads/asf-staging (71d3b6ed2) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: content/search-index.js | 2 +- site-ui/build/ui-bundle.zip | Bin 4881412 -> 4881412 bytes 2 files changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18941) Support max SSTable size in sorted CQLSSTableWriter
[ https://issues.apache.org/jira/browse/CASSANDRA-18941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yifan Cai updated CASSANDRA-18941: -- Fix Version/s: 4.0.x 4.1.x 5.0.x > Support max SSTable size in sorted CQLSSTableWriter > --- > > Key: CASSANDRA-18941 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18941 > Project: Cassandra > Issue Type: Improvement > Components: Tool/sstable >Reporter: Yifan Cai >Assignee: Yifan Cai >Priority: Normal > Fix For: 4.0.x, 4.1.x, 5.0.x, 5.x > > Time Spent: 3h 10m > Remaining Estimate: 0h > > The CQLSSTableWriter can produce a series of SSTables with a bounded size in > the unsorted mode. The functionality is missing in the sorted > CQLSSTableWriter. > It will be great to bringing the parity to the sorted mode, so that it is > able to produce a series of size-bounded SSTable, instead of a single but > giant one. > Unlike the unsorted CQLSSTableWriter, the max SSTable size in the sorted > writer does not require buffering. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18941) Support max SSTable size in sorted CQLSSTableWriter
[ https://issues.apache.org/jira/browse/CASSANDRA-18941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779638#comment-17779638 ] Yifan Cai commented on CASSANDRA-18941: --- Backporting the PR to other branches as proposed in the dev thread. cassandra-4.0: [https://github.com/apache/cassandra/pull/2845] cassandra-4.1: [https://github.com/apache/cassandra/pull/2846] cassandra-5.0: [https://github.com/apache/cassandra/pull/2847] cassandra-trunk: [https://github.com/apache/cassandra/pull/2824] > Support max SSTable size in sorted CQLSSTableWriter > --- > > Key: CASSANDRA-18941 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18941 > Project: Cassandra > Issue Type: Improvement > Components: Tool/sstable >Reporter: Yifan Cai >Assignee: Yifan Cai >Priority: Normal > Fix For: 5.x > > Time Spent: 3h 10m > Remaining Estimate: 0h > > The CQLSSTableWriter can produce a series of SSTables with a bounded size in > the unsorted mode. The functionality is missing in the sorted > CQLSSTableWriter. > It will be great to bringing the parity to the sorted mode, so that it is > able to produce a series of size-bounded SSTable, instead of a single but > giant one. > Unlike the unsorted CQLSSTableWriter, the max SSTable size in the sorted > writer does not require buffering. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18866) Node sends multiple inflight echos
[ https://issues.apache.org/jira/browse/CASSANDRA-18866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779630#comment-17779630 ] Brandon Williams commented on CASSANDRA-18866: -- It's still on my radar, we just need to be very thorough and cautious on our second attempt. > Node sends multiple inflight echos > -- > > Key: CASSANDRA-18866 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18866 > Project: Cassandra > Issue Type: Improvement > Components: Cluster/Gossip >Reporter: Cameron Zemek >Assignee: Cameron Zemek >Priority: Normal > Attachments: 18866-regression.patch, duplicates.log, echo.log > > > CASSANDRA-18854 rolled back the changes from CASSANDRA-18845. In particular, > 18845 had change to only allow 1 inflight ECHO request at a time. As per > 18854 some tests have an error rate due to this change. Creating this ticket > to discuss this further. As the current state also does not have retry logic, > it just allowing multiple ECHO requests inflight at the same time so less > likely that all ECHO will timeout or get lost. > With the change from 18845 adding in some extra logging to track what is > going on, I do see it retrying ECHOs. Likewise, I patched a node to drop ECHO > requests from a node and also see it retrying ECHOs when it doesn't get a > reply. > Therefore, I think the problem is more specific than the dropping of one ECHO > request. Yes there no retry logic for failed ECHO requests, but this is the > case even both before and after 18845. ECHO requests are only sent via gossip > verb handlers calling applyStateLocally. In these failed tests I therefore > assuming their cases where it won't call markAlive when other nodes consider > the node UP but its marked DOWN by a node. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18872) Remove deprecated crc_check_chance in compression params
[ https://issues.apache.org/jira/browse/CASSANDRA-18872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779621#comment-17779621 ] Stefan Miklosovic edited comment on CASSANDRA-18872 at 10/25/23 6:31 PM: - [~blambov] I have reflected your suggestions on the PR into the code and squashed it all. dtest PR [here|https://github.com/apache/cassandra-dtest/pull/238/files] I am waiting for your explicit +1. Thanks was (Author: smiklosovic): [~blambov] I have reflected your suggestions on the PR into the code and squashed it all. I am waiting for your explicit +1. Thanks > Remove deprecated crc_check_chance in compression params > > > Key: CASSANDRA-18872 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18872 > Project: Cassandra > Issue Type: Task > Components: Feature/Compression, Legacy/CQL >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 5.x > > Time Spent: 1h > Remaining Estimate: 0h > > crc_check_chance was moved from compression parameters and it is a standalone > table parameter. This was done in times of 3.0 so it is now time to get rid > of that in 5.0. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18872) Remove deprecated crc_check_chance in compression params
[ https://issues.apache.org/jira/browse/CASSANDRA-18872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779621#comment-17779621 ] Stefan Miklosovic commented on CASSANDRA-18872: --- [~blambov] I have reflected your suggestions on the PR into the code and squashed it all. I am waiting for your explicit +1. Thanks > Remove deprecated crc_check_chance in compression params > > > Key: CASSANDRA-18872 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18872 > Project: Cassandra > Issue Type: Task > Components: Feature/Compression, Legacy/CQL >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 5.x > > Time Spent: 50m > Remaining Estimate: 0h > > crc_check_chance was moved from compression parameters and it is a standalone > table parameter. This was done in times of 3.0 so it is now time to get rid > of that in 5.0. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18872) Remove deprecated crc_check_chance in compression params
[ https://issues.apache.org/jira/browse/CASSANDRA-18872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779618#comment-17779618 ] Brandon Williams commented on CASSANDRA-18872: -- It was just a timeout, so probably. > Remove deprecated crc_check_chance in compression params > > > Key: CASSANDRA-18872 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18872 > Project: Cassandra > Issue Type: Task > Components: Feature/Compression, Legacy/CQL >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 5.x > > Time Spent: 50m > Remaining Estimate: 0h > > crc_check_chance was moved from compression parameters and it is a standalone > table parameter. This was done in times of 3.0 so it is now time to get rid > of that in 5.0. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18872) Remove deprecated crc_check_chance in compression params
[ https://issues.apache.org/jira/browse/CASSANDRA-18872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779614#comment-17779614 ] Stefan Miklosovic edited comment on CASSANDRA-18872 at 10/25/23 6:16 PM: - this one fails upgrade_tests/cql_tests.py::TestCQLNodes2RF1_Upgrade_current_5_0_x_To_indev_trunk::test_no_clustering but I was not able to reproduce it locally. Probably just a flake. was (Author: smiklosovic): this one fails upgrade_tests/cql_tests.py::TestCQLNodes2RF1_Upgrade_current_5_0_x_To_indev_trunk::test_no_clustering but I was not able to reproduce it locally. Probably just a flaky. > Remove deprecated crc_check_chance in compression params > > > Key: CASSANDRA-18872 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18872 > Project: Cassandra > Issue Type: Task > Components: Feature/Compression, Legacy/CQL >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 5.x > > Time Spent: 0.5h > Remaining Estimate: 0h > > crc_check_chance was moved from compression parameters and it is a standalone > table parameter. This was done in times of 3.0 so it is now time to get rid > of that in 5.0. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18872) Remove deprecated crc_check_chance in compression params
[ https://issues.apache.org/jira/browse/CASSANDRA-18872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779614#comment-17779614 ] Stefan Miklosovic commented on CASSANDRA-18872: --- this one fails upgrade_tests/cql_tests.py::TestCQLNodes2RF1_Upgrade_current_5_0_x_To_indev_trunk::test_no_clustering but I was not able to reproduce it locally. Probably just a flaky. > Remove deprecated crc_check_chance in compression params > > > Key: CASSANDRA-18872 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18872 > Project: Cassandra > Issue Type: Task > Components: Feature/Compression, Legacy/CQL >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 5.x > > Time Spent: 0.5h > Remaining Estimate: 0h > > crc_check_chance was moved from compression parameters and it is a standalone > table parameter. This was done in times of 3.0 so it is now time to get rid > of that in 5.0. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] Cassandra 18852: [WIP] Make bulk writer resilient to cluster resize events [cassandra-analytics]
arjunashok commented on code in PR #17:
URL:
https://github.com/apache/cassandra-analytics/pull/17#discussion_r1372139184
##
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/token/ConsistencyLevel.java:
##
@@ -20,18 +20,43 @@
package org.apache.cassandra.spark.bulkwriter.token;
import java.util.Collection;
+import java.util.Collections;
+import java.util.Set;
+import java.util.stream.Collectors;
import com.google.common.base.Preconditions;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
import org.apache.cassandra.spark.common.model.CassandraInstance;
import org.apache.cassandra.spark.data.ReplicationFactor;
public interface ConsistencyLevel
{
boolean isLocal();
-boolean checkConsistency(Collection
failedInsts, ReplicationFactor replicationFactor, String localDC);
+Logger LOGGER = LoggerFactory.getLogger(ConsistencyLevel.class);
+
+/**
+ * Checks if the consistency guarantees are maintained, given the failed,
blocked and replacing instances, consistency-level and the replication-factor.
+ *
+ * - QUORUM based consistency levels check for quorum using the
write-replica-set (instead of RF) as they include healthy and pending nodes.
+ * This is done to ensure that writes go to a quorum of healthy nodes
while accounting for potential failure in pending nodes becoming healthy.
+ * - ONE and TWO consistency guarantees are maintained by ensuring that
the failures leave us with at-least the corresponding healthy
+ * (and non-pending) nodes.
+ *
+ * For both the above cases, blocked instances are also considered as
failures while performing consistency checks.
+ * Write replicas are adjusted to exclude replacement nodes for
consistency checks, if we have replacement nodes that are not among the failed
instances.
+ * This is to ensure that we are writing to sufficient non-replacement
nodes as replacements can potentially fail leaving us with fewer nodes.
+ *
+ */
+boolean checkConsistency(CassandraRing ring,
+ TokenRangeMapping
tokenRangeMapping,
Review Comment:
Fair point. The reason I pulled this in is because some of these values are
CL specific. For instance, we use local_dc for LOCAL_QUORUM and LOCAL_ONE.
Also, for multi-DC, we cycle through all DCs to find consistency failures.
What you're suggesting will require some specific checks up-front (before
`checkConsistency`) for the cases I mentioned, but it will isolate CL
functionality to some extent. Will update
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18962) Add retries to IR messages
[ https://issues.apache.org/jira/browse/CASSANDRA-18962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-18962: -- Test and Documentation Plan: updated tests Status: Patch Available (was: In Progress) > Add retries to IR messages > -- > > Key: CASSANDRA-18962 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18962 > Project: Cassandra > Issue Type: Improvement > Components: Consistency/Repair >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: 5.0.x, 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > With CASSANDRA-18816 we now have repair message retries for full and preview > repair, but IR was left out as message processing was handled differently, > this patch is to extend that work to include IR messages! > Out of scope of this patch was making the status checks deal with retries as > we retry anyways every hour or so… -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18962) Add retries to IR messages
[ https://issues.apache.org/jira/browse/CASSANDRA-18962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779598#comment-17779598 ] David Capwell commented on CASSANDRA-18962: --- The current patch is based off CASSANDRA-18952 as I know there will be conflicts... that should be ready to merge before this one at which point ill rebase back to 5.0... Once review is close to done ill then make the patch for trunk as well... keeping 5.0 and trunk in-sync is easy to loose feedback, so prefer to handle the trunk branch at the end of the review. > Add retries to IR messages > -- > > Key: CASSANDRA-18962 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18962 > Project: Cassandra > Issue Type: Improvement > Components: Consistency/Repair >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: 5.0.x, 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > With CASSANDRA-18816 we now have repair message retries for full and preview > repair, but IR was left out as message processing was handled differently, > this patch is to extend that work to include IR messages! > Out of scope of this patch was making the status checks deal with retries as > we retry anyways every hour or so… -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18962) Add retries to IR messages
[ https://issues.apache.org/jira/browse/CASSANDRA-18962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-18962: -- Change Category: Operability Complexity: Normal Fix Version/s: 5.0.x 5.x Assignee: David Capwell Status: Open (was: Triage Needed) > Add retries to IR messages > -- > > Key: CASSANDRA-18962 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18962 > Project: Cassandra > Issue Type: Improvement > Components: Consistency/Repair >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: 5.0.x, 5.x > > > With CASSANDRA-18816 we now have repair message retries for full and preview > repair, but IR was left out as message processing was handled differently, > this patch is to extend that work to include IR messages! > Out of scope of this patch was making the status checks deal with retries as > we retry anyways every hour or so… -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-18962) Add retries to IR messages
David Capwell created CASSANDRA-18962: - Summary: Add retries to IR messages Key: CASSANDRA-18962 URL: https://issues.apache.org/jira/browse/CASSANDRA-18962 Project: Cassandra Issue Type: Improvement Components: Consistency/Repair Reporter: David Capwell With CASSANDRA-18816 we now have repair message retries for full and preview repair, but IR was left out as message processing was handled differently, this patch is to extend that work to include IR messages! Out of scope of this patch was making the status checks deal with retries as we retry anyways every hour or so… -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18952) Add metrics and logging to repair retries
[ https://issues.apache.org/jira/browse/CASSANDRA-18952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-18952: -- Reviewers: Maxim Muzafarov Status: Review In Progress (was: Patch Available) > Add metrics and logging to repair retries > - > > Key: CASSANDRA-18952 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18952 > Project: Cassandra > Issue Type: Improvement > Components: Consistency/Repair, Observability/Metrics >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: 5.0.x, 5.x > > Time Spent: 2.5h > Remaining Estimate: 0h > > In CASSANDRA-18816 we added repair message retries but forgot to add logging > and metrics to actually let operators know repairs happened and how often… we > should add such visibility to help operators know how best to tune it for > their environment. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18961) Record commit timestamp - fix data loss when dropping and recreating a column
[
https://issues.apache.org/jira/browse/CASSANDRA-18961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779574#comment-17779574
]
Jacek Lewandowski commented on CASSANDRA-18961:
---
The issue can be demonstrated with this CQL:
{code:sql}
CREATE KEYSPACE ks WITH REPLICATION = {'class': 'SimpleStrategy',
'replication_factor': 1};
CREATE TABLE ks.tab (id INT PRIMARY KEY, a INT, b INT, c INT);
INSERT INTO ks.tab (id, a, b, c) VALUES (1, 1, 1, 1);
ALTER TABLE ks.tab DROP (c);
INSERT INTO ks.tab (id, a, b) VALUES (2, 2, 2);
ALTER TABLE ks.tab ADD c INT;
INSERT INTO ks.tab (id, a, b, c) VALUES (3, 3, 3, 3);
SELECT * FROM ks.tab;
{code}
restart the node, then
{code:sql}
SELECT * FROM ks.tab;
{code}
> Record commit timestamp - fix data loss when dropping and recreating a column
> -
>
> Key: CASSANDRA-18961
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18961
> Project: Cassandra
> Issue Type: Bug
> Components: Transactional Cluster Metadata
>Reporter: Jacek Lewandowski
>Assignee: Jacek Lewandowski
>Priority: Normal
>
> Drop column transformation is replayed with the current timestamp so the
> column appears to be dropped when the node starts regardless of its real drop
> time.
> As a solution to this problem I propose recording the timestamp of the
> transformation, guaranteeing that it is always greater than a timestamp of
> any previously committed transformation. Such timestamp is passed to the
> execute method of the transformation so that the transformation code can make
> use of it, increasing its "purity".
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18961) Record commit timestamp - fix data loss when dropping and recreating a column
[ https://issues.apache.org/jira/browse/CASSANDRA-18961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacek Lewandowski updated CASSANDRA-18961: -- Bug Category: Parent values: Correctness(12982)Level 1 values: Unrecoverable Corruption / Loss(13161) Complexity: Normal Component/s: Transactional Cluster Metadata Discovered By: Code Inspection Severity: Normal Assignee: Jacek Lewandowski Status: Open (was: Triage Needed) > Record commit timestamp - fix data loss when dropping and recreating a column > - > > Key: CASSANDRA-18961 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18961 > Project: Cassandra > Issue Type: Bug > Components: Transactional Cluster Metadata >Reporter: Jacek Lewandowski >Assignee: Jacek Lewandowski >Priority: Normal > > Drop column transformation is replayed with the current timestamp so the > column appears to be dropped when the node starts regardless of its real drop > time. > As a solution to this problem I propose recording the timestamp of the > transformation, guaranteeing that it is always greater than a timestamp of > any previously committed transformation. Such timestamp is passed to the > execute method of the transformation so that the transformation code can make > use of it, increasing its "purity". -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-18961) Record commit timestamp - fix data loss when dropping and recreating a column
Jacek Lewandowski created CASSANDRA-18961: - Summary: Record commit timestamp - fix data loss when dropping and recreating a column Key: CASSANDRA-18961 URL: https://issues.apache.org/jira/browse/CASSANDRA-18961 Project: Cassandra Issue Type: Bug Reporter: Jacek Lewandowski Drop column transformation is replayed with the current timestamp so the column appears to be dropped when the node starts regardless of its real drop time. As a solution to this problem I propose recording the timestamp of the transformation, guaranteeing that it is always greater than a timestamp of any previously committed transformation. Such timestamp is passed to the execute method of the transformation so that the transformation code can make use of it, increasing its "purity". -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18715) Add support for vector search in SAI
[ https://issues.apache.org/jira/browse/CASSANDRA-18715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779562#comment-17779562 ] Mike Adamson commented on CASSANDRA-18715: -- The latest CI runs are here: |[5.0|https://github.com/apache/cassandra/pull/2673]|[CI|https://app.circleci.com/pipelines/github/mike-tr-adamson/cassandra/348/workflows/982fd591-c53a-4aa6-9a95-68f10df6bfae]| |[trunk|https://github.com/apache/cassandra/pull/2765]|[CI|https://app.circleci.com/pipelines/github/mike-tr-adamson/cassandra/349/workflows/20dc9c0d-695a-4f85-b2e4-a568bac06bc6]| > Add support for vector search in SAI > > > Key: CASSANDRA-18715 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18715 > Project: Cassandra > Issue Type: Improvement > Components: Feature/Vector Search >Reporter: Mike Adamson >Assignee: Mike Adamson >Priority: Normal > Fix For: 5.0-beta, 5.x > > Time Spent: 24h 10m > Remaining Estimate: 0h > > The patch associated with this ticket adds a new vector index to SAI. This > introduces the following new elements and changes to SAI: > * VectorMemtableIndex - the in-memory representation of the vector indexes > that writes data to a DiskANN instance > * VectorSegmentBuilder - that writes a DiskANN graph to the following > on-disk components: > ** VECTOR - contains the floating point vectors associated with the graph > ** TERMS - contains the HNSW graph on-disk representation written by a > HnswGraphWriter > ** POSTINGS - contains the index postings as written by a > VectorPostingsWriter > * VectorIndexSegmentSearcher - used to search the on-disk DiskANN graph -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18715) Add support for vector search in SAI
[ https://issues.apache.org/jira/browse/CASSANDRA-18715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Adamson updated CASSANDRA-18715: - Description: The patch associated with this ticket adds a new vector index to SAI. This introduces the following new elements and changes to SAI: * VectorMemtableIndex - the in-memory representation of the vector indexes that writes data to a DiskANN instance * VectorSegmentBuilder - that writes a DiskANN graph to the following on-disk components: ** VECTOR - contains the floating point vectors associated with the graph ** TERMS - contains the HNSW graph on-disk representation written by a HnswGraphWriter ** POSTINGS - contains the index postings as written by a VectorPostingsWriter * VectorIndexSegmentSearcher - used to search the on-disk DiskANN graph was: The patch associated with this ticket adds a new vector index to SAI. This introduces the following new elements and changes to SAI: * VectorMemtableIndex - the in-memory representation of the vector indexes that writes data to a CassandraOnHeapHnsw instance * VectorSegmentBuilder - that writes a HNSW graph to the following on-disk components: ** VECTOR - contains the floating point vectors associated with the graph ** TERMS - contains the HNSW graph on-disk representation written by a HnswGraphWriter ** POSTINGS - contains the index postings as written by a VectorPostingsWriter * VectorIndexSegmentSearcher - used to search the on-disk HNSW index > Add support for vector search in SAI > > > Key: CASSANDRA-18715 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18715 > Project: Cassandra > Issue Type: Improvement > Components: Feature/Vector Search >Reporter: Mike Adamson >Assignee: Mike Adamson >Priority: Normal > Fix For: 5.0-beta, 5.x > > Time Spent: 24h 10m > Remaining Estimate: 0h > > The patch associated with this ticket adds a new vector index to SAI. This > introduces the following new elements and changes to SAI: > * VectorMemtableIndex - the in-memory representation of the vector indexes > that writes data to a DiskANN instance > * VectorSegmentBuilder - that writes a DiskANN graph to the following > on-disk components: > ** VECTOR - contains the floating point vectors associated with the graph > ** TERMS - contains the HNSW graph on-disk representation written by a > HnswGraphWriter > ** POSTINGS - contains the index postings as written by a > VectorPostingsWriter > * VectorIndexSegmentSearcher - used to search the on-disk DiskANN graph -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18533) Move format-specific sstable options into the format configuration
[
https://issues.apache.org/jira/browse/CASSANDRA-18533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779554#comment-17779554
]
Maxwell Guo commented on CASSANDRA-18533:
-
[~blambov]Hi, I have some questions here.
1.we are going to put the format-specific options into the [option
map|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/io/sstable/format/AbstractSSTableFormat.java#L27]
here , am I right ?
2.it seems key_cache_size, key_cache_keys_to_save, key_cache_save_period, are
not sstable level but just for key cache which is db level, should I remove
them?
3.I am a little confusing now for table level configuration in CASSANDRA-18534
and options here. if we are going to define sstable option like [this
|https://github.com/apache/cassandra/blob/trunk/conf/cassandra.yaml#L1029],then
we may mix the table level options in CASSANDRA-18534 and the options here,
feeling not clear as we mix the table level configuration together with those
non-table level, should we separate them at yaml level, though the original
yaml do not define a configuration as table level or not .if we define sstable
format like this :
{code:java}
sstable:
selected_format: big
format.options:
- bit-fast:
row_index_granularity: 1kiB
bloom_filter_fp_chance: 0.01
- big-small:
row_index_granularity: 1kiB
bloom_filter_fp_chance: 0.01
{code}
what about change to
{code:java}
{code:java}
sstable:
selected_format: big
format.options:
- bit-fast:
row_index_granularity: 1kiB
table-level:
bloom_filter_fp_chance: 0.01
{code}
{code}
> Move format-specific sstable options into the format configuration
> --
>
> Key: CASSANDRA-18533
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18533
> Project: Cassandra
> Issue Type: Improvement
> Components: Cluster/Schema, Local/SSTable
>Reporter: Branimir Lambov
>Assignee: Maxwell Guo
>Priority: Normal
> Fix For: 5.x
>
>
> This mainly concerns cassandra yaml settings:
> - {{column_index_size}}, which should also be renamed to
> {{row_index_granularity}}
> - {{column_index_cache_size}}
> - {{index_summary_capacity}}
> - {{index_summary_resize_interval}}
> and possibly
> - {{key_cache_size}}, {{key_cache_keys_to_save}}, {{key_cache_save_period}},
> {{key_cache_migrate_during_compaction}}
> - {{sstable_preemptive_open_interval}}
> Existing settings should be deprecated but still picked up if defined.
> At this point we will not consider table-level options that make better sense
> as format parameters ({{min/max_index_interval}}, {{bloom_filter_fp_chance}},
> {{crc_check_chance}} and possibly {{compression}}), because we do not yet
> support per-table format selection/configuration.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18956) Metadata Loss caused by unchecked rename column when upgrading from 2.x to 3.0.29
[
https://issues.apache.org/jira/browse/CASSANDRA-18956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779553#comment-17779553
]
Ke Han commented on CASSANDRA-18956:
[~mikloso...@pm.me] No. It only exists in 3.0 branch.
In 3.11 branch, it's fixed by using ColumnDefinition.Raw.getIdentifier to check
both FROM and TO columns. I followed a similar way but using
ColumnIdentifier.Raw.prepare to check whether both columns exist for the
thrift-model table.
> Metadata Loss caused by unchecked rename column when upgrading from 2.x to
> 3.0.29
> -
>
> Key: CASSANDRA-18956
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18956
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Distributed Metadata
>Reporter: Ke Han
>Priority: Normal
> Attachments: data.tar.gz, signature.asc
>
>
> After migrating data from 2.1.22 (released 2022-06-17) to 3.0.29 (released
> 2023-05-05), if user performs a rename operation to rename the primary key to
> an existing column, it will succeed, and the original column will get lost
> permanently.
> h1. Reproduce
> Start up single cassandra node 2.1.22, create the following table using
> cassandra-cli
> {code:java}
> # bin/cassandra-cli
> create keyspace test with strategy_options = {replication_factor:1} and
> placement_strategy = 'org.apache.cassandra.locator.SimpleStrategy';
> use test;
> create column family foos
> with column_type = 'Standard'
> and comparator = 'BytesType'
> and key_validation_class = 'UTF8Type'
> and column_metadata = [{column_name: '2f', validation_class: 'UTF8Type'}];
> {code}
> Stop the daemon
> {code:java}
> bin/nodetool -h :::127.0.0.1 stopdaemon {code}
> Upgrade, start up new version
> {code:java}
> cqlsh> desc test.foos ;
> CREATE TABLE test.foos (
> key text PRIMARY KEY,
> "2f" text
> ) WITH COMPACT STORAGE
> AND bloom_filter_fp_chance = 0.01
> AND caching = {'keys': 'ALL', 'rows_per_partition': 'NONE'}
> AND comment = ''
> AND compaction = {'class':
> 'org.apache.cassandra.db.compaction.SizeTieredCompactionStrategy',
> 'max_threshold': '32', 'min_threshold': '4'}
> AND compression = {'chunk_length_in_kb': '64', 'class':
> 'org.apache.cassandra.io.compress.LZ4Compressor'}
> AND crc_check_chance = 1.0
> AND dclocal_read_repair_chance = 0.1
> AND default_time_to_live = 0
> AND gc_grace_seconds = 864000
> AND max_index_interval = 2048
> AND memtable_flush_period_in_ms = 0
> AND min_index_interval = 128
> AND read_repair_chance = 0.0
> AND speculative_retry = 'NONE';
> cqlsh> ALTER TABLE test.foos RENAME key TO "2f";
> cqlsh> desc test.foos ;
> CREATE TABLE test.foos (
> "2f" text PRIMARY KEY
> ) WITH COMPACT STORAGE
> AND bloom_filter_fp_chance = 0.01
> AND caching = {'keys': 'ALL', 'rows_per_partition': 'NONE'}
> AND comment = ''
> AND compaction = {'class':
> 'org.apache.cassandra.db.compaction.SizeTieredCompactionStrategy',
> 'max_threshold': '32', 'min_threshold': '4'}
> AND compression = {'chunk_length_in_kb': '64', 'class':
> 'org.apache.cassandra.io.compress.LZ4Compressor'}
> AND crc_check_chance = 1.0
> AND dclocal_read_repair_chance = 0.1
> AND default_time_to_live = 0
> AND gc_grace_seconds = 864000
> AND max_index_interval = 2048
> AND memtable_flush_period_in_ms = 0
> AND min_index_interval = 128
> AND read_repair_chance = 0.0
> AND speculative_retry = 'NONE';
> cqlsh> SELECT * FROM test.foos ;
> 2f
>
> (0 rows) {code}
> h1. Root Cause
> The root cause is a missing check for the existing column when the table
> comparator from the old version is BytesType.
> I have uploaded the data dir, use it to start up 3.0.29 and execute the
> commands will reproduce this bug.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-staging updated (0341f970a -> f19a9dab2)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard 0341f970a generate docs for 207dbf1f new f19a9dab2 generate docs for 207dbf1f This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (0341f970a) \ N -- N -- N refs/heads/asf-staging (f19a9dab2) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: site-ui/build/ui-bundle.zip | Bin 4881412 -> 4881412 bytes 1 file changed, 0 insertions(+), 0 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16565) Remove dependency on sigar
[ https://issues.apache.org/jira/browse/CASSANDRA-16565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779017#comment-17779017 ] Claude Warren edited comment on CASSANDRA-16565 at 10/25/23 11:49 AM: -- The OSHI library does not have a method to retrieve the maximum processes. The maximum process request is equivalent to "ulimit -u". The OSHI library also returns 64 bit longs rather thant 32 bit values as sigar does. This results in some differences in the tests. I have extracted the sigar code into an evaluation package and coded an OSHI replacement to verify that there are no differences in the results. Evaluation code for the differences between Sigar and OSHI can be found at: https://github.com/Aiven-Labs/compare_oshi_sigar was (Author: claudenw): The OSHI library does not have a method to retrieve the maximum processes. The maximum process request is equivalent to "ulimit -u". The OSHI library also returns 64 bit longs rather thant 32 bit values as sigar does. This results in some differences in the tests. I have extracted the sigar code into an evaluation package and coded an OSHI replacement to verify that there are no differences in the results. > Remove dependency on sigar > -- > > Key: CASSANDRA-16565 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16565 > Project: Cassandra > Issue Type: Improvement > Components: Build >Reporter: David Capwell >Assignee: Claude Warren >Priority: Normal > Fix For: 5.x > > > sigar is used to check if the environment has good settings for running C*, > but requires we bundle a lot of native libraries to perform this check (which > can also be done elsewhere). This project also appears to be dead as the > last commit was around 6 years ago. > With the move to resolve artifacts rather than commit them, removing this > dependency would remove majority of the artifacts fetched from GitHub. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16565) Remove dependency on sigar
[ https://issues.apache.org/jira/browse/CASSANDRA-16565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779479#comment-17779479 ] Claude Warren commented on CASSANDRA-16565: --- There are several checks. That is the only one not supported by OSHI > Remove dependency on sigar > -- > > Key: CASSANDRA-16565 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16565 > Project: Cassandra > Issue Type: Improvement > Components: Build >Reporter: David Capwell >Assignee: Claude Warren >Priority: Normal > Fix For: 5.x > > > sigar is used to check if the environment has good settings for running C*, > but requires we bundle a lot of native libraries to perform this check (which > can also be done elsewhere). This project also appears to be dead as the > last commit was around 6 years ago. > With the move to resolve artifacts rather than commit them, removing this > dependency would remove majority of the artifacts fetched from GitHub. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18946) Add cqlsh autocompletion for the vector data type
[
https://issues.apache.org/jira/browse/CASSANDRA-18946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andres de la Peña updated CASSANDRA-18946:
--
Component/s: Tool/cqlsh
> Add cqlsh autocompletion for the vector data type
> -
>
> Key: CASSANDRA-18946
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18946
> Project: Cassandra
> Issue Type: New Feature
> Components: Feature/Vector Search, Tool/cqlsh
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Low
> Fix For: 5.0-alpha2, 5.1
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Add cqlsh autocompletion for the vector data type, so we have completions
> such as:
> {code:java}
> cqlsh> CREATE TABLE t (v
> ascii boolean decimal float int set time tinyint
> varint
> bigintcounter doublefrozenlist smallint timestamp uuid
> vector
> blob date duration inet map text timeuuid varchar
> cqlsh> CREATE TABLE t (v vector<
> ascii boolean decimal float int set time tinyint
> varint
> bigintcounter doublefrozenlist smallint timestamp uuid
> vector
> blob date duration inet map text timeuuid varchar
> cqlsh> CREATE TABLE t (v vector
> cqlsh> INSERT INTO t(k, v) VALUES ( 0,
> )>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18960) Upgrade Python driver to 3.28.0
[
https://issues.apache.org/jira/browse/CASSANDRA-18960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andres de la Peña updated CASSANDRA-18960:
--
Fix Version/s: 5.0.x
5.x
> Upgrade Python driver to 3.28.0
> ---
>
> Key: CASSANDRA-18960
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18960
> Project: Cassandra
> Issue Type: Task
> Components: Feature/Vector Search, Tool/cqlsh
>Reporter: Andres de la Peña
>Priority: Normal
> Fix For: 5.0.x, 5.x
>
>
> The version of the Python driver that is used by cqlsh (3.25.0) doesn't
> entirely support the new vector data type introduced by CASSANDRA-18504.
> While we can perfectly write data, read vectors are presented as blobs:
> {code}
> > CREATE TABLE t (k int PRIMARY KEY, v vector);
> > INSERT INTO t(k, v) VALUES (0, [1, 2]);
> > SELECT * FROM t;
> k | v
> ---+-
> 0 | b'\x00\x00\x00\x01\x00\x00\x00\x02'
> {code}
> I think that would we fixed if we update the driver to (at least) 3.28.0,
> which includes support for the new vector data type.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-18960) Upgrade Python driver to 3.28.0
Andres de la Peña created CASSANDRA-18960:
-
Summary: Upgrade Python driver to 3.28.0
Key: CASSANDRA-18960
URL: https://issues.apache.org/jira/browse/CASSANDRA-18960
Project: Cassandra
Issue Type: Task
Components: Feature/Vector Search, Tool/cqlsh
Reporter: Andres de la Peña
The version of the Python driver that is used by cqlsh (3.25.0) doesn't
entirely support the new vector data type introduced by CASSANDRA-18504. While
we can perfectly write data, read vectors are presented as blobs:
{code}
> CREATE TABLE t (k int PRIMARY KEY, v vector);
> INSERT INTO t(k, v) VALUES (0, [1, 2]);
> SELECT * FROM t;
k | v
---+-
0 | b'\x00\x00\x00\x01\x00\x00\x00\x02'
{code}
I think that would we fixed if we update the driver to (at least) 3.28.0, which
includes support for the new vector data type.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18710) Test failure: org.apache.cassandra.io.DiskSpaceMetricsTest.testFlushSize-.jdk17 (from org.apache.cassandra.io.DiskSpaceMetricsTest-.jdk17)
[
https://issues.apache.org/jira/browse/CASSANDRA-18710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779468#comment-17779468
]
Branimir Lambov commented on CASSANDRA-18710:
-
So the {{KEYSPACE_PER_TEST}} fix for unexpected flushes no longer works after
CASSANDRA-17071? All of the tests that use it will be having intermittent
failures unless we find a way to block this.
> Test failure:
> org.apache.cassandra.io.DiskSpaceMetricsTest.testFlushSize-.jdk17 (from
> org.apache.cassandra.io.DiskSpaceMetricsTest-.jdk17)
> --
>
> Key: CASSANDRA-18710
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18710
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Ekaterina Dimitrova
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 5.0.x, 5.x
>
> Attachments: org.apache.cassandra.io.DiskSpaceMetricsTest.txt
>
>
> Seen here:
> [https://ci-cassandra.apache.org/job/Cassandra-trunk/1644/testReport/org.apache.cassandra.io/DiskSpaceMetricsTest/testFlushSize__jdk17/]
> h3.
> {code:java}
> Error Message
> expected:<7200.0> but was:<1367.83970468544>
> Stacktrace
> junit.framework.AssertionFailedError: expected:<7200.0> but
> was:<1367.83970468544> at
> org.apache.cassandra.io.DiskSpaceMetricsTest.testFlushSize(DiskSpaceMetricsTest.java:119)
> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method) at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16565) Remove dependency on sigar
[ https://issues.apache.org/jira/browse/CASSANDRA-16565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779465#comment-17779465 ] Brandon Williams commented on CASSANDRA-16565: -- bq. all modern Linuxes have a "/proc/PID/limits" file. The SystemInfo.warnIfRunningInDegradedMode method will parse that file on a Linux box If we are going to parse files on the machine, how much value is OSHI providing? > Remove dependency on sigar > -- > > Key: CASSANDRA-16565 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16565 > Project: Cassandra > Issue Type: Improvement > Components: Build >Reporter: David Capwell >Assignee: Claude Warren >Priority: Normal > Fix For: 5.x > > > sigar is used to check if the environment has good settings for running C*, > but requires we bundle a lot of native libraries to perform this check (which > can also be done elsewhere). This project also appears to be dead as the > last commit was around 6 years ago. > With the move to resolve artifacts rather than commit them, removing this > dependency would remove majority of the artifacts fetched from GitHub. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16565) Remove dependency on sigar
[ https://issues.apache.org/jira/browse/CASSANDRA-16565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779464#comment-17779464 ] Claude Warren commented on CASSANDRA-16565: --- I have submitted a pull request https://github.com/apache/cassandra/pull/2842 that achieves the following: Removed Sigar references from the build scripts and library. Removed SigarLibrary.java and replaced it with SystemInfo.java and updated the calls. Switched to [OSHI library|https://github.com/oshi/oshi] Due to the differences between the Sigar library and the OSHI library some changes in the "warnIfRunningInDegradedMode" method were necessary. There is no OSHI support for determining the maximum number of processes allowed. However, all modern Linuxes have a "/proc/PID/limits" file. The SystemInfo.warnIfRunningInDegradedMode method will parse that file on a Linux box and if not on a Linux box will return the default number of PIDs for Linux (1024). We should not return 0 as that is obviously wrong since at least 1 process is running, We can not return -1 because that is the historical value of UNLIMITED, or INFINITY as it was called in the SigarLibrary. Since we only officially support Linux and the number of processes is probably wrong for other cases, the check now declares a degraded mode if the system is anything but Linux (yes, Mac OS will now report running in degraded mode). But since this is a warning and developers know to expect it there should not be a problem. The logging message now indicates what values are expected when the value is not met. > Remove dependency on sigar > -- > > Key: CASSANDRA-16565 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16565 > Project: Cassandra > Issue Type: Improvement > Components: Build >Reporter: David Capwell >Assignee: Claude Warren >Priority: Normal > Fix For: 5.x > > > sigar is used to check if the environment has good settings for running C*, > but requires we bundle a lot of native libraries to perform this check (which > can also be done elsewhere). This project also appears to be dead as the > last commit was around 6 years ago. > With the move to resolve artifacts rather than commit them, removing this > dependency would remove majority of the artifacts fetched from GitHub. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18946) Add cqlsh autocompletion for the vector data type
[
https://issues.apache.org/jira/browse/CASSANDRA-18946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779462#comment-17779462
]
Andres de la Peña commented on CASSANDRA-18946:
---
Thanks for the review.
Committed to 5.0 as
[5eba52feb83d5cc68b7c2dea39eb64cad2e5338d|https://github.com/apache/cassandra/commit/5eba52feb83d5cc68b7c2dea39eb64cad2e5338d]
and merged to
[{{trunk}}|https://github.com/apache/cassandra/commit/e8c5fe31a28ec6e5aac9a87f3aad138d4e913494].
> Add cqlsh autocompletion for the vector data type
> -
>
> Key: CASSANDRA-18946
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18946
> Project: Cassandra
> Issue Type: New Feature
> Components: Feature/Vector Search
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Low
> Fix For: 5.0, 5.x
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Add cqlsh autocompletion for the vector data type, so we have completions
> such as:
> {code:java}
> cqlsh> CREATE TABLE t (v
> ascii boolean decimal float int set time tinyint
> varint
> bigintcounter doublefrozenlist smallint timestamp uuid
> vector
> blob date duration inet map text timeuuid varchar
> cqlsh> CREATE TABLE t (v vector<
> ascii boolean decimal float int set time tinyint
> varint
> bigintcounter doublefrozenlist smallint timestamp uuid
> vector
> blob date duration inet map text timeuuid varchar
> cqlsh> CREATE TABLE t (v vector
> cqlsh> INSERT INTO t(k, v) VALUES ( 0,
> )>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18946) Add cqlsh autocompletion for the vector data type
[
https://issues.apache.org/jira/browse/CASSANDRA-18946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andres de la Peña updated CASSANDRA-18946:
--
Fix Version/s: 5.0-alpha2
5.1
(was: 5.x)
(was: 5.0)
Source Control Link:
https://github.com/apache/cassandra/commit/5eba52feb83d5cc68b7c2dea39eb64cad2e5338d
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
> Add cqlsh autocompletion for the vector data type
> -
>
> Key: CASSANDRA-18946
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18946
> Project: Cassandra
> Issue Type: New Feature
> Components: Feature/Vector Search
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Low
> Fix For: 5.0-alpha2, 5.1
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Add cqlsh autocompletion for the vector data type, so we have completions
> such as:
> {code:java}
> cqlsh> CREATE TABLE t (v
> ascii boolean decimal float int set time tinyint
> varint
> bigintcounter doublefrozenlist smallint timestamp uuid
> vector
> blob date duration inet map text timeuuid varchar
> cqlsh> CREATE TABLE t (v vector<
> ascii boolean decimal float int set time tinyint
> varint
> bigintcounter doublefrozenlist smallint timestamp uuid
> vector
> blob date duration inet map text timeuuid varchar
> cqlsh> CREATE TABLE t (v vector
> cqlsh> INSERT INTO t(k, v) VALUES ( 0,
> )>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-staging updated (1bc910851 -> 0341f970a)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard 1bc910851 generate docs for 207dbf1f new 0341f970a generate docs for 207dbf1f This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (1bc910851) \ N -- N -- N refs/heads/asf-staging (0341f970a) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: content/search-index.js | 2 +- site-ui/build/ui-bundle.zip | Bin 4881412 -> 4881412 bytes 2 files changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-5.0 updated: Add cqlsh autocompletion for the vector data type
This is an automated email from the ASF dual-hosted git repository.
adelapena pushed a commit to branch cassandra-5.0
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/cassandra-5.0 by this push:
new 5eba52feb8 Add cqlsh autocompletion for the vector data type
5eba52feb8 is described below
commit 5eba52feb83d5cc68b7c2dea39eb64cad2e5338d
Author: Andrés de la Peña
AuthorDate: Fri Oct 20 13:31:25 2023 +0100
Add cqlsh autocompletion for the vector data type
patch by Andrés de la Peña; reviewed by Brandon Williams for CASSANDRA-18946
---
CHANGES.txt | 1 +
pylib/cqlshlib/cql3handling.py | 20 +---
pylib/cqlshlib/test/test_cqlsh_completion.py | 36
pylib/cqlshlib/test/test_cqlsh_output.py | 12 ++
pylib/cqlshlib/test/test_keyspace_init.cql | 30 ---
5 files changed, 73 insertions(+), 26 deletions(-)
diff --git a/CHANGES.txt b/CHANGES.txt
index 517a20cdb8..317954aafb 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
5.0-alpha2
+ * Add cqlsh autocompletion for the vector data type (CASSANDRA-18946)
* Fix nodetool tablehistograms output to avoid printing repeated information
and ensure at most two arguments (CASSANDRA-18955)
* Change the checksum algorithm SAI-related files use from CRC32 to CRC32C
(CASSANDRA-18836)
* Correctly remove Index.Group from IndexRegistry (CASSANDRA-18905)
diff --git a/pylib/cqlshlib/cql3handling.py b/pylib/cqlshlib/cql3handling.py
index 39b08fcb1b..3c6518a0b9 100644
--- a/pylib/cqlshlib/cql3handling.py
+++ b/pylib/cqlshlib/cql3handling.py
@@ -21,7 +21,7 @@ from cqlshlib.cqlhandling import CqlParsingRuleSet, Hint
simple_cql_types = {'ascii', 'bigint', 'blob', 'boolean', 'counter', 'date',
'decimal', 'double', 'duration', 'float',
'inet', 'int', 'smallint', 'text', 'time', 'timestamp',
'timeuuid', 'tinyint', 'uuid', 'varchar',
'varint'}
-simple_cql_types.difference_update(('set', 'map', 'list'))
+simple_cql_types.difference_update(('set', 'map', 'list', 'vector'))
cqldocs = helptopics.CQL3HelpTopics()
@@ -305,7 +305,7 @@ JUNK ::= /([
\t\r\f\v]+|(--|[/][/])[^\n\r]*([\n\r]|$)|[/][*].*?[*][/])/ ;
::= utname= ;
- ::= ( | |
| ) ( )? ;
+ ::= ( | |
| | ) ( )? ;
::= "MASKED" "WITH" ( "DEFAULT" |
);
@@ -321,6 +321,8 @@ JUNK ::= /([
\t\r\f\v]+|(--|[/][/])[^\n\r]*([\n\r]|$)|[/][*].*?[*][/])/ ;
| "frozen" "<" "set" "<" ">" ">"
;
+ ::= "vector" "<" "," ">" ;
+
::= ( ksname= dot="." )? cfname= ;
::= ( ksname= dot="." )?
mvname= ;
@@ -922,9 +924,9 @@ def insert_newval_completer(ctxt, cass):
return []
curcol = insertcols[len(valuesdone)]
coltype = layout.columns[curcol].cql_type
-if coltype in ('map', 'set'):
+if coltype.startswith('map<') or coltype.startswith('set<'):
return ['{']
-if coltype == 'list':
+if coltype.startswith('list<') or coltype.startswith('vector<'):
return ['[']
if coltype == 'boolean':
return ['true', 'false']
@@ -999,10 +1001,10 @@ def update_countername_completer(ctxt, cass):
coltype = layout.columns[curcol].cql_type
if coltype == 'counter':
return [maybe_escape_name(curcol)]
-if coltype in ('map', 'set'):
-return ["{"]
-if coltype == 'list':
-return ["["]
+if coltype.startswith('map<') or coltype.startswith('set<'):
+return ['{']
+if coltype.startswith('list<') or coltype.startswith('vector<'):
+return ['[']
return [Hint('' % coltype)]
@@ -1065,7 +1067,7 @@ def assignment_udt_field_completer(ctxt, cass):
def _is_usertype(layout, curcol):
coltype = layout.columns[curcol].cql_type
-return coltype not in simple_cql_types and coltype not in ('map', 'set',
'list')
+return coltype not in simple_cql_types and coltype not in ('map', 'set',
'list', 'vector')
def _usertype_fields(ctxt, cass, layout, curcol):
diff --git a/pylib/cqlshlib/test/test_cqlsh_completion.py
b/pylib/cqlshlib/test/test_cqlsh_completion.py
index db59297a97..3fe46e878f 100644
--- a/pylib/cqlshlib/test/test_cqlsh_completion.py
+++ b/pylib/cqlshlib/test/test_cqlsh_completion.py
@@ -210,17 +210,17 @@ class TestCqlshCompletion(CqlshCompletionCase):
self.trycompletions(
'INSERT INTO twenty_rows_composite_table (a, b, c) VALUES (',
-[''],
+choices=[''],
split_completed_lines=False)
self.trycompletions(
"INSERT INTO twenty_rows_composite_table (a, b, c) VALUES ('",
-[''],
+choices=[''],
split_completed_lines=False)
self.trycompletions(
"INSERT INTO twenty_rows_composite_table (a, b, c) VALUES ( 'eggs",
-[''],
+choices=[''],
[cassandra] 01/01: Merge branch 'cassandra-5.0' into trunk
This is an automated email from the ASF dual-hosted git repository.
adelapena pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra.git
commit e8c5fe31a28ec6e5aac9a87f3aad138d4e913494
Merge: 3d022d3c5f 5eba52feb8
Author: Andrés de la Peña
AuthorDate: Wed Oct 25 12:15:26 2023 +0100
Merge branch 'cassandra-5.0' into trunk
CHANGES.txt | 1 +
pylib/cqlshlib/cql3handling.py | 20 +---
pylib/cqlshlib/test/test_cqlsh_completion.py | 36
pylib/cqlshlib/test/test_cqlsh_output.py | 12 ++
pylib/cqlshlib/test/test_keyspace_init.cql | 30 ---
5 files changed, 73 insertions(+), 26 deletions(-)
diff --cc CHANGES.txt
index 763b8ecbbd,317954aafb..e3a8ff051b
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@@ -1,8 -1,5 +1,9 @@@
-5.0-alpha2
+5.1
+ * Add ELAPSED command to cqlsh (CASSANDRA-18861)
+ * Add the ability to disable bulk loading of SSTables (CASSANDRA-18781)
+ * Clean up obsolete functions and simplify cql_version handling in cqlsh
(CASSANDRA-18787)
+Merged from 5.0:
+ * Add cqlsh autocompletion for the vector data type (CASSANDRA-18946)
* Fix nodetool tablehistograms output to avoid printing repeated information
and ensure at most two arguments (CASSANDRA-18955)
* Change the checksum algorithm SAI-related files use from CRC32 to CRC32C
(CASSANDRA-18836)
* Correctly remove Index.Group from IndexRegistry (CASSANDRA-18905)
diff --cc pylib/cqlshlib/cql3handling.py
index 220c197629,3c6518a0b9..d19febceaf
--- a/pylib/cqlshlib/cql3handling.py
+++ b/pylib/cqlshlib/cql3handling.py
@@@ -21,8 -21,10 +21,8 @@@ from cqlshlib.cqlhandling import CqlPar
simple_cql_types = {'ascii', 'bigint', 'blob', 'boolean', 'counter', 'date',
'decimal', 'double', 'duration', 'float',
'inet', 'int', 'smallint', 'text', 'time', 'timestamp',
'timeuuid', 'tinyint', 'uuid', 'varchar',
'varint'}
- simple_cql_types.difference_update(('set', 'map', 'list'))
+ simple_cql_types.difference_update(('set', 'map', 'list', 'vector'))
-cqldocs = helptopics.CQL3HelpTopics()
-
class UnexpectedTableStructure(UserWarning):
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated (3d022d3c5f -> e8c5fe31a2)
This is an automated email from the ASF dual-hosted git repository. adelapena pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git from 3d022d3c5f Merge branch 'cassandra-5.0' into trunk new 5eba52feb8 Add cqlsh autocompletion for the vector data type new e8c5fe31a2 Merge branch 'cassandra-5.0' into trunk The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGES.txt | 1 + pylib/cqlshlib/cql3handling.py | 20 +--- pylib/cqlshlib/test/test_cqlsh_completion.py | 36 pylib/cqlshlib/test/test_cqlsh_output.py | 12 ++ pylib/cqlshlib/test/test_keyspace_init.cql | 30 --- 5 files changed, 73 insertions(+), 26 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18945) Unified Compaction Strategy is creating too many sstables
[
https://issues.apache.org/jira/browse/CASSANDRA-18945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Miklosovic updated CASSANDRA-18945:
--
Attachment: file_ucs_shenandoah.html
file_ucs_shenandoah_3.html
file_ucs_shenandoah_off_heap_memtable.html
file_ucs_shenandoah_on_heap_memtable_2.html
file_ucs_shenandoah_on_heap_memtable_3.html
> Unified Compaction Strategy is creating too many sstables
> -
>
> Key: CASSANDRA-18945
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18945
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Compaction
>Reporter: Branimir Lambov
>Assignee: Ethan Brown
>Priority: Normal
> Attachments: file_ucs_shenandoah.html, file_ucs_shenandoah_3.html,
> file_ucs_shenandoah_off_heap_memtable.html,
> file_ucs_shenandoah_on_heap_memtable_2.html,
> file_ucs_shenandoah_on_heap_memtable_3.html, key-value-oss.html
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The unified compaction strategy currently aims to create sstables with close
> to the same size, defaulting to 1 GiB. Unfortunately tests show that
> Cassandra starts to have performance problems when the number of sstables
> grows to the order of a thousand, and in particular that even 1 TiB of data
> with the default configuration is creating too many sstables for efficient
> processing. This matters even more for SAI, where the number of sstables in
> the system can have a proportional effect on the complexity of operations.
> It is quite easy to create a configuration option that allows sstables to
> take some part of the data growth by adding a multiplier to [the shard count
> calculation|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/compaction/UnifiedCompactionStrategy.md#sharding]
> formula, replacing
> {{2 ^ round(log2(d / (t * b))) * b}}
> with
> {{2 ^ round((1 - 휆) * log2(d / (t * b))) * b}},
> where 휆 is a parameter whose value is between 0 and 1.
> With this, a 휆 of 0.5 would mean that shard count and sstable size grow in
> parallel at the square root of the data size growth. 0 would result in no
> growth, and 1 in always using the same number of shards.
> It may also be valuable to introduce a threshold for engaging the base shard
> count to avoid splitting lowest-level sstables into fragments that are too
> small.
> Once both of these are in place, we can set defaults that better suit all
> node densities, including 10 TiB and beyond, for example:
> - target size of 1 GiB
> - 휆 of 1/3
> - base shard count of 4
> - minimum size 100 MiB
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18945) Unified Compaction Strategy is creating too many sstables
[
https://issues.apache.org/jira/browse/CASSANDRA-18945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779448#comment-17779448
]
Stefan Miklosovic commented on CASSANDRA-18945:
---
Interesting! I have to admit I was not comparing the various strategies, I
remember having UCS with kind of default setup and I saw ~100k writes like for
~2hours so I have not though anything is wrong with it.
I uploaded bunch of htmls with UCS and various
parameters.[^file_ucs_shenandoah.html]
> Unified Compaction Strategy is creating too many sstables
> -
>
> Key: CASSANDRA-18945
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18945
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Compaction
>Reporter: Branimir Lambov
>Assignee: Ethan Brown
>Priority: Normal
> Attachments: file_ucs_shenandoah.html, file_ucs_shenandoah_3.html,
> file_ucs_shenandoah_off_heap_memtable.html,
> file_ucs_shenandoah_on_heap_memtable_2.html,
> file_ucs_shenandoah_on_heap_memtable_3.html, key-value-oss.html
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The unified compaction strategy currently aims to create sstables with close
> to the same size, defaulting to 1 GiB. Unfortunately tests show that
> Cassandra starts to have performance problems when the number of sstables
> grows to the order of a thousand, and in particular that even 1 TiB of data
> with the default configuration is creating too many sstables for efficient
> processing. This matters even more for SAI, where the number of sstables in
> the system can have a proportional effect on the complexity of operations.
> It is quite easy to create a configuration option that allows sstables to
> take some part of the data growth by adding a multiplier to [the shard count
> calculation|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/compaction/UnifiedCompactionStrategy.md#sharding]
> formula, replacing
> {{2 ^ round(log2(d / (t * b))) * b}}
> with
> {{2 ^ round((1 - 휆) * log2(d / (t * b))) * b}},
> where 휆 is a parameter whose value is between 0 and 1.
> With this, a 휆 of 0.5 would mean that shard count and sstable size grow in
> parallel at the square root of the data size growth. 0 would result in no
> growth, and 1 in always using the same number of shards.
> It may also be valuable to introduce a threshold for engaging the base shard
> count to avoid splitting lowest-level sstables into fragments that are too
> small.
> Once both of these are in place, we can set defaults that better suit all
> node densities, including 10 TiB and beyond, for example:
> - target size of 1 GiB
> - 휆 of 1/3
> - base shard count of 4
> - minimum size 100 MiB
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18945) Unified Compaction Strategy is creating too many sstables
[
https://issues.apache.org/jira/browse/CASSANDRA-18945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779444#comment-17779444
]
Branimir Lambov commented on CASSANDRA-18945:
-
Attached [the result of a recent
benchmark|https://issues.apache.org/jira/secure/attachment/13063855/key-value-oss.html]
comparing the UCS default (green) to STCS (blue) and an option with larger
SSTable size (orange). The default UCS has worse results in the throughput
stage, but more importantly it is unable to serve the 110k ops/s during the 1:1
and read-only stages. I'm still investigating what causes these reads to be so
slow, but switching to 10GiB target fully fixes the problem (the two other
options the orange graph uses, 'base_shard_count': '1' and
'max_sstables_to_compact': '32', help but are not as significant on their own).
Rather than ask users to choose a target size based on their expected data
density, the database should be able to deal with this itself. Admitting some
of the growth into the sstable size is a good way to achieve that.
> Unified Compaction Strategy is creating too many sstables
> -
>
> Key: CASSANDRA-18945
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18945
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Compaction
>Reporter: Branimir Lambov
>Assignee: Ethan Brown
>Priority: Normal
> Attachments: key-value-oss.html
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The unified compaction strategy currently aims to create sstables with close
> to the same size, defaulting to 1 GiB. Unfortunately tests show that
> Cassandra starts to have performance problems when the number of sstables
> grows to the order of a thousand, and in particular that even 1 TiB of data
> with the default configuration is creating too many sstables for efficient
> processing. This matters even more for SAI, where the number of sstables in
> the system can have a proportional effect on the complexity of operations.
> It is quite easy to create a configuration option that allows sstables to
> take some part of the data growth by adding a multiplier to [the shard count
> calculation|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/compaction/UnifiedCompactionStrategy.md#sharding]
> formula, replacing
> {{2 ^ round(log2(d / (t * b))) * b}}
> with
> {{2 ^ round((1 - 휆) * log2(d / (t * b))) * b}},
> where 휆 is a parameter whose value is between 0 and 1.
> With this, a 휆 of 0.5 would mean that shard count and sstable size grow in
> parallel at the square root of the data size growth. 0 would result in no
> growth, and 1 in always using the same number of shards.
> It may also be valuable to introduce a threshold for engaging the base shard
> count to avoid splitting lowest-level sstables into fragments that are too
> small.
> Once both of these are in place, we can set defaults that better suit all
> node densities, including 10 TiB and beyond, for example:
> - target size of 1 GiB
> - 휆 of 1/3
> - base shard count of 4
> - minimum size 100 MiB
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18938) Map and possibly remove Deprecated code
[
https://issues.apache.org/jira/browse/CASSANDRA-18938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779379#comment-17779379
]
Stefan Miklosovic edited comment on CASSANDRA-18938 at 10/25/23 10:16 AM:
--
I used this script
{code:java}
#!/bin/bash
echo "||Deprecation||jmx/public||interface||notes||"
since=$1
for i in $(find . -type f -name '*.java' | xargs grep -n "@Deprecated(since =
\"${since}\"" | cut -d ":" -f1,2); do
path=$i
i="${i:1}"
i=$(echo $i | sed -r 's/:/#L/g')
public_facing="no"
if [ $(echo $i | egrep -e 'MBean|Config|Descriptor|nodetool' | wc -l) != "0"
]; then
public_facing="yes"
fi
interface="no"
if [ $(cat $(echo $path | cut -d":" -f1) | grep "^public interface" | wc -l)
!= "0" ]; then
interface="yes"
fi
echo
"|[$i|https://github.com/apache/cassandra/blob/3d022d3c5f2512e03c8c7fbc52de70afd058b2e7$i]|$public_facing|$interface|
|"
done
{code}
Calling it like
{code:java}
./script.sh 1.*
{code}
*Deprecated since 1.x*
||Deprecation||jmx/public||interface||notes||
|[/src/java/org/apache/cassandra/auth/Permission.java#L35|https://github.com/apache/cassandra/blob/3d022d3c5f2512e03c8c7fbc52de70afd058b2e7/src/java/org/apache/cassandra/auth/Permission.java#L35]|no|no|unused|
|[/src/java/org/apache/cassandra/auth/Permission.java#L38|https://github.com/apache/cassandra/blob/3d022d3c5f2512e03c8c7fbc52de70afd058b2e7/src/java/org/apache/cassandra/auth/Permission.java#L38]|no|no|unused|
|[/src/java/org/apache/cassandra/auth/Resources.java#L68|https://github.com/apache/cassandra/blob/3d022d3c5f2512e03c8c7fbc52de70afd058b2e7/src/java/org/apache/cassandra/auth/Resources.java#L68]|no|no|unused|
|[/src/java/org/apache/cassandra/auth/Resources.java#L71|https://github.com/apache/cassandra/blob/3d022d3c5f2512e03c8c7fbc52de70afd058b2e7/src/java/org/apache/cassandra/auth/Resources.java#L71]|no|no|unused|
|[/src/java/org/apache/cassandra/auth/Resources.java#L75|https://github.com/apache/cassandra/blob/3d022d3c5f2512e03c8c7fbc52de70afd058b2e7/src/java/org/apache/cassandra/auth/Resources.java#L75]|no|no|unused|
|[/src/java/org/apache/cassandra/locator/TokenMetadata.java#L353|https://github.com/apache/cassandra/blob/3d022d3c5f2512e03c8c7fbc52de70afd058b2e7/src/java/org/apache/cassandra/locator/TokenMetadata.java#L353]|no|no|used
only in tests|
|[/src/java/org/apache/cassandra/locator/TokenMetadata.java#L616|https://github.com/apache/cassandra/blob/3d022d3c5f2512e03c8c7fbc52de70afd058b2e7/src/java/org/apache/cassandra/locator/TokenMetadata.java#L616]|no|no|used
internally in private StorageService.getRemovalStatus|
|[/src/java/org/apache/cassandra/locator/TokenMetadata.java#L798|https://github.com/apache/cassandra/blob/3d022d3c5f2512e03c8c7fbc52de70afd058b2e7/src/java/org/apache/cassandra/locator/TokenMetadata.java#L798]|no|no|easily
replaceable|
|[/src/java/org/apache/cassandra/config/Config.java#L301|https://github.com/apache/cassandra/blob/3d022d3c5f2512e03c8c7fbc52de70afd058b2e7/src/java/org/apache/cassandra/config/Config.java#L301]|yes|no|not
used anywhere|
*Deprecated since 2.x*
||Deprecation||jmx/public||interface||notes||
|[/src/java/org/apache/cassandra/db/marshal/DateType.java#L43|https://github.com/apache/cassandra/blob/3d022d3c5f2512e03c8c7fbc52de70afd058b2e7/src/java/org/apache/cassandra/db/marshal/DateType.java#L43]|no|no|I
am not sure this should be removed as it is dealing with CQL types, we should
keep it there for ever|
|[/src/java/org/apache/cassandra/tools/nodetool/CfStats.java#L26|https://github.com/apache/cassandra/blob/3d022d3c5f2512e03c8c7fbc52de70afd058b2e7/src/java/org/apache/cassandra/tools/nodetool/CfStats.java#L26]|yes|no|just
alias command to tablestats|
|[/src/java/org/apache/cassandra/tools/nodetool/CfHistograms.java#L26|https://github.com/apache/cassandra/blob/3d022d3c5f2512e03c8c7fbc52de70afd058b2e7/src/java/org/apache/cassandra/tools/nodetool/CfHistograms.java#L26]|yes|no|just
alias command to tablehistograms|
|[/src/java/org/apache/cassandra/config/Config.java#L183|https://github.com/apache/cassandra/blob/3d022d3c5f2512e03c8c7fbc52de70afd058b2e7/src/java/org/apache/cassandra/config/Config.java#L183]|yes|no|unused|
|[/src/java/org/apache/cassandra/config/Config.java#L419|https://github.com/apache/cassandra/blob/3d022d3c5f2512e03c8c7fbc52de70afd058b2e7/src/java/org/apache/cassandra/config/Config.java#L419]|yes|no|unused|
|[/src/java/org/apache/cassandra/service/StorageServiceMBean.java#L217|https://github.com/apache/cassandra/blob/3d022d3c5f2512e03c8c7fbc52de70afd058b2e7/src/java/org/apache/cassandra/service/StorageServiceMBean.java#L217]|yes|yes|getEndpointToHostId
should be used as replacement|
|[/src/java/org/apache/cassandra/service/StorageServiceMBean.java#L416|https://github.com/apache/cassandra/blob/3d022d3c5f2512e03c8c7fbc52de70afd058b2e7/src/java/org/apache/cassandra/service/StorageServiceMBean.java#L416]|yes|yes|other
[jira] [Updated] (CASSANDRA-18945) Unified Compaction Strategy is creating too many sstables
[
https://issues.apache.org/jira/browse/CASSANDRA-18945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Branimir Lambov updated CASSANDRA-18945:
Attachment: key-value-oss.html
> Unified Compaction Strategy is creating too many sstables
> -
>
> Key: CASSANDRA-18945
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18945
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Compaction
>Reporter: Branimir Lambov
>Assignee: Ethan Brown
>Priority: Normal
> Attachments: key-value-oss.html
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The unified compaction strategy currently aims to create sstables with close
> to the same size, defaulting to 1 GiB. Unfortunately tests show that
> Cassandra starts to have performance problems when the number of sstables
> grows to the order of a thousand, and in particular that even 1 TiB of data
> with the default configuration is creating too many sstables for efficient
> processing. This matters even more for SAI, where the number of sstables in
> the system can have a proportional effect on the complexity of operations.
> It is quite easy to create a configuration option that allows sstables to
> take some part of the data growth by adding a multiplier to [the shard count
> calculation|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/compaction/UnifiedCompactionStrategy.md#sharding]
> formula, replacing
> {{2 ^ round(log2(d / (t * b))) * b}}
> with
> {{2 ^ round((1 - 휆) * log2(d / (t * b))) * b}},
> where 휆 is a parameter whose value is between 0 and 1.
> With this, a 휆 of 0.5 would mean that shard count and sstable size grow in
> parallel at the square root of the data size growth. 0 would result in no
> growth, and 1 in always using the same number of shards.
> It may also be valuable to introduce a threshold for engaging the base shard
> count to avoid splitting lowest-level sstables into fragments that are too
> small.
> Once both of these are in place, we can set defaults that better suit all
> node densities, including 10 TiB and beyond, for example:
> - target size of 1 GiB
> - 휆 of 1/3
> - base shard count of 4
> - minimum size 100 MiB
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18938) Map and possibly remove Deprecated code
[
https://issues.apache.org/jira/browse/CASSANDRA-18938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779379#comment-17779379
]
Stefan Miklosovic edited comment on CASSANDRA-18938 at 10/25/23 10:10 AM:
--
I used this script
{code:java}
#!/bin/bash
echo "||Deprecation||jmx/public||interface||notes||"
since=$1
for i in $(find . -type f -name '*.java' | xargs grep -n "@Deprecated(since =
\"${since}\"" | cut -d ":" -f1,2); do
path=$i
i="${i:1}"
i=$(echo $i | sed -r 's/:/#L/g')
public_facing="no"
if [ $(echo $i | egrep -e 'MBean|Config|Descriptor|nodetool' | wc -l) != "0"
]; then
public_facing="yes"
fi
interface="no"
if [ $(cat $(echo $path | cut -d":" -f1) | grep "^public interface" | wc -l)
!= "0" ]; then
interface="yes"
fi
echo
"|[$i|https://github.com/apache/cassandra/blob/trunk/$i]|$public_facing|$interface|
|"
done
{code}
Calling it like
{code:java}
./script.sh 1.*
{code}
*Deprecated since 1.x*
||Deprecation||jmx/public||interface||notes||
|[/src/java/org/apache/cassandra/auth/Permission.java#L35|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/auth/Permission.java#L35]|no|no|unused|
|[/src/java/org/apache/cassandra/auth/Permission.java#L38|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/auth/Permission.java#L38]|no|no|unused|
|[/src/java/org/apache/cassandra/auth/Resources.java#L68|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/auth/Resources.java#L68]|no|no|unused|
|[/src/java/org/apache/cassandra/auth/Resources.java#L71|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/auth/Resources.java#L71]|no|no|unused|
|[/src/java/org/apache/cassandra/auth/Resources.java#L75|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/auth/Resources.java#L75]|no|no|unused|
|[/src/java/org/apache/cassandra/locator/TokenMetadata.java#L353|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/locator/TokenMetadata.java#L353]|no|no|used
only in tests|
|[/src/java/org/apache/cassandra/locator/TokenMetadata.java#L616|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/locator/TokenMetadata.java#L616]|no|no|used
internally in private StorageService.getRemovalStatus|
|[/src/java/org/apache/cassandra/locator/TokenMetadata.java#L798|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/locator/TokenMetadata.java#L798]|no|no|easily
replaceable|
|[/src/java/org/apache/cassandra/config/Config.java#L301|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/config/Config.java#L301]|yes|no|not
used anywhere|
*Deprecated since 2.x*
||Deprecation||jmx/public||interface||notes||
|[/src/java/org/apache/cassandra/db/marshal/DateType.java#L43|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/db/marshal/DateType.java#L43]|no|no|I
am not sure this should be removed as it is dealing with CQL types, we should
keep it there for ever|
|[/src/java/org/apache/cassandra/tools/nodetool/CfStats.java#L26|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/tools/nodetool/CfStats.java#L26]|yes|no|just
alias command to tablestats|
|[/src/java/org/apache/cassandra/tools/nodetool/CfHistograms.java#L26|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/tools/nodetool/CfHistograms.java#L26]|yes|no|just
alias command to tablehistograms|
|[/src/java/org/apache/cassandra/config/Config.java#L183|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/config/Config.java#L183]|yes|no|unused|
|[/src/java/org/apache/cassandra/config/Config.java#L419|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/config/Config.java#L419]|yes|no|unused|
|[/src/java/org/apache/cassandra/service/StorageServiceMBean.java#L217|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/service/StorageServiceMBean.java#L217]|yes|yes|getEndpointToHostId
should be used as replacement|
|[/src/java/org/apache/cassandra/service/StorageServiceMBean.java#L416|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/service/StorageServiceMBean.java#L416]|yes|yes|other
version of scrub method should be used|
*Deprecated since 3.x*
||Deprecation||jmx/public||interface||notes||
|[/src/java/org/apache/cassandra/db/ColumnFamilyStore.java#L282|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/db/ColumnFamilyStore.java#L282]|no|no|
|
|[/src/java/org/apache/cassandra/db/ColumnFamilyStore.java#L924|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/db/ColumnFamilyStore.java#L924]|no|no|
|
[jira] [Updated] (CASSANDRA-18938) Map and possibly remove Deprecated code
[ https://issues.apache.org/jira/browse/CASSANDRA-18938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-18938: -- Fix Version/s: (was: 5.x) > Map and possibly remove Deprecated code > --- > > Key: CASSANDRA-18938 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18938 > Project: Cassandra > Issue Type: Epic > Components: Build >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Time Spent: 10m > Remaining Estimate: 0h > > This is follow-up of CASSANDRA-18912. We should scan the project and document > what was deprecated and when (based on "since" added to Deprecated > annotation). > Once this is done, we need to identify what should be removed and what should > stay. > It is questionable if this ticket will result in some actual code change. I > think we should firstly just map what was deprecated to have a bigger picture > where we are. Then we can discuss what to actually remove. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18959) Remove deprecated code in Cassandra 1.x and 2.x for 5.0
[ https://issues.apache.org/jira/browse/CASSANDRA-18959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-18959: -- Summary: Remove deprecated code in Cassandra 1.x and 2.x for 5.0 (was: Remove deprecated code from Cassandra 1.x and 2.x) > Remove deprecated code in Cassandra 1.x and 2.x for 5.0 > --- > > Key: CASSANDRA-18959 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18959 > Project: Cassandra > Issue Type: Task > Components: Legacy/Core >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 5.x > > > This ticket tracks removal of deprecations which were added in Cassandra 1.x > and 2.x for Cassandra 5 branch. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18938) Map and possibly remove Deprecated code
[ https://issues.apache.org/jira/browse/CASSANDRA-18938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-18938: -- Epic Name: deprecations-removal > Map and possibly remove Deprecated code > --- > > Key: CASSANDRA-18938 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18938 > Project: Cassandra > Issue Type: Epic > Components: Build >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > This is follow-up of CASSANDRA-18912. We should scan the project and document > what was deprecated and when (based on "since" added to Deprecated > annotation). > Once this is done, we need to identify what should be removed and what should > stay. > It is questionable if this ticket will result in some actual code change. I > think we should firstly just map what was deprecated to have a bigger picture > where we are. Then we can discuss what to actually remove. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18959) Remove deprecated code from Cassandra 1.x and 2.x
[ https://issues.apache.org/jira/browse/CASSANDRA-18959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-18959: -- Change Category: Code Clarity Complexity: Low Hanging Fruit Component/s: Legacy/Core Fix Version/s: 5.x Status: Open (was: Triage Needed) This tracks the removal of deprecations from Cassandra 1.x and 2.x in Cassandra 5 PR: https://github.com/apache/cassandra/pull/2841 > Remove deprecated code from Cassandra 1.x and 2.x > - > > Key: CASSANDRA-18959 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18959 > Project: Cassandra > Issue Type: Task > Components: Legacy/Core >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 5.x > > > This ticket tracks removal of deprecations which were added in Cassandra 1.x > and 2.x for Cassandra 5 branch. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18959) Remove deprecated code from Cassandra 1.x and 2.x
[ https://issues.apache.org/jira/browse/CASSANDRA-18959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-18959: -- Test and Documentation Plan: CI Status: Patch Available (was: In Progress) > Remove deprecated code from Cassandra 1.x and 2.x > - > > Key: CASSANDRA-18959 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18959 > Project: Cassandra > Issue Type: Task > Components: Legacy/Core >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 5.x > > > This ticket tracks removal of deprecations which were added in Cassandra 1.x > and 2.x for Cassandra 5 branch. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18938) Map and possibly remove Deprecated code
[ https://issues.apache.org/jira/browse/CASSANDRA-18938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779434#comment-17779434 ] Stefan Miklosovic edited comment on CASSANDRA-18938 at 10/25/23 9:45 AM: - I have created CASSANDRA-18959 to track the work, next will be 3.x etc ... We may keep this epic open as more into the future we go, more stuff we can remove, per major. We will just keep updating the tables in the first comment. was (Author: smiklosovic): I have created CASSANDRA-18959 to track the work, next will be 3.x etc ... We may keep this epic open as more into the future we go, more stuff we can remove, per major. > Map and possibly remove Deprecated code > --- > > Key: CASSANDRA-18938 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18938 > Project: Cassandra > Issue Type: Epic > Components: Build >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > This is follow-up of CASSANDRA-18912. We should scan the project and document > what was deprecated and when (based on "since" added to Deprecated > annotation). > Once this is done, we need to identify what should be removed and what should > stay. > It is questionable if this ticket will result in some actual code change. I > think we should firstly just map what was deprecated to have a bigger picture > where we are. Then we can discuss what to actually remove. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18938) Map and possibly remove Deprecated code
[ https://issues.apache.org/jira/browse/CASSANDRA-18938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779434#comment-17779434 ] Stefan Miklosovic commented on CASSANDRA-18938: --- I have created CASSANDRA-18959 to track the work, next will be 3.x etc ... We may keep this epic open as more into the future we go, more stuff we can remove, per major. > Map and possibly remove Deprecated code > --- > > Key: CASSANDRA-18938 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18938 > Project: Cassandra > Issue Type: Epic > Components: Build >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > This is follow-up of CASSANDRA-18912. We should scan the project and document > what was deprecated and when (based on "since" added to Deprecated > annotation). > Once this is done, we need to identify what should be removed and what should > stay. > It is questionable if this ticket will result in some actual code change. I > think we should firstly just map what was deprecated to have a bigger picture > where we are. Then we can discuss what to actually remove. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-18959) Remove deprecated code from Cassandra 1.x and 2.x
Stefan Miklosovic created CASSANDRA-18959: - Summary: Remove deprecated code from Cassandra 1.x and 2.x Key: CASSANDRA-18959 URL: https://issues.apache.org/jira/browse/CASSANDRA-18959 Project: Cassandra Issue Type: Task Reporter: Stefan Miklosovic Assignee: Stefan Miklosovic This ticket tracks removal of deprecations which were added in Cassandra 1.x and 2.x for Cassandra 5 branch. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18938) Map and possibly remove Deprecated code
[ https://issues.apache.org/jira/browse/CASSANDRA-18938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-18938: -- Issue Type: Epic (was: Task) > Map and possibly remove Deprecated code > --- > > Key: CASSANDRA-18938 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18938 > Project: Cassandra > Issue Type: Epic > Components: Build >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > This is follow-up of CASSANDRA-18912. We should scan the project and document > what was deprecated and when (based on "since" added to Deprecated > annotation). > Once this is done, we need to identify what should be removed and what should > stay. > It is questionable if this ticket will result in some actual code change. I > think we should firstly just map what was deprecated to have a bigger picture > where we are. Then we can discuss what to actually remove. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18942) Repeatable test runs
[ https://issues.apache.org/jira/browse/CASSANDRA-18942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779419#comment-17779419 ] Michael Semb Wever commented on CASSANDRA-18942: make sense, right direction! > Repeatable test runs > > > Key: CASSANDRA-18942 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18942 > Project: Cassandra > Issue Type: New Feature > Components: Build, CI >Reporter: Berenguer Blasi >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 5.0, 5.0.x > > Time Spent: 40m > Remaining Estimate: 0h > > It is our policy to loop new introduced tests to avoid introducing flakies. > We also want to add the possibility to repeat a test N number of times to > test robustness, debug flakies, etc. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18942) Repeatable test runs
[ https://issues.apache.org/jira/browse/CASSANDRA-18942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779411#comment-17779411 ] Berenguer Blasi edited comment on CASSANDRA-18942 at 10/25/23 8:44 AM: --- [~mck] can you please do a preliminary quick sanity check see if sthg like [this|https://ci-cassandra.apache.org/view/all/job/Cassandra-5.0-repeat/2/] looks good/makes sense? I still have to fix the j17 bug and see how I can go about keeping logs which at the moment get lost in docker and I don't know where I should store them yet... was (Author: bereng): [~mck] can you please do a sanity check see if sthg like [this|https://ci-cassandra.apache.org/view/all/job/Cassandra-5.0-repeat/2/] looks good? I still have to fix the j17 bug and see how I can go about keeping logs which at the moment get lost in docker and I don't know where I should store them yet... > Repeatable test runs > > > Key: CASSANDRA-18942 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18942 > Project: Cassandra > Issue Type: New Feature > Components: Build, CI >Reporter: Berenguer Blasi >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 5.0, 5.0.x > > > It is our policy to loop new introduced tests to avoid introducing flakies. > We also want to add the possibility to repeat a test N number of times to > test robustness, debug flakies, etc. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18942) Repeatable test runs
[ https://issues.apache.org/jira/browse/CASSANDRA-18942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779411#comment-17779411 ] Berenguer Blasi commented on CASSANDRA-18942: - [~mck] can you please do a sanity check see if sthg like [this|https://ci-cassandra.apache.org/view/all/job/Cassandra-5.0-repeat/2/] looks good? I still have to fix the j17 bug and see how I can go about keeping logs which at the moment get lost in docker and I don't know where I should store them yet... > Repeatable test runs > > > Key: CASSANDRA-18942 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18942 > Project: Cassandra > Issue Type: New Feature > Components: Build, CI >Reporter: Berenguer Blasi >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 5.0, 5.0.x > > > It is our policy to loop new introduced tests to avoid introducing flakies. > We also want to add the possibility to repeat a test N number of times to > test robustness, debug flakies, etc. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18866) Node sends multiple inflight echos
[ https://issues.apache.org/jira/browse/CASSANDRA-18866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779406#comment-17779406 ] Stefan Miklosovic commented on CASSANDRA-18866: --- [~brandon.williams] kindly pinging to check if there is any appetite left to try to fix this. > Node sends multiple inflight echos > -- > > Key: CASSANDRA-18866 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18866 > Project: Cassandra > Issue Type: Improvement > Components: Cluster/Gossip >Reporter: Cameron Zemek >Assignee: Cameron Zemek >Priority: Normal > Attachments: 18866-regression.patch, duplicates.log, echo.log > > > CASSANDRA-18854 rolled back the changes from CASSANDRA-18845. In particular, > 18845 had change to only allow 1 inflight ECHO request at a time. As per > 18854 some tests have an error rate due to this change. Creating this ticket > to discuss this further. As the current state also does not have retry logic, > it just allowing multiple ECHO requests inflight at the same time so less > likely that all ECHO will timeout or get lost. > With the change from 18845 adding in some extra logging to track what is > going on, I do see it retrying ECHOs. Likewise, I patched a node to drop ECHO > requests from a node and also see it retrying ECHOs when it doesn't get a > reply. > Therefore, I think the problem is more specific than the dropping of one ECHO > request. Yes there no retry logic for failed ECHO requests, but this is the > case even both before and after 18845. ECHO requests are only sent via gossip > verb handlers calling applyStateLocally. In these failed tests I therefore > assuming their cases where it won't call markAlive when other nodes consider > the node UP but its marked DOWN by a node. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18938) Map and possibly remove Deprecated code
[
https://issues.apache.org/jira/browse/CASSANDRA-18938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779379#comment-17779379
]
Stefan Miklosovic edited comment on CASSANDRA-18938 at 10/25/23 7:49 AM:
-
I used this script
{code:java}
#!/bin/bash
echo "||Deprecation||jmx/public||interface||notes||"
since=$1
for i in $(find . -type f -name '*.java' | xargs grep -n "@Deprecated(since =
\"${since}\"" | cut -d ":" -f1,2); do
path=$i
i="${i:1}"
i=$(echo $i | sed -r 's/:/#L/g')
public_facing="no"
if [ $(echo $i | egrep -e 'MBean|Config|Descriptor|nodetool' | wc -l) != "0"
]; then
public_facing="yes"
fi
interface="no"
if [ $(cat $(echo $path | cut -d":" -f1) | grep "^public interface" | wc -l)
!= "0" ]; then
interface="yes"
fi
echo
"|[$i|https://github.com/apache/cassandra/blob/trunk/$i]|$public_facing|$interface|
|"
done
{code}
Calling it like
{code:java}
./script.sh 1.*
{code}
*Deprecated since 1.x*
||Deprecation||jmx/public||interface||notes||
|[/src/java/org/apache/cassandra/auth/Permission.java#L35|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/auth/Permission.java#L35]|no|no|unused|
|[/src/java/org/apache/cassandra/auth/Permission.java#L38|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/auth/Permission.java#L38]|no|no|unused|
|[/src/java/org/apache/cassandra/auth/Resources.java#L68|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/auth/Resources.java#L68]|no|no|unused|
|[/src/java/org/apache/cassandra/auth/Resources.java#L71|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/auth/Resources.java#L71]|no|no|unused|
|[/src/java/org/apache/cassandra/auth/Resources.java#L75|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/auth/Resources.java#L75]|no|no|unused|
|[/src/java/org/apache/cassandra/locator/TokenMetadata.java#L353|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/locator/TokenMetadata.java#L353]|no|no|used
only in tests|
|[/src/java/org/apache/cassandra/locator/TokenMetadata.java#L616|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/locator/TokenMetadata.java#L616]|no|no|used
internally in private StorageService.getRemovalStatus|
|[/src/java/org/apache/cassandra/locator/TokenMetadata.java#L798|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/locator/TokenMetadata.java#L798]|no|no|easily
replaceable|
|[/src/java/org/apache/cassandra/config/Config.java#L301|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/config/Config.java#L301]|yes|no|not
used anywhere|
*Deprecated since 2.x*
||Deprecation||jmx/public||interface||notes||
|[/src/java/org/apache/cassandra/db/marshal/DateType.java#L43|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/db/marshal/DateType.java#L43]|no|no|I
am not sure this should be removed as it is dealing with CQL types, we should
keep it there for ever|
|[/src/java/org/apache/cassandra/tools/nodetool/CfStats.java#L26|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/tools/nodetool/CfStats.java#L26]|yes|no|just
alias command to tablestats|
|[/src/java/org/apache/cassandra/tools/nodetool/CfHistograms.java#L26|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/tools/nodetool/CfHistograms.java#L26]|yes|no|just
alias command to tablehistograms|
|[/src/java/org/apache/cassandra/config/Config.java#L183|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/config/Config.java#L183]|yes|no|unused|
|[/src/java/org/apache/cassandra/config/Config.java#L419|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/config/Config.java#L419]|yes|no|unused|
|[/src/java/org/apache/cassandra/service/StorageServiceMBean.java#L217|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/service/StorageServiceMBean.java#L217]|yes|yes|getEndpointToHostId
should be used as replacement|
|[/src/java/org/apache/cassandra/service/StorageServiceMBean.java#L416|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/service/StorageServiceMBean.java#L416]|yes|yes|other
version of scrub method should be used|
*Deprecated since 3.x*
||Deprecation||jmx/public||interface||notes||
|[/src/java/org/apache/cassandra/db/ColumnFamilyStore.java#L282|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/db/ColumnFamilyStore.java#L282]|no|no|
|
|[/src/java/org/apache/cassandra/db/ColumnFamilyStore.java#L924|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/db/ColumnFamilyStore.java#L924]|no|no|
|
[jira] [Comment Edited] (CASSANDRA-18938) Map and possibly remove Deprecated code
[
https://issues.apache.org/jira/browse/CASSANDRA-18938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779379#comment-17779379
]
Stefan Miklosovic edited comment on CASSANDRA-18938 at 10/25/23 7:45 AM:
-
I used this script
{code:java}
#!/bin/bash
echo "||Deprecation||jmx/public||interface||notes||"
since=$1
for i in $(find . -type f -name '*.java' | xargs grep -n "@Deprecated(since =
\"${since}\"" | cut -d ":" -f1,2); do
path=$i
i="${i:1}"
i=$(echo $i | sed -r 's/:/#L/g')
public_facing="no"
if [ $(echo $i | egrep -e 'MBean|Config|Descriptor|nodetool' | wc -l) != "0"
]; then
public_facing="yes"
fi
interface="no"
if [ $(cat $(echo $path | cut -d":" -f1) | grep "^public interface" | wc -l)
!= "0" ]; then
interface="yes"
fi
echo
"|[$i|https://github.com/apache/cassandra/blob/trunk/$i]|$public_facing|$interface|
|"
done
{code}
Calling it like
{code:java}
./script.sh 1.*
{code}
*Deprecated since 1.x*
||Deprecation||jmx/public||interface||notes||
|[/src/java/org/apache/cassandra/auth/Permission.java#L35|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/auth/Permission.java#L35]|no|no|unused|
|[/src/java/org/apache/cassandra/auth/Permission.java#L38|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/auth/Permission.java#L38]|no|no|unused|
|[/src/java/org/apache/cassandra/auth/Resources.java#L68|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/auth/Resources.java#L68]|no|no|unused|
|[/src/java/org/apache/cassandra/auth/Resources.java#L71|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/auth/Resources.java#L71]|no|no|unused|
|[/src/java/org/apache/cassandra/auth/Resources.java#L75|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/auth/Resources.java#L75]|no|no|unused|
|[/src/java/org/apache/cassandra/locator/TokenMetadata.java#L353|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/locator/TokenMetadata.java#L353]|no|no|used
only in tests|
|[/src/java/org/apache/cassandra/locator/TokenMetadata.java#L616|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/locator/TokenMetadata.java#L616]|no|no|used
internally in private StorageService.getRemovalStatus|
|[/src/java/org/apache/cassandra/locator/TokenMetadata.java#L798|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/locator/TokenMetadata.java#L798]|no|no|easily
replaceable|
|[/src/java/org/apache/cassandra/config/Config.java#L301|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/config/Config.java#L301]|yes|no|not
used anywhere|
*Deprecated since 2.x*
||Deprecation||jmx/public||interface||notes||
|[/src/java/org/apache/cassandra/db/marshal/DateType.java#L43|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/db/marshal/DateType.java#L43]|no|no|I
am not sure this should be removed as it is dealing with CQL types, we should
keep it there for ever|
|[/src/java/org/apache/cassandra/tools/nodetool/CfStats.java#L26|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/tools/nodetool/CfStats.java#L26]|yes|no|
|
|[/src/java/org/apache/cassandra/tools/nodetool/CfHistograms.java#L26|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/tools/nodetool/CfHistograms.java#L26]|yes|no|
|
|[/src/java/org/apache/cassandra/config/Config.java#L183|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/config/Config.java#L183]|yes|no|
|
|[/src/java/org/apache/cassandra/config/Config.java#L419|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/config/Config.java#L419]|yes|no|
|
|[/src/java/org/apache/cassandra/service/StorageServiceMBean.java#L217|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/service/StorageServiceMBean.java#L217]|yes|yes|
|
|[/src/java/org/apache/cassandra/service/StorageServiceMBean.java#L416|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/service/StorageServiceMBean.java#L416]|yes|yes|
|
*Deprecated since 3.x*
||Deprecation||jmx/public||interface||notes||
|[/src/java/org/apache/cassandra/db/ColumnFamilyStore.java#L282|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/db/ColumnFamilyStore.java#L282]|no|no|
|
|[/src/java/org/apache/cassandra/db/ColumnFamilyStore.java#L924|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/db/ColumnFamilyStore.java#L924]|no|no|
|
|[/src/java/org/apache/cassandra/db/ColumnFamilyStoreMBean.java#L43|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/db/ColumnFamilyStoreMBean.java#L43]|yes|yes|
|
[cassandra-website] branch asf-staging updated (d609eb7e8 -> 1bc910851)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard d609eb7e8 generate docs for 207dbf1f new 1bc910851 generate docs for 207dbf1f This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (d609eb7e8) \ N -- N -- N refs/heads/asf-staging (1bc910851) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: site-ui/build/ui-bundle.zip | Bin 4881412 -> 4881412 bytes 1 file changed, 0 insertions(+), 0 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18938) Map and possibly remove Deprecated code
[
https://issues.apache.org/jira/browse/CASSANDRA-18938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779379#comment-17779379
]
Stefan Miklosovic edited comment on CASSANDRA-18938 at 10/25/23 7:28 AM:
-
I used this script
{code:java}
#!/bin/bash
echo "||Deprecation||jmx/public||interface||notes||"
since=$1
for i in $(find . -type f -name '*.java' | xargs grep -n "@Deprecated(since =
\"${since}\"" | cut -d ":" -f1,2); do
path=$i
i="${i:1}"
i=$(echo $i | sed -r 's/:/#L/g')
public_facing="no"
if [ $(echo $i | egrep -e 'MBean|Config|Descriptor|nodetool' | wc -l) != "0"
]; then
public_facing="yes"
fi
interface="no"
if [ $(cat $(echo $path | cut -d":" -f1) | grep "^public interface" | wc -l)
!= "0" ]; then
interface="yes"
fi
echo
"|[$i|https://github.com/apache/cassandra/blob/trunk/$i]|$public_facing|$interface|
|"
done
{code}
Calling it like
{code:java}
./script.sh 1.*
{code}
*Deprecated since 1.x*
||Deprecation||jmx/public||interface||notes||
|[/src/java/org/apache/cassandra/auth/Permission.java#L35|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/auth/Permission.java#L35]|no|no|
|
|[/src/java/org/apache/cassandra/auth/Permission.java#L38|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/auth/Permission.java#L38]|no|no|
|
|[/src/java/org/apache/cassandra/auth/Resources.java#L68|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/auth/Resources.java#L68]|no|no|
|
|[/src/java/org/apache/cassandra/auth/Resources.java#L71|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/auth/Resources.java#L71]|no|no|
|
|[/src/java/org/apache/cassandra/auth/Resources.java#L75|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/auth/Resources.java#L75]|no|no|
|
|[/src/java/org/apache/cassandra/locator/TokenMetadata.java#L353|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/locator/TokenMetadata.java#L353]|no|no|
|
|[/src/java/org/apache/cassandra/locator/TokenMetadata.java#L616|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/locator/TokenMetadata.java#L616]|no|no|
|
|[/src/java/org/apache/cassandra/locator/TokenMetadata.java#L798|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/locator/TokenMetadata.java#L798]|no|no|
|
|[/src/java/org/apache/cassandra/config/Config.java#L301|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/config/Config.java#L301]|yes|no|
|
*Deprecated since 2.x*
||Deprecation||jmx/public||interface||notes||
|[/src/java/org/apache/cassandra/db/marshal/DateType.java#L43|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/db/marshal/DateType.java#L43]|no|no|I
am not sure this should be removed as it is dealing with CQL types, we should
keep it there for ever|
|[/src/java/org/apache/cassandra/tools/nodetool/CfStats.java#L26|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/tools/nodetool/CfStats.java#L26]|yes|no|
|
|[/src/java/org/apache/cassandra/tools/nodetool/CfHistograms.java#L26|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/tools/nodetool/CfHistograms.java#L26]|yes|no|
|
|[/src/java/org/apache/cassandra/config/Config.java#L183|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/config/Config.java#L183]|yes|no|
|
|[/src/java/org/apache/cassandra/config/Config.java#L419|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/config/Config.java#L419]|yes|no|
|
|[/src/java/org/apache/cassandra/service/StorageServiceMBean.java#L217|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/service/StorageServiceMBean.java#L217]|yes|yes|
|
|[/src/java/org/apache/cassandra/service/StorageServiceMBean.java#L416|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/service/StorageServiceMBean.java#L416]|yes|yes|
|
*Deprecated since 3.x*
||Deprecation||jmx/public||interface||notes||
|[/src/java/org/apache/cassandra/db/ColumnFamilyStore.java#L282|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/db/ColumnFamilyStore.java#L282]|no|no|
|
|[/src/java/org/apache/cassandra/db/ColumnFamilyStore.java#L924|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/db/ColumnFamilyStore.java#L924]|no|no|
|
|[/src/java/org/apache/cassandra/db/ColumnFamilyStoreMBean.java#L43|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/db/ColumnFamilyStoreMBean.java#L43]|yes|yes|
|
|[/src/java/org/apache/cassandra/db/filter/RowFilter.java#L470|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/db/filter/RowFilter.java#L470]|no|no|
|
[jira] [Comment Edited] (CASSANDRA-18938) Map and possibly remove Deprecated code
[
https://issues.apache.org/jira/browse/CASSANDRA-18938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779379#comment-17779379
]
Stefan Miklosovic edited comment on CASSANDRA-18938 at 10/25/23 7:25 AM:
-
I used this script
{code:java}
#!/bin/bash
echo "||Deprecation||jmx/public||interface||notes||"
since=$1
for i in $(find . -type f -name '*.java' | xargs grep -n "@Deprecated(since =
\"${since}\"" | cut -d ":" -f1,2); do
path=$i
i="${i:1}"
i=$(echo $i | sed -r 's/:/#L/g')
public_facing="no"
if [ $(echo $i | egrep -e 'MBean|Config|Descriptor' | wc -l) != "0" ]; then
public_facing="yes"
fi
interface="no"
if [ $(cat $(echo $path | cut -d":" -f1) | grep "^public interface" | wc -l)
!= "0" ]; then
interface="yes"
fi
echo
"|[$i|https://github.com/apache/cassandra/blob/trunk/$i]|$public_facing|$interface|
|"
done
{code}
Calling it like
{code:java}
./script.sh 1.*
{code}
*Deprecated since 1.x*
||Deprecation||jmx/public||interface||notes||
|[/src/java/org/apache/cassandra/auth/Permission.java#L35|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/auth/Permission.java#L35]|no|no|
|
|[/src/java/org/apache/cassandra/auth/Permission.java#L38|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/auth/Permission.java#L38]|no|no|
|
|[/src/java/org/apache/cassandra/auth/Resources.java#L68|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/auth/Resources.java#L68]|no|no|
|
|[/src/java/org/apache/cassandra/auth/Resources.java#L71|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/auth/Resources.java#L71]|no|no|
|
|[/src/java/org/apache/cassandra/auth/Resources.java#L75|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/auth/Resources.java#L75]|no|no|
|
|[/src/java/org/apache/cassandra/locator/TokenMetadata.java#L353|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/locator/TokenMetadata.java#L353]|no|no|
|
|[/src/java/org/apache/cassandra/locator/TokenMetadata.java#L616|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/locator/TokenMetadata.java#L616]|no|no|
|
|[/src/java/org/apache/cassandra/locator/TokenMetadata.java#L798|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/locator/TokenMetadata.java#L798]|no|no|
|
|[/src/java/org/apache/cassandra/config/Config.java#L301|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/config/Config.java#L301]|yes|no|
|
*Deprecated since 2.x*
||Deprecation||jmx/public||interface||notes||
|[/src/java/org/apache/cassandra/db/marshal/DateType.java#L43|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/db/marshal/DateType.java#L43]|no|no|I
am not sure this should be removed as it is dealing with CQL types, we should
keep it there for ever|
|[/src/java/org/apache/cassandra/tools/nodetool/CfStats.java#L26|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/tools/nodetool/CfStats.java#L26]|yes|no|
|
|[/src/java/org/apache/cassandra/tools/nodetool/CfHistograms.java#L26|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/tools/nodetool/CfHistograms.java#L26]|yes|no|
|
|[/src/java/org/apache/cassandra/config/Config.java#L183|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/config/Config.java#L183]|yes|no|
|
|[/src/java/org/apache/cassandra/config/Config.java#L419|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/config/Config.java#L419]|yes|no|
|
|[/src/java/org/apache/cassandra/service/StorageServiceMBean.java#L217|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/service/StorageServiceMBean.java#L217]|yes|yes|
|
|[/src/java/org/apache/cassandra/service/StorageServiceMBean.java#L416|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/service/StorageServiceMBean.java#L416]|yes|yes|
|
*Deprecated since 3.x*
||Deprecation||jmx/public||interface||notes||
|[/src/java/org/apache/cassandra/db/ColumnFamilyStore.java#L282|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/db/ColumnFamilyStore.java#L282]|no|no|
|
|[/src/java/org/apache/cassandra/db/ColumnFamilyStore.java#L924|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/db/ColumnFamilyStore.java#L924]|no|no|
|
|[/src/java/org/apache/cassandra/db/ColumnFamilyStoreMBean.java#L43|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/db/ColumnFamilyStoreMBean.java#L43]|yes|yes|
|
|[/src/java/org/apache/cassandra/db/filter/RowFilter.java#L470|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/db/filter/RowFilter.java#L470]|no|no|
|
[jira] [Comment Edited] (CASSANDRA-18938) Map and possibly remove Deprecated code
[
https://issues.apache.org/jira/browse/CASSANDRA-18938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779379#comment-17779379
]
Stefan Miklosovic edited comment on CASSANDRA-18938 at 10/25/23 7:23 AM:
-
I used this script
{code:java}
#!/bin/bash
echo "||Deprecation||jmx/public||interface||notes||"
since=$1
for i in $(find . -type f -name '*.java' | xargs grep -n "@Deprecated(since =
\"${since}\"" | cut -d ":" -f1,2); do
path=$i
i="${i:1}"
i=$(echo $i | sed -r 's/:/#L/g')
public_facing="no"
if [ $(echo $i | egrep -e 'MBean|Config|Descriptor' | wc -l) != "0" ]; then
public_facing="yes"
fi
interface="no"
if [ $(cat $(echo $path | cut -d":" -f1) | grep "^public interface" | wc -l)
!= "0" ]; then
interface="yes"
fi
echo
"|[$i|https://github.com/apache/cassandra/blob/trunk/$i]|$public_facing|$interface|
|"
done
{code}
Calling it like
{code:java}
./script.sh 1.*
{code}
*Deprecated since 1.x*
||Deprecation||jmx/public||interface||notes||
|[/src/java/org/apache/cassandra/auth/Permission.java#L35|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/auth/Permission.java#L35]|no|no|
|
|[/src/java/org/apache/cassandra/auth/Permission.java#L38|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/auth/Permission.java#L38]|no|no|
|
|[/src/java/org/apache/cassandra/auth/Resources.java#L68|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/auth/Resources.java#L68]|no|no|
|
|[/src/java/org/apache/cassandra/auth/Resources.java#L71|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/auth/Resources.java#L71]|no|no|
|
|[/src/java/org/apache/cassandra/auth/Resources.java#L75|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/auth/Resources.java#L75]|no|no|
|
|[/src/java/org/apache/cassandra/locator/TokenMetadata.java#L353|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/locator/TokenMetadata.java#L353]|no|no|
|
|[/src/java/org/apache/cassandra/locator/TokenMetadata.java#L616|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/locator/TokenMetadata.java#L616]|no|no|
|
|[/src/java/org/apache/cassandra/locator/TokenMetadata.java#L798|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/locator/TokenMetadata.java#L798]|no|no|
|
|[/src/java/org/apache/cassandra/config/Config.java#L301|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/config/Config.java#L301]|yes|no|
|
*Deprecated since 2.x*
||Deprecation||jmx/public||interface||notes||
|[/src/java/org/apache/cassandra/db/marshal/DateType.java#L43|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/db/marshal/DateType.java#L43]|no|no|I
am not sure this should be removed as it is dealing with CQL types, we should
keep it there for ever|
|[/src/java/org/apache/cassandra/tools/nodetool/CfStats.java#L26|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/tools/nodetool/CfStats.java#L26]|no|no|
|
|[/src/java/org/apache/cassandra/tools/nodetool/CfHistograms.java#L26|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/tools/nodetool/CfHistograms.java#L26]|no|no|
|
|[/src/java/org/apache/cassandra/config/Config.java#L183|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/config/Config.java#L183]|yes|no|
|
|[/src/java/org/apache/cassandra/config/Config.java#L419|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/config/Config.java#L419]|yes|no|
|
|[/src/java/org/apache/cassandra/service/StorageServiceMBean.java#L217|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/service/StorageServiceMBean.java#L217]|yes|yes|
|
|[/src/java/org/apache/cassandra/service/StorageServiceMBean.java#L416|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/service/StorageServiceMBean.java#L416]|yes|yes|
|
*Deprecated since 3.x*
||Deprecation||jmx/public||interface||notes||
|[/src/java/org/apache/cassandra/db/ColumnFamilyStore.java#L282|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/db/ColumnFamilyStore.java#L282]|no|no|
|
|[/src/java/org/apache/cassandra/db/ColumnFamilyStore.java#L924|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/db/ColumnFamilyStore.java#L924]|no|no|
|
|[/src/java/org/apache/cassandra/db/ColumnFamilyStoreMBean.java#L43|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/db/ColumnFamilyStoreMBean.java#L43]|yes|yes|
|
|[/src/java/org/apache/cassandra/db/filter/RowFilter.java#L470|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/db/filter/RowFilter.java#L470]|no|no|
|
[jira] [Comment Edited] (CASSANDRA-18938) Map and possibly remove Deprecated code
[
https://issues.apache.org/jira/browse/CASSANDRA-18938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779379#comment-17779379
]
Stefan Miklosovic edited comment on CASSANDRA-18938 at 10/25/23 7:20 AM:
-
I used this script
{code}
#!/bin/bash
echo "||Deprecation||jmx/public||interface||notes||"
since=$1
for i in $(find . -type f -name '*.java' | xargs grep -n "@Deprecated(since =
\"${since}\"" | cut -d ":" -f1,2); do
path=$i
i="${i:1}"
i=$(echo $i | sed -r 's/:/#L/g')
public_facing="no"
if [ $(echo $i | egrep -e 'MBean|Config|Descriptor' | wc -l) != "0" ]; then
public_facing="yes"
fi
interface="no"
if [ $(cat $(echo $path | cut -d":" -f1) | grep "^public interface" | wc -l)
!= "0" ]; then
interface="yes"
fi
echo
"|[$i|https://github.com/apache/cassandra/blob/trunk/$i]|$public_facing|$interface|
|"
done
{code}
Calling it like
{code}
./script.sh 1.*
{code}
*Deprecated since 1.x*
||Deprecation||jmx/public||interface||notes||
|[/src/java/org/apache/cassandra/auth/Permission.java#L35|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/auth/Permission.java#L35]|no|no|
|
|[/src/java/org/apache/cassandra/auth/Permission.java#L38|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/auth/Permission.java#L38]|no|no|
|
|[/src/java/org/apache/cassandra/auth/Resources.java#L68|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/auth/Resources.java#L68]|no|no|
|
|[/src/java/org/apache/cassandra/auth/Resources.java#L71|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/auth/Resources.java#L71]|no|no|
|
|[/src/java/org/apache/cassandra/auth/Resources.java#L75|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/auth/Resources.java#L75]|no|no|
|
|[/src/java/org/apache/cassandra/locator/TokenMetadata.java#L353|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/locator/TokenMetadata.java#L353]|no|no|
|
|[/src/java/org/apache/cassandra/locator/TokenMetadata.java#L616|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/locator/TokenMetadata.java#L616]|no|no|
|
|[/src/java/org/apache/cassandra/locator/TokenMetadata.java#L798|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/locator/TokenMetadata.java#L798]|no|no|
|
|[/src/java/org/apache/cassandra/config/Config.java#L301|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/config/Config.java#L301]|yes|no|
|
*Deprecated since 2.x*
||Deprecation||jmx/public||interface||notes||
|[/src/java/org/apache/cassandra/db/marshal/DateType.java#L43|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/db/marshal/DateType.java#L43]|no|no|
|
|[/src/java/org/apache/cassandra/tools/nodetool/CfStats.java#L26|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/tools/nodetool/CfStats.java#L26]|no|no|
|
|[/src/java/org/apache/cassandra/tools/nodetool/CfHistograms.java#L26|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/tools/nodetool/CfHistograms.java#L26]|no|no|
|
|[/src/java/org/apache/cassandra/config/Config.java#L183|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/config/Config.java#L183]|yes|no|
|
|[/src/java/org/apache/cassandra/config/Config.java#L419|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/config/Config.java#L419]|yes|no|
|
|[/src/java/org/apache/cassandra/service/StorageServiceMBean.java#L217|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/service/StorageServiceMBean.java#L217]|yes|yes|
|
|[/src/java/org/apache/cassandra/service/StorageServiceMBean.java#L416|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/service/StorageServiceMBean.java#L416]|yes|yes|
|
*Deprecated since 3.x*
||Deprecation||jmx/public||interface||notes||
|[/src/java/org/apache/cassandra/db/ColumnFamilyStore.java#L282|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/db/ColumnFamilyStore.java#L282]|no|no|
|
|[/src/java/org/apache/cassandra/db/ColumnFamilyStore.java#L924|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/db/ColumnFamilyStore.java#L924]|no|no|
|
|[/src/java/org/apache/cassandra/db/ColumnFamilyStoreMBean.java#L43|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/db/ColumnFamilyStoreMBean.java#L43]|yes|yes|
|
|[/src/java/org/apache/cassandra/db/filter/RowFilter.java#L470|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/db/filter/RowFilter.java#L470]|no|no|
|
[jira] [Commented] (CASSANDRA-18938) Map and possibly remove Deprecated code
[ https://issues.apache.org/jira/browse/CASSANDRA-18938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779379#comment-17779379 ] Stefan Miklosovic commented on CASSANDRA-18938: --- *Deprecated since 1.x* ||Deprecation||jmx/public||interface||notes|| |[/src/java/org/apache/cassandra/auth/Permission.java#L35|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/auth/Permission.java#L35]|no|no| | |[/src/java/org/apache/cassandra/auth/Permission.java#L38|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/auth/Permission.java#L38]|no|no| | |[/src/java/org/apache/cassandra/auth/Resources.java#L68|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/auth/Resources.java#L68]|no|no| | |[/src/java/org/apache/cassandra/auth/Resources.java#L71|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/auth/Resources.java#L71]|no|no| | |[/src/java/org/apache/cassandra/auth/Resources.java#L75|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/auth/Resources.java#L75]|no|no| | |[/src/java/org/apache/cassandra/locator/TokenMetadata.java#L353|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/locator/TokenMetadata.java#L353]|no|no| | |[/src/java/org/apache/cassandra/locator/TokenMetadata.java#L616|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/locator/TokenMetadata.java#L616]|no|no| | |[/src/java/org/apache/cassandra/locator/TokenMetadata.java#L798|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/locator/TokenMetadata.java#L798]|no|no| | |[/src/java/org/apache/cassandra/config/Config.java#L301|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/config/Config.java#L301]|yes|no| | *Deprecated since 2.x* ||Deprecation||jmx/public||interface||notes|| |[/src/java/org/apache/cassandra/db/marshal/DateType.java#L43|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/db/marshal/DateType.java#L43]|no|no| | |[/src/java/org/apache/cassandra/tools/nodetool/CfStats.java#L26|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/tools/nodetool/CfStats.java#L26]|no|no| | |[/src/java/org/apache/cassandra/tools/nodetool/CfHistograms.java#L26|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/tools/nodetool/CfHistograms.java#L26]|no|no| | |[/src/java/org/apache/cassandra/config/Config.java#L183|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/config/Config.java#L183]|yes|no| | |[/src/java/org/apache/cassandra/config/Config.java#L419|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/config/Config.java#L419]|yes|no| | |[/src/java/org/apache/cassandra/service/StorageServiceMBean.java#L217|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/service/StorageServiceMBean.java#L217]|yes|yes| | |[/src/java/org/apache/cassandra/service/StorageServiceMBean.java#L416|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/service/StorageServiceMBean.java#L416]|yes|yes| | *Deprecated since 3.x* ||Deprecation||jmx/public||interface||notes|| |[/src/java/org/apache/cassandra/db/ColumnFamilyStore.java#L282|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/db/ColumnFamilyStore.java#L282]|no|no| | |[/src/java/org/apache/cassandra/db/ColumnFamilyStore.java#L924|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/db/ColumnFamilyStore.java#L924]|no|no| | |[/src/java/org/apache/cassandra/db/ColumnFamilyStoreMBean.java#L43|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/db/ColumnFamilyStoreMBean.java#L43]|yes|yes| | |[/src/java/org/apache/cassandra/db/filter/RowFilter.java#L470|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/db/filter/RowFilter.java#L470]|no|no| | |[/src/java/org/apache/cassandra/schema/CompressionParams.java#L85|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/schema/CompressionParams.java#L85]|no|no| | |[/src/java/org/apache/cassandra/config/Config.java#L794|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/config/Config.java#L794]|yes|no| | |[/src/java/org/apache/cassandra/config/Config.java#L834|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/config/Config.java#L834]|yes|no| | |[/src/java/org/apache/cassandra/service/StorageService.java#L343|https://github.com/apache/cassandra/blob/trunk//src/java/org/apache/cassandra/service/StorageService.java#L343]|no|no| |
[jira] [Commented] (CASSANDRA-18955) TableHistograms output a lot of repeated information
[ https://issues.apache.org/jira/browse/CASSANDRA-18955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779371#comment-17779371 ] Maxwell Guo commented on CASSANDRA-18955: - Thanks everyone. > TableHistograms output a lot of repeated information > > > Key: CASSANDRA-18955 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18955 > Project: Cassandra > Issue Type: Bug > Components: Tool/nodetool >Reporter: Maxwell Guo >Assignee: Maxwell Guo >Priority: Normal > Fix For: 5.0-alpha2, 5.1 > > Attachments: 1.png > > > This patch aims to fix two issues: > 1. the original output of nodetool tablehistograms with no tables specified > is wrong , the output will contains many repeated informations. See the > picture below. > The reason is that for > [tablesList.keys()|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/tools/nodetool/TableHistograms.java#L80] > will give a Multiset output as tablesList is a Multimap. > 2. as we have DISCUSS for "Change the useage of nodetool tablehistograms" , > for arguments more than two, the output of tablehistograms will be all of the > tables, it's a bug that we should fix. We can see that the > [description|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/tools/nodetool/TableHistograms.java#L42] > of tablehistograms is ,out put the statistic histograms for the given table. > and the format of the argument is like > [tthis|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/tools/nodetool/TableHistograms.java#L45] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18955) TableHistograms output a lot of repeated information
[ https://issues.apache.org/jira/browse/CASSANDRA-18955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779357#comment-17779357 ] Stefan Miklosovic commented on CASSANDRA-18955: --- +1. I fixed the nits. > TableHistograms output a lot of repeated information > > > Key: CASSANDRA-18955 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18955 > Project: Cassandra > Issue Type: Bug > Components: Tool/nodetool >Reporter: Maxwell Guo >Assignee: Maxwell Guo >Priority: Normal > Fix For: 5.x > > Attachments: 1.png > > > This patch aims to fix two issues: > 1. the original output of nodetool tablehistograms with no tables specified > is wrong , the output will contains many repeated informations. See the > picture below. > The reason is that for > [tablesList.keys()|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/tools/nodetool/TableHistograms.java#L80] > will give a Multiset output as tablesList is a Multimap. > 2. as we have DISCUSS for "Change the useage of nodetool tablehistograms" , > for arguments more than two, the output of tablehistograms will be all of the > tables, it's a bug that we should fix. We can see that the > [description|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/tools/nodetool/TableHistograms.java#L42] > of tablehistograms is ,out put the statistic histograms for the given table. > and the format of the argument is like > [tthis|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/tools/nodetool/TableHistograms.java#L45] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18955) TableHistograms output a lot of repeated information
[ https://issues.apache.org/jira/browse/CASSANDRA-18955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-18955: -- Status: Ready to Commit (was: Review In Progress) > TableHistograms output a lot of repeated information > > > Key: CASSANDRA-18955 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18955 > Project: Cassandra > Issue Type: Bug > Components: Tool/nodetool >Reporter: Maxwell Guo >Assignee: Maxwell Guo >Priority: Normal > Fix For: 5.x > > Attachments: 1.png > > > This patch aims to fix two issues: > 1. the original output of nodetool tablehistograms with no tables specified > is wrong , the output will contains many repeated informations. See the > picture below. > The reason is that for > [tablesList.keys()|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/tools/nodetool/TableHistograms.java#L80] > will give a Multiset output as tablesList is a Multimap. > 2. as we have DISCUSS for "Change the useage of nodetool tablehistograms" , > for arguments more than two, the output of tablehistograms will be all of the > tables, it's a bug that we should fix. We can see that the > [description|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/tools/nodetool/TableHistograms.java#L42] > of tablehistograms is ,out put the statistic histograms for the given table. > and the format of the argument is like > [tthis|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/tools/nodetool/TableHistograms.java#L45] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18955) TableHistograms output a lot of repeated information
[ https://issues.apache.org/jira/browse/CASSANDRA-18955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-18955: -- Fix Version/s: 5.0-alpha2 5.1 (was: 5.x) Since Version: NA Source Control Link: https://github.com/apache/cassandra/commit/0c7410a9da1281dd4f7a70a0668903ebb61bda58 Resolution: Fixed Status: Resolved (was: Ready to Commit) > TableHistograms output a lot of repeated information > > > Key: CASSANDRA-18955 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18955 > Project: Cassandra > Issue Type: Bug > Components: Tool/nodetool >Reporter: Maxwell Guo >Assignee: Maxwell Guo >Priority: Normal > Fix For: 5.0-alpha2, 5.1 > > Attachments: 1.png > > > This patch aims to fix two issues: > 1. the original output of nodetool tablehistograms with no tables specified > is wrong , the output will contains many repeated informations. See the > picture below. > The reason is that for > [tablesList.keys()|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/tools/nodetool/TableHistograms.java#L80] > will give a Multiset output as tablesList is a Multimap. > 2. as we have DISCUSS for "Change the useage of nodetool tablehistograms" , > for arguments more than two, the output of tablehistograms will be all of the > tables, it's a bug that we should fix. We can see that the > [description|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/tools/nodetool/TableHistograms.java#L42] > of tablehistograms is ,out put the statistic histograms for the given table. > and the format of the argument is like > [tthis|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/tools/nodetool/TableHistograms.java#L45] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-5.0 updated (9ffb838d03 -> 0c7410a9da)
This is an automated email from the ASF dual-hosted git repository. smiklosovic pushed a change to branch cassandra-5.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git from 9ffb838d03 Merge branch 'cassandra-4.1' into cassandra-5.0 add 0c7410a9da Fix nodetool tablehistograms output to avoid printing repeated information and ensure at most two arguments No new revisions were added by this update. Summary of changes: CHANGES.txt| 1 + .../cassandra/tools/nodetool/TableHistograms.java | 23 +++- .../tools/nodetool/TableHistogramsTest.java| 152 + 3 files changed, 170 insertions(+), 6 deletions(-) create mode 100644 test/unit/org/apache/cassandra/tools/nodetool/TableHistogramsTest.java - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated (b094303ac2 -> 3d022d3c5f)
This is an automated email from the ASF dual-hosted git repository. smiklosovic pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git from b094303ac2 Merge branch 'cassandra-5.0' into trunk add 0c7410a9da Fix nodetool tablehistograms output to avoid printing repeated information and ensure at most two arguments new 3d022d3c5f Merge branch 'cassandra-5.0' into trunk The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGES.txt| 1 + .../cassandra/tools/nodetool/TableHistograms.java | 23 +++- .../tools/nodetool/TableHistogramsTest.java| 152 + 3 files changed, 170 insertions(+), 6 deletions(-) create mode 100644 test/unit/org/apache/cassandra/tools/nodetool/TableHistogramsTest.java - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-5.0' into trunk
This is an automated email from the ASF dual-hosted git repository. smiklosovic pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 3d022d3c5f2512e03c8c7fbc52de70afd058b2e7 Merge: b094303ac2 0c7410a9da Author: Stefan Miklosovic AuthorDate: Wed Oct 25 08:40:37 2023 +0200 Merge branch 'cassandra-5.0' into trunk CHANGES.txt| 1 + .../cassandra/tools/nodetool/TableHistograms.java | 23 +++- .../tools/nodetool/TableHistogramsTest.java| 152 + 3 files changed, 170 insertions(+), 6 deletions(-) diff --cc CHANGES.txt index 4c7d4ef721,517a20cdb8..763b8ecbbd --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -1,8 -1,5 +1,9 @@@ -5.0-alpha2 +5.1 + * Add ELAPSED command to cqlsh (CASSANDRA-18861) + * Add the ability to disable bulk loading of SSTables (CASSANDRA-18781) + * Clean up obsolete functions and simplify cql_version handling in cqlsh (CASSANDRA-18787) +Merged from 5.0: + * Fix nodetool tablehistograms output to avoid printing repeated information and ensure at most two arguments (CASSANDRA-18955) * Change the checksum algorithm SAI-related files use from CRC32 to CRC32C (CASSANDRA-18836) * Correctly remove Index.Group from IndexRegistry (CASSANDRA-18905) * Fix vector type to support DDM's mask_default function (CASSANDRA-18889) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18872) Remove deprecated crc_check_chance in compression params
[ https://issues.apache.org/jira/browse/CASSANDRA-18872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-18872: -- Status: Needs Committer (was: Patch Available) > Remove deprecated crc_check_chance in compression params > > > Key: CASSANDRA-18872 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18872 > Project: Cassandra > Issue Type: Task > Components: Feature/Compression, Legacy/CQL >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 5.x > > Time Spent: 20m > Remaining Estimate: 0h > > crc_check_chance was moved from compression parameters and it is a standalone > table parameter. This was done in times of 3.0 so it is now time to get rid > of that in 5.0. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18872) Remove deprecated crc_check_chance in compression params
[ https://issues.apache.org/jira/browse/CASSANDRA-18872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-18872: -- Status: Patch Available (was: In Progress) > Remove deprecated crc_check_chance in compression params > > > Key: CASSANDRA-18872 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18872 > Project: Cassandra > Issue Type: Task > Components: Feature/Compression, Legacy/CQL >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 5.x > > Time Spent: 20m > Remaining Estimate: 0h > > crc_check_chance was moved from compression parameters and it is a standalone > table parameter. This was done in times of 3.0 so it is now time to get rid > of that in 5.0. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18872) Remove deprecated crc_check_chance in compression params
[ https://issues.apache.org/jira/browse/CASSANDRA-18872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779343#comment-17779343 ] Stefan Miklosovic commented on CASSANDRA-18872: --- [j17 trunk|https://app.circleci.com/pipelines/github/instaclustr/cassandra/3394/workflows/138625f9-187b-42a1-811b-ace2a0ca4520] [j11 trunk|https://app.circleci.com/pipelines/github/instaclustr/cassandra/3394/workflows/a4ddd52b-b86d-499e-9219-6c8c4b745dda] [j17 5.0|https://app.circleci.com/pipelines/github/instaclustr/cassandra/3386/workflows/1f51189c-3f8d-4cf4-8720-10d90af307e1] [j11 5.0|https://app.circleci.com/pipelines/github/instaclustr/cassandra/3386/workflows/16f68769-2e12-41d1-8e28-0c764a9ea2a7] I fixed the docs as part of this PR, [~blambov]. Anything to add or are we good to ship it? [~blambov], [~jlewandowski] > Remove deprecated crc_check_chance in compression params > > > Key: CASSANDRA-18872 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18872 > Project: Cassandra > Issue Type: Task > Components: Feature/Compression, Legacy/CQL >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 5.x > > Time Spent: 20m > Remaining Estimate: 0h > > crc_check_chance was moved from compression parameters and it is a standalone > table parameter. This was done in times of 3.0 so it is now time to get rid > of that in 5.0. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18955) TableHistograms output a lot of repeated information
[ https://issues.apache.org/jira/browse/CASSANDRA-18955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-18955: -- Reviewers: Brandon Williams, Stefan Miklosovic (was: Brandon Williams) Status: Review In Progress (was: Needs Committer) > TableHistograms output a lot of repeated information > > > Key: CASSANDRA-18955 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18955 > Project: Cassandra > Issue Type: Bug > Components: Tool/nodetool >Reporter: Maxwell Guo >Assignee: Maxwell Guo >Priority: Normal > Fix For: 5.x > > Attachments: 1.png > > > This patch aims to fix two issues: > 1. the original output of nodetool tablehistograms with no tables specified > is wrong , the output will contains many repeated informations. See the > picture below. > The reason is that for > [tablesList.keys()|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/tools/nodetool/TableHistograms.java#L80] > will give a Multiset output as tablesList is a Multimap. > 2. as we have DISCUSS for "Change the useage of nodetool tablehistograms" , > for arguments more than two, the output of tablehistograms will be all of the > tables, it's a bug that we should fix. We can see that the > [description|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/tools/nodetool/TableHistograms.java#L42] > of tablehistograms is ,out put the statistic histograms for the given table. > and the format of the argument is like > [tthis|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/tools/nodetool/TableHistograms.java#L45] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
