[jira] [Comment Edited] (CASSANDRA-18969) Pre-release required legal changes for cassandra-java-driver
[
https://issues.apache.org/jira/browse/CASSANDRA-18969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17785375#comment-17785375
]
Henry Hughes edited comment on CASSANDRA-18969 at 11/13/23 6:07 AM:
{quote}are there any releases that bundle dependencies (like shaded jars
published to maven central) ?{quote}
Yes one of the published artifacts is
[java-driver-core-shaded|https://central.sonatype.com/artifact/com.datastax.oss/java-driver-core-shaded]
which includes shaded versions of [netty and
jackson|https://github.com/apache/cassandra-java-driver/blob/4.x/core-shaded/pom.xml#L152],
jackson doesn't have a NOTICE file but netty has [a pretty long
one|https://github.com/netty/netty/blob/4.1/NOTICE.txt].
There is also a dependency on
[java-driver-shaded-guava|https://github.com/datastax/java-driver-shaded-guava],
but this was not part of the donation so may be out of scope for this ticket.
was (Author: JIRAUSER301149):
{quote}are there any releases that bundle dependencies (like shaded jars
published to maven central) ?{quote}
Yes there is
[java-driver-core-shaded|https://central.sonatype.com/artifact/com.datastax.oss/java-driver-core-shaded]
which includes shaded versions of [netty and
jackson|https://github.com/apache/cassandra-java-driver/blob/4.x/core-shaded/pom.xml#L152],
jackson doesn't have a NOTICE file but netty has [a pretty long
one|https://github.com/netty/netty/blob/4.1/NOTICE.txt].
There is also a dependency on
[java-driver-shaded-guava|https://github.com/datastax/java-driver-shaded-guava],
but this was not part of the donation so may be out of scope for this ticket.
> Pre-release required legal changes for cassandra-java-driver
>
>
> Key: CASSANDRA-18969
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18969
> Project: Cassandra
> Issue Type: Sub-task
> Components: Client/java-driver
>Reporter: Michael Semb Wever
>Priority: Urgent
> Time Spent: 15h 50m
> Remaining Estimate: 0h
>
> TODO
> * there is still code copyrighted to others that isn't mentioned in LICENSE
> (e.g. ci/install-jdk.sh )
> * "© DataStax" still appears in the README
> * -spotbugs is LGPL, in 4.x, and not correctly made provided scope-
> * add any BSD/MIT deps to LICENCE
> * -ensure copyright headers are on all files, use rat plugin-
> * ensure NOTICE propagates NOTICES
> In short…
> {quote}
> LICENSE must contain the ASL, plus references to all code that includes
> someone else's copyright, and all BSD and MIT dependencies (including
> transitive).
> NOTICE must the standard header, plus the shorten content of any NOTICE file
> (minus its header) found in any ASL dependency (including transitive).
> {quote}
> These things must be done before a release.
> Cat X deps we included as build tool by using scope provided we should put a
> test in to ensure they work at runtime without the dep doesn't regress in the
> future.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18969) Pre-release required legal changes for cassandra-java-driver
[
https://issues.apache.org/jira/browse/CASSANDRA-18969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17785375#comment-17785375
]
Henry Hughes commented on CASSANDRA-18969:
--
{quote}are there any releases that bundle dependencies (like shaded jars
published to maven central) ?{quote}
Yes there is
[java-driver-core-shaded|https://central.sonatype.com/artifact/com.datastax.oss/java-driver-core-shaded]
which includes shaded versions of [netty and
jackson|https://github.com/apache/cassandra-java-driver/blob/4.x/core-shaded/pom.xml#L152],
jackson doesn't have a NOTICE file but netty has [a pretty long
one|https://github.com/netty/netty/blob/4.1/NOTICE.txt].
There is also a dependency on
[java-driver-shaded-guava|https://github.com/datastax/java-driver-shaded-guava],
but this was not part of the donation so may be out of scope for this ticket.
> Pre-release required legal changes for cassandra-java-driver
>
>
> Key: CASSANDRA-18969
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18969
> Project: Cassandra
> Issue Type: Sub-task
> Components: Client/java-driver
>Reporter: Michael Semb Wever
>Priority: Urgent
> Time Spent: 15h 50m
> Remaining Estimate: 0h
>
> TODO
> * there is still code copyrighted to others that isn't mentioned in LICENSE
> (e.g. ci/install-jdk.sh )
> * "© DataStax" still appears in the README
> * -spotbugs is LGPL, in 4.x, and not correctly made provided scope-
> * add any BSD/MIT deps to LICENCE
> * -ensure copyright headers are on all files, use rat plugin-
> * ensure NOTICE propagates NOTICES
> In short…
> {quote}
> LICENSE must contain the ASL, plus references to all code that includes
> someone else's copyright, and all BSD and MIT dependencies (including
> transitive).
> NOTICE must the standard header, plus the shorten content of any NOTICE file
> (minus its header) found in any ASL dependency (including transitive).
> {quote}
> These things must be done before a release.
> Cat X deps we included as build tool by using scope provided we should put a
> test in to ensure they work at runtime without the dep doesn't regress in the
> future.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19001) Check whether the startup warnings for unknown modules represent a legit problem or cosmetic issue
[
https://issues.apache.org/jira/browse/CASSANDRA-19001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17785338#comment-17785338
]
Ekaterina Dimitrova commented on CASSANDRA-19001:
-
I did not get any response to my github issues question to chronicle.
The closest I found by searching into the repos was:
[https://github.com/OpenHFT/Chronicle-Queue/blob/9f03bc69b8f0ec36c505108bcc2b8370e6bde798/docs/antora/modules/demos/pages/message-history.adoc#L69]
Mentioning errors, but I need to test it
[https://github.com/OpenHFT/Chronicle-Wire/commit/eeb1004a9635240492e3bb0d100d03737f22300f]
- the commit is about performance, not sure whether if we remove those there
won't be errors... need to be checked
[https://github.com/OpenHFT/Chronicle-Wire/commit/9fc82fe42d414710e655ca9985eb2c151f8d38cb]
- mentions that those are needed to make it possible to run the demos in the
repo.
So this was from high-level digging in the repos. I need to look into the
details of how this relates to us.
> Check whether the startup warnings for unknown modules represent a legit
> problem or cosmetic issue
> --
>
> Key: CASSANDRA-19001
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19001
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Other
>Reporter: Ekaterina Dimitrova
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 4.0.x, 4.1.x, 5.0-beta, 5.0.x, 5.x
>
>
> During the 5.0 alpha 2 release
> [vote|https://lists.apache.org/thread/lt3x0obr5cpbcydf5490pj6b2q0mz5zr],
> [~paulo] raised the following concerns:
> {code:java}
> Launched a tarball-based 5.0-alpha2 container on top of
> "eclipse-temurin:17-jre-focal" and the server starts up fine, can run
> nodetool and cqlsh.
> I got these seemingly harmless JDK17 warnings during startup and when
> running nodetool (no warnings on JDK11):
> WARNING: Unknown module: jdk.attach specified to --add-exports
> WARNING: Unknown module: jdk.compiler specified to --add-exports
> WARNING: Unknown module: jdk.compiler specified to --add-opens
> WARNING: A terminally deprecated method in java.lang.System has been called
> WARNING: System::setSecurityManager has been called by
> org.apache.cassandra.security.ThreadAwareSecurityManager
> (file:/opt/cassandra/lib/apache-cassandra-5.0-alpha2-SNAPSHOT.jar)
> WARNING: Please consider reporting this to the maintainers of
> org.apache.cassandra.security.ThreadAwareSecurityManager
> WARNING: System::setSecurityManager will be removed in a future release
> Anybody knows if these warnings are legit/expected ? We can create
> follow-up tickets if needed.
> $ java --version
> openjdk 17.0.9 2023-10-17
> OpenJDK Runtime Environment Temurin-17.0.9+9 (build 17.0.9+9)
> OpenJDK 64-Bit Server VM Temurin-17.0.9+9 (build 17.0.9+9, mixed mode,
> sharing)
> {code}
> {code:java}
> Clarification: - When running nodetool only the "Unknown module" warnings
> show up. All warnings show up during startup.{code}
> We need to verify whether this presents a real problem in the features where
> those modules are expected to be used, or if it is a false alarm.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19019) DESC TYPE forgets to quote UDT's field names
[ https://issues.apache.org/jira/browse/CASSANDRA-19019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-19019: -- Resolution: Duplicate Status: Resolved (was: Triage Needed) > DESC TYPE forgets to quote UDT's field names > > > Key: CASSANDRA-19019 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19019 > Project: Cassandra > Issue Type: Bug >Reporter: Nadav Har'El >Priority: Normal > > If I create a type with > *CREATE TYPE "Quoted_KS"."udt_@@@" (a int, "field_!!!" text)* > and then run DESC TYPE "Quoted_KS"."udt_@@@" I get: > *CREATE TYPE "Quoted_KS"."udt_@@@" (a int, field_!!! text)* > Note the missing quotes around the non-alphanumeric field name, which does > need quoting. If I'll try to run this command, it won't work. > Tested on Cassandra 4.1. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19019) DESC TYPE forgets to quote UDT's field names
[
https://issues.apache.org/jira/browse/CASSANDRA-19019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17785316#comment-17785316
]
Stefan Miklosovic commented on CASSANDRA-19019:
---
This does not reproduce on 4.1.2
{code}
cqlsh> CREATE KEYSPACE "Quoted_KS" WITH replication = {'class':
'SimpleStrategy', 'replication_factor': 1};
cqlsh> CREATE TYPE "Quoted_KS"."udt_@@@" (a int, "field_!!!" text);
cqlsh> DESC TYPE "Quoted_KS"."udt_@@@";
CREATE TYPE "Quoted_KS"."udt_@@@" (
a int,
"field_!!!" text
);
{code}
> DESC TYPE forgets to quote UDT's field names
>
>
> Key: CASSANDRA-19019
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19019
> Project: Cassandra
> Issue Type: Bug
>Reporter: Nadav Har'El
>Priority: Normal
>
> If I create a type with
> *CREATE TYPE "Quoted_KS"."udt_@@@" (a int, "field_!!!" text)*
> and then run DESC TYPE "Quoted_KS"."udt_@@@" I get:
> *CREATE TYPE "Quoted_KS"."udt_@@@" (a int, field_!!! text)*
> Note the missing quotes around the non-alphanumeric field name, which does
> need quoting. If I'll try to run this command, it won't work.
> Tested on Cassandra 4.1.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19019) DESC TYPE forgets to quote UDT's field names
[ https://issues.apache.org/jira/browse/CASSANDRA-19019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17785315#comment-17785315 ] Stefan Miklosovic commented on CASSANDRA-19019: --- I think this was fixed in CASSANDRA-17918 which is in 4.1.2. https://github.com/apache/cassandra/commit/75194201f1f06d120f246f6fad025ca5f672943d [~nyh] could you check that so we can eventually close this one as a duplicate? > DESC TYPE forgets to quote UDT's field names > > > Key: CASSANDRA-19019 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19019 > Project: Cassandra > Issue Type: Bug >Reporter: Nadav Har'El >Priority: Normal > > If I create a type with > *CREATE TYPE "Quoted_KS"."udt_@@@" (a int, "field_!!!" text)* > and then run DESC TYPE "Quoted_KS"."udt_@@@" I get: > *CREATE TYPE "Quoted_KS"."udt_@@@" (a int, field_!!! text)* > Note the missing quotes around the non-alphanumeric field name, which does > need quoting. If I'll try to run this command, it won't work. > Tested on Cassandra 4.1. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-19019) DESC TYPE forgets to quote UDT's field names
Nadav Har'El created CASSANDRA-19019: Summary: DESC TYPE forgets to quote UDT's field names Key: CASSANDRA-19019 URL: https://issues.apache.org/jira/browse/CASSANDRA-19019 Project: Cassandra Issue Type: Bug Reporter: Nadav Har'El If I create a type with *CREATE TYPE "Quoted_KS"."udt_@@@" (a int, "field_!!!" text)* and then run DESC TYPE "Quoted_KS"."udt_@@@" I get: *CREATE TYPE "Quoted_KS"."udt_@@@" (a int, field_!!! text)* Note the missing quotes around the non-alphanumeric field name, which does need quoting. If I'll try to run this command, it won't work. Tested on Cassandra 4.1. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18969) Pre-release required legal changes for cassandra-java-driver
[
https://issues.apache.org/jira/browse/CASSANDRA-18969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17785274#comment-17785274
]
Michael Semb Wever commented on CASSANDRA-18969:
bq. A reminder that only things that are included/bundled in a release need to
be mentioned in LICENSE and NOTICE.
Yea, thanks for the reminder.
This java-driver does not bundle any dependencies in the source release, and
[~henry.hughes] are there any releases that bundle dependencies (like shaded
jars published to maven central) ?
bq. So in general, transitive dependencies don't need to be mentioned in
LICENSE or NOTICE.
That's kinda misleading. Transitive dependencies are to be treated no
differently. It is solely whether they are included or not.
See https://infra.apache.org/licensing-howto.html#deps-of-deps
{quote}Dependencies of dependencies (including so-called "transitive
dependencies") are no different from first-order dependencies for the purposes
of assembling LICENSE and NOTICE: LICENSE and NOTICE need only be modified to
accommodate them only if their bits are bundled.{quote}
> Pre-release required legal changes for cassandra-java-driver
>
>
> Key: CASSANDRA-18969
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18969
> Project: Cassandra
> Issue Type: Sub-task
> Components: Client/java-driver
>Reporter: Michael Semb Wever
>Priority: Urgent
> Time Spent: 15h 50m
> Remaining Estimate: 0h
>
> TODO
> * there is still code copyrighted to others that isn't mentioned in LICENSE
> (e.g. ci/install-jdk.sh )
> * "© DataStax" still appears in the README
> * -spotbugs is LGPL, in 4.x, and not correctly made provided scope-
> * add any BSD/MIT deps to LICENCE
> * -ensure copyright headers are on all files, use rat plugin-
> * ensure NOTICE propagates NOTICES
> In short…
> {quote}
> LICENSE must contain the ASL, plus references to all code that includes
> someone else's copyright, and all BSD and MIT dependencies (including
> transitive).
> NOTICE must the standard header, plus the shorten content of any NOTICE file
> (minus its header) found in any ASL dependency (including transitive).
> {quote}
> These things must be done before a release.
> Cat X deps we included as build tool by using scope provided we should put a
> test in to ensure they work at runtime without the dep doesn't regress in the
> future.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
