(cassandra-website) branch asf-staging updated (30acfbcf5 -> 80cfe5b18)

2023-12-14 Thread git-site-role
This is an automated email from the ASF dual-hosted git repository.

git-site-role pushed a change to branch asf-staging
in repository https://gitbox.apache.org/repos/asf/cassandra-website.git


 discard 30acfbcf5 generate docs for 28519203
 new 80cfe5b18 generate docs for 28519203

This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version.  This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:

 * -- * -- B -- O -- O -- O   (30acfbcf5)
\
 N -- N -- N   refs/heads/asf-staging (80cfe5b18)

You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.

Any revisions marked "omit" are not gone; other references still
refer to them.  Any revisions marked "discard" are gone forever.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .../managing/tools/nodetool/disablebackup.html |   3 ++-
 .../managing/tools/nodetool/disablebackup.html |   3 ++-
 site-ui/build/ui-bundle.zip| Bin 4883726 -> 4883726 
bytes
 3 files changed, 4 insertions(+), 2 deletions(-)


-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-19196) Don't allow to enable direct i/o with broken kernels

2023-12-14 Thread Maxwell Guo (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-19196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Maxwell Guo updated CASSANDRA-19196:

Status: Needs Committer  (was: Patch Available)

> Don't allow to enable direct i/o with broken kernels
> 
>
> Key: CASSANDRA-19196
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19196
> Project: Cassandra
>  Issue Type: Bug
>  Components: Legacy/Local Write-Read Paths
>Reporter: Jacek Lewandowski
>Assignee: Jacek Lewandowski
>Priority: Normal
> Fix For: 5.0-rc, 5.1
>
> Attachments: signature.asc
>
>
> https://lwn.net/Articles/954285/, found by [~rustyrazorblade]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-19197) OA format serialization/deserialization problem

2023-12-14 Thread Jacek Lewandowski (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-19197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17797067#comment-17797067
 ] 

Jacek Lewandowski commented on CASSANDRA-19197:
---

Upgrade tests and tries tests + repeats are green on both branches, all links 
in PRs

> OA format serialization/deserialization problem
> ---
>
> Key: CASSANDRA-19197
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19197
> Project: Cassandra
>  Issue Type: Bug
>  Components: Legacy/Local Write-Read Paths
>Reporter: Jacek Lewandowski
>Assignee: Jacek Lewandowski
>Priority: Normal
> Fix For: 5.0-rc, 5.1
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> There is a problem with either serialization or deserialization of the new TTL



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[PR] Update com.github.jnr:jnr-posix to 3.1.18 to avoid M1 docker crash [cassandra-java-driver]

2023-12-14 Thread via GitHub


codefromthecrypt opened a new pull request, #1904:
URL: https://github.com/apache/cassandra-java-driver/pull/1904

   Zipkin found the following crash when running a docker container that uses 
this driver on Apple Silicon. Note: the problem doesn't happen when run via 
java directly on the host. Updating jnr-posix is all that was needed to remedy 
the situation.
   
   ```
   ~ $  STORAGE_TYPE=cassandra3 start-zipkin
   
 oo

   oo
  
 oo

  ooo  ooo
 oo ooo
oo   ooo
   oo   o  o   oo
  oo   oo  oo   oo
ooo      ooo
   oo   o  o  ooo
  oo   oo  oo  ooo
   oo  oo  
 o oo  oo o
   
   
   
   
   _  _ _   _
   |__  /_ _|  _ \| |/ /_ _| \ | |
 / / | || |_) | ' / | ||  \| |
/ /_ | ||  __/| . \ | || |\  |
   ||___|_|   |_|\_\___|_| \_|
   
   :: version 2.25.1 :: commit 82c3d7a ::
   
   2023-12-15 05:45:58.195  INFO [/] 8 --- [oss-http-*:9411] c.l.a.s.Server 
  : Serving HTTP at /0.0.0.0:9411 - http://127.0.0.1:9411/
   2023-12-15 05:46:06.887  INFO [/] 8 --- [cking-tasks-2-1] 
c.d.o.d.i.c.c.CqlPrepareAsyncProcessor   : Adding handler to invalidate cached 
prepared statements on type changes
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Comment Edited] (CASSANDRA-19126) Streaming appears to be incompatible with different storage_compatibility_mode settings

2023-12-14 Thread Berenguer Blasi (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-19126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17797047#comment-17797047
 ] 

Berenguer Blasi edited comment on CASSANDRA-19126 at 12/15/23 6:24 AM:
---

Just my 2cts here is the message: 
https://github.com/apache/cassandra/blob/cassandra-5.0/src/java/org/apache/cassandra/repair/messages/PrepareMessage.java#L91


was (Author: bereng):
Just my 2cts here is he message: 
https://github.com/apache/cassandra/blob/cassandra-5.0/src/java/org/apache/cassandra/repair/messages/PrepareMessage.java#L91

> Streaming appears to be incompatible with different 
> storage_compatibility_mode settings
> ---
>
> Key: CASSANDRA-19126
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19126
> Project: Cassandra
>  Issue Type: Bug
>  Components: Consistency/Streaming, Legacy/Streaming and Messaging, 
> Messaging/Internode, Tool/bulk load
>Reporter: Branimir Lambov
>Assignee: Jacek Lewandowski
>Priority: Normal
> Fix For: 5.0-rc, 5.x
>
>
> In particular, SSTableLoader appears to be incompatible with 
> storage_compatibility_mode: NONE, which manifests as a failure of 
> {{org.apache.cassandra.distributed.test.SSTableLoaderEncryptionOptionsTest}} 
> when the flag is turned on (found during CASSANDRA-18753 testing). Setting 
> {{storage_compatibility_mode: NONE}} in the tool configuration yaml does not 
> help (according to the docs, this setting is not picked up).
> This is likely a bigger problem as the acceptable streaming version for C* 5 
> is 12 only in legacy mode and 13 only in none, i.e. two C* 5 nodes do not 
> appear to be able to stream with each other if their setting for the 
> compatibility mode is different.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-19126) Streaming appears to be incompatible with different storage_compatibility_mode settings

2023-12-14 Thread Berenguer Blasi (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-19126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17797047#comment-17797047
 ] 

Berenguer Blasi commented on CASSANDRA-19126:
-

Just my 2cts here is he message: 
https://github.com/apache/cassandra/blob/cassandra-5.0/src/java/org/apache/cassandra/repair/messages/PrepareMessage.java#L91

> Streaming appears to be incompatible with different 
> storage_compatibility_mode settings
> ---
>
> Key: CASSANDRA-19126
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19126
> Project: Cassandra
>  Issue Type: Bug
>  Components: Consistency/Streaming, Legacy/Streaming and Messaging, 
> Messaging/Internode, Tool/bulk load
>Reporter: Branimir Lambov
>Assignee: Jacek Lewandowski
>Priority: Normal
> Fix For: 5.0-rc, 5.x
>
>
> In particular, SSTableLoader appears to be incompatible with 
> storage_compatibility_mode: NONE, which manifests as a failure of 
> {{org.apache.cassandra.distributed.test.SSTableLoaderEncryptionOptionsTest}} 
> when the flag is turned on (found during CASSANDRA-18753 testing). Setting 
> {{storage_compatibility_mode: NONE}} in the tool configuration yaml does not 
> help (according to the docs, this setting is not picked up).
> This is likely a bigger problem as the acceptable streaming version for C* 5 
> is 12 only in legacy mode and 13 only in none, i.e. two C* 5 nodes do not 
> appear to be able to stream with each other if their setting for the 
> compatibility mode is different.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-19197) OA format serialization/deserialization problem

2023-12-14 Thread Berenguer Blasi (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-19197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17797044#comment-17797044
 ] 

Berenguer Blasi commented on CASSANDRA-19197:
-

Code LGTM. CI is all green with only known flakies and an unrelated new failure 
imo. Still we changed BTI so: 
- 5.0 PR: https://github.com/apache/cassandra/pull/2990. +1 LGTM conditional to 
running jvm-upgrade-repeats and junit tries which shouldn't fail.
- Trunk PR: https://github.com/apache/cassandra/pull/2994. +1 LGTM conditional 
to green tries junit

> OA format serialization/deserialization problem
> ---
>
> Key: CASSANDRA-19197
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19197
> Project: Cassandra
>  Issue Type: Bug
>  Components: Legacy/Local Write-Read Paths
>Reporter: Jacek Lewandowski
>Assignee: Jacek Lewandowski
>Priority: Normal
> Fix For: 5.0-rc, 5.1
>
>
> There is a problem with either serialization or deserialization of the new TTL



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-19187) nodetool assassinate may cause thread serialization for that node

2023-12-14 Thread Runtian Liu (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-19187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17797000#comment-17797000
 ] 

Runtian Liu commented on CASSANDRA-19187:
-

Updated the test

> nodetool assassinate may cause thread serialization for that node
> -
>
> Key: CASSANDRA-19187
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19187
> Project: Cassandra
>  Issue Type: Bug
>  Components: Cluster/Membership
>Reporter: Runtian Liu
>Assignee: Runtian Liu
>Priority: Normal
> Fix For: 4.0.x, 4.1.x, 5.0.x
>
>
> When assassinate an ip address that is not in the gossip map, a "corrupted" 
> entry will be inserted into the gossip map. 
> [(1)|https://github.com/apache/cassandra/blob/cassandra-4.0/src/java/org/apache/cassandra/gms/Gossiper.java#L810]
> For example, if we do "nodetool assassinate 10.1.1.1"
> we will get an entry like below by running "nodetool gossipinfo":
>  
> {code:java}
> /10.1.1.1
>   generation:1702006511
>   heartbeat:
>   STATUS:209516:LEFT,-8393921141401589197,1702265651923
>   STATUS_WITH_PORT:209515:LEFT,-8393921141401589197,1702265651923
>   TOKENS: not present {code}
>  
> This entry in endpointStateMap will cause issue for 
> [isUpgradingFromVersionLowerThan|https://github.com/apache/cassandra/blob/cassandra-4.0/src/java/org/apache/cassandra/gms/Gossiper.java#L2284]
>  function. Because the 
> [upgradeFromVersionSupplier|https://github.com/apache/cassandra/blob/cassandra-4.0/src/java/org/apache/cassandra/gms/Gossiper.java#L191]
>  supplier will always set the 
> [allHostsHaveKnownVersion|https://github.com/apache/cassandra/blob/cassandra-4.0/src/java/org/apache/cassandra/gms/Gossiper.java#L216]
>  flag to false so no memoized value will be returned. The "get" function will 
> always require a lock from this 
> [line|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/ExpiringMemoizingSupplier.java#L66].
> If application is using "fetchAll", the native-transport-requests thread will 
> hit this 
> [line|https://github.com/apache/cassandra/blob/cassandra-4.0/src/java/org/apache/cassandra/db/filter/ColumnFilter.java#L574].
>  This means all the native-transport-requests thread is serialized, also, the 
> lock is shared by GossipStage threads. It means if a node in a cluster with 
> the corrupted gossip map is restart, the node will run into this problem.
> To fix the issue,
>  # Why we want to add a dummy entry for nodetool assassinate if the endpoint 
> is not in the map anymore. Should we do nothing or throw exception if the 
> node is not in the gossip map anymore?
>  # Before checking if a version is null, we should make sure the node is not 
> a dead node. A decommissioned node, a left node should not be considered part 
> of the cluster anymore when calculating "upgradeInProgressPossible"
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



(cassandra-website) branch asf-staging updated (b005457c9 -> 30acfbcf5)

2023-12-14 Thread git-site-role
This is an automated email from the ASF dual-hosted git repository.

git-site-role pushed a change to branch asf-staging
in repository https://gitbox.apache.org/repos/asf/cassandra-website.git


 discard b005457c9 generate docs for 28519203
 new 30acfbcf5 generate docs for 28519203

This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version.  This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:

 * -- * -- B -- O -- O -- O   (b005457c9)
\
 N -- N -- N   refs/heads/asf-staging (30acfbcf5)

You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.

Any revisions marked "omit" are not gone; other references still
refer to them.  Any revisions marked "discard" are gone forever.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 content/search-index.js |   2 +-
 site-ui/build/ui-bundle.zip | Bin 4883726 -> 4883726 bytes
 2 files changed, 1 insertion(+), 1 deletion(-)


-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-19202) A multi-line comment containing semi colon as the end of line throws error

2023-12-14 Thread Madhavan (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-19202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Madhavan updated CASSANDRA-19202:
-
Impacts:   (was: None)

> A multi-line comment containing semi colon as the end of line throws error
> --
>
> Key: CASSANDRA-19202
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19202
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Madhavan
>Priority: Normal
>
> {{Tested this with C* 4.0.latest.}}
> Let's say I've a comment section as follows, it fails today,
>  
> {quote}{{/*}}
> {{ Licensed under the Apache License, Version 2.0 (the "License");}}
> {{ you may not use this file except in compliance with the License.}}
> {{ You may obtain a copy of the License at}}
> {{ [http://www.apache.org/licenses/LICENSE-2.0]}}
> {{ Unless required by applicable law or agreed to in writing, software}}
> {{ distributed under the License is distributed on an "AS IS" BASIS,}}
> {{ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.}}
> {{ See the License for the specific language governing permissions and}}
> {{ limitations under the License.}}
> {{*/}}
> {{SELECT * FROM origin.table_a;}}
> {quote}
> which throws an exception as follows when execute it as,
> {quote}
> cqlsh -f test.cql
> {quote}
>  
> error,
> {quote}/tmp/test.cql:3:SyntaxException: line 2:64 mismatched character 
> '' expecting '*'
> /tmp/test.cql:14:SyntaxException: line 1:0 no viable alternative at input 
> 'you' ([you]...)
> {quote}
> This is because of having a semi-colon at the end of the [1st] line. If that 
> same line ended as follows,
> {quote}Version 2.0 (the "License"); you
> {quote}
> This error will not occur.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Created] (CASSANDRA-19202) A multi-line comment containing semi colon as the end of line throws error

2023-12-14 Thread Madhavan (Jira)
Madhavan created CASSANDRA-19202:


 Summary: A multi-line comment containing semi colon as the end of 
line throws error
 Key: CASSANDRA-19202
 URL: https://issues.apache.org/jira/browse/CASSANDRA-19202
 Project: Cassandra
  Issue Type: Bug
Reporter: Madhavan


{{Tested this with C* 4.0.latest.}}

Let's say I've a comment section as follows, it fails today,

 
{quote}{{/*}}
{{ Licensed under the Apache License, Version 2.0 (the "License");}}
{{ you may not use this file except in compliance with the License.}}
{{ You may obtain a copy of the License at}}
{{ [http://www.apache.org/licenses/LICENSE-2.0]}}
{{ Unless required by applicable law or agreed to in writing, software}}
{{ distributed under the License is distributed on an "AS IS" BASIS,}}
{{ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.}}
{{ See the License for the specific language governing permissions and}}
{{ limitations under the License.}}
{{*/}}

{{SELECT * FROM origin.table_a;}}
{quote}
which throws an exception as follows when execute it as,

{quote}
cqlsh -f test.cql
{quote}
 
error,
{quote}/tmp/test.cql:3:SyntaxException: line 2:64 mismatched character '' 
expecting '*'
/tmp/test.cql:14:SyntaxException: line 1:0 no viable alternative at input 'you' 
([you]...)
{quote}
This is because of having a semi-colon at the end of the [1st] line. If that 
same line ended as follows,
{quote}Version 2.0 (the "License"); you
{quote}
This error will not occur.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-19201) Refactor cqlshmain global constants

2023-12-14 Thread Brad Schoening (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-19201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Brad Schoening updated CASSANDRA-19201:
---
Description: 
Refactor global constants
 * move globals CASSANDRA_CQL_HTML and cqlruleset

 * move module level defaults (DEFAULT_) into Shell class

 * move setup_cqlruleset into cqlshhandling
 * remove unused exceptions 
 ** FunctionNotFound(Exception):
 ** AggregateNotFound(Exception):

  was:
Refactor global constants
 * move globals CASSANDRA_CQL_HTML and cqlruleset

 * move module level defaults into Shell class

 * move setup_cqlruleset into cqlshhandling
 * remove unused exceptions 
 ** FunctionNotFound(Exception):
 ** AggregateNotFound(Exception):


> Refactor cqlshmain global constants
> ---
>
> Key: CASSANDRA-19201
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19201
> Project: Cassandra
>  Issue Type: Task
>  Components: CQL/Interpreter
>Reporter: Brad Schoening
>Assignee: Brad Schoening
>Priority: Low
> Fix For: 5.x
>
>
> Refactor global constants
>  * move globals CASSANDRA_CQL_HTML and cqlruleset
>  * move module level defaults (DEFAULT_) into Shell class
>  * move setup_cqlruleset into cqlshhandling
>  * remove unused exceptions 
>  ** FunctionNotFound(Exception):
>  ** AggregateNotFound(Exception):



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-19201) Refactor cqlshmain global constants

2023-12-14 Thread Brad Schoening (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-19201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Brad Schoening updated CASSANDRA-19201:
---
Change Category: Code Clarity
 Complexity: Low Hanging Fruit
Component/s: CQL/Interpreter
  Fix Version/s: 5.x
   Priority: Low  (was: Normal)
 Status: Open  (was: Triage Needed)

> Refactor cqlshmain global constants
> ---
>
> Key: CASSANDRA-19201
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19201
> Project: Cassandra
>  Issue Type: Task
>  Components: CQL/Interpreter
>Reporter: Brad Schoening
>Assignee: Brad Schoening
>Priority: Low
> Fix For: 5.x
>
>
> Refactor global constants
>  * move globals CASSANDRA_CQL_HTML and cqlruleset
>  * move module level defaults into Shell class
>  * move setup_cqlruleset into cqlshhandling
>  * remove unused exceptions



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Created] (CASSANDRA-19201) Refactor cqlshmain global constants

2023-12-14 Thread Brad Schoening (Jira)
Brad Schoening created CASSANDRA-19201:
--

 Summary: Refactor cqlshmain global constants
 Key: CASSANDRA-19201
 URL: https://issues.apache.org/jira/browse/CASSANDRA-19201
 Project: Cassandra
  Issue Type: Task
Reporter: Brad Schoening


Refactor global constants

* remove globals CASSANDRA_CQL_HTML and cqlruleset

* move module level defaults into Shell class

* move setup_cqlruleset into cqlshhandling

* remove unused exceptions



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-19187) nodetool assassinate may cause thread serialization for that node

2023-12-14 Thread Brandon Williams (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-19187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17796907#comment-17796907
 ] 

Brandon Williams commented on CASSANDRA-19187:
--

Unfortunately there seems to be some flakiness in 
testAssassinatedNodeWillNotContributeToVersionCalculation.

> nodetool assassinate may cause thread serialization for that node
> -
>
> Key: CASSANDRA-19187
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19187
> Project: Cassandra
>  Issue Type: Bug
>  Components: Cluster/Membership
>Reporter: Runtian Liu
>Assignee: Runtian Liu
>Priority: Normal
> Fix For: 4.0.x, 4.1.x, 5.0.x
>
>
> When assassinate an ip address that is not in the gossip map, a "corrupted" 
> entry will be inserted into the gossip map. 
> [(1)|https://github.com/apache/cassandra/blob/cassandra-4.0/src/java/org/apache/cassandra/gms/Gossiper.java#L810]
> For example, if we do "nodetool assassinate 10.1.1.1"
> we will get an entry like below by running "nodetool gossipinfo":
>  
> {code:java}
> /10.1.1.1
>   generation:1702006511
>   heartbeat:
>   STATUS:209516:LEFT,-8393921141401589197,1702265651923
>   STATUS_WITH_PORT:209515:LEFT,-8393921141401589197,1702265651923
>   TOKENS: not present {code}
>  
> This entry in endpointStateMap will cause issue for 
> [isUpgradingFromVersionLowerThan|https://github.com/apache/cassandra/blob/cassandra-4.0/src/java/org/apache/cassandra/gms/Gossiper.java#L2284]
>  function. Because the 
> [upgradeFromVersionSupplier|https://github.com/apache/cassandra/blob/cassandra-4.0/src/java/org/apache/cassandra/gms/Gossiper.java#L191]
>  supplier will always set the 
> [allHostsHaveKnownVersion|https://github.com/apache/cassandra/blob/cassandra-4.0/src/java/org/apache/cassandra/gms/Gossiper.java#L216]
>  flag to false so no memoized value will be returned. The "get" function will 
> always require a lock from this 
> [line|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/ExpiringMemoizingSupplier.java#L66].
> If application is using "fetchAll", the native-transport-requests thread will 
> hit this 
> [line|https://github.com/apache/cassandra/blob/cassandra-4.0/src/java/org/apache/cassandra/db/filter/ColumnFilter.java#L574].
>  This means all the native-transport-requests thread is serialized, also, the 
> lock is shared by GossipStage threads. It means if a node in a cluster with 
> the corrupted gossip map is restart, the node will run into this problem.
> To fix the issue,
>  # Why we want to add a dummy entry for nodetool assassinate if the endpoint 
> is not in the map anymore. Should we do nothing or throw exception if the 
> node is not in the gossip map anymore?
>  # Before checking if a version is null, we should make sure the node is not 
> a dead node. A decommissioned node, a left node should not be considered part 
> of the cluster anymore when calculating "upgradeInProgressPossible"
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-19187) nodetool assassinate may cause thread serialization for that node

2023-12-14 Thread Runtian Liu (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-19187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17796898#comment-17796898
 ] 

Runtian Liu commented on CASSANDRA-19187:
-

[~brandon.williams] , thanks, updated the 4.0 link.

> nodetool assassinate may cause thread serialization for that node
> -
>
> Key: CASSANDRA-19187
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19187
> Project: Cassandra
>  Issue Type: Bug
>  Components: Cluster/Membership
>Reporter: Runtian Liu
>Assignee: Runtian Liu
>Priority: Normal
> Fix For: 4.0.x, 4.1.x, 5.0.x
>
>
> When assassinate an ip address that is not in the gossip map, a "corrupted" 
> entry will be inserted into the gossip map. 
> [(1)|https://github.com/apache/cassandra/blob/cassandra-4.0/src/java/org/apache/cassandra/gms/Gossiper.java#L810]
> For example, if we do "nodetool assassinate 10.1.1.1"
> we will get an entry like below by running "nodetool gossipinfo":
>  
> {code:java}
> /10.1.1.1
>   generation:1702006511
>   heartbeat:
>   STATUS:209516:LEFT,-8393921141401589197,1702265651923
>   STATUS_WITH_PORT:209515:LEFT,-8393921141401589197,1702265651923
>   TOKENS: not present {code}
>  
> This entry in endpointStateMap will cause issue for 
> [isUpgradingFromVersionLowerThan|https://github.com/apache/cassandra/blob/cassandra-4.0/src/java/org/apache/cassandra/gms/Gossiper.java#L2284]
>  function. Because the 
> [upgradeFromVersionSupplier|https://github.com/apache/cassandra/blob/cassandra-4.0/src/java/org/apache/cassandra/gms/Gossiper.java#L191]
>  supplier will always set the 
> [allHostsHaveKnownVersion|https://github.com/apache/cassandra/blob/cassandra-4.0/src/java/org/apache/cassandra/gms/Gossiper.java#L216]
>  flag to false so no memoized value will be returned. The "get" function will 
> always require a lock from this 
> [line|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/ExpiringMemoizingSupplier.java#L66].
> If application is using "fetchAll", the native-transport-requests thread will 
> hit this 
> [line|https://github.com/apache/cassandra/blob/cassandra-4.0/src/java/org/apache/cassandra/db/filter/ColumnFilter.java#L574].
>  This means all the native-transport-requests thread is serialized, also, the 
> lock is shared by GossipStage threads. It means if a node in a cluster with 
> the corrupted gossip map is restart, the node will run into this problem.
> To fix the issue,
>  # Why we want to add a dummy entry for nodetool assassinate if the endpoint 
> is not in the map anymore. Should we do nothing or throw exception if the 
> node is not in the gossip map anymore?
>  # Before checking if a version is null, we should make sure the node is not 
> a dead node. A decommissioned node, a left node should not be considered part 
> of the cluster anymore when calculating "upgradeInProgressPossible"
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Comment Edited] (CASSANDRA-19187) nodetool assassinate may cause thread serialization for that node

2023-12-14 Thread Runtian Liu (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-19187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17796502#comment-17796502
 ] 

Runtian Liu edited comment on CASSANDRA-19187 at 12/14/23 8:34 PM:
---

[~brandon.williams] please review:

4.0 : https://github.com/apache/cassandra/pull/2978

4.1: [https://github.com/apache/cassandra/pull/2992]

5.0: [https://github.com/apache/cassandra/pull/2993]


was (Author: JIRAUSER291682):
[~brandon.williams] please review:

4.0 : https://github.com/apache/cassandra/pull/2981

4.1: https://github.com/apache/cassandra/pull/2992

5.0: https://github.com/apache/cassandra/pull/2993

> nodetool assassinate may cause thread serialization for that node
> -
>
> Key: CASSANDRA-19187
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19187
> Project: Cassandra
>  Issue Type: Bug
>  Components: Cluster/Membership
>Reporter: Runtian Liu
>Assignee: Runtian Liu
>Priority: Normal
> Fix For: 4.0.x, 4.1.x, 5.0.x
>
>
> When assassinate an ip address that is not in the gossip map, a "corrupted" 
> entry will be inserted into the gossip map. 
> [(1)|https://github.com/apache/cassandra/blob/cassandra-4.0/src/java/org/apache/cassandra/gms/Gossiper.java#L810]
> For example, if we do "nodetool assassinate 10.1.1.1"
> we will get an entry like below by running "nodetool gossipinfo":
>  
> {code:java}
> /10.1.1.1
>   generation:1702006511
>   heartbeat:
>   STATUS:209516:LEFT,-8393921141401589197,1702265651923
>   STATUS_WITH_PORT:209515:LEFT,-8393921141401589197,1702265651923
>   TOKENS: not present {code}
>  
> This entry in endpointStateMap will cause issue for 
> [isUpgradingFromVersionLowerThan|https://github.com/apache/cassandra/blob/cassandra-4.0/src/java/org/apache/cassandra/gms/Gossiper.java#L2284]
>  function. Because the 
> [upgradeFromVersionSupplier|https://github.com/apache/cassandra/blob/cassandra-4.0/src/java/org/apache/cassandra/gms/Gossiper.java#L191]
>  supplier will always set the 
> [allHostsHaveKnownVersion|https://github.com/apache/cassandra/blob/cassandra-4.0/src/java/org/apache/cassandra/gms/Gossiper.java#L216]
>  flag to false so no memoized value will be returned. The "get" function will 
> always require a lock from this 
> [line|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/ExpiringMemoizingSupplier.java#L66].
> If application is using "fetchAll", the native-transport-requests thread will 
> hit this 
> [line|https://github.com/apache/cassandra/blob/cassandra-4.0/src/java/org/apache/cassandra/db/filter/ColumnFilter.java#L574].
>  This means all the native-transport-requests thread is serialized, also, the 
> lock is shared by GossipStage threads. It means if a node in a cluster with 
> the corrupted gossip map is restart, the node will run into this problem.
> To fix the issue,
>  # Why we want to add a dummy entry for nodetool assassinate if the endpoint 
> is not in the map anymore. Should we do nothing or throw exception if the 
> node is not in the gossip map anymore?
>  # Before checking if a version is null, we should make sure the node is not 
> a dead node. A decommissioned node, a left node should not be considered part 
> of the cluster anymore when calculating "upgradeInProgressPossible"
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Comment Edited] (CASSANDRA-19187) nodetool assassinate may cause thread serialization for that node

2023-12-14 Thread Brandon Williams (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-19187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17796891#comment-17796891
 ] 

Brandon Williams edited comment on CASSANDRA-19187 at 12/14/23 8:06 PM:


[~curlylrt] that 4.0 link is for another ticket. I used the one you originally 
linked [here|https://github.com/apache/cassandra/pull/2978].

||Branch||CI||
|[4.0|https://github.com/driftx/cassandra/tree/CASSANDRA-19187-4.0]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/1416/workflows/2cafb3ad-057c-4fa4-a638-f8877912c60d],
 
[j11|https://app.circleci.com/pipelines/github/driftx/cassandra/1416/workflows/d4e03537-c49e-4e2d-8910-156d23732321]|
|[4.1|https://github.com/driftx/cassandra/tree/CASSANDRA-19187-4.1]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/1414/workflows/a019c2cd-64b5-4b57-a554-5881de6fd3c7],
 
[j11|https://app.circleci.com/pipelines/github/driftx/cassandra/1414/workflows/11889dfa-7d86-4fb7-a713-874dfc3a0552]|
|[5.0|https://github.com/driftx/cassandra/tree/CASSANDRA-19187-5.0]|[j11|https://app.circleci.com/pipelines/github/driftx/cassandra/1415/workflows/821eb0bd-9af4-48a9-a50e-a9e1aab75a4e],
 
[j17|https://app.circleci.com/pipelines/github/driftx/cassandra/1415/workflows/54d783aa-3fca-4531-9a80-6ab8b47472b2]|



was (Author: brandon.williams):
[~curlylrt] that 4.0 link is for another ticket.

> nodetool assassinate may cause thread serialization for that node
> -
>
> Key: CASSANDRA-19187
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19187
> Project: Cassandra
>  Issue Type: Bug
>  Components: Cluster/Membership
>Reporter: Runtian Liu
>Assignee: Runtian Liu
>Priority: Normal
> Fix For: 4.0.x, 4.1.x, 5.0.x
>
>
> When assassinate an ip address that is not in the gossip map, a "corrupted" 
> entry will be inserted into the gossip map. 
> [(1)|https://github.com/apache/cassandra/blob/cassandra-4.0/src/java/org/apache/cassandra/gms/Gossiper.java#L810]
> For example, if we do "nodetool assassinate 10.1.1.1"
> we will get an entry like below by running "nodetool gossipinfo":
>  
> {code:java}
> /10.1.1.1
>   generation:1702006511
>   heartbeat:
>   STATUS:209516:LEFT,-8393921141401589197,1702265651923
>   STATUS_WITH_PORT:209515:LEFT,-8393921141401589197,1702265651923
>   TOKENS: not present {code}
>  
> This entry in endpointStateMap will cause issue for 
> [isUpgradingFromVersionLowerThan|https://github.com/apache/cassandra/blob/cassandra-4.0/src/java/org/apache/cassandra/gms/Gossiper.java#L2284]
>  function. Because the 
> [upgradeFromVersionSupplier|https://github.com/apache/cassandra/blob/cassandra-4.0/src/java/org/apache/cassandra/gms/Gossiper.java#L191]
>  supplier will always set the 
> [allHostsHaveKnownVersion|https://github.com/apache/cassandra/blob/cassandra-4.0/src/java/org/apache/cassandra/gms/Gossiper.java#L216]
>  flag to false so no memoized value will be returned. The "get" function will 
> always require a lock from this 
> [line|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/ExpiringMemoizingSupplier.java#L66].
> If application is using "fetchAll", the native-transport-requests thread will 
> hit this 
> [line|https://github.com/apache/cassandra/blob/cassandra-4.0/src/java/org/apache/cassandra/db/filter/ColumnFilter.java#L574].
>  This means all the native-transport-requests thread is serialized, also, the 
> lock is shared by GossipStage threads. It means if a node in a cluster with 
> the corrupted gossip map is restart, the node will run into this problem.
> To fix the issue,
>  # Why we want to add a dummy entry for nodetool assassinate if the endpoint 
> is not in the map anymore. Should we do nothing or throw exception if the 
> node is not in the gossip map anymore?
>  # Before checking if a version is null, we should make sure the node is not 
> a dead node. A decommissioned node, a left node should not be considered part 
> of the cluster anymore when calculating "upgradeInProgressPossible"
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-19187) nodetool assassinate may cause thread serialization for that node

2023-12-14 Thread Brandon Williams (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-19187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17796891#comment-17796891
 ] 

Brandon Williams commented on CASSANDRA-19187:
--

[~curlylrt] that 4.0 link is for another ticket.

> nodetool assassinate may cause thread serialization for that node
> -
>
> Key: CASSANDRA-19187
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19187
> Project: Cassandra
>  Issue Type: Bug
>  Components: Cluster/Membership
>Reporter: Runtian Liu
>Assignee: Runtian Liu
>Priority: Normal
> Fix For: 4.0.x, 4.1.x, 5.0.x
>
>
> When assassinate an ip address that is not in the gossip map, a "corrupted" 
> entry will be inserted into the gossip map. 
> [(1)|https://github.com/apache/cassandra/blob/cassandra-4.0/src/java/org/apache/cassandra/gms/Gossiper.java#L810]
> For example, if we do "nodetool assassinate 10.1.1.1"
> we will get an entry like below by running "nodetool gossipinfo":
>  
> {code:java}
> /10.1.1.1
>   generation:1702006511
>   heartbeat:
>   STATUS:209516:LEFT,-8393921141401589197,1702265651923
>   STATUS_WITH_PORT:209515:LEFT,-8393921141401589197,1702265651923
>   TOKENS: not present {code}
>  
> This entry in endpointStateMap will cause issue for 
> [isUpgradingFromVersionLowerThan|https://github.com/apache/cassandra/blob/cassandra-4.0/src/java/org/apache/cassandra/gms/Gossiper.java#L2284]
>  function. Because the 
> [upgradeFromVersionSupplier|https://github.com/apache/cassandra/blob/cassandra-4.0/src/java/org/apache/cassandra/gms/Gossiper.java#L191]
>  supplier will always set the 
> [allHostsHaveKnownVersion|https://github.com/apache/cassandra/blob/cassandra-4.0/src/java/org/apache/cassandra/gms/Gossiper.java#L216]
>  flag to false so no memoized value will be returned. The "get" function will 
> always require a lock from this 
> [line|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/ExpiringMemoizingSupplier.java#L66].
> If application is using "fetchAll", the native-transport-requests thread will 
> hit this 
> [line|https://github.com/apache/cassandra/blob/cassandra-4.0/src/java/org/apache/cassandra/db/filter/ColumnFilter.java#L574].
>  This means all the native-transport-requests thread is serialized, also, the 
> lock is shared by GossipStage threads. It means if a node in a cluster with 
> the corrupted gossip map is restart, the node will run into this problem.
> To fix the issue,
>  # Why we want to add a dummy entry for nodetool assassinate if the endpoint 
> is not in the map anymore. Should we do nothing or throw exception if the 
> node is not in the gossip map anymore?
>  # Before checking if a version is null, we should make sure the node is not 
> a dead node. A decommissioned node, a left node should not be considered part 
> of the cluster anymore when calculating "upgradeInProgressPossible"
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRASC-88) Allow DriverUtils to be pluggable

2023-12-14 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRASC-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17796883#comment-17796883
 ] 

ASF subversion and git services commented on CASSANDRASC-88:


Commit 888a546f84790c0a0b1b930e682cf597caaa0d61 in cassandra-sidecar's branch 
refs/heads/trunk from Francisco Guerrero
[ https://gitbox.apache.org/repos/asf?p=cassandra-sidecar.git;h=888a546 ]

CASSANDRASC-88: Allow DriverUtils to be pluggable

Patch by Francisco Guerrero; Reviewed by Yifan Cai for CASSANDRASC-88


> Allow DriverUtils to be pluggable
> -
>
> Key: CASSANDRASC-88
> URL: https://issues.apache.org/jira/browse/CASSANDRASC-88
> Project: Sidecar for Apache Cassandra
>  Issue Type: Improvement
>  Components: Configuration
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
>  Labels: pull-request-available
>
> Sidecar provides a class to provide utilities to access package private 
> methods in the datastax driver. However, the nature of the static methods is 
> that it doesn't allow for plugging a custom implementation. For example, if 
> we plug a new driver version, these methods might not necessarily work as 
> APIs might change between version changes. For that reason, we need to 
> provide a shim layer to access these utilities, and allow pluggability when 
> needed.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRASC-88) Allow DriverUtils to be pluggable

2023-12-14 Thread Francisco Guerrero (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRASC-88?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Francisco Guerrero updated CASSANDRASC-88:
--
  Fix Version/s: 1.0
Source Control Link: 
https://github.com/apache/cassandra-sidecar/commit/888a546f84790c0a0b1b930e682cf597caaa0d61
 Resolution: Fixed
 Status: Resolved  (was: Ready to Commit)

> Allow DriverUtils to be pluggable
> -
>
> Key: CASSANDRASC-88
> URL: https://issues.apache.org/jira/browse/CASSANDRASC-88
> Project: Sidecar for Apache Cassandra
>  Issue Type: Improvement
>  Components: Configuration
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
>  Labels: pull-request-available
> Fix For: 1.0
>
>
> Sidecar provides a class to provide utilities to access package private 
> methods in the datastax driver. However, the nature of the static methods is 
> that it doesn't allow for plugging a custom implementation. For example, if 
> we plug a new driver version, these methods might not necessarily work as 
> APIs might change between version changes. For that reason, we need to 
> provide a shim layer to access these utilities, and allow pluggability when 
> needed.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



(cassandra-sidecar) branch trunk updated: CASSANDRASC-88: Allow DriverUtils to be pluggable

2023-12-14 Thread frankgh
This is an automated email from the ASF dual-hosted git repository.

frankgh pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra-sidecar.git


The following commit(s) were added to refs/heads/trunk by this push:
 new 888a546  CASSANDRASC-88: Allow DriverUtils to be pluggable
888a546 is described below

commit 888a546f84790c0a0b1b930e682cf597caaa0d61
Author: Francisco Guerrero 
AuthorDate: Wed Dec 13 16:45:39 2023 -0800

CASSANDRASC-88: Allow DriverUtils to be pluggable

Patch by Francisco Guerrero; Reviewed by Yifan Cai for CASSANDRASC-88
---
 CHANGES.txt|  1 +
 .../sidecar/adapters/base/CassandraAdapter.java| 15 ++
 .../sidecar/adapters/base/CassandraFactory.java|  9 +++---
 .../java/com/datastax/driver/core/DriverUtils.java | 11 ++-
 .../sidecar/common/utils}/DriverUtils.java | 35 +++---
 .../sidecar/cluster/CQLSessionProviderImpl.java| 10 +--
 .../sidecar/cluster/CassandraAdapterDelegate.java  |  8 +++--
 .../cluster/SidecarLoadBalancingPolicy.java|  9 --
 .../cassandra/sidecar/server/MainModule.java   | 29 +-
 .../testing/CassandraSidecarTestContext.java   |  6 ++--
 .../cassandra/sidecar/snapshots/SnapshotUtils.java |  3 +-
 11 files changed, 82 insertions(+), 54 deletions(-)

diff --git a/CHANGES.txt b/CHANGES.txt
index 25e76dc..f8a4f87 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,5 +1,6 @@
 1.0.0
 -
+ * Allow DriverUtils to be pluggable (CASSANDRASC-88)
  * Add JMX health checks during the periodic health checks (CASSANDRASC-87)
  * Sidecar should be able to load metadata even if the local instance is 
unavailable (CASSANDRASC-79)
  * Expose additional SSL configuration options for the Sidecar Service 
(CASSANDRASC-82)
diff --git 
a/adapters/base/src/main/java/org/apache/cassandra/sidecar/adapters/base/CassandraAdapter.java
 
b/adapters/base/src/main/java/org/apache/cassandra/sidecar/adapters/base/CassandraAdapter.java
index f02ea2f..5caab2e 100644
--- 
a/adapters/base/src/main/java/org/apache/cassandra/sidecar/adapters/base/CassandraAdapter.java
+++ 
b/adapters/base/src/main/java/org/apache/cassandra/sidecar/adapters/base/CassandraAdapter.java
@@ -24,7 +24,6 @@ import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
 import com.datastax.driver.core.ConsistencyLevel;
-import com.datastax.driver.core.DriverUtils;
 import com.datastax.driver.core.Host;
 import com.datastax.driver.core.Metadata;
 import com.datastax.driver.core.ResultSet;
@@ -38,6 +37,7 @@ import org.apache.cassandra.sidecar.common.NodeSettings;
 import org.apache.cassandra.sidecar.common.StorageOperations;
 import org.apache.cassandra.sidecar.common.TableOperations;
 import org.apache.cassandra.sidecar.common.dns.DnsResolver;
+import org.apache.cassandra.sidecar.common.utils.DriverUtils;
 import org.jetbrains.annotations.Nullable;
 
 /**
@@ -49,18 +49,21 @@ public class CassandraAdapter implements ICassandraAdapter
 protected final DnsResolver dnsResolver;
 protected final JmxClient jmxClient;
 private final CQLSessionProvider cqlSessionProvider;
-private final String sidecarVersion;
 private final InetSocketAddress localNativeTransportAddress;
+private final DriverUtils driverUtils;
 private volatile Host host;
 
-public CassandraAdapter(DnsResolver dnsResolver, JmxClient jmxClient, 
CQLSessionProvider cqlSessionProvider,
-String sidecarVersion, InetSocketAddress 
localNativeTransportAddress)
+public CassandraAdapter(DnsResolver dnsResolver,
+JmxClient jmxClient,
+CQLSessionProvider cqlSessionProvider,
+InetSocketAddress localNativeTransportAddress,
+DriverUtils driverUtils)
 {
 this.dnsResolver = dnsResolver;
 this.jmxClient = jmxClient;
 this.cqlSessionProvider = cqlSessionProvider;
-this.sidecarVersion = sidecarVersion;
 this.localNativeTransportAddress = localNativeTransportAddress;
+this.driverUtils = driverUtils;
 }
 
 /**
@@ -132,7 +135,7 @@ public class CassandraAdapter implements ICassandraAdapter
 {
 if (host == null)
 {
-host = DriverUtils.getHost(metadata, 
localNativeTransportAddress);
+host = driverUtils.getHost(metadata, 
localNativeTransportAddress);
 }
 }
 }
diff --git 
a/adapters/base/src/main/java/org/apache/cassandra/sidecar/adapters/base/CassandraFactory.java
 
b/adapters/base/src/main/java/org/apache/cassandra/sidecar/adapters/base/CassandraFactory.java
index 5e505d7..bfb5eb0 100644
--- 
a/adapters/base/src/main/java/org/apache/cassandra/sidecar/adapters/base/CassandraFactory.java
+++ 

[jira] [Commented] (CASSANDRASC-88) Allow DriverUtils to be pluggable

2023-12-14 Thread Francisco Guerrero (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRASC-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17796881#comment-17796881
 ] 

Francisco Guerrero commented on CASSANDRASC-88:
---

Green CI: 
https://app.circleci.com/pipelines/github/frankgh/cassandra-sidecar/409

> Allow DriverUtils to be pluggable
> -
>
> Key: CASSANDRASC-88
> URL: https://issues.apache.org/jira/browse/CASSANDRASC-88
> Project: Sidecar for Apache Cassandra
>  Issue Type: Improvement
>  Components: Configuration
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
>  Labels: pull-request-available
>
> Sidecar provides a class to provide utilities to access package private 
> methods in the datastax driver. However, the nature of the static methods is 
> that it doesn't allow for plugging a custom implementation. For example, if 
> we plug a new driver version, these methods might not necessarily work as 
> APIs might change between version changes. For that reason, we need to 
> provide a shim layer to access these utilities, and allow pluggability when 
> needed.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRASC-88) Allow DriverUtils to be pluggable

2023-12-14 Thread Francisco Guerrero (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRASC-88?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Francisco Guerrero updated CASSANDRASC-88:
--
Status: Ready to Commit  (was: Review In Progress)

> Allow DriverUtils to be pluggable
> -
>
> Key: CASSANDRASC-88
> URL: https://issues.apache.org/jira/browse/CASSANDRASC-88
> Project: Sidecar for Apache Cassandra
>  Issue Type: Improvement
>  Components: Configuration
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
>  Labels: pull-request-available
>
> Sidecar provides a class to provide utilities to access package private 
> methods in the datastax driver. However, the nature of the static methods is 
> that it doesn't allow for plugging a custom implementation. For example, if 
> we plug a new driver version, these methods might not necessarily work as 
> APIs might change between version changes. For that reason, we need to 
> provide a shim layer to access these utilities, and allow pluggability when 
> needed.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-16565) Remove dependency on sigar

2023-12-14 Thread Stefan Miklosovic (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-16565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17796802#comment-17796802
 ] 

Stefan Miklosovic commented on CASSANDRA-16565:
---

OK so I looked more closely and kernel version is parsed here. They are reading 
it from /proc/version, in my case it is 

{code}
Linux version 5.19.0-051900-generic (kernel@sita) (x86_64-linux-gnu-gcc-11 
(Ubuntu 11.3.0-5ubuntu1) 11.3.0, GNU ld (GNU Binutils for Ubuntu) 
2.38.90.20220713) #202207312230 SMP PREEMPT_DYNAMIC Sun Jul 31 22:34:11 UTC 2022
{code}

and kernel version is in this case "5.19.0-051900-generic"

[~jlewandowski]'s patch in CASSANDRA-19196 reads it from "uname -r", which 
gives me

{code}
$ uname -r
5.19.0-051900-generic
{code}

which is exact same thing. I think that we do not need to implement anything in 
OSHI to read kernel's version which is good news.

(1) 
https://github.com/oshi/oshi/blob/master/oshi-core/src/main/java/oshi/software/os/linux/LinuxOperatingSystem.java#L180

> Remove dependency on sigar
> --
>
> Key: CASSANDRA-16565
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16565
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Build
>Reporter: David Capwell
>Assignee: Claude Warren
>Priority: Normal
> Fix For: 5.x
>
> Attachments: signature.asc
>
>
> sigar is used to check if the environment has good settings for running C*, 
> but requires we bundle a lot of native libraries to perform this check (which 
> can also be done elsewhere).  This project also appears to be dead as the 
> last commit was around 6 years ago.
> With the move to resolve artifacts rather than commit them, removing this 
> dependency would remove majority of the artifacts fetched from GitHub.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-19183) Fix cqlshlib cython test

2023-12-14 Thread Brandon Williams (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-19183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Brandon Williams updated CASSANDRA-19183:
-
  Fix Version/s: 5.0-beta2
 5.1-alpha1
 (was: 5.x)
 (was: 5.0-beta)
  Since Version: NA
Source Control Link: 
https://github.com/apache/cassandra/commit/f9ebec98a2f4610e280abf6ecdd1f7f53f160da6
 Resolution: Fixed
 Status: Resolved  (was: Ready to Commit)

Thanks, committed.

> Fix cqlshlib cython test
> 
>
> Key: CASSANDRA-19183
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19183
> Project: Cassandra
>  Issue Type: Bug
>  Components: Tool/cqlsh
>Reporter: Brandon Williams
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 5.0-beta2, 5.1-alpha1
>
>
> This is failing on 
> [trunk|https://app.circleci.com/pipelines/github/driftx/cassandra/1405/workflows/ff7b5121-b6df-4290-8d63-bcc6d6385724/jobs/65554]
>  and 
> [5.0|https://app.circleci.com/pipelines/github/driftx/cassandra/1406/workflows/f7f2b35c-1233-43d7-a942-218f1712add4/jobs/65649]:
> {quote}
> PermissionError: [Errno 13] Permission denied: '/.ccm'
> {quote}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-19183) Fix cqlshlib cython test

2023-12-14 Thread Brandon Williams (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-19183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Brandon Williams updated CASSANDRA-19183:
-
Status: Ready to Commit  (was: Review In Progress)

> Fix cqlshlib cython test
> 
>
> Key: CASSANDRA-19183
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19183
> Project: Cassandra
>  Issue Type: Bug
>  Components: Tool/cqlsh
>Reporter: Brandon Williams
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 5.0-beta, 5.x
>
>
> This is failing on 
> [trunk|https://app.circleci.com/pipelines/github/driftx/cassandra/1405/workflows/ff7b5121-b6df-4290-8d63-bcc6d6385724/jobs/65554]
>  and 
> [5.0|https://app.circleci.com/pipelines/github/driftx/cassandra/1406/workflows/f7f2b35c-1233-43d7-a942-218f1712add4/jobs/65649]:
> {quote}
> PermissionError: [Errno 13] Permission denied: '/.ccm'
> {quote}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-19183) Fix cqlshlib cython test

2023-12-14 Thread Brandon Williams (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-19183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Brandon Williams updated CASSANDRA-19183:
-
Reviewers: Berenguer Blasi, Brandon Williams
   Status: Review In Progress  (was: Patch Available)

> Fix cqlshlib cython test
> 
>
> Key: CASSANDRA-19183
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19183
> Project: Cassandra
>  Issue Type: Bug
>  Components: Tool/cqlsh
>Reporter: Brandon Williams
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 5.0-beta, 5.x
>
>
> This is failing on 
> [trunk|https://app.circleci.com/pipelines/github/driftx/cassandra/1405/workflows/ff7b5121-b6df-4290-8d63-bcc6d6385724/jobs/65554]
>  and 
> [5.0|https://app.circleci.com/pipelines/github/driftx/cassandra/1406/workflows/f7f2b35c-1233-43d7-a942-218f1712add4/jobs/65649]:
> {quote}
> PermissionError: [Errno 13] Permission denied: '/.ccm'
> {quote}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-19183) Fix cqlshlib cython test

2023-12-14 Thread Brandon Williams (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-19183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Brandon Williams updated CASSANDRA-19183:
-
Reviewers: Berenguer Blasi  (was: Berenguer Blasi, Brandon Williams)

> Fix cqlshlib cython test
> 
>
> Key: CASSANDRA-19183
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19183
> Project: Cassandra
>  Issue Type: Bug
>  Components: Tool/cqlsh
>Reporter: Brandon Williams
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 5.0-beta, 5.x
>
>
> This is failing on 
> [trunk|https://app.circleci.com/pipelines/github/driftx/cassandra/1405/workflows/ff7b5121-b6df-4290-8d63-bcc6d6385724/jobs/65554]
>  and 
> [5.0|https://app.circleci.com/pipelines/github/driftx/cassandra/1406/workflows/f7f2b35c-1233-43d7-a942-218f1712add4/jobs/65649]:
> {quote}
> PermissionError: [Errno 13] Permission denied: '/.ccm'
> {quote}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



(cassandra) branch cassandra-5.0 updated: Fix cqlshlib cython test by definining DIST_DIR

2023-12-14 Thread brandonwilliams
This is an automated email from the ASF dual-hosted git repository.

brandonwilliams pushed a commit to branch cassandra-5.0
in repository https://gitbox.apache.org/repos/asf/cassandra.git


The following commit(s) were added to refs/heads/cassandra-5.0 by this push:
 new f9ebec98a2 Fix cqlshlib cython test by definining DIST_DIR
f9ebec98a2 is described below

commit f9ebec98a2f4610e280abf6ecdd1f7f53f160da6
Author: Brandon Williams 
AuthorDate: Thu Dec 14 06:04:47 2023 -0600

Fix cqlshlib cython test by definining DIST_DIR

Patch by brandonwilliams, reviewed by bereng for CASSANDRA-19183
---
 pylib/cassandra-cqlsh-tests.sh | 1 +
 1 file changed, 1 insertion(+)

diff --git a/pylib/cassandra-cqlsh-tests.sh b/pylib/cassandra-cqlsh-tests.sh
index 91730a363e..3bbf9820e7 100755
--- a/pylib/cassandra-cqlsh-tests.sh
+++ b/pylib/cassandra-cqlsh-tests.sh
@@ -27,6 +27,7 @@ WORKSPACE=$1
 
 [ "x${WORKSPACE}" != "x" ] || WORKSPACE="$(readlink -f $(dirname "$0")/..)"
 [ "x${BUILD_DIR}" != "x" ] || BUILD_DIR="${WORKSPACE}/build"
+[ "x${DIST_DIR}" != "x" ] || DIST_DIR="${WORKSPACE}/build"
 
 export TMPDIR="$(mktemp -d ${DIST_DIR}/run-python-dtest.XX)"
 export PYTHONIOENCODING="utf-8"


-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-16565) Remove dependency on sigar

2023-12-14 Thread miklosovic (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-16565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

miklosovic updated CASSANDRA-16565:
---
Attachment: signature.asc

If it is not obvious, I need to mention that oshi currently does not offer such 
API and we would need to implement it. Nice to have but not a must.


Sent from ProtonMail mobile



\

> Remove dependency on sigar
> --
>
> Key: CASSANDRA-16565
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16565
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Build
>Reporter: David Capwell
>Assignee: Claude Warren
>Priority: Normal
> Fix For: 5.x
>
> Attachments: signature.asc
>
>
> sigar is used to check if the environment has good settings for running C*, 
> but requires we bundle a lot of native libraries to perform this check (which 
> can also be done elsewhere).  This project also appears to be dead as the 
> last commit was around 6 years ago.
> With the move to resolve artifacts rather than commit them, removing this 
> dependency would remove majority of the artifacts fetched from GitHub.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



(cassandra) branch trunk updated (afa86df27d -> 85a0b9b5dc)

2023-12-14 Thread brandonwilliams
This is an automated email from the ASF dual-hosted git repository.

brandonwilliams pushed a change to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra.git


from afa86df27d Merge branch 'cassandra-5.0' into trunk
 new f9ebec98a2 Fix cqlshlib cython test by definining DIST_DIR
 new 85a0b9b5dc Merge branch 'cassandra-5.0' into trunk

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 pylib/cassandra-cqlsh-tests.sh | 1 +
 1 file changed, 1 insertion(+)


-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



(cassandra) 01/01: Merge branch 'cassandra-5.0' into trunk

2023-12-14 Thread brandonwilliams
This is an automated email from the ASF dual-hosted git repository.

brandonwilliams pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra.git

commit 85a0b9b5dc3af87dd3692f195cee461dd9eb62f7
Merge: afa86df27d f9ebec98a2
Author: Brandon Williams 
AuthorDate: Thu Dec 14 08:49:59 2023 -0600

Merge branch 'cassandra-5.0' into trunk

 pylib/cassandra-cqlsh-tests.sh | 1 +
 1 file changed, 1 insertion(+)



-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-19190) ForceSnapshot transformations should not be persisted in the local log table

2023-12-14 Thread Sam Tunnicliffe (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-19190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sam Tunnicliffe updated CASSANDRA-19190:

Description: Per its inline comments, ForceSnapshot is a synthetic 
transformation whose purpose it to enable the local log to jump missing epochs. 
A common use for this is when replaying persisted events from the metadata log 
at startup. The log is initialised with {{Epoch.EMPTY}} but rather that 
replaying every single entry since the beginning of history, we select the most 
recent snapshot held locally and start the replay from that point. Likewise, 
when catching up from a peer, a node may receive a snapshot plus subsequent log 
entries. In order to bring local metadata to the same state as the snapshot, a 
{{ForceSnapshot}} with the same epoch as the snapshot is inserted into the 
{{LocalLog}} and enacted like any other other transformation. These synthetic 
transformations should not be persisted in the `system.local_metadata_log`, as 
they do not exist in the distributed metadata log. We _should_ persist the 
snapshot itself in {{system.metadata_snapshots}} so that we can avoid having to 
re-fetch remote snapshots (i.e. if a node were to restart shortly after 
receiving a catchup from a peer).  (was: Per its inline comments, ForceSnapshot 
is a synthetic transformation whose purpose it to enable the local log to jump 
missing epochs. A common use for this is when replaying persisted events from 
the metadata log at startup. The log is initialised with {{Epoch.EMPTY}} but 
rather that replaying every single entry since the beginning of history, we 
select the most recent snapshot held locally and start the replay from that 
point. Likewise, when catching up from a peer, a node may receive a snapshot 
plus subsequent log entries. In order to bring local metadata to the same state 
as the snapshot, a {{ForceSnapshot}} with the same epoch as the snapshot is 
inserted into the {{LocalLog}} and enacted like any other other transformation. 
These synthetic transformations should not be persisted in the 
`system.local_metadata_log`, as they do not exist in the distributed metadata 
log. We _should_ persist the snapshot itself in `system.metadata_snapshots` so 
that we can avoid having to re-fetch remote snapshots (i.e. if a node were to 
restart shortly after receiving a catchup from a peer).)

> ForceSnapshot transformations should not be persisted in the local log table
> 
>
> Key: CASSANDRA-19190
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19190
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Transactional Cluster Metadata
>Reporter: Marcus Eriksson
>Priority: Normal
> Fix For: 5.1-alpha1
>
>
> Per its inline comments, ForceSnapshot is a synthetic transformation whose 
> purpose it to enable the local log to jump missing epochs. A common use for 
> this is when replaying persisted events from the metadata log at startup. The 
> log is initialised with {{Epoch.EMPTY}} but rather that replaying every 
> single entry since the beginning of history, we select the most recent 
> snapshot held locally and start the replay from that point. Likewise, when 
> catching up from a peer, a node may receive a snapshot plus subsequent log 
> entries. In order to bring local metadata to the same state as the snapshot, 
> a {{ForceSnapshot}} with the same epoch as the snapshot is inserted into the 
> {{LocalLog}} and enacted like any other other transformation. These synthetic 
> transformations should not be persisted in the `system.local_metadata_log`, 
> as they do not exist in the distributed metadata log. We _should_ persist the 
> snapshot itself in {{system.metadata_snapshots}} so that we can avoid having 
> to re-fetch remote snapshots (i.e. if a node were to restart shortly after 
> receiving a catchup from a peer).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-19197) OA format serialization/deserialization problem

2023-12-14 Thread Jacek Lewandowski (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-19197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17796751#comment-17796751
 ] 

Jacek Lewandowski commented on CASSANDRA-19197:
---

trunk PR
https://github.com/apache/cassandra/pull/2994

> OA format serialization/deserialization problem
> ---
>
> Key: CASSANDRA-19197
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19197
> Project: Cassandra
>  Issue Type: Bug
>  Components: Legacy/Local Write-Read Paths
>Reporter: Jacek Lewandowski
>Assignee: Jacek Lewandowski
>Priority: Normal
> Fix For: 5.0-rc, 5.1
>
>
> There is a problem with either serialization or deserialization of the new TTL



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-18598) Use trie for literal index building

2023-12-14 Thread Jira


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-18598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andres de la Peña updated CASSANDRA-18598:
--
Status: Review In Progress  (was: Patch Available)

> Use trie for literal index building
> ---
>
> Key: CASSANDRA-18598
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18598
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Feature/SAI
>Reporter: Mike Adamson
>Assignee: Mike Adamson
>Priority: Normal
> Fix For: 5.x
>
>  Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> The BlockBalancedTreeRamBuffer for numerics indexes uses a trie for building 
> indexes in memory before flushing to disk. The RAMStringIndexer for literal 
> indexes does not do this. It uses lucene classes to build the in memory index 
> before flushing.
> We should combine both of the in-memory index builders and have them both use 
> the trie. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-19183) Fix cqlshlib cython test

2023-12-14 Thread Berenguer Blasi (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-19183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17796725#comment-17796725
 ] 

Berenguer Blasi commented on CASSANDRA-19183:
-

No blame game :-) I would have looked if I hadn't been onto some serialization 
problem.

Your branch passes, tested locally and I also prefer making it closer to it's 
sister script. +1 AFAICT

> Fix cqlshlib cython test
> 
>
> Key: CASSANDRA-19183
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19183
> Project: Cassandra
>  Issue Type: Bug
>  Components: Tool/cqlsh
>Reporter: Brandon Williams
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 5.0-beta, 5.x
>
>
> This is failing on 
> [trunk|https://app.circleci.com/pipelines/github/driftx/cassandra/1405/workflows/ff7b5121-b6df-4290-8d63-bcc6d6385724/jobs/65554]
>  and 
> [5.0|https://app.circleci.com/pipelines/github/driftx/cassandra/1406/workflows/f7f2b35c-1233-43d7-a942-218f1712add4/jobs/65649]:
> {quote}
> PermissionError: [Errno 13] Permission denied: '/.ccm'
> {quote}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-19183) Fix cqlshlib cython test

2023-12-14 Thread Brandon Williams (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-19183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17796717#comment-17796717
 ] 

Brandon Williams commented on CASSANDRA-19183:
--

We could alternately replace DIST_DIR with BUILD_DIR, but adding it makes it 
closer to its [sister 
script|https://github.com/apache/cassandra/blob/trunk/.build/run-python-dtests.sh#L46].

> Fix cqlshlib cython test
> 
>
> Key: CASSANDRA-19183
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19183
> Project: Cassandra
>  Issue Type: Bug
>  Components: Tool/cqlsh
>Reporter: Brandon Williams
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 5.0-beta, 5.x
>
>
> This is failing on 
> [trunk|https://app.circleci.com/pipelines/github/driftx/cassandra/1405/workflows/ff7b5121-b6df-4290-8d63-bcc6d6385724/jobs/65554]
>  and 
> [5.0|https://app.circleci.com/pipelines/github/driftx/cassandra/1406/workflows/f7f2b35c-1233-43d7-a942-218f1712add4/jobs/65649]:
> {quote}
> PermissionError: [Errno 13] Permission denied: '/.ccm'
> {quote}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-19183) Fix cqlshlib cython test

2023-12-14 Thread Brandon Williams (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-19183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17796716#comment-17796716
 ] 

Brandon Williams commented on CASSANDRA-19183:
--

Indeed, undefined DIST_DIR was the main issue, it 
[passes|https://app.circleci.com/pipelines/github/driftx/cassandra/1413/workflows/6167a91b-9aa3-4a83-a7d5-9646cd04fa71]
 with that fixed 
[here|https://github.com/driftx/cassandra/commit/1a5fbcabb5482d936494ecc43d91c72fc645acf9].

> Fix cqlshlib cython test
> 
>
> Key: CASSANDRA-19183
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19183
> Project: Cassandra
>  Issue Type: Bug
>  Components: Tool/cqlsh
>Reporter: Brandon Williams
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 5.0-beta, 5.x
>
>
> This is failing on 
> [trunk|https://app.circleci.com/pipelines/github/driftx/cassandra/1405/workflows/ff7b5121-b6df-4290-8d63-bcc6d6385724/jobs/65554]
>  and 
> [5.0|https://app.circleci.com/pipelines/github/driftx/cassandra/1406/workflows/f7f2b35c-1233-43d7-a942-218f1712add4/jobs/65649]:
> {quote}
> PermissionError: [Errno 13] Permission denied: '/.ccm'
> {quote}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-19183) Fix cqlshlib cython test

2023-12-14 Thread Brandon Williams (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-19183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Brandon Williams updated CASSANDRA-19183:
-
Test and Documentation Plan: run CI
 Status: Patch Available  (was: Open)

> Fix cqlshlib cython test
> 
>
> Key: CASSANDRA-19183
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19183
> Project: Cassandra
>  Issue Type: Bug
>  Components: Tool/cqlsh
>Reporter: Brandon Williams
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 5.0-beta, 5.x
>
>
> This is failing on 
> [trunk|https://app.circleci.com/pipelines/github/driftx/cassandra/1405/workflows/ff7b5121-b6df-4290-8d63-bcc6d6385724/jobs/65554]
>  and 
> [5.0|https://app.circleci.com/pipelines/github/driftx/cassandra/1406/workflows/f7f2b35c-1233-43d7-a942-218f1712add4/jobs/65649]:
> {quote}
> PermissionError: [Errno 13] Permission denied: '/.ccm'
> {quote}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-13169) Test failure: org.apache.cassandra.index.sasi.disk.OnDiskIndexTest.testSparseMode-compression

2023-12-14 Thread Jacek Lewandowski (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-13169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17796714#comment-17796714
 ] 

Jacek Lewandowski commented on CASSANDRA-13169:
---

https://app.circleci.com/pipelines/github/jacek-lewandowski/cassandra/1175/workflows/ee8501e7-d301-4153-b33e-08db3d8ec4e6/jobs/56420/tests

> Test failure: 
> org.apache.cassandra.index.sasi.disk.OnDiskIndexTest.testSparseMode-compression
> -
>
> Key: CASSANDRA-13169
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13169
> Project: Cassandra
>  Issue Type: Bug
>  Components: Test/unit
>Reporter: Sean McCarthy
>Assignee: Alex Petrov
>Priority: Normal
> Fix For: 4.1.x, 5.x
>
> Attachments: 
> TEST-org.apache.cassandra.index.sasi.disk.OnDiskIndexTest.log
>
>
> example failure:
> http://cassci.datastax.com/job/trunk_testall/1376/testReport/org.apache.cassandra.index.sasi.disk/OnDiskIndexTest/testSparseMode_compression
> {code}
> Error Message
> expected:<-1> but was:<0>
> {code}{code}
> Stacktrace
> junit.framework.AssertionFailedError: expected:<-1> but was:<0>
>   at 
> org.apache.cassandra.index.sasi.disk.OnDiskIndexTest.testSparseMode(OnDiskIndexTest.java:350)
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-19146) Upgrade owasp to 9.0.x

2023-12-14 Thread Jacek Lewandowski (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-19146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17796708#comment-17796708
 ] 

Jacek Lewandowski commented on CASSANDRA-19146:
---

[~mmuzaf] I've addressed or responded your comments

> Upgrade owasp to 9.0.x
> --
>
> Key: CASSANDRA-19146
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19146
> Project: Cassandra
>  Issue Type: Bug
>  Components: Build
>Reporter: Brandon Williams
>Assignee: Jacek Lewandowski
>Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 5.0-rc, 5.x
>
>
> From https://github.com/jeremylong/DependencyCheck :
> {quote}
> Upgrading to 9.0.0 or later is mandatory; previous versions of 
> dependency-check utilize the NVD data feeds which will be deprecated on Dec 
> 15th, 2023. 
> {quote}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-19183) Fix cqlshlib cython test

2023-12-14 Thread Brandon Williams (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-19183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17796707#comment-17796707
 ] 

Brandon Williams commented on CASSANDRA-19183:
--

All good [~bereng], sorry I falsely blamed you and thanks for your help! :)

> Fix cqlshlib cython test
> 
>
> Key: CASSANDRA-19183
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19183
> Project: Cassandra
>  Issue Type: Bug
>  Components: Tool/cqlsh
>Reporter: Brandon Williams
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 5.0-beta, 5.x
>
>
> This is failing on 
> [trunk|https://app.circleci.com/pipelines/github/driftx/cassandra/1405/workflows/ff7b5121-b6df-4290-8d63-bcc6d6385724/jobs/65554]
>  and 
> [5.0|https://app.circleci.com/pipelines/github/driftx/cassandra/1406/workflows/f7f2b35c-1233-43d7-a942-218f1712add4/jobs/65649]:
> {quote}
> PermissionError: [Errno 13] Permission denied: '/.ccm'
> {quote}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Assigned] (CASSANDRA-19183) Fix cqlshlib cython test

2023-12-14 Thread Brandon Williams (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-19183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Brandon Williams reassigned CASSANDRA-19183:


Assignee: Brandon Williams

> Fix cqlshlib cython test
> 
>
> Key: CASSANDRA-19183
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19183
> Project: Cassandra
>  Issue Type: Bug
>  Components: Tool/cqlsh
>Reporter: Brandon Williams
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 5.0-beta, 5.x
>
>
> This is failing on 
> [trunk|https://app.circleci.com/pipelines/github/driftx/cassandra/1405/workflows/ff7b5121-b6df-4290-8d63-bcc6d6385724/jobs/65554]
>  and 
> [5.0|https://app.circleci.com/pipelines/github/driftx/cassandra/1406/workflows/f7f2b35c-1233-43d7-a942-218f1712add4/jobs/65649]:
> {quote}
> PermissionError: [Errno 13] Permission denied: '/.ccm'
> {quote}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-19183) Fix cqlshlib cython test

2023-12-14 Thread Berenguer Blasi (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-19183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17796706#comment-17796706
 ] 

Berenguer Blasi commented on CASSANDRA-19183:
-

Sorry I couldn't help more, I am onto sthg else atm

> Fix cqlshlib cython test
> 
>
> Key: CASSANDRA-19183
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19183
> Project: Cassandra
>  Issue Type: Bug
>  Components: Tool/cqlsh
>Reporter: Brandon Williams
>Priority: Normal
> Fix For: 5.0-beta, 5.x
>
>
> This is failing on 
> [trunk|https://app.circleci.com/pipelines/github/driftx/cassandra/1405/workflows/ff7b5121-b6df-4290-8d63-bcc6d6385724/jobs/65554]
>  and 
> [5.0|https://app.circleci.com/pipelines/github/driftx/cassandra/1406/workflows/f7f2b35c-1233-43d7-a942-218f1712add4/jobs/65649]:
> {quote}
> PermissionError: [Errno 13] Permission denied: '/.ccm'
> {quote}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-19146) Upgrade owasp to 9.0.x

2023-12-14 Thread Jacek Lewandowski (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-19146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17796697#comment-17796697
 ] 

Jacek Lewandowski commented on CASSANDRA-19146:
---

[~mmuzaf], if you like the 3.0 PR, I can now follow with others, wanted to make 
sure that I wouldn't have to apply comments on each PR

> Upgrade owasp to 9.0.x
> --
>
> Key: CASSANDRA-19146
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19146
> Project: Cassandra
>  Issue Type: Bug
>  Components: Build
>Reporter: Brandon Williams
>Assignee: Jacek Lewandowski
>Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 5.0-rc, 5.x
>
>
> From https://github.com/jeremylong/DependencyCheck :
> {quote}
> Upgrading to 9.0.0 or later is mandatory; previous versions of 
> dependency-check utilize the NVD data feeds which will be deprecated on Dec 
> 15th, 2023. 
> {quote}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-19183) Fix cqlshlib cython test

2023-12-14 Thread Brandon Williams (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-19183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17796699#comment-17796699
 ] 

Brandon Williams commented on CASSANDRA-19183:
--

I believe the problem here is that DIST_DIR is 
[undefined|https://github.com/apache/cassandra/blob/trunk/pylib/cassandra-cqlsh-tests.sh#L31],
 as added by INFRA-25202.

> Fix cqlshlib cython test
> 
>
> Key: CASSANDRA-19183
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19183
> Project: Cassandra
>  Issue Type: Bug
>  Components: Tool/cqlsh
>Reporter: Brandon Williams
>Priority: Normal
> Fix For: 5.0-beta, 5.x
>
>
> This is failing on 
> [trunk|https://app.circleci.com/pipelines/github/driftx/cassandra/1405/workflows/ff7b5121-b6df-4290-8d63-bcc6d6385724/jobs/65554]
>  and 
> [5.0|https://app.circleci.com/pipelines/github/driftx/cassandra/1406/workflows/f7f2b35c-1233-43d7-a942-218f1712add4/jobs/65649]:
> {quote}
> PermissionError: [Errno 13] Permission denied: '/.ccm'
> {quote}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Assigned] (CASSANDRA-19183) Fix cqlshlib cython test

2023-12-14 Thread Jacek Lewandowski (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-19183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacek Lewandowski reassigned CASSANDRA-19183:
-

Assignee: (was: Jacek Lewandowski)

> Fix cqlshlib cython test
> 
>
> Key: CASSANDRA-19183
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19183
> Project: Cassandra
>  Issue Type: Bug
>  Components: Tool/cqlsh
>Reporter: Brandon Williams
>Priority: Normal
> Fix For: 5.0-beta, 5.x
>
>
> This is failing on 
> [trunk|https://app.circleci.com/pipelines/github/driftx/cassandra/1405/workflows/ff7b5121-b6df-4290-8d63-bcc6d6385724/jobs/65554]
>  and 
> [5.0|https://app.circleci.com/pipelines/github/driftx/cassandra/1406/workflows/f7f2b35c-1233-43d7-a942-218f1712add4/jobs/65649]:
> {quote}
> PermissionError: [Errno 13] Permission denied: '/.ccm'
> {quote}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Assigned] (CASSANDRA-19183) Fix cqlshlib cython test

2023-12-14 Thread Jacek Lewandowski (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-19183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacek Lewandowski reassigned CASSANDRA-19183:
-

Assignee: Jacek Lewandowski

> Fix cqlshlib cython test
> 
>
> Key: CASSANDRA-19183
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19183
> Project: Cassandra
>  Issue Type: Bug
>  Components: Tool/cqlsh
>Reporter: Brandon Williams
>Assignee: Jacek Lewandowski
>Priority: Normal
> Fix For: 5.0-beta, 5.x
>
>
> This is failing on 
> [trunk|https://app.circleci.com/pipelines/github/driftx/cassandra/1405/workflows/ff7b5121-b6df-4290-8d63-bcc6d6385724/jobs/65554]
>  and 
> [5.0|https://app.circleci.com/pipelines/github/driftx/cassandra/1406/workflows/f7f2b35c-1233-43d7-a942-218f1712add4/jobs/65649]:
> {quote}
> PermissionError: [Errno 13] Permission denied: '/.ccm'
> {quote}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-19196) Don't allow to enable direct i/o with broken kernels

2023-12-14 Thread Jacek Lewandowski (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-19196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17796678#comment-17796678
 ] 

Jacek Lewandowski commented on CASSANDRA-19196:
---

[~maxwellguo] if this is committed before CASSANDRA-16565, that other ticket 
should handle the upgrade, I've added a note there.

> Don't allow to enable direct i/o with broken kernels
> 
>
> Key: CASSANDRA-19196
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19196
> Project: Cassandra
>  Issue Type: Bug
>  Components: Legacy/Local Write-Read Paths
>Reporter: Jacek Lewandowski
>Assignee: Jacek Lewandowski
>Priority: Normal
> Fix For: 5.0-rc, 5.1
>
> Attachments: signature.asc
>
>
> https://lwn.net/Articles/954285/, found by [~rustyrazorblade]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-16565) Remove dependency on sigar

2023-12-14 Thread Jacek Lewandowski (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-16565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17796677#comment-17796677
 ] 

Jacek Lewandowski commented on CASSANDRA-16565:
---

If we decide to move to OSHI, the PR should consider using OSHI to retrieve the 
kernel version, that is, remove the custom stuff from CASSANDRA-19196.


> Remove dependency on sigar
> --
>
> Key: CASSANDRA-16565
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16565
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Build
>Reporter: David Capwell
>Assignee: Claude Warren
>Priority: Normal
> Fix For: 5.x
>
>
> sigar is used to check if the environment has good settings for running C*, 
> but requires we bundle a lot of native libraries to perform this check (which 
> can also be done elsewhere).  This project also appears to be dead as the 
> last commit was around 6 years ago.
> With the move to resolve artifacts rather than commit them, removing this 
> dependency would remove majority of the artifacts fetched from GitHub.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Comment Edited] (CASSANDRA-19196) Don't allow to enable direct i/o with broken kernels

2023-12-14 Thread Maxwell Guo (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-19196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17796531#comment-17796531
 ] 

Maxwell Guo edited comment on CASSANDRA-19196 at 12/14/23 10:03 AM:


{quote}Trying to make a patch in oshi and get it releases so we can drop a lot 
id stuff here is also an option.{quote}

I agree with what [~mikloso...@pm.me] said if oshi finally meets our needs. But 
there may be some small gaps here:
1.{quote} Too bad they do not seem to parse kernel version as far as I see. 
{quote}
So we may need to add some patch to optimize code to meet our needs, whether it 
is modifying c* or oshi, it will take some time.
2.CASSANDRA-16565 seems to fix for 5.x and CASSANDRA-19196 here is for 5.0rc 
and 5.1 ;

So what about open a new ticket or finish this work of replacing the code with 
oshi (when it is ready and can meet our needs) in CASSANDRA-16565 ? 
[~brandon.williams] [~mikloso...@pm.me][~jlewandowski] WDYT?


was (Author: maxwellguo):
{quote}Trying to make a patch in oshi and get it releases so we can drop a lot 
id stuff here is also an option.{quote}

I agree with what [~mikloso...@pm.me] said if oshi finally meets our needs. But 
there may be some small gaps here:
1.{quote} Too bad they do not seem to parse kernel version as far as I see. 
{quote}
So we may need to add some patch to optimize code to meet our needs, whether it 
is modifying c* or oshi, it will take some time.
2.CASSANDRA-16565 seems to fix for 5.x and CASSANDRA-19196 here is for 5.0rc 
and 5.1 ;

So what about open a new ticket or finish this work of replacing the code with 
oshi (when it is ready and can meet our needs) in CASSANDRA-16565 ? 
[~mikloso...@pm.me][~jlewandowski] WDYT?

> Don't allow to enable direct i/o with broken kernels
> 
>
> Key: CASSANDRA-19196
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19196
> Project: Cassandra
>  Issue Type: Bug
>  Components: Legacy/Local Write-Read Paths
>Reporter: Jacek Lewandowski
>Assignee: Jacek Lewandowski
>Priority: Normal
> Fix For: 5.0-rc, 5.1
>
> Attachments: signature.asc
>
>
> https://lwn.net/Articles/954285/, found by [~rustyrazorblade]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-19197) OA format serialization/deserialization problem

2023-12-14 Thread Jacek Lewandowski (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-19197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacek Lewandowski updated CASSANDRA-19197:
--
Test and Documentation Plan: run regressions  + new tests
 Status: Patch Available  (was: Open)

> OA format serialization/deserialization problem
> ---
>
> Key: CASSANDRA-19197
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19197
> Project: Cassandra
>  Issue Type: Bug
>  Components: Legacy/Local Write-Read Paths
>Reporter: Jacek Lewandowski
>Assignee: Jacek Lewandowski
>Priority: Normal
> Fix For: 5.0-rc, 5.1
>
>
> There is a problem with either serialization or deserialization of the new TTL



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-19197) OA format serialization/deserialization problem

2023-12-14 Thread Berenguer Blasi (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-19197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17796630#comment-17796630
 ] 

Berenguer Blasi commented on CASSANDRA-19197:
-

I don't know if this is meant to be ready for review but I checked the PR and 
so far lgmt besides some doc problems

> OA format serialization/deserialization problem
> ---
>
> Key: CASSANDRA-19197
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19197
> Project: Cassandra
>  Issue Type: Bug
>  Components: Legacy/Local Write-Read Paths
>Reporter: Jacek Lewandowski
>Assignee: Jacek Lewandowski
>Priority: Normal
> Fix For: 5.0-rc, 5.1
>
>
> There is a problem with either serialization or deserialization of the new TTL



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org