[jira] [Commented] (CASSANDRA-19412) delete useless collection:backPressureHosts in the sendToHintedReplicas to improve write performance
[
https://issues.apache.org/jira/browse/CASSANDRA-19412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819106#comment-17819106
]
Stefan Miklosovic commented on CASSANDRA-19412:
---
[CASSANDRA-19412-trunk|https://github.com/instaclustr/cassandra/tree/CASSANDRA-19412-trunk]
{noformat}
java17_pre-commit_tests
✓ j17_build 5m 5s
✓ j17_cqlsh_dtests_py311 7m 12s
✓ j17_cqlsh_dtests_py311_vnode 7m 24s
✓ j17_cqlsh_dtests_py387m 12s
✓ j17_cqlsh_dtests_py38_vnode 7m 1s
✓ j17_cqlshlib_cython_tests7m 36s
✓ j17_cqlshlib_tests 6m 58s
✓ j17_dtests 35m 13s
✓ j17_dtests_vnode36m 12s
✕ j17_jvm_dtests 25m 19s
org.apache.cassandra.distributed.test.NativeTransportEncryptionOptionsTest
testEndpointVerificationEnabledIpNotInSAN TIMEOUTED
✕ j17_jvm_dtests_vnode20m 11s
✕ j17_unit_tests 13m 20s
org.apache.cassandra.index.sai.cql.VectorUpdateDeleteTest updateTest
✕ j17_utests_oa 13m 48s
org.apache.cassandra.index.sai.cql.VectorUpdateDeleteTest updateTest
java17_separate_tests
java11_pre-commit_tests
java11_separate_tests
{noformat}
[java17_pre-commit_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/3902/workflows/777f88fe-e6dc-42a1-aa5d-40a22e8009fa]
[java17_separate_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/3902/workflows/f1d8d323-c08b-40f3-93e3-9b077d38c377]
[java11_pre-commit_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/3902/workflows/4f4d0a17-f8bc-4d58-9f9f-a2d037613aa3]
[java11_separate_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/3902/workflows/1b9bc8dd-74a1-4d99-bdb0-5751a1db2755]
> delete useless collection:backPressureHosts in the sendToHintedReplicas to
> improve write performance
>
>
> Key: CASSANDRA-19412
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19412
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Local Write-Read Paths
>Reporter: Ling Mao
>Assignee: Ling Mao
>Priority: Low
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Every normal write request will go through this
> method({_}*sendToHintedReplicas*{_}). However, the list:backPressureHosts in
> the method has never been used functionally.
> The _*backpressure*_ was introduced by:
> {code:java}
> Support optional backpressure strategies at the coordinator
> patch by Sergio Bossa; reviewed by Stefania Alborghetti for CASSANDRA-9318
> d43b9ce5 Sergio Bossa on 2016/9/19 at 10:42 AM {code}
> {code:java}
> public static void sendToHintedEndpoints(final Mutation mutation,
> Iterable targets,
>
> AbstractWriteResponseHandler responseHandler,
> String localDataCenter,
> Stage stage)
> throws OverloadedException
> {
> int targetsSize = Iterables.size(targets);
> // this dc replicas:
> Collection localDc = null;
> // extra-datacenter replicas, grouped by dc
> Map> dcGroups = null;
> // only need to create a Message for non-local writes
> MessageOut message = null;
> boolean insertLocal = false;
> ArrayList endpointsToHint = null;
> List backPressureHosts = null;
> for (InetAddress destination : targets)
> {
> checkHintOverload(destination);
> if (FailureDetector.instance.isAlive(destination))
> {
> if (canDoLocalRequest(destination))
> {
> insertLocal = true;
> }
> else
> {
> // belongs on a different server
> if (message == null)
> message = mutation.createMessage();
> String dc =
> DatabaseDescriptor.getEndpointSnitch().getDatacenter(destination);
> // direct writes to local DC or old Cassandra versions
> // (1.1 knows how to forward old-style String message
> IDs; updated to int in 2.0)
> if (localDataCenter.equals(dc))
> {
> if
[jira] [Commented] (CASSANDRA-19407) Drop one JVM tests run from pre-commit pipeline
[ https://issues.apache.org/jira/browse/CASSANDRA-19407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819087#comment-17819087 ] Berenguer Blasi commented on CASSANDRA-19407: - I think it means sthg along those lines correct, varying jvms depending on the branch. There was also the ask to be able to choose which jvm of the typical 2 available you want to run... I'll get to it once I get the other 2 merged. > Drop one JVM tests run from pre-commit pipeline > --- > > Key: CASSANDRA-19407 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19407 > Project: Cassandra > Issue Type: Task >Reporter: Jacek Lewandowski >Assignee: Berenguer Blasi >Priority: Normal > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19412) delete useless collection:backPressureHosts in the sendToHintedReplicas to improve write performance
[
https://issues.apache.org/jira/browse/CASSANDRA-19412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819039#comment-17819039
]
Maxwell Guo commented on CASSANDRA-19412:
-
Thanks [~smiklosovic], and +1 on start the builds.
> delete useless collection:backPressureHosts in the sendToHintedReplicas to
> improve write performance
>
>
> Key: CASSANDRA-19412
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19412
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Local Write-Read Paths
>Reporter: Ling Mao
>Assignee: Ling Mao
>Priority: Low
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Every normal write request will go through this
> method({_}*sendToHintedReplicas*{_}). However, the list:backPressureHosts in
> the method has never been used functionally.
> The _*backpressure*_ was introduced by:
> {code:java}
> Support optional backpressure strategies at the coordinator
> patch by Sergio Bossa; reviewed by Stefania Alborghetti for CASSANDRA-9318
> d43b9ce5 Sergio Bossa on 2016/9/19 at 10:42 AM {code}
> {code:java}
> public static void sendToHintedEndpoints(final Mutation mutation,
> Iterable targets,
>
> AbstractWriteResponseHandler responseHandler,
> String localDataCenter,
> Stage stage)
> throws OverloadedException
> {
> int targetsSize = Iterables.size(targets);
> // this dc replicas:
> Collection localDc = null;
> // extra-datacenter replicas, grouped by dc
> Map> dcGroups = null;
> // only need to create a Message for non-local writes
> MessageOut message = null;
> boolean insertLocal = false;
> ArrayList endpointsToHint = null;
> List backPressureHosts = null;
> for (InetAddress destination : targets)
> {
> checkHintOverload(destination);
> if (FailureDetector.instance.isAlive(destination))
> {
> if (canDoLocalRequest(destination))
> {
> insertLocal = true;
> }
> else
> {
> // belongs on a different server
> if (message == null)
> message = mutation.createMessage();
> String dc =
> DatabaseDescriptor.getEndpointSnitch().getDatacenter(destination);
> // direct writes to local DC or old Cassandra versions
> // (1.1 knows how to forward old-style String message
> IDs; updated to int in 2.0)
> if (localDataCenter.equals(dc))
> {
> if (localDc == null)
> localDc = new ArrayList<>(targetsSize);
> localDc.add(destination);
> }
> else
> {
> Collection messages = (dcGroups != null)
> ? dcGroups.get(dc) : null;
> if (messages == null)
> {
> messages = new ArrayList<>(3); // most DCs will
> have <= 3 replicas
> if (dcGroups == null)
> dcGroups = new HashMap<>();
> dcGroups.put(dc, messages);
> }
> messages.add(destination);
> }
> if (backPressureHosts == null)
> backPressureHosts = new ArrayList<>(targetsSize);
> backPressureHosts.add(destination);
> }
> }
> else
> {
> if (shouldHint(destination))
> {
> if (endpointsToHint == null)
> endpointsToHint = new ArrayList<>(targetsSize);
> endpointsToHint.add(destination);
> }
> }
> }
> if (backPressureHosts != null)
> MessagingService.instance().applyBackPressure(backPressureHosts,
> responseHandler.currentTimeout());
> if (endpointsToHint != null)
> submitHint(mutation, endpointsToHint, responseHandler);
> if (insertLocal)
> performLocally(stage, Optional.of(mutation), mutation::apply,
> responseHandler);
> if (localDc != null)
> {
> for (InetAddress destination : localDc)
> MessagingService.instance().sendRR(message, destination,
> responseHandler,
[jira] [Assigned] (CASSANDRA-19412) delete useless collection:backPressureHosts in the sendToHintedReplicas to improve write performance
[
https://issues.apache.org/jira/browse/CASSANDRA-19412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maxwell Guo reassigned CASSANDRA-19412:
---
Assignee: Ling Mao (was: Maxwell Guo)
> delete useless collection:backPressureHosts in the sendToHintedReplicas to
> improve write performance
>
>
> Key: CASSANDRA-19412
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19412
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Local Write-Read Paths
>Reporter: Ling Mao
>Assignee: Ling Mao
>Priority: Low
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Every normal write request will go through this
> method({_}*sendToHintedReplicas*{_}). However, the list:backPressureHosts in
> the method has never been used functionally.
> The _*backpressure*_ was introduced by:
> {code:java}
> Support optional backpressure strategies at the coordinator
> patch by Sergio Bossa; reviewed by Stefania Alborghetti for CASSANDRA-9318
> d43b9ce5 Sergio Bossa on 2016/9/19 at 10:42 AM {code}
> {code:java}
> public static void sendToHintedEndpoints(final Mutation mutation,
> Iterable targets,
>
> AbstractWriteResponseHandler responseHandler,
> String localDataCenter,
> Stage stage)
> throws OverloadedException
> {
> int targetsSize = Iterables.size(targets);
> // this dc replicas:
> Collection localDc = null;
> // extra-datacenter replicas, grouped by dc
> Map> dcGroups = null;
> // only need to create a Message for non-local writes
> MessageOut message = null;
> boolean insertLocal = false;
> ArrayList endpointsToHint = null;
> List backPressureHosts = null;
> for (InetAddress destination : targets)
> {
> checkHintOverload(destination);
> if (FailureDetector.instance.isAlive(destination))
> {
> if (canDoLocalRequest(destination))
> {
> insertLocal = true;
> }
> else
> {
> // belongs on a different server
> if (message == null)
> message = mutation.createMessage();
> String dc =
> DatabaseDescriptor.getEndpointSnitch().getDatacenter(destination);
> // direct writes to local DC or old Cassandra versions
> // (1.1 knows how to forward old-style String message
> IDs; updated to int in 2.0)
> if (localDataCenter.equals(dc))
> {
> if (localDc == null)
> localDc = new ArrayList<>(targetsSize);
> localDc.add(destination);
> }
> else
> {
> Collection messages = (dcGroups != null)
> ? dcGroups.get(dc) : null;
> if (messages == null)
> {
> messages = new ArrayList<>(3); // most DCs will
> have <= 3 replicas
> if (dcGroups == null)
> dcGroups = new HashMap<>();
> dcGroups.put(dc, messages);
> }
> messages.add(destination);
> }
> if (backPressureHosts == null)
> backPressureHosts = new ArrayList<>(targetsSize);
> backPressureHosts.add(destination);
> }
> }
> else
> {
> if (shouldHint(destination))
> {
> if (endpointsToHint == null)
> endpointsToHint = new ArrayList<>(targetsSize);
> endpointsToHint.add(destination);
> }
> }
> }
> if (backPressureHosts != null)
> MessagingService.instance().applyBackPressure(backPressureHosts,
> responseHandler.currentTimeout());
> if (endpointsToHint != null)
> submitHint(mutation, endpointsToHint, responseHandler);
> if (insertLocal)
> performLocally(stage, Optional.of(mutation), mutation::apply,
> responseHandler);
> if (localDc != null)
> {
> for (InetAddress destination : localDc)
> MessagingService.instance().sendRR(message, destination,
> responseHandler, true);
> }
> if (dcGroups
[jira] [Assigned] (CASSANDRA-19412) delete useless collection:backPressureHosts in the sendToHintedReplicas to improve write performance
[
https://issues.apache.org/jira/browse/CASSANDRA-19412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maxwell Guo reassigned CASSANDRA-19412:
---
Assignee: Maxwell Guo (was: Ling Mao)
> delete useless collection:backPressureHosts in the sendToHintedReplicas to
> improve write performance
>
>
> Key: CASSANDRA-19412
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19412
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Local Write-Read Paths
>Reporter: Ling Mao
>Assignee: Maxwell Guo
>Priority: Low
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Every normal write request will go through this
> method({_}*sendToHintedReplicas*{_}). However, the list:backPressureHosts in
> the method has never been used functionally.
> The _*backpressure*_ was introduced by:
> {code:java}
> Support optional backpressure strategies at the coordinator
> patch by Sergio Bossa; reviewed by Stefania Alborghetti for CASSANDRA-9318
> d43b9ce5 Sergio Bossa on 2016/9/19 at 10:42 AM {code}
> {code:java}
> public static void sendToHintedEndpoints(final Mutation mutation,
> Iterable targets,
>
> AbstractWriteResponseHandler responseHandler,
> String localDataCenter,
> Stage stage)
> throws OverloadedException
> {
> int targetsSize = Iterables.size(targets);
> // this dc replicas:
> Collection localDc = null;
> // extra-datacenter replicas, grouped by dc
> Map> dcGroups = null;
> // only need to create a Message for non-local writes
> MessageOut message = null;
> boolean insertLocal = false;
> ArrayList endpointsToHint = null;
> List backPressureHosts = null;
> for (InetAddress destination : targets)
> {
> checkHintOverload(destination);
> if (FailureDetector.instance.isAlive(destination))
> {
> if (canDoLocalRequest(destination))
> {
> insertLocal = true;
> }
> else
> {
> // belongs on a different server
> if (message == null)
> message = mutation.createMessage();
> String dc =
> DatabaseDescriptor.getEndpointSnitch().getDatacenter(destination);
> // direct writes to local DC or old Cassandra versions
> // (1.1 knows how to forward old-style String message
> IDs; updated to int in 2.0)
> if (localDataCenter.equals(dc))
> {
> if (localDc == null)
> localDc = new ArrayList<>(targetsSize);
> localDc.add(destination);
> }
> else
> {
> Collection messages = (dcGroups != null)
> ? dcGroups.get(dc) : null;
> if (messages == null)
> {
> messages = new ArrayList<>(3); // most DCs will
> have <= 3 replicas
> if (dcGroups == null)
> dcGroups = new HashMap<>();
> dcGroups.put(dc, messages);
> }
> messages.add(destination);
> }
> if (backPressureHosts == null)
> backPressureHosts = new ArrayList<>(targetsSize);
> backPressureHosts.add(destination);
> }
> }
> else
> {
> if (shouldHint(destination))
> {
> if (endpointsToHint == null)
> endpointsToHint = new ArrayList<>(targetsSize);
> endpointsToHint.add(destination);
> }
> }
> }
> if (backPressureHosts != null)
> MessagingService.instance().applyBackPressure(backPressureHosts,
> responseHandler.currentTimeout());
> if (endpointsToHint != null)
> submitHint(mutation, endpointsToHint, responseHandler);
> if (insertLocal)
> performLocally(stage, Optional.of(mutation), mutation::apply,
> responseHandler);
> if (localDc != null)
> {
> for (InetAddress destination : localDc)
> MessagingService.instance().sendRR(message, destination,
> responseHandler, true);
> }
> if
Re: [PR] Changelog updates to reflect work that went out in 4.18.0 [cassandra-java-driver]
tolbertam commented on code in PR #1914: URL: https://github.com/apache/cassandra-java-driver/pull/1914#discussion_r1496556628 ## changelog/README.md: ## @@ -21,6 +21,16 @@ under the License. +### 4.18.0 + +- [improvement] PR 1689: Add support for publishing percentile time series for the histogram metrics (nparaddi-walmart) Review Comment: I like including the CASSANDRA jira if there is one, I think the particular cases where there is no jira, referencing the PR is good (which I think was both of these) :+1: At some point will be push for all contributions to be tied to a jira ticket? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] CASSANDRA-18969 headers [4.1.0_fixes] [cassandra-java-driver]
absurdfarce closed pull request #1759: CASSANDRA-18969 headers [4.1.0_fixes] URL: https://github.com/apache/cassandra-java-driver/pull/1759 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] CASSANDRA-16969-copyright-check-4.11.x [cassandra-java-driver]
absurdfarce closed pull request #1763: CASSANDRA-16969-copyright-check-4.11.x URL: https://github.com/apache/cassandra-java-driver/pull/1763 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] CASSANDRA-16969 4.12.x license check [cassandra-java-driver]
absurdfarce commented on PR #1764: URL: https://github.com/apache/cassandra-java-driver/pull/1764#issuecomment-1954949173 Closing based on quick conversation with @Claudenw -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] CASSANDRA-16969-copyright-check-4.2.x [cassandra-java-driver]
absurdfarce closed pull request #1765: CASSANDRA-16969-copyright-check-4.2.x URL: https://github.com/apache/cassandra-java-driver/pull/1765 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] CASSANDRA-18969 - added missing copyrights [4.x] [cassandra-java-driver]
absurdfarce commented on PR #1742: URL: https://github.com/apache/cassandra-java-driver/pull/1742#issuecomment-1954950669 Closing based on quick conversation with @Claudenw -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] CASSANDRA-18969 - added missing copyrights [4.x] [cassandra-java-driver]
absurdfarce closed pull request #1742: CASSANDRA-18969 - added missing copyrights [4.x] URL: https://github.com/apache/cassandra-java-driver/pull/1742 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] CASSANDRA-18969 - added missing license headers [4.x] [cassandra-java-driver]
absurdfarce commented on PR #1758: URL: https://github.com/apache/cassandra-java-driver/pull/1758#issuecomment-1954950405 Closing based on quick conversation with @Claudenw -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] CASSANDRA-18969 - added missing license headers [4.x] [cassandra-java-driver]
absurdfarce closed pull request #1758: CASSANDRA-18969 - added missing license headers [4.x] URL: https://github.com/apache/cassandra-java-driver/pull/1758 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] CASSANDRA-16969-copyright-check-4.3.0_fixes [cassandra-java-driver]
absurdfarce closed pull request #1767: CASSANDRA-16969-copyright-check-4.3.0_fixes URL: https://github.com/apache/cassandra-java-driver/pull/1767 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] CASSANDRA-18969 headers [4.1.0_fixes] [cassandra-java-driver]
absurdfarce commented on PR #1759: URL: https://github.com/apache/cassandra-java-driver/pull/1759#issuecomment-1954950233 Closing based on quick conversation with @Claudenw -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] CASSANDRA-16969-copyright-check-4.1.0_fixes [cassandra-java-driver]
absurdfarce commented on PR #1762: URL: https://github.com/apache/cassandra-java-driver/pull/1762#issuecomment-1954949590 Closing based on quick conversation with @Claudenw -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] CASSANDRA-16969-copyright-check-4.1.0_fixes [cassandra-java-driver]
absurdfarce closed pull request #1762: CASSANDRA-16969-copyright-check-4.1.0_fixes URL: https://github.com/apache/cassandra-java-driver/pull/1762 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] CASSANDRA-16969-copyright-check-4.11.x [cassandra-java-driver]
absurdfarce commented on PR #1763: URL: https://github.com/apache/cassandra-java-driver/pull/1763#issuecomment-1954949434 Closing based on quick conversation with @Claudenw -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] CASSANDRA-16969 4.12.x license check [cassandra-java-driver]
absurdfarce closed pull request #1764: CASSANDRA-16969 4.12.x license check URL: https://github.com/apache/cassandra-java-driver/pull/1764 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] CASSANDRA-16969-copyright-check-4.2.x [cassandra-java-driver]
absurdfarce commented on PR #1765: URL: https://github.com/apache/cassandra-java-driver/pull/1765#issuecomment-1954948886 Closing based on quick conversation with @Claudenw -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] CASSANDRA-16969-copyright-check-4.3.x [cassandra-java-driver]
absurdfarce commented on PR #1766: URL: https://github.com/apache/cassandra-java-driver/pull/1766#issuecomment-1954948705 Closing based on quick conversation with @Claudenw -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] CASSANDRA-16969-copyright-check-4.3.x [cassandra-java-driver]
absurdfarce closed pull request #1766: CASSANDRA-16969-copyright-check-4.3.x URL: https://github.com/apache/cassandra-java-driver/pull/1766 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] CASSANDRA-16969-copyright-check-4.3.0_fixes [cassandra-java-driver]
absurdfarce commented on PR #1767: URL: https://github.com/apache/cassandra-java-driver/pull/1767#issuecomment-1954948486 Closing based on quick conversation with @Claudenw -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] CASSANDRA-16969-copyright-check-4.5.x [cassandra-java-driver]
absurdfarce commented on PR #1769: URL: https://github.com/apache/cassandra-java-driver/pull/1769#issuecomment-1954948108 Closing based on quick conversation with @Claudenw -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] CASSANDRA-16969-copyright-check-4.5.x [cassandra-java-driver]
absurdfarce closed pull request #1769: CASSANDRA-16969-copyright-check-4.5.x URL: https://github.com/apache/cassandra-java-driver/pull/1769 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] CASSANDRA-16969-copyright-check-4.4.0 fixes [cassandra-java-driver]
absurdfarce commented on PR #1768: URL: https://github.com/apache/cassandra-java-driver/pull/1768#issuecomment-1954948316 Closing based on quick conversation with @Claudenw -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] CASSANDRA-16969-copyright-check-4.4.0 fixes [cassandra-java-driver]
absurdfarce closed pull request #1768: CASSANDRA-16969-copyright-check-4.4.0 fixes URL: https://github.com/apache/cassandra-java-driver/pull/1768 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] CASSANDRA-16969-copyright-check-4.5.0 fixes [cassandra-java-driver]
absurdfarce closed pull request #1770: CASSANDRA-16969-copyright-check-4.5.0 fixes URL: https://github.com/apache/cassandra-java-driver/pull/1770 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] CASSANDRA-16969-copyright-check-4.6.x [cassandra-java-driver]
absurdfarce commented on PR #1771: URL: https://github.com/apache/cassandra-java-driver/pull/1771#issuecomment-1954947594 Closing based on quick conversation with @Claudenw -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] CASSANDRA-16969-copyright-check-4.7.x [cassandra-java-driver]
absurdfarce commented on PR #1773: URL: https://github.com/apache/cassandra-java-driver/pull/1773#issuecomment-1954946883 Closing based on quick conversation with @Claudenw -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] CASSANDRA-16969-copyright-check-4.7.x [cassandra-java-driver]
absurdfarce closed pull request #1773: CASSANDRA-16969-copyright-check-4.7.x URL: https://github.com/apache/cassandra-java-driver/pull/1773 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] CASSANDRA-16969-copyright-check-4.8.0 fixes [cassandra-java-driver]
absurdfarce closed pull request #1774: CASSANDRA-16969-copyright-check-4.8.0 fixes URL: https://github.com/apache/cassandra-java-driver/pull/1774 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] CASSANDRA-16969-copyright-check-4.5.0 fixes [cassandra-java-driver]
absurdfarce commented on PR #1770: URL: https://github.com/apache/cassandra-java-driver/pull/1770#issuecomment-1954947930 Closing based on quick conversation with @Claudenw -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] CASSANDRA-16969-copyright-check-4.6.x [cassandra-java-driver]
absurdfarce closed pull request #1771: CASSANDRA-16969-copyright-check-4.6.x URL: https://github.com/apache/cassandra-java-driver/pull/1771 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] CASSANDRA-16969-copyright-check-4.6.1 fixes [cassandra-java-driver]
absurdfarce commented on PR #1772: URL: https://github.com/apache/cassandra-java-driver/pull/1772#issuecomment-1954947202 Closing based on quick conversation with @Claudenw -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] CASSANDRA-16969-copyright-check-4.6.1 fixes [cassandra-java-driver]
absurdfarce closed pull request #1772: CASSANDRA-16969-copyright-check-4.6.1 fixes URL: https://github.com/apache/cassandra-java-driver/pull/1772 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] CASSANDRA-16969-copyright-check-4.8.0 fixes [cassandra-java-driver]
absurdfarce commented on PR #1774: URL: https://github.com/apache/cassandra-java-driver/pull/1774#issuecomment-1954946357 Closing based on quick conversation with @Claudenw -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] CASSANDRA-16969 4.11.x license check [cassandra-java-driver]
absurdfarce commented on PR #1775: URL: https://github.com/apache/cassandra-java-driver/pull/1775#issuecomment-1954945989 Closing based on quick conversation with @Claudenw -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] CASSANDRA-16969 4.11.x license check [cassandra-java-driver]
absurdfarce closed pull request #1775: CASSANDRA-16969 4.11.x license check URL: https://github.com/apache/cassandra-java-driver/pull/1775 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] CASSANDRA-16969 4.12.x copyright check [cassandra-java-driver]
absurdfarce closed pull request #1776: CASSANDRA-16969 4.12.x copyright check URL: https://github.com/apache/cassandra-java-driver/pull/1776 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] CASSANDRA-16969 4.12.x copyright check [cassandra-java-driver]
absurdfarce commented on PR #1776: URL: https://github.com/apache/cassandra-java-driver/pull/1776#issuecomment-1954945423 Closing based on quick conversation with @Claudenw -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] CASSANDRA-16969 4.3.0 fixes license check [cassandra-java-driver]
absurdfarce commented on PR #1778: URL: https://github.com/apache/cassandra-java-driver/pull/1778#issuecomment-1954944379 Closing based on quick conversation with @Claudenw -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] CASSANDRA-16969 4.2.x license check [cassandra-java-driver]
absurdfarce closed pull request #1777: CASSANDRA-16969 4.2.x license check URL: https://github.com/apache/cassandra-java-driver/pull/1777 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] CASSANDRA-16969 4.2.x license check [cassandra-java-driver]
absurdfarce commented on PR #1777: URL: https://github.com/apache/cassandra-java-driver/pull/1777#issuecomment-1954944966 Closing based on quick conversation with @Claudenw -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] CASSANDRA-16969 4.3.0 fixes license check [cassandra-java-driver]
absurdfarce closed pull request #1778: CASSANDRA-16969 4.3.0 fixes license check URL: https://github.com/apache/cassandra-java-driver/pull/1778 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] CASSANDRA-16969 4.3.x license check [cassandra-java-driver]
absurdfarce commented on PR #1779: URL: https://github.com/apache/cassandra-java-driver/pull/1779#issuecomment-1954943972 Closing based on quick conversation with @Claudenw -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] CASSANDRA-16969 4.4.0 fixes license check [cassandra-java-driver]
absurdfarce commented on PR #1780: URL: https://github.com/apache/cassandra-java-driver/pull/1780#issuecomment-1954943594 Closing based on quick conversation with @Claudenw -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] CASSANDRA-16969 4.3.x license check [cassandra-java-driver]
absurdfarce closed pull request #1779: CASSANDRA-16969 4.3.x license check URL: https://github.com/apache/cassandra-java-driver/pull/1779 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] CASSANDRA-16969 4.4.0 fixes license check [cassandra-java-driver]
absurdfarce closed pull request #1780: CASSANDRA-16969 4.4.0 fixes license check URL: https://github.com/apache/cassandra-java-driver/pull/1780 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] CASSANDRA-16969 4.5.0 fixes license check [cassandra-java-driver]
absurdfarce commented on PR #1781: URL: https://github.com/apache/cassandra-java-driver/pull/1781#issuecomment-1954943216 Closing based on quick conversation with @Claudenw -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] CASSANDRA-16969 4.5.0 fixes license check [cassandra-java-driver]
absurdfarce closed pull request #1781: CASSANDRA-16969 4.5.0 fixes license check URL: https://github.com/apache/cassandra-java-driver/pull/1781 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] CASSANDRA-16969 4.5.x license check [cassandra-java-driver]
absurdfarce closed pull request #1782: CASSANDRA-16969 4.5.x license check URL: https://github.com/apache/cassandra-java-driver/pull/1782 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] CASSANDRA-16969 4.5.x license check [cassandra-java-driver]
absurdfarce commented on PR #1782: URL: https://github.com/apache/cassandra-java-driver/pull/1782#issuecomment-1954942951 Closing based on quick conversation with @Claudenw -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] CASSANDRA-16969 4.6.1 fixes license check [cassandra-java-driver]
absurdfarce commented on PR #1783: URL: https://github.com/apache/cassandra-java-driver/pull/1783#issuecomment-1954942724 Closing based on quick conversation with @Claudenw -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] CASSANDRA-16969 4.6.1 fixes license check [cassandra-java-driver]
absurdfarce closed pull request #1783: CASSANDRA-16969 4.6.1 fixes license check URL: https://github.com/apache/cassandra-java-driver/pull/1783 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] CASSANDRA-16969 4.6.x license check [cassandra-java-driver]
absurdfarce closed pull request #1784: CASSANDRA-16969 4.6.x license check URL: https://github.com/apache/cassandra-java-driver/pull/1784 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] CASSANDRA-16969 4.6.x license check [cassandra-java-driver]
absurdfarce commented on PR #1784: URL: https://github.com/apache/cassandra-java-driver/pull/1784#issuecomment-1954942491 Closing based on quick conversation with @Claudenw -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] CASSANDRA-16969 4.7.x license check [cassandra-java-driver]
absurdfarce closed pull request #1785: CASSANDRA-16969 4.7.x license check URL: https://github.com/apache/cassandra-java-driver/pull/1785 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] CASSANDRA-16969 4.7.x license check [cassandra-java-driver]
absurdfarce commented on PR #1785: URL: https://github.com/apache/cassandra-java-driver/pull/1785#issuecomment-1954942058 Closing based on quick conversation with @Claudenw -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-19416) fix "if" condition for mx4j tool in cassandra-env.sh
[
https://issues.apache.org/jira/browse/CASSANDRA-19416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818948#comment-17818948
]
Brandon Williams edited comment on CASSANDRA-19416 at 2/20/24 6:59 PM:
---
No, I think it's fine to skip, nothing will test this anyway. We should make
sure this still works in bash though.
was (Author: brandon.williams):
No, I think it's fine to skip, nothing will test this anyway.
> fix "if" condition for mx4j tool in cassandra-env.sh
>
>
> Key: CASSANDRA-19416
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19416
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Tools
>Reporter: Stefan Miklosovic
>Assignee: Stefan Miklosovic
>Priority: Normal
> Fix For: 4.0.x, 4.1.x, 5.0.x, 5.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> There is this in cassandra-env.sh
> {code}
> if [[ "$MX4J_ADDRESS" == \-Dmx4jaddress* ]]; then
> {code}
> (similar for port)
> This is wrong for /bin/sh shell (our shebang in bin/cassandra) and this does
> not work, probably in bash only, because /bin/sh does not understand what
> "[[" is nor it understand what "==" is.
> The reason this was never detected so far is that the logic will never come
> there when MX4J_ADDRESS and / or MX4J_PORT is commented out couple lines
> above.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19416) fix "if" condition for mx4j tool in cassandra-env.sh
[
https://issues.apache.org/jira/browse/CASSANDRA-19416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818948#comment-17818948
]
Brandon Williams commented on CASSANDRA-19416:
--
No, I think it's fine to skip, nothing will test this anyway.
> fix "if" condition for mx4j tool in cassandra-env.sh
>
>
> Key: CASSANDRA-19416
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19416
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Tools
>Reporter: Stefan Miklosovic
>Assignee: Stefan Miklosovic
>Priority: Normal
> Fix For: 4.0.x, 4.1.x, 5.0.x, 5.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> There is this in cassandra-env.sh
> {code}
> if [[ "$MX4J_ADDRESS" == \-Dmx4jaddress* ]]; then
> {code}
> (similar for port)
> This is wrong for /bin/sh shell (our shebang in bin/cassandra) and this does
> not work, probably in bash only, because /bin/sh does not understand what
> "[[" is nor it understand what "==" is.
> The reason this was never detected so far is that the logic will never come
> there when MX4J_ADDRESS and / or MX4J_PORT is commented out couple lines
> above.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-19416) fix "if" condition for mx4j tool in cassandra-env.sh
[
https://issues.apache.org/jira/browse/CASSANDRA-19416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818943#comment-17818943
]
Stefan Miklosovic edited comment on CASSANDRA-19416 at 2/20/24 6:46 PM:
[~brandon.williams] is it necessary to provide builds for all branches back to
4.0? I think it is super straightforward patch and might be just merged as is.
was (Author: smiklosovic):
[~brandon.williams] is it necessary to provide build for all branches back to
4.0? I think it is super straightforward patch and might be just merged as is.
> fix "if" condition for mx4j tool in cassandra-env.sh
>
>
> Key: CASSANDRA-19416
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19416
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Tools
>Reporter: Stefan Miklosovic
>Assignee: Stefan Miklosovic
>Priority: Normal
> Fix For: 4.0.x, 4.1.x, 5.0.x, 5.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> There is this in cassandra-env.sh
> {code}
> if [[ "$MX4J_ADDRESS" == \-Dmx4jaddress* ]]; then
> {code}
> (similar for port)
> This is wrong for /bin/sh shell (our shebang in bin/cassandra) and this does
> not work, probably in bash only, because /bin/sh does not understand what
> "[[" is nor it understand what "==" is.
> The reason this was never detected so far is that the logic will never come
> there when MX4J_ADDRESS and / or MX4J_PORT is commented out couple lines
> above.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19416) fix "if" condition for mx4j tool in cassandra-env.sh
[
https://issues.apache.org/jira/browse/CASSANDRA-19416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Miklosovic updated CASSANDRA-19416:
--
Bug Category: Parent values: Correctness(12982)
Complexity: Low Hanging Fruit
Discovered By: Adhoc Test
Severity: Low
Status: Open (was: Triage Needed)
> fix "if" condition for mx4j tool in cassandra-env.sh
>
>
> Key: CASSANDRA-19416
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19416
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Tools
>Reporter: Stefan Miklosovic
>Assignee: Stefan Miklosovic
>Priority: Normal
> Fix For: 4.0.x, 4.1.x, 5.0.x, 5.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> There is this in cassandra-env.sh
> {code}
> if [[ "$MX4J_ADDRESS" == \-Dmx4jaddress* ]]; then
> {code}
> (similar for port)
> This is wrong for /bin/sh shell (our shebang in bin/cassandra) and this does
> not work, probably in bash only, because /bin/sh does not understand what
> "[[" is nor it understand what "==" is.
> The reason this was never detected so far is that the logic will never come
> there when MX4J_ADDRESS and / or MX4J_PORT is commented out couple lines
> above.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19416) fix "if" condition for mx4j tool in cassandra-env.sh
[
https://issues.apache.org/jira/browse/CASSANDRA-19416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Miklosovic updated CASSANDRA-19416:
--
Test and Documentation Plan: manual verification
Status: Patch Available (was: Open)
https://github.com/apache/cassandra/pull/3119/files
> fix "if" condition for mx4j tool in cassandra-env.sh
>
>
> Key: CASSANDRA-19416
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19416
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Tools
>Reporter: Stefan Miklosovic
>Assignee: Stefan Miklosovic
>Priority: Normal
> Fix For: 4.0.x, 4.1.x, 5.0.x, 5.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> There is this in cassandra-env.sh
> {code}
> if [[ "$MX4J_ADDRESS" == \-Dmx4jaddress* ]]; then
> {code}
> (similar for port)
> This is wrong for /bin/sh shell (our shebang in bin/cassandra) and this does
> not work, probably in bash only, because /bin/sh does not understand what
> "[[" is nor it understand what "==" is.
> The reason this was never detected so far is that the logic will never come
> there when MX4J_ADDRESS and / or MX4J_PORT is commented out couple lines
> above.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-19415) Documentation work to accomplish for C* 5.1 launch
Lorina Poland created CASSANDRA-19415: - Summary: Documentation work to accomplish for C* 5.1 launch Key: CASSANDRA-19415 URL: https://issues.apache.org/jira/browse/CASSANDRA-19415 Project: Cassandra Issue Type: Epic Components: Documentation Reporter: Lorina Poland -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18229) Write docs for CEP-15
[ https://issues.apache.org/jira/browse/CASSANDRA-18229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lorina Poland updated CASSANDRA-18229: -- Epic Link: CASSANDRA-19415 (was: CASSANDRA-18227) > Write docs for CEP-15 > - > > Key: CASSANDRA-18229 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18229 > Project: Cassandra > Issue Type: New Feature > Components: Documentation >Reporter: Lorina Poland >Assignee: Lorina Poland >Priority: High > Fix For: 5.x > > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18234) Write docs for CEP-21
[ https://issues.apache.org/jira/browse/CASSANDRA-18234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lorina Poland updated CASSANDRA-18234: -- Epic Link: CASSANDRA-19415 (was: CASSANDRA-18227) > Write docs for CEP-21 > - > > Key: CASSANDRA-18234 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18234 > Project: Cassandra > Issue Type: New Feature > Components: Documentation >Reporter: Lorina Poland >Assignee: Lorina Poland >Priority: High > Fix For: 5.x > > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19284) Harry overrides model
[ https://issues.apache.org/jira/browse/CASSANDRA-19284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Petrov updated CASSANDRA-19284: Reviewers: Caleb Rackliffe Status: Review In Progress (was: Patch Available) > Harry overrides model > - > > Key: CASSANDRA-19284 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19284 > Project: Cassandra > Issue Type: New Feature > Components: Test/fuzz >Reporter: Alex Petrov >Assignee: Alex Petrov >Priority: High > Attachments: ci_summary.html, result_details.tar.gz > > > Harry model to allow providing specific values for the test. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-19407) Drop one JVM tests run from pre-commit pipeline
[
https://issues.apache.org/jira/browse/CASSANDRA-19407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818912#comment-17818912
]
Ekaterina Dimitrova edited comment on CASSANDRA-19407 at 2/20/24 5:05 PM:
--
{quote}I believe it means "don't run J17" here.
{quote}
I think it is:
Build 11 + 17
Then run either:
1) J11+J17 tests on J11 build
or
2) J11 tests on J11 build and J17 tests on J17 build
So far, from the thread around CASSANDRA-18753, I suggested [1] as an immediate
step to run pre-commit only the J11 pre-commit workflow and add a J17 build,
but no other jobs in CircleCI. I believe this ticket should probably
facilitate any changes to CircleCI workflows, plus the decision of whether we
choose 1) or 2). [~jlewandowski] ?
[1] https://lists.apache.org/thread/8pp0fonoc33xqgbzs0kfgy630pyggcdq
was (Author: e.dimitrova):
bq. I believe it means "don't run J17" here.
I think it is:
Build 11 + 17
Then run either:
1) J11+J17 tests on J11 build
or
2) J11 tests on J11 build and J17 tests on J17 build
So far, from the thread around CASSANDRA-18753, I suggested as an immediate
step to run pre-commit only the J11 pre-commit workflow and add a J17 build,
but no other jobs in CircleCI. I believe this ticket should probably
facilitate any changes to CircleCI workflows, plus the decision of whether we
choose 1) or 2). [~jlewandowski] ?
> Drop one JVM tests run from pre-commit pipeline
> ---
>
> Key: CASSANDRA-19407
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19407
> Project: Cassandra
> Issue Type: Task
>Reporter: Jacek Lewandowski
>Assignee: Berenguer Blasi
>Priority: Normal
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19407) Drop one JVM tests run from pre-commit pipeline
[ https://issues.apache.org/jira/browse/CASSANDRA-19407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818912#comment-17818912 ] Ekaterina Dimitrova commented on CASSANDRA-19407: - bq. I believe it means "don't run J17" here. I think it is: Build 11 + 17 Then run either: 1) J11+J17 tests on J11 build or 2) J11 tests on J11 build and J17 tests on J17 build So far, from the thread around CASSANDRA-18753, I suggested as an immediate step to run pre-commit only the J11 pre-commit workflow and add a J17 build, but no other jobs in CircleCI. I believe this ticket should probably facilitate any changes to CircleCI workflows, plus the decision of whether we choose 1) or 2). [~jlewandowski] ? > Drop one JVM tests run from pre-commit pipeline > --- > > Key: CASSANDRA-19407 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19407 > Project: Cassandra > Issue Type: Task >Reporter: Jacek Lewandowski >Assignee: Berenguer Blasi >Priority: Normal > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19120) local consistencies may get timeout if blocking read repair is sending the read repair mutation to other DC
[ https://issues.apache.org/jira/browse/CASSANDRA-19120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-19120: -- Reviewers: Blake Eggleston, Stefan Miklosovic (was: Stefan Miklosovic) Status: Review In Progress (was: Needs Committer) > local consistencies may get timeout if blocking read repair is sending the > read repair mutation to other DC > > > Key: CASSANDRA-19120 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19120 > Project: Cassandra > Issue Type: Bug > Components: Consistency/Repair >Reporter: Runtian Liu >Assignee: Runtian Liu >Priority: Normal > Fix For: 4.0.x, 4.1.x, 5.0.x, 5.x > > Attachments: image-2023-11-29-15-26-08-056.png, signature.asc > > Time Spent: 10m > Remaining Estimate: 0h > > For a two DCs cluster setup. When a new node is being added to DC1, for > blocking read repair triggered by local_quorum in DC1, it will require to > send read repair mutation to an extra node(1)(2). The selector for read > repair may select *ANY* node that has not been contacted before(3) instead of > selecting the DC1 nodes. If a node from DC2 is selected, this will cause 100% > timeout because of the bug described below: > When we initialized the latch(4) for blocking read repair, the shouldBlockOn > function will only return true for local nodes(5), the blockFor value will be > reduced if a local node doesn't require repair(6). The blockFor is same as > the number of read repair mutation sent out. But when the coordinator node > receives the response from the target nodes, the latch only count down for > nodes in same DC(7). The latch will wait till timeout and the read request > will timeout. > This can be reproduced if you have a constant load on a 3 + 3 cluster when > adding a node. If you have someway to trigger blocking read repair(maybe by > adding load using stress tool). If you use local_quorum consistency with a > constant read after write load in the same DC that you are adding node. You > will see read timeout issue from time to time because of the bug described > above > > I think for read repair when selecting the extra node to do repair, we should > prefer local nodes than the nodes from other region. Also, we need to fix the > latch part so even if we send mutation to the nodes in other DC, we don't get > a timeout. > (1)[https://github.com/apache/cassandra/blob/cassandra-4.0.11/src/java/org/apache/cassandra/locator/ReplicaPlans.java#L455] > (2)[https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/ConsistencyLevel.java#L183] > (3)[https://github.com/apache/cassandra/blob/cassandra-4.0.11/src/java/org/apache/cassandra/locator/ReplicaPlans.java#L458] > (4)[https://github.com/apache/cassandra/blob/cassandra-4.0.11/src/java/org/apache/cassandra/service/reads/repair/BlockingPartitionRepair.java#L96] > (5)[https://github.com/apache/cassandra/blob/cassandra-4.0.11/src/java/org/apache/cassandra/service/reads/repair/BlockingPartitionRepair.java#L71] > (6)[https://github.com/apache/cassandra/blob/cassandra-4.0.11/src/java/org/apache/cassandra/service/reads/repair/BlockingPartitionRepair.java#L88] > (7)[https://github.com/apache/cassandra/blob/cassandra-4.0.11/src/java/org/apache/cassandra/service/reads/repair/BlockingPartitionRepair.java#L113] > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19120) local consistencies may get timeout if blocking read repair is sending the read repair mutation to other DC
[ https://issues.apache.org/jira/browse/CASSANDRA-19120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-19120: -- Status: Ready to Commit (was: Review In Progress) > local consistencies may get timeout if blocking read repair is sending the > read repair mutation to other DC > > > Key: CASSANDRA-19120 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19120 > Project: Cassandra > Issue Type: Bug > Components: Consistency/Repair >Reporter: Runtian Liu >Assignee: Runtian Liu >Priority: Normal > Fix For: 4.0.x, 4.1.x, 5.0.x, 5.x > > Attachments: image-2023-11-29-15-26-08-056.png, signature.asc > > Time Spent: 10m > Remaining Estimate: 0h > > For a two DCs cluster setup. When a new node is being added to DC1, for > blocking read repair triggered by local_quorum in DC1, it will require to > send read repair mutation to an extra node(1)(2). The selector for read > repair may select *ANY* node that has not been contacted before(3) instead of > selecting the DC1 nodes. If a node from DC2 is selected, this will cause 100% > timeout because of the bug described below: > When we initialized the latch(4) for blocking read repair, the shouldBlockOn > function will only return true for local nodes(5), the blockFor value will be > reduced if a local node doesn't require repair(6). The blockFor is same as > the number of read repair mutation sent out. But when the coordinator node > receives the response from the target nodes, the latch only count down for > nodes in same DC(7). The latch will wait till timeout and the read request > will timeout. > This can be reproduced if you have a constant load on a 3 + 3 cluster when > adding a node. If you have someway to trigger blocking read repair(maybe by > adding load using stress tool). If you use local_quorum consistency with a > constant read after write load in the same DC that you are adding node. You > will see read timeout issue from time to time because of the bug described > above > > I think for read repair when selecting the extra node to do repair, we should > prefer local nodes than the nodes from other region. Also, we need to fix the > latch part so even if we send mutation to the nodes in other DC, we don't get > a timeout. > (1)[https://github.com/apache/cassandra/blob/cassandra-4.0.11/src/java/org/apache/cassandra/locator/ReplicaPlans.java#L455] > (2)[https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/ConsistencyLevel.java#L183] > (3)[https://github.com/apache/cassandra/blob/cassandra-4.0.11/src/java/org/apache/cassandra/locator/ReplicaPlans.java#L458] > (4)[https://github.com/apache/cassandra/blob/cassandra-4.0.11/src/java/org/apache/cassandra/service/reads/repair/BlockingPartitionRepair.java#L96] > (5)[https://github.com/apache/cassandra/blob/cassandra-4.0.11/src/java/org/apache/cassandra/service/reads/repair/BlockingPartitionRepair.java#L71] > (6)[https://github.com/apache/cassandra/blob/cassandra-4.0.11/src/java/org/apache/cassandra/service/reads/repair/BlockingPartitionRepair.java#L88] > (7)[https://github.com/apache/cassandra/blob/cassandra-4.0.11/src/java/org/apache/cassandra/service/reads/repair/BlockingPartitionRepair.java#L113] > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19120) local consistencies may get timeout if blocking read repair is sending the read repair mutation to other DC
[ https://issues.apache.org/jira/browse/CASSANDRA-19120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818902#comment-17818902 ] Blake Eggleston commented on CASSANDRA-19120: - +1 if we know the failing tests were failing/flaky previously > local consistencies may get timeout if blocking read repair is sending the > read repair mutation to other DC > > > Key: CASSANDRA-19120 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19120 > Project: Cassandra > Issue Type: Bug > Components: Consistency/Repair >Reporter: Runtian Liu >Assignee: Runtian Liu >Priority: Normal > Fix For: 4.0.x, 4.1.x, 5.0.x, 5.x > > Attachments: image-2023-11-29-15-26-08-056.png, signature.asc > > Time Spent: 10m > Remaining Estimate: 0h > > For a two DCs cluster setup. When a new node is being added to DC1, for > blocking read repair triggered by local_quorum in DC1, it will require to > send read repair mutation to an extra node(1)(2). The selector for read > repair may select *ANY* node that has not been contacted before(3) instead of > selecting the DC1 nodes. If a node from DC2 is selected, this will cause 100% > timeout because of the bug described below: > When we initialized the latch(4) for blocking read repair, the shouldBlockOn > function will only return true for local nodes(5), the blockFor value will be > reduced if a local node doesn't require repair(6). The blockFor is same as > the number of read repair mutation sent out. But when the coordinator node > receives the response from the target nodes, the latch only count down for > nodes in same DC(7). The latch will wait till timeout and the read request > will timeout. > This can be reproduced if you have a constant load on a 3 + 3 cluster when > adding a node. If you have someway to trigger blocking read repair(maybe by > adding load using stress tool). If you use local_quorum consistency with a > constant read after write load in the same DC that you are adding node. You > will see read timeout issue from time to time because of the bug described > above > > I think for read repair when selecting the extra node to do repair, we should > prefer local nodes than the nodes from other region. Also, we need to fix the > latch part so even if we send mutation to the nodes in other DC, we don't get > a timeout. > (1)[https://github.com/apache/cassandra/blob/cassandra-4.0.11/src/java/org/apache/cassandra/locator/ReplicaPlans.java#L455] > (2)[https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/ConsistencyLevel.java#L183] > (3)[https://github.com/apache/cassandra/blob/cassandra-4.0.11/src/java/org/apache/cassandra/locator/ReplicaPlans.java#L458] > (4)[https://github.com/apache/cassandra/blob/cassandra-4.0.11/src/java/org/apache/cassandra/service/reads/repair/BlockingPartitionRepair.java#L96] > (5)[https://github.com/apache/cassandra/blob/cassandra-4.0.11/src/java/org/apache/cassandra/service/reads/repair/BlockingPartitionRepair.java#L71] > (6)[https://github.com/apache/cassandra/blob/cassandra-4.0.11/src/java/org/apache/cassandra/service/reads/repair/BlockingPartitionRepair.java#L88] > (7)[https://github.com/apache/cassandra/blob/cassandra-4.0.11/src/java/org/apache/cassandra/service/reads/repair/BlockingPartitionRepair.java#L113] > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
Re: [PR] Changelog updates to reflect work that went out in 4.18.0 [cassandra-java-driver]
absurdfarce commented on code in PR #1914: URL: https://github.com/apache/cassandra-java-driver/pull/1914#discussion_r1496142454 ## changelog/README.md: ## @@ -21,6 +21,16 @@ under the License. +### 4.18.0 + +- [improvement] PR 1689: Add support for publishing percentile time series for the histogram metrics (nparaddi-walmart) +- [improvement] JAVA-3104: Do not eagerly pre-allocate array when deserializing CqlVector +- [improvement] JAVA-3111: upgrade jackson-databind to 2.13.4.2 to address gradle dependency issue +- [improvement] PR 1617: Improve ByteBufPrimitiveCodec readBytes (chibenwa) +- [improvement] JAVA-3095: Fix CREATE keyword in vector search example in upgrade guide +- [improvement] JAVA-3100: Update jackson-databind to 2.13.4.1 and jackson-jaxrs-json-provider to 2.13.4 to address recent CVEs +- [improvement] JAVA-3089: Forbid wildcard imports Review Comment: Normally build and test fixes aren't included in the changelog but I made an exception for this one; it could have developer-facing impacts. The docs have always suggested to avoid wildcard imports but actually mandating them in the Maven build is a new thing. ## changelog/README.md: ## @@ -21,6 +21,16 @@ under the License. +### 4.18.0 + +- [improvement] PR 1689: Add support for publishing percentile time series for the histogram metrics (nparaddi-walmart) Review Comment: Historically we've only included JAVA tickets in the changelog but this will obviously be changing as we transition to CASSANDRA tickets for the Java driver. Rather than creating JAVA tickets for a few user-contributed changes (such as this one) it seemed easier to just include an explicit reference to the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[PR] Changelog updates to reflect work that went out in 4.18.0 [cassandra-java-driver]
absurdfarce opened a new pull request, #1914: URL: https://github.com/apache/cassandra-java-driver/pull/1914 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19120) local consistencies may get timeout if blocking read repair is sending the read repair mutation to other DC
[ https://issues.apache.org/jira/browse/CASSANDRA-19120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-19120: -- Status: Needs Committer (was: Review In Progress) > local consistencies may get timeout if blocking read repair is sending the > read repair mutation to other DC > > > Key: CASSANDRA-19120 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19120 > Project: Cassandra > Issue Type: Bug > Components: Consistency/Repair >Reporter: Runtian Liu >Assignee: Runtian Liu >Priority: Normal > Fix For: 4.0.x, 4.1.x, 5.0.x, 5.x > > Attachments: image-2023-11-29-15-26-08-056.png, signature.asc > > Time Spent: 10m > Remaining Estimate: 0h > > For a two DCs cluster setup. When a new node is being added to DC1, for > blocking read repair triggered by local_quorum in DC1, it will require to > send read repair mutation to an extra node(1)(2). The selector for read > repair may select *ANY* node that has not been contacted before(3) instead of > selecting the DC1 nodes. If a node from DC2 is selected, this will cause 100% > timeout because of the bug described below: > When we initialized the latch(4) for blocking read repair, the shouldBlockOn > function will only return true for local nodes(5), the blockFor value will be > reduced if a local node doesn't require repair(6). The blockFor is same as > the number of read repair mutation sent out. But when the coordinator node > receives the response from the target nodes, the latch only count down for > nodes in same DC(7). The latch will wait till timeout and the read request > will timeout. > This can be reproduced if you have a constant load on a 3 + 3 cluster when > adding a node. If you have someway to trigger blocking read repair(maybe by > adding load using stress tool). If you use local_quorum consistency with a > constant read after write load in the same DC that you are adding node. You > will see read timeout issue from time to time because of the bug described > above > > I think for read repair when selecting the extra node to do repair, we should > prefer local nodes than the nodes from other region. Also, we need to fix the > latch part so even if we send mutation to the nodes in other DC, we don't get > a timeout. > (1)[https://github.com/apache/cassandra/blob/cassandra-4.0.11/src/java/org/apache/cassandra/locator/ReplicaPlans.java#L455] > (2)[https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/ConsistencyLevel.java#L183] > (3)[https://github.com/apache/cassandra/blob/cassandra-4.0.11/src/java/org/apache/cassandra/locator/ReplicaPlans.java#L458] > (4)[https://github.com/apache/cassandra/blob/cassandra-4.0.11/src/java/org/apache/cassandra/service/reads/repair/BlockingPartitionRepair.java#L96] > (5)[https://github.com/apache/cassandra/blob/cassandra-4.0.11/src/java/org/apache/cassandra/service/reads/repair/BlockingPartitionRepair.java#L71] > (6)[https://github.com/apache/cassandra/blob/cassandra-4.0.11/src/java/org/apache/cassandra/service/reads/repair/BlockingPartitionRepair.java#L88] > (7)[https://github.com/apache/cassandra/blob/cassandra-4.0.11/src/java/org/apache/cassandra/service/reads/repair/BlockingPartitionRepair.java#L113] > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19120) local consistencies may get timeout if blocking read repair is sending the read repair mutation to other DC
[ https://issues.apache.org/jira/browse/CASSANDRA-19120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818897#comment-17818897 ] Stefan Miklosovic commented on CASSANDRA-19120: --- This all looks good to me, if [~bdeggleston] agrees we might ship it. > local consistencies may get timeout if blocking read repair is sending the > read repair mutation to other DC > > > Key: CASSANDRA-19120 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19120 > Project: Cassandra > Issue Type: Bug > Components: Consistency/Repair >Reporter: Runtian Liu >Assignee: Runtian Liu >Priority: Normal > Fix For: 4.0.x, 4.1.x, 5.0.x, 5.x > > Attachments: image-2023-11-29-15-26-08-056.png, signature.asc > > Time Spent: 10m > Remaining Estimate: 0h > > For a two DCs cluster setup. When a new node is being added to DC1, for > blocking read repair triggered by local_quorum in DC1, it will require to > send read repair mutation to an extra node(1)(2). The selector for read > repair may select *ANY* node that has not been contacted before(3) instead of > selecting the DC1 nodes. If a node from DC2 is selected, this will cause 100% > timeout because of the bug described below: > When we initialized the latch(4) for blocking read repair, the shouldBlockOn > function will only return true for local nodes(5), the blockFor value will be > reduced if a local node doesn't require repair(6). The blockFor is same as > the number of read repair mutation sent out. But when the coordinator node > receives the response from the target nodes, the latch only count down for > nodes in same DC(7). The latch will wait till timeout and the read request > will timeout. > This can be reproduced if you have a constant load on a 3 + 3 cluster when > adding a node. If you have someway to trigger blocking read repair(maybe by > adding load using stress tool). If you use local_quorum consistency with a > constant read after write load in the same DC that you are adding node. You > will see read timeout issue from time to time because of the bug described > above > > I think for read repair when selecting the extra node to do repair, we should > prefer local nodes than the nodes from other region. Also, we need to fix the > latch part so even if we send mutation to the nodes in other DC, we don't get > a timeout. > (1)[https://github.com/apache/cassandra/blob/cassandra-4.0.11/src/java/org/apache/cassandra/locator/ReplicaPlans.java#L455] > (2)[https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/ConsistencyLevel.java#L183] > (3)[https://github.com/apache/cassandra/blob/cassandra-4.0.11/src/java/org/apache/cassandra/locator/ReplicaPlans.java#L458] > (4)[https://github.com/apache/cassandra/blob/cassandra-4.0.11/src/java/org/apache/cassandra/service/reads/repair/BlockingPartitionRepair.java#L96] > (5)[https://github.com/apache/cassandra/blob/cassandra-4.0.11/src/java/org/apache/cassandra/service/reads/repair/BlockingPartitionRepair.java#L71] > (6)[https://github.com/apache/cassandra/blob/cassandra-4.0.11/src/java/org/apache/cassandra/service/reads/repair/BlockingPartitionRepair.java#L88] > (7)[https://github.com/apache/cassandra/blob/cassandra-4.0.11/src/java/org/apache/cassandra/service/reads/repair/BlockingPartitionRepair.java#L113] > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19120) local consistencies may get timeout if blocking read repair is sending the read repair mutation to other DC
[
https://issues.apache.org/jira/browse/CASSANDRA-19120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818894#comment-17818894
]
Stefan Miklosovic commented on CASSANDRA-19120:
---
[CASSANDRA-19120-trunk|https://github.com/instaclustr/cassandra/tree/CASSANDRA-19120-trunk]
{noformat}
java17_pre-commit_tests
java17_separate_tests
java11_pre-commit_tests
✓ j11_build7m 58s
✓ j11_cqlsh_dtests_py311 9m 58s
✓ j11_cqlsh_dtests_py311_vnode10m 23s
✓ j11_cqlsh_dtests_py387m 52s
✓ j11_cqlsh_dtests_py38_vnode 10m 31s
✓ j11_cqlshlib_cython_tests 11m 38s
✓ j11_cqlshlib_tests 12m 1s
✓ j11_dtests 37m 13s
✓ j11_dtests_vnode 41m 2s
✓ j11_jvm_dtests_vnode 20m 5s
✓ j11_simulator_dtests 9m 0s
✓ j17_cqlsh_dtests_py311 6m 53s
✓ j17_cqlsh_dtests_py311_vnode 7m 12s
✓ j17_cqlsh_dtests_py386m 51s
✓ j17_cqlsh_dtests_py38_vnode 7m 13s
✓ j17_cqlshlib_cython_tests8m 19s
✓ j17_cqlshlib_tests7m 4s
✓ j17_dtests 35m 30s
✓ j17_dtests_vnode35m 34s
✕ j11_jvm_dtests 26m 8s
org.apache.cassandra.fuzz.ring.ConsistentBootstrapTest
coordinatorIsBehindTest
✕ j11_unit_tests 15m 46s
org.apache.cassandra.index.sai.cql.VectorUpdateDeleteTest updateTest
✕ j11_utests_oa 15m 46s
org.apache.cassandra.index.sai.cql.VectorUpdateDeleteTest updateTest
✕ j11_utests_system_keyspace_directory16m 17s
org.apache.cassandra.index.sai.cql.VectorUpdateDeleteTest updateTest
✕ j17_jvm_dtests 25m 12s
org.apache.cassandra.distributed.test.NativeTransportEncryptionOptionsTest
testEndpointVerificationEnabledIpNotInSAN TIMEOUTED
✕ j17_jvm_dtests_vnode23m 24s
junit.framework.TestSuite
org.apache.cassandra.fuzz.harry.integration.model.InJVMTokenAwareExecutorTest
TIMEOUTED
org.apache.cassandra.distributed.test.NativeTransportEncryptionOptionsTest
testEndpointVerificationEnabledIpNotInSAN TIMEOUTED
✕ j17_unit_tests 14m 54s
org.apache.cassandra.index.sai.cql.VectorUpdateDeleteTest updateTest
✕ j17_utests_oa 13m 18s
org.apache.cassandra.index.sai.cql.VectorUpdateDeleteTest updateTest
java11_separate_tests
{noformat}
[java17_pre-commit_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/3896/workflows/b64e0655-b604-4fad-a917-cbe6429819c6]
[java17_separate_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/3896/workflows/afeaf2b1-3d7b-4231-b669-9be4d6e9d7a7]
[java11_pre-commit_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/3896/workflows/2d7b6b75-8bdd-4c81-959d-9e3db922565e]
[java11_separate_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/3896/workflows/74474984-97f7-4a1f-8541-b66291e93ef9]
> local consistencies may get timeout if blocking read repair is sending the
> read repair mutation to other DC
>
>
> Key: CASSANDRA-19120
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19120
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Repair
>Reporter: Runtian Liu
>Assignee: Runtian Liu
>Priority: Normal
> Fix For: 4.0.x, 4.1.x, 5.0.x, 5.x
>
> Attachments: image-2023-11-29-15-26-08-056.png, signature.asc
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> For a two DCs cluster setup. When a new node is being added to DC1, for
> blocking read repair triggered by local_quorum in DC1, it will require to
> send read repair mutation to an extra node(1)(2). The selector for read
> repair may select *ANY* node that has not been contacted before(3) instead of
> selecting the DC1 nodes. If a node from DC2 is selected, this will cause 100%
> timeout because of the bug described below:
> When we initialized the latch(4) for blocking read repair, the shouldBlockOn
> function will only return true for local nodes(5), the blockFor value will be
> reduced if a local node doesn't require repair(6). The blockFor
[jira] [Commented] (CASSANDRA-19412) delete useless collection:backPressureHosts in the sendToHintedReplicas to improve write performance
[
https://issues.apache.org/jira/browse/CASSANDRA-19412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818851#comment-17818851
]
Brandon Williams commented on CASSANDRA-19412:
--
Looks good to me if you want to start builds.
> delete useless collection:backPressureHosts in the sendToHintedReplicas to
> improve write performance
>
>
> Key: CASSANDRA-19412
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19412
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Local Write-Read Paths
>Reporter: Ling Mao
>Assignee: Ling Mao
>Priority: Low
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Every normal write request will go through this
> method({_}*sendToHintedReplicas*{_}). However, the list:backPressureHosts in
> the method has never been used functionally.
> The _*backpressure*_ was introduced by:
> {code:java}
> Support optional backpressure strategies at the coordinator
> patch by Sergio Bossa; reviewed by Stefania Alborghetti for CASSANDRA-9318
> d43b9ce5 Sergio Bossa on 2016/9/19 at 10:42 AM {code}
> {code:java}
> public static void sendToHintedEndpoints(final Mutation mutation,
> Iterable targets,
>
> AbstractWriteResponseHandler responseHandler,
> String localDataCenter,
> Stage stage)
> throws OverloadedException
> {
> int targetsSize = Iterables.size(targets);
> // this dc replicas:
> Collection localDc = null;
> // extra-datacenter replicas, grouped by dc
> Map> dcGroups = null;
> // only need to create a Message for non-local writes
> MessageOut message = null;
> boolean insertLocal = false;
> ArrayList endpointsToHint = null;
> List backPressureHosts = null;
> for (InetAddress destination : targets)
> {
> checkHintOverload(destination);
> if (FailureDetector.instance.isAlive(destination))
> {
> if (canDoLocalRequest(destination))
> {
> insertLocal = true;
> }
> else
> {
> // belongs on a different server
> if (message == null)
> message = mutation.createMessage();
> String dc =
> DatabaseDescriptor.getEndpointSnitch().getDatacenter(destination);
> // direct writes to local DC or old Cassandra versions
> // (1.1 knows how to forward old-style String message
> IDs; updated to int in 2.0)
> if (localDataCenter.equals(dc))
> {
> if (localDc == null)
> localDc = new ArrayList<>(targetsSize);
> localDc.add(destination);
> }
> else
> {
> Collection messages = (dcGroups != null)
> ? dcGroups.get(dc) : null;
> if (messages == null)
> {
> messages = new ArrayList<>(3); // most DCs will
> have <= 3 replicas
> if (dcGroups == null)
> dcGroups = new HashMap<>();
> dcGroups.put(dc, messages);
> }
> messages.add(destination);
> }
> if (backPressureHosts == null)
> backPressureHosts = new ArrayList<>(targetsSize);
> backPressureHosts.add(destination);
> }
> }
> else
> {
> if (shouldHint(destination))
> {
> if (endpointsToHint == null)
> endpointsToHint = new ArrayList<>(targetsSize);
> endpointsToHint.add(destination);
> }
> }
> }
> if (backPressureHosts != null)
> MessagingService.instance().applyBackPressure(backPressureHosts,
> responseHandler.currentTimeout());
> if (endpointsToHint != null)
> submitHint(mutation, endpointsToHint, responseHandler);
> if (insertLocal)
> performLocally(stage, Optional.of(mutation), mutation::apply,
> responseHandler);
> if (localDc != null)
> {
> for (InetAddress destination : localDc)
> MessagingService.instance().sendRR(message, destination,
>
[jira] [Commented] (CASSANDRA-19413) Batch size guardrail ignores primary key size
[
https://issues.apache.org/jira/browse/CASSANDRA-19413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818847#comment-17818847
]
Szymon Miezal commented on CASSANDRA-19413:
---
Thank you for that assessment, I would say that adding a new guardrail is the
cleanest and least intrusive approach.
{quote}I think this is probably worth a quick poll on the dev list.
{quote}
That sounds like a good idea.
{quote}By the way, this threshold is not using the guardrails framework. We
have had CASSANDRA-17193 open for a while to port it to guardrails.
{quote}
That's true, even for trunk -
[https://github.com/apache/cassandra/blob/trunk/conf/cassandra.yaml#L1709-L1713.]
> Batch size guardrail ignores primary key size
> -
>
> Key: CASSANDRA-19413
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19413
> Project: Cassandra
> Issue Type: Bug
> Components: Feature/Guardrails
>Reporter: Szymon Miezal
>Assignee: Szymon Miezal
>Priority: Normal
> Fix For: 3.0.x, 3.11.x
>
>
> {color:#1f2328}The size of a mutation does not consider the primary key size.
> In the context of BATCHed mutations, this means that INSERTs, DELETEs, and
> UPDATEs for tables with a simple PRIMARY KEY and no clustering columns would
> be equal to zero (or almost zero depending on the version). Consequently, the
> batch_size_fail_threshold_in_kb has no effect for such tables, and it cannot
> protect the cluster from being overloaded.{color}
> {color:#1f2328}A test that reproduces the problem in 3.11 -
> [https://github.com/szymon-miezal/cassandra/commit/50b27c1e9030ce5ace6a6486a9876493c4ad41ae#diff-8cb249caec219439da461a4369f20530bb7d6cc0467c7e46f16288e22b574e61R43]
> {color}
> {color:#1f2328}There are a few ways it could be solved:{color}
> * {color:#1f2328}Modifying the existing batch_size_fail_threshold_in_kb to
> take into account the primary keys size (it has the disadvantage of changing
> the semantic of the guardrail thus introducing a regression).{color}
> * {color:#1f2328}Adding a new guardrail e.g.
> batch_size_with_pk_fail_threshold_in_kb that is going to be calculated taking
> primary key into account.{color}
> * Adding a -D switch that by default would be {{false}}{color:#1f2328}
> meaning that in case the new formula (which takes PK into account) yields
> value over the error threshold it will gracefully tell us about it in an
> additional log message. Changing the flag value to
> {color}{{true}}{color:#1f2328} would be equivalent to the new formula and
> error will be thrown in case we get over the threshold.{color}
> {{{color:#1f2328}I have a preference for going with an option that adds a new
> guardrail.{color}}}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19387) invalid
[ https://issues.apache.org/jira/browse/CASSANDRA-19387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brad Schoening updated CASSANDRA-19387: --- Resolution: Invalid Status: Resolved (was: Triage Needed) > invalid > --- > > Key: CASSANDRA-19387 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19387 > Project: Cassandra > Issue Type: Improvement >Reporter: Brad Schoening >Priority: Normal > > invalid > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19387) Transition Micro config to 48GB RAM
[ https://issues.apache.org/jira/browse/CASSANDRA-19387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brad Schoening updated CASSANDRA-19387: --- Description: invalid was: I think we have been starving the OS of RAM on the micro 32GB hosts. Cassandra 4.0 switched to Netty (nio), which allocates Direct Memory buffers (off heap) and may have accentuated the issue. Reports are that Netty can be memory intensive [Netty 4.x High Memory Usage|https://access.redhat.com/solutions/5286701]. Some symptoms: * Summer 2023 RHEL begins swapping to favor page cache * Fall 2023 OutOfMemory DirectMemory seen on several clusters with 4.0.6 * Cluster 733 speed up 2X simply by switching from 32GB -> 64GB RAM Our typical configuration for Micro: 16GB JVM 16GB Direct Memory buffers for netty I/O (default is equal to heap size) - 0 memory left over for page cache or anything else DataStax DSE [recommends|https://docs.datastax.com/eol/en/dse/6.7/dse-admin/datastax_enterprise/config/configRecommendedSettings.html#configFileCacheSettings__chunkCacheHistory]: * Max direct memory = (system memory – JVM heap size) / 2 * Chunk cache = (Max direct memory ) / 2 For CaaS micro nodes, this suggests 16GB (heap) + 8GB (nio) + 2GB (chunk) + 0.5GB (networking) = 26.5 GB + CaaS agent (3GB?) = 29.5GB I’d like to see us use 48GB VMs for micro nodes. > Transition Micro config to 48GB RAM > --- > > Key: CASSANDRA-19387 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19387 > Project: Cassandra > Issue Type: Improvement >Reporter: Brad Schoening >Priority: Normal > > invalid > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19387) invalid
[ https://issues.apache.org/jira/browse/CASSANDRA-19387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brad Schoening updated CASSANDRA-19387: --- Summary: invalid (was: Transition Micro config to 48GB RAM) > invalid > --- > > Key: CASSANDRA-19387 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19387 > Project: Cassandra > Issue Type: Improvement >Reporter: Brad Schoening >Priority: Normal > > invalid > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19412) delete useless collection:backPressureHosts in the sendToHintedReplicas to improve write performance
[
https://issues.apache.org/jira/browse/CASSANDRA-19412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Miklosovic updated CASSANDRA-19412:
--
Test and Documentation Plan: CI
Status: Patch Available (was: In Progress)
> delete useless collection:backPressureHosts in the sendToHintedReplicas to
> improve write performance
>
>
> Key: CASSANDRA-19412
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19412
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Local Write-Read Paths
>Reporter: Ling Mao
>Assignee: Ling Mao
>Priority: Low
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Every normal write request will go through this
> method({_}*sendToHintedReplicas*{_}). However, the list:backPressureHosts in
> the method has never been used functionally.
> The _*backpressure*_ was introduced by:
> {code:java}
> Support optional backpressure strategies at the coordinator
> patch by Sergio Bossa; reviewed by Stefania Alborghetti for CASSANDRA-9318
> d43b9ce5 Sergio Bossa on 2016/9/19 at 10:42 AM {code}
> {code:java}
> public static void sendToHintedEndpoints(final Mutation mutation,
> Iterable targets,
>
> AbstractWriteResponseHandler responseHandler,
> String localDataCenter,
> Stage stage)
> throws OverloadedException
> {
> int targetsSize = Iterables.size(targets);
> // this dc replicas:
> Collection localDc = null;
> // extra-datacenter replicas, grouped by dc
> Map> dcGroups = null;
> // only need to create a Message for non-local writes
> MessageOut message = null;
> boolean insertLocal = false;
> ArrayList endpointsToHint = null;
> List backPressureHosts = null;
> for (InetAddress destination : targets)
> {
> checkHintOverload(destination);
> if (FailureDetector.instance.isAlive(destination))
> {
> if (canDoLocalRequest(destination))
> {
> insertLocal = true;
> }
> else
> {
> // belongs on a different server
> if (message == null)
> message = mutation.createMessage();
> String dc =
> DatabaseDescriptor.getEndpointSnitch().getDatacenter(destination);
> // direct writes to local DC or old Cassandra versions
> // (1.1 knows how to forward old-style String message
> IDs; updated to int in 2.0)
> if (localDataCenter.equals(dc))
> {
> if (localDc == null)
> localDc = new ArrayList<>(targetsSize);
> localDc.add(destination);
> }
> else
> {
> Collection messages = (dcGroups != null)
> ? dcGroups.get(dc) : null;
> if (messages == null)
> {
> messages = new ArrayList<>(3); // most DCs will
> have <= 3 replicas
> if (dcGroups == null)
> dcGroups = new HashMap<>();
> dcGroups.put(dc, messages);
> }
> messages.add(destination);
> }
> if (backPressureHosts == null)
> backPressureHosts = new ArrayList<>(targetsSize);
> backPressureHosts.add(destination);
> }
> }
> else
> {
> if (shouldHint(destination))
> {
> if (endpointsToHint == null)
> endpointsToHint = new ArrayList<>(targetsSize);
> endpointsToHint.add(destination);
> }
> }
> }
> if (backPressureHosts != null)
> MessagingService.instance().applyBackPressure(backPressureHosts,
> responseHandler.currentTimeout());
> if (endpointsToHint != null)
> submitHint(mutation, endpointsToHint, responseHandler);
> if (insertLocal)
> performLocally(stage, Optional.of(mutation), mutation::apply,
> responseHandler);
> if (localDc != null)
> {
> for (InetAddress destination : localDc)
> MessagingService.instance().sendRR(message,
[jira] [Updated] (CASSANDRA-19412) delete useless collection:backPressureHosts in the sendToHintedReplicas to improve write performance
[
https://issues.apache.org/jira/browse/CASSANDRA-19412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Miklosovic updated CASSANDRA-19412:
--
Status: Needs Committer (was: Patch Available)
> delete useless collection:backPressureHosts in the sendToHintedReplicas to
> improve write performance
>
>
> Key: CASSANDRA-19412
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19412
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Local Write-Read Paths
>Reporter: Ling Mao
>Assignee: Ling Mao
>Priority: Low
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Every normal write request will go through this
> method({_}*sendToHintedReplicas*{_}). However, the list:backPressureHosts in
> the method has never been used functionally.
> The _*backpressure*_ was introduced by:
> {code:java}
> Support optional backpressure strategies at the coordinator
> patch by Sergio Bossa; reviewed by Stefania Alborghetti for CASSANDRA-9318
> d43b9ce5 Sergio Bossa on 2016/9/19 at 10:42 AM {code}
> {code:java}
> public static void sendToHintedEndpoints(final Mutation mutation,
> Iterable targets,
>
> AbstractWriteResponseHandler responseHandler,
> String localDataCenter,
> Stage stage)
> throws OverloadedException
> {
> int targetsSize = Iterables.size(targets);
> // this dc replicas:
> Collection localDc = null;
> // extra-datacenter replicas, grouped by dc
> Map> dcGroups = null;
> // only need to create a Message for non-local writes
> MessageOut message = null;
> boolean insertLocal = false;
> ArrayList endpointsToHint = null;
> List backPressureHosts = null;
> for (InetAddress destination : targets)
> {
> checkHintOverload(destination);
> if (FailureDetector.instance.isAlive(destination))
> {
> if (canDoLocalRequest(destination))
> {
> insertLocal = true;
> }
> else
> {
> // belongs on a different server
> if (message == null)
> message = mutation.createMessage();
> String dc =
> DatabaseDescriptor.getEndpointSnitch().getDatacenter(destination);
> // direct writes to local DC or old Cassandra versions
> // (1.1 knows how to forward old-style String message
> IDs; updated to int in 2.0)
> if (localDataCenter.equals(dc))
> {
> if (localDc == null)
> localDc = new ArrayList<>(targetsSize);
> localDc.add(destination);
> }
> else
> {
> Collection messages = (dcGroups != null)
> ? dcGroups.get(dc) : null;
> if (messages == null)
> {
> messages = new ArrayList<>(3); // most DCs will
> have <= 3 replicas
> if (dcGroups == null)
> dcGroups = new HashMap<>();
> dcGroups.put(dc, messages);
> }
> messages.add(destination);
> }
> if (backPressureHosts == null)
> backPressureHosts = new ArrayList<>(targetsSize);
> backPressureHosts.add(destination);
> }
> }
> else
> {
> if (shouldHint(destination))
> {
> if (endpointsToHint == null)
> endpointsToHint = new ArrayList<>(targetsSize);
> endpointsToHint.add(destination);
> }
> }
> }
> if (backPressureHosts != null)
> MessagingService.instance().applyBackPressure(backPressureHosts,
> responseHandler.currentTimeout());
> if (endpointsToHint != null)
> submitHint(mutation, endpointsToHint, responseHandler);
> if (insertLocal)
> performLocally(stage, Optional.of(mutation), mutation::apply,
> responseHandler);
> if (localDc != null)
> {
> for (InetAddress destination : localDc)
> MessagingService.instance().sendRR(message, destination,
> responseHandler, true);
> }
>
[jira] [Commented] (CASSANDRA-19412) delete useless collection:backPressureHosts in the sendToHintedReplicas to improve write performance
[
https://issues.apache.org/jira/browse/CASSANDRA-19412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818834#comment-17818834
]
Stefan Miklosovic commented on CASSANDRA-19412:
---
I have added PRs for older branches (4.0, 4.1, 5.0).
If this makes sense to people I will start the builds.
> delete useless collection:backPressureHosts in the sendToHintedReplicas to
> improve write performance
>
>
> Key: CASSANDRA-19412
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19412
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Local Write-Read Paths
>Reporter: Ling Mao
>Assignee: Ling Mao
>Priority: Low
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Every normal write request will go through this
> method({_}*sendToHintedReplicas*{_}). However, the list:backPressureHosts in
> the method has never been used functionally.
> The _*backpressure*_ was introduced by:
> {code:java}
> Support optional backpressure strategies at the coordinator
> patch by Sergio Bossa; reviewed by Stefania Alborghetti for CASSANDRA-9318
> d43b9ce5 Sergio Bossa on 2016/9/19 at 10:42 AM {code}
> {code:java}
> public static void sendToHintedEndpoints(final Mutation mutation,
> Iterable targets,
>
> AbstractWriteResponseHandler responseHandler,
> String localDataCenter,
> Stage stage)
> throws OverloadedException
> {
> int targetsSize = Iterables.size(targets);
> // this dc replicas:
> Collection localDc = null;
> // extra-datacenter replicas, grouped by dc
> Map> dcGroups = null;
> // only need to create a Message for non-local writes
> MessageOut message = null;
> boolean insertLocal = false;
> ArrayList endpointsToHint = null;
> List backPressureHosts = null;
> for (InetAddress destination : targets)
> {
> checkHintOverload(destination);
> if (FailureDetector.instance.isAlive(destination))
> {
> if (canDoLocalRequest(destination))
> {
> insertLocal = true;
> }
> else
> {
> // belongs on a different server
> if (message == null)
> message = mutation.createMessage();
> String dc =
> DatabaseDescriptor.getEndpointSnitch().getDatacenter(destination);
> // direct writes to local DC or old Cassandra versions
> // (1.1 knows how to forward old-style String message
> IDs; updated to int in 2.0)
> if (localDataCenter.equals(dc))
> {
> if (localDc == null)
> localDc = new ArrayList<>(targetsSize);
> localDc.add(destination);
> }
> else
> {
> Collection messages = (dcGroups != null)
> ? dcGroups.get(dc) : null;
> if (messages == null)
> {
> messages = new ArrayList<>(3); // most DCs will
> have <= 3 replicas
> if (dcGroups == null)
> dcGroups = new HashMap<>();
> dcGroups.put(dc, messages);
> }
> messages.add(destination);
> }
> if (backPressureHosts == null)
> backPressureHosts = new ArrayList<>(targetsSize);
> backPressureHosts.add(destination);
> }
> }
> else
> {
> if (shouldHint(destination))
> {
> if (endpointsToHint == null)
> endpointsToHint = new ArrayList<>(targetsSize);
> endpointsToHint.add(destination);
> }
> }
> }
> if (backPressureHosts != null)
> MessagingService.instance().applyBackPressure(backPressureHosts,
> responseHandler.currentTimeout());
> if (endpointsToHint != null)
> submitHint(mutation, endpointsToHint, responseHandler);
> if (insertLocal)
> performLocally(stage, Optional.of(mutation), mutation::apply,
> responseHandler);
> if (localDc != null)
> {
> for (InetAddress destination : localDc)
>
[jira] [Commented] (CASSANDRA-19412) delete useless collection:backPressureHosts in the sendToHintedReplicas to improve write performance
[
https://issues.apache.org/jira/browse/CASSANDRA-19412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818827#comment-17818827
]
Stefan Miklosovic commented on CASSANDRA-19412:
---
I think that this is leftover after CASSANDRA-15375 so this is truly a dead
code to me and should be removed.
https://github.com/apache/cassandra/commit/d8993934e976d8edb94cbfe2974688dac63c5db5#diff-4f6615c703489b87cafd23c0dc5a4edc4af27c33aba172870b30e38a7d8faa1d
If we do not create a list unnecessarily and we don't populate it by some
values, that is by definition surely more performance-friendly than vice versa.
> delete useless collection:backPressureHosts in the sendToHintedReplicas to
> improve write performance
>
>
> Key: CASSANDRA-19412
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19412
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Local Write-Read Paths
>Reporter: Ling Mao
>Assignee: Ling Mao
>Priority: Low
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Every normal write request will go through this
> method({_}*sendToHintedReplicas*{_}). However, the list:backPressureHosts in
> the method has never been used functionally.
> The _*backpressure*_ was introduced by:
> {code:java}
> Support optional backpressure strategies at the coordinator
> patch by Sergio Bossa; reviewed by Stefania Alborghetti for CASSANDRA-9318
> d43b9ce5 Sergio Bossa on 2016/9/19 at 10:42 AM {code}
> {code:java}
> public static void sendToHintedEndpoints(final Mutation mutation,
> Iterable targets,
>
> AbstractWriteResponseHandler responseHandler,
> String localDataCenter,
> Stage stage)
> throws OverloadedException
> {
> int targetsSize = Iterables.size(targets);
> // this dc replicas:
> Collection localDc = null;
> // extra-datacenter replicas, grouped by dc
> Map> dcGroups = null;
> // only need to create a Message for non-local writes
> MessageOut message = null;
> boolean insertLocal = false;
> ArrayList endpointsToHint = null;
> List backPressureHosts = null;
> for (InetAddress destination : targets)
> {
> checkHintOverload(destination);
> if (FailureDetector.instance.isAlive(destination))
> {
> if (canDoLocalRequest(destination))
> {
> insertLocal = true;
> }
> else
> {
> // belongs on a different server
> if (message == null)
> message = mutation.createMessage();
> String dc =
> DatabaseDescriptor.getEndpointSnitch().getDatacenter(destination);
> // direct writes to local DC or old Cassandra versions
> // (1.1 knows how to forward old-style String message
> IDs; updated to int in 2.0)
> if (localDataCenter.equals(dc))
> {
> if (localDc == null)
> localDc = new ArrayList<>(targetsSize);
> localDc.add(destination);
> }
> else
> {
> Collection messages = (dcGroups != null)
> ? dcGroups.get(dc) : null;
> if (messages == null)
> {
> messages = new ArrayList<>(3); // most DCs will
> have <= 3 replicas
> if (dcGroups == null)
> dcGroups = new HashMap<>();
> dcGroups.put(dc, messages);
> }
> messages.add(destination);
> }
> if (backPressureHosts == null)
> backPressureHosts = new ArrayList<>(targetsSize);
> backPressureHosts.add(destination);
> }
> }
> else
> {
> if (shouldHint(destination))
> {
> if (endpointsToHint == null)
> endpointsToHint = new ArrayList<>(targetsSize);
> endpointsToHint.add(destination);
> }
> }
> }
> if (backPressureHosts != null)
> MessagingService.instance().applyBackPressure(backPressureHosts,
> responseHandler.currentTimeout());
> if (endpointsToHint != null)
>
[jira] [Commented] (CASSANDRA-16684) Flaky MemtableSizeTest
[
https://issues.apache.org/jira/browse/CASSANDRA-16684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818824#comment-17818824
]
Ekaterina Dimitrova commented on CASSANDRA-16684:
-
There is an open ticket - CASSANDRA-17298. The test is consistently failing
after we fixed our test configuration a few weeks ago.
> Flaky MemtableSizeTest
> --
>
> Key: CASSANDRA-16684
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16684
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Berenguer Blasi
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 4.0-rc2, 4.0, 4.1-alpha1, 4.1
>
>
> Flaky
> [MemtableSizeTest|https://ci-cassandra.apache.org/job/Cassandra-4.0/50/testReport/junit/org.apache.cassandra.cql3/MemtableSizeTest/testSize_compression/]
> {noformat}
> Error Message
> Expected heap usage close to 50.085MiB, got 41.294MiB.
> Stacktrace
> junit.framework.AssertionFailedError: Expected heap usage close to 50.085MiB,
> got 41.294MiB.
> at
> org.apache.cassandra.cql3.MemtableSizeTest.testSize(MemtableSizeTest.java:121)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> Standard Output
> INFO [main] 2021-05-18 22:08:42,837 YamlConfigurationLoader.java:93 -
> Configuration location:
> file:home/cassandra/cassandra/build/test/cassandra.compressed.yaml
> DEBUG [main] 2021-05-18 22:08:42,840 YamlConfigurationLoader.java:112 -
> Loading settings from
> file:home/cassandra/cassandra/build/test/cassandra.compressed.yaml
> DEBUG [main] 2021-05-18 22:08:42,934 InternalLoggerFactory.java:63 - Using
> SLF4J as the default logging framework
> DEBUG [main] 2021-05-18 22:08:42,956 PlatformDependent0
> ...[truncated 86028 chars]...
> hed transaction log, deleting
> /home/cassandra/cassandra/build/test/cassandra/data/system_schema/keyspaces-abac5682dea631c5b535b3d6cffd0fb6/nb_txn_flush_a3253f00-b825-11eb-b0ec-cd4f0218a6b5.log
>
> DEBUG [MemtableFlushWriter:2] 2021-05-18 22:08:55,552
> ColumnFamilyStore.java:1197 - Flushed to
> [BigTableReader(path='/home/cassandra/cassandra/build/test/cassandra/data/system_schema/keyspaces-abac5682dea631c5b535b3d6cffd0fb6/nb-6-big-Data.db')]
> (1 sstables, 4.894KiB), biggest 4.894KiB, smallest 4.894KiB
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19412) delete useless collection:backPressureHosts in the sendToHintedReplicas to improve write performance
[
https://issues.apache.org/jira/browse/CASSANDRA-19412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ling Mao updated CASSANDRA-19412:
-
Description:
Every normal write request will go through this
method({_}*sendToHintedReplicas*{_}). However, the list:backPressureHosts in
the method has never been used functionally.
The _*backpressure*_ was introduced by:
{code:java}
Support optional backpressure strategies at the coordinator
patch by Sergio Bossa; reviewed by Stefania Alborghetti for CASSANDRA-9318
d43b9ce5 Sergio Bossa on 2016/9/19 at 10:42 AM {code}
{code:java}
public static void sendToHintedEndpoints(final Mutation mutation,
Iterable targets,
AbstractWriteResponseHandler responseHandler,
String localDataCenter,
Stage stage)
throws OverloadedException
{
int targetsSize = Iterables.size(targets);
// this dc replicas:
Collection localDc = null;
// extra-datacenter replicas, grouped by dc
Map> dcGroups = null;
// only need to create a Message for non-local writes
MessageOut message = null;
boolean insertLocal = false;
ArrayList endpointsToHint = null;
List backPressureHosts = null;
for (InetAddress destination : targets)
{
checkHintOverload(destination);
if (FailureDetector.instance.isAlive(destination))
{
if (canDoLocalRequest(destination))
{
insertLocal = true;
}
else
{
// belongs on a different server
if (message == null)
message = mutation.createMessage();
String dc =
DatabaseDescriptor.getEndpointSnitch().getDatacenter(destination);
// direct writes to local DC or old Cassandra versions
// (1.1 knows how to forward old-style String message IDs;
updated to int in 2.0)
if (localDataCenter.equals(dc))
{
if (localDc == null)
localDc = new ArrayList<>(targetsSize);
localDc.add(destination);
}
else
{
Collection messages = (dcGroups != null) ?
dcGroups.get(dc) : null;
if (messages == null)
{
messages = new ArrayList<>(3); // most DCs will
have <= 3 replicas
if (dcGroups == null)
dcGroups = new HashMap<>();
dcGroups.put(dc, messages);
}
messages.add(destination);
}
if (backPressureHosts == null)
backPressureHosts = new ArrayList<>(targetsSize);
backPressureHosts.add(destination);
}
}
else
{
if (shouldHint(destination))
{
if (endpointsToHint == null)
endpointsToHint = new ArrayList<>(targetsSize);
endpointsToHint.add(destination);
}
}
}
if (backPressureHosts != null)
MessagingService.instance().applyBackPressure(backPressureHosts,
responseHandler.currentTimeout());
if (endpointsToHint != null)
submitHint(mutation, endpointsToHint, responseHandler);
if (insertLocal)
performLocally(stage, Optional.of(mutation), mutation::apply,
responseHandler);
if (localDc != null)
{
for (InetAddress destination : localDc)
MessagingService.instance().sendRR(message, destination,
responseHandler, true);
}
if (dcGroups != null)
{
// for each datacenter, send the message to one node to relay the
write to other replicas
for (Collection dcTargets : dcGroups.values())
sendMessagesToNonlocalDC(message, dcTargets, responseHandler);
}
} {code}
Now the backPressure related codes had been deleted in the codebase, and here
maybe someone forgot to remove the collection: backPressureHosts. Removing it
will save every write request to add a few items to a list to reduce the memory
footprint
was:
Every normal write request will go through this
method({_}*sendToHintedReplicas*{_}). However, the list:backPressureHosts in
the method has never been used functionally. The _*backpressure*_ was
introduced by:
{code:java}
Support optional backpressure strategies at the
[jira] [Updated] (CASSANDRA-19412) delete useless collection:backPressureHosts in the sendToHintedReplicas to improve write performance
[
https://issues.apache.org/jira/browse/CASSANDRA-19412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ling Mao updated CASSANDRA-19412:
-
Description:
Every normal write request will go through this
method({_}*sendToHintedReplicas*{_}). However, the list:backPressureHosts in
the method has never been used functionally. The _*backpressure*_ was
introduced by:
{code:java}
Support optional backpressure strategies at the coordinator
patch by Sergio Bossa; reviewed by Stefania Alborghetti for CASSANDRA-9318
d43b9ce5 Sergio Bossa on 2016/9/19 at 10:42 AM {code}
{code:java}
public static void sendToHintedEndpoints(final Mutation mutation,
Iterable targets,
AbstractWriteResponseHandler responseHandler,
String localDataCenter,
Stage stage)
throws OverloadedException
{
int targetsSize = Iterables.size(targets);
// this dc replicas:
Collection localDc = null;
// extra-datacenter replicas, grouped by dc
Map> dcGroups = null;
// only need to create a Message for non-local writes
MessageOut message = null;
boolean insertLocal = false;
ArrayList endpointsToHint = null;
List backPressureHosts = null;
for (InetAddress destination : targets)
{
checkHintOverload(destination);
if (FailureDetector.instance.isAlive(destination))
{
if (canDoLocalRequest(destination))
{
insertLocal = true;
}
else
{
// belongs on a different server
if (message == null)
message = mutation.createMessage();
String dc =
DatabaseDescriptor.getEndpointSnitch().getDatacenter(destination);
// direct writes to local DC or old Cassandra versions
// (1.1 knows how to forward old-style String message IDs;
updated to int in 2.0)
if (localDataCenter.equals(dc))
{
if (localDc == null)
localDc = new ArrayList<>(targetsSize);
localDc.add(destination);
}
else
{
Collection messages = (dcGroups != null) ?
dcGroups.get(dc) : null;
if (messages == null)
{
messages = new ArrayList<>(3); // most DCs will
have <= 3 replicas
if (dcGroups == null)
dcGroups = new HashMap<>();
dcGroups.put(dc, messages);
}
messages.add(destination);
}
if (backPressureHosts == null)
backPressureHosts = new ArrayList<>(targetsSize);
backPressureHosts.add(destination);
}
}
else
{
if (shouldHint(destination))
{
if (endpointsToHint == null)
endpointsToHint = new ArrayList<>(targetsSize);
endpointsToHint.add(destination);
}
}
}
if (backPressureHosts != null)
MessagingService.instance().applyBackPressure(backPressureHosts,
responseHandler.currentTimeout());
if (endpointsToHint != null)
submitHint(mutation, endpointsToHint, responseHandler);
if (insertLocal)
performLocally(stage, Optional.of(mutation), mutation::apply,
responseHandler);
if (localDc != null)
{
for (InetAddress destination : localDc)
MessagingService.instance().sendRR(message, destination,
responseHandler, true);
}
if (dcGroups != null)
{
// for each datacenter, send the message to one node to relay the
write to other replicas
for (Collection dcTargets : dcGroups.values())
sendMessagesToNonlocalDC(message, dcTargets, responseHandler);
}
} {code}
Now the backPressure related codes had been deleted in the codebase, and Here
maybe someone forget to remove the collection:
was:I'll write a PR tonight
> delete useless collection:backPressureHosts in the sendToHintedReplicas to
> improve write performance
>
>
> Key: CASSANDRA-19412
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19412
> Project: Cassandra
>
[jira] [Updated] (CASSANDRA-19412) delete useless collection:backPressureHosts in the sendToHintedReplicas to improve write performance
[
https://issues.apache.org/jira/browse/CASSANDRA-19412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ling Mao updated CASSANDRA-19412:
-
Description:
Every normal write request will go through this
method({_}*sendToHintedReplicas*{_}). However, the list:backPressureHosts in
the method has never been used functionally. The _*backpressure*_ was
introduced by:
{code:java}
Support optional backpressure strategies at the coordinator
patch by Sergio Bossa; reviewed by Stefania Alborghetti for CASSANDRA-9318
d43b9ce5 Sergio Bossa on 2016/9/19 at 10:42 AM {code}
{code:java}
public static void sendToHintedEndpoints(final Mutation mutation,
Iterable targets,
AbstractWriteResponseHandler responseHandler,
String localDataCenter,
Stage stage)
throws OverloadedException
{
int targetsSize = Iterables.size(targets);
// this dc replicas:
Collection localDc = null;
// extra-datacenter replicas, grouped by dc
Map> dcGroups = null;
// only need to create a Message for non-local writes
MessageOut message = null;
boolean insertLocal = false;
ArrayList endpointsToHint = null;
List backPressureHosts = null;
for (InetAddress destination : targets)
{
checkHintOverload(destination);
if (FailureDetector.instance.isAlive(destination))
{
if (canDoLocalRequest(destination))
{
insertLocal = true;
}
else
{
// belongs on a different server
if (message == null)
message = mutation.createMessage();
String dc =
DatabaseDescriptor.getEndpointSnitch().getDatacenter(destination);
// direct writes to local DC or old Cassandra versions
// (1.1 knows how to forward old-style String message IDs;
updated to int in 2.0)
if (localDataCenter.equals(dc))
{
if (localDc == null)
localDc = new ArrayList<>(targetsSize);
localDc.add(destination);
}
else
{
Collection messages = (dcGroups != null) ?
dcGroups.get(dc) : null;
if (messages == null)
{
messages = new ArrayList<>(3); // most DCs will
have <= 3 replicas
if (dcGroups == null)
dcGroups = new HashMap<>();
dcGroups.put(dc, messages);
}
messages.add(destination);
}
if (backPressureHosts == null)
backPressureHosts = new ArrayList<>(targetsSize);
backPressureHosts.add(destination);
}
}
else
{
if (shouldHint(destination))
{
if (endpointsToHint == null)
endpointsToHint = new ArrayList<>(targetsSize);
endpointsToHint.add(destination);
}
}
}
if (backPressureHosts != null)
MessagingService.instance().applyBackPressure(backPressureHosts,
responseHandler.currentTimeout());
if (endpointsToHint != null)
submitHint(mutation, endpointsToHint, responseHandler);
if (insertLocal)
performLocally(stage, Optional.of(mutation), mutation::apply,
responseHandler);
if (localDc != null)
{
for (InetAddress destination : localDc)
MessagingService.instance().sendRR(message, destination,
responseHandler, true);
}
if (dcGroups != null)
{
// for each datacenter, send the message to one node to relay the
write to other replicas
for (Collection dcTargets : dcGroups.values())
sendMessagesToNonlocalDC(message, dcTargets, responseHandler);
}
} {code}
Now the backPressure related codes had been deleted in the codebase, and Here
maybe someone forget to remove the collection: backPressureHosts
was:
Every normal write request will go through this
method({_}*sendToHintedReplicas*{_}). However, the list:backPressureHosts in
the method has never been used functionally. The _*backpressure*_ was
introduced by:
{code:java}
Support optional backpressure strategies at the coordinator
patch by Sergio Bossa; reviewed by Stefania Alborghetti for CASSANDRA-9318
d43b9ce5
[jira] [Updated] (CASSANDRA-19201) Refactor cqlshmain global constants
[ https://issues.apache.org/jira/browse/CASSANDRA-19201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-19201: -- Fix Version/s: 5.1 (was: 5.x) Source Control Link: https://github.com/apache/cassandra/commit/1163dd9a084c7887059b34268bb01377825a1ed4 Resolution: Fixed Status: Resolved (was: Ready to Commit) > Refactor cqlshmain global constants > --- > > Key: CASSANDRA-19201 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19201 > Project: Cassandra > Issue Type: Task > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Brad Schoening >Priority: Low > Fix For: 5.1 > > Time Spent: 1h > Remaining Estimate: 0h > > Refactor global constants > * move globals CASSANDRA_CQL_HTML and cqlruleset > * move module level defaults (DEFAULT_) into Shell class > * move setup_cqlruleset into cqlshhandling > Remove unused exceptions > * FunctionNotFound(Exception) > * AggregateNotFound(Exception) -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
(cassandra) branch trunk updated: Refactor cqlshmain global constants
This is an automated email from the ASF dual-hosted git repository.
smiklosovic pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/trunk by this push:
new 1163dd9a08 Refactor cqlshmain global constants
1163dd9a08 is described below
commit 1163dd9a084c7887059b34268bb01377825a1ed4
Author: Brad Schoening
AuthorDate: Mon Dec 18 19:59:55 2023 -0500
Refactor cqlshmain global constants
patch by Brad Schoening; reviewed by Stefan Miklosovic and Brandon Williams
for CASSANDRA-19201
---
CHANGES.txt | 1 +
pylib/cqlshlib/cqlshhandling.py | 14 +-
pylib/cqlshlib/cqlshmain.py | 282 +++-
3 files changed, 146 insertions(+), 151 deletions(-)
diff --git a/CHANGES.txt b/CHANGES.txt
index 06520d16dc..d2f959ee48 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
5.1
+ * Refactor cqlshmain global constants (CASSANDRA-19201)
* Remove native_transport_port_ssl (CASSANDRA-19397)
* Make nodetool reconfigurecms sync by default and add --cancel to be able to
cancel ongoing reconfigurations (CASSANDRA-19216)
* Expose auth mode in system_views.clients, nodetool clientstats, metrics
(CASSANDRA-19366)
diff --git a/pylib/cqlshlib/cqlshhandling.py b/pylib/cqlshlib/cqlshhandling.py
index ad515e63c0..ef6ad28725 100644
--- a/pylib/cqlshlib/cqlshhandling.py
+++ b/pylib/cqlshlib/cqlshhandling.py
@@ -16,7 +16,7 @@
import os
-from cqlshlib import cqlhandling
+from cqlshlib import cqlhandling, cql3handling
# we want the cql parser to understand our cqlsh-specific commands too
my_commands_ending_with_newline = (
@@ -251,6 +251,18 @@ cqlsh_extra_syntax_rules = cqlsh_cmd_syntax_rules + \
cqlsh_question_mark
+def get_cqlshruleset():
+cqlruleset = cql3handling.CqlRuleSet
+cqlruleset.append_rules(cqlsh_extra_syntax_rules)
+for rulename, termname, func in cqlsh_syntax_completers:
+cqlruleset.completer_for(rulename, termname)(func)
+
cqlruleset.commands_end_with_newline.update(my_commands_ending_with_newline)
+return cqlruleset
+
+
+cqlshruleset = get_cqlshruleset()
+
+
def complete_source_quoted_filename(ctxt, cqlsh):
partial_path = ctxt.get_binding('partial', '')
head, tail = os.path.split(partial_path)
diff --git a/pylib/cqlshlib/cqlshmain.py b/pylib/cqlshlib/cqlshmain.py
index e515ff3c6a..57cb16bb46 100755
--- a/pylib/cqlshlib/cqlshmain.py
+++ b/pylib/cqlshlib/cqlshmain.py
@@ -52,14 +52,15 @@ from cqlshlib.formatting import (DEFAULT_DATE_FORMAT,
DEFAULT_NANOTIME_FORMAT,
from cqlshlib.helptopics import get_html_anchor, get_html_topics
from cqlshlib.tracing import print_trace, print_trace_session
from cqlshlib.util import get_file_encoding_bomsize, is_file_secure
+
+from cqlshlib.cqlshhandling import cqlshruleset as ruleset
+
try:
from cqlshlib.serverversion import version as build_version
except ImportError:
build_version = 'UNKNOWN'
UTF8 = 'utf-8'
-
-description = "CQL Shell for Apache Cassandra"
version = "6.2.0"
readline = None
@@ -85,83 +86,11 @@ if webbrowser._tryorder and webbrowser._tryorder[0] ==
'xdg-open' and os.environ
webbrowser._tryorder.remove('xdg-open')
webbrowser._tryorder.append('xdg-open')
-warnings.filterwarnings("ignore", r".*blist.*")
-
-DEFAULT_HOST = '127.0.0.1'
-DEFAULT_PORT = 9042
-DEFAULT_SSL = False
-DEFAULT_CONNECT_TIMEOUT_SECONDS = 5
-DEFAULT_REQUEST_TIMEOUT_SECONDS = 10
-
-DEFAULT_FLOAT_PRECISION = 5
-DEFAULT_DOUBLE_PRECISION = 5
-DEFAULT_MAX_TRACE_WAIT = 10
-
if readline is not None and readline.__doc__ is not None and 'libedit' in
readline.__doc__:
DEFAULT_COMPLETEKEY = '\t'
else:
DEFAULT_COMPLETEKEY = 'tab'
-cqldocs = None
-cqlruleset = None
-CASSANDRA_CQL_HTML = None
-
-epilog = """Connects to %(DEFAULT_HOST)s:%(DEFAULT_PORT)d by default. These
-defaults can be changed by setting $CQLSH_HOST and/or $CQLSH_PORT. When a
-host (and optional port number) are given on the command line, they take
-precedence over any defaults.""" % globals()
-
-
-parser = argparse.ArgumentParser(description=description, epilog=epilog,
- usage="Usage: %(prog)s [options] [host
[port]]",
- prog='cqlsh')
-parser.add_argument('-v', '--version', action='version', version='cqlsh ' +
version)
-parser.add_argument("-C", "--color", action='store_true', dest='color',
-help='Always use color output')
-parser.add_argument("--no-color", action='store_false', dest='color',
help='Never use color output')
-parser.add_argument("--browser", dest='browser', help="""The browser to use to
display CQL help, where BROWSER can be:
-- one of the supported
browsers in https://docs.python.org/3/library/webbrowser.html.
-- browser path followed by
[jira] [Updated] (CASSANDRA-19201) Refactor cqlshmain global constants
[ https://issues.apache.org/jira/browse/CASSANDRA-19201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-19201: - Status: Ready to Commit (was: Review In Progress) > Refactor cqlshmain global constants > --- > > Key: CASSANDRA-19201 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19201 > Project: Cassandra > Issue Type: Task > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Brad Schoening >Priority: Low > Fix For: 5.x > > Time Spent: 1h > Remaining Estimate: 0h > > Refactor global constants > * move globals CASSANDRA_CQL_HTML and cqlruleset > * move module level defaults (DEFAULT_) into Shell class > * move setup_cqlruleset into cqlshhandling > Remove unused exceptions > * FunctionNotFound(Exception) > * AggregateNotFound(Exception) -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19201) Refactor cqlshmain global constants
[ https://issues.apache.org/jira/browse/CASSANDRA-19201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818789#comment-17818789 ] Brandon Williams commented on CASSANDRA-19201: -- +1 > Refactor cqlshmain global constants > --- > > Key: CASSANDRA-19201 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19201 > Project: Cassandra > Issue Type: Task > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Brad Schoening >Priority: Low > Fix For: 5.x > > Time Spent: 1h > Remaining Estimate: 0h > > Refactor global constants > * move globals CASSANDRA_CQL_HTML and cqlruleset > * move module level defaults (DEFAULT_) into Shell class > * move setup_cqlruleset into cqlshhandling > Remove unused exceptions > * FunctionNotFound(Exception) > * AggregateNotFound(Exception) -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-19201) Refactor cqlshmain global constants
[ https://issues.apache.org/jira/browse/CASSANDRA-19201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-19201: - Status: Review In Progress (was: Needs Committer) > Refactor cqlshmain global constants > --- > > Key: CASSANDRA-19201 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19201 > Project: Cassandra > Issue Type: Task > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Brad Schoening >Priority: Low > Fix For: 5.x > > Time Spent: 1h > Remaining Estimate: 0h > > Refactor global constants > * move globals CASSANDRA_CQL_HTML and cqlruleset > * move module level defaults (DEFAULT_) into Shell class > * move setup_cqlruleset into cqlshhandling > Remove unused exceptions > * FunctionNotFound(Exception) > * AggregateNotFound(Exception) -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19393) nodetool: group CMS-related commands into one command
[ https://issues.apache.org/jira/browse/CASSANDRA-19393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818773#comment-17818773 ] Stefan Miklosovic commented on CASSANDRA-19393: --- I took a look at this more closely and critically and I think that this set of changes should be introduced https://github.com/smiklosovic/cassandra/commit/639a18c4712b70beca81bafa280c4ebac0c3c2a8 I think we should copy the case of repair_admin, I put the comments into the PR and I did the work so we may speed things up a little bit if another committer evaluates that it makes sense as well ... cc [~marcuse] > nodetool: group CMS-related commands into one command > - > > Key: CASSANDRA-19393 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19393 > Project: Cassandra > Issue Type: Improvement > Components: Tool/nodetool, Transactional Cluster Metadata >Reporter: n.v.harikrishna >Assignee: n.v.harikrishna >Priority: Normal > Fix For: 5.x > > Time Spent: 1.5h > Remaining Estimate: 0h > > The purpose of this ticket is to group all CMS-related commands under one > "nodetool cms" command where existing command would be subcommands of it. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19413) Batch size guardrail ignores primary key size
[
https://issues.apache.org/jira/browse/CASSANDRA-19413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818761#comment-17818761
]
Andres de la Peña commented on CASSANDRA-19413:
---
[~szymon.miezal] I understand that the original intention of
{{batch_size_fail_threshold}} was to prevent against batches of a specific
size, and not counting the keys would be a bug. If that's the case, we would
usually just fix it.
However, {{batch_size_fail_threshold}} has worked this way for a decade
(CASSANDRA-6487), so many users are probably okay with the current behaviour.
Thus, I would probably go with a new separate guardrail.
I think this is probably worth a quick poll on the dev list.
By the way, this threshold is not using the guardrails framework. We have had
CASSANDRA-17193 open for a while to port it to guardrails.
> Batch size guardrail ignores primary key size
> -
>
> Key: CASSANDRA-19413
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19413
> Project: Cassandra
> Issue Type: Bug
> Components: Feature/Guardrails
>Reporter: Szymon Miezal
>Assignee: Szymon Miezal
>Priority: Normal
> Fix For: 3.0.x, 3.11.x
>
>
> {color:#1f2328}The size of a mutation does not consider the primary key size.
> In the context of BATCHed mutations, this means that INSERTs, DELETEs, and
> UPDATEs for tables with a simple PRIMARY KEY and no clustering columns would
> be equal to zero (or almost zero depending on the version). Consequently, the
> batch_size_fail_threshold_in_kb has no effect for such tables, and it cannot
> protect the cluster from being overloaded.{color}
> {color:#1f2328}A test that reproduces the problem in 3.11 -
> [https://github.com/szymon-miezal/cassandra/commit/50b27c1e9030ce5ace6a6486a9876493c4ad41ae#diff-8cb249caec219439da461a4369f20530bb7d6cc0467c7e46f16288e22b574e61R43]
> {color}
> {color:#1f2328}There are a few ways it could be solved:{color}
> * {color:#1f2328}Modifying the existing batch_size_fail_threshold_in_kb to
> take into account the primary keys size (it has the disadvantage of changing
> the semantic of the guardrail thus introducing a regression).{color}
> * {color:#1f2328}Adding a new guardrail e.g.
> batch_size_with_pk_fail_threshold_in_kb that is going to be calculated taking
> primary key into account.{color}
> * Adding a -D switch that by default would be {{false}}{color:#1f2328}
> meaning that in case the new formula (which takes PK into account) yields
> value over the error threshold it will gracefully tell us about it in an
> additional log message. Changing the flag value to
> {color}{{true}}{color:#1f2328} would be equivalent to the new formula and
> error will be thrown in case we get over the threshold.{color}
> {{{color:#1f2328}I have a preference for going with an option that adds a new
> guardrail.{color}}}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19120) local consistencies may get timeout if blocking read repair is sending the read repair mutation to other DC
[
https://issues.apache.org/jira/browse/CASSANDRA-19120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818758#comment-17818758
]
Stefan Miklosovic commented on CASSANDRA-19120:
---
[CASSANDRA-19120-5.0|https://github.com/instaclustr/cassandra/tree/CASSANDRA-19120-5.0]
{noformat}
java17_pre-commit_tests
java17_separate_tests
java11_pre-commit_tests
✓ j11_build3m 42s
✓ j11_cqlsh_dtests_py311 6m 27s
✓ j11_cqlsh_dtests_py311_vnode 10m 0s
✓ j11_cqlsh_dtests_py38 8m 3s
✓ j11_cqlsh_dtests_py38_vnode 9m 21s
✓ j11_cqlshlib_cython_tests 12m 53s
✓ j11_cqlshlib_tests 6m 35s
✓ j11_dtests 32m 48s
✓ j11_dtests_vnode39m 21s
✓ j11_jvm_dtests 20m 23s
✓ j11_jvm_dtests_vnode16m 10s
✓ j11_simulator_dtests 2m 47s
✓ j17_cqlsh_dtests_py311 5m 52s
✓ j17_cqlsh_dtests_py311_vnode 6m 14s
✓ j17_cqlsh_dtests_py386m 16s
✓ j17_cqlsh_dtests_py38_vnode 6m 16s
✓ j17_cqlshlib_cython_tests9m 32s
✓ j17_cqlshlib_tests 6m 29s
✓ j17_dtests 33m 15s
✓ j17_dtests_vnode 33m 1s
✓ j17_jvm_dtests 19m 57s
✓ j17_jvm_dtests_vnode14m 52s
✕ j11_unit_tests 21m 10s
org.apache.cassandra.index.sai.cql.VectorUpdateDeleteTest updateTest
✕ j11_utests_oa 17m 44s
org.apache.cassandra.index.sai.cql.VectorUpdateDeleteTest updateTest
✕ j11_utests_system_keyspace_directory16m 51s
org.apache.cassandra.index.sai.cql.VectorUpdateDeleteTest updateTest
✕ j17_unit_tests 14m 55s
org.apache.cassandra.index.sai.cql.VectorUpdateDeleteTest updateTest
✕ j17_utests_oa 17m 25s
org.apache.cassandra.index.sai.cql.VectorUpdateDeleteTest updateTest
java11_separate_tests
{noformat}
[java17_pre-commit_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/3894/workflows/3d8af41d-1225-4a8e-b590-46c06051b324]
[java17_separate_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/3894/workflows/3d1996bf-acb6-403a-a8aa-d89521bb6b42]
[java11_pre-commit_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/3894/workflows/abe178de-5d3f-468f-9886-c93e10cddbcf]
[java11_separate_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/3894/workflows/66bb8816-92b9-4237-8dc9-d3d811782575]
> local consistencies may get timeout if blocking read repair is sending the
> read repair mutation to other DC
>
>
> Key: CASSANDRA-19120
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19120
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Repair
>Reporter: Runtian Liu
>Assignee: Runtian Liu
>Priority: Normal
> Fix For: 4.0.x, 4.1.x, 5.0.x, 5.x
>
> Attachments: image-2023-11-29-15-26-08-056.png, signature.asc
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> For a two DCs cluster setup. When a new node is being added to DC1, for
> blocking read repair triggered by local_quorum in DC1, it will require to
> send read repair mutation to an extra node(1)(2). The selector for read
> repair may select *ANY* node that has not been contacted before(3) instead of
> selecting the DC1 nodes. If a node from DC2 is selected, this will cause 100%
> timeout because of the bug described below:
> When we initialized the latch(4) for blocking read repair, the shouldBlockOn
> function will only return true for local nodes(5), the blockFor value will be
> reduced if a local node doesn't require repair(6). The blockFor is same as
> the number of read repair mutation sent out. But when the coordinator node
> receives the response from the target nodes, the latch only count down for
> nodes in same DC(7). The latch will wait till timeout and the read request
> will timeout.
> This can be reproduced if you have a constant load on a 3 + 3 cluster when
> adding a node. If you have someway to trigger blocking read repair(maybe by
> adding load using stress tool). If you use local_quorum
