[jira] [Updated] (CASSANDRA-12279) nodetool repair hangs on non-existant table
[ https://issues.apache.org/jira/browse/CASSANDRA-12279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Masataka Yamaguchi updated CASSANDRA-12279: --- Status: Patch Available (was: Open) > nodetool repair hangs on non-existant table > --- > > Key: CASSANDRA-12279 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12279 > Project: Cassandra > Issue Type: Bug > Environment: Linux Ubuntu, Openjdk >Reporter: Benjamin Roth >Assignee: Masataka Yamaguchi >Priority: Minor > Labels: lhf > Attachments: 0001-CASSANDRA-12279-2.2.patch, > 0001-CASSANDRA-12279-2.2and3.0-v2.patch, 0001-CASSANDRA-12279-3.0.patch, > 0001-CASSANDRA-12279-trunk-v2.patch, 0001-CASSANDRA-12279-trunk.patch, > CASSANDRA-12279-trunk.patch, new_result_example-v2.txt, > new_result_example.txt, org_result_example.txt > > > If nodetool repair is called with a table that does not exist, ist hangs > infinitely without any error message or logs. > E.g. > nodetool repair foo bar > Keyspace foo exists but table bar does not -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-12279) nodetool repair hangs on non-existant table
[ https://issues.apache.org/jira/browse/CASSANDRA-12279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Masataka Yamaguchi updated CASSANDRA-12279: --- Attachment: new_result_example-v2.txt 0001-CASSANDRA-12279-trunk-v2.patch 0001-CASSANDRA-12279-2.2and3.0-v2.patch Thank you for reviewing and testing. I rewrote the patch for nodetool repair. I added a new try-catch in RepairRunnable to catch the exception that happens when given keyspace does not have at least one given table in getValidColumnFamilies. I attached three files. First one is the patch for trunk, second one is the patch for 2.2 and 3.0 and third one is new output example. Please review it if you have time. > nodetool repair hangs on non-existant table > --- > > Key: CASSANDRA-12279 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12279 > Project: Cassandra > Issue Type: Bug > Environment: Linux Ubuntu, Openjdk >Reporter: Benjamin Roth >Assignee: Masataka Yamaguchi >Priority: Minor > Labels: lhf > Attachments: 0001-CASSANDRA-12279-2.2.patch, > 0001-CASSANDRA-12279-2.2and3.0-v2.patch, 0001-CASSANDRA-12279-3.0.patch, > 0001-CASSANDRA-12279-trunk-v2.patch, 0001-CASSANDRA-12279-trunk.patch, > CASSANDRA-12279-trunk.patch, new_result_example-v2.txt, > new_result_example.txt, org_result_example.txt > > > If nodetool repair is called with a table that does not exist, ist hangs > infinitely without any error message or logs. > E.g. > nodetool repair foo bar > Keyspace foo exists but table bar does not -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-12486) Structure for compactionhistory output (JSON, YAML)
[ https://issues.apache.org/jira/browse/CASSANDRA-12486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Masataka Yamaguchi updated CASSANDRA-12486: --- Status: Patch Available (was: Open) > Structure for compactionhistory output (JSON, YAML) > --- > > Key: CASSANDRA-12486 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12486 > Project: Cassandra > Issue Type: Improvement > Components: Tools >Reporter: Masataka Yamaguchi >Assignee: Masataka Yamaguchi >Priority: Minor > Fix For: 3.x > > Attachments: CASSANDRA-12486-trunk.patch, > CASSANDRA-12486-v2-git-format-patch.patch, compactionhistory_result-v2.json, > compactionhistory_result-v2.txt, compactionhistory_result-v2.yaml, > compactionhistory_result.json, compactionhistory_result.txt, > compactionhistory_result.yaml > > > As with nodetool tpstats and tablestats (CASSANDRA-12035), nodetool > compactionhistory should also support useful output formats such as JSON or > YAML, so we implemented it. > Please review the attached patch. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-12486) Structure for compactionhistory output (JSON, YAML)
[ https://issues.apache.org/jira/browse/CASSANDRA-12486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Masataka Yamaguchi updated CASSANDRA-12486: --- Attachment: compactionhistory_result-v2.yaml compactionhistory_result-v2.txt compactionhistory_result-v2.json CASSANDRA-12486-v2-git-format-patch.patch First, printing out compactionhistory as a list sorted by compacted_at sounds better for me than an associative array whose key is each compaction’s id, so I rewrote the patch so as to print it as a list sorted by compacted_at. Second, I also think that we should print it in the same way as default printer. So I changed the way of printing compacted_at in the patch. I attached the new patch and new output files, so please review it when you have time. Please note that the new patch was generated with git format-patch, while the previous patch was generated by patch command. Thank you. > Structure for compactionhistory output (JSON, YAML) > --- > > Key: CASSANDRA-12486 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12486 > Project: Cassandra > Issue Type: Improvement > Components: Tools >Reporter: Masataka Yamaguchi >Assignee: Masataka Yamaguchi >Priority: Minor > Fix For: 3.x > > Attachments: CASSANDRA-12486-trunk.patch, > CASSANDRA-12486-v2-git-format-patch.patch, compactionhistory_result-v2.json, > compactionhistory_result-v2.txt, compactionhistory_result-v2.yaml, > compactionhistory_result.json, compactionhistory_result.txt, > compactionhistory_result.yaml > > > As with nodetool tpstats and tablestats (CASSANDRA-12035), nodetool > compactionhistory should also support useful output formats such as JSON or > YAML, so we implemented it. > Please review the attached patch. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-12279) nodetool repair hangs on non-existant table
[ https://issues.apache.org/jira/browse/CASSANDRA-12279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Masataka Yamaguchi updated CASSANDRA-12279: --- Status: Patch Available (was: Open) > nodetool repair hangs on non-existant table > --- > > Key: CASSANDRA-12279 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12279 > Project: Cassandra > Issue Type: Bug > Environment: Linux Ubuntu, Openjdk >Reporter: Benjamin Roth >Assignee: Masataka Yamaguchi >Priority: Minor > Labels: lhf > Attachments: 0001-CASSANDRA-12279-2.2.patch, > 0001-CASSANDRA-12279-3.0.patch, 0001-CASSANDRA-12279-trunk.patch, > CASSANDRA-12279-trunk.patch, new_result_example.txt, org_result_example.txt > > > If nodetool repair is called with a table that does not exist, ist hangs > infinitely without any error message or logs. > E.g. > nodetool repair foo bar > Keyspace foo exists but table bar does not -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-12279) nodetool repair hangs on non-existant table
[ https://issues.apache.org/jira/browse/CASSANDRA-12279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Masataka Yamaguchi updated CASSANDRA-12279: --- Attachment: 0001-CASSANDRA-12279-trunk.patch 0001-CASSANDRA-12279-3.0.patch 0001-CASSANDRA-12279-2.2.patch Thank you for reviewing and creating a dtest! Sorry for my mistake. I created patches for 2.2, 3.0 and trunk with git format-patch. I attached them and please review it. > nodetool repair hangs on non-existant table > --- > > Key: CASSANDRA-12279 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12279 > Project: Cassandra > Issue Type: Bug > Environment: Linux Ubuntu, Openjdk >Reporter: Benjamin Roth >Assignee: Masataka Yamaguchi >Priority: Minor > Labels: lhf > Attachments: 0001-CASSANDRA-12279-2.2.patch, > 0001-CASSANDRA-12279-3.0.patch, 0001-CASSANDRA-12279-trunk.patch, > CASSANDRA-12279-trunk.patch, new_result_example.txt, org_result_example.txt > > > If nodetool repair is called with a table that does not exist, ist hangs > infinitely without any error message or logs. > E.g. > nodetool repair foo bar > Keyspace foo exists but table bar does not -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-12279) nodetool repair hangs on non-existant table
[ https://issues.apache.org/jira/browse/CASSANDRA-12279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Masataka Yamaguchi updated CASSANDRA-12279: --- Status: Patch Available (was: Open) > nodetool repair hangs on non-existant table > --- > > Key: CASSANDRA-12279 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12279 > Project: Cassandra > Issue Type: Bug > Environment: Linux Ubuntu, Openjdk >Reporter: Benjamin Roth >Priority: Minor > Labels: lhf > Attachments: CASSANDRA-12279-trunk.patch, new_result_example.txt, > org_result_example.txt > > > If nodetool repair is called with a table that does not exist, ist hangs > infinitely without any error message or logs. > E.g. > nodetool repair foo bar > Keyspace foo exists but table bar does not -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-12279) nodetool repair hangs on non-existant table
[ https://issues.apache.org/jira/browse/CASSANDRA-12279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Masataka Yamaguchi updated CASSANDRA-12279: --- Attachment: org_result_example.txt new_result_example.txt CASSANDRA-12279-trunk.patch This happens because the method “parseOptinalTables” in src/java/org/apache/cassandra/tools/NodeTool.java does not confirm that the given keyspace has the given table. The method “parseOptinalTables” is also used in some nodetool commands such as src/java/org/apache/cassandra/tools/nodetool/Cleanup.java, src/java/org/apache/cassandra/tools/nodetool/Compact.java and so on, and Java error happens when those commands are used with no-existent table name given, while they do not hang. I have reimplemented parseOptionalTables so that it confirms that the given keyspace has the given table, and I will send the patch. Please review it. > nodetool repair hangs on non-existant table > --- > > Key: CASSANDRA-12279 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12279 > Project: Cassandra > Issue Type: Bug > Environment: Linux Ubuntu, Openjdk >Reporter: Benjamin Roth >Priority: Minor > Labels: lhf > Attachments: CASSANDRA-12279-trunk.patch, new_result_example.txt, > org_result_example.txt > > > If nodetool repair is called with a table that does not exist, ist hangs > infinitely without any error message or logs. > E.g. > nodetool repair foo bar > Keyspace foo exists but table bar does not -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-12486) Structure for compactionhistory output (JSON, YAML)
[ https://issues.apache.org/jira/browse/CASSANDRA-12486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Masataka Yamaguchi updated CASSANDRA-12486: --- Attachment: CASSANDRA-12486-trunk.patch > Structure for compactionhistory output (JSON, YAML) > --- > > Key: CASSANDRA-12486 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12486 > Project: Cassandra > Issue Type: Improvement > Components: Tools >Reporter: Masataka Yamaguchi >Priority: Minor > Attachments: CASSANDRA-12486-trunk.patch, > compactionhistory_result.json, compactionhistory_result.txt, > compactionhistory_result.yaml > > > As with nodetool tpstats and tablestats (CASSANDRA-12035), nodetool > compactionhistory should also support useful output formats such as JSON or > YAML, so we implemented it. > Please review the attached patch. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-12486) Structure for compactionhistory output (JSON, YAML)
[ https://issues.apache.org/jira/browse/CASSANDRA-12486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Masataka Yamaguchi updated CASSANDRA-12486: --- Attachment: (was: CASSANDRA-12486-trunk.patch) > Structure for compactionhistory output (JSON, YAML) > --- > > Key: CASSANDRA-12486 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12486 > Project: Cassandra > Issue Type: Improvement > Components: Tools >Reporter: Masataka Yamaguchi >Priority: Minor > Attachments: CASSANDRA-12486-trunk.patch, > compactionhistory_result.json, compactionhistory_result.txt, > compactionhistory_result.yaml > > > As with nodetool tpstats and tablestats (CASSANDRA-12035), nodetool > compactionhistory should also support useful output formats such as JSON or > YAML, so we implemented it. > Please review the attached patch. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-12486) Structure for compactionhistory output (JSON, YAML)
[ https://issues.apache.org/jira/browse/CASSANDRA-12486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Masataka Yamaguchi updated CASSANDRA-12486: --- Status: Patch Available (was: Open) > Structure for compactionhistory output (JSON, YAML) > --- > > Key: CASSANDRA-12486 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12486 > Project: Cassandra > Issue Type: Improvement > Components: Tools >Reporter: Masataka Yamaguchi >Priority: Minor > Attachments: CASSANDRA-12486-trunk.patch, > compactionhistory_result.json, compactionhistory_result.txt, > compactionhistory_result.yaml > > > As with nodetool tpstats and tablestats (CASSANDRA-12035), nodetool > compactionhistory should also support useful output formats such as JSON or > YAML, so we implemented it. > Please review the attached patch. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-12486) Structure for compactionhistory output (JSON, YAML)
[ https://issues.apache.org/jira/browse/CASSANDRA-12486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Masataka Yamaguchi updated CASSANDRA-12486: --- Fix Version/s: (was: 3.10) > Structure for compactionhistory output (JSON, YAML) > --- > > Key: CASSANDRA-12486 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12486 > Project: Cassandra > Issue Type: Improvement > Components: Tools >Reporter: Masataka Yamaguchi >Priority: Minor > Attachments: CASSANDRA-12486-trunk.patch, > compactionhistory_result.json, compactionhistory_result.txt, > compactionhistory_result.yaml > > > As with nodetool tpstats and tablestats (CASSANDRA-12035), nodetool > compactionhistory should also support useful output formats such as JSON or > YAML, so we implemented it. > Please review the attached patch. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-12486) Structure for compactionhistory output (JSON, YAML)
[ https://issues.apache.org/jira/browse/CASSANDRA-12486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Masataka Yamaguchi updated CASSANDRA-12486: --- Attachment: CASSANDRA-12486-trunk.patch > Structure for compactionhistory output (JSON, YAML) > --- > > Key: CASSANDRA-12486 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12486 > Project: Cassandra > Issue Type: Improvement > Components: Tools >Reporter: Masataka Yamaguchi >Priority: Minor > Fix For: 3.10 > > Attachments: CASSANDRA-12486-trunk.patch, > compactionhistory_result.json, compactionhistory_result.txt, > compactionhistory_result.yaml > > > As with nodetool tpstats and tablestats (CASSANDRA-12035), nodetool > compactionhistory should also support useful output formats such as JSON or > YAML, so we implemented it. > Please review the attached patch. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (CASSANDRA-12486) Structure for compactionhistory output (JSON, YAML)
Masataka Yamaguchi created CASSANDRA-12486: -- Summary: Structure for compactionhistory output (JSON, YAML) Key: CASSANDRA-12486 URL: https://issues.apache.org/jira/browse/CASSANDRA-12486 Project: Cassandra Issue Type: Improvement Components: Tools Reporter: Masataka Yamaguchi Priority: Minor Fix For: 3.10 Attachments: CASSANDRA-12486-trunk.patch, compactionhistory_result.json, compactionhistory_result.txt, compactionhistory_result.yaml As with nodetool tpstats and tablestats (CASSANDRA-12035), nodetool compactionhistory should also support useful output formats such as JSON or YAML, so we implemented it. Please review the attached patch. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
