[jira] [Created] (CASSANDRA-3604) Bad code in org.apache.cassandra.cql.QueryProcessor

2011-12-09 Thread Zoltan Farkas (Created) (JIRA)
Bad code in org.apache.cassandra.cql.QueryProcessor
---

 Key: CASSANDRA-3604
 URL: https://issues.apache.org/jira/browse/CASSANDRA-3604
 Project: Cassandra
  Issue Type: Bug
Affects Versions: 1.0.5
 Environment: all
Reporter: Zoltan Farkas


line 206:
if (rows.get(0).key.key.equals(startKey))
rows.remove(0);

the equals will always return false because object of different types are 
compared

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Created] (CASSANDRA-3605) Exception swallowing in Hex.java

2011-12-09 Thread Zoltan Farkas (Created) (JIRA)
Exception swallowing in Hex.java


 Key: CASSANDRA-3605
 URL: https://issues.apache.org/jira/browse/CASSANDRA-3605
 Project: Cassandra
  Issue Type: Bug
Affects Versions: 1.0.5
 Environment: all
Reporter: Zoltan Farkas
Priority: Minor


org.apache.cassandra.utils.Hex line 94:

try
{
s = stringConstructor.newInstance(0, c.length, c);
}
catch (Exception e)
{
// Swallowing as we'll just use a copying constructor
}

this code does not comply with coding standard, caught exception needs to be 
rethrown as RuntimeException

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Created] (CASSANDRA-3607) Iterating through HashMap via key set instead of entry set

2011-12-09 Thread Zoltan Farkas (Created) (JIRA)
Iterating through HashMap via key set instead of entry set
--

 Key: CASSANDRA-3607
 URL: https://issues.apache.org/jira/browse/CASSANDRA-3607
 Project: Cassandra
  Issue Type: Improvement
 Environment: all
Reporter: Zoltan Farkas
Priority: Trivial


At StorageService.java:[line 2635]
At StorageService.java:[line 2687]
At SSTableImport.java:[line 286]
At CliClient.java:[line 2138]



--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira