[jira] [Commented] (CASSANDRA-13492) RPM Init: don't attempt to start if it's running
[ https://issues.apache.org/jira/browse/CASSANDRA-13492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16015924#comment-16015924 ] martin a langhoff commented on CASSANDRA-13492: --- My testing is on CentOS6 and friends; on CentOS6, I'll be testing it explicitly and report back. My 2c is that if you plan to only support systemd, there's a lot of good stuff to gain from using it right. Why would you use a SysV script? > RPM Init: don't attempt to start if it's running > > > Key: CASSANDRA-13492 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13492 > Project: Cassandra > Issue Type: Sub-task > Components: Packaging >Reporter: martin a langhoff >Assignee: Stefan Podkowinski > Attachments: 0002-RPM-Init-avoid-starting-cassandra-if-it-is-up.patch > > > We don't check whether Cassandra is running. Attempts to start Cassandra when > it's already running overwrite the pidfile, make a confusing mess of > logfiles, _fail to start, as the port is taken_; and then the init script > cannot bring the first Cassandra process down because the init file has been > clobbered. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13490) RPM Spec - disable binary check, improve readme instructions
[ https://issues.apache.org/jira/browse/CASSANDRA-13490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16014053#comment-16014053 ] martin a langhoff commented on CASSANDRA-13490: --- Yeah. That's roughly equivalent. One item I'd like to point is that my patch is a kludge, you're implementing my kludge fine :-) The right fix would be one of... * change from noarch to x86_64 arch specific, your package is lying in claiming it's "noarch", as it contains binary files compiled for x86_64 * not include binaries -- split off anything that needs binaries into a separate rpm using subpackages > RPM Spec - disable binary check, improve readme instructions > > > Key: CASSANDRA-13490 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13490 > Project: Cassandra > Issue Type: Sub-task > Components: Packaging >Reporter: martin a langhoff > Fix For: 3.11.0 > > Attachments: > 0001-RPM-rpmbuild-tolerate-binaries-in-noarch-README-upda.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13493) RPM Init: Service startup ordering
[ https://issues.apache.org/jira/browse/CASSANDRA-13493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16000678#comment-16000678 ] martin a langhoff commented on CASSANDRA-13493: --- For the BEGIN INIT INFO section, it seems to me that they could be made the same. For the chkconfig bits, it's not priority, it's _ordering_. If you want to start late, you need a high number. A good hint is to look at similar services, or services with similar needs, which are popular and packaged in Fedora/RHEL. So we could look at PostgreSQL or MySQL, which need the network, network-based storage, etc. And they both have "chkconfig: - 64 36". So we could match those, or keep the ones in my patch which are more conservative. > RPM Init: Service startup ordering > -- > > Key: CASSANDRA-13493 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13493 > Project: Cassandra > Issue Type: Sub-task > Components: Packaging >Reporter: martin a langhoff > Fix For: 3.11.0 > > Attachments: > 0001-RPM-Init-ordering-start-after-network-and-name-servi.patch > > > Currently, Cassandra is setup to start _before_ network and name services > come up, and setup to be town down _after_ them, dangerously close to the > final shutdown call. > A service daemon which may use network-based storage, and serves requests > over a network needs to start clearly after network and network mounts, and > come down clearly after. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-13493) RPM Init: Service startup ordering
[ https://issues.apache.org/jira/browse/CASSANDRA-13493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] martin a langhoff updated CASSANDRA-13493: -- Attachment: 0001-RPM-Init-ordering-start-after-network-and-name-servi.patch > RPM Init: Service startup ordering > -- > > Key: CASSANDRA-13493 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13493 > Project: Cassandra > Issue Type: Sub-task > Components: Packaging >Reporter: martin a langhoff > Fix For: 3.11.0 > > Attachments: > 0001-RPM-Init-ordering-start-after-network-and-name-servi.patch > > > Currently, Cassandra is setup to start _before_ network and name services > come up, and setup to be town down _after_ them, dangerously close to the > final shutdown call. > A service daemon which may use network-based storage, and serves requests > over a network needs to start clearly after network and network mounts, and > come down clearly after. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-13493) RPM Init: Service startup ordering
[ https://issues.apache.org/jira/browse/CASSANDRA-13493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] martin a langhoff updated CASSANDRA-13493: -- Reviewer: Michael Shuler Fix Version/s: 3.11.0 Status: Patch Available (was: Open) > RPM Init: Service startup ordering > -- > > Key: CASSANDRA-13493 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13493 > Project: Cassandra > Issue Type: Sub-task > Components: Packaging >Reporter: martin a langhoff > Fix For: 3.11.0 > > Attachments: > 0001-RPM-Init-ordering-start-after-network-and-name-servi.patch > > > Currently, Cassandra is setup to start _before_ network and name services > come up, and setup to be town down _after_ them, dangerously close to the > final shutdown call. > A service daemon which may use network-based storage, and serves requests > over a network needs to start clearly after network and network mounts, and > come down clearly after. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-13492) RPM Init: don't attempt to start if it's running
[ https://issues.apache.org/jira/browse/CASSANDRA-13492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] martin a langhoff updated CASSANDRA-13492: -- Reviewer: Michael Shuler Fix Version/s: 3.11.0 Status: Patch Available (was: Open) > RPM Init: don't attempt to start if it's running > > > Key: CASSANDRA-13492 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13492 > Project: Cassandra > Issue Type: Sub-task > Components: Packaging >Reporter: martin a langhoff > Fix For: 3.11.0 > > Attachments: 0002-RPM-Init-avoid-starting-cassandra-if-it-is-up.patch > > > We don't check whether Cassandra is running. Attempts to start Cassandra when > it's already running overwrite the pidfile, make a confusing mess of > logfiles, _fail to start, as the port is taken_; and then the init script > cannot bring the first Cassandra process down because the init file has been > clobbered. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-13492) RPM Init: don't attempt to start if it's running
[ https://issues.apache.org/jira/browse/CASSANDRA-13492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] martin a langhoff updated CASSANDRA-13492: -- Attachment: 0002-RPM-Init-avoid-starting-cassandra-if-it-is-up.patch > RPM Init: don't attempt to start if it's running > > > Key: CASSANDRA-13492 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13492 > Project: Cassandra > Issue Type: Sub-task > Components: Packaging >Reporter: martin a langhoff > Attachments: 0002-RPM-Init-avoid-starting-cassandra-if-it-is-up.patch > > > We don't check whether Cassandra is running. Attempts to start Cassandra when > it's already running overwrite the pidfile, make a confusing mess of > logfiles, _fail to start, as the port is taken_; and then the init script > cannot bring the first Cassandra process down because the init file has been > clobbered. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-13493) RPM Init: Service startup ordering
martin a langhoff created CASSANDRA-13493: - Summary: RPM Init: Service startup ordering Key: CASSANDRA-13493 URL: https://issues.apache.org/jira/browse/CASSANDRA-13493 Project: Cassandra Issue Type: Sub-task Reporter: martin a langhoff Currently, Cassandra is setup to start _before_ network and name services come up, and setup to be town down _after_ them, dangerously close to the final shutdown call. A service daemon which may use network-based storage, and serves requests over a network needs to start clearly after network and network mounts, and come down clearly after. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-13492) RPM Init: don't attempt to start if it's running
martin a langhoff created CASSANDRA-13492: - Summary: RPM Init: don't attempt to start if it's running Key: CASSANDRA-13492 URL: https://issues.apache.org/jira/browse/CASSANDRA-13492 Project: Cassandra Issue Type: Sub-task Reporter: martin a langhoff We don't check whether Cassandra is running. Attempts to start Cassandra when it's already running overwrite the pidfile, make a confusing mess of logfiles, _fail to start, as the port is taken_; and then the init script cannot bring the first Cassandra process down because the init file has been clobbered. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-13490) RPM Spec - disable binary check, improve readme instructions
[ https://issues.apache.org/jira/browse/CASSANDRA-13490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] martin a langhoff updated CASSANDRA-13490: -- Attachment: 0001-RPM-rpmbuild-tolerate-binaries-in-noarch-README-upda.patch > RPM Spec - disable binary check, improve readme instructions > > > Key: CASSANDRA-13490 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13490 > Project: Cassandra > Issue Type: Sub-task > Components: Packaging >Reporter: martin a langhoff > Fix For: 3.11.0 > > Attachments: > 0001-RPM-rpmbuild-tolerate-binaries-in-noarch-README-upda.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-13490) RPM Spec - disable binary check, improve readme instructions
[ https://issues.apache.org/jira/browse/CASSANDRA-13490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] martin a langhoff updated CASSANDRA-13490: -- Reviewer: Michael Shuler Fix Version/s: 3.11.0 Status: Patch Available (was: Open) > RPM Spec - disable binary check, improve readme instructions > > > Key: CASSANDRA-13490 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13490 > Project: Cassandra > Issue Type: Sub-task > Components: Packaging >Reporter: martin a langhoff > Fix For: 3.11.0 > > -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-13490) RPM Spec - disable binary check, improve readme instructions
martin a langhoff created CASSANDRA-13490: - Summary: RPM Spec - disable binary check, improve readme instructions Key: CASSANDRA-13490 URL: https://issues.apache.org/jira/browse/CASSANDRA-13490 Project: Cassandra Issue Type: Sub-task Reporter: martin a langhoff -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
