Re: [PR] CASSANDRA-16969 4.11.x license check [cassandra-java-driver]

2024-02-20 Thread via GitHub


absurdfarce commented on PR #1775:
URL: 
https://github.com/apache/cassandra-java-driver/pull/1775#issuecomment-1954945989

   Closing based on quick conversation with @Claudenw 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



Re: [PR] CASSANDRA-16969 4.11.x license check [cassandra-java-driver]

2024-02-20 Thread via GitHub


absurdfarce closed pull request #1775: CASSANDRA-16969 4.11.x license check
URL: https://github.com/apache/cassandra-java-driver/pull/1775


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



Re: [PR] CASSANDRA-16969 4.11.x license check [cassandra-java-driver]

2023-11-10 Thread via GitHub


hhughes commented on PR #1775:
URL: 
https://github.com/apache/cassandra-java-driver/pull/1775#issuecomment-1806512012

   Please close in favor of #1823 (which retains original contributor credit)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



Re: [PR] CASSANDRA-16969 4.11.x license check [cassandra-java-driver]

2023-11-08 Thread via GitHub


hhughes commented on code in PR #1775:
URL: 
https://github.com/apache/cassandra-java-driver/pull/1775#discussion_r1386933156


##
ci/install-jdk.sh:
##
@@ -1,4 +1,20 @@
 #!/usr/bin/env bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+# 
+#   http://www.apache.org/licenses/LICENSE-2.0
+# 
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.

Review Comment:
   Per @michaelsembwever - 
[link](https://github.com/apache/cassandra-java-driver/pull/1803#discussion_r1386773964)
 - is it correct to add a ASF license to this file which already has a 
3rd-party license header?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



Re: [PR] CASSANDRA-16969: 4.11.x license check [cassandra-java-driver]

2023-11-08 Thread via GitHub


hhughes commented on PR #1802:
URL: 
https://github.com/apache/cassandra-java-driver/pull/1802#issuecomment-1802285381

   We should update the original version of this PR instead - #1763 - closing 
out.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



Re: [PR] CASSANDRA-16969: 4.11.x license check [cassandra-java-driver]

2023-11-08 Thread via GitHub


hhughes closed pull request #1802: CASSANDRA-16969: 4.11.x license check
URL: https://github.com/apache/cassandra-java-driver/pull/1802


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



Re: [PR] CASSANDRA-16969 4.11.x license check [cassandra-java-driver]

2023-11-06 Thread via GitHub


hhughes commented on PR #1775:
URL: 
https://github.com/apache/cassandra-java-driver/pull/1775#issuecomment-1797829134

   I've opened #1802 which has a properly formatted `Jenkinsfile`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[PR] CASSANDRA-16969: 4.11.x license check [cassandra-java-driver]

2023-11-06 Thread via GitHub


hhughes opened a new pull request, #1802:
URL: https://github.com/apache/cassandra-java-driver/pull/1802

   Files with unapproved licenses:
 /Users/henry.hughes/repos/java-driver/.gitignore
 
/Users/henry.hughes/repos/java-driver/core/src/main/resources/META-INF/services/reactor.blockhound.integration.BlockHoundIntegration
 
/Users/henry.hughes/repos/java-driver/core/src/test/resources/insights/duplicate-dependencies.txt
 
/Users/henry.hughes/repos/java-driver/core/src/test/resources/insights/netty-dependency-optional.txt
 
/Users/henry.hughes/repos/java-driver/core/src/test/resources/insights/netty-dependency.txt
 
/Users/henry.hughes/repos/java-driver/core/src/test/resources/insights/ordered-dependencies.txt
 
/Users/henry.hughes/repos/java-driver/core/src/test/resources/insights/test-dependencies.txt
 
/Users/henry.hughes/repos/java-driver/integration-tests/src/test/resources/META-INF/services/com.datastax.oss.driver.api.mapper.result.MapperResultProducerService
 /Users/henry.hughes/repos/java-driver/manual/.nav
 /Users/henry.hughes/repos/java-driver/manual/core/dse/.nav
 /Users/henry.hughes/repos/java-driver/manual/core/dse/graph/.nav
 /Users/henry.hughes/repos/java-driver/manual/core/dse/graph/fluent/.nav
 /Users/henry.hughes/repos/java-driver/manual/core/statements/.nav
 /Users/henry.hughes/repos/java-driver/manual/developer/.nav
 /Users/henry.hughes/repos/java-driver/manual/developer/common/.nav
 /Users/henry.hughes/repos/java-driver/manual/mapper/.nav
 /Users/henry.hughes/repos/java-driver/manual/mapper/daos/.nav
 /Users/henry.hughes/repos/java-driver/manual/query_builder/.nav
 /Users/henry.hughes/repos/java-driver/manual/query_builder/schema/.nav
 
/Users/henry.hughes/repos/java-driver/mapper-processor/src/main/resources/META-INF/services/javax.annotation.processing.Processor
 
/Users/henry.hughes/repos/java-driver/test-infra/src/main/resources/client.crt
 
/Users/henry.hughes/repos/java-driver/test-infra/src/main/resources/client.key


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[PR] CASSANDRA-16969 4.11.x license check [cassandra-java-driver]

2023-11-06 Thread via GitHub


Claudenw opened a new pull request, #1775:
URL: https://github.com/apache/cassandra-java-driver/pull/1775

   Files with unapproved licenses:
 /home/claude/apache/cassandra-java-driver/.gitignore
 
/home/claude/apache/cassandra-java-driver/core/src/main/resources/META-INF/services/reactor.blockhound.integration.BlockHoundIntegration
 
/home/claude/apache/cassandra-java-driver/core/src/test/resources/insights/duplicate-dependencies.txt
 
/home/claude/apache/cassandra-java-driver/core/src/test/resources/insights/netty-dependency-optional.txt
 
/home/claude/apache/cassandra-java-driver/core/src/test/resources/insights/netty-dependency.txt
 
/home/claude/apache/cassandra-java-driver/core/src/test/resources/insights/ordered-dependencies.txt
 
/home/claude/apache/cassandra-java-driver/core/src/test/resources/insights/test-dependencies.txt
 
/home/claude/apache/cassandra-java-driver/integration-tests/src/test/resources/META-INF/services/com.datastax.oss.driver.api.mapper.result.MapperResultProducerService
 /home/claude/apache/cassandra-java-driver/manual/.nav
 /home/claude/apache/cassandra-java-driver/manual/core/dse/.nav
 /home/claude/apache/cassandra-java-driver/manual/core/dse/graph/.nav
 /home/claude/apache/cassandra-java-driver/manual/core/dse/graph/fluent/.nav
 /home/claude/apache/cassandra-java-driver/manual/core/statements/.nav
 /home/claude/apache/cassandra-java-driver/manual/developer/.nav
 /home/claude/apache/cassandra-java-driver/manual/developer/common/.nav
 /home/claude/apache/cassandra-java-driver/manual/mapper/.nav
 /home/claude/apache/cassandra-java-driver/manual/mapper/daos/.nav
 /home/claude/apache/cassandra-java-driver/manual/query_builder/.nav
 /home/claude/apache/cassandra-java-driver/manual/query_builder/schema/.nav
 
/home/claude/apache/cassandra-java-driver/mapper-processor/src/main/resources/META-INF/services/javax.annotation.processing.Processor
 
/home/claude/apache/cassandra-java-driver/test-infra/src/main/resources/client.crt
 
/home/claude/apache/cassandra-java-driver/test-infra/src/main/resources/client.key
   
   
   
   I believe all of the above files are acceptable.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org