[jira] [Comment Edited] (CASSANDRA-10190) Python 3 support for cqlsh
[ https://issues.apache.org/jira/browse/CASSANDRA-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17037196#comment-17037196 ] Dinesh Joshi edited comment on CASSANDRA-10190 at 2/14/20 6:48 PM: --- Thank you everyone for your help! This has been committed to [cassandra|https://github.com/apache/cassandra/commit/bf9a1d487b9ba469e8d740cf7d1cd419535a7e79] and [cassandra-dtest|https://github.com/apache/cassandra-dtest/commit/175a083a6f3b4d5d58f3702d31ce6920af519669]. The one dtest failure seems to be flakey. All other dtests and cqlsh tests are green. !Screen Shot 2020-02-14 at 10.40.05 AM.png|height=600! was (Author: djoshi3): Thank you everyone for your help! This has been committed to [cassandra|https://github.com/apache/cassandra/commit/bf9a1d487b9ba469e8d740cf7d1cd419535a7e79] and [cassandra-dtest|https://github.com/apache/cassandra-dtest/commit/175a083a6f3b4d5d58f3702d31ce6920af519669]. The one dtest failure seems to be flakey. All other dtests and cqlsh tests are green. !Screen Shot 2020-02-14 at 10.40.05 AM.png|thumbnail! > Python 3 support for cqlsh > -- > > Key: CASSANDRA-10190 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10190 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Tools >Reporter: Andrew Pennebaker >Assignee: Patrick Bannister >Priority: Normal > Labels: cqlsh, pull-request-available > Fix For: 4.0, 4.0-alpha > > Attachments: > 0001-Fix-issues-from-version-specific-logic-commit.patch, > 0001-Update-six-to-1.12.0.patch, > 0002-Simplify-version-specific-logic-by-using-six.moves-a.patch, Screen Shot > 2020-02-14 at 10.40.05 AM.png, coverage_notes.txt > > Time Spent: 1.5h > Remaining Estimate: 0h > > Users who operate in a Python 3 environment may have trouble launching cqlsh. > Could we please update cqlsh's syntax to run in Python 3? > As a workaround, users can setup pyenv, and cd to a directory with a > .python-version containing "2.7". But it would be nice if cqlsh supported > modern Python versions out of the box. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-10190) Python 3 support for cqlsh
[ https://issues.apache.org/jira/browse/CASSANDRA-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17037196#comment-17037196 ] Dinesh Joshi edited comment on CASSANDRA-10190 at 2/14/20 6:46 PM: --- Thank you everyone for your help! This has been committed to [cassandra|https://github.com/apache/cassandra/commit/bf9a1d487b9ba469e8d740cf7d1cd419535a7e79] and [cassandra-dtest|https://github.com/apache/cassandra-dtest/commit/175a083a6f3b4d5d58f3702d31ce6920af519669]. The one dtest failure seems to be flakey. All other dtests and cqlsh tests are green. !Screen Shot 2020-02-14 at 10.40.05 AM.png! was (Author: djoshi3): Thank you everyone for your help! This has been committed to [cassandra|https://github.com/apache/cassandra/commit/bf9a1d487b9ba469e8d740cf7d1cd419535a7e79] and [cassandra-dtest|https://github.com/apache/cassandra-dtest/commit/175a083a6f3b4d5d58f3702d31ce6920af519669]. The one dtest failure seems to be flakey. All other dtests and cqlsh tests are green. > Python 3 support for cqlsh > -- > > Key: CASSANDRA-10190 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10190 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Tools >Reporter: Andrew Pennebaker >Assignee: Patrick Bannister >Priority: Normal > Labels: cqlsh, pull-request-available > Fix For: 4.0, 4.0-alpha > > Attachments: > 0001-Fix-issues-from-version-specific-logic-commit.patch, > 0001-Update-six-to-1.12.0.patch, > 0002-Simplify-version-specific-logic-by-using-six.moves-a.patch, Screen Shot > 2020-02-14 at 10.40.05 AM.png, coverage_notes.txt > > Time Spent: 1.5h > Remaining Estimate: 0h > > Users who operate in a Python 3 environment may have trouble launching cqlsh. > Could we please update cqlsh's syntax to run in Python 3? > As a workaround, users can setup pyenv, and cd to a directory with a > .python-version containing "2.7". But it would be nice if cqlsh supported > modern Python versions out of the box. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-10190) Python 3 support for cqlsh
[ https://issues.apache.org/jira/browse/CASSANDRA-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17037196#comment-17037196 ] Dinesh Joshi edited comment on CASSANDRA-10190 at 2/14/20 6:46 PM: --- Thank you everyone for your help! This has been committed to [cassandra|https://github.com/apache/cassandra/commit/bf9a1d487b9ba469e8d740cf7d1cd419535a7e79] and [cassandra-dtest|https://github.com/apache/cassandra-dtest/commit/175a083a6f3b4d5d58f3702d31ce6920af519669]. The one dtest failure seems to be flakey. All other dtests and cqlsh tests are green. !Screen Shot 2020-02-14 at 10.40.05 AM.png|thumbnail! was (Author: djoshi3): Thank you everyone for your help! This has been committed to [cassandra|https://github.com/apache/cassandra/commit/bf9a1d487b9ba469e8d740cf7d1cd419535a7e79] and [cassandra-dtest|https://github.com/apache/cassandra-dtest/commit/175a083a6f3b4d5d58f3702d31ce6920af519669]. The one dtest failure seems to be flakey. All other dtests and cqlsh tests are green. !Screen Shot 2020-02-14 at 10.40.05 AM.png! > Python 3 support for cqlsh > -- > > Key: CASSANDRA-10190 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10190 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Tools >Reporter: Andrew Pennebaker >Assignee: Patrick Bannister >Priority: Normal > Labels: cqlsh, pull-request-available > Fix For: 4.0, 4.0-alpha > > Attachments: > 0001-Fix-issues-from-version-specific-logic-commit.patch, > 0001-Update-six-to-1.12.0.patch, > 0002-Simplify-version-specific-logic-by-using-six.moves-a.patch, Screen Shot > 2020-02-14 at 10.40.05 AM.png, coverage_notes.txt > > Time Spent: 1.5h > Remaining Estimate: 0h > > Users who operate in a Python 3 environment may have trouble launching cqlsh. > Could we please update cqlsh's syntax to run in Python 3? > As a workaround, users can setup pyenv, and cd to a directory with a > .python-version containing "2.7". But it would be nice if cqlsh supported > modern Python versions out of the box. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-10190) Python 3 support for cqlsh
[ https://issues.apache.org/jira/browse/CASSANDRA-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17031896#comment-17031896 ] Dinesh Joshi edited comment on CASSANDRA-10190 at 2/6/20 9:41 PM: -- [~ptbannister] and [~dcapwell] I have addressed your review comments. I also removed the Python 2 specific code from cassandra-dtests as dtests themselves are expected to be Python 3 only. I have added the circleci changes to this patch so can get this in trunk. However, we would need to backport it to other branches or Python 2.7 only. Latest test runs are [here|https://circleci.com/workflow-run/d49608a5-f630-478c-947a-55a96048f5a1]. Please ignore the flakey unit test failure. was (Author: djoshi3): [~ptbannister] and [~dcapwell] I have addressed your review comments. I also removed the Python 2 specific code from cassandra-dtests as dtests themselves are expected to be Python 3 only. I have added the circleci changes to this patch so can get this in trunk. However, we would need to backport it to other branches or Python 2.7 only. > Python 3 support for cqlsh > -- > > Key: CASSANDRA-10190 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10190 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Tools >Reporter: Andrew Pennebaker >Assignee: Patrick Bannister >Priority: Normal > Labels: cqlsh, pull-request-available > Fix For: 4.0, 4.0-alpha > > Attachments: > 0001-Fix-issues-from-version-specific-logic-commit.patch, > 0001-Update-six-to-1.12.0.patch, > 0002-Simplify-version-specific-logic-by-using-six.moves-a.patch, > coverage_notes.txt > > Time Spent: 1h 20m > Remaining Estimate: 0h > > Users who operate in a Python 3 environment may have trouble launching cqlsh. > Could we please update cqlsh's syntax to run in Python 3? > As a workaround, users can setup pyenv, and cd to a directory with a > .python-version containing "2.7". But it would be nice if cqlsh supported > modern Python versions out of the box. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-10190) Python 3 support for cqlsh
[ https://issues.apache.org/jira/browse/CASSANDRA-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17031896#comment-17031896 ] Dinesh Joshi edited comment on CASSANDRA-10190 at 2/6/20 9:34 PM: -- [~ptbannister] and [~dcapwell] I have addressed your review comments. I also removed the Python 2 specific code from cassandra-dtests as dtests themselves are expected to be Python 3 only. I have added the circleci changes to this patch so can get this in trunk. However, we would need to backport it to other branches or Python 2.7 only. was (Author: djoshi3): [~ptbannister] and [~dcapwell] I have addressed your review comments except build related changes. I also removed the Python 2 specific code from cassandra-dtests as dtests themselves are expected to be Python 3 only. > Python 3 support for cqlsh > -- > > Key: CASSANDRA-10190 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10190 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Tools >Reporter: Andrew Pennebaker >Assignee: Patrick Bannister >Priority: Normal > Labels: cqlsh, pull-request-available > Fix For: 4.0, 4.0-alpha > > Attachments: > 0001-Fix-issues-from-version-specific-logic-commit.patch, > 0001-Update-six-to-1.12.0.patch, > 0002-Simplify-version-specific-logic-by-using-six.moves-a.patch, > coverage_notes.txt > > Time Spent: 1h 20m > Remaining Estimate: 0h > > Users who operate in a Python 3 environment may have trouble launching cqlsh. > Could we please update cqlsh's syntax to run in Python 3? > As a workaround, users can setup pyenv, and cd to a directory with a > .python-version containing "2.7". But it would be nice if cqlsh supported > modern Python versions out of the box. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-10190) Python 3 support for cqlsh
[ https://issues.apache.org/jira/browse/CASSANDRA-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17031896#comment-17031896 ] Dinesh Joshi edited comment on CASSANDRA-10190 at 2/6/20 8:25 PM: -- [~ptbannister] and [~dcapwell] I have addressed your review comments except build related changes. I also removed the Python 2 specific code from cassandra-dtests as dtests themselves are expected to be Python 3 only. was (Author: djoshi3): [~ptbannister] and [~dcapwell] I have addressed your review comments. I also removed the Python 2 specific code from cassandra-dtests as dtests themselves are expected to be Python 3 only. > Python 3 support for cqlsh > -- > > Key: CASSANDRA-10190 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10190 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Tools >Reporter: Andrew Pennebaker >Assignee: Patrick Bannister >Priority: Normal > Labels: cqlsh, pull-request-available > Fix For: 4.0, 4.0-alpha > > Attachments: > 0001-Fix-issues-from-version-specific-logic-commit.patch, > 0001-Update-six-to-1.12.0.patch, > 0002-Simplify-version-specific-logic-by-using-six.moves-a.patch, > coverage_notes.txt > > Time Spent: 1h 20m > Remaining Estimate: 0h > > Users who operate in a Python 3 environment may have trouble launching cqlsh. > Could we please update cqlsh's syntax to run in Python 3? > As a workaround, users can setup pyenv, and cd to a directory with a > .python-version containing "2.7". But it would be nice if cqlsh supported > modern Python versions out of the box. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-10190) Python 3 support for cqlsh
[ https://issues.apache.org/jira/browse/CASSANDRA-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027226#comment-17027226 ] Dinesh Joshi edited comment on CASSANDRA-10190 at 1/31/20 6:41 AM: --- [~jaikiran] ofcourse. You can clone my branch and build C* and use cqlsh that is packaged in there. Please note that this ticket is still WIP and I appreciate early feedback, however I might address issues in follow on tickets. was (Author: djoshi3): [~jaikiran] ofcourse. You can clone my branch and build C* and use cqlsh that is packaged in there. > Python 3 support for cqlsh > -- > > Key: CASSANDRA-10190 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10190 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Tools >Reporter: Andrew Pennebaker >Assignee: Patrick Bannister >Priority: Normal > Labels: cqlsh > Fix For: 4.0, 4.0-alpha > > Attachments: > 0001-Fix-issues-from-version-specific-logic-commit.patch, > 0001-Update-six-to-1.12.0.patch, > 0002-Simplify-version-specific-logic-by-using-six.moves-a.patch, > coverage_notes.txt > > > Users who operate in a Python 3 environment may have trouble launching cqlsh. > Could we please update cqlsh's syntax to run in Python 3? > As a workaround, users can setup pyenv, and cd to a directory with a > .python-version containing "2.7". But it would be nice if cqlsh supported > modern Python versions out of the box. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-10190) Python 3 support for cqlsh
[ https://issues.apache.org/jira/browse/CASSANDRA-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17022679#comment-17022679 ] Dinesh Joshi edited comment on CASSANDRA-10190 at 1/28/20 1:45 AM: --- I have rebased and squashed, [~ptbannister]'s original branch into my repo [here|https://github.com/dineshjoshi/cassandra/tree/10190-trunk-review]. Let's use this branch going forward. I also ran [circleci|https://circleci.com/workflow-run/53b5f86f-2a97-4ce8-8269-9fab522f9406] jobs. There are about 5 tests that are failing right now. The following tests pass locally but fail on CircleCI (let's debug these later) – - test_writing_with_token_boundaries - test_datetime_values - test_remote_query The following tests fail locally and on CircleCI so I think these are genuine failures (let's focus on them right now) – - test_complex_schema - test_complex_data_types was (Author: djoshi3): I have rebased and squashed, [~ptbannister]'s original branch into my repo [here|https://github.com/dineshjoshi/cassandra/tree/10190-trunk-review]. Let's use this branch going forward. I also ran [circleci|https://circleci.com/workflow-run/53b5f86f-2a97-4ce8-8269-9fab522f9406] jobs. There are about 5 tests that are failing right now. The following tests pass locally but fail on CircleCI (let's debug these later) – - test_writing_with_token_boundaries - test_datetime_values - test_remote_query The following tests fail locally and on CircleCI so I think these are Genuine failures (let's focus on them right now) – - test_complex_schema - test_complex_data_types > Python 3 support for cqlsh > -- > > Key: CASSANDRA-10190 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10190 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Tools >Reporter: Andrew Pennebaker >Assignee: Patrick Bannister >Priority: Normal > Labels: cqlsh > Fix For: 4.0, 4.0-alpha > > Attachments: > 0001-Fix-issues-from-version-specific-logic-commit.patch, > 0001-Update-six-to-1.12.0.patch, > 0002-Simplify-version-specific-logic-by-using-six.moves-a.patch, > coverage_notes.txt > > > Users who operate in a Python 3 environment may have trouble launching cqlsh. > Could we please update cqlsh's syntax to run in Python 3? > As a workaround, users can setup pyenv, and cd to a directory with a > .python-version containing "2.7". But it would be nice if cqlsh supported > modern Python versions out of the box. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-10190) Python 3 support for cqlsh
[
https://issues.apache.org/jira/browse/CASSANDRA-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17024803#comment-17024803
]
Dinesh Joshi edited comment on CASSANDRA-10190 at 1/28/20 1:44 AM:
---
I have pushed an update to my
[branch|https://github.com/dineshjoshi/cassandra/tree/10190-trunk-review] which
fixes {{test_complex_schema}} and {{test_complex_data_types}}. Turned out to be
a minor issue. I also ran into an issue with running cqlsh on the command line.
The code was trying to import {{six}} before it was included in the
{{PYTHONPATH}}.
Tests are running
[here|https://circleci.com/workflow-run/6ae89f2e-b357-48ac-b945-4bc2d9f78f30].
was (Author: djoshi3):
I have pushed an update to my
[branch|https://github.com/dineshjoshi/cassandra/tree/10190-trunk-review] which
fixes {{test_complex_schema}} and {{test_complex_data_types}}. Turned out to be
a minor issue. I also ran into an issue with running cqlsh on the command line.
The code was trying to import {{six}} before it was included in the
{{PYTHONPATH}}.
> Python 3 support for cqlsh
> --
>
> Key: CASSANDRA-10190
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10190
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Tools
>Reporter: Andrew Pennebaker
>Assignee: Patrick Bannister
>Priority: Normal
> Labels: cqlsh
> Fix For: 4.0, 4.0-alpha
>
> Attachments:
> 0001-Fix-issues-from-version-specific-logic-commit.patch,
> 0001-Update-six-to-1.12.0.patch,
> 0002-Simplify-version-specific-logic-by-using-six.moves-a.patch,
> coverage_notes.txt
>
>
> Users who operate in a Python 3 environment may have trouble launching cqlsh.
> Could we please update cqlsh's syntax to run in Python 3?
> As a workaround, users can setup pyenv, and cd to a directory with a
> .python-version containing "2.7". But it would be nice if cqlsh supported
> modern Python versions out of the box.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-10190) Python 3 support for cqlsh
[ https://issues.apache.org/jira/browse/CASSANDRA-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17022679#comment-17022679 ] Dinesh Joshi edited comment on CASSANDRA-10190 at 1/24/20 4:36 AM: --- I have rebased and squashed, [~ptbannister]'s original branch into my repo [here|https://github.com/dineshjoshi/cassandra/tree/10190-trunk-review]. Let's use this branch going forward. I also ran [circleci|https://circleci.com/workflow-run/53b5f86f-2a97-4ce8-8269-9fab522f9406] jobs. There are about 5 tests that are failing right now. The following tests pass locally but fail on CircleCI (let's debug these later) – - test_writing_with_token_boundaries - test_datetime_values - test_remote_query The following tests fail locally and on CircleCI so I think these are Genuine failures (let's focus on them right now) – - test_complex_schema - test_complex_data_types was (Author: djoshi3): I have rebased and squashed, [~ptbannister]'s original branch into my repo [here|https://github.com/dineshjoshi/cassandra/tree/10190-trunk-review] and run [circleci|https://circleci.com/workflow-run/53b5f86f-2a97-4ce8-8269-9fab522f9406] jobs. There are about 5 tests that are failing right now. The following tests pass locally but fail on CircleCI (let's debug these later) – - test_writing_with_token_boundaries - test_datetime_values - test_remote_query The following tests fail locally and on CircleCI so I think these are Genuine failures (let's focus on them right now) – - test_complex_schema - test_complex_data_types > Python 3 support for cqlsh > -- > > Key: CASSANDRA-10190 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10190 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Tools >Reporter: Andrew Pennebaker >Assignee: Patrick Bannister >Priority: Normal > Labels: cqlsh > Fix For: 4.0, 4.0-alpha > > Attachments: > 0001-Fix-issues-from-version-specific-logic-commit.patch, > 0001-Update-six-to-1.12.0.patch, > 0002-Simplify-version-specific-logic-by-using-six.moves-a.patch, > coverage_notes.txt > > > Users who operate in a Python 3 environment may have trouble launching cqlsh. > Could we please update cqlsh's syntax to run in Python 3? > As a workaround, users can setup pyenv, and cd to a directory with a > .python-version containing "2.7". But it would be nice if cqlsh supported > modern Python versions out of the box. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-10190) Python 3 support for cqlsh
[
https://issues.apache.org/jira/browse/CASSANDRA-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16945587#comment-16945587
]
Andy Tolbert edited comment on CASSANDRA-10190 at 10/7/19 4:58 AM:
---
{quote}
I think it's worth updating the driver to a newer version
{quote}
I just read the comments earlier in the thread about the driver, mainly this
one:
{quote}
Finally, extracting the checked in driver is something we'll look into. But
that is a longpole and strictly not needed for Python 3 compatibility.
{quote}
Agree with that, don't think that should hold things up, it can be done out of
band. Noticed that I had already opened up a ticket for updating the python
driver a while back for a different reason ([CASSANDRA-14872]), and there's
probably other 4.0 specific reasons it needs to be updated, so would be good to
do that separately.
was (Author: andrew.tolbert):
{quote}
I think it's worth updating the driver to a newer version
{quote}
I just read the comments earlier in the thread about the driver, mainly this
one:
{quote}
Finally, extracting the checked in driver is something we'll look into. But
that is a longpole and strictly not needed for Python 3 compatibility.
{quote}
Agree with that, don't think that should hold things up, it can be done out of
band. Noticed that I had already opened up a ticket of updating the python
driver a while back for a different reason ([CASSANDRA-14872]), and there's
probably other 4.0 specific reasons it needs to be updated, so would be good to
do that separately.
> Python 3 support for cqlsh
> --
>
> Key: CASSANDRA-10190
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10190
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Tools
>Reporter: Andrew Pennebaker
>Assignee: Patrick Bannister
>Priority: Normal
> Labels: cqlsh
> Fix For: 4.0, 4.0-alpha
>
> Attachments: 0001-Update-six-to-1.12.0.patch,
> 0002-Simplify-version-specific-logic-by-using-six.moves-a.patch,
> coverage_notes.txt
>
>
> Users who operate in a Python 3 environment may have trouble launching cqlsh.
> Could we please update cqlsh's syntax to run in Python 3?
> As a workaround, users can setup pyenv, and cd to a directory with a
> .python-version containing "2.7". But it would be nice if cqlsh supported
> modern Python versions out of the box.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-10190) Python 3 support for cqlsh
[
https://issues.apache.org/jira/browse/CASSANDRA-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928785#comment-16928785
]
Patrick Bannister edited comment on CASSANDRA-10190 at 9/13/19 1:23 AM:
I'm experimenting with the {{test_cqlsh_completion}} unit tests to try to make
them faster and more like unit tests. Right now they work more like dtests (as
do most of the cqlshlib unit tests).
This is not worth holding up the ticket to do, but I'll push the results up to
the branch if I can finish something before we're ready to proceed.
was (Author: ptbannister):
I'm experimenting with changing the cqlshlib unit tests in
{{test_cqlsh_completion}}. These are the slowest part of the cqlshlib unit test
suite. They currently work by running cqlsh in a subprocess to connect to a ccm
cluster, sending partial commands to the cqlsh, and reading the completions
suggested by the cqlsh. This is slow, because we have to use a timeout to wait
for the cqlsh to accept our input and output its recommended completions.
In general, these don't really look like unit tests, they look more like
dtests. One approach would be to remove this from the unit tests and make it
part of the dtests. But I'd prefer to convert them to something more like a
unit test. We can make them run faster by using cqlshlib internals directly,
instead of running cqlsh in a subprocess. We can call {{cql_complete}} on each
partial command and assert that the completions are what we expect.
Once I've rewritten the {{test_cqlsh_completion.py}} tests like this, it'll be
up on the branch for consideration.
> Python 3 support for cqlsh
> --
>
> Key: CASSANDRA-10190
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10190
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Tools
>Reporter: Andrew Pennebaker
>Assignee: Patrick Bannister
>Priority: Normal
> Labels: cqlsh
> Fix For: 4.0, 4.0-alpha
>
> Attachments: coverage_notes.txt
>
>
> Users who operate in a Python 3 environment may have trouble launching cqlsh.
> Could we please update cqlsh's syntax to run in Python 3?
> As a workaround, users can setup pyenv, and cd to a directory with a
> .python-version containing "2.7". But it would be nice if cqlsh supported
> modern Python versions out of the box.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-10190) Python 3 support for cqlsh
[ https://issues.apache.org/jira/browse/CASSANDRA-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16863768#comment-16863768 ] Dinesh Joshi edited comment on CASSANDRA-10190 at 6/14/19 7:19 AM: --- Hi [~ptbannister], thank you for making the changes. The latest set of changes look good. [I ran the dtests|https://circleci.com/workflow-run/9ce3ae71-70d4-4fd7-b590-1449323408ff]. There are some cqlsh related failures in the vnodes case. Could you please take a look? Additionally, as part of this change, it would be desirable to run cqlsh tests with Python 2.7 as well as Python 3. I think it would be trivial to do it if we can override the Python interpreter's path by providing it as a parameter. WDYT? was (Author: djoshi3): Hi [~ptbannister], thank you for making the changes. The latest set of changes look good. I ran the dtests. There are some cqlsh related failures in the vnodes case. Could you please take a look? Additionally, as part of this change, I think it would be desirable to run cqlsh tests with Python 2.7 as well as Python 3. I think it would be trivial to do it if we can override the Python interpreter's path by providing it as a parameter. WDYT? > Python 3 support for cqlsh > -- > > Key: CASSANDRA-10190 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10190 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Tools >Reporter: Andrew Pennebaker >Assignee: Patrick Bannister >Priority: Normal > Labels: cqlsh > Attachments: coverage_notes.txt > > > Users who operate in a Python 3 environment may have trouble launching cqlsh. > Could we please update cqlsh's syntax to run in Python 3? > As a workaround, users can setup pyenv, and cd to a directory with a > .python-version containing "2.7". But it would be nice if cqlsh supported > modern Python versions out of the box. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-10190) Python 3 support for cqlsh
[ https://issues.apache.org/jira/browse/CASSANDRA-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859468#comment-16859468 ] Patrick Bannister edited comment on CASSANDRA-10190 at 6/9/19 2:15 PM: --- [~djoshi3], thanks for the feedback. I've incorporated all of your recommendations on the branch. I meant to completely delete FrozenType after testing with it commented out, but I forgot to follow through. The reason I wanted to remove the FrozenType class from cqlsh.py is because it was commented "Needed until the bundled python driver adds FrozenType.", and I noticed that [the Python driver includes FrozenType since version 2.5.0|https://github.com/datastax/python-driver/blob/master/CHANGELOG.rst#250]. It looks like the bundled driver is at least version 3.7.0 (CASSANDRA-12736), so I think we should be able to remove FrozenType completely. I've made this change on my branch too. was (Author: ptbannister): [~djoshi3], thanks for the feedback. I've incorporated all of your recommendations on the branch. I meant to completely delete FrozenType after testing with it commented out, but I forgot to follow through. The reason I wanted to remove the FrozenType class from cqlsh.py is because it was commented "Needed until the bundled python driver adds FrozenType.", and I noticed that [the Python driver includes FrozenType since version 2.5.0|[https://github.com/datastax/python-driver/blob/master/CHANGELOG.rst#250].] It looks like the bundled driver is at least version 3.7.0 (CASSANDRA-12736), so I think we should be able to remove FrozenType completely. I've made this change on my branch too. > Python 3 support for cqlsh > -- > > Key: CASSANDRA-10190 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10190 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Tools >Reporter: Andrew Pennebaker >Assignee: Patrick Bannister >Priority: Normal > Labels: cqlsh > Attachments: coverage_notes.txt > > > Users who operate in a Python 3 environment may have trouble launching cqlsh. > Could we please update cqlsh's syntax to run in Python 3? > As a workaround, users can setup pyenv, and cd to a directory with a > .python-version containing "2.7". But it would be nice if cqlsh supported > modern Python versions out of the box. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-10190) Python 3 support for cqlsh
[
https://issues.apache.org/jira/browse/CASSANDRA-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856488#comment-16856488
]
Dinesh Joshi edited comment on CASSANDRA-10190 at 6/5/19 8:22 AM:
--
Hi [~ptbannister], I have gone over your patch and here are some minor comments
-
{{cqlsh.py}}
* Why is {{FrozenType}} commented out?
* You've replaced occurrences of {{%r}} with {{"'{}'"}}. However, we should
use "\{!r}" instead which is equivalent to {{%r}}. Please remove the single
quotes surrounding the object names.
* Remove {{six}} import from L42. This is a premature import and breaks Python
2. {{six}} is imported on L150 once we have discovered the Python libraries
path for cqlsh.
* Python version check could be a bit more readable like this
{{sys.version_info.major != 3 and (sys.version_info.major == 2 and
sys.version_info.minor != 7)}} instead of using indexes.
{{copyutil.py}}
* L2514 remove commented out code.
{{cqlsh}}
* Nit: L51: python -> Python
was (Author: djoshi3):
Hi [~ptbannister], I have gone over your patch and here are some minor comments
-
{{cqlsh.py}}
* Why is {{FrozenType}} commented out?
* You've replaced occurrences of {{%r}} with {{"'{}'"}}. However, we should
use \{{"{!r}"}} instead which is equivalent to {{%r}}. Please remove the single
quotes surrounding the object names.
* Remove {{six}} import from L42. This is a premature import and breaks Python
2. {{six}} is imported on L150 once we have discovered the Python libraries
path for cqlsh.
* Python version check could be a bit more readable like this
{{sys.version_info.major != 3 and (sys.version_info.major == 2 and
sys.version_info.minor != 7)}} instead of using indexes.
{{copyutil.py}}
* L2514 remove commented out code.
{{cqlsh}}
* Nit: L51: python -> Python
> Python 3 support for cqlsh
> --
>
> Key: CASSANDRA-10190
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10190
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Tools
>Reporter: Andrew Pennebaker
>Assignee: Patrick Bannister
>Priority: Normal
> Labels: cqlsh
> Attachments: coverage_notes.txt
>
>
> Users who operate in a Python 3 environment may have trouble launching cqlsh.
> Could we please update cqlsh's syntax to run in Python 3?
> As a workaround, users can setup pyenv, and cd to a directory with a
> .python-version containing "2.7". But it would be nice if cqlsh supported
> modern Python versions out of the box.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-10190) Python 3 support for cqlsh
[
https://issues.apache.org/jira/browse/CASSANDRA-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856488#comment-16856488
]
Dinesh Joshi edited comment on CASSANDRA-10190 at 6/5/19 8:22 AM:
--
Hi [~ptbannister], I have gone over your patch and here are some minor comments
-
{{cqlsh.py}}
* Why is {{FrozenType}} commented out?
* You've replaced occurrences of {{%r}} with {{"'{}'"}}. However, we should
use \{{"{!r}"}} instead which is equivalent to {{%r}}. Please remove the single
quotes surrounding the object names.
* Remove {{six}} import from L42. This is a premature import and breaks Python
2. {{six}} is imported on L150 once we have discovered the Python libraries
path for cqlsh.
* Python version check could be a bit more readable like this
{{sys.version_info.major != 3 and (sys.version_info.major == 2 and
sys.version_info.minor != 7)}} instead of using indexes.
{{copyutil.py}}
* L2514 remove commented out code.
{{cqlsh}}
* Nit: L51: python -> Python
was (Author: djoshi3):
Hi [~ptbannister], I have gone over your patch and here are some minor comments
-
{{cqlsh.py}}
* Why is {{FrozenType}} commented out?
* You've replaced occurrences of {{%r}} with \{{"'{}'"}}. However, we should
use \{{"{!r}"}} instead which is equivalent to \{{%r}}. Please remove the
single quotes surrounding the object names.
* Remove {{six}} import from L42. This is a premature import and breaks Python
2. {{six}} is imported on L150 once we have discovered the Python libraries
path for cqlsh.
* Python version check could be a bit more readable like this
{{sys.version_info.major != 3 and (sys.version_info.major == 2 and
sys.version_info.minor != 7)}} instead of using indexes.
{{copyutil.py}}
* L2514 remove commented out code.
{{cqlsh}}
* Nit: L51: python -> Python
> Python 3 support for cqlsh
> --
>
> Key: CASSANDRA-10190
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10190
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Tools
>Reporter: Andrew Pennebaker
>Assignee: Patrick Bannister
>Priority: Normal
> Labels: cqlsh
> Attachments: coverage_notes.txt
>
>
> Users who operate in a Python 3 environment may have trouble launching cqlsh.
> Could we please update cqlsh's syntax to run in Python 3?
> As a workaround, users can setup pyenv, and cd to a directory with a
> .python-version containing "2.7". But it would be nice if cqlsh supported
> modern Python versions out of the box.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-10190) Python 3 support for cqlsh
[
https://issues.apache.org/jira/browse/CASSANDRA-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856488#comment-16856488
]
Dinesh Joshi edited comment on CASSANDRA-10190 at 6/5/19 8:21 AM:
--
Hi [~ptbannister], I have gone over your patch and here are some minor comments
-
{{cqlsh.py}}
* Why is {{FrozenType}} commented out?
* You've replaced occurrences of {{%r}} with \{{"'{}'"}}. However, we should
use \{{"{!r}"}} instead which is equivalent to \{{%r}}. Please remove the
single quotes surrounding the object names.
* Remove {{six}} import from L42. This is a premature import and breaks Python
2. {{six}} is imported on L150 once we have discovered the Python libraries
path for cqlsh.
* Python version check could be a bit more readable like this
{{sys.version_info.major != 3 and (sys.version_info.major == 2 and
sys.version_info.minor != 7)}} instead of using indexes.
{{copyutil.py}}
* L2514 remove commented out code.
{{cqlsh}}
* Nit: L51: python -> Python
was (Author: djoshi3):
Hi [~ptbannister], I have gone over your patch and here are some minor comments
-
{{cqlsh.py}}
* Why is {{FrozenType}} commented out?
* You've replaced occurrences of %r with "'{}'". However, we should use "{!r}"
instead which is equivalent to %r. Please remove the single quotes surrounding
the object names.
* Remove {{six}} import from L42. This is a premature import and breaks Python
2. {{six}} is imported on L150 once we have discovered the Python libraries
path for cqlsh.
* Python version check could be a bit more readable like this
{{sys.version_info.major != 3 and (sys.version_info.major == 2 and
sys.version_info.minor != 7)}} instead of using indexes.
{{copyutil.py}}
* L2514 remove commented out code.
{{cqlsh}}
* Nit: L51: python -> Python
> Python 3 support for cqlsh
> --
>
> Key: CASSANDRA-10190
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10190
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Tools
>Reporter: Andrew Pennebaker
>Assignee: Patrick Bannister
>Priority: Normal
> Labels: cqlsh
> Attachments: coverage_notes.txt
>
>
> Users who operate in a Python 3 environment may have trouble launching cqlsh.
> Could we please update cqlsh's syntax to run in Python 3?
> As a workaround, users can setup pyenv, and cd to a directory with a
> .python-version containing "2.7". But it would be nice if cqlsh supported
> modern Python versions out of the box.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-10190) Python 3 support for cqlsh
[ https://issues.apache.org/jira/browse/CASSANDRA-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16805523#comment-16805523 ] Dinesh Joshi edited comment on CASSANDRA-10190 at 3/30/19 6:19 PM: --- Hi [~riley.mcdowell], Patrick & I had a chat and we will be first bringing the Python 3 implementation in line with the Python 2.7 which means if there are tests that are currently broken, we won't fix them as long as the failures are the same. Once we have a better insight into what the failures are about, we will go in and fix whatever is possible without touching the driver. Finally, extracting the checked in driver is something we'll look into. But that is a longpole and strictly not needed for Python 3 compatibility. was (Author: djoshi3): Hi [~riley.mcdowell], Patrick & I had a chat and we will be first bringing the Python 3 implementation in line with the Python 2.7 which means if there are tests that are currently broken, we won't fix them as long as the failures are the same. Once we have a better insight into what the failures are about, we will go in and fix whatever is possible without touching the driver. Finally, extracting the checked in driver is something we'll look into. But that is a long poll and strictly not needed for Python 3 compatibility. > Python 3 support for cqlsh > -- > > Key: CASSANDRA-10190 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10190 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Tools >Reporter: Andrew Pennebaker >Assignee: Patrick Bannister >Priority: Normal > Labels: cqlsh > Attachments: coverage_notes.txt > > > Users who operate in a Python 3 environment may have trouble launching cqlsh. > Could we please update cqlsh's syntax to run in Python 3? > As a workaround, users can setup pyenv, and cd to a directory with a > .python-version containing "2.7". But it would be nice if cqlsh supported > modern Python versions out of the box. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-10190) Python 3 support for cqlsh
[ https://issues.apache.org/jira/browse/CASSANDRA-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16805523#comment-16805523 ] Dinesh Joshi edited comment on CASSANDRA-10190 at 3/29/19 10:42 PM: Hi [~riley.mcdowell], Patrick & I had a chat and we will be first bringing the Python 3 implementation in line with the Python 2.7 which means if there are tests that are currently broken, we won't fix them as long as the failures are the same. Once we have a better insight into what the failures are about, we will go in and fix whatever is possible without touching the driver. Finally, extracting the checked in driver is something we'll look into. But that is a long poll and strictly not needed for Python 3 compatibility. was (Author: djoshi3): Hi [~riley.mcdowell], Patrick & I had a chat and we will be first bringing the Python 3 implementation in line with the Python 2.7 which means if there are tests that are currently broken, we won't fix them as long as the failures are the same. Once we have a better insight into what the failures are about, we will go in and fix whatever is possible without touching the driver. Finally, extracting the checked in driver is something we'll look into this. > Python 3 support for cqlsh > -- > > Key: CASSANDRA-10190 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10190 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Tools >Reporter: Andrew Pennebaker >Assignee: Patrick Bannister >Priority: Normal > Labels: cqlsh > Attachments: coverage_notes.txt > > > Users who operate in a Python 3 environment may have trouble launching cqlsh. > Could we please update cqlsh's syntax to run in Python 3? > As a workaround, users can setup pyenv, and cd to a directory with a > .python-version containing "2.7". But it would be nice if cqlsh supported > modern Python versions out of the box. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
