[jira] [Comment Edited] (CASSANDRA-15733) jvm dtest builder should be provided to the factory and expose state
[ https://issues.apache.org/jira/browse/CASSANDRA-15733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17097102#comment-17097102 ] David Capwell edited comment on CASSANDRA-15733 at 5/5/20, 5:05 PM: | Branch | Build | Results | | trunk | [Circle CI|https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=feature%2FCASSANDRA-15733] | GREEN | | 3.11 | [Circle CI|https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=feature%2FCASSANDRA-15733-3.11] | GREEN | | 3.0 | [Circle CI|https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=feature%2FCASSANDRA-15733-3.0] | GREEN | | 2.2 | [Circle CI|https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=feature%2FCASSANDRA-15733-2.2] | YELLOW [1] | [1] - org.apache.cassandra.cql3.validation.entities.TypeTest#testDateCompatibility failed in 2.2, this was passing before so assume its a flaky test. The code is jvm dtest so ignoring this error. was (Author: dcapwell): | Branch | Build | Results | | trunk | [Circle CI|https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=feature%2FCASSANDRA-15733] | GREEN | | 3.11 | [Circle CI|https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=feature%2FCASSANDRA-15733-3.11] | GREEN | | 3.0 | [Circle CI|https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=feature%2FCASSANDRA-15733-3.0] | GREEN | | 2.2 | [Circle CI|https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=feature%2FCASSANDRA-15733-2.2] | UNKNOWN | > jvm dtest builder should be provided to the factory and expose state > > > Key: CASSANDRA-15733 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15733 > Project: Cassandra > Issue Type: Improvement > Components: Test/dtest >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Labels: pull-request-available > Time Spent: 3h > Remaining Estimate: 0h > > Currently the builder is rather heavy and creates configs plus call the > factory with specific fields only, this isn’t that flexible and makes it > harder to have custom cluster definitions which require additional fields to > be defined. To solve this we should make the builder be sent to the factory > and expose the state so the factory can get all the fields it needs, the > factory should also be in charge of creating the configs -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-15733) jvm dtest builder should be provided to the factory and expose state
[ https://issues.apache.org/jira/browse/CASSANDRA-15733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17097102#comment-17097102 ] David Capwell edited comment on CASSANDRA-15733 at 5/5/20, 5:03 PM: | Branch | Build | Results | | trunk | [Circle CI|https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=feature%2FCASSANDRA-15733] | GREEN | | 3.11 | [Circle CI|https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=feature%2FCASSANDRA-15733-3.11] | GREEN | | 3.0 | [Circle CI|https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=feature%2FCASSANDRA-15733-3.0] | GREEN | | 2.2 | [Circle CI|https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=feature%2FCASSANDRA-15733-2.2] | UNKNOWN | was (Author: dcapwell): | Branch | Build | Results | | trunk | [Circle CI|https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=feature%2FCASSANDRA-15733] | UNKNOWN | | 3.11 | [Circle CI|https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=feature%2FCASSANDRA-15733-3.11] | UNKNOWN | | 3.0 | [Circle CI|https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=feature%2FCASSANDRA-15733-3.0] | UNKNOWN | | 2.2 | [Circle CI|https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=feature%2FCASSANDRA-15733-2.2] | UNKNOWN | > jvm dtest builder should be provided to the factory and expose state > > > Key: CASSANDRA-15733 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15733 > Project: Cassandra > Issue Type: Improvement > Components: Test/dtest >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Labels: pull-request-available > Time Spent: 3h > Remaining Estimate: 0h > > Currently the builder is rather heavy and creates configs plus call the > factory with specific fields only, this isn’t that flexible and makes it > harder to have custom cluster definitions which require additional fields to > be defined. To solve this we should make the builder be sent to the factory > and expose the state so the factory can get all the fields it needs, the > factory should also be in charge of creating the configs -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-15733) jvm dtest builder should be provided to the factory and expose state
[ https://issues.apache.org/jira/browse/CASSANDRA-15733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17097102#comment-17097102 ] David Capwell edited comment on CASSANDRA-15733 at 5/1/20, 1:27 AM: | Branch | Build | Results | | trunk | [Circle CI|https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=feature%2FCASSANDRA-15733] | UNKNOWN | | 3.11 | [Circle CI|https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=feature%2FCASSANDRA-15733-3.11] | UNKNOWN | | 3.0 | [Circle CI|https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=feature%2FCASSANDRA-15733-3.0] | UNKNOWN | | 2.2 | [Circle CI|https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=feature%2FCASSANDRA-15733-2.2] | UNKNOWN | was (Author: dcapwell): | Branch | Build | Results | | trunk | [Circle CI|https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=feature%2FCASSANDRA-15733] | UNKNOWN | | 3.11 | [Circle CI|https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=feature%2FCASSANDRA-15733-3.11] | UNKNOWN | | 3.0 | [Circle CI|https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=feature%2FCASSANDRA-15733-3.0] | UNKNOWN | > jvm dtest builder should be provided to the factory and expose state > > > Key: CASSANDRA-15733 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15733 > Project: Cassandra > Issue Type: Improvement > Components: Test/dtest >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Labels: pull-request-available > Time Spent: 3h > Remaining Estimate: 0h > > Currently the builder is rather heavy and creates configs plus call the > factory with specific fields only, this isn’t that flexible and makes it > harder to have custom cluster definitions which require additional fields to > be defined. To solve this we should make the builder be sent to the factory > and expose the state so the factory can get all the fields it needs, the > factory should also be in charge of creating the configs -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-15733) jvm dtest builder should be provided to the factory and expose state
[ https://issues.apache.org/jira/browse/CASSANDRA-15733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17097102#comment-17097102 ] David Capwell edited comment on CASSANDRA-15733 at 5/1/20, 1:25 AM: | Branch | Build | Results | | trunk | [Circle CI|https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=feature%2FCASSANDRA-15733] | UNKNOWN | | 3.11 | [Circle CI|https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=feature%2FCASSANDRA-15733-3.11] | UNKNOWN | | 3.0 | [Circle CI|https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=feature%2FCASSANDRA-15733-3.0] | UNKNOWN | was (Author: dcapwell): | Branch | Build | Results | | trunk | [Circle CI|https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=feature%2FCASSANDRA-15733] | UNKNOWN | | 3.11 | [Circle CI|https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=feature%2FCASSANDRA-15733-3.11] | UNKNOWN | > jvm dtest builder should be provided to the factory and expose state > > > Key: CASSANDRA-15733 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15733 > Project: Cassandra > Issue Type: Improvement > Components: Test/dtest >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Labels: pull-request-available > Time Spent: 3h > Remaining Estimate: 0h > > Currently the builder is rather heavy and creates configs plus call the > factory with specific fields only, this isn’t that flexible and makes it > harder to have custom cluster definitions which require additional fields to > be defined. To solve this we should make the builder be sent to the factory > and expose the state so the factory can get all the fields it needs, the > factory should also be in charge of creating the configs -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-15733) jvm dtest builder should be provided to the factory and expose state
[ https://issues.apache.org/jira/browse/CASSANDRA-15733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17097102#comment-17097102 ] David Capwell edited comment on CASSANDRA-15733 at 5/1/20, 1:23 AM: | Branch | Build | Results | | trunk | [Circle CI|https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=feature%2FCASSANDRA-15733] | UNKNOWN | | 3.11 | [Circle CI|https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=feature%2FCASSANDRA-15733-3.11] | UNKNOWN | was (Author: dcapwell): | Branch | Build | Results | | trunk | [Circle CI|https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=feature%2FCASSANDRA-15733] | UNKNOWN | > jvm dtest builder should be provided to the factory and expose state > > > Key: CASSANDRA-15733 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15733 > Project: Cassandra > Issue Type: Improvement > Components: Test/dtest >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Labels: pull-request-available > Time Spent: 3h > Remaining Estimate: 0h > > Currently the builder is rather heavy and creates configs plus call the > factory with specific fields only, this isn’t that flexible and makes it > harder to have custom cluster definitions which require additional fields to > be defined. To solve this we should make the builder be sent to the factory > and expose the state so the factory can get all the fields it needs, the > factory should also be in charge of creating the configs -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-15733) jvm dtest builder should be provided to the factory and expose state
[ https://issues.apache.org/jira/browse/CASSANDRA-15733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092360#comment-17092360 ] David Capwell edited comment on CASSANDRA-15733 at 4/25/20, 9:26 PM: - Ran the trunk build [here|https://app.circleci.com/pipelines/github/dcapwell/cassandra/215/workflows/2751a22a-7dc9-4776-80b2-185304856af2] was (Author: dcapwell): Ran the trunk build [here|https://app.circleci.com/pipelines/github/dcapwell/cassandra/214/workflows/ebbe807b-4a36-4a37-b6ae-17b25f7dd25c] > jvm dtest builder should be provided to the factory and expose state > > > Key: CASSANDRA-15733 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15733 > Project: Cassandra > Issue Type: Improvement > Components: Test/dtest >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Labels: pull-request-available > Time Spent: 3h > Remaining Estimate: 0h > > Currently the builder is rather heavy and creates configs plus call the > factory with specific fields only, this isn’t that flexible and makes it > harder to have custom cluster definitions which require additional fields to > be defined. To solve this we should make the builder be sent to the factory > and expose the state so the factory can get all the fields it needs, the > factory should also be in charge of creating the configs -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
