[jira] [Comment Edited] (CASSANDRA-19393) nodetool: group CMS-related commands into one command
[ https://issues.apache.org/jira/browse/CASSANDRA-19393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827262#comment-17827262 ] Stefan Miklosovic edited comment on CASSANDRA-19393 at 3/14/24 9:47 PM: These two tests are the only ones dealing with cms: storage_engine_upgrade_test upgrade_through_versions_test repeated dtest for the first one is here https://app.circleci.com/pipelines/github/instaclustr/cassandra/4009/workflows/2b9fd421-82bc-47a8-9d82-7c76c1a22bc8/jobs/204887 I also run the the job for the second one but after 5h it timeouted, probably circle thing / flakiness. I do not have any reason to think that my change introduced the timeouts. It is literally just "initializecms -> cms initialize" dtest branch tested: https://github.com/smiklosovic/cassandra-dtest/commit/505e78ce3d5f1bcc596b29ffdb8a4e10de2b3a33 I am going to ship this. was (Author: smiklosovic): These two tests are the only ones dealing with cms: storage_engine_upgrade_test upgrade_through_versions_test repeated dtest for the first one is here https://app.circleci.com/pipelines/github/instaclustr/cassandra/4009/workflows/2b9fd421-82bc-47a8-9d82-7c76c1a22bc8/jobs/204887 I also run the the job for the second one but after 5h it timeouted, probably circle thing / flakiness. I do not have any reason to think that my changed introduced the timeouts. It is literally just "initializecms -> cms initialize" dtest branch tested: https://github.com/smiklosovic/cassandra-dtest/commit/505e78ce3d5f1bcc596b29ffdb8a4e10de2b3a33 I am going to ship this. > nodetool: group CMS-related commands into one command > - > > Key: CASSANDRA-19393 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19393 > Project: Cassandra > Issue Type: Improvement > Components: Tool/nodetool, Transactional Cluster Metadata >Reporter: n.v.harikrishna >Assignee: n.v.harikrishna >Priority: Normal > Fix For: 5.x > > Time Spent: 1.5h > Remaining Estimate: 0h > > The purpose of this ticket is to group all CMS-related commands under one > "nodetool cms" command where existing command would be subcommands of it. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-19393) nodetool: group CMS-related commands into one command
[ https://issues.apache.org/jira/browse/CASSANDRA-19393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17825985#comment-17825985 ] Stefan Miklosovic edited comment on CASSANDRA-19393 at 3/13/24 9:32 AM: good catch! yeah, I haven't run upgrades ... I dont have CI plan for that. I need to check if we can run this thing in Jenkins ... [~n.v.harikrishna] please put together dtest PR and let us know was (Author: smiklosovic): good catch! yeah, I haven't run upgrades ... I dont have CI plan for that. I need to check if we can run this thing in Jenkins ... > nodetool: group CMS-related commands into one command > - > > Key: CASSANDRA-19393 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19393 > Project: Cassandra > Issue Type: Improvement > Components: Tool/nodetool, Transactional Cluster Metadata >Reporter: n.v.harikrishna >Assignee: n.v.harikrishna >Priority: Normal > Fix For: 5.x > > Time Spent: 1.5h > Remaining Estimate: 0h > > The purpose of this ticket is to group all CMS-related commands under one > "nodetool cms" command where existing command would be subcommands of it. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-19393) nodetool: group CMS-related commands into one command
[ https://issues.apache.org/jira/browse/CASSANDRA-19393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818061#comment-17818061 ] Stefan Miklosovic edited comment on CASSANDRA-19393 at 2/16/24 5:48 PM: [~n.v.harikrishna] could you please incorporate my suggestion https://github.com/smiklosovic/cassandra/commit/401be662d000598125bc44fc5c24e0d2095407ee and go through the documentation and replace all occurrences of the individual commands by their new counter parts? I am talking mostly about TransactionalClusterMetadata.md in org.apache.cassandra.tcm package. was (Author: smiklosovic): [~n.v.harikrishna] could you please incorporate my suggestion https://github.com/smiklosovic/cassandra/commit/401be662d000598125bc44fc5c24e0d2095407ee and go through the documentation and replace all occurrences of the individual commands by their new counter parts? > nodetool: group CMS-related commands into one command > - > > Key: CASSANDRA-19393 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19393 > Project: Cassandra > Issue Type: Improvement > Components: Tool/nodetool, Transactional Cluster Metadata >Reporter: n.v.harikrishna >Assignee: n.v.harikrishna >Priority: Normal > Fix For: 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > The purpose of this ticket is to group all CMS-related commands under one > "nodetool cms" command where existing command would be subcommands of it. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-19393) nodetool: group CMS-related commands into one command
[ https://issues.apache.org/jira/browse/CASSANDRA-19393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817961#comment-17817961 ] Stefan Miklosovic edited comment on CASSANDRA-19393 at 2/16/24 1:35 PM: I propose these minor fixes (1) otherwise all good. Can be done on commit. I need another committer. cc [~marcuse] [~brandon.williams] (1) https://github.com/smiklosovic/cassandra/commit/401be662d000598125bc44fc5c24e0d2095407ee was (Author: smiklosovic): I propose these minor fixes (1) otherwise all good. Can be done on commit. I need another committer. (1) https://github.com/smiklosovic/cassandra/commit/401be662d000598125bc44fc5c24e0d2095407ee > nodetool: group CMS-related commands into one command > - > > Key: CASSANDRA-19393 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19393 > Project: Cassandra > Issue Type: Improvement > Components: Tool/nodetool, Transactional Cluster Metadata >Reporter: n.v.harikrishna >Assignee: n.v.harikrishna >Priority: Normal > Fix For: 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > The purpose of this ticket is to group all CMS-related commands under one > "nodetool cms" command where existing command would be subcommands of it. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
