[
https://issues.apache.org/jira/browse/CASSANDRA-7523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14234410#comment-14234410
]
Joshua McKenzie edited comment on CASSANDRA-7523 at 12/4/14 5:57 PM:
-
Nits fixed, along with a tiny bit of polish:
* reverted TypeSerializer change
* fixed seconds not bounds-checking w/out period
* Added unit tests to check for that
* changed joda license file from CRLF line-endings to LF
* rebased both java and python branches
* fixed unit test for simple date type in python (hadn't updated for new 2^31
== epoch centered byte-order-comparable)
My original plan was to get our house in order on this side, then open a
ticket/PR for the python driver changes once we've stabilized. We can then
open another ticket for updating the python driver that's packaged with C*,
since we can commit the java changes w/out necessarily having driver support.
Alternatively we can just sit on this ticket until the python changes get
merged in and then push this through; the rebase was clean on the java code.
edit: [Java
branch|https://github.com/josh-mckenzie/cassandra/compare/7523_squashed] and
[python
branch|https://github.com/josh-mckenzie/python-driver/compare/7523_squashed]
for convenience.
was (Author: joshuamckenzie):
Nits fixed, along with a tiny bit of polish:
* reverted TypeSerializer change
* fixed seconds not bounds-checking w/out period
* Added unit tests to check for that
* changed joda license file from CRLF line-endings to LF
* rebased both java and python branches
* fixed unit test for simple date type in python (hadn't updated for new 2^31
== epoch centered byte-order-comparable)
My original plan was to get our house in order on this side, then open a
ticket/PR for the python driver changes once we've stabilized. We can then
open another ticket for updating the python driver that's packaged with C*,
since we can commit the java changes w/out necessarily having driver support.
Alternatively we can just sit on this ticket until the python changes get
merged in and then push this through; the rebase was clean on the java code.
add date and time types
---
Key: CASSANDRA-7523
URL: https://issues.apache.org/jira/browse/CASSANDRA-7523
Project: Cassandra
Issue Type: New Feature
Components: API
Reporter: Jonathan Ellis
Assignee: Joshua McKenzie
Priority: Minor
Labels: docs
Fix For: 2.1.3
http://www.postgresql.org/docs/9.1/static/datatype-datetime.html
(we already have timestamp; interval is out of scope for now, and see
CASSANDRA-6350 for discussion on timestamp-with-time-zone. but date/time
should be pretty easy to add.)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
