[jira] [Commented] (CASSANDRA-10012) Deadlock when session streaming is retried after exception
[ https://issues.apache.org/jira/browse/CASSANDRA-10012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15437104#comment-15437104 ] Yuki Morishita commented on CASSANDRA-10012: FTR the patch here is later reverted by CASSANDRA-10961. > Deadlock when session streaming is retried after exception > -- > > Key: CASSANDRA-10012 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10012 > Project: Cassandra > Issue Type: Bug > Components: Streaming and Messaging >Reporter: Chris Moos >Assignee: Yuki Morishita > Fix For: 2.1.12, 2.2.4, 3.0.1, 3.1 > > Attachments: CASSANDRA-10012.patch > > > This patch ensures that the CompressedInputStream thread is cleaned up > properly (for example, if an Exception occurs and a session stream is > retried). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10012) Deadlock when session streaming is retried after exception
[ https://issues.apache.org/jira/browse/CASSANDRA-10012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022281#comment-15022281 ] Paulo Motta commented on CASSANDRA-10012: - Sorry, I missed this ticket for some reason. Tests look good. Marking as "Ready to commit". Thanks! > Deadlock when session streaming is retried after exception > -- > > Key: CASSANDRA-10012 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10012 > Project: Cassandra > Issue Type: Bug >Reporter: Chris Moos >Assignee: Yuki Morishita > Fix For: 2.1.x, 2.2.x > > Attachments: CASSANDRA-10012.patch > > > This patch ensures that the CompressedInputStream thread is cleaned up > properly (for example, if an Exception occurs and a session stream is > retried). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10012) Deadlock when session streaming is retried after exception
[ https://issues.apache.org/jira/browse/CASSANDRA-10012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022271#comment-15022271 ] Yuki Morishita commented on CASSANDRA-10012: Technically, yes. I have 2.1 branch as well. ||branch||testall||dtest|| |[10012-2.1|https://github.com/yukim/cassandra/tree/10012-2.1]|[testall|http://cassci.datastax.com/view/Dev/view/yukim/job/yukim-10012-2.1-testall/lastCompletedBuild/testReport/]|[dtest|http://cassci.datastax.com/view/Dev/view/yukim/job/yukim-10012-2.1-dtest/lastCompletedBuild/testReport/]| > Deadlock when session streaming is retried after exception > -- > > Key: CASSANDRA-10012 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10012 > Project: Cassandra > Issue Type: Bug >Reporter: Chris Moos >Assignee: Chris Moos > Fix For: 2.2.x > > Attachments: CASSANDRA-10012.patch > > > This patch ensures that the CompressedInputStream thread is cleaned up > properly (for example, if an Exception occurs and a session stream is > retried). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10012) Deadlock when session streaming is retried after exception
[ https://issues.apache.org/jira/browse/CASSANDRA-10012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022241#comment-15022241 ] Aleksey Yeschenko commented on CASSANDRA-10012: --- Does the issue affect 2.1 as well? > Deadlock when session streaming is retried after exception > -- > > Key: CASSANDRA-10012 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10012 > Project: Cassandra > Issue Type: Bug >Reporter: Chris Moos >Assignee: Chris Moos > Fix For: 2.2.x > > Attachments: CASSANDRA-10012.patch > > > This patch ensures that the CompressedInputStream thread is cleaned up > properly (for example, if an Exception occurs and a session stream is > retried). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10012) Deadlock when session streaming is retried after exception
[ https://issues.apache.org/jira/browse/CASSANDRA-10012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15004095#comment-15004095 ] Yuki Morishita commented on CASSANDRA-10012: [~pauloricardomg] updated branches. ||branch||testall||dtest|| |[10012-2.2|https://github.com/yukim/cassandra/tree/10012-2.2]|[testall|http://cassci.datastax.com/view/Dev/view/yukim/job/yukim-10012-2.2-testall/lastCompletedBuild/testReport/]|[dtest|http://cassci.datastax.com/view/Dev/view/yukim/job/yukim-10012-2.2-dtest/lastCompletedBuild/testReport/]| |[10012-3.0|https://github.com/yukim/cassandra/tree/10012-3.0]|[testall|http://cassci.datastax.com/view/Dev/view/yukim/job/yukim-10012-3.0-testall/lastCompletedBuild/testReport/]|[dtest|http://cassci.datastax.com/view/Dev/view/yukim/job/yukim-10012-3.0-dtest/lastCompletedBuild/testReport/]| CASSANDRA-10448 can be caused by this, but I'm not sure. > Deadlock when session streaming is retried after exception > -- > > Key: CASSANDRA-10012 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10012 > Project: Cassandra > Issue Type: Bug >Reporter: Chris Moos >Assignee: Chris Moos > Fix For: 2.2.x > > Attachments: CASSANDRA-10012.patch > > > This patch ensures that the CompressedInputStream thread is cleaned up > properly (for example, if an Exception occurs and a session stream is > retried). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10012) Deadlock when session streaming is retried after exception
[ https://issues.apache.org/jira/browse/CASSANDRA-10012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14990250#comment-14990250 ] Paulo Motta commented on CASSANDRA-10012: - Nice catch! Code and tests look good. It doesn't merge to 3.0 though, could you rebase and submit tests for 3.0? Could this be a duplicate of CASSANDRA-10448 ? The same {{Unknown type 0}} exception is thrown. Can we close preceding ticket CASSANDRA-10005? > Deadlock when session streaming is retried after exception > -- > > Key: CASSANDRA-10012 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10012 > Project: Cassandra > Issue Type: Bug >Reporter: Chris Moos >Assignee: Chris Moos > Fix For: 2.2.x > > Attachments: CASSANDRA-10012.patch > > > This patch ensures that the CompressedInputStream thread is cleaned up > properly (for example, if an Exception occurs and a session stream is > retried). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10012) Deadlock when session streaming is retried after exception
[ https://issues.apache.org/jira/browse/CASSANDRA-10012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14988043#comment-14988043 ] Yuki Morishita commented on CASSANDRA-10012: I think the test is running ok without regression. [~pauloricardomg] Can you take a look at my patch above also? If it seems good then I'll commit. > Deadlock when session streaming is retried after exception > -- > > Key: CASSANDRA-10012 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10012 > Project: Cassandra > Issue Type: Bug >Reporter: Chris Moos >Assignee: Chris Moos > Fix For: 2.2.x > > Attachments: CASSANDRA-10012.patch > > > This patch ensures that the CompressedInputStream thread is cleaned up > properly (for example, if an Exception occurs and a session stream is > retried). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10012) Deadlock when session streaming is retried after exception
[ https://issues.apache.org/jira/browse/CASSANDRA-10012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14697657#comment-14697657 ] Yuki Morishita commented on CASSANDRA-10012: Thanks for the patch! I fixed some coding style and added test: https://github.com/yukim/cassandra/tree/10012 Also, CompressedInputStream may block when exception is thrown from reading source stream. I added fix to that in above. tests are running here: http://cassci.datastax.com/view/Dev/view/yukim/job/yukim-10012-testall/ and http://cassci.datastax.com/view/Dev/view/yukim/job/yukim-10012-dtest/ Deadlock when session streaming is retried after exception -- Key: CASSANDRA-10012 URL: https://issues.apache.org/jira/browse/CASSANDRA-10012 Project: Cassandra Issue Type: Bug Components: Core Reporter: Chris Moos Fix For: 2.2.x Attachments: CASSANDRA-10012.patch This patch ensures that the CompressedInputStream thread is cleaned up properly (for example, if an Exception occurs and a session stream is retried). -- This message was sent by Atlassian JIRA (v6.3.4#6332)