[jira] [Commented] (CASSANDRA-10211) SliceQueryFilter warnings should print the partition key
[ https://issues.apache.org/jira/browse/CASSANDRA-10211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15314824#comment-15314824 ] sankalp kohli commented on CASSANDRA-10211: --- This is already there in 2.2 and not required in 3.0 Closing as not to be fixed. > SliceQueryFilter warnings should print the partition key > > > Key: CASSANDRA-10211 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10211 > Project: Cassandra > Issue Type: Improvement >Reporter: Soumava Ghosh >Assignee: Soumava Ghosh >Priority: Minor > Fix For: 2.1.x > > Attachments: 10211-2.1.txt > > > Currently the SliceQueryFilter does not log the partition key while logging > the warning/error when the number of tombstones exceed the limits set by the > tombstone_warn_threshold and the tombstone_failure_threshold. Logging the > partition key would be really helpful for debugging. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10211) SliceQueryFilter warnings should print the partition key
[ https://issues.apache.org/jira/browse/CASSANDRA-10211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15112797#comment-15112797 ] Soumava Ghosh commented on CASSANDRA-10211: --- I'm working on a patch for the other branches. > SliceQueryFilter warnings should print the partition key > > > Key: CASSANDRA-10211 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10211 > Project: Cassandra > Issue Type: Improvement >Reporter: Soumava Ghosh >Assignee: Soumava Ghosh >Priority: Minor > Fix For: 2.1.x > > Attachments: 10211-2.1.txt > > > Currently the SliceQueryFilter does not log the partition key while logging > the warning/error when the number of tombstones exceed the limits set by the > tombstone_warn_threshold and the tombstone_failure_threshold. Logging the > partition key would be really helpful for debugging. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10211) SliceQueryFilter warnings should print the partition key
[ https://issues.apache.org/jira/browse/CASSANDRA-10211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15112544#comment-15112544 ] Sylvain Lebresne commented on CASSANDRA-10211: -- I'm cancelling the "ready to commit" as there only is the 2.1 patch, but this won't go in 2.1 since it's not a critical bug fix and the patch doesn't apply to 2.2 and will be somewhat different for 3.0+. > SliceQueryFilter warnings should print the partition key > > > Key: CASSANDRA-10211 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10211 > Project: Cassandra > Issue Type: Improvement >Reporter: Soumava Ghosh >Assignee: Soumava Ghosh >Priority: Minor > Fix For: 2.1.x > > Attachments: 10211-2.1.txt > > > Currently the SliceQueryFilter does not log the partition key while logging > the warning/error when the number of tombstones exceed the limits set by the > tombstone_warn_threshold and the tombstone_failure_threshold. Logging the > partition key would be really helpful for debugging. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10211) SliceQueryFilter warnings should print the partition key
[ https://issues.apache.org/jira/browse/CASSANDRA-10211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15109549#comment-15109549 ] sankalp kohli commented on CASSANDRA-10211: --- [~soumava] Please provide patches for later branches if this patch does not apply to them. > SliceQueryFilter warnings should print the partition key > > > Key: CASSANDRA-10211 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10211 > Project: Cassandra > Issue Type: Improvement >Reporter: Soumava Ghosh >Assignee: Soumava Ghosh >Priority: Minor > Fix For: 2.1.x > > Attachments: 10211-2.1.txt > > > Currently the SliceQueryFilter does not log the partition key while logging > the warning/error when the number of tombstones exceed the limits set by the > tombstone_warn_threshold and the tombstone_failure_threshold. Logging the > partition key would be really helpful for debugging. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10211) SliceQueryFilter warnings should print the partition key
[ https://issues.apache.org/jira/browse/CASSANDRA-10211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15099112#comment-15099112 ] sankalp kohli commented on CASSANDRA-10211: --- I have already reviewed it internally so +1 > SliceQueryFilter warnings should print the partition key > > > Key: CASSANDRA-10211 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10211 > Project: Cassandra > Issue Type: Improvement >Reporter: Soumava Ghosh >Assignee: Soumava Ghosh >Priority: Minor > Fix For: 2.1.x > > Attachments: 10211-2.1.txt > > > Currently the SliceQueryFilter does not log the partition key while logging > the warning/error when the number of tombstones exceed the limits set by the > tombstone_warn_threshold and the tombstone_failure_threshold. Logging the > partition key would be really helpful for debugging. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10211) SliceQueryFilter warnings should print the partition key
[ https://issues.apache.org/jira/browse/CASSANDRA-10211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15098406#comment-15098406 ] Aleksey Yeschenko commented on CASSANDRA-10211: --- [~kohlisankalp] Any chance you can review? Thanks. > SliceQueryFilter warnings should print the partition key > > > Key: CASSANDRA-10211 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10211 > Project: Cassandra > Issue Type: Improvement >Reporter: Soumava Ghosh >Assignee: Soumava Ghosh >Priority: Minor > Fix For: 2.1.x > > Attachments: 10211-2.1.txt > > > Currently the SliceQueryFilter does not log the partition key while logging > the warning/error when the number of tombstones exceed the limits set by the > tombstone_warn_threshold and the tombstone_failure_threshold. Logging the > partition key would be really helpful for debugging. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10211) SliceQueryFilter warnings should print the partition key
[ https://issues.apache.org/jira/browse/CASSANDRA-10211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15000152#comment-15000152 ] Soumava Ghosh commented on CASSANDRA-10211: --- Looks like the warning path was fixed as a part of CASSANDRA-8561. The patch attached here is for the tombstone failure path. Also adding a null check before logging the Decorated key, which can be null as in RowDataResolver.resolveSuperset(). > SliceQueryFilter warnings should print the partition key > > > Key: CASSANDRA-10211 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10211 > Project: Cassandra > Issue Type: Improvement >Reporter: Soumava Ghosh >Assignee: Soumava Ghosh >Priority: Minor > Fix For: 2.1.x > > Attachments: 10211-2.1.txt > > > Currently the SliceQueryFilter does not log the partition key while logging > the warning/error when the number of tombstones exceed the limits set by the > tombstone_warn_threshold and the tombstone_failure_threshold. Logging the > partition key would be really helpful for debugging. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
