[jira] [Commented] (CASSANDRA-10512) We do not save an upsampled index summaries
[ https://issues.apache.org/jira/browse/CASSANDRA-10512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15143534#comment-15143534 ] Tyler Hobbs commented on CASSANDRA-10512: - Sorry for neglecting this for a while. I've rebased 2.2, 3.0, and trunk branches and started new test runs here: ||branch||testall||dtest|| |[CASSANDRA-10512-2.2|https://github.com/thobbs/cassandra/tree/CASSANDRA-10512-2.2]|[testall|http://cassci.datastax.com/view/Dev/view/thobbs/job/thobbs-CASSANDRA-10512-2.2-testall]|[dtest|http://cassci.datastax.com/view/Dev/view/thobbs/job/thobbs-CASSANDRA-10512-2.2-dtest]| |[CASSANDRA-10512-3.0|https://github.com/thobbs/cassandra/tree/CASSANDRA-10512-3.0]|[testall|http://cassci.datastax.com/view/Dev/view/thobbs/job/thobbs-CASSANDRA-10512-3.0-testall]|[dtest|http://cassci.datastax.com/view/Dev/view/thobbs/job/thobbs-CASSANDRA-10512-3.0-dtest]| |[CASSANDRA-10512-trunk|https://github.com/thobbs/cassandra/tree/CASSANDRA-10512-trunk]|[testall|http://cassci.datastax.com/view/Dev/view/thobbs/job/thobbs-CASSANDRA-10512-trunk-testall]|[dtest|http://cassci.datastax.com/view/Dev/view/thobbs/job/thobbs-CASSANDRA-10512-trunk-dtest]| > We do not save an upsampled index summaries > --- > > Key: CASSANDRA-10512 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10512 > Project: Cassandra > Issue Type: Bug > Components: Local Write-Read Paths >Reporter: Benedict >Assignee: Ariel Weisberg > Fix For: 3.0.x > > > If we downsample an index summary, we overwrite the existing summary, despite > downsampling being inexpensive. However on upsampling (which is expensive) we > do not, so that on restart all of our index summaries are the smallest they > have ever been adjusted to. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10512) We do not save an upsampled index summaries
[ https://issues.apache.org/jira/browse/CASSANDRA-10512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15045305#comment-15045305 ] Ariel Weisberg commented on CASSANDRA-10512: The tests on this finished running. > We do not save an upsampled index summaries > --- > > Key: CASSANDRA-10512 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10512 > Project: Cassandra > Issue Type: Bug > Components: Local Write-Read Paths >Reporter: Benedict >Assignee: Ariel Weisberg > Fix For: 3.0.1, 3.1, 2.1.x, 2.2.x > > > If we downsample an index summary, we overwrite the existing summary, despite > downsampling being inexpensive. However on upsampling (which is expensive) we > do not, so that on restart all of our index summaries are the smallest they > have ever been adjusted to. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10512) We do not save an upsampled index summaries
[ https://issues.apache.org/jira/browse/CASSANDRA-10512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15036814#comment-15036814 ] Ariel Weisberg commented on CASSANDRA-10512: bq. The code changes look good to me, with only one nitpick: in MmappedSegmentedFile.copyReadableBounds(), you used ii for the loop index variable instead of the standard i, for no reason that's apparent to me. I always use double letters for loop variables so you can search for them without hitting the letters as they occur inside other words. If that conflicts with the code style for C* I can go back to using single letter variables. Will change it and rebase now. > We do not save an upsampled index summaries > --- > > Key: CASSANDRA-10512 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10512 > Project: Cassandra > Issue Type: Bug > Components: Local Write-Read Paths >Reporter: Benedict >Assignee: Ariel Weisberg > Fix For: 3.0.1, 3.1, 2.1.x, 2.2.x > > > If we downsample an index summary, we overwrite the existing summary, despite > downsampling being inexpensive. However on upsampling (which is expensive) we > do not, so that on restart all of our index summaries are the smallest they > have ever been adjusted to. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10512) We do not save an upsampled index summaries
[ https://issues.apache.org/jira/browse/CASSANDRA-10512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15036829#comment-15036829 ] Ariel Weisberg commented on CASSANDRA-10512: Loop variable renamed, rebased, tests are running now. > We do not save an upsampled index summaries > --- > > Key: CASSANDRA-10512 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10512 > Project: Cassandra > Issue Type: Bug > Components: Local Write-Read Paths >Reporter: Benedict >Assignee: Ariel Weisberg > Fix For: 3.0.1, 3.1, 2.1.x, 2.2.x > > > If we downsample an index summary, we overwrite the existing summary, despite > downsampling being inexpensive. However on upsampling (which is expensive) we > do not, so that on restart all of our index summaries are the smallest they > have ever been adjusted to. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10512) We do not save an upsampled index summaries
[
https://issues.apache.org/jira/browse/CASSANDRA-10512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15036675#comment-15036675
]
Tyler Hobbs commented on CASSANDRA-10512:
-
The code changes look good to me, with only one nitpick: in
{{MmappedSegmentedFile.copyReadableBounds()}}, you used {{ii}} for the loop
index variable instead of the standard {{i}}, for no reason that's apparent to
me.
Can you rebase your branches and start new test runs?
> We do not save an upsampled index summaries
> ---
>
> Key: CASSANDRA-10512
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10512
> Project: Cassandra
> Issue Type: Bug
> Components: Local Write-Read Paths
>Reporter: Benedict
>Assignee: Ariel Weisberg
> Fix For: 3.0.1, 3.1, 2.1.x, 2.2.x
>
>
> If we downsample an index summary, we overwrite the existing summary, despite
> downsampling being inexpensive. However on upsampling (which is expensive) we
> do not, so that on restart all of our index summaries are the smallest they
> have ever been adjusted to.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10512) We do not save an upsampled index summaries
[ https://issues.apache.org/jira/browse/CASSANDRA-10512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14990240#comment-14990240 ] Ariel Weisberg commented on CASSANDRA-10512: Renamed, tests are running. > We do not save an upsampled index summaries > --- > > Key: CASSANDRA-10512 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10512 > Project: Cassandra > Issue Type: Bug >Reporter: Benedict >Assignee: Ariel Weisberg > Fix For: 2.1.x, 2.2.x, 3.1 > > > If we downsample an index summary, we overwrite the existing summary, despite > downsampling being inexpensive. However on upsampling (which is expensive) we > do not, so that on restart all of our index summaries are the smallest they > have ever been adjusted to. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10512) We do not save an upsampled index summaries
[
https://issues.apache.org/jira/browse/CASSANDRA-10512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14989434#comment-14989434
]
Benedict commented on CASSANDRA-10512:
--
I've closed CASSANDRA-10511 in favour of this, since your branches are merged.
Would it be neater to have a {{copyReadableBounds}} method instead of
{{getReadableBounds}}?
> We do not save an upsampled index summaries
> ---
>
> Key: CASSANDRA-10512
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10512
> Project: Cassandra
> Issue Type: Bug
>Reporter: Benedict
>Assignee: Ariel Weisberg
> Fix For: 2.1.x, 2.2.x, 3.1
>
>
> If we downsample an index summary, we overwrite the existing summary, despite
> downsampling being inexpensive. However on upsampling (which is expensive) we
> do not, so that on restart all of our index summaries are the smallest they
> have ever been adjusted to.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10512) We do not save an upsampled index summaries
[ https://issues.apache.org/jira/browse/CASSANDRA-10512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14979225#comment-14979225 ] Ariel Weisberg commented on CASSANDRA-10512: 2.1 and 2.2 build on the CASSANDRA-10511 branch. The 3.0 branch does not. |[2.2 code|https://github.com/apache/cassandra/compare/apache:cassandra-2.2...aweisberg:CASSANDRA-10511-2.2?expand=1]|[utests|http://cassci.datastax.com/view/Dev/view/aweisberg/job/aweisberg-CASSANDRA-10511-2.2-testall/]|[dtests|http://cassci.datastax.com/view/Dev/view/aweisberg/job/aweisberg-CASSANDRA-10511-2.2-dtest/]| |[2.1 code|https://github.com/apache/cassandra/compare/apache:cassandra-2.1...aweisberg:CASSANDRA-10511-2.1?expand=1]|[utests|http://cassci.datastax.com/view/Dev/view/aweisberg/job/aweisberg-CASSANDRA-10511-2.1-testall/]|[dtests|http://cassci.datastax.com/view/Dev/view/aweisberg/job/aweisberg-CASSANDRA-10511-2.1-dtest/]| |[3.0 code|https://github.com/apache/cassandra/compare/apache:cassandra-3.0...aweisberg:CASSANDRA-10512-3.0?expand=1]|[utests|http://cassci.datastax.com/view/Dev/view/aweisberg/job/aweisberg-CASSANDRA-10512-3.0-testall/]|[dtests|http://cassci.datastax.com/view/Dev/view/aweisberg/job/aweisberg-CASSANDRA-10512-3.0-dtest/]| > We do not save an upsampled index summaries > --- > > Key: CASSANDRA-10512 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10512 > Project: Cassandra > Issue Type: Bug >Reporter: Benedict >Assignee: Ariel Weisberg > Fix For: 2.1.x, 2.2.x, 3.1 > > > If we downsample an index summary, we overwrite the existing summary, despite > downsampling being inexpensive. However on upsampling (which is expensive) we > do not, so that on restart all of our index summaries are the smallest they > have ever been adjusted to. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
