[jira] [Commented] (CASSANDRA-10628) get JEMAlloc debug output out of nodetool output
[
https://issues.apache.org/jira/browse/CASSANDRA-10628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14990586#comment-14990586
]
Robert Stupp commented on CASSANDRA-10628:
--
Works on both OSX and Linux (latest Debian).
Thanks, committed as 0ff13d2a6847f7ecba1ac9a26b66714d9e58b60d to 2.2, 3.0, trunk
> get JEMAlloc debug output out of nodetool output
>
>
> Key: CASSANDRA-10628
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10628
> Project: Cassandra
> Issue Type: Bug
>Reporter: Jim Witschey
>Assignee: Robert Stupp
> Fix For: 2.2.4, 3.0.0
>
>
> This is a followup ticket for CASSANDRA-10581. The consensus on the Cassandra
> TE is that the debug output for loading JEMAlloc is helpful (or at least
> harmless when starting C*, but not when starting {{nodetool}}, which, it
> turns out, sources {{cassandra-env}}:
> https://github.com/apache/cassandra/blob/trunk/bin/nodetool#L53
> You can reproduce the excessive output with
> {code}
> ccm create test-nodetool-output -v git:cassandra-3.0 -n 1 ; ccm start
> --wait-for-binary-proto ; ccm node1 nodetool ring
> {code}
> The simplest solution would probably be to redirect the output of the
> sourcing to {{/dev/null/}}. I don't know if that's the right thing to do; it
> may be better to move the {{LD_PRELOAD}}-setting logic to {{bin/cassandra}}.
> I'm not sure what the reasoning would be for putting something in one place
> or another, so I leave it to the dev team to decide on the best solution.
> Assigning [~snazy] for now; feel free to reassign
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10628) get JEMAlloc debug output out of nodetool output
[
https://issues.apache.org/jira/browse/CASSANDRA-10628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14990322#comment-14990322
]
Ariel Weisberg commented on CASSANDRA-10628:
The change LGTM. The dtests and utests look good although the trunk version is
still running. I asked Robert to manually test on Linux and OS X, with and
without jemalloc, and disabling jemalloc with "-". If that checks out then +1.
> get JEMAlloc debug output out of nodetool output
>
>
> Key: CASSANDRA-10628
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10628
> Project: Cassandra
> Issue Type: Bug
>Reporter: Jim Witschey
>Assignee: Robert Stupp
> Fix For: 2.2.4, 3.0.0
>
>
> This is a followup ticket for CASSANDRA-10581. The consensus on the Cassandra
> TE is that the debug output for loading JEMAlloc is helpful (or at least
> harmless when starting C*, but not when starting {{nodetool}}, which, it
> turns out, sources {{cassandra-env}}:
> https://github.com/apache/cassandra/blob/trunk/bin/nodetool#L53
> You can reproduce the excessive output with
> {code}
> ccm create test-nodetool-output -v git:cassandra-3.0 -n 1 ; ccm start
> --wait-for-binary-proto ; ccm node1 nodetool ring
> {code}
> The simplest solution would probably be to redirect the output of the
> sourcing to {{/dev/null/}}. I don't know if that's the right thing to do; it
> may be better to move the {{LD_PRELOAD}}-setting logic to {{bin/cassandra}}.
> I'm not sure what the reasoning would be for putting something in one place
> or another, so I leave it to the dev team to decide on the best solution.
> Assigning [~snazy] for now; feel free to reassign
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10628) get JEMAlloc debug output out of nodetool output
[
https://issues.apache.org/jira/browse/CASSANDRA-10628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14986874#comment-14986874
]
Sylvain Lebresne commented on CASSANDRA-10628:
--
As I mentioned in CASSANDRA-10581, I'm not terribly fan of the warning as it
exists in the first place. I'd have a strong preference for warning for this in
the {{system.log}} file, like we do for many other things. I can see at least 2
ways to make that happen: 1) export some custom variable in the startup shell
script if JEMalloc is detected and check for that variable on the java side or
2) pass a startup option that says if we detected JEMalloc, with a preference
for 1). Doing so will obviously also solve this ticket.
> get JEMAlloc debug output out of nodetool output
>
>
> Key: CASSANDRA-10628
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10628
> Project: Cassandra
> Issue Type: Bug
>Reporter: Jim Witschey
>Assignee: Robert Stupp
> Fix For: 2.2.4, 3.0.0
>
>
> This is a followup ticket for CASSANDRA-10581. The consensus on the Cassandra
> TE is that the debug output for loading JEMAlloc is helpful (or at least
> harmless when starting C*, but not when starting {{nodetool}}, which, it
> turns out, sources {{cassandra-env}}:
> https://github.com/apache/cassandra/blob/trunk/bin/nodetool#L53
> You can reproduce the excessive output with
> {code}
> ccm create test-nodetool-output -v git:cassandra-3.0 -n 1 ; ccm start
> --wait-for-binary-proto ; ccm node1 nodetool ring
> {code}
> The simplest solution would probably be to redirect the output of the
> sourcing to {{/dev/null/}}. I don't know if that's the right thing to do; it
> may be better to move the {{LD_PRELOAD}}-setting logic to {{bin/cassandra}}.
> I'm not sure what the reasoning would be for putting something in one place
> or another, so I leave it to the dev team to decide on the best solution.
> Assigning [~snazy] for now; feel free to reassign
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10628) get JEMAlloc debug output out of nodetool output
[
https://issues.apache.org/jira/browse/CASSANDRA-10628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14987958#comment-14987958
]
Robert Stupp commented on CASSANDRA-10628:
--
Updated the patch to pass a Java system property containing the path of the
(probably) preloaded jemalloc to log the message from a {{StartupCheck}}
implementation.
Triggered [testall + dtest for 2.2 and 3.0
branches|http://cassci.datastax.com/search/?q=snazy-10628-].
> get JEMAlloc debug output out of nodetool output
>
>
> Key: CASSANDRA-10628
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10628
> Project: Cassandra
> Issue Type: Bug
>Reporter: Jim Witschey
>Assignee: Robert Stupp
> Fix For: 2.2.4, 3.0.0
>
>
> This is a followup ticket for CASSANDRA-10581. The consensus on the Cassandra
> TE is that the debug output for loading JEMAlloc is helpful (or at least
> harmless when starting C*, but not when starting {{nodetool}}, which, it
> turns out, sources {{cassandra-env}}:
> https://github.com/apache/cassandra/blob/trunk/bin/nodetool#L53
> You can reproduce the excessive output with
> {code}
> ccm create test-nodetool-output -v git:cassandra-3.0 -n 1 ; ccm start
> --wait-for-binary-proto ; ccm node1 nodetool ring
> {code}
> The simplest solution would probably be to redirect the output of the
> sourcing to {{/dev/null/}}. I don't know if that's the right thing to do; it
> may be better to move the {{LD_PRELOAD}}-setting logic to {{bin/cassandra}}.
> I'm not sure what the reasoning would be for putting something in one place
> or another, so I leave it to the dev team to decide on the best solution.
> Assigning [~snazy] for now; feel free to reassign
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10628) get JEMAlloc debug output out of nodetool output
[
https://issues.apache.org/jira/browse/CASSANDRA-10628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14985257#comment-14985257
]
Sylvain Lebresne commented on CASSANDRA-10628:
--
Was was the ticket that introduced that output?
> get JEMAlloc debug output out of nodetool output
>
>
> Key: CASSANDRA-10628
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10628
> Project: Cassandra
> Issue Type: Bug
>Reporter: Jim Witschey
>Assignee: Robert Stupp
> Fix For: 2.2.4, 3.0.0
>
>
> This is a followup ticket for CASSANDRA-10581. The consensus on the Cassandra
> TE is that the debug output for loading JEMAlloc is helpful (or at least
> harmless when starting C*, but not when starting {{nodetool}}, which, it
> turns out, sources {{cassandra-env}}:
> https://github.com/apache/cassandra/blob/trunk/bin/nodetool#L53
> You can reproduce the excessive output with
> {code}
> ccm create test-nodetool-output -v git:cassandra-3.0 -n 1 ; ccm start
> --wait-for-binary-proto ; ccm node1 nodetool ring
> {code}
> The simplest solution would probably be to redirect the output of the
> sourcing to {{/dev/null/}}. I don't know if that's the right thing to do; it
> may be better to move the {{LD_PRELOAD}}-setting logic to {{bin/cassandra}}.
> I'm not sure what the reasoning would be for putting something in one place
> or another, so I leave it to the dev team to decide on the best solution.
> Assigning [~snazy] for now; feel free to reassign
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10628) get JEMAlloc debug output out of nodetool output
[
https://issues.apache.org/jira/browse/CASSANDRA-10628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14985357#comment-14985357
]
Jim Witschey commented on CASSANDRA-10628:
--
[~slebresne] it was CASSANDRA-10581.
> get JEMAlloc debug output out of nodetool output
>
>
> Key: CASSANDRA-10628
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10628
> Project: Cassandra
> Issue Type: Bug
>Reporter: Jim Witschey
>Assignee: Robert Stupp
> Fix For: 2.2.4, 3.0.0
>
>
> This is a followup ticket for CASSANDRA-10581. The consensus on the Cassandra
> TE is that the debug output for loading JEMAlloc is helpful (or at least
> harmless when starting C*, but not when starting {{nodetool}}, which, it
> turns out, sources {{cassandra-env}}:
> https://github.com/apache/cassandra/blob/trunk/bin/nodetool#L53
> You can reproduce the excessive output with
> {code}
> ccm create test-nodetool-output -v git:cassandra-3.0 -n 1 ; ccm start
> --wait-for-binary-proto ; ccm node1 nodetool ring
> {code}
> The simplest solution would probably be to redirect the output of the
> sourcing to {{/dev/null/}}. I don't know if that's the right thing to do; it
> may be better to move the {{LD_PRELOAD}}-setting logic to {{bin/cassandra}}.
> I'm not sure what the reasoning would be for putting something in one place
> or another, so I leave it to the dev team to decide on the best solution.
> Assigning [~snazy] for now; feel free to reassign
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10628) get JEMAlloc debug output out of nodetool output
[
https://issues.apache.org/jira/browse/CASSANDRA-10628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14985402#comment-14985402
]
Sylvain Lebresne commented on CASSANDRA-10628:
--
This seems to be breaking a bunch of dtests for the record.
> get JEMAlloc debug output out of nodetool output
>
>
> Key: CASSANDRA-10628
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10628
> Project: Cassandra
> Issue Type: Bug
>Reporter: Jim Witschey
>Assignee: Robert Stupp
> Fix For: 2.2.4, 3.0.0
>
>
> This is a followup ticket for CASSANDRA-10581. The consensus on the Cassandra
> TE is that the debug output for loading JEMAlloc is helpful (or at least
> harmless when starting C*, but not when starting {{nodetool}}, which, it
> turns out, sources {{cassandra-env}}:
> https://github.com/apache/cassandra/blob/trunk/bin/nodetool#L53
> You can reproduce the excessive output with
> {code}
> ccm create test-nodetool-output -v git:cassandra-3.0 -n 1 ; ccm start
> --wait-for-binary-proto ; ccm node1 nodetool ring
> {code}
> The simplest solution would probably be to redirect the output of the
> sourcing to {{/dev/null/}}. I don't know if that's the right thing to do; it
> may be better to move the {{LD_PRELOAD}}-setting logic to {{bin/cassandra}}.
> I'm not sure what the reasoning would be for putting something in one place
> or another, so I leave it to the dev team to decide on the best solution.
> Assigning [~snazy] for now; feel free to reassign
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10628) get JEMAlloc debug output out of nodetool output
[
https://issues.apache.org/jira/browse/CASSANDRA-10628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14986043#comment-14986043
]
Ariel Weisberg commented on CASSANDRA-10628:
The dtests for this haven't run yet in Cassci. I started them on the 2.2 branch.
> get JEMAlloc debug output out of nodetool output
>
>
> Key: CASSANDRA-10628
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10628
> Project: Cassandra
> Issue Type: Bug
>Reporter: Jim Witschey
>Assignee: Robert Stupp
> Fix For: 2.2.4, 3.0.0
>
>
> This is a followup ticket for CASSANDRA-10581. The consensus on the Cassandra
> TE is that the debug output for loading JEMAlloc is helpful (or at least
> harmless when starting C*, but not when starting {{nodetool}}, which, it
> turns out, sources {{cassandra-env}}:
> https://github.com/apache/cassandra/blob/trunk/bin/nodetool#L53
> You can reproduce the excessive output with
> {code}
> ccm create test-nodetool-output -v git:cassandra-3.0 -n 1 ; ccm start
> --wait-for-binary-proto ; ccm node1 nodetool ring
> {code}
> The simplest solution would probably be to redirect the output of the
> sourcing to {{/dev/null/}}. I don't know if that's the right thing to do; it
> may be better to move the {{LD_PRELOAD}}-setting logic to {{bin/cassandra}}.
> I'm not sure what the reasoning would be for putting something in one place
> or another, so I leave it to the dev team to decide on the best solution.
> Assigning [~snazy] for now; feel free to reassign
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
