[jira] [Commented] (CASSANDRA-10632) sstableutil tests failing
[
https://issues.apache.org/jira/browse/CASSANDRA-10632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15008899#comment-15008899
]
Jim Witschey commented on CASSANDRA-10632:
--
Good catch, thanks. [dtest PR
filed|https://github.com/riptano/cassandra-dtest/pull/665].
> sstableutil tests failing
> -
>
> Key: CASSANDRA-10632
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10632
> Project: Cassandra
> Issue Type: Sub-task
>Reporter: Jim Witschey
>Assignee: Jim Witschey
> Fix For: 3.0.1, 3.1
>
>
> {{sstableutil_test.py:SSTableUtilTest.abortedcompaction_test}} and
> {{sstableutil_test.py:SSTableUtilTest.compaction_test}} fail on Windows:
> http://cassci.datastax.com/view/win32/job/cassandra-3.0_dtest_win32/100/testReport/sstableutil_test/SSTableUtilTest/abortedcompaction_test/
> http://cassci.datastax.com/view/win32/job/cassandra-3.0_dtest_win32/100/testReport/sstableutil_test/SSTableUtilTest/compaction_test/
> This is a pretty simple failure -- looks like the underlying behavior is ok,
> but string comparison fails when the leading {{d}} in the filename is
> lowercase as returned by {{sstableutil}} (see the [{{_invoke_sstableutil}}
> test
> function|https://github.com/riptano/cassandra-dtest/blob/master/sstableutil_test.py#L128]),
> but uppercase as returned by {{glob.glob}} (see the [{{_get_sstable_files}}
> test
> function|https://github.com/riptano/cassandra-dtest/blob/master/sstableutil_test.py#L160]).
> Do I understand correctly that Windows filenames are case-insensitive,
> including the drive portion? If that's the case, then we can just lowercase
> the file names in the test helper functions above when the tests are run on
> Windows. [~JoshuaMcKenzie] can you confirm? I'll fix this in the tests if so.
> If I'm wrong, and something in {{sstableutil}} needs to be fixed, could you
> find an assignee?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10632) sstableutil tests failing
[
https://issues.apache.org/jira/browse/CASSANDRA-10632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15006851#comment-15006851
]
Jim Witschey commented on CASSANDRA-10632:
--
Here's the current status of these tests:
* Linux
** [{{compaction_test}} is
fixed|http://cassci.datastax.com/job/cassandra-3.0_dtest/337/testReport/junit/sstableutil_test/SSTableUtilTest/compaction_test/history/].
** [{{abortedcompaction_test}}
flaps|http://cassci.datastax.com/job/cassandra-3.0_dtest/337/testReport/junit/sstableutil_test/SSTableUtilTest/abortedcompaction_test/history/].
This could be because of a race condition in the test (as [noted in this
comment|https://github.com/riptano/cassandra-dtest/blob/master/sstableutil_test.py#L80])
and may be fixed by [this dtest
PR|https://github.com/riptano/cassandra-dtest/pull/661].
* Windows
** [{{compaction_test}} is
fixed|http://cassci.datastax.com/view/win32/job/cassandra-3.0_dtest_win32/112/testReport/junit/sstableutil_test/SSTableUtilTest/compaction_test/history/].
** [{{abortedcompaction_test}} fails
consistently|http://cassci.datastax.com/view/win32/job/cassandra-3.0_dtest_win32/112/testReport/junit/sstableutil_test/SSTableUtilTest/abortedcompaction_test/history/].
It seems to fail when it finds temporary data files via {{sstableutil}} after
compaction [in this
assertion|https://github.com/riptano/cassandra-dtest/blob/master/sstableutil_test.py#L87].
Could this also be a race condition, where [the cleanup peformed in this
line|https://github.com/riptano/cassandra-dtest/blob/master/sstableutil_test.py#L85]
isn't complete?
[~jkni] I remember you saying you'd be willing/able to have a look at this. Do
you have any ideas about the failing Windows test?
> sstableutil tests failing
> -
>
> Key: CASSANDRA-10632
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10632
> Project: Cassandra
> Issue Type: Sub-task
>Reporter: Jim Witschey
>Assignee: Jim Witschey
> Fix For: 3.1
>
>
> {{sstableutil_test.py:SSTableUtilTest.abortedcompaction_test}} and
> {{sstableutil_test.py:SSTableUtilTest.compaction_test}} fail on Windows:
> http://cassci.datastax.com/view/win32/job/cassandra-3.0_dtest_win32/100/testReport/sstableutil_test/SSTableUtilTest/abortedcompaction_test/
> http://cassci.datastax.com/view/win32/job/cassandra-3.0_dtest_win32/100/testReport/sstableutil_test/SSTableUtilTest/compaction_test/
> This is a pretty simple failure -- looks like the underlying behavior is ok,
> but string comparison fails when the leading {{d}} in the filename is
> lowercase as returned by {{sstableutil}} (see the [{{_invoke_sstableutil}}
> test
> function|https://github.com/riptano/cassandra-dtest/blob/master/sstableutil_test.py#L128]),
> but uppercase as returned by {{glob.glob}} (see the [{{_get_sstable_files}}
> test
> function|https://github.com/riptano/cassandra-dtest/blob/master/sstableutil_test.py#L160]).
> Do I understand correctly that Windows filenames are case-insensitive,
> including the drive portion? If that's the case, then we can just lowercase
> the file names in the test helper functions above when the tests are run on
> Windows. [~JoshuaMcKenzie] can you confirm? I'll fix this in the tests if so.
> If I'm wrong, and something in {{sstableutil}} needs to be fixed, could you
> find an assignee?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10632) sstableutil tests failing
[
https://issues.apache.org/jira/browse/CASSANDRA-10632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15006896#comment-15006896
]
Joel Knighton commented on CASSANDRA-10632:
---
I don't have an immediate reaction other than that I don't think there is a
race condition in the cleanup there.
I'll take a look tonight.
> sstableutil tests failing
> -
>
> Key: CASSANDRA-10632
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10632
> Project: Cassandra
> Issue Type: Sub-task
>Reporter: Jim Witschey
>Assignee: Jim Witschey
> Fix For: 3.1
>
>
> {{sstableutil_test.py:SSTableUtilTest.abortedcompaction_test}} and
> {{sstableutil_test.py:SSTableUtilTest.compaction_test}} fail on Windows:
> http://cassci.datastax.com/view/win32/job/cassandra-3.0_dtest_win32/100/testReport/sstableutil_test/SSTableUtilTest/abortedcompaction_test/
> http://cassci.datastax.com/view/win32/job/cassandra-3.0_dtest_win32/100/testReport/sstableutil_test/SSTableUtilTest/compaction_test/
> This is a pretty simple failure -- looks like the underlying behavior is ok,
> but string comparison fails when the leading {{d}} in the filename is
> lowercase as returned by {{sstableutil}} (see the [{{_invoke_sstableutil}}
> test
> function|https://github.com/riptano/cassandra-dtest/blob/master/sstableutil_test.py#L128]),
> but uppercase as returned by {{glob.glob}} (see the [{{_get_sstable_files}}
> test
> function|https://github.com/riptano/cassandra-dtest/blob/master/sstableutil_test.py#L160]).
> Do I understand correctly that Windows filenames are case-insensitive,
> including the drive portion? If that's the case, then we can just lowercase
> the file names in the test helper functions above when the tests are run on
> Windows. [~JoshuaMcKenzie] can you confirm? I'll fix this in the tests if so.
> If I'm wrong, and something in {{sstableutil}} needs to be fixed, could you
> find an assignee?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10632) sstableutil tests failing
[
https://issues.apache.org/jira/browse/CASSANDRA-10632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007942#comment-15007942
]
Joel Knighton commented on CASSANDRA-10632:
---
[~mambocab]
There's another round of text fixes before we will find any C* bugs here.
If you look at the Windows failures, they're actually occurring in
{{_check_files}} before a cleanup is even attempted.
It expects no temporary files at this point, which is an error, as we know
there should be some. If we look at how this list of temporary files is
created, we see it is the set difference of all files and final files. From
debug output, we see there are 75 files total and 72 final files, so this
difference should find three expected files.
If we look at all files and final files after the Windows path handling, it is
clear a bad and terrifying thing has happened. After Windows file mangling, we
get paths like:
{code}
dtest: DEBUG: ['g-crc.db', 'g-data.db', 'g-digest.crc32', 'g-filter.db',
'g-index.db', 'g-statistics.db', 'g-summary.db', 'g-toc.txt', 'g-crc.db',
'g-data.db', 'g-digest.crc32', 'g-filter.db', 'g-index.db', 'g-statistics.db',
'g-summary.db', 'g-toc.txt', 'g-crc.db', 'g-data.db', 'g-digest.crc32',
'g-filter.db', 'g-index.db', 'g-statistics.db', 'g-summary.db', 'g-toc.txt',
'4-big-crc.db', '4-big-data.db', '4-big-digest.crc32', '4-big-filter.db',
'4-big-index.db', '4-big-statistics.db', '4-big-summary.db', '4-big-toc.txt',
'g-crc.db', 'g-data.db', 'g-digest.crc32', 'g-filter.db', 'g-index.db',
'g-statistics.db', 'g-summary.db', 'g-toc.txt', 'g-crc.db', 'g-data.db',
'g-digest.crc32', 'g-filter.db', 'g-index.db', 'g-statistics.db',
'g-summary.db', 'g-toc.txt', '7-big-crc.db', '7-big-data.db',
'7-big-digest.crc32', '7-big-filter.db', '7-big-index.db',
'7-big-statistics.db', '7-big-summary.db', '7-big-toc.txt', 'g-crc.db',
'g-data.db', 'g-digest.crc32', 'g-filter.db', 'g-index.db', 'g-statistics.db',
'g-summary.db', 'g-toc.txt', 'g-crc.db', 'g-data.db', 'g-digest.crc32',
'g-filter.db', 'g-index.db', 'g-statistics.db', 'g-summary.db', 'g-toc.txt']
{code}
This is because lstrip doesn't strip a string from the left, but it in fact
strips a string as long as the next character is present in the string given as
an argument. {{_strip_common_prefix}} needs to be fixed to use a different
method to strip strings from the left based on absolute match - I suggest just
removing the number of characters that is the length of the common prefix.
After that, in the comparison, {{expected_tmpfiles}} in {{_check_files}} isn't
processed the same way, so comparisons will still fail.
{{_strip_common_prefix}} doesn't work here, since it will likely only contain
files for one sstable, so the common prefix will match more than expected.
Once these are fixed, I can take another look if there still seem to be any
problems.
> sstableutil tests failing
> -
>
> Key: CASSANDRA-10632
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10632
> Project: Cassandra
> Issue Type: Sub-task
>Reporter: Jim Witschey
>Assignee: Jim Witschey
> Fix For: 3.0.1, 3.1
>
>
> {{sstableutil_test.py:SSTableUtilTest.abortedcompaction_test}} and
> {{sstableutil_test.py:SSTableUtilTest.compaction_test}} fail on Windows:
> http://cassci.datastax.com/view/win32/job/cassandra-3.0_dtest_win32/100/testReport/sstableutil_test/SSTableUtilTest/abortedcompaction_test/
> http://cassci.datastax.com/view/win32/job/cassandra-3.0_dtest_win32/100/testReport/sstableutil_test/SSTableUtilTest/compaction_test/
> This is a pretty simple failure -- looks like the underlying behavior is ok,
> but string comparison fails when the leading {{d}} in the filename is
> lowercase as returned by {{sstableutil}} (see the [{{_invoke_sstableutil}}
> test
> function|https://github.com/riptano/cassandra-dtest/blob/master/sstableutil_test.py#L128]),
> but uppercase as returned by {{glob.glob}} (see the [{{_get_sstable_files}}
> test
> function|https://github.com/riptano/cassandra-dtest/blob/master/sstableutil_test.py#L160]).
> Do I understand correctly that Windows filenames are case-insensitive,
> including the drive portion? If that's the case, then we can just lowercase
> the file names in the test helper functions above when the tests are run on
> Windows. [~JoshuaMcKenzie] can you confirm? I'll fix this in the tests if so.
> If I'm wrong, and something in {{sstableutil}} needs to be fixed, could you
> find an assignee?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10632) sstableutil tests failing
[
https://issues.apache.org/jira/browse/CASSANDRA-10632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15004009#comment-15004009
]
Joshua McKenzie commented on CASSANDRA-10632:
-
For temp files from an aborted compaction, I wouldn't expect them to hang
around on Windows after 3.0. Active sstables that are being read, maybe (since
we mmap and have new retrying deletion paths), but not temp sstables.
> sstableutil tests failing
> -
>
> Key: CASSANDRA-10632
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10632
> Project: Cassandra
> Issue Type: Sub-task
>Reporter: Jim Witschey
>Assignee: Jim Witschey
> Fix For: 3.1
>
>
> {{sstableutil_test.py:SSTableUtilTest.abortedcompaction_test}} and
> {{sstableutil_test.py:SSTableUtilTest.compaction_test}} fail on Windows:
> http://cassci.datastax.com/view/win32/job/cassandra-3.0_dtest_win32/100/testReport/sstableutil_test/SSTableUtilTest/abortedcompaction_test/
> http://cassci.datastax.com/view/win32/job/cassandra-3.0_dtest_win32/100/testReport/sstableutil_test/SSTableUtilTest/compaction_test/
> This is a pretty simple failure -- looks like the underlying behavior is ok,
> but string comparison fails when the leading {{d}} in the filename is
> lowercase as returned by {{sstableutil}} (see the [{{_invoke_sstableutil}}
> test
> function|https://github.com/riptano/cassandra-dtest/blob/master/sstableutil_test.py#L128]),
> but uppercase as returned by {{glob.glob}} (see the [{{_get_sstable_files}}
> test
> function|https://github.com/riptano/cassandra-dtest/blob/master/sstableutil_test.py#L160]).
> Do I understand correctly that Windows filenames are case-insensitive,
> including the drive portion? If that's the case, then we can just lowercase
> the file names in the test helper functions above when the tests are run on
> Windows. [~JoshuaMcKenzie] can you confirm? I'll fix this in the tests if so.
> If I'm wrong, and something in {{sstableutil}} needs to be fixed, could you
> find an assignee?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10632) sstableutil tests failing
[
https://issues.apache.org/jira/browse/CASSANDRA-10632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15002958#comment-15002958
]
Jim Witschey commented on CASSANDRA-10632:
--
Looks like the failures meant to be fixed by that dtest PR are fixed:
http://cassci.datastax.com/view/win32/job/cassandra-3.0_dtest_win32/110/testReport/sstableutil_test/SSTableUtilTest/
So now we're on to a new error:
http://cassci.datastax.com/view/win32/job/cassandra-3.0_dtest_win32/110/testReport/sstableutil_test/SSTableUtilTest/abortedcompaction_test/
If I read the test correctly, it looks like some temp files are handing around
after an aborted compaction. [~JoshuaMcKenzie] is this expected on Windows, or
is this a true bug?
> sstableutil tests failing
> -
>
> Key: CASSANDRA-10632
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10632
> Project: Cassandra
> Issue Type: Sub-task
>Reporter: Jim Witschey
>Assignee: Jim Witschey
> Fix For: 3.1
>
>
> {{sstableutil_test.py:SSTableUtilTest.abortedcompaction_test}} and
> {{sstableutil_test.py:SSTableUtilTest.compaction_test}} fail on Windows:
> http://cassci.datastax.com/view/win32/job/cassandra-3.0_dtest_win32/100/testReport/sstableutil_test/SSTableUtilTest/abortedcompaction_test/
> http://cassci.datastax.com/view/win32/job/cassandra-3.0_dtest_win32/100/testReport/sstableutil_test/SSTableUtilTest/compaction_test/
> This is a pretty simple failure -- looks like the underlying behavior is ok,
> but string comparison fails when the leading {{d}} in the filename is
> lowercase as returned by {{sstableutil}} (see the [{{_invoke_sstableutil}}
> test
> function|https://github.com/riptano/cassandra-dtest/blob/master/sstableutil_test.py#L128]),
> but uppercase as returned by {{glob.glob}} (see the [{{_get_sstable_files}}
> test
> function|https://github.com/riptano/cassandra-dtest/blob/master/sstableutil_test.py#L160]).
> Do I understand correctly that Windows filenames are case-insensitive,
> including the drive portion? If that's the case, then we can just lowercase
> the file names in the test helper functions above when the tests are run on
> Windows. [~JoshuaMcKenzie] can you confirm? I'll fix this in the tests if so.
> If I'm wrong, and something in {{sstableutil}} needs to be fixed, could you
> find an assignee?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10632) sstableutil tests failing
[
https://issues.apache.org/jira/browse/CASSANDRA-10632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14996697#comment-14996697
]
Jim Witschey commented on CASSANDRA-10632:
--
Ping [~JoshuaMcKenzie] -- do you see anything wrong with the workaround in the
dtest PR?
https://github.com/riptano/cassandra-dtest/pull/641
> sstableutil tests failing
> -
>
> Key: CASSANDRA-10632
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10632
> Project: Cassandra
> Issue Type: Sub-task
>Reporter: Jim Witschey
>Assignee: Jim Witschey
> Fix For: 3.1
>
>
> {{sstableutil_test.py:SSTableUtilTest.abortedcompaction_test}} and
> {{sstableutil_test.py:SSTableUtilTest.compaction_test}} fail on Windows:
> http://cassci.datastax.com/view/win32/job/cassandra-3.0_dtest_win32/100/testReport/sstableutil_test/SSTableUtilTest/abortedcompaction_test/
> http://cassci.datastax.com/view/win32/job/cassandra-3.0_dtest_win32/100/testReport/sstableutil_test/SSTableUtilTest/compaction_test/
> This is a pretty simple failure -- looks like the underlying behavior is ok,
> but string comparison fails when the leading {{d}} in the filename is
> lowercase as returned by {{sstableutil}} (see the [{{_invoke_sstableutil}}
> test
> function|https://github.com/riptano/cassandra-dtest/blob/master/sstableutil_test.py#L128]),
> but uppercase as returned by {{glob.glob}} (see the [{{_get_sstable_files}}
> test
> function|https://github.com/riptano/cassandra-dtest/blob/master/sstableutil_test.py#L160]).
> Do I understand correctly that Windows filenames are case-insensitive,
> including the drive portion? If that's the case, then we can just lowercase
> the file names in the test helper functions above when the tests are run on
> Windows. [~JoshuaMcKenzie] can you confirm? I'll fix this in the tests if so.
> If I'm wrong, and something in {{sstableutil}} needs to be fixed, could you
> find an assignee?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10632) sstableutil tests failing on Windows
[
https://issues.apache.org/jira/browse/CASSANDRA-10632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14993772#comment-14993772
]
Sylvain Lebresne commented on CASSANDRA-10632:
--
Fyi, those are not only failing on windows, they appear
[here|http://cassci.datastax.com/job/cassandra-3.0_dtest/335/#showFailuresLink]
too. So that's probably not a windows specific thing.
> sstableutil tests failing on Windows
>
>
> Key: CASSANDRA-10632
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10632
> Project: Cassandra
> Issue Type: Sub-task
>Reporter: Jim Witschey
>Assignee: Jim Witschey
> Fix For: 3.1
>
>
> {{sstableutil_test.py:SSTableUtilTest.abortedcompaction_test}} and
> {{sstableutil_test.py:SSTableUtilTest.compaction_test}} fail on Windows:
> http://cassci.datastax.com/view/win32/job/cassandra-3.0_dtest_win32/100/testReport/sstableutil_test/SSTableUtilTest/abortedcompaction_test/
> http://cassci.datastax.com/view/win32/job/cassandra-3.0_dtest_win32/100/testReport/sstableutil_test/SSTableUtilTest/compaction_test/
> This is a pretty simple failure -- looks like the underlying behavior is ok,
> but string comparison fails when the leading {{d}} in the filename is
> lowercase as returned by {{sstableutil}} (see the [{{_invoke_sstableutil}}
> test
> function|https://github.com/riptano/cassandra-dtest/blob/master/sstableutil_test.py#L128]),
> but uppercase as returned by {{glob.glob}} (see the [{{_get_sstable_files}}
> test
> function|https://github.com/riptano/cassandra-dtest/blob/master/sstableutil_test.py#L160]).
> Do I understand correctly that Windows filenames are case-insensitive,
> including the drive portion? If that's the case, then we can just lowercase
> the file names in the test helper functions above when the tests are run on
> Windows. [~JoshuaMcKenzie] can you confirm? I'll fix this in the tests if so.
> If I'm wrong, and something in {{sstableutil}} needs to be fixed, could you
> find an assignee?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10632) sstableutil tests failing on Windows
[
https://issues.apache.org/jira/browse/CASSANDRA-10632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14990462#comment-14990462
]
Jim Witschey commented on CASSANDRA-10632:
--
[dtest PR|https://github.com/riptano/cassandra-dtest/pull/641]. In my OpenStack
Windows environment,
{{sstableutil_test.py:SSTableUtilTest.abortedcompaction_test}} still fails
after those changes, as described in the PR. If that PR gets merged, I'll still
need help figuring out what's causing the remaining failure.
> sstableutil tests failing on Windows
>
>
> Key: CASSANDRA-10632
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10632
> Project: Cassandra
> Issue Type: Sub-task
>Reporter: Jim Witschey
>Assignee: Jim Witschey
> Fix For: 3.0.0
>
>
> {{sstableutil_test.py:SSTableUtilTest.abortedcompaction_test}} and
> {{sstableutil_test.py:SSTableUtilTest.compaction_test}} fail on Windows:
> http://cassci.datastax.com/view/win32/job/cassandra-3.0_dtest_win32/100/testReport/sstableutil_test/SSTableUtilTest/abortedcompaction_test/
> http://cassci.datastax.com/view/win32/job/cassandra-3.0_dtest_win32/100/testReport/sstableutil_test/SSTableUtilTest/compaction_test/
> This is a pretty simple failure -- looks like the underlying behavior is ok,
> but string comparison fails when the leading {{d}} in the filename is
> lowercase as returned by {{sstableutil}} (see the [{{_invoke_sstableutil}}
> test
> function|https://github.com/riptano/cassandra-dtest/blob/master/sstableutil_test.py#L128]),
> but uppercase as returned by {{glob.glob}} (see the [{{_get_sstable_files}}
> test
> function|https://github.com/riptano/cassandra-dtest/blob/master/sstableutil_test.py#L160]).
> Do I understand correctly that Windows filenames are case-insensitive,
> including the drive portion? If that's the case, then we can just lowercase
> the file names in the test helper functions above when the tests are run on
> Windows. [~JoshuaMcKenzie] can you confirm? I'll fix this in the tests if so.
> If I'm wrong, and something in {{sstableutil}} needs to be fixed, could you
> find an assignee?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10632) sstableutil tests failing on Windows
[
https://issues.apache.org/jira/browse/CASSANDRA-10632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14985699#comment-14985699
]
Joshua McKenzie commented on CASSANDRA-10632:
-
While NTFS itself is case sensitive, most things in the Windows API / using
Win32 are case-insensitive (tools used in command-prompt, command-prompt
itself, etc), including treatment of file names.
> sstableutil tests failing on Windows
>
>
> Key: CASSANDRA-10632
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10632
> Project: Cassandra
> Issue Type: Sub-task
>Reporter: Jim Witschey
>Assignee: Jim Witschey
> Fix For: 3.0.0
>
>
> {{sstableutil_test.py:SSTableUtilTest.abortedcompaction_test}} and
> {{sstableutil_test.py:SSTableUtilTest.compaction_test}} fail on Windows:
> http://cassci.datastax.com/view/win32/job/cassandra-3.0_dtest_win32/100/testReport/sstableutil_test/SSTableUtilTest/abortedcompaction_test/
> http://cassci.datastax.com/view/win32/job/cassandra-3.0_dtest_win32/100/testReport/sstableutil_test/SSTableUtilTest/compaction_test/
> This is a pretty simple failure -- looks like the underlying behavior is ok,
> but string comparison fails when the leading {{d}} in the filename is
> lowercase as returned by {{sstableutil}} (see the [{{_invoke_sstableutil}}
> test
> function|https://github.com/riptano/cassandra-dtest/blob/master/sstableutil_test.py#L128]),
> but uppercase as returned by {{glob.glob}} (see the [{{_get_sstable_files}}
> test
> function|https://github.com/riptano/cassandra-dtest/blob/master/sstableutil_test.py#L160]).
> Do I understand correctly that Windows filenames are case-insensitive,
> including the drive portion? If that's the case, then we can just lowercase
> the file names in the test helper functions above when the tests are run on
> Windows. [~JoshuaMcKenzie] can you confirm? I'll fix this in the tests if so.
> If I'm wrong, and something in {{sstableutil}} needs to be fixed, could you
> find an assignee?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
