[jira] [Commented] (CASSANDRA-10635) Add metrics for authentication failures
[ https://issues.apache.org/jira/browse/CASSANDRA-10635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15373176#comment-15373176 ] Soumava Ghosh commented on CASSANDRA-10635: --- [~beobal] your changes look good to me. I agree, they should be meters, the rate of these failures would be good metric to have. Being able to disambiguate would have been nice, but as you say its a different feature, which is true. > Add metrics for authentication failures > --- > > Key: CASSANDRA-10635 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10635 > Project: Cassandra > Issue Type: Improvement >Reporter: Soumava Ghosh >Assignee: Soumava Ghosh >Priority: Minor > Fix For: 3.x > > Attachments: 10635-2.1.txt, 10635-2.2.txt, 10635-3.0.txt, > 10635-dtest.patch, 10635-trunk.patch > > > There should be no auth failures on a cluster in general. > Having metrics around the authentication code would help detect clients > that are connecting to the wrong cluster or have auth incorrectly configured. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10635) Add metrics for authentication failures
[ https://issues.apache.org/jira/browse/CASSANDRA-10635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15373042#comment-15373042 ] Sam Tunnicliffe commented on CASSANDRA-10635: - [~soumava] I've opened a [dtest PR|https://github.com/riptano/cassandra-dtest/pull/1090] with your new test. Once that's approved, unless you object I'll commit the version with the meters from my branch. > Add metrics for authentication failures > --- > > Key: CASSANDRA-10635 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10635 > Project: Cassandra > Issue Type: Improvement >Reporter: Soumava Ghosh >Assignee: Soumava Ghosh >Priority: Minor > Fix For: 3.x > > Attachments: 10635-2.1.txt, 10635-2.2.txt, 10635-3.0.txt, > 10635-dtest.patch, 10635-trunk.patch > > > There should be no auth failures on a cluster in general. > Having metrics around the authentication code would help detect clients > that are connecting to the wrong cluster or have auth incorrectly configured. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10635) Add metrics for authentication failures
[ https://issues.apache.org/jira/browse/CASSANDRA-10635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15369087#comment-15369087 ] Chris Lohfink commented on CASSANDRA-10635: --- Your branch looks good to me, I like the idea of it as a meter instead of counter > Add metrics for authentication failures > --- > > Key: CASSANDRA-10635 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10635 > Project: Cassandra > Issue Type: Improvement >Reporter: Soumava Ghosh >Assignee: Soumava Ghosh >Priority: Minor > Fix For: 3.x > > Attachments: 10635-2.1.txt, 10635-2.2.txt, 10635-3.0.txt, > 10635-dtest.patch, 10635-trunk.patch > > > There should be no auth failures on a cluster in general. > Having metrics around the authentication code would help detect clients > that are connecting to the wrong cluster or have auth incorrectly configured. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10635) Add metrics for authentication failures
[
https://issues.apache.org/jira/browse/CASSANDRA-10635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15367587#comment-15367587
]
Sam Tunnicliffe commented on CASSANDRA-10635:
-
I wonder whether meters rather than counters would be more useful here, being
able to provide not just an absolute count but rates of auth failure/success. I
would imagine that the ability to detect spikes here would provide more
actionable signals for operators.
I'm not wild about tying the metric/mbean names to the message classes. It
would be cleaner IMO to grouop them with the existing client metrics (at least
in the mbeans). Doing it that way would mean being losing the ability to
disambiguate between the counts generated from {{CredentialsMessage}}(protocol
v1) and {{AuthResponse}}(later versions), but that's a feature not a bug for me
and we should have dedicated metrics for the versions used by connecting
clients if they're relevant.
[~soumava] I've pushed a branch which applies the above changes to your
original patch [here|https://github.com/beobal/cassandra/tree/10635-trunk],
wdyt?
[~cnlwsu] would be good to get your opinion here too, if you have chance to
take a look.
> Add metrics for authentication failures
> ---
>
> Key: CASSANDRA-10635
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10635
> Project: Cassandra
> Issue Type: Improvement
>Reporter: Soumava Ghosh
>Assignee: Soumava Ghosh
>Priority: Minor
> Fix For: 3.x
>
> Attachments: 10635-2.1.txt, 10635-2.2.txt, 10635-3.0.txt,
> 10635-dtest.patch, 10635-trunk.patch
>
>
> There should be no auth failures on a cluster in general.
> Having metrics around the authentication code would help detect clients
> that are connecting to the wrong cluster or have auth incorrectly configured.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10635) Add metrics for authentication failures
[ https://issues.apache.org/jira/browse/CASSANDRA-10635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269247#comment-15269247 ] Soumava Ghosh commented on CASSANDRA-10635: --- Yeah, sorry for the delay, I'm looking at this right now and I should be back with a patch within the next few days. > Add metrics for authentication failures > --- > > Key: CASSANDRA-10635 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10635 > Project: Cassandra > Issue Type: Improvement >Reporter: Soumava Ghosh >Assignee: Soumava Ghosh >Priority: Minor > Fix For: 3.x > > Attachments: 10635-2.1.txt, 10635-2.2.txt, 10635-3.0.txt > > > There should be no auth failures on a cluster in general. > Having metrics around the authentication code would help detect clients > that are connecting to the wrong cluster or have auth incorrectly configured. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10635) Add metrics for authentication failures
[ https://issues.apache.org/jira/browse/CASSANDRA-10635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269221#comment-15269221 ] Sam Tunnicliffe commented on CASSANDRA-10635: - [~soumava], did you get a chance to revisit this? > Add metrics for authentication failures > --- > > Key: CASSANDRA-10635 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10635 > Project: Cassandra > Issue Type: Improvement >Reporter: Soumava Ghosh >Assignee: Soumava Ghosh >Priority: Minor > Fix For: 3.x > > Attachments: 10635-2.1.txt, 10635-2.2.txt, 10635-3.0.txt > > > There should be no auth failures on a cluster in general. > Having metrics around the authentication code would help detect clients > that are connecting to the wrong cluster or have auth incorrectly configured. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
