[jira] [Commented] (CASSANDRA-10653) Remove dependency on jgrapht for UDT resolution
[ https://issues.apache.org/jira/browse/CASSANDRA-10653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15064116#comment-15064116 ] Aleksey Yeschenko commented on CASSANDRA-10653: --- Done [here|http://cassci.datastax.com/view/Dev/view/iamaleksey/job/iamaleksey-10653-testall/lastCompletedBuild/testReport/] and [here|http://cassci.datastax.com/view/Dev/view/iamaleksey/job/iamaleksey-10653-dtest/lastCompletedBuild/testReport/]. Committed as [d877ba073f60b8aba9ab70a5e163cc13b232ffdd|https://github.com/apache/cassandra/commit/d877ba073f60b8aba9ab70a5e163cc13b232ffdd] to 3.0 and merged with trunk. Thanks. > Remove dependency on jgrapht for UDT resolution > --- > > Key: CASSANDRA-10653 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10653 > Project: Cassandra > Issue Type: Bug > Components: Distributed Metadata >Reporter: Aleksey Yeschenko >Assignee: Aleksey Yeschenko >Priority: Minor > Fix For: 3.0.x > > > Now that the java-driver no longer pulls it as a dependency, it is silly to > pull a whole library for resolving UDTs dependencies. > Should rewrite the resolution code without jgrapht (maybe reuse whatever code > java-driver ended up writing). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10653) Remove dependency on jgrapht for UDT resolution
[ https://issues.apache.org/jira/browse/CASSANDRA-10653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15060024#comment-15060024 ] Sylvain Lebresne commented on CASSANDRA-10653: -- +1, but it's probably worth rebasing and re-running the tests before commit. > Remove dependency on jgrapht for UDT resolution > --- > > Key: CASSANDRA-10653 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10653 > Project: Cassandra > Issue Type: Bug > Components: Distributed Metadata >Reporter: Aleksey Yeschenko >Assignee: Aleksey Yeschenko >Priority: Minor > Fix For: 3.0.x > > > Now that the java-driver no longer pulls it as a dependency, it is silly to > pull a whole library for resolving UDTs dependencies. > Should rewrite the resolution code without jgrapht (maybe reuse whatever code > java-driver ended up writing). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10653) Remove dependency on jgrapht for UDT resolution
[ https://issues.apache.org/jira/browse/CASSANDRA-10653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15025438#comment-15025438 ] Aleksey Yeschenko commented on CASSANDRA-10653: --- [~slebresne] If you are +1, or need to make only some trivial changes, please commit yourself. Thanks. > Remove dependency on jgrapht for UDT resolution > --- > > Key: CASSANDRA-10653 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10653 > Project: Cassandra > Issue Type: Bug > Components: Distributed Metadata >Reporter: Aleksey Yeschenko >Assignee: Aleksey Yeschenko >Priority: Minor > Fix For: 3.0.1, 3.1 > > > Now that the java-driver no longer pulls it as a dependency, it is silly to > pull a whole library for resolving UDTs dependencies. > Should rewrite the resolution code without jgrapht (maybe reuse whatever code > java-driver ended up writing). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10653) Remove dependency on jgrapht for UDT resolution
[
https://issues.apache.org/jira/browse/CASSANDRA-10653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15008669#comment-15008669
]
Aleksey Yeschenko commented on CASSANDRA-10653:
---
Pushed a branch to my repo, tests running:
||branch||testall||dtest||
|[10653|https://github.com/iamaleksey/cassandra/tree/10653]|[testall|http://cassci.datastax.com/view/Dev/view/iamaleksey/job/iamaleksey-10653-testall]|[dtest|http://cassci.datastax.com/view/Dev/view/iamaleksey/job/iamaleksey-10653-dtest]|
It's not even taking that much more code, when hand-rolled. Now that the driver
doesn't use jgrapht, it's an utter overkill to keep it (though I still maintain
that v1 was ugly as hell).
Test coverage piggybacks on existing {{UserTypesTest}}, {{LegacyMigratorTest}}
and dtests. CASSANDRA-10364 will be adding more, including more complex UDT
graphs.
> Remove dependency on jgrapht for UDT resolution
> ---
>
> Key: CASSANDRA-10653
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10653
> Project: Cassandra
> Issue Type: Improvement
> Components: Distributed Metadata
>Reporter: Aleksey Yeschenko
>Assignee: Aleksey Yeschenko
>Priority: Minor
> Fix For: 3.0.x
>
>
> Now that the java-driver no longer pulls it as a dependency, it is silly to
> pull a whole library for resolving UDTs dependencies.
> Should rewrite the resolution code without jgrapht (maybe reuse whatever code
> java-driver ended up writing).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
