[jira] [Commented] (CASSANDRA-10852) Add requireAuthorization method to IAuthorizer
[
https://issues.apache.org/jira/browse/CASSANDRA-10852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15056182#comment-15056182
]
Mike Adamson commented on CASSANDRA-10852:
--
Good point. I've updated the branch to use a default implementation of the
method.
> Add requireAuthorization method to IAuthorizer
> --
>
> Key: CASSANDRA-10852
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10852
> Project: Cassandra
> Issue Type: New Feature
>Reporter: Mike Adamson
>Assignee: Mike Adamson
>Priority: Minor
> Fix For: 3.2
>
>
> The {{IAuthenticator}} interface has a {{requireAuthentication}} to indicate
> whether an implementation requires an explicit login. For consistency it
> would be useful for 3rd party implementers if the {{IAuthorizer}} had a
> similar method {{requireAuthorization}} that would indicate if the
> implementation required explicit authorization.
> This would mean that we could remove and explicit {{instanceof}} checks for
> {{AllowAllAuthenticator}} and {{AllowAllAuthorizer}} in the code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10852) Add requireAuthorization method to IAuthorizer
[
https://issues.apache.org/jira/browse/CASSANDRA-10852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15056036#comment-15056036
]
Aleksey Yeschenko commented on CASSANDRA-10852:
---
Not a review, however:
1. You are not allowed to add new abstract interface methods to public APIs.
For 3.x, though, as we are forcing Java 8, you can use default methods.
2. {{@Override}} missing in the implementations once you switch to {{default}}
> Add requireAuthorization method to IAuthorizer
> --
>
> Key: CASSANDRA-10852
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10852
> Project: Cassandra
> Issue Type: New Feature
>Reporter: Mike Adamson
>Assignee: Mike Adamson
>Priority: Minor
> Fix For: 3.2
>
>
> The {{IAuthenticator}} interface has a {{requireAuthentication}} to indicate
> whether an implementation requires an explicit login. For consistency it
> would be useful for 3rd party implementers if the {{IAuthorizer}} had a
> similar method {{requireAuthorization}} that would indicate if the
> implementation required explicit authorization.
> This would mean that we could remove and explicit {{instanceof}} checks for
> {{AllowAllAuthenticator}} and {{AllowAllAuthorizer}} in the code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10852) Add requireAuthorization method to IAuthorizer
[
https://issues.apache.org/jira/browse/CASSANDRA-10852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15054365#comment-15054365
]
Mike Adamson commented on CASSANDRA-10852:
--
Branch and tests:
||trunk||
|[branch|https://github.com/mike-tr-adamson/cassandra/tree/10852-trunk]|
|[testall|http://cassci.datastax.com/view/Dev/view/madamson/job/mike-tr-adamson-10852-trunk-testall/]|
|[dtests|http://cassci.datastax.com/view/Dev/view/madamson/job/mike-tr-adamson-10852-trunk-dtest/]|
> Add requireAuthorization method to IAuthorizer
> --
>
> Key: CASSANDRA-10852
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10852
> Project: Cassandra
> Issue Type: New Feature
>Reporter: Mike Adamson
>Assignee: Mike Adamson
>Priority: Minor
> Fix For: 3.2
>
>
> The {{IAuthenticator}} interface has a {{requireAuthentication}} to indicate
> whether an implementation requires an explicit login. For consistency it
> would be useful for 3rd party implementers if the {{IAuthorizer}} had a
> similar method {{requireAuthorization}} that would indicate if the
> implementation required explicit authorization.
> This would mean that we could remove and explicit {{instanceof}} checks for
> {{AllowAllAuthenticator}} and {{AllowAllAuthorizer}} in the code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
