[jira] [Commented] (CASSANDRA-10897) Avoid building PartitionUpdate in toString()

[Benjamin Lerer (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-10897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15066397#comment-15066397
 ] 

Benjamin Lerer commented on CASSANDRA-10897:


+1

> Avoid building PartitionUpdate in toString()
> 
>
> Key: CASSANDRA-10897
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10897
> Project: Cassandra
>  Issue Type: Bug
>  Components: Coordination
>Reporter: Tyler Hobbs
>Assignee: Tyler Hobbs
>Priority: Minor
> Fix For: 3.0.x, 3.x
>
>
> In {{AbstractBTreePartition.toString()}} (which {{PartitionUpdate}} extends), 
> we iterate over the rows in the partition.  This triggers {{maybeBuild()}} in 
> the {{PartitionUpdate}}.  If the {{PartitionUpdate}} gets updated after the 
> {{toString()}} call, it will result in an {{IllegalStateException}} with the 
> message "An update should not be written again once it has been read".
> As a result, logging or using a debugger can trigger spurious errors, which 
> makes debugging difficult or impossible.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-10897) Avoid building PartitionUpdate in toString()

[Tyler Hobbs (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-10897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15062318#comment-15062318
 ] 

Tyler Hobbs commented on CASSANDRA-10897:
-

Patch and pending CI runs:

||branch||testall||dtest||
|[CASSANDRA-10897|https://github.com/thobbs/cassandra/tree/CASSANDRA-10897]|[testall|http://cassci.datastax.com/view/Dev/view/thobbs/job/thobbs-CASSANDRA-10897-testall]|[dtest|http://cassci.datastax.com/view/Dev/view/thobbs/job/thobbs-CASSANDRA-10897-dtest]|
|[CASSANDRA-10897-trunk|https://github.com/thobbs/cassandra/tree/CASSANDRA-10897-trunk]|[testall|http://cassci.datastax.com/view/Dev/view/thobbs/job/thobbs-CASSANDRA-10897-trunk-testall]|[dtest|http://cassci.datastax.com/view/Dev/view/thobbs/job/thobbs-CASSANDRA-10897-trunk-dtest]|

> Avoid building PartitionUpdate in toString()
> 
>
> Key: CASSANDRA-10897
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10897
> Project: Cassandra
>  Issue Type: Bug
>  Components: Coordination
>Reporter: Tyler Hobbs
>Assignee: Tyler Hobbs
> Fix For: 3.0.x, 3.x
>
>
> In {{AbstractBTreePartition.toString()}} (which {{PartitionUpdate}} extends), 
> we iterate over the rows in the partition.  This triggers {{maybeBuild()}} in 
> the {{PartitionUpdate}}.  If the {{PartitionUpdate}} gets updated after the 
> {{toString()}} call, it will result in an {{IllegalStateException}} with the 
> message "An update should not be written again once it has been read".
> As a result, logging or using a debugger can trigger spurious errors, which 
> makes debugging difficult or impossible.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)