[jira] [Commented] (CASSANDRA-11037) cqlsh bash script cannot be called through symlink
[ https://issues.apache.org/jira/browse/CASSANDRA-11037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15113187#comment-15113187 ] Benjamin Zarzycki commented on CASSANDRA-11037: --- [~carlyeks] That makes way more sense. Thanks for that. :) I updated my github repo and will update the JIRA thread. > cqlsh bash script cannot be called through symlink > -- > > Key: CASSANDRA-11037 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11037 > Project: Cassandra > Issue Type: Bug > Components: Tools > Environment: BASH >Reporter: Benjamin Zarzycki >Priority: Trivial > Labels: lhf > Fix For: 2.2.0 > > Original Estimate: 0h > Remaining Estimate: 0h > > cqlsh bash script cannot be called through a symlink -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-11037) cqlsh bash script cannot be called through symlink
[
https://issues.apache.org/jira/browse/CASSANDRA-11037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15111052#comment-15111052
]
Carl Yeksigian commented on CASSANDRA-11037:
Since we are already requiring that users have python installed, we can do the
same thing with that instead of requiring perl as well:
{noformat}
python "`python -c "import
os;print(os.path.dirname(os.path.realpath('$0')))"`/cqlsh.py" "$@"
{noformat}
WDYT, [~kf6nux]?
> cqlsh bash script cannot be called through symlink
> --
>
> Key: CASSANDRA-11037
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11037
> Project: Cassandra
> Issue Type: Bug
> Components: Tools
> Environment: BASH
>Reporter: Benjamin Zarzycki
>Priority: Trivial
> Labels: lhf
> Fix For: 2.2.0
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> cqlsh bash script cannot be called through a symlink
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-11037) cqlsh bash script cannot be called through symlink
[ https://issues.apache.org/jira/browse/CASSANDRA-11037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15109743#comment-15109743 ] Joshua McKenzie commented on CASSANDRA-11037: - bq. Wouldn't a windows environment be executing the cqlsh.bat file and not the cqlsh bash script? Absolutely. I misread your diff and thought you were changing cqlsh.py (which, in retrospect, would make no sense at all given the change you're talking about). Ignore me and carry on. :) > cqlsh bash script cannot be called through symlink > -- > > Key: CASSANDRA-11037 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11037 > Project: Cassandra > Issue Type: Bug > Components: Tools > Environment: BASH >Reporter: Benjamin Zarzycki >Priority: Trivial > Labels: lhf > Fix For: 2.2.0 > > Original Estimate: 0h > Remaining Estimate: 0h > > cqlsh bash script cannot be called through a symlink -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-11037) cqlsh bash script cannot be called through symlink
[ https://issues.apache.org/jira/browse/CASSANDRA-11037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15109206#comment-15109206 ] Benjamin Zarzycki commented on CASSANDRA-11037: --- [~JoshuaMcKenzie] Wouldn't a windows environment be running the cqlsh.bat file and not the cqlsh bash script? > cqlsh bash script cannot be called through symlink > -- > > Key: CASSANDRA-11037 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11037 > Project: Cassandra > Issue Type: Bug > Components: Tools > Environment: BASH >Reporter: Benjamin Zarzycki >Priority: Trivial > Labels: lhf > Attachments: > 0001-Allows-bash-script-to-be-executed-through-symlinks.patch > > Original Estimate: 0h > Remaining Estimate: 0h > > cqlsh bash script cannot be called through a symlink -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-11037) cqlsh bash script cannot be called through symlink
[ https://issues.apache.org/jira/browse/CASSANDRA-11037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15109180#comment-15109180 ] Joshua McKenzie commented on CASSANDRA-11037: - It's not a safe assumption that perl is going to be installed on a Windows environment, unfortunately. > cqlsh bash script cannot be called through symlink > -- > > Key: CASSANDRA-11037 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11037 > Project: Cassandra > Issue Type: Bug > Components: Tools > Environment: BASH >Reporter: Benjamin Zarzycki >Priority: Trivial > Labels: lhf > Attachments: > 0001-Allows-bash-script-to-be-executed-through-symlinks.patch > > Original Estimate: 0h > Remaining Estimate: 0h > > cqlsh bash script cannot be called through a symlink -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-11037) cqlsh bash script cannot be called through symlink
[ https://issues.apache.org/jira/browse/CASSANDRA-11037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15109146#comment-15109146 ] Benjamin Zarzycki commented on CASSANDRA-11037: --- [~carlyeks] Thanks for the JIRA info and raising the Mac OS compatibility issue. Would be okay to have this script depend on perl? Then we could resolve the cross platform compatibility and symlink issue. Something like: python "$(dirname $(perl -e 'use Cwd "abs_path";print abs_path(shift)' $0))/cqlsh.py" $@" Thoughts? > cqlsh bash script cannot be called through symlink > -- > > Key: CASSANDRA-11037 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11037 > Project: Cassandra > Issue Type: Bug > Components: Tools > Environment: BASH >Reporter: Benjamin Zarzycki >Priority: Trivial > Labels: lhf > Attachments: > 0001-Allows-bash-script-to-be-executed-through-symlinks.patch > > Original Estimate: 0h > Remaining Estimate: 0h > > cqlsh bash script cannot be called through a symlink -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-11037) cqlsh bash script cannot be called through symlink
[
https://issues.apache.org/jira/browse/CASSANDRA-11037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15108688#comment-15108688
]
Carl Yeksigian commented on CASSANDRA-11037:
[~kf6nux]: Thanks for the patch! Unfortunately, this won't work on OS X as
{{readlink}} does not take {{-f}} as an option.
In the Cassandra JIRA, the "Ready to Commit" state is for when the reviewer has
finished looking at the patch and determined that it is ready to be committed;
the state this should have been in was "Patch Available".
> cqlsh bash script cannot be called through symlink
> --
>
> Key: CASSANDRA-11037
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11037
> Project: Cassandra
> Issue Type: Bug
> Components: Tools
> Environment: BASH
>Reporter: Benjamin Zarzycki
>Priority: Trivial
> Labels: easyfix, newbie
> Fix For: 2.2.0
>
> Attachments:
> 0001-Allows-bash-script-to-be-executed-through-symlinks.patch
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> cqlsh bash script cannot be called through a symlink
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-11037) cqlsh bash script cannot be called through symlink
[ https://issues.apache.org/jira/browse/CASSANDRA-11037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15107740#comment-15107740 ] Benjamin Zarzycki commented on CASSANDRA-11037: --- I'm new to JIRA and contributing to Apache Cassandra, so if I did something wrong, please let me know. > cqlsh bash script cannot be called through symlink > -- > > Key: CASSANDRA-11037 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11037 > Project: Cassandra > Issue Type: Bug > Components: Tools > Environment: BASH >Reporter: Benjamin Zarzycki >Priority: Trivial > Labels: easyfix, newbie > Fix For: 2.2.0 > > Attachments: > 0001-Allows-bash-script-to-be-executed-through-symlinks.patch > > Original Estimate: 0h > Remaining Estimate: 0h > > cqlsh bash script cannot be called through a symlink -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-11037) cqlsh bash script cannot be called through symlink
[ https://issues.apache.org/jira/browse/CASSANDRA-11037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15107738#comment-15107738 ] Benjamin Zarzycki commented on CASSANDRA-11037: --- I setup a branch on GitHub with the fix: https://github.com/kf6nux/cassandra/tree/11037-2.2 > cqlsh bash script cannot be called through symlink > -- > > Key: CASSANDRA-11037 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11037 > Project: Cassandra > Issue Type: Bug > Components: Tools > Environment: BASH >Reporter: Benjamin Zarzycki >Priority: Trivial > Attachments: > 0001-Allows-bash-script-to-be-executed-through-symlinks.patch > > Original Estimate: 0h > Remaining Estimate: 0h > > cqlsh bash script cannot be called through a symlink -- This message was sent by Atlassian JIRA (v6.3.4#6332)
