[jira] [Commented] (CASSANDRA-11949) GC log directory should be created in startup scripts
[
https://issues.apache.org/jira/browse/CASSANDRA-11949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15566806#comment-15566806
]
Mahdi Mohammadi commented on CASSANDRA-11949:
-
[~mshuler], [~JoshuaMcKenzie] Shall I close this ticket?
> GC log directory should be created in startup scripts
> -
>
> Key: CASSANDRA-11949
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11949
> Project: Cassandra
> Issue Type: Bug
>Reporter: Joel Knighton
>Assignee: Mahdi Mohammadi
>Priority: Minor
> Fix For: 2.2.x, 3.0.x, 3.x
>
>
> In [CASSANDRA-10140], we enabled GC logging by default, since the overhead
> was low and asking people providing diagnostics to restart can often make it
> more difficult to diagnose problems.
> The default GC log path is set to {{$CASSANDRA_HOME/logs/gc.log}} in
> {{cassandra-env.sh}}, a directory that is not present in a fresh
> clone/install. Even if logback creates this directory later in startup, it is
> not present when the JVM initiates GC logging, so GC logging will silently
> fail for this first Cassandra run
> I haven't tested this in Windows but suspect the same problem may occur.
> Since lots of tooling around Cassandra won't create this directory, we should
> instead consider attempting to create it in our startup scripts.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-11949) GC log directory should be created in startup scripts
[
https://issues.apache.org/jira/browse/CASSANDRA-11949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15407838#comment-15407838
]
Mahdi Mohammadi commented on CASSANDRA-11949:
-
[~mshuler], [~JoshuaMcKenzie] Shall I close this ticket?
> GC log directory should be created in startup scripts
> -
>
> Key: CASSANDRA-11949
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11949
> Project: Cassandra
> Issue Type: Bug
>Reporter: Joel Knighton
>Assignee: Mahdi Mohammadi
>Priority: Minor
> Fix For: 2.2.8, 3.0.9, 3.9
>
>
> In [CASSANDRA-10140], we enabled GC logging by default, since the overhead
> was low and asking people providing diagnostics to restart can often make it
> more difficult to diagnose problems.
> The default GC log path is set to {{$CASSANDRA_HOME/logs/gc.log}} in
> {{cassandra-env.sh}}, a directory that is not present in a fresh
> clone/install. Even if logback creates this directory later in startup, it is
> not present when the JVM initiates GC logging, so GC logging will silently
> fail for this first Cassandra run
> I haven't tested this in Windows but suspect the same problem may occur.
> Since lots of tooling around Cassandra won't create this directory, we should
> instead consider attempting to create it in our startup scripts.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-11949) GC log directory should be created in startup scripts
[
https://issues.apache.org/jira/browse/CASSANDRA-11949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15396442#comment-15396442
]
Michael Shuler commented on CASSANDRA-11949:
It looks like we already fix the gc.log location in deb packages, so I assume
this is OK -
https://github.com/apache/cassandra/blob/trunk/debian/patches/002cassandra_logdir_fix.dpatch
> GC log directory should be created in startup scripts
> -
>
> Key: CASSANDRA-11949
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11949
> Project: Cassandra
> Issue Type: Bug
>Reporter: Joel Knighton
>Assignee: Mahdi Mohammadi
>Priority: Minor
> Fix For: 2.2.8, 3.0.9, 3.9
>
>
> In [CASSANDRA-10140], we enabled GC logging by default, since the overhead
> was low and asking people providing diagnostics to restart can often make it
> more difficult to diagnose problems.
> The default GC log path is set to {{$CASSANDRA_HOME/logs/gc.log}} in
> {{cassandra-env.sh}}, a directory that is not present in a fresh
> clone/install. Even if logback creates this directory later in startup, it is
> not present when the JVM initiates GC logging, so GC logging will silently
> fail for this first Cassandra run
> I haven't tested this in Windows but suspect the same problem may occur.
> Since lots of tooling around Cassandra won't create this directory, we should
> instead consider attempting to create it in our startup scripts.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-11949) GC log directory should be created in startup scripts
[
https://issues.apache.org/jira/browse/CASSANDRA-11949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15396414#comment-15396414
]
Michael Shuler commented on CASSANDRA-11949:
I suppose we could do something like ISC cron does and add the dirs to git with
a placeholder and adjust .gitignore accordingly for running from a git checkout?
{noformat}
(trunk)mshuler@hana:~/git/cassandra$ cat /etc/cron.weekly/.placeholder
# DO NOT EDIT OR REMOVE
# This file is a simple placeholder to keep dpkg from removing this directory
{noformat}
Alternatively, if we only really care about release packages, the artifacts
target in build.xml could create the directories, I would think.
> GC log directory should be created in startup scripts
> -
>
> Key: CASSANDRA-11949
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11949
> Project: Cassandra
> Issue Type: Bug
>Reporter: Joel Knighton
>Assignee: Mahdi Mohammadi
>Priority: Minor
> Fix For: 2.2.8, 3.0.9, 3.9
>
>
> In [CASSANDRA-10140], we enabled GC logging by default, since the overhead
> was low and asking people providing diagnostics to restart can often make it
> more difficult to diagnose problems.
> The default GC log path is set to {{$CASSANDRA_HOME/logs/gc.log}} in
> {{cassandra-env.sh}}, a directory that is not present in a fresh
> clone/install. Even if logback creates this directory later in startup, it is
> not present when the JVM initiates GC logging, so GC logging will silently
> fail for this first Cassandra run
> I haven't tested this in Windows but suspect the same problem may occur.
> Since lots of tooling around Cassandra won't create this directory, we should
> instead consider attempting to create it in our startup scripts.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-11949) GC log directory should be created in startup scripts
[
https://issues.apache.org/jira/browse/CASSANDRA-11949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15396404#comment-15396404
]
Michael Shuler commented on CASSANDRA-11949:
Are we talking about debian packages or the -bin.tar.gz? Both?
The debian packages create the directories here:
https://github.com/apache/cassandra/blob/trunk/debian/dirs
The logs directory is set to /var/log/cassandra, so looking at this:
https://github.com/apache/cassandra/compare/trunk...mm-binary:11949-2.2
..that is incorrect for a deb installation. Logs should not be written to a
directory under $CASSANDRA_HOME (/usr/share/cassandra in deb's case), nor
should a directory be made there by a startup file. This would mean keeping 2
different cassandra-env.sh files, which isn't the end of the world, but
unfortunate.
I think the correct thing to do in the case of debian packages is to write
gc.log to the correct log location, which already exists at deb install time,
not create a new log dir in the wrong location in -env.sh.
> GC log directory should be created in startup scripts
> -
>
> Key: CASSANDRA-11949
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11949
> Project: Cassandra
> Issue Type: Bug
>Reporter: Joel Knighton
>Assignee: Mahdi Mohammadi
>Priority: Minor
> Fix For: 2.2.8, 3.0.9, 3.9
>
>
> In [CASSANDRA-10140], we enabled GC logging by default, since the overhead
> was low and asking people providing diagnostics to restart can often make it
> more difficult to diagnose problems.
> The default GC log path is set to {{$CASSANDRA_HOME/logs/gc.log}} in
> {{cassandra-env.sh}}, a directory that is not present in a fresh
> clone/install. Even if logback creates this directory later in startup, it is
> not present when the JVM initiates GC logging, so GC logging will silently
> fail for this first Cassandra run
> I haven't tested this in Windows but suspect the same problem may occur.
> Since lots of tooling around Cassandra won't create this directory, we should
> instead consider attempting to create it in our startup scripts.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-11949) GC log directory should be created in startup scripts
[
https://issues.apache.org/jira/browse/CASSANDRA-11949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15395952#comment-15395952
]
Joshua McKenzie commented on CASSANDRA-11949:
-
[~mahdix]: After chewing on this issue a bit more, I'm not sure I'm comfortable
with us adding directory creation into our launch scripts. This would put us at
three separate locations responsible for directory creation: launch scripts,
within Java / Daemon itself, and implicitly via the package. I think I'd prefer
that this directory exist in the original archived form of Cassandra's
distribution rather than us creating it programmatically.
[~mshuler]: The data and logs are currently excluded as part of .gitignore (for
obvious reasons). What would it take to get a logs (and data for that matter)
folder created with the C* package when we roll it up as part of our release?
> GC log directory should be created in startup scripts
> -
>
> Key: CASSANDRA-11949
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11949
> Project: Cassandra
> Issue Type: Bug
>Reporter: Joel Knighton
>Assignee: Mahdi Mohammadi
>Priority: Minor
> Fix For: 2.2.8, 3.0.9, 3.9
>
>
> In [CASSANDRA-10140], we enabled GC logging by default, since the overhead
> was low and asking people providing diagnostics to restart can often make it
> more difficult to diagnose problems.
> The default GC log path is set to {{$CASSANDRA_HOME/logs/gc.log}} in
> {{cassandra-env.sh}}, a directory that is not present in a fresh
> clone/install. Even if logback creates this directory later in startup, it is
> not present when the JVM initiates GC logging, so GC logging will silently
> fail for this first Cassandra run
> I haven't tested this in Windows but suspect the same problem may occur.
> Since lots of tooling around Cassandra won't create this directory, we should
> instead consider attempting to create it in our startup scripts.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-11949) GC log directory should be created in startup scripts
[
https://issues.apache.org/jira/browse/CASSANDRA-11949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389777#comment-15389777
]
Mahdi Mohammadi commented on CASSANDRA-11949:
-
[Branch for 2.2+|https://github.com/mm-binary/cassandra/tree/11949-2.2]
> GC log directory should be created in startup scripts
> -
>
> Key: CASSANDRA-11949
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11949
> Project: Cassandra
> Issue Type: Bug
>Reporter: Joel Knighton
>Assignee: Mahdi Mohammadi
>Priority: Minor
> Fix For: 2.2.8, 3.0.9, 3.9
>
>
> In [CASSANDRA-10140], we enabled GC logging by default, since the overhead
> was low and asking people providing diagnostics to restart can often make it
> more difficult to diagnose problems.
> The default GC log path is set to {{$CASSANDRA_HOME/logs/gc.log}} in
> {{cassandra-env.sh}}, a directory that is not present in a fresh
> clone/install. Even if logback creates this directory later in startup, it is
> not present when the JVM initiates GC logging, so GC logging will silently
> fail for this first Cassandra run
> I haven't tested this in Windows but suspect the same problem may occur.
> Since lots of tooling around Cassandra won't create this directory, we should
> instead consider attempting to create it in our startup scripts.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-11949) GC log directory should be created in startup scripts
[
https://issues.apache.org/jira/browse/CASSANDRA-11949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15357927#comment-15357927
]
Mahdi Mohammadi commented on CASSANDRA-11949:
-
Ok. I will fix this.
> GC log directory should be created in startup scripts
> -
>
> Key: CASSANDRA-11949
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11949
> Project: Cassandra
> Issue Type: Bug
>Reporter: Joel Knighton
>Assignee: Mahdi Mohammadi
>Priority: Minor
> Fix For: 2.2.7, 3.0.9, 3.9
>
>
> In [CASSANDRA-10140], we enabled GC logging by default, since the overhead
> was low and asking people providing diagnostics to restart can often make it
> more difficult to diagnose problems.
> The default GC log path is set to {{$CASSANDRA_HOME/logs/gc.log}} in
> {{cassandra-env.sh}}, a directory that is not present in a fresh
> clone/install. Even if logback creates this directory later in startup, it is
> not present when the JVM initiates GC logging, so GC logging will silently
> fail for this first Cassandra run
> I haven't tested this in Windows but suspect the same problem may occur.
> Since lots of tooling around Cassandra won't create this directory, we should
> instead consider attempting to create it in our startup scripts.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-11949) GC log directory should be created in startup scripts
[
https://issues.apache.org/jira/browse/CASSANDRA-11949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15356520#comment-15356520
]
Mahdi Mohammadi commented on CASSANDRA-11949:
-
Thank you.
> GC log directory should be created in startup scripts
> -
>
> Key: CASSANDRA-11949
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11949
> Project: Cassandra
> Issue Type: Bug
>Reporter: Joel Knighton
>Assignee: Mahdi Mohammadi
>Priority: Minor
> Fix For: 2.2.7, 3.0.9, 3.9
>
>
> In [CASSANDRA-10140], we enabled GC logging by default, since the overhead
> was low and asking people providing diagnostics to restart can often make it
> more difficult to diagnose problems.
> The default GC log path is set to {{$CASSANDRA_HOME/logs/gc.log}} in
> {{cassandra-env.sh}}, a directory that is not present in a fresh
> clone/install. Even if logback creates this directory later in startup, it is
> not present when the JVM initiates GC logging, so GC logging will silently
> fail for this first Cassandra run
> I haven't tested this in Windows but suspect the same problem may occur.
> Since lots of tooling around Cassandra won't create this directory, we should
> instead consider attempting to create it in our startup scripts.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-11949) GC log directory should be created in startup scripts
[
https://issues.apache.org/jira/browse/CASSANDRA-11949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353220#comment-15353220
]
Joshua McKenzie commented on CASSANDRA-11949:
-
bq. it requires me to run some command to enable some policy in the PowerShell
console to be able to create the directory
The PowerShell startup scripts require you set your execution policy to
unrestricted. See:
[link|https://technet.microsoft.com/en-us/library/hh847748.aspx]. Theoretically
we could limit the scope of the required security access by using
[Unblock-File|https://technet.microsoft.com/en-us/library/hh849924.aspx], but
then we'd have to swap to RemoteSigned on systems that default to Restricted,
etc. Ultimately, just don't run unknown powershell scripts on the user account
you're using to run C* on Windows and you're in good shape.
> GC log directory should be created in startup scripts
> -
>
> Key: CASSANDRA-11949
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11949
> Project: Cassandra
> Issue Type: Bug
>Reporter: Joel Knighton
>Assignee: Mahdi Mohammadi
>Priority: Minor
>
> In [CASSANDRA-10140], we enabled GC logging by default, since the overhead
> was low and asking people providing diagnostics to restart can often make it
> more difficult to diagnose problems.
> The default GC log path is set to {{$CASSANDRA_HOME/logs/gc.log}} in
> {{cassandra-env.sh}}, a directory that is not present in a fresh
> clone/install. Even if logback creates this directory later in startup, it is
> not present when the JVM initiates GC logging, so GC logging will silently
> fail for this first Cassandra run
> I haven't tested this in Windows but suspect the same problem may occur.
> Since lots of tooling around Cassandra won't create this directory, we should
> instead consider attempting to create it in our startup scripts.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-11949) GC log directory should be created in startup scripts
[
https://issues.apache.org/jira/browse/CASSANDRA-11949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344043#comment-15344043
]
Mahdi Mohammadi commented on CASSANDRA-11949:
-
||2.2||3.0||
|[branch|https://github.com/mm-binary/cassandra/tree/11949-2.2]|[branch|https://github.com/mm-binary/cassandra/tree/11949-3.0]|
> GC log directory should be created in startup scripts
> -
>
> Key: CASSANDRA-11949
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11949
> Project: Cassandra
> Issue Type: Bug
>Reporter: Joel Knighton
>Assignee: Mahdi Mohammadi
>Priority: Minor
>
> In [CASSANDRA-10140], we enabled GC logging by default, since the overhead
> was low and asking people providing diagnostics to restart can often make it
> more difficult to diagnose problems.
> The default GC log path is set to {{$CASSANDRA_HOME/logs/gc.log}} in
> {{cassandra-env.sh}}, a directory that is not present in a fresh
> clone/install. Even if logback creates this directory later in startup, it is
> not present when the JVM initiates GC logging, so GC logging will silently
> fail for this first Cassandra run
> I haven't tested this in Windows but suspect the same problem may occur.
> Since lots of tooling around Cassandra won't create this directory, we should
> instead consider attempting to create it in our startup scripts.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-11949) GC log directory should be created in startup scripts
[
https://issues.apache.org/jira/browse/CASSANDRA-11949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15332627#comment-15332627
]
Mahdi Mohammadi commented on CASSANDRA-11949:
-
Branch: [2.2|https://github.com/mm-binary/cassandra/tree/11949-2.2]
> GC log directory should be created in startup scripts
> -
>
> Key: CASSANDRA-11949
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11949
> Project: Cassandra
> Issue Type: Bug
>Reporter: Joel Knighton
>Assignee: Mahdi Mohammadi
>Priority: Minor
>
> In [CASSANDRA-10140], we enabled GC logging by default, since the overhead
> was low and asking people providing diagnostics to restart can often make it
> more difficult to diagnose problems.
> The default GC log path is set to {{$CASSANDRA_HOME/logs/gc.log}} in
> {{cassandra-env.sh}}, a directory that is not present in a fresh
> clone/install. Even if logback creates this directory later in startup, it is
> not present when the JVM initiates GC logging, so GC logging will silently
> fail for this first Cassandra run
> I haven't tested this in Windows but suspect the same problem may occur.
> Since lots of tooling around Cassandra won't create this directory, we should
> instead consider attempting to create it in our startup scripts.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
