[jira] [Commented] (CASSANDRA-12167) Review JMX metrics test coverage
[ https://issues.apache.org/jira/browse/CASSANDRA-12167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15411987#comment-15411987 ] Philip Thompson commented on CASSANDRA-12167: - Seems reasonable then > Review JMX metrics test coverage > > > Key: CASSANDRA-12167 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12167 > Project: Cassandra > Issue Type: Test >Reporter: Jim Witschey >Assignee: DS Test Eng > Labels: dtest > > I just deleted the dtest that was meant to smoke test JMX metrics: > https://github.com/riptano/cassandra-dtest/pull/1085 > The idea was that you'd read JMX metrics, run stress, then make sure the > metrics went up, down, or stayed the same, as appropriate. This kind of > coverage would be good to have. > I don't think we have it anywhere in the dtests, and it probably isn't > appropriate in unit tests. We should check there's no coverage in the unit > tests, and add some coverage. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12167) Review JMX metrics test coverage
[ https://issues.apache.org/jira/browse/CASSANDRA-12167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15411981#comment-15411981 ] Jim Witschey commented on CASSANDRA-12167: -- Sounds right -- but, I think that the documentation on these was fleshed out much better, which could make it more doable for TE. Thoughts? > Review JMX metrics test coverage > > > Key: CASSANDRA-12167 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12167 > Project: Cassandra > Issue Type: Test >Reporter: Jim Witschey >Assignee: DS Test Eng > Labels: dtest > > I just deleted the dtest that was meant to smoke test JMX metrics: > https://github.com/riptano/cassandra-dtest/pull/1085 > The idea was that you'd read JMX metrics, run stress, then make sure the > metrics went up, down, or stayed the same, as appropriate. This kind of > coverage would be good to have. > I don't think we have it anywhere in the dtests, and it probably isn't > appropriate in unit tests. We should check there's no coverage in the unit > tests, and add some coverage. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12167) Review JMX metrics test coverage
[ https://issues.apache.org/jira/browse/CASSANDRA-12167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15411911#comment-15411911 ] Philip Thompson commented on CASSANDRA-12167: - This was discussed, and we established it would be best for a dev to do this, somewhere far down the line, yeah? > Review JMX metrics test coverage > > > Key: CASSANDRA-12167 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12167 > Project: Cassandra > Issue Type: Test >Reporter: Jim Witschey >Assignee: DS Test Eng > Labels: dtest > > I just deleted the dtest that was meant to smoke test JMX metrics: > https://github.com/riptano/cassandra-dtest/pull/1085 > The idea was that you'd read JMX metrics, run stress, then make sure the > metrics went up, down, or stayed the same, as appropriate. This kind of > coverage would be good to have. > I don't think we have it anywhere in the dtests, and it probably isn't > appropriate in unit tests. We should check there's no coverage in the unit > tests, and add some coverage. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
