[jira] [Commented] (CASSANDRA-12244) progress in compactionstats is reported wrongly for view builds
[
https://issues.apache.org/jira/browse/CASSANDRA-12244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462388#comment-16462388
]
ZhaoYang commented on CASSANDRA-12244:
--
[~michaelsembwever] thanks for the review, looks good to me.
> progress in compactionstats is reported wrongly for view builds
> ---
>
> Key: CASSANDRA-12244
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12244
> Project: Cassandra
> Issue Type: Bug
>Reporter: Tom van der Woerdt
>Assignee: ZhaoYang
>Priority: Minor
> Labels: lhf
> Fix For: 3.0.x
>
>
> In the view build progress given by compactionstats, there are several issues
> :
> {code}
> id compaction type keyspace
> table completed total unit progress
>038d3690-4dbe-11e6-b207-21ec388d48e6View build mykeyspace
> mytable 844 bytes 967 bytes ranges 87.28%
> Active compaction remaining time :n/a
> {code}
> 1) those are ranges, not bytes
> 2) it's not at 87.28%, it's at ~4%. the method for calculating progress in
> Cassandra is wrong: it neglects to sort the tokens it's iterating through
> (ViewBuilder.java) and thus ends up with a random number.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-12244) progress in compactionstats is reported wrongly for view builds
[
https://issues.apache.org/jira/browse/CASSANDRA-12244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462348#comment-16462348
]
mck commented on CASSANDRA-12244:
-
Looking green. Trunk's {{test-all}} is already broken, waiting on
CASSANDRA-14428.
And comparing failed dtests to their respective base branches:
- 3.0: stable {{bootstrap_test.TestBootstrap.test_simultaneous_bootstrap}}
failed, tested locally ok.
- 3.11: no difference.
- trunk: two additional failures:
{{bootstrap_test.TestBootstrap.test_decommissioned_wiped_node_can_join}} and
{{repair_tests.repair_test.TestRepair.test_dc_repair}}; neither are flakey but
both tested locally ok.
> progress in compactionstats is reported wrongly for view builds
> ---
>
> Key: CASSANDRA-12244
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12244
> Project: Cassandra
> Issue Type: Bug
>Reporter: Tom van der Woerdt
>Assignee: ZhaoYang
>Priority: Minor
> Labels: lhf
> Fix For: 3.0.x
>
>
> In the view build progress given by compactionstats, there are several issues
> :
> {code}
> id compaction type keyspace
> table completed total unit progress
>038d3690-4dbe-11e6-b207-21ec388d48e6View build mykeyspace
> mytable 844 bytes 967 bytes ranges 87.28%
> Active compaction remaining time :n/a
> {code}
> 1) those are ranges, not bytes
> 2) it's not at 87.28%, it's at ~4%. the method for calculating progress in
> Cassandra is wrong: it neglects to sort the tokens it's iterating through
> (ViewBuilder.java) and thus ends up with a random number.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-12244) progress in compactionstats is reported wrongly for view builds
[
https://issues.apache.org/jira/browse/CASSANDRA-12244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460524#comment-16460524
]
mck commented on CASSANDRA-12244:
-
Patch looks good. Note in trunk it was fixed in a different manner, but the
clash with the human readable flag was still there so I kept the introduction
of the {{Unit}} enum.
I've put your patch into relevant branches, and will commit once they go green.
In the meantime [~jasonstack], could you please check i've applied your patch
appropriately in each branch and commit.
|| Branch || uTest || dTest ||
|[cassandra-3.0_12244|https://github.com/thelastpickle/cassandra/tree/mck/cassandra-3.0_12244]|[!https://circleci.com/gh/thelastpickle/cassandra/tree/mck%2Fcassandra-3.0_12244.svg?style=svg!|https://circleci.com/gh/thelastpickle/cassandra/tree/mck%2Fcassandra-3.0_12244]|
https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/540/
|
|[cassandra-3.11_12244|https://github.com/thelastpickle/cassandra/tree/mck/cassandra-3.11_12244]|[!https://circleci.com/gh/thelastpickle/cassandra/tree/mck%2Fcassandra-3.11_12244.svg?style=svg!|https://circleci.com/gh/thelastpickle/cassandra/tree/mck%2Fcassandra-3.11_12244]|
https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/541/
|
|[trunk_12244|https://github.com/thelastpickle/cassandra/tree/mck/trunk_12244]|[!https://circleci.com/gh/thelastpickle/cassandra/tree/mck%2Ftrunk_12244.svg?style=svg!|https://circleci.com/gh/thelastpickle/cassandra/tree/mck%2Ftrunk_12244]|
https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/541/
|
> progress in compactionstats is reported wrongly for view builds
> ---
>
> Key: CASSANDRA-12244
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12244
> Project: Cassandra
> Issue Type: Bug
>Reporter: Tom van der Woerdt
>Assignee: ZhaoYang
>Priority: Minor
> Labels: lhf
> Fix For: 3.0.x
>
>
> In the view build progress given by compactionstats, there are several issues
> :
> {code}
> id compaction type keyspace
> table completed total unit progress
>038d3690-4dbe-11e6-b207-21ec388d48e6View build mykeyspace
> mytable 844 bytes 967 bytes ranges 87.28%
> Active compaction remaining time :n/a
> {code}
> 1) those are ranges, not bytes
> 2) it's not at 87.28%, it's at ~4%. the method for calculating progress in
> Cassandra is wrong: it neglects to sort the tokens it's iterating through
> (ViewBuilder.java) and thus ends up with a random number.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-12244) progress in compactionstats is reported wrongly for view builds
[
https://issues.apache.org/jira/browse/CASSANDRA-12244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15857910#comment-15857910
]
Sylvain Lebresne commented on CASSANDRA-12244:
--
Sorry, I know I encouraged the submission of a patch here but that's not the
part of the code I know the best and I'm a bit swamped right now so I'm gonna
leave the review to someone else.
> progress in compactionstats is reported wrongly for view builds
> ---
>
> Key: CASSANDRA-12244
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12244
> Project: Cassandra
> Issue Type: Bug
>Reporter: Tom van der Woerdt
>Assignee: ZhaoYang
>Priority: Minor
> Labels: lhf
> Fix For: 3.0.9
>
>
> In the view build progress given by compactionstats, there are several issues
> :
> {code}
> id compaction type keyspace
> table completed total unit progress
>038d3690-4dbe-11e6-b207-21ec388d48e6View build mykeyspace
> mytable 844 bytes 967 bytes ranges 87.28%
> Active compaction remaining time :n/a
> {code}
> 1) those are ranges, not bytes
> 2) it's not at 87.28%, it's at ~4%. the method for calculating progress in
> Cassandra is wrong: it neglects to sort the tokens it's iterating through
> (ViewBuilder.java) and thus ends up with a random number.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (CASSANDRA-12244) progress in compactionstats is reported wrongly for view builds
[
https://issues.apache.org/jira/browse/CASSANDRA-12244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15659573#comment-15659573
]
ZhaoYang commented on CASSANDRA-12244:
--
[~muru] thanks for the comments. I updated the commit:
https://github.com/jasonstack/cassandra/commit/4339a960fe9cd2b42dc80192570d39287d6c9157
> progress in compactionstats is reported wrongly for view builds
> ---
>
> Key: CASSANDRA-12244
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12244
> Project: Cassandra
> Issue Type: Bug
>Reporter: Tom van der Woerdt
>Assignee: ZhaoYang
>Priority: Minor
> Labels: lhf
> Fix For: 3.0.9
>
>
> In the view build progress given by compactionstats, there are several issues
> :
> {code}
> id compaction type keyspace
> table completed total unit progress
>038d3690-4dbe-11e6-b207-21ec388d48e6View build mykeyspace
> mytable 844 bytes 967 bytes ranges 87.28%
> Active compaction remaining time :n/a
> {code}
> 1) those are ranges, not bytes
> 2) it's not at 87.28%, it's at ~4%. the method for calculating progress in
> Cassandra is wrong: it neglects to sort the tokens it's iterating through
> (ViewBuilder.java) and thus ends up with a random number.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12244) progress in compactionstats is reported wrongly for view builds
[
https://issues.apache.org/jira/browse/CASSANDRA-12244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15656122#comment-15656122
]
Murukesh Mohanan commented on CASSANDRA-12244:
--
[~jasonstack] IMHO the ranges don't need to be sorted. You could do something
like:
{code}
for (Range range :
StorageService.instance.getLocalRanges(baseCfs.keyspace.getName()))
{
rangesTotal++;
// Each range whose right boundary (largest value) is less than the
lastToken can be considered as seen
// by the node.
if ((lastToken != null) && lastToken.compareTo(range.right) > 0)
rangesCompleted++;
}
{code}
Making a collection and sorting it is a waste when you need to iterate over the
ranges only once.
> progress in compactionstats is reported wrongly for view builds
> ---
>
> Key: CASSANDRA-12244
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12244
> Project: Cassandra
> Issue Type: Bug
>Reporter: Tom van der Woerdt
>Assignee: ZhaoYang
>Priority: Minor
> Labels: lhf
> Fix For: 3.0.9
>
>
> In the view build progress given by compactionstats, there are several issues
> :
> {code}
> id compaction type keyspace
> table completed total unit progress
>038d3690-4dbe-11e6-b207-21ec388d48e6View build mykeyspace
> mytable 844 bytes 967 bytes ranges 87.28%
> Active compaction remaining time :n/a
> {code}
> 1) those are ranges, not bytes
> 2) it's not at 87.28%, it's at ~4%. the method for calculating progress in
> Cassandra is wrong: it neglects to sort the tokens it's iterating through
> (ViewBuilder.java) and thus ends up with a random number.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12244) progress in compactionstats is reported wrongly for view builds
[
https://issues.apache.org/jira/browse/CASSANDRA-12244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389603#comment-15389603
]
Sylvain Lebresne commented on CASSANDRA-12244:
--
Sounds wrong indeed. Wants to give a short a patch by any chance?
> progress in compactionstats is reported wrongly for view builds
> ---
>
> Key: CASSANDRA-12244
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12244
> Project: Cassandra
> Issue Type: Bug
>Reporter: Tom van der Woerdt
>Priority: Minor
> Labels: lhf
>
> In the view build progress given by compactionstats, there are several issues
> :
> {code}
> id compaction type keyspace
> table completed total unit progress
>038d3690-4dbe-11e6-b207-21ec388d48e6View build mykeyspace
> mytable 844 bytes 967 bytes ranges 87.28%
> Active compaction remaining time :n/a
> {code}
> 1) those are ranges, not bytes
> 2) it's not at 87.28%, it's at ~4%. the method for calculating progress in
> Cassandra is wrong: it neglects to sort the tokens it's iterating through
> (ViewBuilder.java) and thus ends up with a random number.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
