[jira] [Commented] (CASSANDRA-12273) Casandra stress graph: option to create directory for graph if it doesn't exist

[Joel Knighton (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-12273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15654367#comment-15654367
 ] 

Joel Knighton commented on CASSANDRA-12273:
---

Very, very close - the only change is that the ticket number is included at the 
end of the patch by ...; reviewed by ... line, like "patch by Murukesh Mohanan; 
reviewed by Joel Knighton for CASSANDRA-12273" instead of including it at the 
end of the commit message.

{code}
Create log directories as needed, handling symbolic links

patch by Murukesh Mohanan; reviewed by Joel Knighton for CASSANDRA-12273
{code}

> Casandra stress graph: option to create directory for graph if it doesn't 
> exist
> ---
>
> Key: CASSANDRA-12273
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12273
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Tools
>Reporter: Christopher Batey
>Assignee: Murukesh Mohanan
>Priority: Minor
>  Labels: lhf
> Attachments: 12273.patch
>
>
> I am running it in CI with ephemeral workspace  / build dirs. It would be 
> nice if CS would create the directory so my build tool doesn't have to



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-12273) Casandra stress graph: option to create directory for graph if it doesn't exist

[Murukesh Mohanan (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-12273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15652591#comment-15652591
 ] 

Murukesh Mohanan commented on CASSANDRA-12273:
--

[~jkni], I'd be happy to look into the {{hdrfile}} thing. Just to confirm, the 
file to be attached would look like:

{code}
>From b98e9b4de506fd0b344d9aaf4cb380651a0a68a0 Mon Sep 17 00:00:00 2001
From: Murukesh Mohanan 
Date: Thu, 10 Nov 2016 09:58:34 +0900
Subject: [PATCH] Create log directories as needed, handling symbolic links
 (CASSANDRA-12273)

patch by Murukesh Mohanan; reviewed by Joel Knighton
---
 CHANGES.txt |  1 +
 .../stress/src/org/apache/cassandra/stress/StressGraph.java | 13 +
 2 files changed, 14 insertions(+)

diff --git a/CHANGES.txt b/CHANGES.txt
index 69a05c2..ac2e9c3 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
 4.0
+ * Create log directories as needed, handling symbolic links (CASSANDRA-12273)
  * Add column definition kind to dropped columns in schema (CASSANDRA-12705)
  * Add (automate) Nodetool Documentation (CASSANDRA-12672)
  * Update bundled cqlsh python driver to 3.7.0 (CASSANDRA-12736)
diff --git a/tools/stress/src/org/apache/cassandra/stress/StressGraph.java 
b/tools/stress/src/org/apache/cassandra/stress/StressGraph.java
index 17b718d..a4d9744 100644
...
{code}

> Casandra stress graph: option to create directory for graph if it doesn't 
> exist
> ---
>
> Key: CASSANDRA-12273
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12273
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Tools
>Reporter: Christopher Batey
>Assignee: Murukesh Mohanan
>Priority: Minor
>  Labels: lhf
> Attachments: 12273.patch
>
>
> I am running it in CI with ephemeral workspace  / build dirs. It would be 
> nice if CS would create the directory so my build tool doesn't have to



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)