[jira] [Commented] (CASSANDRA-12585) Fixup Cassandra Stress reporting thread model and precision
[ https://issues.apache.org/jira/browse/CASSANDRA-12585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15470171#comment-15470171 ] Nitsan Wakart commented on CASSANDRA-12585: --- updated to use latest release > Fixup Cassandra Stress reporting thread model and precision > --- > > Key: CASSANDRA-12585 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12585 > Project: Cassandra > Issue Type: Improvement > Components: Tools >Reporter: Nitsan Wakart >Assignee: Nitsan Wakart >Priority: Minor > Labels: stress > > Stress current reporting thread currently has a complex, slow and imprecise > method of collecting measurements from the Consumer threads. > StressMetrics thread iterates through the Timers (one Timer per op per > Consumer thread), blocks until the consumer thread collects a measurement on > that operation, which forces the consumer thread to collect a report and > unblock the StressMetrics thread. This means: > - Reporting intervals are effected by sleep interval accuracy on the > StressMetrics thread > - Interval report timing is staggered as the operations get collected. > - The intended logging interval often does not resemble the effective > interval. > This patch simplifies collection method and resolves the above issues: > - Each Consumer thread submits timing data to a queue > - StressMetrics thread reads from the queues and merges the data into a report > - StressMetrics reads and reports for the intended interval, so not effected > by timing inaccuracies > - Measurement intervals are aligned to the second, improving the ease of > measurements correlation from several nodes. > See branch here: > https://github.com/nitsanw/cassandra/tree/fix-reporting-sync-issues -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12585) Fixup Cassandra Stress reporting thread model and precision
[ https://issues.apache.org/jira/browse/CASSANDRA-12585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15467824#comment-15467824 ] T Jake Luciani commented on CASSANDRA-12585: [~nitsanw] is jctools snapshot needed? We need a released version to add it to the maven pom > Fixup Cassandra Stress reporting thread model and precision > --- > > Key: CASSANDRA-12585 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12585 > Project: Cassandra > Issue Type: Improvement > Components: Tools >Reporter: Nitsan Wakart >Assignee: Nitsan Wakart >Priority: Minor > Labels: stress > > Stress current reporting thread currently has a complex, slow and imprecise > method of collecting measurements from the Consumer threads. > StressMetrics thread iterates through the Timers (one Timer per op per > Consumer thread), blocks until the consumer thread collects a measurement on > that operation, which forces the consumer thread to collect a report and > unblock the StressMetrics thread. This means: > - Reporting intervals are effected by sleep interval accuracy on the > StressMetrics thread > - Interval report timing is staggered as the operations get collected. > - The intended logging interval often does not resemble the effective > interval. > This patch simplifies collection method and resolves the above issues: > - Each Consumer thread submits timing data to a queue > - StressMetrics thread reads from the queues and merges the data into a report > - StressMetrics reads and reports for the intended interval, so not effected > by timing inaccuracies > - Measurement intervals are aligned to the second, improving the ease of > measurements correlation from several nodes. > See branch here: > https://github.com/nitsanw/cassandra/tree/fix-reporting-sync-issues -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12585) Fixup Cassandra Stress reporting thread model and precision
[ https://issues.apache.org/jira/browse/CASSANDRA-12585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15467509#comment-15467509 ] T Jake Luciani commented on CASSANDRA-12585: [testall|http://cassci.datastax.com/view/Dev/view/tjake/job/tjake-fix-reporting-sync-issues-testall] [dtests|http://cassci.datastax.com/view/Dev/view/tjake/job/tjake-fix-reporting-sync-issues-dtest] > Fixup Cassandra Stress reporting thread model and precision > --- > > Key: CASSANDRA-12585 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12585 > Project: Cassandra > Issue Type: Improvement > Components: Tools >Reporter: Nitsan Wakart >Assignee: Nitsan Wakart >Priority: Minor > Labels: stress > > Stress current reporting thread currently has a complex, slow and imprecise > method of collecting measurements from the Consumer threads. > StressMetrics thread iterates through the Timers (one Timer per op per > Consumer thread), blocks until the consumer thread collects a measurement on > that operation, which forces the consumer thread to collect a report and > unblock the StressMetrics thread. This means: > - Reporting intervals are effected by sleep interval accuracy on the > StressMetrics thread > - Interval report timing is staggered as the operations get collected. > - The intended logging interval often does not resemble the effective > interval. > This patch simplifies collection method and resolves the above issues: > - Each Consumer thread submits timing data to a queue > - StressMetrics thread reads from the queues and merges the data into a report > - StressMetrics reads and reports for the intended interval, so not effected > by timing inaccuracies > - Measurement intervals are aligned to the second, improving the ease of > measurements correlation from several nodes. > See branch here: > https://github.com/nitsanw/cassandra/tree/fix-reporting-sync-issues -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12585) Fixup Cassandra Stress reporting thread model and precision
[ https://issues.apache.org/jira/browse/CASSANDRA-12585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15465090#comment-15465090 ] Christopher Batey commented on CASSANDRA-12585: --- I'll aim to review this week unless you get to it first [~tjake] > Fixup Cassandra Stress reporting thread model and precision > --- > > Key: CASSANDRA-12585 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12585 > Project: Cassandra > Issue Type: Improvement > Components: Tools >Reporter: Nitsan Wakart >Assignee: Nitsan Wakart >Priority: Minor > Labels: stress > > Stress current reporting thread currently has a complex, slow and imprecise > method of collecting measurements from the Consumer threads. > StressMetrics thread iterates through the Timers (one Timer per op per > Consumer thread), blocks until the consumer thread collects a measurement on > that operation, which forces the consumer thread to collect a report and > unblock the StressMetrics thread. This means: > - Reporting intervals are effected by sleep interval accuracy on the > StressMetrics thread > - Interval report timing is staggered as the operations get collected. > - The intended logging interval often does not resemble the effective > interval. > This patch simplifies collection method and resolves the above issues: > - Each Consumer thread submits timing data to a queue > - StressMetrics thread reads from the queues and merges the data into a report > - StressMetrics reads and reports for the intended interval, so not effected > by timing inaccuracies > - Measurement intervals are aligned to the second, improving the ease of > measurements correlation from several nodes. > See branch here: > https://github.com/nitsanw/cassandra/tree/fix-reporting-sync-issues -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12585) Fixup Cassandra Stress reporting thread model and precision
[ https://issues.apache.org/jira/browse/CASSANDRA-12585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15464763#comment-15464763 ] Nitsan Wakart commented on CASSANDRA-12585: --- Please let me know of any issues blocking this patch > Fixup Cassandra Stress reporting thread model and precision > --- > > Key: CASSANDRA-12585 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12585 > Project: Cassandra > Issue Type: Improvement > Components: Tools >Reporter: Nitsan Wakart >Assignee: Nitsan Wakart >Priority: Minor > Labels: stress > > Stress current reporting thread currently has a complex, slow and imprecise > method of collecting measurements from the Consumer threads. > StressMetrics thread iterates through the Timers (one Timer per op per > Consumer thread), blocks until the consumer thread collects a measurement on > that operation, which forces the consumer thread to collect a report and > unblock the StressMetrics thread. This means: > - Reporting intervals are effected by sleep interval accuracy on the > StressMetrics thread > - Interval report timing is staggered as the operations get collected. > - The intended logging interval often does not resemble the effective > interval. > This patch simplifies collection method and resolves the above issues: > - Each Consumer thread submits timing data to a queue > - StressMetrics thread reads from the queues and merges the data into a report > - StressMetrics reads and reports for the intended interval, so not effected > by timing inaccuracies > - Measurement intervals are aligned to the second, improving the ease of > measurements correlation from several nodes. > See branch here: > https://github.com/nitsanw/cassandra/tree/fix-reporting-sync-issues -- This message was sent by Atlassian JIRA (v6.3.4#6332)
