[jira] [Commented] (CASSANDRA-12661) Make gc_log and gc_warn settable at runtime
[
https://issues.apache.org/jira/browse/CASSANDRA-12661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15969206#comment-15969206
]
Blake Eggleston commented on CASSANDRA-12661:
-
Committed test and misc style fixes as
{{8a6fc4e2ac8012ae2d3e4abf6c6502cbeda5159c}}.
> Make gc_log and gc_warn settable at runtime
> ---
>
> Key: CASSANDRA-12661
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12661
> Project: Cassandra
> Issue Type: New Feature
>Reporter: Edward Capriolo
>Assignee: Edward Capriolo
>Priority: Minor
> Attachments: Screen Shot 2017-04-12 at 11.38.06 AM.png
>
>
> Changes:
> * Move gc_log_threshold_in_ms and gc_warn_threshold_in_ms close together in
> the config
> * rename variables to match properties
> * add unit tests to ensure hybration
> * add unit tests to ensure variables are set propertly
> * minor perf (do not consturct string from buffer f not logging)
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (CASSANDRA-12661) Make gc_log and gc_warn settable at runtime
[ https://issues.apache.org/jira/browse/CASSANDRA-12661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1591#comment-1591 ] Edward Capriolo commented on CASSANDRA-12661: - That change makes sense volatile needs to stay to be set for JMX but in static cases we are sometimes getting values from other test runs I guess. Any of the other open comments I can address let me know. > Make gc_log and gc_warn settable at runtime > --- > > Key: CASSANDRA-12661 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12661 > Project: Cassandra > Issue Type: New Feature >Reporter: Edward Capriolo >Assignee: Edward Capriolo >Priority: Minor > Attachments: Screen Shot 2017-04-12 at 11.38.06 AM.png > > > Changes: > * Move gc_log_threshold_in_ms and gc_warn_threshold_in_ms close together in > the config > * rename variables to match properties > * add unit tests to ensure hybration > * add unit tests to ensure variables are set propertly > * minor perf (do not consturct string from buffer f not logging) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CASSANDRA-12661) Make gc_log and gc_warn settable at runtime
[ https://issues.apache.org/jira/browse/CASSANDRA-12661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15966621#comment-15966621 ] Blake Eggleston commented on CASSANDRA-12661: - [~appodictic], I’ve fixed the broken test and pulled in your style fixes [here|https://github.com/bdeggleston/cassandra/commits/12661-fix], and started a utest run [here|https://circleci.com/gh/bdeggleston/cassandra/5]. Assuming the tests pass and you're ok with the fix, we can commit that and re-close. Any other changes should get their own jira. Sorry for committing a broken test. > Make gc_log and gc_warn settable at runtime > --- > > Key: CASSANDRA-12661 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12661 > Project: Cassandra > Issue Type: New Feature >Reporter: Edward Capriolo >Assignee: Edward Capriolo >Priority: Minor > Attachments: Screen Shot 2017-04-12 at 11.38.06 AM.png > > > Changes: > * Move gc_log_threshold_in_ms and gc_warn_threshold_in_ms close together in > the config > * rename variables to match properties > * add unit tests to ensure hybration > * add unit tests to ensure variables are set propertly > * minor perf (do not consturct string from buffer f not logging) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CASSANDRA-12661) Make gc_log and gc_warn settable at runtime
[ https://issues.apache.org/jira/browse/CASSANDRA-12661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15966287#comment-15966287 ] Edward Capriolo commented on CASSANDRA-12661: - [~krummas] I was under the impression using annotation OrderedTestRunner addressed this and that the tests would run in the same order. But I agree I we can probably avoid the copy. > Make gc_log and gc_warn settable at runtime > --- > > Key: CASSANDRA-12661 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12661 > Project: Cassandra > Issue Type: New Feature >Reporter: Edward Capriolo >Assignee: Edward Capriolo >Priority: Minor > Attachments: Screen Shot 2017-04-12 at 11.38.06 AM.png > > > Changes: > * Move gc_log_threshold_in_ms and gc_warn_threshold_in_ms close together in > the config > * rename variables to match properties > * add unit tests to ensure hybration > * add unit tests to ensure variables are set propertly > * minor perf (do not consturct string from buffer f not logging) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CASSANDRA-12661) Make gc_log and gc_warn settable at runtime
[ https://issues.apache.org/jira/browse/CASSANDRA-12661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15966273#comment-15966273 ] Marcus Eriksson commented on CASSANDRA-12661: - The problem is the order tests are run in, you change the static members of GCInspector in one test, even if you create a new instance, those static members will have the same value > Make gc_log and gc_warn settable at runtime > --- > > Key: CASSANDRA-12661 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12661 > Project: Cassandra > Issue Type: New Feature >Reporter: Edward Capriolo >Assignee: Edward Capriolo >Priority: Minor > Attachments: Screen Shot 2017-04-12 at 11.38.06 AM.png > > > Changes: > * Move gc_log_threshold_in_ms and gc_warn_threshold_in_ms close together in > the config > * rename variables to match properties > * add unit tests to ensure hybration > * add unit tests to ensure variables are set propertly > * minor perf (do not consturct string from buffer f not logging) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CASSANDRA-12661) Make gc_log and gc_warn settable at runtime
[ https://issues.apache.org/jira/browse/CASSANDRA-12661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15966209#comment-15966209 ] Edward Capriolo commented on CASSANDRA-12661: - What order does OrderedJunitRunner run things in? > Make gc_log and gc_warn settable at runtime > --- > > Key: CASSANDRA-12661 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12661 > Project: Cassandra > Issue Type: New Feature >Reporter: Edward Capriolo >Assignee: Edward Capriolo >Priority: Minor > Attachments: Screen Shot 2017-04-12 at 11.38.06 AM.png > > > Changes: > * Move gc_log_threshold_in_ms and gc_warn_threshold_in_ms close together in > the config > * rename variables to match properties > * add unit tests to ensure hybration > * add unit tests to ensure variables are set propertly > * minor perf (do not consturct string from buffer f not logging) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CASSANDRA-12661) Make gc_log and gc_warn settable at runtime
[ https://issues.apache.org/jira/browse/CASSANDRA-12661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15966202#comment-15966202 ] Edward Capriolo commented on CASSANDRA-12661: - It seems to be some type of singleton/race/test infra issue. Probably could re-write that test another way (with static values). > Make gc_log and gc_warn settable at runtime > --- > > Key: CASSANDRA-12661 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12661 > Project: Cassandra > Issue Type: New Feature >Reporter: Edward Capriolo >Assignee: Edward Capriolo >Priority: Minor > Attachments: Screen Shot 2017-04-12 at 11.38.06 AM.png > > > Changes: > * Move gc_log_threshold_in_ms and gc_warn_threshold_in_ms close together in > the config > * rename variables to match properties > * add unit tests to ensure hybration > * add unit tests to ensure variables are set propertly > * minor perf (do not consturct string from buffer f not logging) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CASSANDRA-12661) Make gc_log and gc_warn settable at runtime
[ https://issues.apache.org/jira/browse/CASSANDRA-12661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15966174#comment-15966174 ] Edward Capriolo commented on CASSANDRA-12661: - EdwardCrioloMBP:cassandra ecapriolo$ ant test -Dtest.name=GCInspectorTest | grep 'Tests run' [junit] Testsuite: org.apache.cassandra.service.GCInspectorTest Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.837 sec (after my latest patch) > Make gc_log and gc_warn settable at runtime > --- > > Key: CASSANDRA-12661 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12661 > Project: Cassandra > Issue Type: New Feature >Reporter: Edward Capriolo >Assignee: Edward Capriolo >Priority: Minor > Attachments: Screen Shot 2017-04-12 at 11.38.06 AM.png > > > Changes: > * Move gc_log_threshold_in_ms and gc_warn_threshold_in_ms close together in > the config > * rename variables to match properties > * add unit tests to ensure hybration > * add unit tests to ensure variables are set propertly > * minor perf (do not consturct string from buffer f not logging) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CASSANDRA-12661) Make gc_log and gc_warn settable at runtime
[
https://issues.apache.org/jira/browse/CASSANDRA-12661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15966168#comment-15966168
]
Michael Shuler commented on CASSANDRA-12661:
[~appodictic] that didn't even run the test. Try:
{noformat}
(trunk)mshuler@hana:~/git/cassandra$ ant test -Dtest.name=GCInspectorTest
Buildfile: /home/mshuler/git/cassandra/build.xml
<...>
test:
[mkdir] Created dir: /home/mshuler/git/cassandra/build/test/cassandra
[mkdir] Created dir: /home/mshuler/git/cassandra/build/test/output
[junit] Testsuite: org.apache.cassandra.service.GCInspectorTest
[junit] Testsuite: org.apache.cassandra.service.GCInspectorTest Tests run:
5, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.484 sec
[junit]
[junit] - Standard Output ---
[junit] ERROR [main] 2017-04-12 11:26:14,308 SubstituteLogger.java:250 -
SLF4J: stderr
[junit] INFO [main] 2017-04-12 11:26:14,495
YamlConfigurationLoader.java:89 - Configuration location:
file:/home/mshuler/git/cassandra/test/conf/cassandra.yaml
[junit] DEBUG [main] 2017-04-12 11:26:14,497
YamlConfigurationLoader.java:108 - Loading settings from
file:/home/mshuler/git/cassandra/test/conf/cassandra.yaml
[junit] INFO [main] 2017-04-12 11:26:14,967 Config.java:454 - Node
configuration:[allocate_tokens_for_keyspace=null; authenticator=null;
authorizer=null; auto_bootstrap=true; auto_snapshot=true;
back_pressure_enabled=false; back_pressure_strategy=null;
batch_size_fail_threshold_in_kb=50; batch_size_warn_threshold_in_kb=5;
batchlog_replay_throttle_in_kb=1024; broadcast_address=null;
broadcast_rpc_address=null; buffer_pool_use_heap_if_exhausted=true;
cas_contention_timeout_in_ms=1000; cdc_enabled=false;
cdc_free_space_check_interval_ms=250;
cdc_raw_directory=build/test/cassandra/cdc_raw:0; cdc_total_space_in_mb=0;
client_encryption_options=; cluster_name=Test Cluster;
column_index_cache_size_in_kb=2; column_index_size_in_kb=4;
commit_failure_policy=stop; commitlog_compression=null;
commitlog_directory=build/test/cassandra/commitlog:0;
commitlog_max_compression_buffers_in_pool=3; commitlog_periodic_queue_size=-1;
commitlog_segment_size_in_mb=5; commitlog_sync=batch;
commitlog_sync_batch_window_in_ms=1.0; commitlog_sync_period_in_ms=0;
commitlog_total_space_in_mb=null;
compaction_large_partition_warning_threshold_mb=100;
compaction_throughput_mb_per_sec=0; concurrent_compactors=4;
concurrent_counter_writes=32; concurrent_materialized_view_writes=32;
concurrent_reads=32; concurrent_replicates=null; concurrent_writes=32;
counter_cache_keys_to_save=2147483647; counter_cache_save_period=7200;
counter_cache_size_in_mb=null; counter_write_request_timeout_in_ms=5000;
credentials_cache_max_entries=1000; credentials_update_interval_in_ms=-1;
credentials_validity_in_ms=2000; cross_node_timeout=false;
data_file_directories=[Ljava.lang.String;@175c2241; disk_access_mode=mmap;
disk_failure_policy=ignore; disk_optimization_estimate_percentile=0.95;
disk_optimization_page_cross_chance=0.1; disk_optimization_strategy=ssd;
dynamic_snitch=true; dynamic_snitch_badness_threshold=0.1;
dynamic_snitch_reset_interval_in_ms=60;
dynamic_snitch_update_interval_in_ms=100;
enable_scripted_user_defined_functions=true;
enable_user_defined_functions=true; enable_user_defined_functions_threads=true;
encryption_options=null;
endpoint_snitch=org.apache.cassandra.locator.SimpleSnitch;
file_cache_size_in_mb=null; gc_log_threshold_in_ms=200;
gc_warn_threshold_in_ms=1000; hinted_handoff_disabled_datacenters=[];
hinted_handoff_enabled=true; hinted_handoff_throttle_in_kb=1024;
hints_compression=null; hints_directory=build/test/cassandra/hints:0;
hints_flush_period_in_ms=1; ideal_consistency_level=null;
incremental_backups=true; index_summary_capacity_in_mb=null;
index_summary_resize_interval_in_minutes=60; initial_token=null;
inter_dc_stream_throughput_outbound_megabits_per_sec=200;
inter_dc_tcp_nodelay=true; internode_authenticator=null;
internode_compression=none; internode_recv_buff_size_in_bytes=0;
internode_send_buff_size_in_bytes=0; key_cache_keys_to_save=2147483647;
key_cache_save_period=14400; key_cache_size_in_mb=null;
listen_address=127.0.0.1; listen_interface=null;
listen_interface_prefer_ipv6=false; listen_on_broadcast_address=false;
max_hint_window_in_ms=1080; max_hints_delivery_threads=2;
max_hints_file_size_in_mb=128; max_mutation_size_in_kb=null;
max_streaming_retries=3; max_value_size_in_mb=256;
memtable_allocation_type=offheap_objects; memtable_cleanup_threshold=null;
memtable_flush_writers=0; memtable_heap_space_in_mb=null;
memtable_offheap_space_in_mb=null; min_free_space_per_drive_in_mb=50;
native_transport_max_concurrent_connections=-1;
native_transport_max_concurrent_connections_per_ip=-1;
native_transport_max_frame_size_in_mb=256;
[jira] [Commented] (CASSANDRA-12661) Make gc_log and gc_warn settable at runtime
[
https://issues.apache.org/jira/browse/CASSANDRA-12661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15966159#comment-15966159
]
Edward Capriolo commented on CASSANDRA-12661:
-
I pushed some of the changes requested here:
https://github.com/apache/cassandra/compare/trunk...edwardcapriolo:CASSANDRA-12661-2?expand=1
I do not quite understand the defect causing the test failures. Side effect or
stale file?
{quote}
due to the checks in the implementation, the order of calls to
setGcLogThresholdInMs + setGcWarnThresholdInMs depend on the current values,
which should not be the case. this could be changed by having just one method
that changes both values.
{quote}
That surely reduces the bounds check logic. I would rather understand first why
I can not reproduce the test failure. If the approach of setting individually
is fundamentally flawed I suggest rolling this back.
> Make gc_log and gc_warn settable at runtime
> ---
>
> Key: CASSANDRA-12661
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12661
> Project: Cassandra
> Issue Type: New Feature
>Reporter: Edward Capriolo
>Assignee: Edward Capriolo
>Priority: Minor
> Attachments: Screen Shot 2017-04-12 at 11.38.06 AM.png
>
>
> Changes:
> * Move gc_log_threshold_in_ms and gc_warn_threshold_in_ms close together in
> the config
> * rename variables to match properties
> * add unit tests to ensure hybration
> * add unit tests to ensure variables are set propertly
> * minor perf (do not consturct string from buffer f not logging)
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (CASSANDRA-12661) Make gc_log and gc_warn settable at runtime
[
https://issues.apache.org/jira/browse/CASSANDRA-12661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15966130#comment-15966130
]
Edward Capriolo commented on CASSANDRA-12661:
-
{noformat}
Total time: 3 seconds
EdwardCrioloMBP:cassandra ecapriolo$ ant test -Dtest.name
org.apache.cassandra.service.GCInspectorTest | tail -10
build-test:
test:
[junitreport] Processing
/Users/ecapriolo/Documents/cassandra/build/test/TESTS-TestSuites.xml to
/var/folders/cn/23mx693j06n69_cl6v1sq0n1km8flm/T/null661334097
[junitreport] Loading stylesheet
jar:file:/usr/local/Cellar/ant/1.10.1/libexec/lib/ant-junit.jar!/org/apache/tools/ant/taskdefs/optional/junit/xsl/junit-frames.xsl
[junitreport] Transform time: 661ms
[junitreport] Deleting:
/var/folders/cn/23mx693j06n69_cl6v1sq0n1km8flm/T/null661334097
BUILD SUCCESSFUL
Total time: 3 seconds
{noformat}
> Make gc_log and gc_warn settable at runtime
> ---
>
> Key: CASSANDRA-12661
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12661
> Project: Cassandra
> Issue Type: New Feature
>Reporter: Edward Capriolo
>Assignee: Edward Capriolo
>Priority: Minor
> Attachments: Screen Shot 2017-04-12 at 11.38.06 AM.png
>
>
> Changes:
> * Move gc_log_threshold_in_ms and gc_warn_threshold_in_ms close together in
> the config
> * rename variables to match properties
> * add unit tests to ensure hybration
> * add unit tests to ensure variables are set propertly
> * minor perf (do not consturct string from buffer f not logging)
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (CASSANDRA-12661) Make gc_log and gc_warn settable at runtime
[
https://issues.apache.org/jira/browse/CASSANDRA-12661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15965906#comment-15965906
]
Edward Capriolo commented on CASSANDRA-12661:
-
{noformat}
it silently changes the default of gc_warn_threshold_in_ms from 0 to 1000
{noformat}
>From this one I do not believe this is the case. I believe the value was unset
>in the config but statically set in the class. So it had a default value but
>it was not supplied as thee other ones were.
{noformat}
due to the checks in the implementation, the order of calls to
setGcLogThresholdInMs + setGcWarnThresholdInMs depend on the current values,
which should not be the case. this could be changed by having just one method
that changes both values.
{noformat}
That was the idea because one can not be lower then the other. I can see how
this would be problematic.We could simply set both or silently raise the value
of one before the other. Or do what you suggest.
{noformat}
i’m missing a reason for the new if (!mbs.isRegistered(me)) and the other
change in the static initializer
{noformat}
Running unit tests bark about instance already being registered.
> Make gc_log and gc_warn settable at runtime
> ---
>
> Key: CASSANDRA-12661
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12661
> Project: Cassandra
> Issue Type: New Feature
>Reporter: Edward Capriolo
>Assignee: Edward Capriolo
>Priority: Minor
>
> Changes:
> * Move gc_log_threshold_in_ms and gc_warn_threshold_in_ms close together in
> the config
> * rename variables to match properties
> * add unit tests to ensure hybration
> * add unit tests to ensure variables are set propertly
> * minor perf (do not consturct string from buffer f not logging)
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (CASSANDRA-12661) Make gc_log and gc_warn settable at runtime
[ https://issues.apache.org/jira/browse/CASSANDRA-12661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15965896#comment-15965896 ] Edward Capriolo commented on CASSANDRA-12661: - Lovely. Ill go thought the simple ones now. > Make gc_log and gc_warn settable at runtime > --- > > Key: CASSANDRA-12661 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12661 > Project: Cassandra > Issue Type: New Feature >Reporter: Edward Capriolo >Assignee: Edward Capriolo >Priority: Minor > > Changes: > * Move gc_log_threshold_in_ms and gc_warn_threshold_in_ms close together in > the config > * rename variables to match properties > * add unit tests to ensure hybration > * add unit tests to ensure variables are set propertly > * minor perf (do not consturct string from buffer f not logging) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CASSANDRA-12661) Make gc_log and gc_warn settable at runtime
[
https://issues.apache.org/jira/browse/CASSANDRA-12661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15965859#comment-15965859
]
Robert Stupp commented on CASSANDRA-12661:
--
There are some other issues with the patch:
* it silently changes the default of {{gc_warn_threshold_in_ms}} from 0 to 1000
* the change of {{final static long}} to {{private volatile static long}} - the
{{volatile}} is unnecessary here, especially since {{handleNotification}} is
running in the JVM GC threads and therefore within a potential stop-the-world
phase
* the first check in {{setGcWarnThresholdInMs}} is wrong
* the second {{if}} in {{setGcLogThresholdInMs}} is wrong
* due to the checks in the implementation, the order of calls to
{{setGcLogThresholdInMs}} + {{setGcWarnThresholdInMs}} depend on the _current_
values, which should not be the case. this could be changed by having just one
method that changes both values.
* i’m missing a reason for the new {{if (!mbs.isRegistered(me))}} and the other
change in the static initializer
* The javadoc change, should be formatted as all other comments - i.e. {{/*}}
in the first line and the first line of text in the next one.
* {{GCInspectorTest}} is missing the _mandatory_ copyright header
* The added {{@Override}} annotations should be removed (according to C* code
style)
* The utest failure should be fixed
> Make gc_log and gc_warn settable at runtime
> ---
>
> Key: CASSANDRA-12661
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12661
> Project: Cassandra
> Issue Type: New Feature
>Reporter: Edward Capriolo
>Assignee: Edward Capriolo
>Priority: Minor
>
> Changes:
> * Move gc_log_threshold_in_ms and gc_warn_threshold_in_ms close together in
> the config
> * rename variables to match properties
> * add unit tests to ensure hybration
> * add unit tests to ensure variables are set propertly
> * minor perf (do not consturct string from buffer f not logging)
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (CASSANDRA-12661) Make gc_log and gc_warn settable at runtime
[
https://issues.apache.org/jira/browse/CASSANDRA-12661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15965339#comment-15965339
]
Michael Shuler commented on CASSANDRA-12661:
The new tests fail:
http://cassci.datastax.com/job/trunk_testall/1509/testReport/org.apache.cassandra.service/GCInspectorTest/ensureLogLessThanWarn/
http://cassci.datastax.com/job/trunk_testall/1509/testReport/org.apache.cassandra.service/GCInspectorTest/ensureLogLessThanWarn_compression/
{noformat}
Error Message
Expected exception: java.lang.IllegalArgumentException
Stacktrace
junit.framework.AssertionFailedError: Expected exception:
java.lang.IllegalArgumentException
Standard Output
ERROR [main] 2017-04-12 02:05:31,914 SubstituteLogger.java:250 - SLF4J: stderr
INFO [main] 2017-04-12 02:05:32,110 YamlConfigurationLoader.java:89 -
Configuration location: file:/home/automaton/cassandra/test/conf/cassandra.yaml
DEBUG [main] 2017-04-12 02:05:32,112 YamlConfigurationLoader.java:108 - Loading
settings from file:/home/automaton/cassandra/test/conf/cassandra.yaml
INFO [main] 2017-04-12 02:05:32,995 Config.java:454 - Node
configuration:[allocate_tokens_for_keyspace=null; authenticator=null;
authorizer=null; auto_bootstrap=true; auto_snapshot=true;
back_pressure_enabled=false; back_pressure_strategy=null;
batch_size_fail_threshold_in_kb=50; batch_size_warn_threshold_in_kb=5;
batchlog_replay_throttle_in_kb=1024; broadcast_address=null;
broadcast_rpc_address=null; buffer_pool_use_heap_if_exhausted=true;
cas_contention_timeout_in_ms=1000; cdc_enabled=false;
cdc_free_space_check_interval_ms=250;
cdc_raw_directory=build/test/cassandra/cdc_raw:331; cdc_total_space_in_mb=0;
client_encryption_options=; cluster_name=Test Cluster;
column_index_cache_size_in_kb=2; column_index_size_in_kb=4;
commit_failure_policy=stop; commitlog_compression=null;
commitlog_directory=build/test/cassandra/commitlog:331;
commitlog_max_compression_buffers_in_pool=3; commitlog_periodic_queue_size=-1;
commitlog_segment_size_in_mb=5; commitlog_sync=batch;
commitlog_sync_batch_window_in_ms=1.0; commitlog_sync_period_in_ms=0;
commitlog_total_space_in_mb=null;
compaction_large_partition_warning_threshold_mb=100;
compaction_throughput_mb_per_sec=0; concurrent_compactors=4;
concurrent_counter_writes=32; concurrent_materialized_view_writes=32;
concurrent_reads=32; concurrent_replicates=null; concurrent_writes=32;
counter_cache_keys_to_save=2147483647; counter_cache_save_period=7200;
counter_cache_size_in_mb=null; counter_write_request_timeout_in_ms=5000;
credentials_cache_max_entries=1000; credentials_update_interval_in_ms=-1;
credentials_validity_in_ms=2000; cross_node_timeout=false;
data_file_directories=[Ljava.lang.String;@4c178a76; disk_access_mode=mmap;
disk_failure_policy=ignore; disk_optimization_estimate_percentile=0.95;
disk_optimization_page_cross_chance=0.1; disk_optimization_strategy=ssd;
dynamic_snitch=true; dynamic_snitch_badness_threshold=0.1;
dynamic_snitch_reset_interval_in_ms=60;
dynamic_snitch_update_interval_in_ms=100;
enable_scripted_user_defined_functions=true;
enable_user_defined_functions=true; enable_user_defined_functions_threads=true;
encryption_options=null;
endpoint_snitch=org.apache.cassandra.locator.SimpleSnitch;
file_cache_size_in_mb=null; gc_log_threshold_in_ms=200;
gc_warn_threshold_in_ms=1000; hinted_handoff_disabled_datacenters=[];
hinted_handoff_enabled=true; hinted_handoff_throttle_in_kb=1024;
hints_compression=null; hints_directory=build/test/cassandra/hints:331;
hints_flush_period_in_ms=1; ideal_consistency_level=null;
incremental_backups=true; index_summary_capacity_in_mb=null;
index_summary_resize_interval_in_minutes=60; initial_token=null;
inter_dc_stream_throughput_outbound_megabits_per_sec=200;
inter_dc_tcp_nodelay=true; internode_authenticator=null;
internode_compression=none; internode_recv_buff_size_in_bytes=0;
internode_send_buff_size_in_bytes=0; key_cache_keys_to_save=2147483647;
key_cache_save_period=14400; key_cache_size_in_mb=null;
listen_address=127.0.0.1; listen_interface=null;
listen_interface_prefer_ipv6=false; listen_on_broadcast_address=false;
max_hint_window_in_ms=1080; max_hints_delivery_threads=2;
max_hints_file_size_in_mb=128; max_mutation_size_in_kb=null;
max_streaming_retries=3; max_value_size_in_mb=256;
memtable_allocation_type=offheap_objects; memtable_cleanup_threshold=null;
memtable_flush_writers=0; memtable_heap_space_in_mb=null;
memtable_offheap_space_in_mb=null; min_free_space_per_drive_in_mb=50;
native_transport_max_concurrent_connections=-1;
native_transport_max_concurrent_connections_per_ip=-1;
native_transport_max_frame_size_in_mb=256; native_transport_max_threads=128;
native_transport_port=9373; native_transport_port_ssl=null; num_tokens=1;
otc_coalescing_enough_coalesced_messages=8; otc_coalescing_strategy=DISABLED;
otc_coalescing_window_us=200;
[jira] [Commented] (CASSANDRA-12661) Make gc_log and gc_warn settable at runtime
[
https://issues.apache.org/jira/browse/CASSANDRA-12661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15965188#comment-15965188
]
Blake Eggleston commented on CASSANDRA-12661:
-
Committed as {{1096f9f5e77ff7b17cc7f9fe5aba008834899251}}, thanks!
> Make gc_log and gc_warn settable at runtime
> ---
>
> Key: CASSANDRA-12661
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12661
> Project: Cassandra
> Issue Type: New Feature
>Reporter: Edward Capriolo
>Priority: Minor
>
> Changes:
> * Move gc_log_threshold_in_ms and gc_warn_threshold_in_ms close together in
> the config
> * rename variables to match properties
> * add unit tests to ensure hybration
> * add unit tests to ensure variables are set propertly
> * minor perf (do not consturct string from buffer f not logging)
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (CASSANDRA-12661) Make gc_log and gc_warn settable at runtime
[ https://issues.apache.org/jira/browse/CASSANDRA-12661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15965112#comment-15965112 ] Jon Haddad commented on CASSANDRA-12661: Sorry for the long delay. I've had a million things on my plate. This looks good, I'm +1 to merge it. > Make gc_log and gc_warn settable at runtime > --- > > Key: CASSANDRA-12661 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12661 > Project: Cassandra > Issue Type: New Feature >Reporter: Edward Capriolo >Priority: Minor > > Changes: > * Move gc_log_threshold_in_ms and gc_warn_threshold_in_ms close together in > the config > * rename variables to match properties > * add unit tests to ensure hybration > * add unit tests to ensure variables are set propertly > * minor perf (do not consturct string from buffer f not logging) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CASSANDRA-12661) Make gc_log and gc_warn settable at runtime
[ https://issues.apache.org/jira/browse/CASSANDRA-12661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15951131#comment-15951131 ] Edward Capriolo commented on CASSANDRA-12661: - Good luck someone carry on my cause without me. Make logging great again. > Make gc_log and gc_warn settable at runtime > --- > > Key: CASSANDRA-12661 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12661 > Project: Cassandra > Issue Type: New Feature >Reporter: Edward Capriolo >Priority: Minor > > Changes: > * Move gc_log_threshold_in_ms and gc_warn_threshold_in_ms close together in > the config > * rename variables to match properties > * add unit tests to ensure hybration > * add unit tests to ensure variables are set propertly > * minor perf (do not consturct string from buffer f not logging) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CASSANDRA-12661) Make gc_log and gc_warn settable at runtime
[ https://issues.apache.org/jira/browse/CASSANDRA-12661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15943409#comment-15943409 ] Edward Capriolo commented on CASSANDRA-12661: - This ticket is approaching 7 months old. > Make gc_log and gc_warn settable at runtime > --- > > Key: CASSANDRA-12661 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12661 > Project: Cassandra > Issue Type: New Feature >Reporter: Edward Capriolo >Assignee: Edward Capriolo >Priority: Minor > > Changes: > * Move gc_log_threshold_in_ms and gc_warn_threshold_in_ms close together in > the config > * rename variables to match properties > * add unit tests to ensure hybration > * add unit tests to ensure variables are set propertly > * minor perf (do not consturct string from buffer f not logging) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CASSANDRA-12661) Make gc_log and gc_warn settable at runtime
[ https://issues.apache.org/jira/browse/CASSANDRA-12661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15925091#comment-15925091 ] Jon Haddad commented on CASSANDRA-12661: Sorry Ed. I've been swamped with stuff and completely forgot. I'll get to it this week. > Make gc_log and gc_warn settable at runtime > --- > > Key: CASSANDRA-12661 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12661 > Project: Cassandra > Issue Type: New Feature >Reporter: Edward Capriolo >Assignee: Edward Capriolo >Priority: Minor > > Changes: > * Move gc_log_threshold_in_ms and gc_warn_threshold_in_ms close together in > the config > * rename variables to match properties > * add unit tests to ensure hybration > * add unit tests to ensure variables are set propertly > * minor perf (do not consturct string from buffer f not logging) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CASSANDRA-12661) Make gc_log and gc_warn settable at runtime
[ https://issues.apache.org/jira/browse/CASSANDRA-12661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15925069#comment-15925069 ] Edward Capriolo commented on CASSANDRA-12661: - Any help needed here? > Make gc_log and gc_warn settable at runtime > --- > > Key: CASSANDRA-12661 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12661 > Project: Cassandra > Issue Type: New Feature >Reporter: Edward Capriolo >Assignee: Edward Capriolo >Priority: Minor > > Changes: > * Move gc_log_threshold_in_ms and gc_warn_threshold_in_ms close together in > the config > * rename variables to match properties > * add unit tests to ensure hybration > * add unit tests to ensure variables are set propertly > * minor perf (do not consturct string from buffer f not logging) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CASSANDRA-12661) Make gc_log and gc_warn settable at runtime
[ https://issues.apache.org/jira/browse/CASSANDRA-12661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15892748#comment-15892748 ] Jon Haddad commented on CASSANDRA-12661: You're right - I think i had tried to apply it twice. Long day. Reviewing now. > Make gc_log and gc_warn settable at runtime > --- > > Key: CASSANDRA-12661 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12661 > Project: Cassandra > Issue Type: New Feature >Reporter: Edward Capriolo >Assignee: Edward Capriolo >Priority: Minor > > Changes: > * Move gc_log_threshold_in_ms and gc_warn_threshold_in_ms close together in > the config > * rename variables to match properties > * add unit tests to ensure hybration > * add unit tests to ensure variables are set propertly > * minor perf (do not consturct string from buffer f not logging) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CASSANDRA-12661) Make gc_log and gc_warn settable at runtime
[ https://issues.apache.org/jira/browse/CASSANDRA-12661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15892735#comment-15892735 ] Edward Capriolo commented on CASSANDRA-12661: - Make it happen capn :) aiming to get a small chunk of meritocracy every blue moon or so! :) > Make gc_log and gc_warn settable at runtime > --- > > Key: CASSANDRA-12661 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12661 > Project: Cassandra > Issue Type: New Feature >Reporter: Edward Capriolo >Assignee: Edward Capriolo >Priority: Minor > > Changes: > * Move gc_log_threshold_in_ms and gc_warn_threshold_in_ms close together in > the config > * rename variables to match properties > * add unit tests to ensure hybration > * add unit tests to ensure variables are set propertly > * minor perf (do not consturct string from buffer f not logging) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CASSANDRA-12661) Make gc_log and gc_warn settable at runtime
[ https://issues.apache.org/jira/browse/CASSANDRA-12661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891624#comment-15891624 ] Jeff Jirsa commented on CASSANDRA-12661: github indicates it still applies cleanly - doesn't look like it's been committed to me. > Make gc_log and gc_warn settable at runtime > --- > > Key: CASSANDRA-12661 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12661 > Project: Cassandra > Issue Type: New Feature >Reporter: Edward Capriolo >Assignee: Edward Capriolo >Priority: Minor > > Changes: > * Move gc_log_threshold_in_ms and gc_warn_threshold_in_ms close together in > the config > * rename variables to match properties > * add unit tests to ensure hybration > * add unit tests to ensure variables are set propertly > * minor perf (do not consturct string from buffer f not logging) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CASSANDRA-12661) Make gc_log and gc_warn settable at runtime
[
https://issues.apache.org/jira/browse/CASSANDRA-12661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891568#comment-15891568
]
Jon Haddad commented on CASSANDRA-12661:
Was this merged by someone else? I tried to take a look at this but git
errored out saying it's already been applied:
{code}
(cassandra) jhaddad@rustyrazorblade ~/dev/cassandra$ git am -3 12661.patch
Applying: CASSANDRA-12661 gc_log and gc_warn runtime setabble and minor cleanup
Using index info to reconstruct a base tree...
M conf/cassandra.yaml
M src/java/org/apache/cassandra/config/Config.java
M src/java/org/apache/cassandra/service/GCInspector.java
M src/java/org/apache/cassandra/service/GCInspectorMXBean.java
.git/rebase-apply/patch:96: trailing whitespace.
.git/rebase-apply/patch:111: trailing whitespace.
catch (RuntimeException | InstanceAlreadyExistsException |
MBeanRegistrationException |
.git/rebase-apply/patch:126: trailing whitespace.
.git/rebase-apply/patch:151: trailing whitespace.
throw new IllegalArgumentException("Threashold must be greater than
gcLogTreasholdInMs which is currently "
.git/rebase-apply/patch:168: trailing whitespace.
throw new IllegalArgumentException("Threashold must be less than
gcWarnTreasholdInMs which is currently "
warning: squelched 11 whitespace errors
warning: 16 lines add whitespace errors.
Falling back to patching base and 3-way merge...
No changes -- Patch already applied.
{code}
> Make gc_log and gc_warn settable at runtime
> ---
>
> Key: CASSANDRA-12661
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12661
> Project: Cassandra
> Issue Type: New Feature
>Reporter: Edward Capriolo
>Assignee: Edward Capriolo
>Priority: Minor
>
> Changes:
> * Move gc_log_threshold_in_ms and gc_warn_threshold_in_ms close together in
> the config
> * rename variables to match properties
> * add unit tests to ensure hybration
> * add unit tests to ensure variables are set propertly
> * minor perf (do not consturct string from buffer f not logging)
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (CASSANDRA-12661) Make gc_log and gc_warn settable at runtime
[ https://issues.apache.org/jira/browse/CASSANDRA-12661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15575464#comment-15575464 ] Edward Capriolo commented on CASSANDRA-12661: - Ping: Still applies cleanly. > Make gc_log and gc_warn settable at runtime > --- > > Key: CASSANDRA-12661 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12661 > Project: Cassandra > Issue Type: New Feature >Reporter: Edward Capriolo >Assignee: Edward Capriolo >Priority: Minor > > Changes: > * Move gc_log_threshold_in_ms and gc_warn_threshold_in_ms close together in > the config > * rename variables to match properties > * add unit tests to ensure hybration > * add unit tests to ensure variables are set propertly > * minor perf (do not consturct string from buffer f not logging) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12661) Make gc_log and gc_warn settable at runtime
[ https://issues.apache.org/jira/browse/CASSANDRA-12661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15499267#comment-15499267 ] Edward Capriolo commented on CASSANDRA-12661: - https://github.com/apache/cassandra/compare/trunk...edwardcapriolo:CASSANDRA-12661?expand=1 > Make gc_log and gc_warn settable at runtime > --- > > Key: CASSANDRA-12661 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12661 > Project: Cassandra > Issue Type: New Feature >Reporter: Edward Capriolo >Assignee: Edward Capriolo >Priority: Minor > > Changes: > * Move gc_log_threshold_in_ms and gc_warn_threshold_in_ms close together in > the config > * rename variables to match properties > * add unit tests to ensure hybration > * add unit tests to ensure variables are set propertly > * minor perf (do not consturct string from buffer f not logging) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
