[jira] [Commented] (CASSANDRA-12739) Cassandra Tools use cassandra-env.sh MAX_HEAP_SIZE if set

2016-09-30 Thread Brad Vernon (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-12739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15537184#comment-15537184
 ] 

Brad Vernon commented on CASSANDRA-12739:
-

Good point, will change.

> Cassandra Tools use cassandra-env.sh MAX_HEAP_SIZE if set
> -
>
> Key: CASSANDRA-12739
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12739
> Project: Cassandra
>  Issue Type: Bug
>  Components: Tools
>Reporter: Brad Vernon
> Attachments: cass-21_tools_xmx.patch, cass-22_tools_xmx.patch, 
> cass-3x_tools_xmx.patch
>
>
> Nodetool and other bash startup scripts load cassandra-env.sh variables 
> including MAX_HEAP_SIZE as part of CASSANDRA-10679.  If cassandra-env.sh has 
> MAX_HEAP_SIZE set to any value the default heap size needed for the cassandra 
> tool to run is overridden.  
> This is a problem if the using a large heap in C* i.e. 16-32G due to each 
> instance of nodetool or other tool will allocate large heap regardless of 
> need and could exceed the total RAM available on the system.
> Patch removes the check for MAX_HEAP_SIZE being set and uses the default heap 
> size needed for each tool.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (CASSANDRA-12739) Cassandra Tools use cassandra-env.sh MAX_HEAP_SIZE if set

2016-09-30 Thread Jeremiah Jordan (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-12739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15537152#comment-15537152
 ] 

Jeremiah Jordan commented on CASSANDRA-12739:
-

All the tools use max heap size on purpose there.  nodetool should just save 
MAX_HEAP_SIZE and restore it, like it does for JVM_OPTS

> Cassandra Tools use cassandra-env.sh MAX_HEAP_SIZE if set
> -
>
> Key: CASSANDRA-12739
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12739
> Project: Cassandra
>  Issue Type: Bug
>  Components: Tools
>Reporter: Brad Vernon
> Attachments: cass-21_tools_xmx.patch, cass-22_tools_xmx.patch, 
> cass-3x_tools_xmx.patch
>
>
> Nodetool and other bash startup scripts load cassandra-env.sh variables 
> including MAX_HEAP_SIZE as part of CASSANDRA-10679.  If cassandra-env.sh has 
> MAX_HEAP_SIZE set to any value the default heap size needed for the cassandra 
> tool to run is overridden.  
> This is a problem if the using a large heap in C* i.e. 16-32G due to each 
> instance of nodetool or other tool will allocate large heap regardless of 
> need and could exceed the total RAM available on the system.
> Patch removes the check for MAX_HEAP_SIZE being set and uses the default heap 
> size needed for each tool.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (CASSANDRA-12739) Cassandra Tools use cassandra-env.sh MAX_HEAP_SIZE if set

2016-09-30 Thread Yuki Morishita (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-12739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15537146#comment-15537146
 ] 

Yuki Morishita commented on CASSANDRA-12739:


As far as I know, only nodetool and debug-cql source cassandra-env.sh.
Other tools do not yet (CASSANDRA-8167).

> Cassandra Tools use cassandra-env.sh MAX_HEAP_SIZE if set
> -
>
> Key: CASSANDRA-12739
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12739
> Project: Cassandra
>  Issue Type: Bug
>  Components: Tools
>Reporter: Brad Vernon
> Attachments: cass-21_tools_xmx.patch, cass-22_tools_xmx.patch, 
> cass-3x_tools_xmx.patch
>
>
> Nodetool and other bash startup scripts load cassandra-env.sh variables 
> including MAX_HEAP_SIZE as part of CASSANDRA-10679.  If cassandra-env.sh has 
> MAX_HEAP_SIZE set to any value the default heap size needed for the cassandra 
> tool to run is overridden.  
> This is a problem if the using a large heap in C* i.e. 16-32G due to each 
> instance of nodetool or other tool will allocate large heap regardless of 
> need and could exceed the total RAM available on the system.
> Patch removes the check for MAX_HEAP_SIZE being set and uses the default heap 
> size needed for each tool.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)