[jira] [Commented] (CASSANDRA-13012) Paxos regression from CASSANDRA-12716

2016-12-07 Thread Aleksey Yeschenko (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-13012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15731005#comment-15731005
 ] 

Aleksey Yeschenko commented on CASSANDRA-13012:
---

[~kohlisankalp] CASSANDRA-12716

> Paxos regression from CASSANDRA-12716
> -
>
> Key: CASSANDRA-13012
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13012
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Sylvain Lebresne
>Assignee: Sylvain Lebresne
>Priority: Minor
>
> I introduced a dumb bug when reading the Paxos state in 
> {{SystemKeyspace.loadPaxosState}} where the new condition on 
> {{proposal_version}} and {{most_recent_commit_version}} is obviously way too 
> strong, and actually entirely unnecessary.
> This is consistently breaking the 
> {{paxos_tests.TestPaxos.contention_test_many_threads}} so I'm not sure why I 
> didn't caught that, sorry. Thanks to [~jkni] who noticed that first.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-13012) Paxos regression from CASSANDRA-12716

2016-12-07 Thread sankalp kohli (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-13012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15730419#comment-15730419
 ] 

sankalp kohli commented on CASSANDRA-13012:
---

IN which JIRA this issues was added...Do you remember? 

> Paxos regression from CASSANDRA-12716
> -
>
> Key: CASSANDRA-13012
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13012
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Sylvain Lebresne
>Assignee: Sylvain Lebresne
>Priority: Minor
>
> I introduced a dumb bug when reading the Paxos state in 
> {{SystemKeyspace.loadPaxosState}} where the new condition on 
> {{proposal_version}} and {{most_recent_commit_version}} is obviously way too 
> strong, and actually entirely unnecessary.
> This is consistently breaking the 
> {{paxos_tests.TestPaxos.contention_test_many_threads}} so I'm not sure why I 
> didn't caught that, sorry. Thanks to [~jkni] who noticed that first.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-13012) Paxos regression from CASSANDRA-12716

2016-12-07 Thread Joel Knighton (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-13012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15729275#comment-15729275
 ] 

Joel Knighton commented on CASSANDRA-13012:
---

+1

> Paxos regression from CASSANDRA-12716
> -
>
> Key: CASSANDRA-13012
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13012
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Sylvain Lebresne
>Assignee: Sylvain Lebresne
>Priority: Minor
>
> I introduced a dumb bug when reading the Paxos state in 
> {{SystemKeyspace.loadPaxosState}} where the new condition on 
> {{proposal_version}} and {{most_recent_commit_version}} is obviously way too 
> strong, and actually entirely unnecessary.
> This is consistently breaking the 
> {{paxos_tests.TestPaxos.contention_test_many_threads}} so I'm not sure why I 
> didn't caught that, sorry. Thanks to [~jkni] who noticed that first.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)