[jira] [Commented] (CASSANDRA-13070) unittest antiCompactionSizeTest is unstable
[ https://issues.apache.org/jira/browse/CASSANDRA-13070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877327#comment-15877327 ] Jay Zhuang commented on CASSANDRA-13070: [~yukim] Thanks Yuki for the review. I'm still able to reproduce it from my mac and linux host with current 3.0 branch (https://github.com/apache/cassandra/commit/0eae9084e674876ac339bcc34d4e135f89b4d2fb): {noformat} [junit] Testcase: antiCompactionSizeTest(org.apache.cassandra.db.compaction.AntiCompactionTest): FAILED [junit] expected:<1.29786604E8> but was:<1.13608285E8> [junit] junit.framework.AssertionFailedError: expected:<1.29786604E8> but was:<1.13608285E8> [junit] at org.apache.cassandra.db.compaction.AntiCompactionTest.antiCompactionSizeTest(AntiCompactionTest.java:164) [junit] [junit] [junit] Test org.apache.cassandra.db.compaction.AntiCompactionTest FAILED {noformat} Not failed every time, for example, I run it 20 times, failed 13 times: {noformat} $ for i in {0..20}; do echo ==$i; ant testsome -Dtest.name=org.apache.cassandra.db.compaction.AntiCompactionTest -Dtest.methods=antiCompactionSizeTest; echo $i $? >> ~/testresult2; done $ cat ~/testresult2 0 0 1 0 2 0 3 0 4 1 5 1 6 1 7 1 8 1 9 0 10 0 11 1 12 1 13 1 14 1 15 0 16 1 17 1 18 0 19 1 20 1 {noformat} > unittest antiCompactionSizeTest is unstable > --- > > Key: CASSANDRA-13070 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13070 > Project: Cassandra > Issue Type: Bug > Components: Testing >Reporter: Jay Zhuang >Assignee: Jay Zhuang > Fix For: 3.0.x > > Attachments: 13070-3.0.txt > > > Unittest > {{org.apache.cassandra.db.compaction.AntiCompactionTest.antiCompactionSizeTest}} > is failing from time to time on branch 3.0 > ([13e9396|https://github.com/apache/cassandra/commit/13e939624d21eaf6e16d60b28636125e817ab286]): > {code} > [junit] Testcase: > antiCompactionSizeTest(org.apache.cassandra.db.compaction.AntiCompactionTest): > FAILED > [junit] expected:<1.29786604E8> but was:<1.13623354E8> > [junit] junit.framework.AssertionFailedError: expected:<1.29786604E8> but > was:<1.13623354E8> > [junit] at > org.apache.cassandra.db.compaction.AntiCompactionTest.antiCompactionSizeTest(AntiCompactionTest.java:164) > {code} > Run the single test 21 times: > {code} > for i in {0..20}; do echo ==$i; ant testsome > -Dtest.name=org.apache.cassandra.db.compaction.AntiCompactionTest > -Dtest.methods=antiCompactionSizeTest; echo $i $? >> ~/testresult; done > {code} > On mac, it passed for 5 times, on linux it passed for 6 times. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CASSANDRA-13070) unittest antiCompactionSizeTest is unstable
[ https://issues.apache.org/jira/browse/CASSANDRA-13070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877106#comment-15877106 ] Yuki Morishita commented on CASSANDRA-13070: I couldn't reproduce this on my machine, nor cassci has not failed this test (http://cassci.datastax.com/view/cassandra-3.0/job/cassandra-3.0_testall/lastCompletedBuild/testReport/org.apache.cassandra.db.compaction/AntiCompactionTest/antiCompactionSizeTest/history/) I wonder if this assertion is valid anymore. Once the delta value was 1, then raised to 1600. I *think* the original intention was to test anti compacted SSTables' size should be close to the original size, but it was adjusted for SSTable format change. I suggest removing this assertion since assertion doen't comply the original intention after format change. > unittest antiCompactionSizeTest is unstable > --- > > Key: CASSANDRA-13070 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13070 > Project: Cassandra > Issue Type: Bug > Components: Testing >Reporter: Jay Zhuang >Assignee: Jay Zhuang > Fix For: 3.0.x > > Attachments: 13070-3.0.txt > > > Unittest > {{org.apache.cassandra.db.compaction.AntiCompactionTest.antiCompactionSizeTest}} > is failing from time to time on branch 3.0 > ([13e9396|https://github.com/apache/cassandra/commit/13e939624d21eaf6e16d60b28636125e817ab286]): > {code} > [junit] Testcase: > antiCompactionSizeTest(org.apache.cassandra.db.compaction.AntiCompactionTest): > FAILED > [junit] expected:<1.29786604E8> but was:<1.13623354E8> > [junit] junit.framework.AssertionFailedError: expected:<1.29786604E8> but > was:<1.13623354E8> > [junit] at > org.apache.cassandra.db.compaction.AntiCompactionTest.antiCompactionSizeTest(AntiCompactionTest.java:164) > {code} > Run the single test 21 times: > {code} > for i in {0..20}; do echo ==$i; ant testsome > -Dtest.name=org.apache.cassandra.db.compaction.AntiCompactionTest > -Dtest.methods=antiCompactionSizeTest; echo $i $? >> ~/testresult; done > {code} > On mac, it passed for 5 times, on linux it passed for 6 times. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CASSANDRA-13070) unittest antiCompactionSizeTest is unstable
[ https://issues.apache.org/jira/browse/CASSANDRA-13070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15768514#comment-15768514 ] Jay Zhuang commented on CASSANDRA-13070: Tested on mac and linux systems, run the test 21 times, all passed. Please review. > unittest antiCompactionSizeTest is unstable > --- > > Key: CASSANDRA-13070 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13070 > Project: Cassandra > Issue Type: Bug > Components: Testing >Reporter: Jay Zhuang >Assignee: Jay Zhuang > Fix For: 3.0.x > > Attachments: 13070-3.0.txt > > > Unittest > {{org.apache.cassandra.db.compaction.AntiCompactionTest.antiCompactionSizeTest}} > is failing from time to time on branch 3.0 > ([13e9396|https://github.com/apache/cassandra/commit/13e939624d21eaf6e16d60b28636125e817ab286]): > {code} > [junit] Testcase: > antiCompactionSizeTest(org.apache.cassandra.db.compaction.AntiCompactionTest): > FAILED > [junit] expected:<1.29786604E8> but was:<1.13623354E8> > [junit] junit.framework.AssertionFailedError: expected:<1.29786604E8> but > was:<1.13623354E8> > [junit] at > org.apache.cassandra.db.compaction.AntiCompactionTest.antiCompactionSizeTest(AntiCompactionTest.java:164) > {code} > Run the single test 21 times: > {code} > for i in {0..20}; do echo ==$i; ant testsome > -Dtest.name=org.apache.cassandra.db.compaction.AntiCompactionTest > -Dtest.methods=antiCompactionSizeTest; echo $i $? >> ~/testresult; done > {code} > On mac, it passed for 5 times, on linux it passed for 6 times. -- This message was sent by Atlassian JIRA (v6.3.4#6332)