[jira] [Commented] (CASSANDRA-13306) Builds fetch source jars for build dependencies, not just source dependencies

2017-03-15 Thread Joel Knighton (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-13306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927489#comment-15927489
 ] 

Joel Knighton commented on CASSANDRA-13306:
---

Thanks! I ran a round of CI and tested builds with empty and populated .m2.

Committed to trunk as {{fe08463c3b7135a0f1b121bb0d148c80b8c7e123}}.

> Builds fetch source jars for build dependencies, not just source dependencies
> -
>
> Key: CASSANDRA-13306
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13306
> Project: Cassandra
>  Issue Type: Bug
>  Components: Build
>Reporter: Joel Knighton
>Assignee: Joel Knighton
> Fix For: 4.0
>
>
> A recent commit without a linked JIRA cleaned up dead imports and also added 
> a {{sourcesFilesetId}} to artifact fetching for the build-deps-pom. This 
> causes ant to fetch source jars for the build deps, but we have an explicit 
> separate build-deps-pom-sources that fetches sources.
> This happened in commit {{e96ce6d132129025ff6b923129cb67eed2f97931}}.
> Was this an intentional change, [~dbrosius]? It seems to conflate the 
> separate build-deps-pom and build-deps-pom-sources.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CASSANDRA-13306) Builds fetch source jars for build dependencies, not just source dependencies

2017-03-07 Thread Dave Brosius (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-13306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15900454#comment-15900454
 ] 

Dave Brosius commented on CASSANDRA-13306:
--

agreed, that can be reverted.

> Builds fetch source jars for build dependencies, not just source dependencies
> -
>
> Key: CASSANDRA-13306
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13306
> Project: Cassandra
>  Issue Type: Bug
>  Components: Build
>Reporter: Joel Knighton
>
> A recent commit without a linked JIRA cleaned up dead imports and also added 
> a {{sourcesFilesetId}} to artifact fetching for the build-deps-pom. This 
> causes ant to fetch source jars for the build deps, but we have an explicit 
> separate build-deps-pom-sources that fetches sources.
> This happened in commit {{e96ce6d132129025ff6b923129cb67eed2f97931}}.
> Was this an intentional change, [~dbrosius]? It seems to conflate the 
> separate build-deps-pom and build-deps-pom-sources.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)