[jira] [Commented] (CASSANDRA-13852) Race condition when closing stream sessions (4.0)

2017-09-07 Thread Blake Eggleston (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-13852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16157862#comment-16157862
 ] 

Blake Eggleston commented on CASSANDRA-13852:
-

+1

> Race condition when closing stream sessions (4.0)
> -
>
> Key: CASSANDRA-13852
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13852
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Jason Brown
>Assignee: Jason Brown
>
> bootstrap_test:TestBootstrap.manual_bootstrap_test is hanging due to a race 
> condition that can occur when waiting for a streaming COMPLETE message and 
> the remote side has already closed the connection. We do not check to see if 
> we still have remaining bytes buffered for consumption in 
> {{RebufferringByteBufDataInputPlus}}, but always go ahead and throw an 
> {{EOFException}}. We should consume the bytes, then throw an {{EOFException}} 
> on subsequent calls.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-13852) Race condition when closing stream sessions (4.0)

2017-09-07 Thread Jason Brown (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-13852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16157855#comment-16157855
 ] 

Jason Brown commented on CASSANDRA-13852:
-

This fix should also resolve the hanging in system_auth_ks_is_alterable_test 
(auth_test.TestAuth)

> Race condition when closing stream sessions (4.0)
> -
>
> Key: CASSANDRA-13852
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13852
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Jason Brown
>Assignee: Jason Brown
>
> bootstrap_test:TestBootstrap.manual_bootstrap_test is hanging due to a race 
> condition that can occur when waiting for a streaming COMPLETE message and 
> the remote side has already closed the connection. We do not check to see if 
> we still have remaining bytes buffered for consumption in 
> {{RebufferringByteBufDataInputPlus}}, but always go ahead and throw an 
> {{EOFException}}. We should consume the bytes, then throw an {{EOFException}} 
> on subsequent calls.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-13852) Race condition when closing stream sessions

2017-09-07 Thread Jason Brown (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-13852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16157383#comment-16157383
 ] 

Jason Brown commented on CASSANDRA-13852:
-

Patch to fix this problem here:

||hang||
|[branch|https://github.com/jasobrown/cassandra/tree/bootstrap-dtest-hang]|
|[dtest|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/287]|
|[utests|https://circleci.com/gh/jasobrown/cassandra/tree/bootstrap-dtest-hang]|

There are other dtests problems happening, and I"m on those now, as well.

> Race condition when closing stream sessions
> ---
>
> Key: CASSANDRA-13852
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13852
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Jason Brown
>
> bootstrap_test:TestBootstrap.manual_bootstrap_test is hanging due to a race 
> condition that can occur when waiting for a streaming COMPLETE message and 
> the remote side has already closed the connection. We do not check to see if 
> we still have remaining bytes buffered for consumption in 
> {{RebufferringByteBufDataInputPlus}}, but always go ahead and throw an 
> {{EOFException}}. We should consume the bytes, then throw an {{EOFException}} 
> on subsequent calls.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-13852) Race condition when closing stream sessions

2017-09-07 Thread Jason Brown (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-13852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16157379#comment-16157379
 ] 

Jason Brown commented on CASSANDRA-13852:
-

This was discovered via bootstrap_test:TestBootstrap.manual_bootstrap_test 
hanging when running dtests

> Race condition when closing stream sessions
> ---
>
> Key: CASSANDRA-13852
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13852
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Jason Brown
>
> bootstrap_test:TestBootstrap.manual_bootstrap_test is hanging due to a race 
> condition that can occur when waiting for a streaming COMPLETE message and 
> the remote side has already closed the connection. We do not check to see if 
> we still have remaining bytes buffered for consumption in 
> {{RebufferringByteBufDataInputPlus}}, but always go ahead and throw an 
> {{EOFException}}. We should consume the bytes, then throw an {{EOFException}} 
> on subsequent calls.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org