[jira] [Commented] (CASSANDRA-13997) Upgrade Guava to 23.3 and Airline to 0.8
[
https://issues.apache.org/jira/browse/CASSANDRA-13997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16249290#comment-16249290
]
Stefan Podkowinski commented on CASSANDRA-13997:
If we do that, then we should probably include the guava artifact directly
instead of j2objc. This should override the ancient guava-16 version that is
pulled by ohc.
> Upgrade Guava to 23.3 and Airline to 0.8
>
>
> Key: CASSANDRA-13997
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13997
> Project: Cassandra
> Issue Type: Improvement
> Components: Libraries
>Reporter: Marcus Eriksson
>Assignee: Marcus Eriksson
> Fix For: 4.0
>
> Attachments: airline-0.8.jar.asc, guava-23.3-jre.jar.asc
>
>
> For 4.0 we should upgrade guava to the latest version
> patch here: https://github.com/krummas/cassandra/commits/marcuse/guava23
> A bunch of quite commonly used methods have been deprecated since guava 18
> which we use now ({{Throwables.propagate}} for example), this patch mostly
> updates uses where compilation fails. {{Futures.transform(ListenableFuture
> ..., AsyncFunction ...}} was deprecated in Guava 19 and removed in 20 for
> example, we should probably open new tickets to remove calls to all
> deprecated guava methods.
> Also had to add a dependency on {{com.google.j2objc.j2objc-annotations}}, to
> avoid some build-time warnings (maybe due to
> https://github.com/google/guava/commit/fffd2b1f67d158c7b4052123c5032b0ba54a910d
> ?)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13997) Upgrade Guava to 23.3 and Airline to 0.8
[
https://issues.apache.org/jira/browse/CASSANDRA-13997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16246172#comment-16246172
]
Marcus Eriksson commented on CASSANDRA-13997:
-
[~tjake] something like this?
https://github.com/krummas/cassandra/commit/4d174989400126c8a4c206699b0abc6c09b30844
> Upgrade Guava to 23.3 and Airline to 0.8
>
>
> Key: CASSANDRA-13997
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13997
> Project: Cassandra
> Issue Type: Improvement
> Components: Libraries
>Reporter: Marcus Eriksson
>Assignee: Marcus Eriksson
> Fix For: 4.0
>
> Attachments: airline-0.8.jar.asc, guava-23.3-jre.jar.asc
>
>
> For 4.0 we should upgrade guava to the latest version
> patch here: https://github.com/krummas/cassandra/commits/marcuse/guava23
> A bunch of quite commonly used methods have been deprecated since guava 18
> which we use now ({{Throwables.propagate}} for example), this patch mostly
> updates uses where compilation fails. {{Futures.transform(ListenableFuture
> ..., AsyncFunction ...}} was deprecated in Guava 19 and removed in 20 for
> example, we should probably open new tickets to remove calls to all
> deprecated guava methods.
> Also had to add a dependency on {{com.google.j2objc.j2objc-annotations}}, to
> avoid some build-time warnings (maybe due to
> https://github.com/google/guava/commit/fffd2b1f67d158c7b4052123c5032b0ba54a910d
> ?)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13997) Upgrade Guava to 23.3 and Airline to 0.8
[
https://issues.apache.org/jira/browse/CASSANDRA-13997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16246126#comment-16246126
]
T Jake Luciani commented on CASSANDRA-13997:
[~krummas] There's no need to add the j2objc to the lib dir. You can simply
add it to the build dep jars. An example of this is the
compile-command-annotation entries in build.xml
> Upgrade Guava to 23.3 and Airline to 0.8
>
>
> Key: CASSANDRA-13997
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13997
> Project: Cassandra
> Issue Type: Improvement
> Components: Libraries
>Reporter: Marcus Eriksson
>Assignee: Marcus Eriksson
> Fix For: 4.0
>
> Attachments: airline-0.8.jar.asc, guava-23.3-jre.jar.asc
>
>
> For 4.0 we should upgrade guava to the latest version
> patch here: https://github.com/krummas/cassandra/commits/marcuse/guava23
> A bunch of quite commonly used methods have been deprecated since guava 18
> which we use now ({{Throwables.propagate}} for example), this patch mostly
> updates uses where compilation fails. {{Futures.transform(ListenableFuture
> ..., AsyncFunction ...}} was deprecated in Guava 19 and removed in 20 for
> example, we should probably open new tickets to remove calls to all
> deprecated guava methods.
> Also had to add a dependency on {{com.google.j2objc.j2objc-annotations}}, to
> avoid some build-time warnings (maybe due to
> https://github.com/google/guava/commit/fffd2b1f67d158c7b4052123c5032b0ba54a910d
> ?)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13997) Upgrade guava to 23.3
[
https://issues.apache.org/jira/browse/CASSANDRA-13997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16245386#comment-16245386
]
Stefan Podkowinski commented on CASSANDRA-13997:
+1
Should get changes.txt entry, but looks fine otherwise.
> Upgrade guava to 23.3
> -
>
> Key: CASSANDRA-13997
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13997
> Project: Cassandra
> Issue Type: Improvement
> Components: Libraries
>Reporter: Marcus Eriksson
>Assignee: Marcus Eriksson
> Fix For: 4.x
>
>
> For 4.0 we should upgrade guava to the latest version
> patch here: https://github.com/krummas/cassandra/commits/marcuse/guava23
> A bunch of quite commonly used methods have been deprecated since guava 18
> which we use now ({{Throwables.propagate}} for example), this patch mostly
> updates uses where compilation fails. {{Futures.transform(ListenableFuture
> ..., AsyncFunction ...}} was deprecated in Guava 19 and removed in 20 for
> example, we should probably open new tickets to remove calls to all
> deprecated guava methods.
> Also had to add a dependency on {{com.google.j2objc.j2objc-annotations}}, to
> avoid some build-time warnings (maybe due to
> https://github.com/google/guava/commit/fffd2b1f67d158c7b4052123c5032b0ba54a910d
> ?)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13997) Upgrade guava to 23.3
[
https://issues.apache.org/jira/browse/CASSANDRA-13997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16244242#comment-16244242
]
Marcus Eriksson commented on CASSANDRA-13997:
-
pushed up a commit to remove the j2obj dep from build.xml
> Upgrade guava to 23.3
> -
>
> Key: CASSANDRA-13997
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13997
> Project: Cassandra
> Issue Type: Improvement
>Reporter: Marcus Eriksson
>Assignee: Marcus Eriksson
> Fix For: 4.x
>
>
> For 4.0 we should upgrade guava to the latest version
> patch here: https://github.com/krummas/cassandra/commits/marcuse/guava23
> A bunch of quite commonly used methods have been deprecated since guava 18
> which we use now ({{Throwables.propagate}} for example), this patch mostly
> updates uses where compilation fails. {{Futures.transform(ListenableFuture
> ..., AsyncFunction ...}} was deprecated in Guava 19 and removed in 20 for
> example, we should probably open new tickets to remove calls to all
> deprecated guava methods.
> Also had to add a dependency on {{com.google.j2objc.j2objc-annotations}}, to
> avoid some build-time warnings (maybe due to
> https://github.com/google/guava/commit/fffd2b1f67d158c7b4052123c5032b0ba54a910d
> ?)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13997) Upgrade guava to 23.3
[
https://issues.apache.org/jira/browse/CASSANDRA-13997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16244236#comment-16244236
]
Stefan Podkowinski commented on CASSANDRA-13997:
Ah, never mind. These dependencies have been introduced in January for v22
already. Should have clicked that little "..." icon next to the tag for the
commit. Guess there's no going back then, as they seem to have settled down for
the [decision|https://github.com/google/guava/issues/2824] to keep the
dependencies non-optional.
> Upgrade guava to 23.3
> -
>
> Key: CASSANDRA-13997
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13997
> Project: Cassandra
> Issue Type: Improvement
>Reporter: Marcus Eriksson
>Assignee: Marcus Eriksson
> Fix For: 4.x
>
>
> For 4.0 we should upgrade guava to the latest version
> patch here: https://github.com/krummas/cassandra/commits/marcuse/guava23
> A bunch of quite commonly used methods have been deprecated since guava 18
> which we use now ({{Throwables.propagate}} for example), this patch mostly
> updates uses where compilation fails. {{Futures.transform(ListenableFuture
> ..., AsyncFunction ...}} was deprecated in Guava 19 and removed in 20 for
> example, we should probably open new tickets to remove calls to all
> deprecated guava methods.
> Also had to add a dependency on {{com.google.j2objc.j2objc-annotations}}, to
> avoid some build-time warnings (maybe due to
> https://github.com/google/guava/commit/fffd2b1f67d158c7b4052123c5032b0ba54a910d
> ?)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13997) Upgrade guava to 23.3
[
https://issues.apache.org/jira/browse/CASSANDRA-13997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16244216#comment-16244216
]
Marcus Eriksson commented on CASSANDRA-13997:
-
bq. I don't think you have to add j2objc-annotations to the pom (build.xml) as
well, as it's already a transitive guava dependency.
Good point
bq. There are also other dependencies that are no longer optional and not
everyone seems to be happy about it.
Is there a discussion about this somewhere?
bq. Shouldn't this be reason enough to stick with 23.2 instead
Couldn't see anything obvious in the diff between 23.2 and .3 that could affect
us, so if you think that is better, I'm totally ok with that
> Upgrade guava to 23.3
> -
>
> Key: CASSANDRA-13997
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13997
> Project: Cassandra
> Issue Type: Improvement
>Reporter: Marcus Eriksson
>Assignee: Marcus Eriksson
> Fix For: 4.x
>
>
> For 4.0 we should upgrade guava to the latest version
> patch here: https://github.com/krummas/cassandra/commits/marcuse/guava23
> A bunch of quite commonly used methods have been deprecated since guava 18
> which we use now ({{Throwables.propagate}} for example), this patch mostly
> updates uses where compilation fails. {{Futures.transform(ListenableFuture
> ..., AsyncFunction ...}} was deprecated in Guava 19 and removed in 20 for
> example, we should probably open new tickets to remove calls to all
> deprecated guava methods.
> Also had to add a dependency on {{com.google.j2objc.j2objc-annotations}}, to
> avoid some build-time warnings (maybe due to
> https://github.com/google/guava/commit/fffd2b1f67d158c7b4052123c5032b0ba54a910d
> ?)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13997) Upgrade guava to 23.3
[
https://issues.apache.org/jira/browse/CASSANDRA-13997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16244185#comment-16244185
]
Stefan Podkowinski commented on CASSANDRA-13997:
I don't think you have to add {{j2objc-annotations}} to the pom (build.xml) as
well, as it's already a transitive guava dependency. There are also other
dependencies that are [no longer
optional|https://github.com/google/guava/commit/0e29934933f33379de953727171f7ca1ec616a58]
and not everyone seems to be happy about it. Shouldn't this be reason enough
to stick with 23.2 instead for the time being?
> Upgrade guava to 23.3
> -
>
> Key: CASSANDRA-13997
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13997
> Project: Cassandra
> Issue Type: Improvement
>Reporter: Marcus Eriksson
>Assignee: Marcus Eriksson
> Fix For: 4.x
>
>
> For 4.0 we should upgrade guava to the latest version
> patch here: https://github.com/krummas/cassandra/commits/marcuse/guava23
> A bunch of quite commonly used methods have been deprecated since guava 18
> which we use now ({{Throwables.propagate}} for example), this patch mostly
> updates uses where compilation fails. {{Futures.transform(ListenableFuture
> ..., AsyncFunction ...}} was deprecated in Guava 19 and removed in 20 for
> example, we should probably open new tickets to remove calls to all
> deprecated guava methods.
> Also had to add a dependency on {{com.google.j2objc.j2objc-annotations}}, to
> avoid some build-time warnings (maybe due to
> https://github.com/google/guava/commit/fffd2b1f67d158c7b4052123c5032b0ba54a910d
> ?)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13997) Upgrade guava to 23.3
[
https://issues.apache.org/jira/browse/CASSANDRA-13997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16243548#comment-16243548
]
Marcus Eriksson commented on CASSANDRA-13997:
-
[~tkruse] 3.11 is mostly in bugfix mode now, could you open a new ticket where
this could be discussed?
> Upgrade guava to 23.3
> -
>
> Key: CASSANDRA-13997
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13997
> Project: Cassandra
> Issue Type: Improvement
>Reporter: Marcus Eriksson
>Assignee: Marcus Eriksson
> Fix For: 4.x
>
>
> For 4.0 we should upgrade guava to the latest version
> patch here: https://github.com/krummas/cassandra/commits/marcuse/guava23
> A bunch of quite commonly used methods have been deprecated since guava 18
> which we use now ({{Throwables.propagate}} for example), this patch mostly
> updates uses where compilation fails. {{Futures.transform(ListenableFuture
> ..., AsyncFunction ...}} was deprecated in Guava 19 and removed in 20 for
> example, we should probably open new tickets to remove calls to all
> deprecated guava methods.
> Also had to add a dependency on {{com.google.j2objc.j2objc-annotations}}, to
> avoid some build-time warnings (maybe due to
> https://github.com/google/guava/commit/fffd2b1f67d158c7b4052123c5032b0ba54a910d
> ?)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13997) Upgrade guava to 23.3
[
https://issues.apache.org/jira/browse/CASSANDRA-13997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16243295#comment-16243295
]
Thibault Kruse commented on CASSANDRA-13997:
For us it would be nice if cassandra 3.x could be made API compatible with
Guava > 19.0.
Such as replacing
Iterators.emptyIterator()
with
Collections.emptyIterator()
as done in
https://github.com/krummas/cassandra/commits/marcuse/guava23
This would not require changing the guava version, just abolishing certain
usages of guava that have been deprecated.
> Upgrade guava to 23.3
> -
>
> Key: CASSANDRA-13997
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13997
> Project: Cassandra
> Issue Type: Improvement
>Reporter: Marcus Eriksson
>Assignee: Marcus Eriksson
> Fix For: 4.x
>
>
> For 4.0 we should upgrade guava to the latest version
> patch here: https://github.com/krummas/cassandra/commits/marcuse/guava23
> A bunch of quite commonly used methods have been deprecated since guava 18
> which we use now ({{Throwables.propagate}} for example), this patch mostly
> updates uses where compilation fails. {{Futures.transform(ListenableFuture
> ..., AsyncFunction ...}} was deprecated in Guava 19 and removed in 20 for
> example, we should probably open new tickets to remove calls to all
> deprecated guava methods.
> Also had to add a dependency on {{com.google.j2objc.j2objc-annotations}}, to
> avoid some build-time warnings (maybe due to
> https://github.com/google/guava/commit/fffd2b1f67d158c7b4052123c5032b0ba54a910d
> ?)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13997) Upgrade guava to 23.3
[
https://issues.apache.org/jira/browse/CASSANDRA-13997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16242118#comment-16242118
]
Marcus Eriksson commented on CASSANDRA-13997:
-
pushed a commit that upgrades airline to 0.8
https://circleci.com/gh/krummas/cassandra/tree/marcuse%2Fguava23
https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/421/
> Upgrade guava to 23.3
> -
>
> Key: CASSANDRA-13997
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13997
> Project: Cassandra
> Issue Type: Improvement
>Reporter: Marcus Eriksson
>Assignee: Marcus Eriksson
> Fix For: 4.x
>
>
> For 4.0 we should upgrade guava to the latest version
> patch here: https://github.com/krummas/cassandra/commits/marcuse/guava23
> A bunch of quite commonly used methods have been deprecated since guava 18
> which we use now ({{Throwables.propagate}} for example), this patch mostly
> updates uses where compilation fails. {{Futures.transform(ListenableFuture
> ..., AsyncFunction ...}} was deprecated in Guava 19 and removed in 20 for
> example, we should probably open new tickets to remove calls to all
> deprecated guava methods.
> Also had to add a dependency on {{com.google.j2objc.j2objc-annotations}}, to
> avoid some build-time warnings (maybe due to
> https://github.com/google/guava/commit/fffd2b1f67d158c7b4052123c5032b0ba54a910d
> ?)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13997) Upgrade guava to 23.3
[
https://issues.apache.org/jira/browse/CASSANDRA-13997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16242108#comment-16242108
]
Marcus Eriksson commented on CASSANDRA-13997:
-
dtest run yesterday timed out:
https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/420/
circle shows that we probably need to upgrade airline as well:
https://circleci.com/gh/krummas/cassandra/171
> Upgrade guava to 23.3
> -
>
> Key: CASSANDRA-13997
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13997
> Project: Cassandra
> Issue Type: Improvement
>Reporter: Marcus Eriksson
>Assignee: Marcus Eriksson
> Fix For: 4.x
>
>
> For 4.0 we should upgrade guava to the latest version
> patch here: https://github.com/krummas/cassandra/commits/marcuse/guava23
> A bunch of quite commonly used methods have been deprecated since guava 18
> which we use now ({{Throwables.propagate}} for example), this patch mostly
> updates uses where compilation fails. {{Futures.transform(ListenableFuture
> ..., AsyncFunction ...}} was deprecated in Guava 19 and removed in 20 for
> example, we should probably open new tickets to remove calls to all
> deprecated guava methods.
> Also had to add a dependency on {{com.google.j2objc.j2objc-annotations}}, to
> avoid some build-time warnings (maybe due to
> https://github.com/google/guava/commit/fffd2b1f67d158c7b4052123c5032b0ba54a910d
> ?)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
