[jira] [Commented] (CASSANDRA-14061) trunk eclipse-warnings
[
https://issues.apache.org/jira/browse/CASSANDRA-14061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16392113#comment-16392113
]
Jay Zhuang commented on CASSANDRA-14061:
Thanks for the review.
Committed as
[a7141e6|https://github.com/apache/cassandra/commit/a7141e6c9df03287567c22c76372e166fc83d18e].
> trunk eclipse-warnings
> --
>
> Key: CASSANDRA-14061
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14061
> Project: Cassandra
> Issue Type: Bug
> Components: Testing
>Reporter: Jay Zhuang
>Assignee: Jay Zhuang
>Priority: Minor
>
> {noformat}
> eclipse-warnings:
> [mkdir] Created dir: /home/ubuntu/cassandra/build/ecj
> [echo] Running Eclipse Code Analysis. Output logged to
> /home/ubuntu/cassandra/build/ecj/eclipse_compiler_checks.txt
> [java] --
> [java] 1. ERROR in
> /home/ubuntu/cassandra/src/java/org/apache/cassandra/io/sstable/SSTableIdentityIterator.java
> (at line 59)
> [java] return new SSTableIdentityIterator(sstable, key,
> partitionLevelDeletion, file.getPath(), iterator);
> [java]
> ^^^
> [java] Potential resource leak: 'iterator' may not be closed at this
> location
> [java] --
> [java] 2. ERROR in
> /home/ubuntu/cassandra/src/java/org/apache/cassandra/io/sstable/SSTableIdentityIterator.java
> (at line 79)
> [java] return new SSTableIdentityIterator(sstable, key,
> partitionLevelDeletion, dfile.getPath(), iterator);
> [java]
>
> [java] Potential resource leak: 'iterator' may not be closed at this
> location
> [java] --
> [java] 2 problems (2 errors)
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14061) trunk eclipse-warnings
[
https://issues.apache.org/jira/browse/CASSANDRA-14061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16391177#comment-16391177
]
ZhaoYang commented on CASSANDRA-14061:
--
Actually, I am not sure how the warning is introduced in 13299.. Thanks for
fixing it!
> trunk eclipse-warnings
> --
>
> Key: CASSANDRA-14061
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14061
> Project: Cassandra
> Issue Type: Bug
> Components: Testing
>Reporter: Jay Zhuang
>Assignee: Jay Zhuang
>Priority: Minor
>
> {noformat}
> eclipse-warnings:
> [mkdir] Created dir: /home/ubuntu/cassandra/build/ecj
> [echo] Running Eclipse Code Analysis. Output logged to
> /home/ubuntu/cassandra/build/ecj/eclipse_compiler_checks.txt
> [java] --
> [java] 1. ERROR in
> /home/ubuntu/cassandra/src/java/org/apache/cassandra/io/sstable/SSTableIdentityIterator.java
> (at line 59)
> [java] return new SSTableIdentityIterator(sstable, key,
> partitionLevelDeletion, file.getPath(), iterator);
> [java]
> ^^^
> [java] Potential resource leak: 'iterator' may not be closed at this
> location
> [java] --
> [java] 2. ERROR in
> /home/ubuntu/cassandra/src/java/org/apache/cassandra/io/sstable/SSTableIdentityIterator.java
> (at line 79)
> [java] return new SSTableIdentityIterator(sstable, key,
> partitionLevelDeletion, dfile.getPath(), iterator);
> [java]
>
> [java] Potential resource leak: 'iterator' may not be closed at this
> location
> [java] --
> [java] 2 problems (2 errors)
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14061) trunk eclipse-warnings
[
https://issues.apache.org/jira/browse/CASSANDRA-14061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16391173#comment-16391173
]
Stefan Podkowinski commented on CASSANDRA-14061:
+1
> trunk eclipse-warnings
> --
>
> Key: CASSANDRA-14061
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14061
> Project: Cassandra
> Issue Type: Bug
> Components: Testing
>Reporter: Jay Zhuang
>Assignee: Jay Zhuang
>Priority: Minor
>
> {noformat}
> eclipse-warnings:
> [mkdir] Created dir: /home/ubuntu/cassandra/build/ecj
> [echo] Running Eclipse Code Analysis. Output logged to
> /home/ubuntu/cassandra/build/ecj/eclipse_compiler_checks.txt
> [java] --
> [java] 1. ERROR in
> /home/ubuntu/cassandra/src/java/org/apache/cassandra/io/sstable/SSTableIdentityIterator.java
> (at line 59)
> [java] return new SSTableIdentityIterator(sstable, key,
> partitionLevelDeletion, file.getPath(), iterator);
> [java]
> ^^^
> [java] Potential resource leak: 'iterator' may not be closed at this
> location
> [java] --
> [java] 2. ERROR in
> /home/ubuntu/cassandra/src/java/org/apache/cassandra/io/sstable/SSTableIdentityIterator.java
> (at line 79)
> [java] return new SSTableIdentityIterator(sstable, key,
> partitionLevelDeletion, dfile.getPath(), iterator);
> [java]
>
> [java] Potential resource leak: 'iterator' may not be closed at this
> location
> [java] --
> [java] 2 problems (2 errors)
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14061) trunk eclipse-warnings
[
https://issues.apache.org/jira/browse/CASSANDRA-14061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16390459#comment-16390459
]
Jay Zhuang commented on CASSANDRA-14061:
CASSANDRA-14296 would fix the new ones.
For the warnings in {{SSTableIdentityIterator.java}}, it cannot be reproduced
consistently: [Cassandra-trunk-test-all:
499|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-trunk-test-all/498/console]
vs. [Cassandra-trunk-test-all:
499|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-trunk-test-all/498/console].
Anyway, I rebased to the trunk to suppress warnings:
| Branch | uTest |
| [14061|https://github.com/cooldoger/cassandra/tree/14061] |
[!https://circleci.com/gh/cooldoger/cassandra/tree/14061.svg?style=svg!|https://circleci.com/gh/cooldoger/cassandra/tree/14061]
|
> trunk eclipse-warnings
> --
>
> Key: CASSANDRA-14061
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14061
> Project: Cassandra
> Issue Type: Bug
> Components: Testing
>Reporter: Jay Zhuang
>Assignee: Jay Zhuang
>Priority: Minor
>
> {noformat}
> eclipse-warnings:
> [mkdir] Created dir: /home/ubuntu/cassandra/build/ecj
> [echo] Running Eclipse Code Analysis. Output logged to
> /home/ubuntu/cassandra/build/ecj/eclipse_compiler_checks.txt
> [java] --
> [java] 1. ERROR in
> /home/ubuntu/cassandra/src/java/org/apache/cassandra/io/sstable/SSTableIdentityIterator.java
> (at line 59)
> [java] return new SSTableIdentityIterator(sstable, key,
> partitionLevelDeletion, file.getPath(), iterator);
> [java]
> ^^^
> [java] Potential resource leak: 'iterator' may not be closed at this
> location
> [java] --
> [java] 2. ERROR in
> /home/ubuntu/cassandra/src/java/org/apache/cassandra/io/sstable/SSTableIdentityIterator.java
> (at line 79)
> [java] return new SSTableIdentityIterator(sstable, key,
> partitionLevelDeletion, dfile.getPath(), iterator);
> [java]
>
> [java] Potential resource leak: 'iterator' may not be closed at this
> location
> [java] --
> [java] 2 problems (2 errors)
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14061) trunk eclipse-warnings
[
https://issues.apache.org/jira/browse/CASSANDRA-14061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16389523#comment-16389523
]
Stefan Podkowinski commented on CASSANDRA-14061:
Looks like {{eclipse-warnings}} is breaking
[trunk-test-all|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-trunk-test-all/]
on b.a.o, so we should get this fixed at some point. There's also a new type
of error. Would you like to rebase and look at this again, [~jay.zhuang]? The
suggested SuppressWarnings annotation should be safe, so let's not
unnecessarily complicate matters and go with the suggested changes.
/cc [~aweisberg]
> trunk eclipse-warnings
> --
>
> Key: CASSANDRA-14061
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14061
> Project: Cassandra
> Issue Type: Bug
> Components: Testing
>Reporter: Jay Zhuang
>Assignee: Jay Zhuang
>Priority: Minor
>
> {noformat}
> eclipse-warnings:
> [mkdir] Created dir: /home/ubuntu/cassandra/build/ecj
> [echo] Running Eclipse Code Analysis. Output logged to
> /home/ubuntu/cassandra/build/ecj/eclipse_compiler_checks.txt
> [java] --
> [java] 1. ERROR in
> /home/ubuntu/cassandra/src/java/org/apache/cassandra/io/sstable/SSTableIdentityIterator.java
> (at line 59)
> [java] return new SSTableIdentityIterator(sstable, key,
> partitionLevelDeletion, file.getPath(), iterator);
> [java]
> ^^^
> [java] Potential resource leak: 'iterator' may not be closed at this
> location
> [java] --
> [java] 2. ERROR in
> /home/ubuntu/cassandra/src/java/org/apache/cassandra/io/sstable/SSTableIdentityIterator.java
> (at line 79)
> [java] return new SSTableIdentityIterator(sstable, key,
> partitionLevelDeletion, dfile.getPath(), iterator);
> [java]
>
> [java] Potential resource leak: 'iterator' may not be closed at this
> location
> [java] --
> [java] 2 problems (2 errors)
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14061) trunk eclipse-warnings
[
https://issues.apache.org/jira/browse/CASSANDRA-14061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16286369#comment-16286369
]
Jay Zhuang commented on CASSANDRA-14061:
[~spo...@gmail.com] For adding {{iterator.close();}} I don't know. Anyway, it's
doing nothing:
[AbstractIterator.java:86|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/AbstractIterator.java#L86]
and won't fix the warning. What do you think?
> trunk eclipse-warnings
> --
>
> Key: CASSANDRA-14061
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14061
> Project: Cassandra
> Issue Type: Bug
> Components: Testing
>Reporter: Jay Zhuang
>Assignee: Jay Zhuang
>Priority: Minor
>
> {noformat}
> eclipse-warnings:
> [mkdir] Created dir: /home/ubuntu/cassandra/build/ecj
> [echo] Running Eclipse Code Analysis. Output logged to
> /home/ubuntu/cassandra/build/ecj/eclipse_compiler_checks.txt
> [java] --
> [java] 1. ERROR in
> /home/ubuntu/cassandra/src/java/org/apache/cassandra/io/sstable/SSTableIdentityIterator.java
> (at line 59)
> [java] return new SSTableIdentityIterator(sstable, key,
> partitionLevelDeletion, file.getPath(), iterator);
> [java]
> ^^^
> [java] Potential resource leak: 'iterator' may not be closed at this
> location
> [java] --
> [java] 2. ERROR in
> /home/ubuntu/cassandra/src/java/org/apache/cassandra/io/sstable/SSTableIdentityIterator.java
> (at line 79)
> [java] return new SSTableIdentityIterator(sstable, key,
> partitionLevelDeletion, dfile.getPath(), iterator);
> [java]
>
> [java] Potential resource leak: 'iterator' may not be closed at this
> location
> [java] --
> [java] 2 problems (2 errors)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14061) trunk eclipse-warnings
[
https://issues.apache.org/jira/browse/CASSANDRA-14061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16286050#comment-16286050
]
Stefan Podkowinski commented on CASSANDRA-14061:
[~jay.zhuang], do you plan to change your patch or keep it as is at this point?
> trunk eclipse-warnings
> --
>
> Key: CASSANDRA-14061
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14061
> Project: Cassandra
> Issue Type: Bug
> Components: Testing
>Reporter: Jay Zhuang
>Assignee: Jay Zhuang
>Priority: Minor
>
> {noformat}
> eclipse-warnings:
> [mkdir] Created dir: /home/ubuntu/cassandra/build/ecj
> [echo] Running Eclipse Code Analysis. Output logged to
> /home/ubuntu/cassandra/build/ecj/eclipse_compiler_checks.txt
> [java] --
> [java] 1. ERROR in
> /home/ubuntu/cassandra/src/java/org/apache/cassandra/io/sstable/SSTableIdentityIterator.java
> (at line 59)
> [java] return new SSTableIdentityIterator(sstable, key,
> partitionLevelDeletion, file.getPath(), iterator);
> [java]
> ^^^
> [java] Potential resource leak: 'iterator' may not be closed at this
> location
> [java] --
> [java] 2. ERROR in
> /home/ubuntu/cassandra/src/java/org/apache/cassandra/io/sstable/SSTableIdentityIterator.java
> (at line 79)
> [java] return new SSTableIdentityIterator(sstable, key,
> partitionLevelDeletion, dfile.getPath(), iterator);
> [java]
>
> [java] Potential resource leak: 'iterator' may not be closed at this
> location
> [java] --
> [java] 2 problems (2 errors)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14061) trunk eclipse-warnings
[
https://issues.apache.org/jira/browse/CASSANDRA-14061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275744#comment-16275744
]
Jay Zhuang commented on CASSANDRA-14061:
I think the warnings are false alert, maybe we {{iterator.close();}} here:
[SSTableIdentityIterator.java:175|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/io/sstable/SSTableIdentityIterator.java#L175].
The warning is introduced in CASSANDRA-13299. cc [~jasonstack]
> trunk eclipse-warnings
> --
>
> Key: CASSANDRA-14061
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14061
> Project: Cassandra
> Issue Type: Bug
> Components: Testing
>Reporter: Jay Zhuang
>Assignee: Jay Zhuang
>Priority: Minor
>
> {noformat}
> eclipse-warnings:
> [mkdir] Created dir: /home/ubuntu/cassandra/build/ecj
> [echo] Running Eclipse Code Analysis. Output logged to
> /home/ubuntu/cassandra/build/ecj/eclipse_compiler_checks.txt
> [java] --
> [java] 1. ERROR in
> /home/ubuntu/cassandra/src/java/org/apache/cassandra/io/sstable/SSTableIdentityIterator.java
> (at line 59)
> [java] return new SSTableIdentityIterator(sstable, key,
> partitionLevelDeletion, file.getPath(), iterator);
> [java]
> ^^^
> [java] Potential resource leak: 'iterator' may not be closed at this
> location
> [java] --
> [java] 2. ERROR in
> /home/ubuntu/cassandra/src/java/org/apache/cassandra/io/sstable/SSTableIdentityIterator.java
> (at line 79)
> [java] return new SSTableIdentityIterator(sstable, key,
> partitionLevelDeletion, dfile.getPath(), iterator);
> [java]
>
> [java] Potential resource leak: 'iterator' may not be closed at this
> location
> [java] --
> [java] 2 problems (2 errors)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14061) trunk eclipse-warnings
[
https://issues.apache.org/jira/browse/CASSANDRA-14061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16274303#comment-16274303
]
Stefan Podkowinski commented on CASSANDRA-14061:
[~jay.zhuang], if we're going to make eclipse-warnings a hard requirement for
the build, shouldn't we also fix the reported issues instead of suppressing
them? Doing both seems to be a bit ambivalent to me.
> trunk eclipse-warnings
> --
>
> Key: CASSANDRA-14061
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14061
> Project: Cassandra
> Issue Type: Bug
> Components: Testing
>Reporter: Jay Zhuang
>Assignee: Jay Zhuang
>Priority: Minor
>
> {noformat}
> eclipse-warnings:
> [mkdir] Created dir: /home/ubuntu/cassandra/build/ecj
> [echo] Running Eclipse Code Analysis. Output logged to
> /home/ubuntu/cassandra/build/ecj/eclipse_compiler_checks.txt
> [java] --
> [java] 1. ERROR in
> /home/ubuntu/cassandra/src/java/org/apache/cassandra/io/sstable/SSTableIdentityIterator.java
> (at line 59)
> [java] return new SSTableIdentityIterator(sstable, key,
> partitionLevelDeletion, file.getPath(), iterator);
> [java]
> ^^^
> [java] Potential resource leak: 'iterator' may not be closed at this
> location
> [java] --
> [java] 2. ERROR in
> /home/ubuntu/cassandra/src/java/org/apache/cassandra/io/sstable/SSTableIdentityIterator.java
> (at line 79)
> [java] return new SSTableIdentityIterator(sstable, key,
> partitionLevelDeletion, dfile.getPath(), iterator);
> [java]
>
> [java] Potential resource leak: 'iterator' may not be closed at this
> location
> [java] --
> [java] 2 problems (2 errors)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14061) trunk eclipse-warnings
[
https://issues.apache.org/jira/browse/CASSANDRA-14061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16273436#comment-16273436
]
Jeff Jirsa commented on CASSANDRA-14061:
[~spo...@gmail.com] interested in being the official reviewer on this?
> trunk eclipse-warnings
> --
>
> Key: CASSANDRA-14061
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14061
> Project: Cassandra
> Issue Type: Bug
> Components: Testing
>Reporter: Jay Zhuang
>Assignee: Jay Zhuang
>Priority: Minor
>
> {noformat}
> eclipse-warnings:
> [mkdir] Created dir: /home/ubuntu/cassandra/build/ecj
> [echo] Running Eclipse Code Analysis. Output logged to
> /home/ubuntu/cassandra/build/ecj/eclipse_compiler_checks.txt
> [java] --
> [java] 1. ERROR in
> /home/ubuntu/cassandra/src/java/org/apache/cassandra/io/sstable/SSTableIdentityIterator.java
> (at line 59)
> [java] return new SSTableIdentityIterator(sstable, key,
> partitionLevelDeletion, file.getPath(), iterator);
> [java]
> ^^^
> [java] Potential resource leak: 'iterator' may not be closed at this
> location
> [java] --
> [java] 2. ERROR in
> /home/ubuntu/cassandra/src/java/org/apache/cassandra/io/sstable/SSTableIdentityIterator.java
> (at line 79)
> [java] return new SSTableIdentityIterator(sstable, key,
> partitionLevelDeletion, dfile.getPath(), iterator);
> [java]
>
> [java] Potential resource leak: 'iterator' may not be closed at this
> location
> [java] --
> [java] 2 problems (2 errors)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14061) trunk eclipse-warnings
[
https://issues.apache.org/jira/browse/CASSANDRA-14061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16267106#comment-16267106
]
Jay Zhuang commented on CASSANDRA-14061:
[~spo...@gmail.com]
I'm still able to reproduce it, for example:
https://circleci.com/gh/cooldoger/cassandra/148#tests/containers/0
{noformat}
eclipse-warnings:
[mkdir] Created dir: /home/ubuntu/cassandra/build/ecj
[echo] Running Eclipse Code Analysis. Output logged to
/home/ubuntu/cassandra/build/ecj/eclipse_compiler_checks.txt
[java] --
[java] 1. ERROR in
/home/ubuntu/cassandra/src/java/org/apache/cassandra/io/sstable/SSTableIdentityIterator.java
(at line 59)
[java] return new SSTableIdentityIterator(sstable, key,
partitionLevelDeletion, file.getPath(), iterator);
[java]
^^^
[java] Potential resource leak: 'iterator' may not be closed at this
location
[java] --
[java] 2. ERROR in
/home/ubuntu/cassandra/src/java/org/apache/cassandra/io/sstable/SSTableIdentityIterator.java
(at line 79)
[java] return new SSTableIdentityIterator(sstable, key,
partitionLevelDeletion, dfile.getPath(), iterator);
[java]
[java] Potential resource leak: 'iterator' may not be closed at this
location
[java] --
[java] 2 problems (2 errors)
{noformat}
> trunk eclipse-warnings
> --
>
> Key: CASSANDRA-14061
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14061
> Project: Cassandra
> Issue Type: Bug
> Components: Testing
>Reporter: Jay Zhuang
>Assignee: Jay Zhuang
>Priority: Minor
>
> {noformat}
> eclipse-warnings:
> [mkdir] Created dir: /home/ubuntu/cassandra/build/ecj
> [echo] Running Eclipse Code Analysis. Output logged to
> /home/ubuntu/cassandra/build/ecj/eclipse_compiler_checks.txt
> [java] --
> [java] 1. ERROR in
> /home/ubuntu/cassandra/src/java/org/apache/cassandra/io/sstable/SSTableIdentityIterator.java
> (at line 59)
> [java] return new SSTableIdentityIterator(sstable, key,
> partitionLevelDeletion, file.getPath(), iterator);
> [java]
> ^^^
> [java] Potential resource leak: 'iterator' may not be closed at this
> location
> [java] --
> [java] 2. ERROR in
> /home/ubuntu/cassandra/src/java/org/apache/cassandra/io/sstable/SSTableIdentityIterator.java
> (at line 79)
> [java] return new SSTableIdentityIterator(sstable, key,
> partitionLevelDeletion, dfile.getPath(), iterator);
> [java]
>
> [java] Potential resource leak: 'iterator' may not be closed at this
> location
> [java] --
> [java] 2 problems (2 errors)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14061) trunk eclipse-warnings
[
https://issues.apache.org/jira/browse/CASSANDRA-14061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266803#comment-16266803
]
Stefan Podkowinski commented on CASSANDRA-14061:
Can't reproduce the issue on trunk. Ant eclipse-warnings will finish without
any errors.
> trunk eclipse-warnings
> --
>
> Key: CASSANDRA-14061
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14061
> Project: Cassandra
> Issue Type: Bug
> Components: Testing
>Reporter: Jay Zhuang
>Assignee: Jay Zhuang
>Priority: Minor
>
> {noformat}
> eclipse-warnings:
> [mkdir] Created dir: /home/ubuntu/cassandra/build/ecj
> [echo] Running Eclipse Code Analysis. Output logged to
> /home/ubuntu/cassandra/build/ecj/eclipse_compiler_checks.txt
> [java] --
> [java] 1. ERROR in
> /home/ubuntu/cassandra/src/java/org/apache/cassandra/io/sstable/SSTableIdentityIterator.java
> (at line 59)
> [java] return new SSTableIdentityIterator(sstable, key,
> partitionLevelDeletion, file.getPath(), iterator);
> [java]
> ^^^
> [java] Potential resource leak: 'iterator' may not be closed at this
> location
> [java] --
> [java] 2. ERROR in
> /home/ubuntu/cassandra/src/java/org/apache/cassandra/io/sstable/SSTableIdentityIterator.java
> (at line 79)
> [java] return new SSTableIdentityIterator(sstable, key,
> partitionLevelDeletion, dfile.getPath(), iterator);
> [java]
>
> [java] Potential resource leak: 'iterator' may not be closed at this
> location
> [java] --
> [java] 2 problems (2 errors)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14061) trunk eclipse-warnings
[
https://issues.apache.org/jira/browse/CASSANDRA-14061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16258926#comment-16258926
]
Jay Zhuang commented on CASSANDRA-14061:
Seems they're not the real problem, here is the patch to {{SupressWarning}}:
| Branch | uTest |
| [14061|https://github.com/cooldoger/cassandra/tree/14061] |
[!https://circleci.com/gh/cooldoger/cassandra/tree/14061.svg?style=svg!|https://circleci.com/gh/cooldoger/cassandra/tree/14061]
|
Also, making {{ant eclipse-warnings}} required in circleci build.
> trunk eclipse-warnings
> --
>
> Key: CASSANDRA-14061
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14061
> Project: Cassandra
> Issue Type: Bug
> Components: Testing
>Reporter: Jay Zhuang
>Assignee: Jay Zhuang
>Priority: Minor
>
> {noformat}
> eclipse-warnings:
> [mkdir] Created dir: /home/ubuntu/cassandra/build/ecj
> [echo] Running Eclipse Code Analysis. Output logged to
> /home/ubuntu/cassandra/build/ecj/eclipse_compiler_checks.txt
> [java] --
> [java] 1. ERROR in
> /home/ubuntu/cassandra/src/java/org/apache/cassandra/io/sstable/SSTableIdentityIterator.java
> (at line 59)
> [java] return new SSTableIdentityIterator(sstable, key,
> partitionLevelDeletion, file.getPath(), iterator);
> [java]
> ^^^
> [java] Potential resource leak: 'iterator' may not be closed at this
> location
> [java] --
> [java] 2. ERROR in
> /home/ubuntu/cassandra/src/java/org/apache/cassandra/io/sstable/SSTableIdentityIterator.java
> (at line 79)
> [java] return new SSTableIdentityIterator(sstable, key,
> partitionLevelDeletion, dfile.getPath(), iterator);
> [java]
>
> [java] Potential resource leak: 'iterator' may not be closed at this
> location
> [java] --
> [java] 2 problems (2 errors)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
