[jira] [Commented] (CASSANDRA-14141) Enable CDC unittest
[
https://issues.apache.org/jira/browse/CASSANDRA-14141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16341644#comment-16341644
]
Ariel Weisberg commented on CASSANDRA-14141:
Nope not disk space. Also passes when run manually from the container. Reliably
fails every time when it's run automatically.
> Enable CDC unittest
> ---
>
> Key: CASSANDRA-14141
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14141
> Project: Cassandra
> Issue Type: Test
> Components: Testing
>Reporter: Jay Zhuang
>Assignee: Jay Zhuang
>Priority: Minor
> Labels: CDC, testing
> Fix For: 3.11.2, 4.0
>
>
> Follow up for CASSANDRA-14066
> 2 CDC unittests are skipped in the normal test run, it has to be {{$ ant
> test-cdc}} to run the cdc test.
> The fix enables them in normal {{$ ant test}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14141) Enable CDC unittest
[
https://issues.apache.org/jira/browse/CASSANDRA-14141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16341615#comment-16341615
]
Ariel Weisberg commented on CASSANDRA-14141:
I think this may be disk space related. We suddenly lost access to the larger
volume in CircleCI that is supposed to be mounted in the container but it's no
longer appearing.
> Enable CDC unittest
> ---
>
> Key: CASSANDRA-14141
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14141
> Project: Cassandra
> Issue Type: Test
> Components: Testing
>Reporter: Jay Zhuang
>Assignee: Jay Zhuang
>Priority: Minor
> Labels: CDC, testing
> Fix For: 3.11.2, 4.0
>
>
> Follow up for CASSANDRA-14066
> 2 CDC unittests are skipped in the normal test run, it has to be {{$ ant
> test-cdc}} to run the cdc test.
> The fix enables them in normal {{$ ant test}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14141) Enable CDC unittest
[
https://issues.apache.org/jira/browse/CASSANDRA-14141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16341598#comment-16341598
]
Ariel Weisberg commented on CASSANDRA-14141:
This doesn't work in CircleCI as of when it was merged here
0ac5a17d3aac49f678f8b1ec4c934c8a0e7367ab
{noformat}
[junit] Testcase:
testRetainLinkOnDiscardCDC(org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDCTest):
Caused an ERROR
[junit] Rejecting mutation to keyspace cql_test_keyspace. Free up space in
build/test/cassandra/cdc_raw:0 by processing CDC logs.
[junit] org.apache.cassandra.exceptions.CDCWriteException: Rejecting
mutation to keyspace cql_test_keyspace. Free up space in
build/test/cassandra/cdc_raw:0 by processing CDC logs.
[junit] at
org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDC.throwIfForbidden(CommitLogSegmentManagerCDC.java:136)
[junit] at
org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDC.allocate(CommitLogSegmentManagerCDC.java:108)
[junit] at
org.apache.cassandra.db.commitlog.CommitLog.add(CommitLog.java:272)
[junit] at
org.apache.cassandra.db.Keyspace.applyInternal(Keyspace.java:603)
[junit] at org.apache.cassandra.db.Keyspace.apply(Keyspace.java:480)
[junit] at org.apache.cassandra.db.Mutation.apply(Mutation.java:194)
[junit] at org.apache.cassandra.db.Mutation.apply(Mutation.java:199)
[junit] at org.apache.cassandra.db.Mutation.apply(Mutation.java:208)
[junit] at
org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDCTest.testRetainLinkOnDiscardCDC(CommitLogSegmentManagerCDCTest.java:256)
[junit]
[junit]
[junit] Testcase:
testCompletedFlag(org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDCTest):
FAILED
[junit] Index file not written:
build/test/cassandra/cdc_raw:0/CommitLog-7-1517000670440_cdc.idx
[junit] junit.framework.AssertionFailedError: Index file not written:
build/test/cassandra/cdc_raw:0/CommitLog-7-1517000670440_cdc.idx
[junit] at
org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDCTest.testCompletedFlag(CommitLogSegmentManagerCDCTest.java:210)
{noformat}
I'm going to try it with the circle.yml on trunk just to see what is up. I am
wondering if this test requires more disk space to pass?
> Enable CDC unittest
> ---
>
> Key: CASSANDRA-14141
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14141
> Project: Cassandra
> Issue Type: Test
> Components: Testing
>Reporter: Jay Zhuang
>Assignee: Jay Zhuang
>Priority: Minor
> Labels: CDC, testing
> Fix For: 3.11.2, 4.0
>
>
> Follow up for CASSANDRA-14066
> 2 CDC unittests are skipped in the normal test run, it has to be {{$ ant
> test-cdc}} to run the cdc test.
> The fix enables them in normal {{$ ant test}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14141) Enable CDC unittest
[
https://issues.apache.org/jira/browse/CASSANDRA-14141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324456#comment-16324456
]
Jason Brown commented on CASSANDRA-14141:
-
Yup, 100% agree, [~JoshuaMcKenzie] .
> Enable CDC unittest
> ---
>
> Key: CASSANDRA-14141
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14141
> Project: Cassandra
> Issue Type: Test
> Components: Testing
>Reporter: Jay Zhuang
>Assignee: Jay Zhuang
>Priority: Minor
> Labels: CDC, testing
> Fix For: 3.11.2, 4.0
>
>
> Follow up for CASSANDRA-14066
> 2 CDC unittests are skipped in the normal test run, it has to be {{$ ant
> test-cdc}} to run the cdc test.
> The fix enables them in normal {{$ ant test}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14141) Enable CDC unittest
[
https://issues.apache.org/jira/browse/CASSANDRA-14141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324260#comment-16324260
]
Jay Zhuang commented on CASSANDRA-14141:
bq. Just a quick note: I wouldn't remove or stop running the test-cdc target on
ci. The reason I kept these completely separate was to fully exercise the rest
of the testing infrastructure with cdc enabled to confirm no regression / data
loss in the CommitLog from the changed cdc code. Running the unit tests
specific to cdc on a regular ant test run is fine as a smoke test but shouldn't
serve as a replacement for running the entire test suite against the changed
logic.
+1
> Enable CDC unittest
> ---
>
> Key: CASSANDRA-14141
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14141
> Project: Cassandra
> Issue Type: Test
> Components: Testing
>Reporter: Jay Zhuang
>Assignee: Jay Zhuang
>Priority: Minor
> Labels: CDC, testing
> Fix For: 3.11.2, 4.0
>
>
> Follow up for CASSANDRA-14066
> 2 CDC unittests are skipped in the normal test run, it has to be {{$ ant
> test-cdc}} to run the cdc test.
> The fix enables them in normal {{$ ant test}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14141) Enable CDC unittest
[
https://issues.apache.org/jira/browse/CASSANDRA-14141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324257#comment-16324257
]
Joshua McKenzie commented on CASSANDRA-14141:
-
Just a quick note: I wouldn't remove or stop running the {{test-cdc}} target on
ci. The reason I kept these completely separate was to fully exercise the rest
of the testing infrastructure with cdc enabled to confirm no regression / data
loss in the CommitLog from the changed cdc code. Running the unit tests
specific to cdc on a regular {{ant test}} run is fine as a smoke test but
shouldn't serve as a replacement for running the entire test suite against the
changed logic.
> Enable CDC unittest
> ---
>
> Key: CASSANDRA-14141
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14141
> Project: Cassandra
> Issue Type: Test
> Components: Testing
>Reporter: Jay Zhuang
>Assignee: Jay Zhuang
>Priority: Minor
> Labels: CDC, testing
> Fix For: 3.11.2, 4.0
>
>
> Follow up for CASSANDRA-14066
> 2 CDC unittests are skipped in the normal test run, it has to be {{$ ant
> test-cdc}} to run the cdc test.
> The fix enables them in normal {{$ ant test}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14141) Enable CDC unittest
[
https://issues.apache.org/jira/browse/CASSANDRA-14141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16304978#comment-16304978
]
Jay Zhuang commented on CASSANDRA-14141:
Here is the patch, please review:
| Branch | uTest |
| [14141-3.11|https://github.com/cooldoger/cassandra/tree/14141-3.11] |
[!https://circleci.com/gh/cooldoger/cassandra/tree/14141-3.11.svg?style=svg!|https://circleci.com/gh/cooldoger/cassandra/tree/14141-3.11]
|
| [14141-trunk|https://github.com/cooldoger/cassandra/tree/14141-trunk] |
[!https://circleci.com/gh/cooldoger/cassandra/tree/14141-trunk.svg?style=svg!|https://circleci.com/gh/cooldoger/cassandra/tree/14141-trunk]
|
Tested with both {{$ ant test}} and {{$ ant test-cdc}}.
> Enable CDC unittest
> ---
>
> Key: CASSANDRA-14141
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14141
> Project: Cassandra
> Issue Type: Test
> Components: Testing
>Reporter: Jay Zhuang
>Assignee: Jay Zhuang
>Priority: Minor
> Labels: CDC, testing
>
> Follow up for CASSANDRA-14066
> 2 CDC unittests are skipped in the normal test run, it has to be {{$ ant
> test-cdc}} to run the cdc test.
> The fix enables them in normal {{$ ant test}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
