[jira] [Commented] (CASSANDRA-14195) CommitLogSegmentManagerCDCTest is flaky

2018-01-30 Thread Joshua McKenzie (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-14195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345079#comment-16345079
 ] 

Joshua McKenzie commented on CASSANDRA-14195:
-

Not yet; env is super rusty. I should be able to get to it today.

 

Thankfully it's in a bit of the code that's not changing frequently so I can 
get away with being slow. =/

 

Sorry about that [~jay.zhuang]!

> CommitLogSegmentManagerCDCTest is flaky
> ---
>
> Key: CASSANDRA-14195
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14195
> Project: Cassandra
>  Issue Type: Bug
>  Components: Testing
>Reporter: Ariel Weisberg
>Assignee: Jay Zhuang
>Priority: Minor
>
> This fails fairly reliably in CircleCI and in a few minutes if you run it in 
> a loop on a MacOS laptop.
> I see two failures.
> {noformat}
> [junit] Testcase: 
> testRetainLinkOnDiscardCDC(org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDCTest):
>Caused an ERROR
> [junit] Rejecting mutation to keyspace cql_test_keyspace. Free up space 
> in build/test/cassandra/cdc_raw:0 by processing CDC logs.
> [junit] org.apache.cassandra.exceptions.CDCWriteException: Rejecting 
> mutation to keyspace cql_test_keyspace. Free up space in 
> build/test/cassandra/cdc_raw:0 by processing CDC logs.
> [junit]   at 
> org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDC.throwIfForbidden(CommitLogSegmentManagerCDC.java:136)
> [junit]   at 
> org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDC.allocate(CommitLogSegmentManagerCDC.java:108)
> [junit]   at 
> org.apache.cassandra.db.commitlog.CommitLog.add(CommitLog.java:272)
> [junit]   at 
> org.apache.cassandra.db.Keyspace.applyInternal(Keyspace.java:604)
> [junit]   at org.apache.cassandra.db.Keyspace.apply(Keyspace.java:481)
> [junit]   at org.apache.cassandra.db.Mutation.apply(Mutation.java:191)
> [junit]   at org.apache.cassandra.db.Mutation.apply(Mutation.java:196)
> [junit]   at org.apache.cassandra.db.Mutation.apply(Mutation.java:205)
> [junit]   at 
> org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDCTest.testRetainLinkOnDiscardCDC(CommitLogSegmentManagerCDCTest.java:256)
> {noformat}
> and
> {noformat}
> [junit] Testcase: 
> testCompletedFlag(org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDCTest):
> FAILED
> [junit] Index file not written: 
> build/test/cassandra/cdc_raw:0/CommitLog-7-1517005121474_cdc.idx
> [junit] junit.framework.AssertionFailedError: Index file not written: 
> build/test/cassandra/cdc_raw:0/CommitLog-7-1517005121474_cdc.idx
> [junit]   at 
> org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDCTest.testCompletedFlag(CommitLogSegmentManagerCDCTest.java:210)
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-14195) CommitLogSegmentManagerCDCTest is flaky

2018-01-30 Thread Jason Brown (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-14195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344938#comment-16344938
 ] 

Jason Brown commented on CASSANDRA-14195:
-

Did any one commit yet? :)

> CommitLogSegmentManagerCDCTest is flaky
> ---
>
> Key: CASSANDRA-14195
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14195
> Project: Cassandra
>  Issue Type: Bug
>  Components: Testing
>Reporter: Ariel Weisberg
>Assignee: Jay Zhuang
>Priority: Minor
>
> This fails fairly reliably in CircleCI and in a few minutes if you run it in 
> a loop on a MacOS laptop.
> I see two failures.
> {noformat}
> [junit] Testcase: 
> testRetainLinkOnDiscardCDC(org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDCTest):
>Caused an ERROR
> [junit] Rejecting mutation to keyspace cql_test_keyspace. Free up space 
> in build/test/cassandra/cdc_raw:0 by processing CDC logs.
> [junit] org.apache.cassandra.exceptions.CDCWriteException: Rejecting 
> mutation to keyspace cql_test_keyspace. Free up space in 
> build/test/cassandra/cdc_raw:0 by processing CDC logs.
> [junit]   at 
> org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDC.throwIfForbidden(CommitLogSegmentManagerCDC.java:136)
> [junit]   at 
> org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDC.allocate(CommitLogSegmentManagerCDC.java:108)
> [junit]   at 
> org.apache.cassandra.db.commitlog.CommitLog.add(CommitLog.java:272)
> [junit]   at 
> org.apache.cassandra.db.Keyspace.applyInternal(Keyspace.java:604)
> [junit]   at org.apache.cassandra.db.Keyspace.apply(Keyspace.java:481)
> [junit]   at org.apache.cassandra.db.Mutation.apply(Mutation.java:191)
> [junit]   at org.apache.cassandra.db.Mutation.apply(Mutation.java:196)
> [junit]   at org.apache.cassandra.db.Mutation.apply(Mutation.java:205)
> [junit]   at 
> org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDCTest.testRetainLinkOnDiscardCDC(CommitLogSegmentManagerCDCTest.java:256)
> {noformat}
> and
> {noformat}
> [junit] Testcase: 
> testCompletedFlag(org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDCTest):
> FAILED
> [junit] Index file not written: 
> build/test/cassandra/cdc_raw:0/CommitLog-7-1517005121474_cdc.idx
> [junit] junit.framework.AssertionFailedError: Index file not written: 
> build/test/cassandra/cdc_raw:0/CommitLog-7-1517005121474_cdc.idx
> [junit]   at 
> org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDCTest.testCompletedFlag(CommitLogSegmentManagerCDCTest.java:210)
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-14195) CommitLogSegmentManagerCDCTest is flaky

2018-01-29 Thread Ariel Weisberg (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-14195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343698#comment-16343698
 ] 

Ariel Weisberg commented on CASSANDRA-14195:


Thanks that did seem to fix it.

> CommitLogSegmentManagerCDCTest is flaky
> ---
>
> Key: CASSANDRA-14195
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14195
> Project: Cassandra
>  Issue Type: Bug
>  Components: Testing
>Reporter: Ariel Weisberg
>Assignee: Jay Zhuang
>Priority: Minor
>
> This fails fairly reliably in CircleCI and in a few minutes if you run it in 
> a loop on a MacOS laptop.
> I see two failures.
> {noformat}
> [junit] Testcase: 
> testRetainLinkOnDiscardCDC(org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDCTest):
>Caused an ERROR
> [junit] Rejecting mutation to keyspace cql_test_keyspace. Free up space 
> in build/test/cassandra/cdc_raw:0 by processing CDC logs.
> [junit] org.apache.cassandra.exceptions.CDCWriteException: Rejecting 
> mutation to keyspace cql_test_keyspace. Free up space in 
> build/test/cassandra/cdc_raw:0 by processing CDC logs.
> [junit]   at 
> org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDC.throwIfForbidden(CommitLogSegmentManagerCDC.java:136)
> [junit]   at 
> org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDC.allocate(CommitLogSegmentManagerCDC.java:108)
> [junit]   at 
> org.apache.cassandra.db.commitlog.CommitLog.add(CommitLog.java:272)
> [junit]   at 
> org.apache.cassandra.db.Keyspace.applyInternal(Keyspace.java:604)
> [junit]   at org.apache.cassandra.db.Keyspace.apply(Keyspace.java:481)
> [junit]   at org.apache.cassandra.db.Mutation.apply(Mutation.java:191)
> [junit]   at org.apache.cassandra.db.Mutation.apply(Mutation.java:196)
> [junit]   at org.apache.cassandra.db.Mutation.apply(Mutation.java:205)
> [junit]   at 
> org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDCTest.testRetainLinkOnDiscardCDC(CommitLogSegmentManagerCDCTest.java:256)
> {noformat}
> and
> {noformat}
> [junit] Testcase: 
> testCompletedFlag(org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDCTest):
> FAILED
> [junit] Index file not written: 
> build/test/cassandra/cdc_raw:0/CommitLog-7-1517005121474_cdc.idx
> [junit] junit.framework.AssertionFailedError: Index file not written: 
> build/test/cassandra/cdc_raw:0/CommitLog-7-1517005121474_cdc.idx
> [junit]   at 
> org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDCTest.testCompletedFlag(CommitLogSegmentManagerCDCTest.java:210)
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-14195) CommitLogSegmentManagerCDCTest is flaky

2018-01-29 Thread Joshua McKenzie (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-14195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343655#comment-16343655
 ] 

Joshua McKenzie commented on CASSANDRA-14195:
-

+1. Good catch.

> CommitLogSegmentManagerCDCTest is flaky
> ---
>
> Key: CASSANDRA-14195
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14195
> Project: Cassandra
>  Issue Type: Bug
>  Components: Testing
>Reporter: Ariel Weisberg
>Assignee: Jay Zhuang
>Priority: Minor
>
> This fails fairly reliably in CircleCI and in a few minutes if you run it in 
> a loop on a MacOS laptop.
> I see two failures.
> {noformat}
> [junit] Testcase: 
> testRetainLinkOnDiscardCDC(org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDCTest):
>Caused an ERROR
> [junit] Rejecting mutation to keyspace cql_test_keyspace. Free up space 
> in build/test/cassandra/cdc_raw:0 by processing CDC logs.
> [junit] org.apache.cassandra.exceptions.CDCWriteException: Rejecting 
> mutation to keyspace cql_test_keyspace. Free up space in 
> build/test/cassandra/cdc_raw:0 by processing CDC logs.
> [junit]   at 
> org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDC.throwIfForbidden(CommitLogSegmentManagerCDC.java:136)
> [junit]   at 
> org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDC.allocate(CommitLogSegmentManagerCDC.java:108)
> [junit]   at 
> org.apache.cassandra.db.commitlog.CommitLog.add(CommitLog.java:272)
> [junit]   at 
> org.apache.cassandra.db.Keyspace.applyInternal(Keyspace.java:604)
> [junit]   at org.apache.cassandra.db.Keyspace.apply(Keyspace.java:481)
> [junit]   at org.apache.cassandra.db.Mutation.apply(Mutation.java:191)
> [junit]   at org.apache.cassandra.db.Mutation.apply(Mutation.java:196)
> [junit]   at org.apache.cassandra.db.Mutation.apply(Mutation.java:205)
> [junit]   at 
> org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDCTest.testRetainLinkOnDiscardCDC(CommitLogSegmentManagerCDCTest.java:256)
> {noformat}
> and
> {noformat}
> [junit] Testcase: 
> testCompletedFlag(org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDCTest):
> FAILED
> [junit] Index file not written: 
> build/test/cassandra/cdc_raw:0/CommitLog-7-1517005121474_cdc.idx
> [junit] junit.framework.AssertionFailedError: Index file not written: 
> build/test/cassandra/cdc_raw:0/CommitLog-7-1517005121474_cdc.idx
> [junit]   at 
> org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDCTest.testCompletedFlag(CommitLogSegmentManagerCDCTest.java:210)
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-14195) CommitLogSegmentManagerCDCTest is flaky

2018-01-28 Thread Jay Zhuang (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-14195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342790#comment-16342790
 ] 

Jay Zhuang commented on CASSANDRA-14195:


The problem is because 
[{{testCompletedFlag()}}|https://github.com/apache/cassandra/commit/e9da85723a8dd40872c4bca087a03b655bd2cacb#diff-7bfedffd12a11d61fa013c6a5894c102R191]
 and 
[{{testReplayLogic()}}|https://github.com/apache/cassandra/commit/e9da85723a8dd40872c4bca087a03b655bd2cacb#diff-7bfedffd12a11d61fa013c6a5894c102R279]
 don't reset the {{CDCSpaceInMB}} after running, which impacts the other tests.
Here is the fix, please review:
| Branch | uTest |
| [14195|https://github.com/cooldoger/cassandra/tree/14195] | 
[!https://circleci.com/gh/cooldoger/cassandra/tree/14195.svg?style=svg!|https://circleci.com/gh/cooldoger/cassandra/tree/14195]
 |

> CommitLogSegmentManagerCDCTest is flaky
> ---
>
> Key: CASSANDRA-14195
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14195
> Project: Cassandra
>  Issue Type: Bug
>  Components: Testing
>Reporter: Ariel Weisberg
>Assignee: Jay Zhuang
>Priority: Major
>
> This fails fairly reliably in CircleCI and in a few minutes if you run it in 
> a loop on a MacOS laptop.
> I see two failures.
> {noformat}
> [junit] Testcase: 
> testRetainLinkOnDiscardCDC(org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDCTest):
>Caused an ERROR
> [junit] Rejecting mutation to keyspace cql_test_keyspace. Free up space 
> in build/test/cassandra/cdc_raw:0 by processing CDC logs.
> [junit] org.apache.cassandra.exceptions.CDCWriteException: Rejecting 
> mutation to keyspace cql_test_keyspace. Free up space in 
> build/test/cassandra/cdc_raw:0 by processing CDC logs.
> [junit]   at 
> org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDC.throwIfForbidden(CommitLogSegmentManagerCDC.java:136)
> [junit]   at 
> org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDC.allocate(CommitLogSegmentManagerCDC.java:108)
> [junit]   at 
> org.apache.cassandra.db.commitlog.CommitLog.add(CommitLog.java:272)
> [junit]   at 
> org.apache.cassandra.db.Keyspace.applyInternal(Keyspace.java:604)
> [junit]   at org.apache.cassandra.db.Keyspace.apply(Keyspace.java:481)
> [junit]   at org.apache.cassandra.db.Mutation.apply(Mutation.java:191)
> [junit]   at org.apache.cassandra.db.Mutation.apply(Mutation.java:196)
> [junit]   at org.apache.cassandra.db.Mutation.apply(Mutation.java:205)
> [junit]   at 
> org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDCTest.testRetainLinkOnDiscardCDC(CommitLogSegmentManagerCDCTest.java:256)
> {noformat}
> and
> {noformat}
> [junit] Testcase: 
> testCompletedFlag(org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDCTest):
> FAILED
> [junit] Index file not written: 
> build/test/cassandra/cdc_raw:0/CommitLog-7-1517005121474_cdc.idx
> [junit] junit.framework.AssertionFailedError: Index file not written: 
> build/test/cassandra/cdc_raw:0/CommitLog-7-1517005121474_cdc.idx
> [junit]   at 
> org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDCTest.testCompletedFlag(CommitLogSegmentManagerCDCTest.java:210)
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org