[jira] [Commented] (CASSANDRA-14322) Cassandra NodeTool clientstats should show SSL Cipher

2018-03-19 Thread Dinesh Joshi (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-14322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16405135#comment-16405135
 ] 

Dinesh Joshi commented on CASSANDRA-14322:
--

[~jasobrown] thank you!

> Cassandra NodeTool clientstats should show SSL Cipher
> -
>
> Key: CASSANDRA-14322
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14322
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Dinesh Joshi
>Assignee: Dinesh Joshi
>Priority: Minor
> Fix For: 4.0
>
>
> Currently nodetool prints out some information that does not include the SSL 
> Cipher being used by the client. It would be helpful to add this in for 
> better visibility.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-14322) Cassandra NodeTool clientstats should show SSL Cipher

2018-03-19 Thread Dinesh Joshi (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-14322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16405112#comment-16405112
 ] 

Dinesh Joshi commented on CASSANDRA-14322:
--

I have rebased my patch on trunk since there were some overlapping changes that 
would've caused conflicts.

> Cassandra NodeTool clientstats should show SSL Cipher
> -
>
> Key: CASSANDRA-14322
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14322
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Dinesh Joshi
>Assignee: Dinesh Joshi
>Priority: Minor
>
> Currently nodetool prints out some information that does not include the SSL 
> Cipher being used by the client. It would be helpful to add this in for 
> better visibility.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-14322) Cassandra NodeTool clientstats should show SSL Cipher

2018-03-19 Thread Dinesh Joshi (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-14322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16405088#comment-16405088
 ] 

Dinesh Joshi commented on CASSANDRA-14322:
--

[~iamaleksey] gave me some feedback over IRC that I have incorporated in the 
PR. Looks a lot better now.

> Cassandra NodeTool clientstats should show SSL Cipher
> -
>
> Key: CASSANDRA-14322
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14322
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Dinesh Joshi
>Assignee: Dinesh Joshi
>Priority: Minor
>
> Currently nodetool prints out some information that does not include the SSL 
> Cipher being used by the client. It would be helpful to add this in for 
> better visibility.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-14322) Cassandra NodeTool clientstats should show SSL Cipher

2018-03-19 Thread Dinesh Joshi (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-14322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16405045#comment-16405045
 ] 

Dinesh Joshi commented on CASSANDRA-14322:
--

Hi [~jasobrown], I have addressed #2 and updated my commit. [~iamaleksey] and I 
settled on using {{undefined}} for missing driver information. So keep things 
consistent, I used {{undefined}} here.

> Cassandra NodeTool clientstats should show SSL Cipher
> -
>
> Key: CASSANDRA-14322
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14322
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Dinesh Joshi
>Assignee: Dinesh Joshi
>Priority: Minor
>
> Currently nodetool prints out some information that does not include the SSL 
> Cipher being used by the client. It would be helpful to add this in for 
> better visibility.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-14322) Cassandra NodeTool clientstats should show SSL Cipher

2018-03-19 Thread Jason Brown (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-14322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16404713#comment-16404713
 ] 

Jason Brown commented on CASSANDRA-14322:
-

two minor points:

- I'm not a fan of printing {{"undefined"}} when the connection is not using 
ssl. Maybe {{"--"}} is better? 
- As long as we're adding the cipher suite, should we print out the protocol, 
as well?


> Cassandra NodeTool clientstats should show SSL Cipher
> -
>
> Key: CASSANDRA-14322
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14322
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Dinesh Joshi
>Assignee: Dinesh Joshi
>Priority: Minor
>
> Currently nodetool prints out some information that does not include the SSL 
> Cipher being used by the client. It would be helpful to add this in for 
> better visibility.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-14322) Cassandra NodeTool clientstats should show SSL Cipher

2018-03-17 Thread Dinesh Joshi (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-14322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16403828#comment-16403828
 ] 

Dinesh Joshi commented on CASSANDRA-14322:
--

||nodetool-cipher-suite||
|[branch|https://github.com/dineshjoshi/cassandra/tree/nodetool-cipher-suite]|
|[utests  
dtests|https://circleci.com/gh/dineshjoshi/workflows/cassandra/tree/nodetool-cipher-suite]|
||

> Cassandra NodeTool clientstats should show SSL Cipher
> -
>
> Key: CASSANDRA-14322
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14322
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Dinesh Joshi
>Assignee: Dinesh Joshi
>Priority: Minor
>
> Currently nodetool prints out some information that does not include the SSL 
> Cipher being used by the client. It would be helpful to add this in for 
> better visibility.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org