[jira] [Commented] (CASSANDRA-15246) Add more information around commit message format expected for a patch
[ https://issues.apache.org/jira/browse/CASSANDRA-15246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16903095#comment-16903095 ] Sumanth Pasupuleti commented on CASSANDRA-15246: Thanks [~zznate]. Realized I was not up to date w.r.t. documentation patch submission. This is a much easier workflow. Here is the pull request: https://github.com/apache/cassandra/pull/338. I guess this may also imply I will have to rework my patch around release lifecycle in https://issues.apache.org/jira/browse/CASSANDRA-15249. Will be on it soon. > Add more information around commit message format expected for a patch > -- > > Key: CASSANDRA-15246 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15246 > Project: Cassandra > Issue Type: Task > Components: Documentation/Website >Reporter: Sumanth Pasupuleti >Assignee: Sumanth Pasupuleti >Priority: Normal > Labels: pull-request-available > Fix For: 4.0 > > Attachments: patch_commit_message.patch > > Time Spent: 10m > Remaining Estimate: 0h > > This is primarily from the suggestion > https://issues.apache.org/jira/browse/CASSANDRA-15013?focusedCommentId=16885255&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16885255, > to have the expected commit message format documented. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15246) Add more information around commit message format expected for a patch
[ https://issues.apache.org/jira/browse/CASSANDRA-15246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16902542#comment-16902542 ] Nate McCall commented on CASSANDRA-15246: - In the process of updating everything, I realized we have changed this worflow substantially recently. [~sumanth.pasupuleti] Please see the following: http://cassandra.apache.org/doc/latest/development/documentation.html#github-based-work-flow as [~benedict] was correct about the location. Create the PR and we'll take it from there. CC/ [~mshuler] because in looking through the (thankfully detailed) SVN log for the site, i'm going to have some questions for that step... > Add more information around commit message format expected for a patch > -- > > Key: CASSANDRA-15246 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15246 > Project: Cassandra > Issue Type: Task > Components: Documentation/Website >Reporter: Sumanth Pasupuleti >Assignee: Sumanth Pasupuleti >Priority: Normal > Fix For: 4.0 > > Attachments: patch_commit_message.patch > > > This is primarily from the suggestion > https://issues.apache.org/jira/browse/CASSANDRA-15013?focusedCommentId=16885255&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16885255, > to have the expected commit message format documented. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15246) Add more information around commit message format expected for a patch
[ https://issues.apache.org/jira/browse/CASSANDRA-15246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16902504#comment-16902504 ] Nate McCall commented on CASSANDRA-15246: - LGTM as well. I'll make the necessary SVN incantations to get this added and published. Thanks, [~sumanth.pasupuleti]! > Add more information around commit message format expected for a patch > -- > > Key: CASSANDRA-15246 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15246 > Project: Cassandra > Issue Type: Task > Components: Documentation/Website >Reporter: Sumanth Pasupuleti >Assignee: Sumanth Pasupuleti >Priority: Normal > Fix For: 4.0 > > Attachments: patch_commit_message.patch > > > This is primarily from the suggestion > https://issues.apache.org/jira/browse/CASSANDRA-15013?focusedCommentId=16885255&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16885255, > to have the expected commit message format documented. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15246) Add more information around commit message format expected for a patch
[ https://issues.apache.org/jira/browse/CASSANDRA-15246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16902400#comment-16902400 ] Sumanth Pasupuleti commented on CASSANDRA-15246: [~benedict] AFAIK, this is the location of the website https://svn.apache.org/repos/asf/cassandra/site/src/ Nate helped commit a website patch (blog on zero copy testing) I submitted in the past https://issues.apache.org/jira/browse/CASSANDRA-14765. > Add more information around commit message format expected for a patch > -- > > Key: CASSANDRA-15246 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15246 > Project: Cassandra > Issue Type: Task > Components: Documentation/Website >Reporter: Sumanth Pasupuleti >Assignee: Sumanth Pasupuleti >Priority: Normal > Fix For: 4.0 > > Attachments: patch_commit_message.patch > > > This is primarily from the suggestion > https://issues.apache.org/jira/browse/CASSANDRA-15013?focusedCommentId=16885255&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16885255, > to have the expected commit message format documented. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15246) Add more information around commit message format expected for a patch
[ https://issues.apache.org/jira/browse/CASSANDRA-15246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16901195#comment-16901195 ] Benedict commented on CASSANDRA-15246: -- Looks reasonable, but I'm not sure where the docs and website stuff actually lives? The patch doesn't apply to trunk, so after that I'm flummoxed. I would have assumed it would be a modification to docs/source/development/how_to_commit.rst, but honestly I haven't a clue about this side of things. > Add more information around commit message format expected for a patch > -- > > Key: CASSANDRA-15246 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15246 > Project: Cassandra > Issue Type: Task > Components: Documentation/Website >Reporter: Sumanth Pasupuleti >Assignee: Sumanth Pasupuleti >Priority: Normal > Fix For: 4.0 > > Attachments: patch_commit_message.patch > > > This is primarily from the suggestion > https://issues.apache.org/jira/browse/CASSANDRA-15013?focusedCommentId=16885255&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16885255, > to have the expected commit message format documented. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15246) Add more information around commit message format expected for a patch
[ https://issues.apache.org/jira/browse/CASSANDRA-15246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16892287#comment-16892287 ] Sumanth Pasupuleti commented on CASSANDRA-15246: Patch attached, to add following commit message format as a recommendation when submitting a patch: " patch by ; reviewed by for CASSANDRA-# " > Add more information around commit message format expected for a patch > -- > > Key: CASSANDRA-15246 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15246 > Project: Cassandra > Issue Type: Task > Components: Documentation/Website >Reporter: Sumanth Pasupuleti >Assignee: Sumanth Pasupuleti >Priority: Normal > Attachments: patch_commit_message.patch > > > This is primarily from the suggestion > https://issues.apache.org/jira/browse/CASSANDRA-15013?focusedCommentId=16885255&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16885255, > to have the expected commit message format documented. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
