[jira] [Commented] (CASSANDRA-16225) Followup CASSANDRA-14554
[ https://issues.apache.org/jira/browse/CASSANDRA-16225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17242586#comment-17242586 ] Brandon Williams commented on CASSANDRA-16225: -- Ninja'd the fix and correct changes entry in https://github.com/apache/cassandra/commit/2bcbd92a25c420b30cc8cc0eb8b266d9889ea973 > Followup CASSANDRA-14554 > > > Key: CASSANDRA-16225 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16225 > Project: Cassandra > Issue Type: Bug > Components: Messaging/Internode >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0-beta, 4.0-beta4, 3.0.24, 3.11.10 > > > As per [~stefania]'s advice, additional synchronization should be added to > LogTransaction.java. Without synchronization, we could have corrupted txn log > files with JBOD. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16225) Followup CASSANDRA-14554
[ https://issues.apache.org/jira/browse/CASSANDRA-16225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17241197#comment-17241197 ] Ekaterina Dimitrova commented on CASSANDRA-16225: - Thanks [~psy...@t-online.de], do I understand correctly that no full CI run is expected and I can ask [~brandon.williams] Brandon for this ninja fix commit, if he doesn't have any concerns? > Followup CASSANDRA-14554 > > > Key: CASSANDRA-16225 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16225 > Project: Cassandra > Issue Type: Bug > Components: Messaging/Internode >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0-beta, 4.0-beta4, 3.0.24, 3.11.10 > > > As per [~stefania]'s advice, additional synchronization should be added to > LogTransaction.java. Without synchronization, we could have corrupted txn log > files with JBOD. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16225) Followup CASSANDRA-14554
[ https://issues.apache.org/jira/browse/CASSANDRA-16225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17236446#comment-17236446 ] Jon Meredith commented on CASSANDRA-16225: -- In-tree tests passed on my cherry-pick for trunk. > Followup CASSANDRA-14554 > > > Key: CASSANDRA-16225 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16225 > Project: Cassandra > Issue Type: Bug > Components: Messaging/Internode >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0-beta, 4.0-beta4, 3.0.24, 3.11.10 > > > As per [~stefania]'s advice, additional synchronization should be added to > LogTransaction.java. Without synchronization, we could have corrupted txn log > files with JBOD. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16225) Followup CASSANDRA-14554
[ https://issues.apache.org/jira/browse/CASSANDRA-16225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17236359#comment-17236359 ] Jon Meredith commented on CASSANDRA-16225: -- +1 on the code. No deadlock issues with callers holding different locks that I could see. I've cherry-picked it and am going to run it through CI locally against trunk. > Followup CASSANDRA-14554 > > > Key: CASSANDRA-16225 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16225 > Project: Cassandra > Issue Type: Bug > Components: Messaging/Internode >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0-beta, 4.0-beta4, 3.0.24, 3.11.10 > > > As per [~stefania]'s advice, additional synchronization should be added to > LogTransaction.java. Without synchronization, we could have corrupted txn log > files with JBOD. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16225) Followup CASSANDRA-14554
[ https://issues.apache.org/jira/browse/CASSANDRA-16225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17236337#comment-17236337 ] Ekaterina Dimitrova commented on CASSANDRA-16225: - [~maedhroz] pointed that I missed the synchronization for I corrected it for 3.0 [here|https://github.com/ekaterinadimitrova2/cassandra/commit/e5241dfa3c097d6078f95823272a1e1c73c2]. This could be merged to the rest of the branches. Not sure whether we need full CI run again [~maedhroz] and [~psy...@t-online.de], can you review, please? And thank you for reaching out, appreciate it! :) > Followup CASSANDRA-14554 > > > Key: CASSANDRA-16225 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16225 > Project: Cassandra > Issue Type: Bug > Components: Messaging/Internode >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0-beta, 4.0-beta4, 3.0.24, 3.11.10 > > > As per [~stefania]'s advice, additional synchronization should be added to > LogTransaction.java. Without synchronization, we could have corrupted txn log > files with JBOD. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16225) Followup CASSANDRA-14554
[ https://issues.apache.org/jira/browse/CASSANDRA-16225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17228655#comment-17228655 ] Ekaterina Dimitrova commented on CASSANDRA-16225: - Transaction files on JBOD may become out of sync, that is lines are not in the same order [trunk |https://github.com/ekaterinadimitrova2/cassandra/commit/7d4007e942202809925b0d715bc519fd8f7d5ba0] | [JAVA8 CI |https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/483/workflows/0fc7c223-7b2f-450a-9697-36cb2f295ad1] | [JAVA11CI |https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/483/workflows/2e4ca8af-217f-4778-8da9-064b24c2fbf4] [3.11 |https://github.com/ekaterinadimitrova2/cassandra/commit/bbf11d406dc88bc646cad45c4dfb8cf7135ff72c] | [CI |https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/482/workflows/5b9f1098-9b79-4477-9ca9-ef9ff8c57e84] [3.0 |https://github.com/ekaterinadimitrova2/cassandra/commit/6b72d5ebe82e7ed031708a1ad4cd45f6c76ca525] | [CI |https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/481/workflows/3b4e63f5-5f09-4520-8e0c-764410febec3] No new failures. [~brandon.williams], can you, please, review? > Followup CASSANDRA-14554 > > > Key: CASSANDRA-16225 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16225 > Project: Cassandra > Issue Type: Bug > Components: Messaging/Internode >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.0-beta > > > As per [~stefania]'s advice, additional synchronization should be added to > LogTransaction.java. Without synchronization, we could have corrupted txn log > files with JBOD. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
