[jira] [Commented] (CASSANDRA-16428) Fix selections of JDKs in debian docker images on arm64

2021-03-03 Thread Michael Semb Wever (Jira) 


[ 
https://issues.apache.org/jira/browse/CASSANDRA-16428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17294468#comment-17294468
 ] 

Michael Semb Wever commented on CASSANDRA-16428:


Have updated
- https://hub.docker.com/r/apache/cassandra-testing-ubuntu2004-java11
- 
https://hub.docker.com/r/apache/cassandra-testing-ubuntu2004-java11-w-dependencies

> Fix selections of JDKs in debian docker images on arm64
> ---
>
> Key: CASSANDRA-16428
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16428
> Project: Cassandra
>  Issue Type: Task
>  Components: Build, Packaging
>Reporter: Michael Semb Wever
>Assignee: Michael Semb Wever
>Priority: Normal
> Fix For: 2.2.20, 3.0.25, 3.11.11, 4.0-beta5, 4.0
>
>
> The debian docker 
> [image|https://github.com/apache/cassandra-builds/blob/trunk/docker/buster-image.docker]
>  used by the 
> [cassandra-deb-packaging.sh|https://github.com/apache/cassandra-builds/blob/trunk/build-scripts/cassandra-deb-packaging.sh]
>  tries to set the jdk like
> {code}
> update-java-alternatives --set java-1.8.0-openjdk-amd64
> {code}
> This won't work on arm64.
> Suggestion is to replace it with the following:
> {code}
> update-java-alternatives --set $(update-java-alternatives -l | cut -d" " -f1 
> | grep java-1.8)
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-16428) Fix selections of JDKs in debian docker images on arm64

2021-03-02 Thread Brandon Williams (Jira) 


[ 
https://issues.apache.org/jira/browse/CASSANDRA-16428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17293814#comment-17293814
 ] 

Brandon Williams commented on CASSANDRA-16428:
--

+1

> Fix selections of JDKs in debian docker images on arm64
> ---
>
> Key: CASSANDRA-16428
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16428
> Project: Cassandra
>  Issue Type: Task
>  Components: Build, Packaging
>Reporter: Michael Semb Wever
>Assignee: Michael Semb Wever
>Priority: Normal
>
> The debian docker 
> [image|https://github.com/apache/cassandra-builds/blob/trunk/docker/buster-image.docker]
>  used by the 
> [cassandra-deb-packaging.sh|https://github.com/apache/cassandra-builds/blob/trunk/build-scripts/cassandra-deb-packaging.sh]
>  tries to set the jdk like
> {code}
> update-java-alternatives --set java-1.8.0-openjdk-amd64
> {code}
> This won't work on arm64.
> Suggestion is to replace it with the following:
> {code}
> update-java-alternatives --set $(update-java-alternatives -l | cut -d" " -f1 
> | grep java-1.8)
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-16428) Fix selections of JDKs in debian docker images on arm64

2021-02-23 Thread Brandon Williams (Jira) 


[ 
https://issues.apache.org/jira/browse/CASSANDRA-16428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17289102#comment-17289102
 ] 

Brandon Williams commented on CASSANDRA-16428:
--

[~RenhaiZhao] Mck is on vacation this week, but he'll get to it when he gets 
back, everything is good here!  Thanks for your review.

> Fix selections of JDKs in debian docker images on arm64
> ---
>
> Key: CASSANDRA-16428
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16428
> Project: Cassandra
>  Issue Type: Task
>  Components: Build, Packaging
>Reporter: Michael Semb Wever
>Assignee: Michael Semb Wever
>Priority: Normal
>
> The debian docker 
> [image|https://github.com/apache/cassandra-builds/blob/trunk/docker/buster-image.docker]
>  used by the 
> [cassandra-deb-packaging.sh|https://github.com/apache/cassandra-builds/blob/trunk/build-scripts/cassandra-deb-packaging.sh]
>  tries to set the jdk like
> {code}
> update-java-alternatives --set java-1.8.0-openjdk-amd64
> {code}
> This won't work on arm64.
> Suggestion is to replace it with the following:
> {code}
> update-java-alternatives --set $(update-java-alternatives -l | cut -d" " -f1 
> | grep java-1.8)
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-16428) Fix selections of JDKs in debian docker images on arm64

2021-02-22 Thread zhaorenhai (Jira) 


[ 
https://issues.apache.org/jira/browse/CASSANDRA-16428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17288797#comment-17288797
 ] 

zhaorenhai commented on CASSANDRA-16428:


[~mck] Hi, this issue still need some other operations ? or just wait suitable 
time to merge code ?

 

> Fix selections of JDKs in debian docker images on arm64
> ---
>
> Key: CASSANDRA-16428
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16428
> Project: Cassandra
>  Issue Type: Task
>  Components: Build, Packaging
>Reporter: Michael Semb Wever
>Assignee: Michael Semb Wever
>Priority: Normal
>
> The debian docker 
> [image|https://github.com/apache/cassandra-builds/blob/trunk/docker/buster-image.docker]
>  used by the 
> [cassandra-deb-packaging.sh|https://github.com/apache/cassandra-builds/blob/trunk/build-scripts/cassandra-deb-packaging.sh]
>  tries to set the jdk like
> {code}
> update-java-alternatives --set java-1.8.0-openjdk-amd64
> {code}
> This won't work on arm64.
> Suggestion is to replace it with the following:
> {code}
> update-java-alternatives --set $(update-java-alternatives -l | cut -d" " -f1 
> | grep java-1.8)
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-16428) Fix selections of JDKs in debian docker images on arm64

2021-02-22 Thread zhaorenhai (Jira) 


[ 
https://issues.apache.org/jira/browse/CASSANDRA-16428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17288362#comment-17288362
 ] 

zhaorenhai commented on CASSANDRA-16428:


lgtm

> Fix selections of JDKs in debian docker images on arm64
> ---
>
> Key: CASSANDRA-16428
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16428
> Project: Cassandra
>  Issue Type: Task
>  Components: Build, Packaging
>Reporter: Michael Semb Wever
>Assignee: Michael Semb Wever
>Priority: Normal
>
> The debian docker 
> [image|https://github.com/apache/cassandra-builds/blob/trunk/docker/buster-image.docker]
>  used by the 
> [cassandra-deb-packaging.sh|https://github.com/apache/cassandra-builds/blob/trunk/build-scripts/cassandra-deb-packaging.sh]
>  tries to set the jdk like
> {code}
> update-java-alternatives --set java-1.8.0-openjdk-amd64
> {code}
> This won't work on arm64.
> Suggestion is to replace it with the following:
> {code}
> update-java-alternatives --set $(update-java-alternatives -l | cut -d" " -f1 
> | grep java-1.8)
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-16428) Fix selections of JDKs in debian docker images on arm64

2021-02-10 Thread Michael Semb Wever (Jira) 


[ 
https://issues.apache.org/jira/browse/CASSANDRA-16428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282697#comment-17282697
 ] 

Michael Semb Wever commented on CASSANDRA-16428:


bq. Perhaps using `dpkg --print-architecture` would be more correct?

Yes. TIL.

Patch updated.
New CI runs:
- https://ci-cassandra.apache.org/job/Cassandra-devbranch-artifacts-arm64/7/
- https://ci-cassandra.apache.org/job/Cassandra-devbranch-dtest-arm64/10/

> Fix selections of JDKs in debian docker images on arm64
> ---
>
> Key: CASSANDRA-16428
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16428
> Project: Cassandra
>  Issue Type: Task
>  Components: Build, Packaging
>Reporter: Michael Semb Wever
>Assignee: Michael Semb Wever
>Priority: Normal
>
> The debian docker 
> [image|https://github.com/apache/cassandra-builds/blob/trunk/docker/buster-image.docker]
>  used by the 
> [cassandra-deb-packaging.sh|https://github.com/apache/cassandra-builds/blob/trunk/build-scripts/cassandra-deb-packaging.sh]
>  tries to set the jdk like
> {code}
> update-java-alternatives --set java-1.8.0-openjdk-amd64
> {code}
> This won't work on arm64.
> Suggestion is to replace it with the following:
> {code}
> update-java-alternatives --set $(update-java-alternatives -l | cut -d" " -f1 
> | grep java-1.8)
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-16428) Fix selections of JDKs in debian docker images on arm64

2021-02-08 Thread Brandon Williams (Jira) 


[ 
https://issues.apache.org/jira/browse/CASSANDRA-16428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281158#comment-17281158
 ] 

Brandon Williams commented on CASSANDRA-16428:
--

Perhaps using `{{dpkg --print-architecture}}` would be more correct?

> Fix selections of JDKs in debian docker images on arm64
> ---
>
> Key: CASSANDRA-16428
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16428
> Project: Cassandra
>  Issue Type: Task
>  Components: Build, Packaging
>Reporter: Michael Semb Wever
>Assignee: Michael Semb Wever
>Priority: Normal
>
> The debian docker 
> [image|https://github.com/apache/cassandra-builds/blob/trunk/docker/buster-image.docker]
>  used by the 
> [cassandra-deb-packaging.sh|https://github.com/apache/cassandra-builds/blob/trunk/build-scripts/cassandra-deb-packaging.sh]
>  tries to set the jdk like
> {code}
> update-java-alternatives --set java-1.8.0-openjdk-amd64
> {code}
> This won't work on arm64.
> Suggestion is to replace it with the following:
> {code}
> update-java-alternatives --set $(update-java-alternatives -l | cut -d" " -f1 
> | grep java-1.8)
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-16428) Fix selections of JDKs in debian docker images on arm64

2021-02-07 Thread Michael Semb Wever (Jira) 


[ 
https://issues.apache.org/jira/browse/CASSANDRA-16428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280446#comment-17280446
 ] 

Michael Semb Wever commented on CASSANDRA-16428:


[~eduard.tudenhoefner], i need an extra pair of eyes on this patch.

I'm removing the docker {{ENV}} for JAVA_HOME, JAVA8_HOME, JAVA11_HOME. The 
.bashrc is already setting them, and as far as I can see the only place we use 
them is 
[here|https://github.com/apache/cassandra-builds/blob/trunk/build-scripts/cassandra-dtest-pytest.sh#L27-L32].

But these were only recently added as part of CASSANDRA-15835 
[here|https://github.com/apache/cassandra-builds/commit/45dc010227d75bf05e34617729de5389e62f8f99#diff-9e34dd20086a6a0c4b9f9f238fabfffae47615da0416ef2929e61e3c1290005dR84-R86].

> Fix selections of JDKs in debian docker images on arm64
> ---
>
> Key: CASSANDRA-16428
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16428
> Project: Cassandra
>  Issue Type: Task
>  Components: Build, Packaging
>Reporter: Michael Semb Wever
>Priority: Normal
>
> The debian docker 
> [image|https://github.com/apache/cassandra-builds/blob/trunk/docker/buster-image.docker]
>  used by the 
> [cassandra-deb-packaging.sh|https://github.com/apache/cassandra-builds/blob/trunk/build-scripts/cassandra-deb-packaging.sh]
>  tries to set the jdk like
> {code}
> update-java-alternatives --set java-1.8.0-openjdk-amd64
> {code}
> This won't work on arm64.
> Suggestion is to replace it with the following:
> {code}
> update-java-alternatives --set $(update-java-alternatives -l | cut -d" " -f1 
> | grep java-1.8)
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org