[jira] [Commented] (CASSANDRA-16758) Flaky ClientResourceLimitsTest
[
https://issues.apache.org/jira/browse/CASSANDRA-16758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17372045#comment-17372045
]
Berenguer Blasi commented on CASSANDRA-16758:
-
Thx [~adelapena]
> Flaky ClientResourceLimitsTest
> --
>
> Key: CASSANDRA-16758
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16758
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 4.0-rc2, 4.0, 4.0.x
>
>
> Flaky
> [ClientResourceLimitsTest|https://ci-cassandra.apache.org/job/Cassandra-4.0.0/35/testReport/junit/org.apache.cassandra.transport/ClientResourceLimitsTest/testBackPressureWhenEndpointLimitExceeded_cdc/]
> {noformat}
> Error Message
> Timed out after waiting 5 seconds for paused connections metric to increment
> due to backpressure expected:<11> but was:<24>
> Stacktrace
> junit.framework.AssertionFailedError: Timed out after waiting 5 seconds for
> paused connections metric to increment due to backpressure expected:<11> but
> was:<24>
> at org.apache.cassandra.Util.spinAssertEquals(Util.java:610)
> at
> org.apache.cassandra.transport.ClientResourceLimitsTest.backPressureTest(ClientResourceLimitsTest.java:218)
> at
> org.apache.cassandra.transport.ClientResourceLimitsTest.testBackPressureWhenEndpointLimitExceeded(ClientResourceLimitsTest.java:179)
> Standard Output
> INFO [main] 2021-06-22 01:56:41,489 YamlConfigurationLoader.java:93 -
> Configuration location:
> file:home/cassandra/cassandra/build/test/cassandra.cdc.yaml
> DEBUG [main] 2021-06-22 01:56:41,491 YamlConfigurationLoader.java:112 -
> Loading settings from
> file:home/cassandra/cassandra/build/test/cassandra.cdc.yaml
> DEBUG [main] 2021-06-22 01:56:41,551 InternalLoggerFactory.java:63 - Using
> SLF4J as the default logging framework
> DEBUG [main] 2021-06-22 01:56:41,565 PlatformDependent0.java:417 - -D
> ...[truncated 765272 chars]...
> org.apache.cassandra.transport.SimpleClient.execute(SimpleClient.java:275)
> at
> org.apache.cassandra.transport.ClientResourceLimitsTest.lambda$testQueryUpdatesConcurrentMetricsUpdate$11(ClientResourceLimitsTest.java:352)
> at java.lang.Thread.run(Thread.java:748)
> DEBUG [Test Cluster-nio-worker-0] 2021-06-22 01:57:08,353 Slf4JLogger.java:81
> - Freed 24 thread-local buffer(s) from thread: Test Cluster-nio-worker-0
> INFO [main] 2021-06-22 01:57:08,364 Server.java:171 - Stop listening for CQL
> clients
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16758) Flaky ClientResourceLimitsTest
[
https://issues.apache.org/jira/browse/CASSANDRA-16758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17371952#comment-17371952
]
Andres de la Peña commented on CASSANDRA-16758:
---
Committed to 4.0.0 as
[636e8b99226703d643cc4b30e5c30a64ce830434|https://github.com/apache/cassandra/commit/636e8b99226703d643cc4b30e5c30a64ce830434]
and merged up to
[4.0|https://github.com/apache/cassandra/commit/07803c8cd22d6918ef9bdbb6653cb90f45291ed9]
and
[trunk|https://github.com/apache/cassandra/commit/700c290350c86444c81e3ab3fa4c7988050ac82f].
> Flaky ClientResourceLimitsTest
> --
>
> Key: CASSANDRA-16758
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16758
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 4.0-rc2, 4.0, 4.0.x
>
>
> Flaky
> [ClientResourceLimitsTest|https://ci-cassandra.apache.org/job/Cassandra-4.0.0/35/testReport/junit/org.apache.cassandra.transport/ClientResourceLimitsTest/testBackPressureWhenEndpointLimitExceeded_cdc/]
> {noformat}
> Error Message
> Timed out after waiting 5 seconds for paused connections metric to increment
> due to backpressure expected:<11> but was:<24>
> Stacktrace
> junit.framework.AssertionFailedError: Timed out after waiting 5 seconds for
> paused connections metric to increment due to backpressure expected:<11> but
> was:<24>
> at org.apache.cassandra.Util.spinAssertEquals(Util.java:610)
> at
> org.apache.cassandra.transport.ClientResourceLimitsTest.backPressureTest(ClientResourceLimitsTest.java:218)
> at
> org.apache.cassandra.transport.ClientResourceLimitsTest.testBackPressureWhenEndpointLimitExceeded(ClientResourceLimitsTest.java:179)
> Standard Output
> INFO [main] 2021-06-22 01:56:41,489 YamlConfigurationLoader.java:93 -
> Configuration location:
> file:home/cassandra/cassandra/build/test/cassandra.cdc.yaml
> DEBUG [main] 2021-06-22 01:56:41,491 YamlConfigurationLoader.java:112 -
> Loading settings from
> file:home/cassandra/cassandra/build/test/cassandra.cdc.yaml
> DEBUG [main] 2021-06-22 01:56:41,551 InternalLoggerFactory.java:63 - Using
> SLF4J as the default logging framework
> DEBUG [main] 2021-06-22 01:56:41,565 PlatformDependent0.java:417 - -D
> ...[truncated 765272 chars]...
> org.apache.cassandra.transport.SimpleClient.execute(SimpleClient.java:275)
> at
> org.apache.cassandra.transport.ClientResourceLimitsTest.lambda$testQueryUpdatesConcurrentMetricsUpdate$11(ClientResourceLimitsTest.java:352)
> at java.lang.Thread.run(Thread.java:748)
> DEBUG [Test Cluster-nio-worker-0] 2021-06-22 01:57:08,353 Slf4JLogger.java:81
> - Freed 24 thread-local buffer(s) from thread: Test Cluster-nio-worker-0
> INFO [main] 2021-06-22 01:57:08,364 Server.java:171 - Stop listening for CQL
> clients
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16758) Flaky ClientResourceLimitsTest
[
https://issues.apache.org/jira/browse/CASSANDRA-16758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17371942#comment-17371942
]
Berenguer Blasi commented on CASSANDRA-16758:
-
sgtm +1
> Flaky ClientResourceLimitsTest
> --
>
> Key: CASSANDRA-16758
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16758
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 4.0-rc2, 4.0, 4.0.x
>
>
> Flaky
> [ClientResourceLimitsTest|https://ci-cassandra.apache.org/job/Cassandra-4.0.0/35/testReport/junit/org.apache.cassandra.transport/ClientResourceLimitsTest/testBackPressureWhenEndpointLimitExceeded_cdc/]
> {noformat}
> Error Message
> Timed out after waiting 5 seconds for paused connections metric to increment
> due to backpressure expected:<11> but was:<24>
> Stacktrace
> junit.framework.AssertionFailedError: Timed out after waiting 5 seconds for
> paused connections metric to increment due to backpressure expected:<11> but
> was:<24>
> at org.apache.cassandra.Util.spinAssertEquals(Util.java:610)
> at
> org.apache.cassandra.transport.ClientResourceLimitsTest.backPressureTest(ClientResourceLimitsTest.java:218)
> at
> org.apache.cassandra.transport.ClientResourceLimitsTest.testBackPressureWhenEndpointLimitExceeded(ClientResourceLimitsTest.java:179)
> Standard Output
> INFO [main] 2021-06-22 01:56:41,489 YamlConfigurationLoader.java:93 -
> Configuration location:
> file:home/cassandra/cassandra/build/test/cassandra.cdc.yaml
> DEBUG [main] 2021-06-22 01:56:41,491 YamlConfigurationLoader.java:112 -
> Loading settings from
> file:home/cassandra/cassandra/build/test/cassandra.cdc.yaml
> DEBUG [main] 2021-06-22 01:56:41,551 InternalLoggerFactory.java:63 - Using
> SLF4J as the default logging framework
> DEBUG [main] 2021-06-22 01:56:41,565 PlatformDependent0.java:417 - -D
> ...[truncated 765272 chars]...
> org.apache.cassandra.transport.SimpleClient.execute(SimpleClient.java:275)
> at
> org.apache.cassandra.transport.ClientResourceLimitsTest.lambda$testQueryUpdatesConcurrentMetricsUpdate$11(ClientResourceLimitsTest.java:352)
> at java.lang.Thread.run(Thread.java:748)
> DEBUG [Test Cluster-nio-worker-0] 2021-06-22 01:57:08,353 Slf4JLogger.java:81
> - Freed 24 thread-local buffer(s) from thread: Test Cluster-nio-worker-0
> INFO [main] 2021-06-22 01:57:08,364 Server.java:171 - Stop listening for CQL
> clients
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16758) Flaky ClientResourceLimitsTest
[
https://issues.apache.org/jira/browse/CASSANDRA-16758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17371938#comment-17371938
]
Andres de la Peña commented on CASSANDRA-16758:
---
It's good to know that we have a real Jenkins failure for the last fix :)
I don't have any outstanding work besides some trivial warning fixes. The final
patch is
[here|https://github.com/adelapena/cassandra/commit/506ebff98860a25f76d936a1a1b67b5509189cd4],
I'm running the multiplexer [one last
time|https://app.circleci.com/pipelines/github/adelapena/cassandra/624/workflows/3b758554-0e14-41e7-847b-01da79daf27f]
just in case before committing.
> Flaky ClientResourceLimitsTest
> --
>
> Key: CASSANDRA-16758
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16758
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 4.0-rc2, 4.0, 4.0.x
>
>
> Flaky
> [ClientResourceLimitsTest|https://ci-cassandra.apache.org/job/Cassandra-4.0.0/35/testReport/junit/org.apache.cassandra.transport/ClientResourceLimitsTest/testBackPressureWhenEndpointLimitExceeded_cdc/]
> {noformat}
> Error Message
> Timed out after waiting 5 seconds for paused connections metric to increment
> due to backpressure expected:<11> but was:<24>
> Stacktrace
> junit.framework.AssertionFailedError: Timed out after waiting 5 seconds for
> paused connections metric to increment due to backpressure expected:<11> but
> was:<24>
> at org.apache.cassandra.Util.spinAssertEquals(Util.java:610)
> at
> org.apache.cassandra.transport.ClientResourceLimitsTest.backPressureTest(ClientResourceLimitsTest.java:218)
> at
> org.apache.cassandra.transport.ClientResourceLimitsTest.testBackPressureWhenEndpointLimitExceeded(ClientResourceLimitsTest.java:179)
> Standard Output
> INFO [main] 2021-06-22 01:56:41,489 YamlConfigurationLoader.java:93 -
> Configuration location:
> file:home/cassandra/cassandra/build/test/cassandra.cdc.yaml
> DEBUG [main] 2021-06-22 01:56:41,491 YamlConfigurationLoader.java:112 -
> Loading settings from
> file:home/cassandra/cassandra/build/test/cassandra.cdc.yaml
> DEBUG [main] 2021-06-22 01:56:41,551 InternalLoggerFactory.java:63 - Using
> SLF4J as the default logging framework
> DEBUG [main] 2021-06-22 01:56:41,565 PlatformDependent0.java:417 - -D
> ...[truncated 765272 chars]...
> org.apache.cassandra.transport.SimpleClient.execute(SimpleClient.java:275)
> at
> org.apache.cassandra.transport.ClientResourceLimitsTest.lambda$testQueryUpdatesConcurrentMetricsUpdate$11(ClientResourceLimitsTest.java:352)
> at java.lang.Thread.run(Thread.java:748)
> DEBUG [Test Cluster-nio-worker-0] 2021-06-22 01:57:08,353 Slf4JLogger.java:81
> - Freed 24 thread-local buffer(s) from thread: Test Cluster-nio-worker-0
> INFO [main] 2021-06-22 01:57:08,364 Server.java:171 - Stop listening for CQL
> clients
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16758) Flaky ClientResourceLimitsTest
[
https://issues.apache.org/jira/browse/CASSANDRA-16758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17371929#comment-17371929
]
Berenguer Blasi commented on CASSANDRA-16758:
-
Good the concurrent update
[failed|http://https://ci-cassandra.apache.org/job/Cassandra-4.0.0-test-compression/37/jdk=jdk_11_latest,label=cassandra,split=7/testReport/junit/org.apache.cassandra.transport/ClientResourceLimitsTest/testQueryUpdatesConcurrentMetricsUpdate_compression/]
today but this should fix it. 2 birds with one stone.
> Flaky ClientResourceLimitsTest
> --
>
> Key: CASSANDRA-16758
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16758
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 4.0-rc2, 4.0, 4.0.x
>
>
> Flaky
> [ClientResourceLimitsTest|https://ci-cassandra.apache.org/job/Cassandra-4.0.0/35/testReport/junit/org.apache.cassandra.transport/ClientResourceLimitsTest/testBackPressureWhenEndpointLimitExceeded_cdc/]
> {noformat}
> Error Message
> Timed out after waiting 5 seconds for paused connections metric to increment
> due to backpressure expected:<11> but was:<24>
> Stacktrace
> junit.framework.AssertionFailedError: Timed out after waiting 5 seconds for
> paused connections metric to increment due to backpressure expected:<11> but
> was:<24>
> at org.apache.cassandra.Util.spinAssertEquals(Util.java:610)
> at
> org.apache.cassandra.transport.ClientResourceLimitsTest.backPressureTest(ClientResourceLimitsTest.java:218)
> at
> org.apache.cassandra.transport.ClientResourceLimitsTest.testBackPressureWhenEndpointLimitExceeded(ClientResourceLimitsTest.java:179)
> Standard Output
> INFO [main] 2021-06-22 01:56:41,489 YamlConfigurationLoader.java:93 -
> Configuration location:
> file:home/cassandra/cassandra/build/test/cassandra.cdc.yaml
> DEBUG [main] 2021-06-22 01:56:41,491 YamlConfigurationLoader.java:112 -
> Loading settings from
> file:home/cassandra/cassandra/build/test/cassandra.cdc.yaml
> DEBUG [main] 2021-06-22 01:56:41,551 InternalLoggerFactory.java:63 - Using
> SLF4J as the default logging framework
> DEBUG [main] 2021-06-22 01:56:41,565 PlatformDependent0.java:417 - -D
> ...[truncated 765272 chars]...
> org.apache.cassandra.transport.SimpleClient.execute(SimpleClient.java:275)
> at
> org.apache.cassandra.transport.ClientResourceLimitsTest.lambda$testQueryUpdatesConcurrentMetricsUpdate$11(ClientResourceLimitsTest.java:352)
> at java.lang.Thread.run(Thread.java:748)
> DEBUG [Test Cluster-nio-worker-0] 2021-06-22 01:57:08,353 Slf4JLogger.java:81
> - Freed 24 thread-local buffer(s) from thread: Test Cluster-nio-worker-0
> INFO [main] 2021-06-22 01:57:08,364 Server.java:171 - Stop listening for CQL
> clients
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16758) Flaky ClientResourceLimitsTest
[
https://issues.apache.org/jira/browse/CASSANDRA-16758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17371023#comment-17371023
]
Berenguer Blasi commented on CASSANDRA-16758:
-
Andres is OOO but back tomorrow so I'd rather wait for him to be around than
hijack his PR in case he had some outstanding work we're not aware of.
> Flaky ClientResourceLimitsTest
> --
>
> Key: CASSANDRA-16758
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16758
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 4.0-rc2, 4.0, 4.0.x
>
>
> Flaky
> [ClientResourceLimitsTest|https://ci-cassandra.apache.org/job/Cassandra-4.0.0/35/testReport/junit/org.apache.cassandra.transport/ClientResourceLimitsTest/testBackPressureWhenEndpointLimitExceeded_cdc/]
> {noformat}
> Error Message
> Timed out after waiting 5 seconds for paused connections metric to increment
> due to backpressure expected:<11> but was:<24>
> Stacktrace
> junit.framework.AssertionFailedError: Timed out after waiting 5 seconds for
> paused connections metric to increment due to backpressure expected:<11> but
> was:<24>
> at org.apache.cassandra.Util.spinAssertEquals(Util.java:610)
> at
> org.apache.cassandra.transport.ClientResourceLimitsTest.backPressureTest(ClientResourceLimitsTest.java:218)
> at
> org.apache.cassandra.transport.ClientResourceLimitsTest.testBackPressureWhenEndpointLimitExceeded(ClientResourceLimitsTest.java:179)
> Standard Output
> INFO [main] 2021-06-22 01:56:41,489 YamlConfigurationLoader.java:93 -
> Configuration location:
> file:home/cassandra/cassandra/build/test/cassandra.cdc.yaml
> DEBUG [main] 2021-06-22 01:56:41,491 YamlConfigurationLoader.java:112 -
> Loading settings from
> file:home/cassandra/cassandra/build/test/cassandra.cdc.yaml
> DEBUG [main] 2021-06-22 01:56:41,551 InternalLoggerFactory.java:63 - Using
> SLF4J as the default logging framework
> DEBUG [main] 2021-06-22 01:56:41,565 PlatformDependent0.java:417 - -D
> ...[truncated 765272 chars]...
> org.apache.cassandra.transport.SimpleClient.execute(SimpleClient.java:275)
> at
> org.apache.cassandra.transport.ClientResourceLimitsTest.lambda$testQueryUpdatesConcurrentMetricsUpdate$11(ClientResourceLimitsTest.java:352)
> at java.lang.Thread.run(Thread.java:748)
> DEBUG [Test Cluster-nio-worker-0] 2021-06-22 01:57:08,353 Slf4JLogger.java:81
> - Freed 24 thread-local buffer(s) from thread: Test Cluster-nio-worker-0
> INFO [main] 2021-06-22 01:57:08,364 Server.java:171 - Stop listening for CQL
> clients
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16758) Flaky ClientResourceLimitsTest
[
https://issues.apache.org/jira/browse/CASSANDRA-16758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17370737#comment-17370737
]
Caleb Rackliffe commented on CASSANDRA-16758:
-
+1 on the
[16758-4.0.0-review-caleb|https://github.com/adelapena/cassandra/compare/16758-4.0.0-review-caleb]
branch
> Flaky ClientResourceLimitsTest
> --
>
> Key: CASSANDRA-16758
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16758
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 4.0-rc2, 4.0, 4.0.x
>
>
> Flaky
> [ClientResourceLimitsTest|https://ci-cassandra.apache.org/job/Cassandra-4.0.0/35/testReport/junit/org.apache.cassandra.transport/ClientResourceLimitsTest/testBackPressureWhenEndpointLimitExceeded_cdc/]
> {noformat}
> Error Message
> Timed out after waiting 5 seconds for paused connections metric to increment
> due to backpressure expected:<11> but was:<24>
> Stacktrace
> junit.framework.AssertionFailedError: Timed out after waiting 5 seconds for
> paused connections metric to increment due to backpressure expected:<11> but
> was:<24>
> at org.apache.cassandra.Util.spinAssertEquals(Util.java:610)
> at
> org.apache.cassandra.transport.ClientResourceLimitsTest.backPressureTest(ClientResourceLimitsTest.java:218)
> at
> org.apache.cassandra.transport.ClientResourceLimitsTest.testBackPressureWhenEndpointLimitExceeded(ClientResourceLimitsTest.java:179)
> Standard Output
> INFO [main] 2021-06-22 01:56:41,489 YamlConfigurationLoader.java:93 -
> Configuration location:
> file:home/cassandra/cassandra/build/test/cassandra.cdc.yaml
> DEBUG [main] 2021-06-22 01:56:41,491 YamlConfigurationLoader.java:112 -
> Loading settings from
> file:home/cassandra/cassandra/build/test/cassandra.cdc.yaml
> DEBUG [main] 2021-06-22 01:56:41,551 InternalLoggerFactory.java:63 - Using
> SLF4J as the default logging framework
> DEBUG [main] 2021-06-22 01:56:41,565 PlatformDependent0.java:417 - -D
> ...[truncated 765272 chars]...
> org.apache.cassandra.transport.SimpleClient.execute(SimpleClient.java:275)
> at
> org.apache.cassandra.transport.ClientResourceLimitsTest.lambda$testQueryUpdatesConcurrentMetricsUpdate$11(ClientResourceLimitsTest.java:352)
> at java.lang.Thread.run(Thread.java:748)
> DEBUG [Test Cluster-nio-worker-0] 2021-06-22 01:57:08,353 Slf4JLogger.java:81
> - Freed 24 thread-local buffer(s) from thread: Test Cluster-nio-worker-0
> INFO [main] 2021-06-22 01:57:08,364 Server.java:171 - Stop listening for CQL
> clients
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16758) Flaky ClientResourceLimitsTest
[
https://issues.apache.org/jira/browse/CASSANDRA-16758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17370474#comment-17370474
]
Berenguer Blasi commented on CASSANDRA-16758:
-
I agree with you both filtering out driver noise is a superior solution. Also
if [~adelapena] managed to get 5K runs for the other failure lurking here then
I say +1 to everything and let [~adelapena] commit it. There's no point in me
duplicating the effort of building the same PR etc.
> Flaky ClientResourceLimitsTest
> --
>
> Key: CASSANDRA-16758
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16758
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 4.0-rc2, 4.0, 4.0.x
>
>
> Flaky
> [ClientResourceLimitsTest|https://ci-cassandra.apache.org/job/Cassandra-4.0.0/35/testReport/junit/org.apache.cassandra.transport/ClientResourceLimitsTest/testBackPressureWhenEndpointLimitExceeded_cdc/]
> {noformat}
> Error Message
> Timed out after waiting 5 seconds for paused connections metric to increment
> due to backpressure expected:<11> but was:<24>
> Stacktrace
> junit.framework.AssertionFailedError: Timed out after waiting 5 seconds for
> paused connections metric to increment due to backpressure expected:<11> but
> was:<24>
> at org.apache.cassandra.Util.spinAssertEquals(Util.java:610)
> at
> org.apache.cassandra.transport.ClientResourceLimitsTest.backPressureTest(ClientResourceLimitsTest.java:218)
> at
> org.apache.cassandra.transport.ClientResourceLimitsTest.testBackPressureWhenEndpointLimitExceeded(ClientResourceLimitsTest.java:179)
> Standard Output
> INFO [main] 2021-06-22 01:56:41,489 YamlConfigurationLoader.java:93 -
> Configuration location:
> file:home/cassandra/cassandra/build/test/cassandra.cdc.yaml
> DEBUG [main] 2021-06-22 01:56:41,491 YamlConfigurationLoader.java:112 -
> Loading settings from
> file:home/cassandra/cassandra/build/test/cassandra.cdc.yaml
> DEBUG [main] 2021-06-22 01:56:41,551 InternalLoggerFactory.java:63 - Using
> SLF4J as the default logging framework
> DEBUG [main] 2021-06-22 01:56:41,565 PlatformDependent0.java:417 - -D
> ...[truncated 765272 chars]...
> org.apache.cassandra.transport.SimpleClient.execute(SimpleClient.java:275)
> at
> org.apache.cassandra.transport.ClientResourceLimitsTest.lambda$testQueryUpdatesConcurrentMetricsUpdate$11(ClientResourceLimitsTest.java:352)
> at java.lang.Thread.run(Thread.java:748)
> DEBUG [Test Cluster-nio-worker-0] 2021-06-22 01:57:08,353 Slf4JLogger.java:81
> - Freed 24 thread-local buffer(s) from thread: Test Cluster-nio-worker-0
> INFO [main] 2021-06-22 01:57:08,364 Server.java:171 - Stop listening for CQL
> clients
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16758) Flaky ClientResourceLimitsTest
[
https://issues.apache.org/jira/browse/CASSANDRA-16758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17369694#comment-17369694
]
Andres de la Peña commented on CASSANDRA-16758:
---
Using the {{requireNetworkWithoutDriver}} method suggested in CASSANDRA-16663
in 4.0.0 definitely solves all the failures but the one in
{{testQueryUpdatesConcurrentMetricsUpdate}}, as it can be seen in [this
multiplexer
run|https://app.circleci.com/pipelines/github/adelapena/cassandra/614/workflows/974352fc-a2d7-453e-ae07-002280b9910e/jobs/6020].
Regarding the failure in {{testQueryUpdatesConcurrentMetricsUpdate}}, I think
that the creation of the startup message of {{SimpleClient}} is messing with
the metrics. We can simply use {{spinAssertEquals}}/{{Awaitility}} to wait
until the moment the startup message finishes and the client metric goes back
to zero, as it's done [this
way|https://github.com/adelapena/cassandra/commit/c0caca66eae1dd388a15cf415ffc25fc37190d2d].
With that change the test survives [5000
runs|https://app.circleci.com/pipelines/github/adelapena/cassandra/623/workflows/b69efc53-0e20-4466-a90a-78f162dde54b/jobs/6097].
> Flaky ClientResourceLimitsTest
> --
>
> Key: CASSANDRA-16758
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16758
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 4.0-rc2, 4.0, 4.0.x
>
>
> Flaky
> [ClientResourceLimitsTest|https://ci-cassandra.apache.org/job/Cassandra-4.0.0/35/testReport/junit/org.apache.cassandra.transport/ClientResourceLimitsTest/testBackPressureWhenEndpointLimitExceeded_cdc/]
> {noformat}
> Error Message
> Timed out after waiting 5 seconds for paused connections metric to increment
> due to backpressure expected:<11> but was:<24>
> Stacktrace
> junit.framework.AssertionFailedError: Timed out after waiting 5 seconds for
> paused connections metric to increment due to backpressure expected:<11> but
> was:<24>
> at org.apache.cassandra.Util.spinAssertEquals(Util.java:610)
> at
> org.apache.cassandra.transport.ClientResourceLimitsTest.backPressureTest(ClientResourceLimitsTest.java:218)
> at
> org.apache.cassandra.transport.ClientResourceLimitsTest.testBackPressureWhenEndpointLimitExceeded(ClientResourceLimitsTest.java:179)
> Standard Output
> INFO [main] 2021-06-22 01:56:41,489 YamlConfigurationLoader.java:93 -
> Configuration location:
> file:home/cassandra/cassandra/build/test/cassandra.cdc.yaml
> DEBUG [main] 2021-06-22 01:56:41,491 YamlConfigurationLoader.java:112 -
> Loading settings from
> file:home/cassandra/cassandra/build/test/cassandra.cdc.yaml
> DEBUG [main] 2021-06-22 01:56:41,551 InternalLoggerFactory.java:63 - Using
> SLF4J as the default logging framework
> DEBUG [main] 2021-06-22 01:56:41,565 PlatformDependent0.java:417 - -D
> ...[truncated 765272 chars]...
> org.apache.cassandra.transport.SimpleClient.execute(SimpleClient.java:275)
> at
> org.apache.cassandra.transport.ClientResourceLimitsTest.lambda$testQueryUpdatesConcurrentMetricsUpdate$11(ClientResourceLimitsTest.java:352)
> at java.lang.Thread.run(Thread.java:748)
> DEBUG [Test Cluster-nio-worker-0] 2021-06-22 01:57:08,353 Slf4JLogger.java:81
> - Freed 24 thread-local buffer(s) from thread: Test Cluster-nio-worker-0
> INFO [main] 2021-06-22 01:57:08,364 Server.java:171 - Stop listening for CQL
> clients
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16758) Flaky ClientResourceLimitsTest
[
https://issues.apache.org/jira/browse/CASSANDRA-16758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17368372#comment-17368372
]
Andres de la Peña commented on CASSANDRA-16758:
---
Indeed getting rid of the driver's interferences without relaxing the assertion
sounds like the way to go. Also it seems to fix the occasional failures in
other tests in {{ClientResourceLimitsTest}}, like [these
ones|https://app.circleci.com/pipelines/github/adelapena/cassandra/612/workflows/09dec5a9-2ac4-4595-b455-fce14aa381cf/jobs/6010].
Unfortunately {{testQueryUpdatesConcurrentMetricsUpdate}} seems
[flaky|https://app.circleci.com/pipelines/github/adelapena/cassandra/613/workflows/693bbc01-eae8-4f56-8298-2811d72892d2/jobs/6015]
with both approaches, but we can deal with that in a separate ticket if we
think that it's not related.
> Flaky ClientResourceLimitsTest
> --
>
> Key: CASSANDRA-16758
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16758
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 4.0-rc2, 4.0, 4.0.x
>
>
> Flaky
> [ClientResourceLimitsTest|https://ci-cassandra.apache.org/job/Cassandra-4.0.0/35/testReport/junit/org.apache.cassandra.transport/ClientResourceLimitsTest/testBackPressureWhenEndpointLimitExceeded_cdc/]
> {noformat}
> Error Message
> Timed out after waiting 5 seconds for paused connections metric to increment
> due to backpressure expected:<11> but was:<24>
> Stacktrace
> junit.framework.AssertionFailedError: Timed out after waiting 5 seconds for
> paused connections metric to increment due to backpressure expected:<11> but
> was:<24>
> at org.apache.cassandra.Util.spinAssertEquals(Util.java:610)
> at
> org.apache.cassandra.transport.ClientResourceLimitsTest.backPressureTest(ClientResourceLimitsTest.java:218)
> at
> org.apache.cassandra.transport.ClientResourceLimitsTest.testBackPressureWhenEndpointLimitExceeded(ClientResourceLimitsTest.java:179)
> Standard Output
> INFO [main] 2021-06-22 01:56:41,489 YamlConfigurationLoader.java:93 -
> Configuration location:
> file:home/cassandra/cassandra/build/test/cassandra.cdc.yaml
> DEBUG [main] 2021-06-22 01:56:41,491 YamlConfigurationLoader.java:112 -
> Loading settings from
> file:home/cassandra/cassandra/build/test/cassandra.cdc.yaml
> DEBUG [main] 2021-06-22 01:56:41,551 InternalLoggerFactory.java:63 - Using
> SLF4J as the default logging framework
> DEBUG [main] 2021-06-22 01:56:41,565 PlatformDependent0.java:417 - -D
> ...[truncated 765272 chars]...
> org.apache.cassandra.transport.SimpleClient.execute(SimpleClient.java:275)
> at
> org.apache.cassandra.transport.ClientResourceLimitsTest.lambda$testQueryUpdatesConcurrentMetricsUpdate$11(ClientResourceLimitsTest.java:352)
> at java.lang.Thread.run(Thread.java:748)
> DEBUG [Test Cluster-nio-worker-0] 2021-06-22 01:57:08,353 Slf4JLogger.java:81
> - Freed 24 thread-local buffer(s) from thread: Test Cluster-nio-worker-0
> INFO [main] 2021-06-22 01:57:08,364 Server.java:171 - Stop listening for CQL
> clients
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16758) Flaky ClientResourceLimitsTest
[
https://issues.apache.org/jira/browse/CASSANDRA-16758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17368318#comment-17368318
]
Caleb Rackliffe commented on CASSANDRA-16758:
-
[~bereng] I noticed this while working on CASSANDRA-16663, and I think I fixed
it there, although in a [slightly
different|https://github.com/apache/cassandra/pull/1045/files#diff-c801dfb00bc39ce5bf66a5876779350dba35def185588d13f5e492b6d79212f7R77]
way. Basically, the background queries are from the driver control
connections, which we don't actually use for {{ClientResourceLimitsTest}}. My
patch for 16663 is obviously only for trunk, but you could use it here, and
then I could just rebase my stuff and pick it up when this issue resolves. I
think we can avoid relaxing the assertion to GTE...
> Flaky ClientResourceLimitsTest
> --
>
> Key: CASSANDRA-16758
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16758
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 4.0-rc2, 4.0, 4.0.x
>
>
> Flaky
> [ClientResourceLimitsTest|https://ci-cassandra.apache.org/job/Cassandra-4.0.0/35/testReport/junit/org.apache.cassandra.transport/ClientResourceLimitsTest/testBackPressureWhenEndpointLimitExceeded_cdc/]
> {noformat}
> Error Message
> Timed out after waiting 5 seconds for paused connections metric to increment
> due to backpressure expected:<11> but was:<24>
> Stacktrace
> junit.framework.AssertionFailedError: Timed out after waiting 5 seconds for
> paused connections metric to increment due to backpressure expected:<11> but
> was:<24>
> at org.apache.cassandra.Util.spinAssertEquals(Util.java:610)
> at
> org.apache.cassandra.transport.ClientResourceLimitsTest.backPressureTest(ClientResourceLimitsTest.java:218)
> at
> org.apache.cassandra.transport.ClientResourceLimitsTest.testBackPressureWhenEndpointLimitExceeded(ClientResourceLimitsTest.java:179)
> Standard Output
> INFO [main] 2021-06-22 01:56:41,489 YamlConfigurationLoader.java:93 -
> Configuration location:
> file:home/cassandra/cassandra/build/test/cassandra.cdc.yaml
> DEBUG [main] 2021-06-22 01:56:41,491 YamlConfigurationLoader.java:112 -
> Loading settings from
> file:home/cassandra/cassandra/build/test/cassandra.cdc.yaml
> DEBUG [main] 2021-06-22 01:56:41,551 InternalLoggerFactory.java:63 - Using
> SLF4J as the default logging framework
> DEBUG [main] 2021-06-22 01:56:41,565 PlatformDependent0.java:417 - -D
> ...[truncated 765272 chars]...
> org.apache.cassandra.transport.SimpleClient.execute(SimpleClient.java:275)
> at
> org.apache.cassandra.transport.ClientResourceLimitsTest.lambda$testQueryUpdatesConcurrentMetricsUpdate$11(ClientResourceLimitsTest.java:352)
> at java.lang.Thread.run(Thread.java:748)
> DEBUG [Test Cluster-nio-worker-0] 2021-06-22 01:57:08,353 Slf4JLogger.java:81
> - Freed 24 thread-local buffer(s) from thread: Test Cluster-nio-worker-0
> INFO [main] 2021-06-22 01:57:08,364 Server.java:171 - Stop listening for CQL
> clients
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16758) Flaky ClientResourceLimitsTest
[
https://issues.apache.org/jira/browse/CASSANDRA-16758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17368013#comment-17368013
]
Berenguer Blasi commented on CASSANDRA-16758:
-
Queries in the background can alter stats. It's easy to repro locally by adding
a sleep just after starting the thread
[here|https://github.com/apache/cassandra/pull/1082/files#diff-c801dfb00bc39ce5bf66a5876779350dba35def185588d13f5e492b6d79212f7R214].
Also printing out the values in the spin assert loop makes that very obvious
and visible. Waiting for background cleaning tasks of {{CQLTtester}} is not
enough. The equality assert can't be guaranteed but a GTE can.
> Flaky ClientResourceLimitsTest
> --
>
> Key: CASSANDRA-16758
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16758
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
>
> Flaky
> [ClientResourceLimitsTest|https://ci-cassandra.apache.org/job/Cassandra-4.0.0/35/testReport/junit/org.apache.cassandra.transport/ClientResourceLimitsTest/testBackPressureWhenEndpointLimitExceeded_cdc/]
> {noformat}
> Error Message
> Timed out after waiting 5 seconds for paused connections metric to increment
> due to backpressure expected:<11> but was:<24>
> Stacktrace
> junit.framework.AssertionFailedError: Timed out after waiting 5 seconds for
> paused connections metric to increment due to backpressure expected:<11> but
> was:<24>
> at org.apache.cassandra.Util.spinAssertEquals(Util.java:610)
> at
> org.apache.cassandra.transport.ClientResourceLimitsTest.backPressureTest(ClientResourceLimitsTest.java:218)
> at
> org.apache.cassandra.transport.ClientResourceLimitsTest.testBackPressureWhenEndpointLimitExceeded(ClientResourceLimitsTest.java:179)
> Standard Output
> INFO [main] 2021-06-22 01:56:41,489 YamlConfigurationLoader.java:93 -
> Configuration location:
> file:home/cassandra/cassandra/build/test/cassandra.cdc.yaml
> DEBUG [main] 2021-06-22 01:56:41,491 YamlConfigurationLoader.java:112 -
> Loading settings from
> file:home/cassandra/cassandra/build/test/cassandra.cdc.yaml
> DEBUG [main] 2021-06-22 01:56:41,551 InternalLoggerFactory.java:63 - Using
> SLF4J as the default logging framework
> DEBUG [main] 2021-06-22 01:56:41,565 PlatformDependent0.java:417 - -D
> ...[truncated 765272 chars]...
> org.apache.cassandra.transport.SimpleClient.execute(SimpleClient.java:275)
> at
> org.apache.cassandra.transport.ClientResourceLimitsTest.lambda$testQueryUpdatesConcurrentMetricsUpdate$11(ClientResourceLimitsTest.java:352)
> at java.lang.Thread.run(Thread.java:748)
> DEBUG [Test Cluster-nio-worker-0] 2021-06-22 01:57:08,353 Slf4JLogger.java:81
> - Freed 24 thread-local buffer(s) from thread: Test Cluster-nio-worker-0
> INFO [main] 2021-06-22 01:57:08,364 Server.java:171 - Stop listening for CQL
> clients
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
