[jira] [Commented] (CASSANDRA-16896) Add soft/hard limits to local reads to protect against reading too much data in a single query
[ https://issues.apache.org/jira/browse/CASSANDRA-16896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17421289#comment-17421289 ] Marcus Eriksson commented on CASSANDRA-16896: - +1 > Add soft/hard limits to local reads to protect against reading too much data > in a single query > -- > > Key: CASSANDRA-16896 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16896 > Project: Cassandra > Issue Type: New Feature > Components: Legacy/Local Write-Read Paths >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: 4.x > > Time Spent: 19h > Remaining Estimate: 0h > > Add soft/hard limits to local reads to protect against reading too much data > in a single query. > This is an extension of the existing work to add warnings/aborts to large > partitions (CASSANDRA-16850), with the core difference is that this applies > locally rather than at the coordinator. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16896) Add soft/hard limits to local reads to protect against reading too much data in a single query
[ https://issues.apache.org/jira/browse/CASSANDRA-16896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17419955#comment-17419955 ] Caleb Rackliffe commented on CASSANDRA-16896: - Trying Apache CI again: https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/1142/ > Add soft/hard limits to local reads to protect against reading too much data > in a single query > -- > > Key: CASSANDRA-16896 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16896 > Project: Cassandra > Issue Type: New Feature > Components: Legacy/Local Write-Read Paths >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: 4.x > > Time Spent: 19h > Remaining Estimate: 0h > > Add soft/hard limits to local reads to protect against reading too much data > in a single query. > This is an extension of the existing work to add warnings/aborts to large > partitions (CASSANDRA-16850), with the core difference is that this applies > locally rather than at the coordinator. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16896) Add soft/hard limits to local reads to protect against reading too much data in a single query
[ https://issues.apache.org/jira/browse/CASSANDRA-16896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17419363#comment-17419363 ] Caleb Rackliffe commented on CASSANDRA-16896: - There were a few minor issues in the run above, nominally because STARTUP and OPTIONS messages do not properly engage with the {{CoordinatorWarnings}} thread-local management logic. I've made a pass at having those messages, which typically flow through {{InitialConnectionHandler}}, not interact with the tracking apparatus at all. branch: https://github.com/maedhroz/cassandra/commits/CASSANDRA-16896-trackable-request Circle CI: https://app.circleci.com/pipelines/github/maedhroz/cassandra?branch=CASSANDRA-16896-trackable-request Apache CI: https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/1136/ CC [~marcuse] > Add soft/hard limits to local reads to protect against reading too much data > in a single query > -- > > Key: CASSANDRA-16896 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16896 > Project: Cassandra > Issue Type: New Feature > Components: Legacy/Local Write-Read Paths >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: 4.x > > Time Spent: 19h > Remaining Estimate: 0h > > Add soft/hard limits to local reads to protect against reading too much data > in a single query. > This is an extension of the existing work to add warnings/aborts to large > partitions (CASSANDRA-16850), with the core difference is that this applies > locally rather than at the coordinator. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16896) Add soft/hard limits to local reads to protect against reading too much data in a single query
[ https://issues.apache.org/jira/browse/CASSANDRA-16896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17418270#comment-17418270 ] Caleb Rackliffe commented on CASSANDRA-16896: - [~marcuse] Just kicked off an Apache CI run here: https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/1130 > Add soft/hard limits to local reads to protect against reading too much data > in a single query > -- > > Key: CASSANDRA-16896 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16896 > Project: Cassandra > Issue Type: New Feature > Components: Legacy/Local Write-Read Paths >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: 4.x > > Time Spent: 19h > Remaining Estimate: 0h > > Add soft/hard limits to local reads to protect against reading too much data > in a single query. > This is an extension of the existing work to add warnings/aborts to large > partitions (CASSANDRA-16850), with the core difference is that this applies > locally rather than at the coordinator. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16896) Add soft/hard limits to local reads to protect against reading too much data in a single query
[ https://issues.apache.org/jira/browse/CASSANDRA-16896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17418258#comment-17418258 ] Caleb Rackliffe commented on CASSANDRA-16896: - Latest raft of commits LGTM (modulo one tiny package naming comment). > Add soft/hard limits to local reads to protect against reading too much data > in a single query > -- > > Key: CASSANDRA-16896 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16896 > Project: Cassandra > Issue Type: New Feature > Components: Legacy/Local Write-Read Paths >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: 4.x > > Time Spent: 19h > Remaining Estimate: 0h > > Add soft/hard limits to local reads to protect against reading too much data > in a single query. > This is an extension of the existing work to add warnings/aborts to large > partitions (CASSANDRA-16850), with the core difference is that this applies > locally rather than at the coordinator. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16896) Add soft/hard limits to local reads to protect against reading too much data in a single query
[ https://issues.apache.org/jira/browse/CASSANDRA-16896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17416745#comment-17416745 ] Marcus Eriksson commented on CASSANDRA-16896: - posted review on the PR > Add soft/hard limits to local reads to protect against reading too much data > in a single query > -- > > Key: CASSANDRA-16896 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16896 > Project: Cassandra > Issue Type: New Feature > Components: Legacy/Local Write-Read Paths >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: 4.x > > Time Spent: 18h 20m > Remaining Estimate: 0h > > Add soft/hard limits to local reads to protect against reading too much data > in a single query. > This is an extension of the existing work to add warnings/aborts to large > partitions (CASSANDRA-16850), with the core difference is that this applies > locally rather than at the coordinator. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16896) Add soft/hard limits to local reads to protect against reading too much data in a single query
[ https://issues.apache.org/jira/browse/CASSANDRA-16896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17413379#comment-17413379 ] Caleb Rackliffe commented on CASSANDRA-16896: - +1 > Add soft/hard limits to local reads to protect against reading too much data > in a single query > -- > > Key: CASSANDRA-16896 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16896 > Project: Cassandra > Issue Type: New Feature > Components: Legacy/Local Write-Read Paths >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: 4.x > > Time Spent: 18h > Remaining Estimate: 0h > > Add soft/hard limits to local reads to protect against reading too much data > in a single query. > This is an extension of the existing work to add warnings/aborts to large > partitions (CASSANDRA-16850), with the core difference is that this applies > locally rather than at the coordinator. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16896) Add soft/hard limits to local reads to protect against reading too much data in a single query
[ https://issues.apache.org/jira/browse/CASSANDRA-16896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17409665#comment-17409665 ] Caleb Rackliffe commented on CASSANDRA-16896: - My first pass at review is complete, and I've dropped a bunch of minor nits as well as a handful of conversation-starting comments on things we might consider changing. Overall, things are looking pretty good, and it's especially nice that we had a fresh canvas to do nested YAML configuration and could fix some issues in the existing heap accounting utilities. > Add soft/hard limits to local reads to protect against reading too much data > in a single query > -- > > Key: CASSANDRA-16896 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16896 > Project: Cassandra > Issue Type: New Feature > Components: Legacy/Local Write-Read Paths >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: 4.1 > > Time Spent: 6h 50m > Remaining Estimate: 0h > > Add soft/hard limits to local reads to protect against reading too much data > in a single query. > This is an extension of the existing work to add warnings/aborts to large > partitions (CASSANDRA-16850), with the core difference is that this applies > locally rather than at the coordinator. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16896) Add soft/hard limits to local reads to protect against reading too much data in a single query
[ https://issues.apache.org/jira/browse/CASSANDRA-16896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407726#comment-17407726 ] David Capwell commented on CASSANDRA-16896: --- good amount of red tests, but sadly those are known issues tests are passing > Add soft/hard limits to local reads to protect against reading too much data > in a single query > -- > > Key: CASSANDRA-16896 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16896 > Project: Cassandra > Issue Type: New Feature > Components: Legacy/Local Write-Read Paths >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: 4.1 > > > Add soft/hard limits to local reads to protect against reading too much data > in a single query. > This is an extension of the existing work to add warnings/aborts to large > partitions (CASSANDRA-16850), with the core difference is that this applies > locally rather than at the coordinator. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org