[jira] [Commented] (CASSANDRA-17724) Remove commons-lang dependency during build runtime

2022-07-06 Thread Dinesh Joshi (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-17724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17563425#comment-17563425
 ] 

Dinesh Joshi commented on CASSANDRA-17724:
--

+1 LGTM. thank you for the patch.

> Remove commons-lang dependency during build runtime
> ---
>
> Key: CASSANDRA-17724
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17724
> Project: Cassandra
>  Issue Type: Bug
>  Components: Build
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
> Fix For: 4.1
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> {{commons-lang}} is not a runtime dependency and a 
> {{java.lang.NoClassDefFoundError: org/apache/commons/lang/StringUtils}} 
> exception is encountered during startup when hitting the codepath in 
> {{{}StartupClusterConnectivityChecker{}}}.
> This error is encountered very infrequently, but it has the potential of 
> preventing the {{CassandraDaemon}} from starting up.
> Currently, the Cassandra project allows developers to import the 
> {{org.apache.commons.lang.\*}} namespace. The Cassandra build process should 
> fail when {{org.apache.commons.lang.\*}} namespace imports are added to the 
> code. This will prevent anyone from adding a build runtime library that is 
> not available during runtime.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-17724) Remove commons-lang dependency during build runtime

2022-06-30 Thread Francisco Guerrero (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-17724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17561134#comment-17561134
 ] 

Francisco Guerrero commented on CASSANDRA-17724:


|[trunk|https://github.com/apache/cassandra/pull/1711]|[CircleCI|https://app.circleci.com/pipelines/github/frankgh/cassandra?branch=CASSANDRA-17724=all]|
|[4.1|https://github.com/apache/cassandra/pull/1712/files]|[CircleCI|https://app.circleci.com/pipelines/github/frankgh/cassandra?branch=CASSANDRA-17724-4.1=all]|

> Remove commons-lang dependency during build runtime
> ---
>
> Key: CASSANDRA-17724
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17724
> Project: Cassandra
>  Issue Type: Bug
>  Components: Build
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
> Fix For: 4.1
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> {{commons-lang}} is not a runtime dependency and a 
> {{java.lang.NoClassDefFoundError: org/apache/commons/lang/StringUtils}} 
> exception is encountered during startup when hitting the codepath in 
> {{{}StartupClusterConnectivityChecker{}}}.
> This error is encountered very infrequently, but it has the potential of 
> preventing the {{CassandraDaemon}} from starting up.
> Currently, the Cassandra project allows developers to import the 
> {{org.apache.commons.lang.\*}} namespace. The Cassandra build process should 
> fail when {{org.apache.commons.lang.\*}} namespace imports are added to the 
> code. This will prevent anyone from adding a build runtime library that is 
> not available during runtime.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org