[jira] [Commented] (CASSANDRA-18012) Remove -l / -m / -h designation and have two options: free or paid tier circle config
[ https://issues.apache.org/jira/browse/CASSANDRA-18012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698901#comment-17698901 ] Andres de la Peña commented on CASSANDRA-18012: --- Thanks for the reviews. Committed to 3.0 as [02048cffeae4267054541f96741b16b1d0d89a20|https://github.com/apache/cassandra/commit/02048cffeae4267054541f96741b16b1d0d89a20] and merged to [3.11|https://github.com/apache/cassandra/commit/4b3cb0a772b7ab0de9dec19c148388d1aea729db], [4.0|https://github.com/apache/cassandra/commit/2aedb58123e562ef6bdb7314033512d0128329ea], [4.1|https://github.com/apache/cassandra/commit/bfc7621c8c4fa6fae87b535558c4a19cebe05a98] and [trunk|https://github.com/apache/cassandra/commit/6d62d2f4f2efb144824a433c0f8048c8a0eeed22]. > Remove -l / -m / -h designation and have two options: free or paid tier > circle config > - > > Key: CASSANDRA-18012 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18012 > Project: Cassandra > Issue Type: Task > Components: CI >Reporter: Josh McKenzie >Assignee: Andres de la Peña >Priority: Normal > Time Spent: 2h 40m > Remaining Estimate: 0h > > Currently the -h designation is wasteful and should not be used, and the -f > designation won't actually successfully run to completion. > We should default to a "free tier" config (probably print a warning that it's > generating config w/subset of full tests that should not be used to validate > commits in big warning letters) that runs a subset of the test suites for > users working on patches to validate their work (unit test only? unit + > in-jvm dtest? TBD), and add a flag to generate a config using larger > containers + parallelization for the "paid" tier for folks w/paid circleci > accounts., > It looks like -p is available right now fwiw. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18012) Remove -l / -m / -h designation and have two options: free or paid tier circle config
[ https://issues.apache.org/jira/browse/CASSANDRA-18012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698145#comment-17698145 ] Josh McKenzie commented on CASSANDRA-18012: --- +1. Thanks for taking this on Andres. > Remove -l / -m / -h designation and have two options: free or paid tier > circle config > - > > Key: CASSANDRA-18012 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18012 > Project: Cassandra > Issue Type: Task > Components: CI >Reporter: Josh McKenzie >Assignee: Andres de la Peña >Priority: Normal > Time Spent: 2h 40m > Remaining Estimate: 0h > > Currently the -h designation is wasteful and should not be used, and the -f > designation won't actually successfully run to completion. > We should default to a "free tier" config (probably print a warning that it's > generating config w/subset of full tests that should not be used to validate > commits in big warning letters) that runs a subset of the test suites for > users working on patches to validate their work (unit test only? unit + > in-jvm dtest? TBD), and add a flag to generate a config using larger > containers + parallelization for the "paid" tier for folks w/paid circleci > accounts., > It looks like -p is available right now fwiw. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18012) Remove -l / -m / -h designation and have two options: free or paid tier circle config
[ https://issues.apache.org/jira/browse/CASSANDRA-18012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697967#comment-17697967 ] Andres de la Peña commented on CASSANDRA-18012: --- Thanks for checking. [~jmckenzie] are you also ok with the changes on the other branches? They patches are identical. > Remove -l / -m / -h designation and have two options: free or paid tier > circle config > - > > Key: CASSANDRA-18012 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18012 > Project: Cassandra > Issue Type: Task > Components: CI >Reporter: Josh McKenzie >Assignee: Andres de la Peña >Priority: Normal > Time Spent: 2h 40m > Remaining Estimate: 0h > > Currently the -h designation is wasteful and should not be used, and the -f > designation won't actually successfully run to completion. > We should default to a "free tier" config (probably print a warning that it's > generating config w/subset of full tests that should not be used to validate > commits in big warning letters) that runs a subset of the test suites for > users working on patches to validate their work (unit test only? unit + > in-jvm dtest? TBD), and add a flag to generate a config using larger > containers + parallelization for the "paid" tier for folks w/paid circleci > accounts., > It looks like -p is available right now fwiw. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18012) Remove -l / -m / -h designation and have two options: free or paid tier circle config
[ https://issues.apache.org/jira/browse/CASSANDRA-18012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17694785#comment-17694785 ] Ekaterina Dimitrova commented on CASSANDRA-18012: - +1 CI looks good. I checked branches got the latest agreed changes. I tried on 3.11 (I noticed the patch was not recreated as in trunk) and there were no warnings or issue pointing we need to recreate it. I assume you tested locally every branch so not going for all of them. Thank you! > Remove -l / -m / -h designation and have two options: free or paid tier > circle config > - > > Key: CASSANDRA-18012 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18012 > Project: Cassandra > Issue Type: Task > Components: CI >Reporter: Josh McKenzie >Assignee: Andres de la Peña >Priority: Normal > Time Spent: 2h 40m > Remaining Estimate: 0h > > Currently the -h designation is wasteful and should not be used, and the -f > designation won't actually successfully run to completion. > We should default to a "free tier" config (probably print a warning that it's > generating config w/subset of full tests that should not be used to validate > commits in big warning letters) that runs a subset of the test suites for > users working on patches to validate their work (unit test only? unit + > in-jvm dtest? TBD), and add a flag to generate a config using larger > containers + parallelization for the "paid" tier for folks w/paid circleci > accounts., > It looks like -p is available right now fwiw. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18012) Remove -l / -m / -h designation and have two options: free or paid tier circle config
[ https://issues.apache.org/jira/browse/CASSANDRA-18012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17694498#comment-17694498 ] Andres de la Peña commented on CASSANDRA-18012: --- I think all review comments are addressed. Here are the patches for all branches: ||PR||CI|| |[3.0 |https://github.com/apache/cassandra/pull/2179]|[Free|https://app.circleci.com/pipelines/github/adelapena/cassandra?branch=18012-3.0] [Paid|https://app.circleci.com/pipelines/github/adelapena/cassandra?branch=18012-3.0-paid]| |[3.11 |https://github.com/apache/cassandra/pull/2180]|[Free|https://app.circleci.com/pipelines/github/adelapena/cassandra?branch=18012-3.11] [Paid|https://app.circleci.com/pipelines/github/adelapena/cassandra?branch=18012-3.11-paid]| |[4.0 |https://github.com/apache/cassandra/pull/2181]|[Free|https://app.circleci.com/pipelines/github/adelapena/cassandra?branch=18012-4.0] [Paid|https://app.circleci.com/pipelines/github/adelapena/cassandra?branch=18012-4.0-paid]| |[4.1 |https://github.com/apache/cassandra/pull/2182]|[Free|https://app.circleci.com/pipelines/github/adelapena/cassandra?branch=18012-4.1] [Paid|https://app.circleci.com/pipelines/github/adelapena/cassandra?branch=18012-4.1-paid]| |[trunk|https://github.com/apache/cassandra/pull/2163]|[Free|https://app.circleci.com/pipelines/github/adelapena/cassandra?branch=18012-trunk] [Paid|https://app.circleci.com/pipelines/github/adelapena/cassandra?branch=18012-trunk-paid]| > Remove -l / -m / -h designation and have two options: free or paid tier > circle config > - > > Key: CASSANDRA-18012 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18012 > Project: Cassandra > Issue Type: Task > Components: CI >Reporter: Josh McKenzie >Assignee: Andres de la Peña >Priority: Normal > Time Spent: 2h 40m > Remaining Estimate: 0h > > Currently the -h designation is wasteful and should not be used, and the -f > designation won't actually successfully run to completion. > We should default to a "free tier" config (probably print a warning that it's > generating config w/subset of full tests that should not be used to validate > commits in big warning letters) that runs a subset of the test suites for > users working on patches to validate their work (unit test only? unit + > in-jvm dtest? TBD), and add a flag to generate a config using larger > containers + parallelization for the "paid" tier for folks w/paid circleci > accounts., > It looks like -p is available right now fwiw. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18012) Remove -l / -m / -h designation and have two options: free or paid tier circle config
[ https://issues.apache.org/jira/browse/CASSANDRA-18012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690476#comment-17690476 ] Josh McKenzie commented on CASSANDRA-18012: --- Left some comments on the PR. There's been some niggling curiosities I've had about file naming, workflow, etc for awhile that intersect w/the changes here; figure it's worth getting some clarity. > Remove -l / -m / -h designation and have two options: free or paid tier > circle config > - > > Key: CASSANDRA-18012 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18012 > Project: Cassandra > Issue Type: Task > Components: CI >Reporter: Josh McKenzie >Assignee: Andres de la Peña >Priority: Normal > Time Spent: 20m > Remaining Estimate: 0h > > Currently the -h designation is wasteful and should not be used, and the -f > designation won't actually successfully run to completion. > We should default to a "free tier" config (probably print a warning that it's > generating config w/subset of full tests that should not be used to validate > commits in big warning letters) that runs a subset of the test suites for > users working on patches to validate their work (unit test only? unit + > in-jvm dtest? TBD), and add a flag to generate a config using larger > containers + parallelization for the "paid" tier for folks w/paid circleci > accounts., > It looks like -p is available right now fwiw. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18012) Remove -l / -m / -h designation and have two options: free or paid tier circle config
[
https://issues.apache.org/jira/browse/CASSANDRA-18012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690369#comment-17690369
]
Andres de la Peña commented on CASSANDRA-18012:
---
Thanks for the review. As for {{j8_jvm_upgrade_dtests}}, I would prefer to do
it on a separate ticket to keeps this one focused on the new flags.
[~jmckenzie] does this look good to you too? We still have many plans for
renaming workflows, removing jobs from that are unsuitable for free tier,
replace patch files by env/pipeline vars, automatically determining
parallelism, etc. Getting rid of the HIGHRES config is only a part of the work,
but doing it as soon as possible should make any other improvements on CircleCI
config easier and cheaper, since we have one less config to maintain and test.
> Remove -l / -m / -h designation and have two options: free or paid tier
> circle config
> -
>
> Key: CASSANDRA-18012
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18012
> Project: Cassandra
> Issue Type: Task
> Components: CI
>Reporter: Josh McKenzie
>Assignee: Andres de la Peña
>Priority: Normal
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently the -h designation is wasteful and should not be used, and the -f
> designation won't actually successfully run to completion.
> We should default to a "free tier" config (probably print a warning that it's
> generating config w/subset of full tests that should not be used to validate
> commits in big warning letters) that runs a subset of the test suites for
> users working on patches to validate their work (unit test only? unit +
> in-jvm dtest? TBD), and add a flag to generate a config using larger
> containers + parallelization for the "paid" tier for folks w/paid circleci
> accounts.,
> It looks like -p is available right now fwiw.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18012) Remove -l / -m / -h designation and have two options: free or paid tier circle config
[ https://issues.apache.org/jira/browse/CASSANDRA-18012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690062#comment-17690062 ] Ekaterina Dimitrova commented on CASSANDRA-18012: - I love it! The patch seems ok to me. I ran locally generate.sh with the new flags which made me realize that I made one mistake the other day in CASSANDRA-18001. j8_jvm_upgrade_dtests was also raised from Large to XLarge together with the Python Large DTests. Can you revert this here or do you want me to open a separate ticket? I don't mind opening one. > Remove -l / -m / -h designation and have two options: free or paid tier > circle config > - > > Key: CASSANDRA-18012 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18012 > Project: Cassandra > Issue Type: Task > Components: CI >Reporter: Josh McKenzie >Assignee: Andres de la Peña >Priority: Normal > Time Spent: 10m > Remaining Estimate: 0h > > Currently the -h designation is wasteful and should not be used, and the -f > designation won't actually successfully run to completion. > We should default to a "free tier" config (probably print a warning that it's > generating config w/subset of full tests that should not be used to validate > commits in big warning letters) that runs a subset of the test suites for > users working on patches to validate their work (unit test only? unit + > in-jvm dtest? TBD), and add a flag to generate a config using larger > containers + parallelization for the "paid" tier for folks w/paid circleci > accounts., > It looks like -p is available right now fwiw. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18012) Remove -l / -m / -h designation and have two options: free or paid tier circle config
[
https://issues.apache.org/jira/browse/CASSANDRA-18012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17689696#comment-17689696
]
Andres de la Peña commented on CASSANDRA-18012:
---
[This PR for {{trunk}}|https://github.com/apache/cassandra/pull/2163] removes
the HIGHRES config and renames the LOWRES/MIDRES config to simply FREE/PAID.
As for the {{generate.sh}} script, it replaces the -l/-m/-h flags by -f/-p,
meaning free and paid tier configs.
Since the new -f flag collides with flag that is used to force the setting of
unknown env vars, I have renamed that flag to -i (for "ignore unknown env
vars"). That flag is probably not very commonly used.
If the approach and the new names look good I'll add patches for the rest of
the branches.
> Remove -l / -m / -h designation and have two options: free or paid tier
> circle config
> -
>
> Key: CASSANDRA-18012
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18012
> Project: Cassandra
> Issue Type: Task
> Components: CI
>Reporter: Josh McKenzie
>Assignee: Andres de la Peña
>Priority: Normal
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently the -h designation is wasteful and should not be used, and the -f
> designation won't actually successfully run to completion.
> We should default to a "free tier" config (probably print a warning that it's
> generating config w/subset of full tests that should not be used to validate
> commits in big warning letters) that runs a subset of the test suites for
> users working on patches to validate their work (unit test only? unit +
> in-jvm dtest? TBD), and add a flag to generate a config using larger
> containers + parallelization for the "paid" tier for folks w/paid circleci
> accounts.,
> It looks like -p is available right now fwiw.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18012) Remove -l / -m / -h designation and have two options: free or paid tier circle config
[ https://issues.apache.org/jira/browse/CASSANDRA-18012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17688150#comment-17688150 ] Ekaterina Dimitrova commented on CASSANDRA-18012: - As a good first step we suggest here to remove HIGHRES and leave MIDRES only as the only paid one. This will significantly simplify and reduce time, effort, credits spend on updating CircleCI config CC [~adelapena] and [~dcapwell] > Remove -l / -m / -h designation and have two options: free or paid tier > circle config > - > > Key: CASSANDRA-18012 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18012 > Project: Cassandra > Issue Type: Task > Components: CI >Reporter: Josh McKenzie >Priority: Normal > > Currently the -h designation is wasteful and should not be used, and the -f > designation won't actually successfully run to completion. > We should default to a "free tier" config (probably print a warning that it's > generating config w/subset of full tests that should not be used to validate > commits in big warning letters) that runs a subset of the test suites for > users working on patches to validate their work (unit test only? unit + > in-jvm dtest? TBD), and add a flag to generate a config using larger > containers + parallelization for the "paid" tier for folks w/paid circleci > accounts., > It looks like -p is available right now fwiw. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18012) Remove -l / -m / -h designation and have two options: free or paid tier circle config
[
https://issues.apache.org/jira/browse/CASSANDRA-18012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17632463#comment-17632463
]
Andres de la Peña commented on CASSANDRA-18012:
---
{quote}and the -f designation won't actually successfully run to completion.
{quote}
I think you meant {{{}-l{}}}, the flag for setting lower resources. {{-f}} is
used to force the acceptance of unknown env vars, which is not related to the
resorce usage.
{quote}all that needs to happen is to remove the -h and -f from the script.
This would include removing the check for $hires and $check_env_vars variables
as the code blocks associated with same.
{quote}
{{$check_env_vars}} doesn't have any relation with the resources config. Maybe
the mention of {{-f}} instead of {{-l}} led to think that it was related to the
resources config.
{quote}(probably print a warning that it's generating config w/subset of full
tests that should not be used to validate commits in big warning letters)
{quote}
Perhaps we could also use a different workflow name for each of the two
configs, that should be hard to miss on the GUI.
> Remove -l / -m / -h designation and have two options: free or paid tier
> circle config
> -
>
> Key: CASSANDRA-18012
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18012
> Project: Cassandra
> Issue Type: Task
> Components: CI
>Reporter: Josh McKenzie
>Priority: Normal
>
> Currently the -h designation is wasteful and should not be used, and the -f
> designation won't actually successfully run to completion.
> We should default to a "free tier" config (probably print a warning that it's
> generating config w/subset of full tests that should not be used to validate
> commits in big warning letters) that runs a subset of the test suites for
> users working on patches to validate their work (unit test only? unit +
> in-jvm dtest? TBD), and add a flag to generate a config using larger
> containers + parallelization for the "paid" tier for folks w/paid circleci
> accounts.,
> It looks like -p is available right now fwiw.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18012) Remove -l / -m / -h designation and have two options: free or paid tier circle config
[ https://issues.apache.org/jira/browse/CASSANDRA-18012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17629829#comment-17629829 ] Claude Warren commented on CASSANDRA-18012: --- >From the description it seems like all that needs to happen is to remove the >-h and -f from the script. This would include removing the check for $hires >and $check_env_vars variables as the code blocks associated with same. This means removing the code block that setup the hires yml file. Should the config-2_1.yml.high_res.patch and the config.yml.HIRES files be removed as well? > Remove -l / -m / -h designation and have two options: free or paid tier > circle config > - > > Key: CASSANDRA-18012 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18012 > Project: Cassandra > Issue Type: Task > Components: CI >Reporter: Josh McKenzie >Priority: Normal > > Currently the -h designation is wasteful and should not be used, and the -f > designation won't actually successfully run to completion. > We should default to a "free tier" config (probably print a warning that it's > generating config w/subset of full tests that should not be used to validate > commits in big warning letters) that runs a subset of the test suites for > users working on patches to validate their work (unit test only? unit + > in-jvm dtest? TBD), and add a flag to generate a config using larger > containers + parallelization for the "paid" tier for folks w/paid circleci > accounts., > It looks like -p is available right now fwiw. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
