[jira] [Commented] (CASSANDRA-18584) CEP-29: NOT operator
[ https://issues.apache.org/jira/browse/CASSANDRA-18584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882748#comment-17882748 ] Ekaterina Dimitrova commented on CASSANDRA-18584: - bq. I will also clean the SAI-acceleration work in progress patch and post it in a follow up ticket next week, so it can be finished one day. CASSANDRA-19929 created > CEP-29: NOT operator > > > Key: CASSANDRA-18584 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18584 > Project: Cassandra > Issue Type: New Feature > Components: CQL/Interpreter, CQL/Semantics, CQL/Syntax, Feature/SAI >Reporter: Piotr Kolaczkowski >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 5.1 > > Time Spent: 6h 40m > Remaining Estimate: 0h > > Implement new CQL operators: > - NOT CONTAINS, > - NOT CONTAINS KEY, > - NOT IN > - NOT LIKE > https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-29%3A+CQL+NOT+operator -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18584) CEP-29: NOT operator
[ https://issues.apache.org/jira/browse/CASSANDRA-18584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17877933#comment-17877933 ] Ekaterina Dimitrova commented on CASSANDRA-18584: - CI is green from the perspective of this patch, also no new or changed tests are flaky. * pushed_notifications_test.TestPushedNotifications.test_move_single_node_localhost - CASSANDRA-19226 * test_dc_parallel_repair - test timeout * test_resumable_decommission - CASSANDRA-19542 * test_killed_wiped_node_cannot_join - TCM timeout * coordinatorIsBehindTest - CASSANDRA-19848 * testMoveToCMS - no ticket, but it was also reported on CASSANDRA-17457, I will open a ticket * testShutdownWithPendingTasks - CASSANDRA-19101 * test_consistent_range_movement_false_with_replica_down_should_succeed - seen also on CASSANDRA-19779 * test_shutdown_wiped_node_cannot_join - reported also as flaky on CASSANDRA-19651 * org.apache.cassandra.distributed.test.NativeTransportEncryptionOptionsTest - CASSANDRA-19239 Committed to https://github.com/apache/cassandra.git 8d154ba66f..e0074a31ef trunk -> trunk > CEP-29: NOT operator > > > Key: CASSANDRA-18584 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18584 > Project: Cassandra > Issue Type: New Feature > Components: CQL/Interpreter, CQL/Semantics, CQL/Syntax, Feature/SAI >Reporter: Piotr Kolaczkowski >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 5.x > > Time Spent: 6h 40m > Remaining Estimate: 0h > > Implement new CQL operators: > - NOT CONTAINS, > - NOT CONTAINS KEY, > - NOT IN > - NOT LIKE > https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-29%3A+CQL+NOT+operator -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18584) CEP-29: NOT operator
[ https://issues.apache.org/jira/browse/CASSANDRA-18584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17877913#comment-17877913 ] Ekaterina Dimitrova commented on CASSANDRA-18584: - [~blerer] also approved the PR. Rebased and squashed the branch, running final pre-commit CI - https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2731/workflows/b987651a-5280-4dd6-9895-3298456406c8 > CEP-29: NOT operator > > > Key: CASSANDRA-18584 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18584 > Project: Cassandra > Issue Type: New Feature > Components: CQL/Interpreter, CQL/Semantics, CQL/Syntax, Feature/SAI >Reporter: Piotr Kolaczkowski >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 5.x > > Time Spent: 6h 40m > Remaining Estimate: 0h > > Implement new CQL operators: > - NOT CONTAINS, > - NOT CONTAINS KEY, > - NOT IN > - NOT LIKE > https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-29%3A+CQL+NOT+operator -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18584) CEP-29: NOT operator
[ https://issues.apache.org/jira/browse/CASSANDRA-18584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17875893#comment-17875893 ] Andres de la Peña commented on CASSANDRA-18584: --- Looks great, +1 > CEP-29: NOT operator > > > Key: CASSANDRA-18584 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18584 > Project: Cassandra > Issue Type: New Feature > Components: CQL/Interpreter, CQL/Semantics, CQL/Syntax, Feature/SAI >Reporter: Piotr Kolaczkowski >Assignee: Ekaterina Dimitrova >Priority: Normal > Time Spent: 6h 40m > Remaining Estimate: 0h > > Implement new CQL operators: > - NOT CONTAINS, > - NOT CONTAINS KEY, > - NOT IN > - NOT LIKE > https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-29%3A+CQL+NOT+operator -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18584) CEP-29: NOT operator
[ https://issues.apache.org/jira/browse/CASSANDRA-18584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17875685#comment-17875685 ] Ekaterina Dimitrova commented on CASSANDRA-18584: - This is the latest rebased branch with all the changes requested and not squashed so things shifted can be easily identified, and we have the PR branch as a backup (when I force push things get lost often, so I prefer the new branch) https://github.com/ekaterinadimitrova2/cassandra/tree/C18584-final-not-squashed Clean CI: https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2730/workflows/9da99499-9514-46ab-84b2-9038e9dfafde > CEP-29: NOT operator > > > Key: CASSANDRA-18584 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18584 > Project: Cassandra > Issue Type: New Feature > Components: CQL/Interpreter, CQL/Semantics, CQL/Syntax, Feature/SAI >Reporter: Piotr Kolaczkowski >Assignee: Ekaterina Dimitrova >Priority: Normal > Time Spent: 6h 40m > Remaining Estimate: 0h > > Implement new CQL operators: > - NOT CONTAINS, > - NOT CONTAINS KEY, > - NOT IN > - NOT LIKE > https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-29%3A+CQL+NOT+operator -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18584) CEP-29: NOT operator
[ https://issues.apache.org/jira/browse/CASSANDRA-18584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17875310#comment-17875310 ] Ekaterina Dimitrova commented on CASSANDRA-18584: - Rebased branch where I squashed all the changes here: https://github.com/ekaterinadimitrova2/cassandra/tree/18584-final-squashed CI here: https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2726/workflows/2d5c888b-d5b8-4f72-9fcb-9e7ae0887940 * testProgressBarrier-_jdk11 - TCM failures, not related but I did not find a ticket. I will open one tomorrow * coordinatorIsBehindTest-_jdk11 - all tickets are closed, but it was seen again recently - https://ci-cassandra.apache.org/job/Cassandra-trunk/1895/testReport/junit/org.apache.cassandra.fuzz.ring/ConsistentBootstrapTest/Tests___jvm_dtest_jdk17_10_12___coordinatorIsBehindTest__jdk17_x86_64/. I will open a ticket. The not squashed backup branch where it can be seen what are the review commits easily: https://github.com/ekaterinadimitrova2/cassandra/tree/C18584-final-not-squashed Fixed CQL docs, some grammar is repetitive intentionally as it is in docs and it may be easier for people to read through it this way, IMHO. > CEP-29: NOT operator > > > Key: CASSANDRA-18584 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18584 > Project: Cassandra > Issue Type: New Feature > Components: CQL/Interpreter, CQL/Semantics, CQL/Syntax, Feature/SAI >Reporter: Piotr Kolaczkowski >Assignee: Ekaterina Dimitrova >Priority: Normal > Time Spent: 4h 10m > Remaining Estimate: 0h > > Implement new CQL operators: > - NOT CONTAINS, > - NOT CONTAINS KEY, > - NOT IN > - NOT LIKE > https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-29%3A+CQL+NOT+operator -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18584) CEP-29: NOT operator
[ https://issues.apache.org/jira/browse/CASSANDRA-18584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17875161#comment-17875161 ] Andres de la Peña commented on CASSANDRA-18584: --- Works for me too. > CEP-29: NOT operator > > > Key: CASSANDRA-18584 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18584 > Project: Cassandra > Issue Type: New Feature > Components: CQL/Interpreter, CQL/Semantics, CQL/Syntax, Feature/SAI >Reporter: Piotr Kolaczkowski >Assignee: Ekaterina Dimitrova >Priority: Normal > Time Spent: 3h 40m > Remaining Estimate: 0h > > Implement new CQL operators: > - NOT CONTAINS, > - NOT CONTAINS KEY, > - NOT IN > - NOT LIKE > https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-29%3A+CQL+NOT+operator -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18584) CEP-29: NOT operator
[ https://issues.apache.org/jira/browse/CASSANDRA-18584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17874899#comment-17874899 ] Benjamin Lerer commented on CASSANDRA-18584: It works for me. > CEP-29: NOT operator > > > Key: CASSANDRA-18584 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18584 > Project: Cassandra > Issue Type: New Feature > Components: CQL/Interpreter, CQL/Semantics, CQL/Syntax, Feature/SAI >Reporter: Piotr Kolaczkowski >Assignee: Ekaterina Dimitrova >Priority: Normal > Time Spent: 3h 20m > Remaining Estimate: 0h > > Implement new CQL operators: > - NOT CONTAINS, > - NOT CONTAINS KEY, > - NOT IN > - NOT LIKE > https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-29%3A+CQL+NOT+operator -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18584) CEP-29: NOT operator
[ https://issues.apache.org/jira/browse/CASSANDRA-18584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17874362#comment-17874362 ] Ekaterina Dimitrova commented on CASSANDRA-18584: - Unfortunately, the initial work on SAI indexing acceleration of the NOT operator did not take into account below two problems which are work on their own: - TTL and NOT CONTAINS in collections because they may not be null after expiring if they have other items. Example: {code:java} cqlsh:test> create table sets(pk int primary key, s set); cqlsh:test> create custom index on sets(s) using 'StorageAttachedIndex'; cqlsh:test> insert into sets(pk, s) values (1, {1, 2, 3, 4}); cqlsh:test> update sets using ttl 30 set s = s+{5} where pk = 1; // run nodetool flush here cqlsh:test> select * from sets; pk | s +- 1 | {1, 2, 3, 4, 5} // wait 30 seconds cqlsh:test> select * from sets; pk | s +-- 1 | {1, 2, 3, 4} // < see? the row does not contain 5 (1 rows) cqlsh:test> select * from sets where s not contains 5; pk | s +--- // < but we don't return it, ouch (0 rows) {code} - For NEQ and maps, current implementation will return everything that does not match the exact entry. Example: {code:java} execute("INSERT INTO %s(k, v, m) values (1, 0, {1:1, 2:2})"); execute("INSERT INTO %s(k, v, m) values (2, 0, {1:1, 3:3})"); execute("INSERT INTO %s(k, v, m) values (3, 0, {4:4, 5:5})"); execute("INSERT INTO %s(k, v, m) values (4, 0, {1:10, 2:20})"); execute("INSERT INTO %s(k, v, m) values (5, 0, {1:10, 3:30})"); execute("INSERT INTO %s(k, v, m) values (6, 0, {4:40, 5:50})"); // not equals entries test("SELECT k FROM %s WHERE m[1] != 1", !hasIndex("me"), hasIndex("me"), row(3), row(4), row(5), row(6)); {code} The SELECT statement should return only row(4) and row(5). To get it to work, we'll need the NEQ operator to have the key and to do two checks on the map entry, one to check the key and another to check the value (the Composite Type complicates things). Some workaround has already been done in some Cassandra fork to enable >, <, <=, >=, but it constitutes its own work, which is too much to be added as part of this ticket and I would also not have the time to do that. The suggestion is to open a follow-up ticket where someone can work on !=, >, <, <=, >=. As the non-SAI work is mostly done and follows the three-valued logic and other expected results correctly, I suggest we commit that work here. Then, we can open follow-up tickets for the SAI acceleration and post the ongoing WIP for someone to finish the work and fix the mentioned problems when time permits. Unfortunately, I won't be able to work on this anytime soon. [~adelapena], [~blerer], [~pkolaczk] - please confirm you are ok with the suggested plan, and I will push the latest tiny review suggestions to the NON-SAI part of the work and get it ready to commit. More info on what type of queries will be enabled is available in the linked PR. > CEP-29: NOT operator > > > Key: CASSANDRA-18584 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18584 > Project: Cassandra > Issue Type: New Feature > Components: CQL/Interpreter, CQL/Semantics, CQL/Syntax, Feature/SAI >Reporter: Piotr Kolaczkowski >Assignee: Ekaterina Dimitrova >Priority: Normal > Time Spent: 3h 20m > Remaining Estimate: 0h > > Implement new CQL operators: > - NOT CONTAINS, > - NOT CONTAINS KEY, > - NOT IN > - NOT LIKE > https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-29%3A+CQL+NOT+operator -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18584) CEP-29: NOT operator
[ https://issues.apache.org/jira/browse/CASSANDRA-18584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17869424#comment-17869424 ] Ekaterina Dimitrova commented on CASSANDRA-18584: - Some review feedback was addressed. Also, it seems we are not adding here NOT CONTAINS and NOT IN for LWTs, and we lack some testing around IN operator in LWTs. I will finish the indexing part and then get back to the LWTs in a separate commit. > CEP-29: NOT operator > > > Key: CASSANDRA-18584 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18584 > Project: Cassandra > Issue Type: New Feature > Components: CQL/Interpreter, CQL/Semantics, CQL/Syntax, Feature/SAI >Reporter: Piotr Kolaczkowski >Assignee: Piotr Kolaczkowski >Priority: Normal > Time Spent: 10m > Remaining Estimate: 0h > > Implement new CQL operators: > - NOT CONTAINS, > - NOT CONTAINS KEY, > - NOT IN > - NOT LIKE > https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-29%3A+CQL+NOT+operator -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18584) CEP-29: NOT operator
[ https://issues.apache.org/jira/browse/CASSANDRA-18584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17868799#comment-17868799 ] Ekaterina Dimitrova commented on CASSANDRA-18584: - In the meantime CASSANDRA-19620 landed, which was in conflict with the non-index part of the work. Rebase done and clean dev workflow CI available(only two known unrelated offenders): Branch: https://github.com/apache/cassandra/compare/trunk...ekaterinadimitrova2:cassandra:C18584-july-rebased2 CI: https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2713/workflows/7f55eff1-64ac-4340-8a8b-133aced58811/jobs/61045/tests One notable thing we need to confirm during the review: In kept the behavior from - CASSANDRA-13174, where we do not support slice operations on duration but we do support !=. Currently != is also slice though... for now I special cased it here: https://github.com/apache/cassandra/commit/63e00662f0bb0a56951aba17e6ea7840cd6e4147#diff-af75f1f0bfc987468f6fc7e48c63ed5e3584e51bafc752ca455fbc125f1f239aR925 and here: https://github.com/apache/cassandra/commit/63e00662f0bb0a56951aba17e6ea7840cd6e4147#diff-488811702c61931d9701d8395aa5b8fda8546036ead7e7ee592f0289d7e2fe44R356 > CEP-29: NOT operator > > > Key: CASSANDRA-18584 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18584 > Project: Cassandra > Issue Type: New Feature > Components: CQL/Interpreter, CQL/Semantics, CQL/Syntax, Feature/SAI >Reporter: Piotr Kolaczkowski >Assignee: Piotr Kolaczkowski >Priority: Normal > > Implement new CQL operators: > - NOT CONTAINS, > - NOT CONTAINS KEY, > - NOT IN > - NOT LIKE > https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-29%3A+CQL+NOT+operator -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18584) CEP-29: NOT operator
[ https://issues.apache.org/jira/browse/CASSANDRA-18584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17868497#comment-17868497 ] Ekaterina Dimitrova commented on CASSANDRA-18584: - The non-SAI part is ready, and we have a clean preliminary dev workflow CI run. https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2711/workflows/2009834b-410f-407c-88dd-f238beb083cf https://github.com/apache/cassandra/compare/trunk...ekaterinadimitrova2:cassandra:C18584-july-rebased I started looking into the indexing part. > CEP-29: NOT operator > > > Key: CASSANDRA-18584 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18584 > Project: Cassandra > Issue Type: New Feature > Components: CQL/Interpreter, CQL/Semantics, CQL/Syntax, Feature/SAI >Reporter: Piotr Kolaczkowski >Assignee: Piotr Kolaczkowski >Priority: Normal > > Implement new CQL operators: > - NOT CONTAINS, > - NOT CONTAINS KEY, > - NOT IN > - NOT LIKE > https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-29%3A+CQL+NOT+operator -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18584) CEP-29: NOT operator
[ https://issues.apache.org/jira/browse/CASSANDRA-18584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17868390#comment-17868390 ] Ekaterina Dimitrova commented on CASSANDRA-18584: - bq. The non-SAI part is ready, and the tests are clean. I have to finish the SAI part, and I will post a branch for review. Got pulled. Rebased yesterday, but there are some weird failures around memtables size with the non-SAI patch. I will look into those and then move to the SAI part. > CEP-29: NOT operator > > > Key: CASSANDRA-18584 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18584 > Project: Cassandra > Issue Type: New Feature > Components: CQL/Interpreter, CQL/Semantics, CQL/Syntax, Feature/SAI >Reporter: Piotr Kolaczkowski >Assignee: Piotr Kolaczkowski >Priority: Normal > > Implement new CQL operators: > - NOT CONTAINS, > - NOT CONTAINS KEY, > - NOT IN > - NOT LIKE > https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-29%3A+CQL+NOT+operator -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18584) CEP-29: NOT operator
[ https://issues.apache.org/jira/browse/CASSANDRA-18584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851803#comment-17851803 ] Ekaterina Dimitrova commented on CASSANDRA-18584: - {quote}I am working on a patch that refactor the relation/restrictions hierarchy. It should makes the code easier to modify while making it also less errors prone. {quote} That work was committed - CASSANDRA-19341 I took over the rebase from [~blerer]. The non-SAI part is ready, and the tests are clean. I have to finish the SAI part, and I will post a branch for review. > CEP-29: NOT operator > > > Key: CASSANDRA-18584 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18584 > Project: Cassandra > Issue Type: New Feature > Components: CQL/Interpreter, CQL/Semantics, CQL/Syntax, Feature/SAI >Reporter: Piotr Kolaczkowski >Assignee: Piotr Kolaczkowski >Priority: Normal > > Implement new CQL operators: > - NOT CONTAINS, > - NOT CONTAINS KEY, > - NOT IN > - NOT LIKE > https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-29%3A+CQL+NOT+operator -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18584) CEP-29: NOT operator
[ https://issues.apache.org/jira/browse/CASSANDRA-18584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17810974#comment-17810974 ] Benjamin Lerer commented on CASSANDRA-18584: I am working on a patch that refactor the relation/restrictions hierarchy. It should makes the code easier to modify while making it also less errors prone. I believe that this refactoring would also simplify the current patch. I have not opened a ticket yet but I will. > CEP-29: NOT operator > > > Key: CASSANDRA-18584 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18584 > Project: Cassandra > Issue Type: New Feature > Components: CQL/Interpreter, CQL/Semantics, CQL/Syntax, Feature/SAI >Reporter: Piotr Kolaczkowski >Assignee: Piotr Kolaczkowski >Priority: Normal > > Implement new CQL operators: > - NOT CONTAINS, > - NOT CONTAINS KEY, > - NOT IN > - NOT LIKE > https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-29%3A+CQL+NOT+operator -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18584) CEP-29: NOT operator
[ https://issues.apache.org/jira/browse/CASSANDRA-18584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17752083#comment-17752083 ] Piotr Kolaczkowski commented on CASSANDRA-18584: Because LIKE operator is habdled neither by ALLOW FILTERING nor SAI, we'd like to postpone NOT LIKE implementation until we have more complete LIKE implementation first. WDYT? > CEP-29: NOT operator > > > Key: CASSANDRA-18584 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18584 > Project: Cassandra > Issue Type: New Feature > Components: CQL/Interpreter, CQL/Semantics, CQL/Syntax, Feature/SAI >Reporter: Piotr Kolaczkowski >Assignee: Piotr Kolaczkowski >Priority: Normal > > Implement new CQL operators: > - NOT CONTAINS, > - NOT CONTAINS KEY, > - NOT IN > - NOT LIKE > https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-29%3A+CQL+NOT+operator -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18584) CEP-29: NOT operator
[ https://issues.apache.org/jira/browse/CASSANDRA-18584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17731631#comment-17731631 ] Piotr Kolaczkowski commented on CASSANDRA-18584: Current status: - Implemented: -- NOT CONTANS, NOT CONTAINS KEY, != for map entries implemented with ALLOW FILTERING -- NOT IN with ALLOW FILTERING -- NOT IN on clustering keys w/o ALLOW FILTERING -- unit tests for all above - All {{org.apache.cassandra.cql3.validation.operations}} tests pass > CEP-29: NOT operator > > > Key: CASSANDRA-18584 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18584 > Project: Cassandra > Issue Type: New Feature > Components: CQL/Interpreter, CQL/Semantics, CQL/Syntax, Feature/SAI >Reporter: Piotr Kolaczkowski >Assignee: Piotr Kolaczkowski >Priority: Normal > > Implement new CQL operators: > - NOT CONTAINS, > - NOT CONTAINS KEY, > - NOT IN > - NOT LIKE > https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-29%3A+CQL+NOT+operator -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org