[jira] [Commented] (CASSANDRA-18615) CREATE INDEX Modifications for Initial Release of SAI
[ https://issues.apache.org/jira/browse/CASSANDRA-18615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17744332#comment-17744332 ] Caleb Rackliffe commented on CASSANDRA-18615: - Thanks [~adelapena] and [~maxwellguo]. Starting commit... > CREATE INDEX Modifications for Initial Release of SAI > - > > Key: CASSANDRA-18615 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18615 > Project: Cassandra > Issue Type: Improvement > Components: CQL/Syntax, Feature/SAI >Reporter: Caleb Rackliffe >Assignee: Caleb Rackliffe >Priority: Normal > Fix For: 5.x > > Time Spent: 5h 50m > Remaining Estimate: 0h > > After a lengthy discussion on the dev list, the community seems to have > arrived at the following list of TODOs before we release SAI in 5.0: > 1.) CREATE INDEX should be expanded to support {{USING … WITH OPTIONS…}} > Essentially, we should be able to do something like {{CREATE INDEX ON tbl(v) > USING ’sai’ WITH OPTIONS = ...}} and {{CREATE INDEX ON tbl(v) USING > ‘cassandra’}} as a more specific/complete way to emulate the current behavior > of {{CREATE INDEX}}. > 2.) Allow operators to configure, in the YAML, a.) whether an index > implementation must be specified w/ USING and {{CREATE INDEX}} and b.) what > the default implementation will be, if {{USING}} isn’t required. > 3.) The defaults we ship w/ will avoid breaking existing {{CREATE INDEX}} > usage. (i.e. A default is allowed, and that default will remain ‘cassandra’, > or the legacy 2i) > With all this in place, users should be able create SAI indexes w/ the > simplest possible syntax, no defaults will change, and operators will have > the ability to change defaults to favor SAI whenever they like. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18615) CREATE INDEX Modifications for Initial Release of SAI
[ https://issues.apache.org/jira/browse/CASSANDRA-18615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17744184#comment-17744184 ] Andres de la Peña commented on CASSANDRA-18615: --- The repeated CI run shows [a single failure of most of the methods of {{StorageAttachedIndexDDLTest}}|https://app.circleci.com/pipelines/github/maedhroz/cassandra/744/workflows/8efbf733-8007-4092-8c26-e349b7fd9576/jobs/10731]. The failure seems environmental, due to an issue while binding a port to an address already in use. The other test failures ({{{}VirtualTableFromInternodeTest{}}} and JDK 17 stuff) are known issues. So I think CI results are good, +1. > CREATE INDEX Modifications for Initial Release of SAI > - > > Key: CASSANDRA-18615 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18615 > Project: Cassandra > Issue Type: Improvement > Components: CQL/Syntax, Feature/SAI >Reporter: Caleb Rackliffe >Assignee: Caleb Rackliffe >Priority: Normal > Fix For: 5.x > > Time Spent: 5h 50m > Remaining Estimate: 0h > > After a lengthy discussion on the dev list, the community seems to have > arrived at the following list of TODOs before we release SAI in 5.0: > 1.) CREATE INDEX should be expanded to support {{USING … WITH OPTIONS…}} > Essentially, we should be able to do something like {{CREATE INDEX ON tbl(v) > USING ’sai’ WITH OPTIONS = ...}} and {{CREATE INDEX ON tbl(v) USING > ‘cassandra’}} as a more specific/complete way to emulate the current behavior > of {{CREATE INDEX}}. > 2.) Allow operators to configure, in the YAML, a.) whether an index > implementation must be specified w/ USING and {{CREATE INDEX}} and b.) what > the default implementation will be, if {{USING}} isn’t required. > 3.) The defaults we ship w/ will avoid breaking existing {{CREATE INDEX}} > usage. (i.e. A default is allowed, and that default will remain ‘cassandra’, > or the legacy 2i) > With all this in place, users should be able create SAI indexes w/ the > simplest possible syntax, no defaults will change, and operators will have > the ability to change defaults to favor SAI whenever they like. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18615) CREATE INDEX Modifications for Initial Release of SAI
[ https://issues.apache.org/jira/browse/CASSANDRA-18615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17744027#comment-17744027 ] Maxwell Guo commented on CASSANDRA-18615: - Hi [~maedhroz] it seems we have some problems with [CI|https://app.circleci.com/pipelines/github/maedhroz/cassandra?branch=CASSANDRA-18615] ,some cases failed. > CREATE INDEX Modifications for Initial Release of SAI > - > > Key: CASSANDRA-18615 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18615 > Project: Cassandra > Issue Type: Improvement > Components: CQL/Syntax, Feature/SAI >Reporter: Caleb Rackliffe >Assignee: Caleb Rackliffe >Priority: Normal > Fix For: 5.x > > Time Spent: 5h 40m > Remaining Estimate: 0h > > After a lengthy discussion on the dev list, the community seems to have > arrived at the following list of TODOs before we release SAI in 5.0: > 1.) CREATE INDEX should be expanded to support {{USING … WITH OPTIONS…}} > Essentially, we should be able to do something like {{CREATE INDEX ON tbl(v) > USING ’sai’ WITH OPTIONS = ...}} and {{CREATE INDEX ON tbl(v) USING > ‘cassandra’}} as a more specific/complete way to emulate the current behavior > of {{CREATE INDEX}}. > 2.) Allow operators to configure, in the YAML, a.) whether an index > implementation must be specified w/ USING and {{CREATE INDEX}} and b.) what > the default implementation will be, if {{USING}} isn’t required. > 3.) The defaults we ship w/ will avoid breaking existing {{CREATE INDEX}} > usage. (i.e. A default is allowed, and that default will remain ‘cassandra’, > or the legacy 2i) > With all this in place, users should be able create SAI indexes w/ the > simplest possible syntax, no defaults will change, and operators will have > the ability to change defaults to favor SAI whenever they like. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18615) CREATE INDEX Modifications for Initial Release of SAI
[ https://issues.apache.org/jira/browse/CASSANDRA-18615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17744009#comment-17744009 ] Caleb Rackliffe commented on CASSANDRA-18615: - PR comments have been addressed and Circle [looks clean|https://app.circleci.com/pipelines/github/maedhroz/cassandra?branch=CASSANDRA-18615]. > CREATE INDEX Modifications for Initial Release of SAI > - > > Key: CASSANDRA-18615 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18615 > Project: Cassandra > Issue Type: Improvement > Components: CQL/Syntax, Feature/SAI >Reporter: Caleb Rackliffe >Assignee: Caleb Rackliffe >Priority: Normal > Fix For: 5.x > > Time Spent: 5h 40m > Remaining Estimate: 0h > > After a lengthy discussion on the dev list, the community seems to have > arrived at the following list of TODOs before we release SAI in 5.0: > 1.) CREATE INDEX should be expanded to support {{USING … WITH OPTIONS…}} > Essentially, we should be able to do something like {{CREATE INDEX ON tbl(v) > USING ’sai’ WITH OPTIONS = ...}} and {{CREATE INDEX ON tbl(v) USING > ‘cassandra’}} as a more specific/complete way to emulate the current behavior > of {{CREATE INDEX}}. > 2.) Allow operators to configure, in the YAML, a.) whether an index > implementation must be specified w/ USING and {{CREATE INDEX}} and b.) what > the default implementation will be, if {{USING}} isn’t required. > 3.) The defaults we ship w/ will avoid breaking existing {{CREATE INDEX}} > usage. (i.e. A default is allowed, and that default will remain ‘cassandra’, > or the legacy 2i) > With all this in place, users should be able create SAI indexes w/ the > simplest possible syntax, no defaults will change, and operators will have > the ability to change defaults to favor SAI whenever they like. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18615) CREATE INDEX Modifications for Initial Release of SAI
[ https://issues.apache.org/jira/browse/CASSANDRA-18615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17743780#comment-17743780 ] Andres de la Peña commented on CASSANDRA-18615: --- I like {{local_table_legacy}} or {{legacy_local_table}}, since they briefly describe the implementation and they clearly show that they are old/deprecated. > CREATE INDEX Modifications for Initial Release of SAI > - > > Key: CASSANDRA-18615 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18615 > Project: Cassandra > Issue Type: Improvement > Components: CQL/Syntax, Feature/SAI >Reporter: Caleb Rackliffe >Assignee: Caleb Rackliffe >Priority: Normal > Fix For: 5.x > > Time Spent: 5.5h > Remaining Estimate: 0h > > After a lengthy discussion on the dev list, the community seems to have > arrived at the following list of TODOs before we release SAI in 5.0: > 1.) CREATE INDEX should be expanded to support {{USING … WITH OPTIONS…}} > Essentially, we should be able to do something like {{CREATE INDEX ON tbl(v) > USING ’sai’ WITH OPTIONS = ...}} and {{CREATE INDEX ON tbl(v) USING > ‘cassandra’}} as a more specific/complete way to emulate the current behavior > of {{CREATE INDEX}}. > 2.) Allow operators to configure, in the YAML, a.) whether an index > implementation must be specified w/ USING and {{CREATE INDEX}} and b.) what > the default implementation will be, if {{USING}} isn’t required. > 3.) The defaults we ship w/ will avoid breaking existing {{CREATE INDEX}} > usage. (i.e. A default is allowed, and that default will remain ‘cassandra’, > or the legacy 2i) > With all this in place, users should be able create SAI indexes w/ the > simplest possible syntax, no defaults will change, and operators will have > the ability to change defaults to favor SAI whenever they like. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18615) CREATE INDEX Modifications for Initial Release of SAI
[ https://issues.apache.org/jira/browse/CASSANDRA-18615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741208#comment-17741208 ] Jeremiah Jordan commented on CASSANDRA-18615: - Listing some names that come to mind after reading these comments: local_table_legacy equality_only_local_table hidden_local_table I like the word local being in the name since they use the LocalPartitioner. > CREATE INDEX Modifications for Initial Release of SAI > - > > Key: CASSANDRA-18615 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18615 > Project: Cassandra > Issue Type: Improvement > Components: CQL/Syntax, Feature/SAI >Reporter: Caleb Rackliffe >Assignee: Caleb Rackliffe >Priority: Normal > Fix For: 5.x > > Time Spent: 5.5h > Remaining Estimate: 0h > > After a lengthy discussion on the dev list, the community seems to have > arrived at the following list of TODOs before we release SAI in 5.0: > 1.) CREATE INDEX should be expanded to support {{USING … WITH OPTIONS…}} > Essentially, we should be able to do something like {{CREATE INDEX ON tbl(v) > USING ’sai’ WITH OPTIONS = ...}} and {{CREATE INDEX ON tbl(v) USING > ‘cassandra’}} as a more specific/complete way to emulate the current behavior > of {{CREATE INDEX}}. > 2.) Allow operators to configure, in the YAML, a.) whether an index > implementation must be specified w/ USING and {{CREATE INDEX}} and b.) what > the default implementation will be, if {{USING}} isn’t required. > 3.) The defaults we ship w/ will avoid breaking existing {{CREATE INDEX}} > usage. (i.e. A default is allowed, and that default will remain ‘cassandra’, > or the legacy 2i) > With all this in place, users should be able create SAI indexes w/ the > simplest possible syntax, no defaults will change, and operators will have > the ability to change defaults to favor SAI whenever they like. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18615) CREATE INDEX Modifications for Initial Release of SAI
[ https://issues.apache.org/jira/browse/CASSANDRA-18615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17737398#comment-17737398 ] Caleb Rackliffe commented on CASSANDRA-18615: - [~jbellis] What about going the descriptive route, like "hidden_table" :D > CREATE INDEX Modifications for Initial Release of SAI > - > > Key: CASSANDRA-18615 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18615 > Project: Cassandra > Issue Type: Improvement > Components: CQL/Syntax, Feature/SAI >Reporter: Caleb Rackliffe >Assignee: Caleb Rackliffe >Priority: Normal > Fix For: NA > > Time Spent: 3h 10m > Remaining Estimate: 0h > > After a lengthy discussion on the dev list, the community seems to have > arrived at the following list of TODOs before we release SAI in 5.0: > 1.) CREATE INDEX should be expanded to support {{USING … WITH OPTIONS…}} > Essentially, we should be able to do something like {{CREATE INDEX ON tbl(v) > USING ’sai’ WITH OPTIONS = ...}} and {{CREATE INDEX ON tbl(v) USING > ‘cassandra’}} as a more specific/complete way to emulate the current behavior > of {{CREATE INDEX}}. > 2.) Allow operators to configure, in the YAML, a.) whether an index > implementation must be specified w/ USING and {{CREATE INDEX}} and b.) what > the default implementation will be, if {{USING}} isn’t required. > 3.) The defaults we ship w/ will avoid breaking existing {{CREATE INDEX}} > usage. (i.e. A default is allowed, and that default will remain ‘cassandra’, > or the legacy 2i) > With all this in place, users should be able create SAI indexes w/ the > simplest possible syntax, no defaults will change, and operators will have > the ability to change defaults to favor SAI whenever they like. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18615) CREATE INDEX Modifications for Initial Release of SAI
[ https://issues.apache.org/jira/browse/CASSANDRA-18615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17737381#comment-17737381 ] Jonathan Ellis commented on CASSANDRA-18615: I don't think the name `cassandra` is very descriptive to end users. How about `hash_legacy`, `equalityonly_legacy`, something like that ? > CREATE INDEX Modifications for Initial Release of SAI > - > > Key: CASSANDRA-18615 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18615 > Project: Cassandra > Issue Type: Improvement > Components: CQL/Syntax, Feature/SAI >Reporter: Caleb Rackliffe >Assignee: Caleb Rackliffe >Priority: Normal > Fix For: NA > > Time Spent: 3h 10m > Remaining Estimate: 0h > > After a lengthy discussion on the dev list, the community seems to have > arrived at the following list of TODOs before we release SAI in 5.0: > 1.) CREATE INDEX should be expanded to support {{USING … WITH OPTIONS…}} > Essentially, we should be able to do something like {{CREATE INDEX ON tbl(v) > USING ’sai’ WITH OPTIONS = ...}} and {{CREATE INDEX ON tbl(v) USING > ‘cassandra’}} as a more specific/complete way to emulate the current behavior > of {{CREATE INDEX}}. > 2.) Allow operators to configure, in the YAML, a.) whether an index > implementation must be specified w/ USING and {{CREATE INDEX}} and b.) what > the default implementation will be, if {{USING}} isn’t required. > 3.) The defaults we ship w/ will avoid breaking existing {{CREATE INDEX}} > usage. (i.e. A default is allowed, and that default will remain ‘cassandra’, > or the legacy 2i) > With all this in place, users should be able create SAI indexes w/ the > simplest possible syntax, no defaults will change, and operators will have > the ability to change defaults to favor SAI whenever they like. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18615) CREATE INDEX Modifications for Initial Release of SAI
[ https://issues.apache.org/jira/browse/CASSANDRA-18615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17737352#comment-17737352 ] Caleb Rackliffe commented on CASSANDRA-18615: - btw, the 3 unit test failures are known/pre-existing, and will be fixed either in CASSANDRA-18490 or CASSANDRA-18067. > CREATE INDEX Modifications for Initial Release of SAI > - > > Key: CASSANDRA-18615 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18615 > Project: Cassandra > Issue Type: Improvement > Components: CQL/Syntax, Feature/SAI >Reporter: Caleb Rackliffe >Assignee: Caleb Rackliffe >Priority: Normal > Fix For: NA > > Time Spent: 3h 10m > Remaining Estimate: 0h > > After a lengthy discussion on the dev list, the community seems to have > arrived at the following list of TODOs before we release SAI in 5.0: > 1.) CREATE INDEX should be expanded to support {{USING … WITH OPTIONS…}} > Essentially, we should be able to do something like {{CREATE INDEX ON tbl(v) > USING ’sai’ WITH OPTIONS = ...}} and {{CREATE INDEX ON tbl(v) USING > ‘cassandra’}} as a more specific/complete way to emulate the current behavior > of {{CREATE INDEX}}. > 2.) Allow operators to configure, in the YAML, a.) whether an index > implementation must be specified w/ USING and {{CREATE INDEX}} and b.) what > the default implementation will be, if {{USING}} isn’t required. > 3.) The defaults we ship w/ will avoid breaking existing {{CREATE INDEX}} > usage. (i.e. A default is allowed, and that default will remain ‘cassandra’, > or the legacy 2i) > With all this in place, users should be able create SAI indexes w/ the > simplest possible syntax, no defaults will change, and operators will have > the ability to change defaults to favor SAI whenever they like. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18615) CREATE INDEX Modifications for Initial Release of SAI
[ https://issues.apache.org/jira/browse/CASSANDRA-18615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17737270#comment-17737270 ] Caleb Rackliffe commented on CASSANDRA-18615: - SASI is already experimental, and the release SAI should allow us to deprecate it, then eventually remove it. Existing SASI tests that use {{CREATE CUSTOM INDEX}} haven't been touched of course, but we do not need to support or document it around the changes in this patch. > CREATE INDEX Modifications for Initial Release of SAI > - > > Key: CASSANDRA-18615 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18615 > Project: Cassandra > Issue Type: Improvement > Components: CQL/Syntax, Feature/SAI >Reporter: Caleb Rackliffe >Assignee: Caleb Rackliffe >Priority: Normal > Fix For: NA > > Time Spent: 3h 10m > Remaining Estimate: 0h > > After a lengthy discussion on the dev list, the community seems to have > arrived at the following list of TODOs before we release SAI in 5.0: > 1.) CREATE INDEX should be expanded to support {{USING … WITH OPTIONS…}} > Essentially, we should be able to do something like {{CREATE INDEX ON tbl(v) > USING ’sai’ WITH OPTIONS = ...}} and {{CREATE INDEX ON tbl(v) USING > ‘cassandra’}} as a more specific/complete way to emulate the current behavior > of {{CREATE INDEX}}. > 2.) Allow operators to configure, in the YAML, a.) whether an index > implementation must be specified w/ USING and {{CREATE INDEX}} and b.) what > the default implementation will be, if {{USING}} isn’t required. > 3.) The defaults we ship w/ will avoid breaking existing {{CREATE INDEX}} > usage. (i.e. A default is allowed, and that default will remain ‘cassandra’, > or the legacy 2i) > With all this in place, users should be able create SAI indexes w/ the > simplest possible syntax, no defaults will change, and operators will have > the ability to change defaults to favor SAI whenever they like. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18615) CREATE INDEX Modifications for Initial Release of SAI
[ https://issues.apache.org/jira/browse/CASSANDRA-18615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17736817#comment-17736817 ] Maxwell Guo commented on CASSANDRA-18615: - sasi will be completely delete when sai is released ?I did not see any sasi-related tests here. > CREATE INDEX Modifications for Initial Release of SAI > - > > Key: CASSANDRA-18615 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18615 > Project: Cassandra > Issue Type: Improvement > Components: CQL/Syntax, Feature/SAI >Reporter: Caleb Rackliffe >Assignee: Caleb Rackliffe >Priority: Normal > Fix For: NA > > Time Spent: 40m > Remaining Estimate: 0h > > After a lengthy discussion on the dev list, the community seems to have > arrived at the following list of TODOs before we release SAI in 5.0: > 1.) CREATE INDEX should be expanded to support {{USING … WITH OPTIONS…}} > Essentially, we should be able to do something like {{CREATE INDEX ON tbl(v) > USING ’sai’ WITH OPTIONS = ...}} and {{CREATE INDEX ON tbl(v) USING > ‘cassandra’}} as a more specific/complete way to emulate the current behavior > of {{CREATE INDEX}}. > 2.) Allow operators to configure, in the YAML, a.) whether an index > implementation must be specified w/ USING and {{CREATE INDEX}} and b.) what > the default implementation will be, if {{USING}} isn’t required. > 3.) The defaults we ship w/ will avoid breaking existing {{CREATE INDEX}} > usage. (i.e. A default is allowed, and that default will remain ‘cassandra’, > or the legacy 2i) > With all this in place, users should be able create SAI indexes w/ the > simplest possible syntax, no defaults will change, and operators will have > the ability to change defaults to favor SAI whenever they like. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org