[jira] [Commented] (CASSANDRA-18684) [Analytics] Minor Refactoring to Improve Code Reusability

2023-07-25 Thread Dinesh Joshi (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-18684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17747143#comment-17747143
 ] 

Dinesh Joshi commented on CASSANDRA-18684:
--

+1, thanks for the patch!

> [Analytics] Minor Refactoring to Improve Code Reusability
> -
>
> Key: CASSANDRA-18684
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18684
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Analytics Library
>Reporter: Yuriy Semchyshyn
>Assignee: Yuriy Semchyshyn
>Priority: Normal
>  Labels: Refactoring, refactor, refactoring
>
> A very minor refactoring is needed in the `CassandraClusterInfo` class to 
> enable reuse of the code block handling retrieval of all `NodeSettings`.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-18684) [Analytics] Minor Refactoring to Improve Code Reusability

2023-07-25 Thread Yifan Cai (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-18684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17747106#comment-17747106
 ] 

Yifan Cai commented on CASSANDRA-18684:
---

+1 on the patch!

> [Analytics] Minor Refactoring to Improve Code Reusability
> -
>
> Key: CASSANDRA-18684
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18684
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Analytics Library
>Reporter: Yuriy Semchyshyn
>Assignee: Yuriy Semchyshyn
>Priority: Normal
>  Labels: Refactoring, refactor, refactoring
>
> A very minor refactoring is needed in the `CassandraClusterInfo` class to 
> enable reuse of the code block handling retrieval of all `NodeSettings`.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-18684) [Analytics] Minor Refactoring to Improve Code Reusability

2023-07-25 Thread Yuriy Semchyshyn (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-18684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17747080#comment-17747080
 ] 

Yuriy Semchyshyn commented on CASSANDRA-18684:
--

PR: https://github.com/apache/cassandra-analytics/pull/12
CI: https://app.circleci.com/pipelines/github/5/cassandra-analytics

> [Analytics] Minor Refactoring to Improve Code Reusability
> -
>
> Key: CASSANDRA-18684
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18684
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Analytics Library
>Reporter: Yuriy Semchyshyn
>Priority: Normal
>  Labels: Refactoring, refactor, refactoring
>
> A very minor refactoring is needed in the `CassandraClusterInfo` class to 
> enable reuse of the code block handling retrieval of all `NodeSettings`.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org