[jira] [Commented] (CASSANDRA-18745) cqlsh should warn on server version mismatch
[
https://issues.apache.org/jira/browse/CASSANDRA-18745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17758740#comment-17758740
]
Brandon Williams commented on CASSANDRA-18745:
--
Running from the src directory isn't a problem if C* has been built:
{noformat}
$ ../bin/cqlsh
Connection error: ('Unable to connect to any servers', {'127.0.0.1:9042':
ConnectionRefusedError(111, "Tried connecting to [('127.0.0.1', 9042)]. Last
error: Connection refused")})
{noformat}
I'm not against printing some warning if it can't be imported instead, but will
note this only happens with source that isn't built - binaries and packages
will have a serverversion.py since they include a compiled server.
> cqlsh should warn on server version mismatch
>
>
> Key: CASSANDRA-18745
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18745
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Interpreter
>Reporter: Brandon Williams
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 3.0.30, 3.11.16, 4.0.12, 4.1.4, 5.0, 5.1
>
>
> When cqlsh is used against a different version of the server than the one
> that it shipped with, it should emit a warning so that users aren't confused
> when some things don't work correctly.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18745) cqlsh should warn on server version mismatch
[ https://issues.apache.org/jira/browse/CASSANDRA-18745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17758738#comment-17758738 ] Brad Schoening commented on CASSANDRA-18745: Yes, understand its being run from the src directory, but it doesn't seem like it needs to be a fatal error. > cqlsh should warn on server version mismatch > > > Key: CASSANDRA-18745 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18745 > Project: Cassandra > Issue Type: Improvement > Components: CQL/Interpreter >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 3.0.30, 3.11.16, 4.0.12, 4.1.4, 5.0, 5.1 > > > When cqlsh is used against a different version of the server than the one > that it shipped with, it should emit a warning so that users aren't confused > when some things don't work correctly. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18745) cqlsh should warn on server version mismatch
[ https://issues.apache.org/jira/browse/CASSANDRA-18745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17758736#comment-17758736 ] Brandon Williams commented on CASSANDRA-18745: -- That is an indication your C* hasn't been built. > cqlsh should warn on server version mismatch > > > Key: CASSANDRA-18745 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18745 > Project: Cassandra > Issue Type: Improvement > Components: CQL/Interpreter >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 3.0.30, 3.11.16, 4.0.12, 4.1.4, 5.0, 5.1 > > > When cqlsh is used against a different version of the server than the one > that it shipped with, it should emit a warning so that users aren't confused > when some things don't work correctly. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18745) cqlsh should warn on server version mismatch
[
https://issues.apache.org/jira/browse/CASSANDRA-18745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17758734#comment-17758734
]
Brad Schoening commented on CASSANDRA-18745:
[~brandon.williams] would be helpful if this had a try/catch around the import
of serverversion and didn't fail outright if serververison is missing. This can
happen if you run directly from the src directory, for example:
{quote}../bin/cqlsh
Traceback (most recent call last):
File "/Users/.../cassandra/bin/cqlsh.py", line 82, in
from cqlshlib.cqlshmain import main
File "/Users/.../cassandra/bin/../pylib/cqlshlib/cqlshmain.py", line 85, in
from cqlshlib.serverversion import version as build_version
ModuleNotFoundError: No module named 'cqlshlib.serverversion'
{quote}
> cqlsh should warn on server version mismatch
>
>
> Key: CASSANDRA-18745
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18745
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Interpreter
>Reporter: Brandon Williams
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 3.0.30, 3.11.16, 4.0.12, 4.1.4, 5.0, 5.1
>
>
> When cqlsh is used against a different version of the server than the one
> that it shipped with, it should emit a warning so that users aren't confused
> when some things don't work correctly.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18745) cqlsh should warn on server version mismatch
[ https://issues.apache.org/jira/browse/CASSANDRA-18745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755930#comment-17755930 ] Berenguer Blasi commented on CASSANDRA-18745: - Yep LGTM +1 > cqlsh should warn on server version mismatch > > > Key: CASSANDRA-18745 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18745 > Project: Cassandra > Issue Type: Improvement > Components: CQL/Interpreter >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 5.x > > > When cqlsh is used against a different version of the server than the one > that it shipped with, it should emit a warning so that users aren't confused > when some things don't work correctly. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18745) cqlsh should warn on server version mismatch
[ https://issues.apache.org/jira/browse/CASSANDRA-18745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755892#comment-17755892 ] Brandon Williams commented on CASSANDRA-18745: -- None of the upgrade test failures look related to this patch. > cqlsh should warn on server version mismatch > > > Key: CASSANDRA-18745 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18745 > Project: Cassandra > Issue Type: Improvement > Components: CQL/Interpreter >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 5.x > > > When cqlsh is used against a different version of the server than the one > that it shipped with, it should emit a warning so that users aren't confused > when some things don't work correctly. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18745) cqlsh should warn on server version mismatch
[ https://issues.apache.org/jira/browse/CASSANDRA-18745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755863#comment-17755863 ] Brandon Williams commented on CASSANDRA-18745: -- Started all the upgrade tests. bq. Also I can't think of an easy test here... Yeah, we'd have to do a dtest with multiple versions installed and I don't think all that weight is worth checking a little warning. > cqlsh should warn on server version mismatch > > > Key: CASSANDRA-18745 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18745 > Project: Cassandra > Issue Type: Improvement > Components: CQL/Interpreter >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 5.x > > > When cqlsh is used against a different version of the server than the one > that it shipped with, it should emit a warning so that users aren't confused > when some things don't work correctly. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18745) cqlsh should warn on server version mismatch
[ https://issues.apache.org/jira/browse/CASSANDRA-18745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755836#comment-17755836 ] Berenguer Blasi commented on CASSANDRA-18745: - We should run upgrade tests here imo, any hidden problems will probably show in there. > cqlsh should warn on server version mismatch > > > Key: CASSANDRA-18745 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18745 > Project: Cassandra > Issue Type: Improvement > Components: CQL/Interpreter >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 5.x > > > When cqlsh is used against a different version of the server than the one > that it shipped with, it should emit a warning so that users aren't confused > when some things don't work correctly. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18745) cqlsh should warn on server version mismatch
[ https://issues.apache.org/jira/browse/CASSANDRA-18745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17753245#comment-17753245 ] Brandon Williams commented on CASSANDRA-18745: -- The way I currently imagine this working is having Ant write "version = $version" to something like pylib/cqlshlib/serverversion.py, which cqlsh can then import and compare against the server version it has connected to. > cqlsh should warn on server version mismatch > > > Key: CASSANDRA-18745 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18745 > Project: Cassandra > Issue Type: Improvement > Components: CQL/Interpreter >Reporter: Brandon Williams >Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 5.x > > > When cqlsh is used against a different version of the server than the one > that it shipped with, it should emit a warning so that users aren't confused > when some things don't work correctly. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
