[jira] [Commented] (CASSANDRA-18772) Remove dependency on commons-codec
[ https://issues.apache.org/jira/browse/CASSANDRA-18772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17762181#comment-17762181 ] Ekaterina Dimitrova commented on CASSANDRA-18772: - Committed to https://github.com/apache/cassandra.git bf39188cdc..9be8369ae6 cassandra-5.0 -> cassandra-5.0 7ecac39570..f8d5a1aa16 trunk -> trunk > Remove dependency on commons-codec > -- > > Key: CASSANDRA-18772 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18772 > Project: Cassandra > Issue Type: Bug > Components: Dependencies >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 5.0.x, 5.x > > > The dependency doesn't seem to have any direct usage in our codebase. > The only reference to how it might be used was found in CASSANDRA-12790. > Considering we also deprecate in 5.0 and remove metrics-reporter-config as > part of CASSANDRA-18743, I do not see a reason not to remove this one too. > We should probably take the same approach as CASSANDRA-18743 - deprecate in > 5.0 and remove in 5.1. ML thread is to be opened too. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18772) Remove dependency on commons-codec
[ https://issues.apache.org/jira/browse/CASSANDRA-18772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17762148#comment-17762148 ] Ekaterina Dimitrova commented on CASSANDRA-18772: - One failed container in trunk CI - restarted the job here - [https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2494/workflows/81c934a3-7109-4454-949d-ba981bf4738e/jobs/38828] 5.0: # CASSANDRA-18737 # and one timeout > Remove dependency on commons-codec > -- > > Key: CASSANDRA-18772 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18772 > Project: Cassandra > Issue Type: Bug > Components: Dependencies >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 5.0.x, 5.x > > > The dependency doesn't seem to have any direct usage in our codebase. > The only reference to how it might be used was found in CASSANDRA-12790. > Considering we also deprecate in 5.0 and remove metrics-reporter-config as > part of CASSANDRA-18743, I do not see a reason not to remove this one too. > We should probably take the same approach as CASSANDRA-18743 - deprecate in > 5.0 and remove in 5.1. ML thread is to be opened too. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18772) Remove dependency on commons-codec
[ https://issues.apache.org/jira/browse/CASSANDRA-18772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17762112#comment-17762112 ] Ekaterina Dimitrova commented on CASSANDRA-18772: - 5.0 branch: https://github.com/ekaterinadimitrova2/cassandra/tree/18772-5.0; CI: https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2493/workflows/f8b3fc1a-4640-4eac-8487-fda42f7e4311 trunk branch: https://github.com/ekaterinadimitrova2/cassandra/tree/18772-trunk; CI: [https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2494/workflows/81c934a3-7109-4454-949d-ba981bf4738e] I started only JDK11 tests, this change doesn't require both JDKs. Either something explodes from the removal or not. > Remove dependency on commons-codec > -- > > Key: CASSANDRA-18772 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18772 > Project: Cassandra > Issue Type: Bug > Components: Dependencies >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 5.0.x, 5.x > > > The dependency doesn't seem to have any direct usage in our codebase. > The only reference to how it might be used was found in CASSANDRA-12790. > Considering we also deprecate in 5.0 and remove metrics-reporter-config as > part of CASSANDRA-18743, I do not see a reason not to remove this one too. > We should probably take the same approach as CASSANDRA-18743 - deprecate in > 5.0 and remove in 5.1. ML thread is to be opened too. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18772) Remove dependency on commons-codec
[ https://issues.apache.org/jira/browse/CASSANDRA-18772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17762100#comment-17762100 ] Ekaterina Dimitrova commented on CASSANDRA-18772: - One week with no concerns raised, I take that as a lazy consensus. > Remove dependency on commons-codec > -- > > Key: CASSANDRA-18772 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18772 > Project: Cassandra > Issue Type: Bug > Components: Dependencies >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 5.0.x, 5.x > > > The dependency doesn't seem to have any direct usage in our codebase. > The only reference to how it might be used was found in CASSANDRA-12790. > Considering we also deprecate in 5.0 and remove metrics-reporter-config as > part of CASSANDRA-18743, I do not see a reason not to remove this one too. > We should probably take the same approach as CASSANDRA-18743 - deprecate in > 5.0 and remove in 5.1. ML thread is to be opened too. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18772) Remove dependency on commons-codec
[ https://issues.apache.org/jira/browse/CASSANDRA-18772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17761134#comment-17761134 ] Ekaterina Dimitrova commented on CASSANDRA-18772: - There was a consensus we can move forward with this one. To be extra cautious, email to @user was initiated first - [https://lists.apache.org/thread/c4m3tc08zhd4d41zs05jcdkr3gjwlhno] If no one expresses any concerns until next week, I will move this one forward. > Remove dependency on commons-codec > -- > > Key: CASSANDRA-18772 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18772 > Project: Cassandra > Issue Type: Bug > Components: Dependencies >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 5.0.x, 5.x > > > The dependency doesn't seem to have any direct usage in our codebase. > The only reference to how it might be used was found in CASSANDRA-12790. > Considering we also deprecate in 5.0 and remove metrics-reporter-config as > part of CASSANDRA-18743, I do not see a reason not to remove this one too. > We should probably take the same approach as CASSANDRA-18743 - deprecate in > 5.0 and remove in 5.1. ML thread is to be opened too. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18772) Remove dependency on commons-codec
[ https://issues.apache.org/jira/browse/CASSANDRA-18772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17758091#comment-17758091 ] Ekaterina Dimitrova commented on CASSANDRA-18772: - I created a general discussion thread as the community is about to vote for a 5.0 alpha version, and there were different opinions around dependency management in an alpha release. https://lists.apache.org/thread/pdq1y2xks629lh6h7nfc6mt5gp145bs6 > Remove dependency on commons-codec > -- > > Key: CASSANDRA-18772 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18772 > Project: Cassandra > Issue Type: Bug > Components: Dependencies >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 5.0.x, 5.x > > > The dependency doesn't seem to have any direct usage in our codebase. > The only reference to how it might be used was found in CASSANDRA-12790. > Considering we also deprecate in 5.0 and remove metrics-reporter-config as > part of CASSANDRA-18743, I do not see a reason not to remove this one too. > We should probably take the same approach as CASSANDRA-18743 - deprecate in > 5.0 and remove in 5.1. ML thread is to be opened too. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18772) Remove dependency on commons-codec
[ https://issues.apache.org/jira/browse/CASSANDRA-18772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755673#comment-17755673 ] Maxim Muzafarov commented on CASSANDRA-18772: - [~e.dimitrova] I've created the issue: CASSANDRA-18777 > Remove dependency on commons-codec > -- > > Key: CASSANDRA-18772 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18772 > Project: Cassandra > Issue Type: Bug > Components: Dependencies >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 5.0.x, 5.x > > > The dependency doesn't seem to have any direct usage in our codebase. > The only reference to how it might be used was found in CASSANDRA-12790. > Considering we also deprecate in 5.0 and remove metrics-reporter-config as > part of CASSANDRA-18743, I do not see a reason not to remove this one too. > We should probably take the same approach as CASSANDRA-18743 - deprecate in > 5.0 and remove in 5.1. ML thread is to be opened too. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18772) Remove dependency on commons-codec
[ https://issues.apache.org/jira/browse/CASSANDRA-18772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755642#comment-17755642 ] Ekaterina Dimitrova commented on CASSANDRA-18772: - ML thread started here - https://lists.apache.org/thread/9m1vz5qyows97wlppkwk1fd8386rj9q1 > Remove dependency on commons-codec > -- > > Key: CASSANDRA-18772 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18772 > Project: Cassandra > Issue Type: Bug > Components: Dependencies >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 5.0.x, 5.x > > > The dependency doesn't seem to have any direct usage in our codebase. > The only reference to how it might be used was found in CASSANDRA-12790. > Considering we also deprecate in 5.0 and remove metrics-reporter-config as > part of CASSANDRA-18743, I do not see a reason not to remove this one too. > We should probably take the same approach as CASSANDRA-18743 - deprecate in > 5.0 and remove in 5.1. ML thread is to be opened too. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18772) Remove dependency on commons-codec
[
https://issues.apache.org/jira/browse/CASSANDRA-18772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755571#comment-17755571
]
Ekaterina Dimitrova commented on CASSANDRA-18772:
-
{quote}this list should be carefully filtered, as some of the "unused
dependencies" may actually be used at runtime.
{quote}
I think some of those need to change probably the mvn scope from compile to
sthg else maybe? Can we open another ticket to explore this, please? I don't
want it to get lost.
{quote}assuming we clear the ML.
{quote}
I will start a thread soon
> Remove dependency on commons-codec
> --
>
> Key: CASSANDRA-18772
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18772
> Project: Cassandra
> Issue Type: Bug
> Components: Dependencies
>Reporter: Ekaterina Dimitrova
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 5.0.x, 5.x
>
>
> The dependency doesn't seem to have any direct usage in our codebase.
> The only reference to how it might be used was found in CASSANDRA-12790.
> Considering we also deprecate in 5.0 and remove metrics-reporter-config as
> part of CASSANDRA-18743, I do not see a reason not to remove this one too.
> We should probably take the same approach as CASSANDRA-18743 - deprecate in
> 5.0 and remove in 5.1. ML thread is to be opened too.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18772) Remove dependency on commons-codec
[
https://issues.apache.org/jira/browse/CASSANDRA-18772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755541#comment-17755541
]
Maxim Muzafarov commented on CASSANDRA-18772:
-
OK, I've found an easy way to find all the unused dependencies, but this list
should be carefully filtered, as some of the "unused dependencies" may actually
be used at runtime. I doubt we can add running of this command to the ant build
as the maven is used.
h3. The command
Tested on the latest trunk (\{{commons-codec}} is there).
{code:java}
mvn -f ./build/apache-cassandra-5.0-SNAPSHOT.pom
org.apache.maven.plugins:maven-dependency-plugin:3.2.0:analyze -Dverbose=true
-DignoreNonCompile
{code}
h3. The result
{code:java}
[INFO] --- dependency:3.2.0:analyze (default-cli) @ cassandra-all ---
[WARNING] Unused declared dependencies found:
[WARNING]com.github.jnr:jffi:jar:native:1.3.11:compile
[WARNING]net.openhft:chronicle-threads:jar:2.23.25:compile
[WARNING]org.psjava:psjava:jar:0.1.19:compile
[WARNING]ch.qos.logback:logback-core:jar:1.2.9:compile
[WARNING]io.netty:netty-transport-native-epoll:jar:4.1.94.Final:compile
[WARNING]org.lz4:lz4-java:jar:1.8.0:compile
[WARNING]org.apache.commons:commons-lang3:jar:3.11:compile
[WARNING]com.fasterxml.jackson.core:jackson-annotations:jar:2.13.2:compile
[WARNING]net.openhft:chronicle-bytes:jar:2.23.33:compile
[WARNING]ch.obermuhlner:big-math:jar:2.3.0:compile
[WARNING]io.airlift:airline:jar:0.8:compile
[WARNING]io.dropwizard.metrics:metrics-logback:jar:3.1.5:compile
[WARNING]io.dropwizard.metrics:metrics-core:jar:3.1.5:compile
[WARNING]org.gridkit.jvmtool:sjk-core:jar:0.14:compile
[WARNING]com.github.seancfoley:ipaddress:jar:5.3.3:compile
[WARNING]com.google.j2objc:j2objc-annotations:jar:1.3:compile
[WARNING]com.fasterxml.jackson.core:jackson-databind:jar:2.13.2.2:compile
[WARNING]net.java.dev.jna:jna:jar:5.13.0:compile
[WARNING]org.gridkit.lab:jvm-attach-api:jar:1.5:compile
[WARNING]org.gridkit.jvmtool:sjk-json:jar:0.14:compile
[WARNING]org.agrona:agrona:jar:1.17.1:compile
[WARNING]org.slf4j:jcl-over-slf4j:jar:1.7.25:compile
[WARNING]
com.fasterxml.jackson.datatype:jackson-datatype-jsr310:jar:2.13.2:compile
[WARNING]com.github.jbellis:jamm:jar:0.4.0:compile
[WARNING]net.openhft:posix:jar:2.24ea4:compile
[WARNING]net.openhft:chronicle-queue:jar:5.23.37:compile
[WARNING]commons-codec:commons-codec:jar:1.9:compile
[WARNING]com.boundary:high-scale-lib:jar:1.0.6:compile
[WARNING]org.caffinitas.ohc:ohc-core-j8:jar:0.5.1:compile
[WARNING]com.addthis.metrics:reporter-config3:jar:3.0.3:compile
[WARNING]
com.datastax.cassandra:cassandra-driver-core:jar:shaded:3.11.0:compile
[WARNING]com.github.luben:zstd-jni:jar:1.5.5-1:compile
[WARNING]com.carrotsearch:hppc:jar:0.8.1:compile
[WARNING]org.xerial.snappy:snappy-java:jar:1.1.10.1:compile
[WARNING]org.bouncycastle:bcpkix-jdk15on:jar:1.70:compile
[WARNING]com.google.code.findbugs:jsr305:jar:2.0.2:compile
[WARNING]com.clearspring.analytics:stream:jar:2.5.2:compile
[WARNING]org.mindrot:jbcrypt:jar:0.4:compile
[WARNING]
io.netty:netty-transport-native-epoll:jar:linux-x86_64:4.1.94.Final:compile
[WARNING]ch.qos.logback:logback-classic:jar:1.2.9:compile
[WARNING]com.google.guava:guava:jar:32.0.1-jre:compile
[WARNING]org.apache.commons:commons-math3:jar:3.2:compile
[WARNING]org.yaml:snakeyaml:jar:1.26:compile
[WARNING]org.apache.lucene:lucene-core:jar:9.7.0:compile
[WARNING]net.openhft:affinity:jar:3.23.3:compile
[WARNING]org.eclipse.jdt:ecj:jar:3.33.0:compile
[WARNING]org.slf4j:log4j-over-slf4j:jar:1.7.25:compile
[WARNING]org.caffinitas.ohc:ohc-core:jar:0.5.1:compile
[WARNING]org.gridkit.jvmtool:sjk-cli:jar:0.14:compile
[WARNING]org.apache.lucene:lucene-analysis-common:jar:9.7.0:compile
[WARNING]com.github.jnr:jnr-constants:jar:0.10.4:compile
[WARNING]org.hdrhistogram:HdrHistogram:jar:2.1.9:compile
[WARNING]net.openhft:chronicle-core:jar:2.23.36:compile
[WARNING]com.github.ben-manes.caffeine:caffeine:jar:2.9.2:compile
[WARNING]org.antlr:ST4:jar:4.0.8:compile
[WARNING]org.gridkit.jvmtool:mxdump:jar:0.14:compile
[WARNING]io.netty:netty-tcnative-boringssl-static:jar:2.0.61.Final:compile
[WARNING]org.antlr:antlr-runtime:jar:3.5.2:compile
[WARNING]com.beust:jcommander:jar:1.30:compile
[WARNING]com.fasterxml.jackson.core:jackson-core:jar:2.13.2:compile
[WARNING]javax.inject:javax.inject:jar:1:compile
[WARNING]io.dropwizard.metrics:metrics-jvm:jar:3.1.5:compile
[WARNING]commons-cli:commons-cli:jar:1.5.0:compile
[WARNING]com.github.jnr:jnr-ffi:jar:2.2.13:compile
[WARNING]org.slf4j:slf4j-api:jar:1.7.25:compile
[WARNING]org.fusesource:sigar:jar:1.6.4:compile
[WARNING]org.jctools:jctools-core:jar:3.1.0:compile
[WARNING]
[jira] [Commented] (CASSANDRA-18772) Remove dependency on commons-codec
[ https://issues.apache.org/jira/browse/CASSANDRA-18772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755493#comment-17755493 ] Brandon Williams commented on CASSANDRA-18772: -- CI looks good, I'm +1 assuming we clear the ML. > Remove dependency on commons-codec > -- > > Key: CASSANDRA-18772 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18772 > Project: Cassandra > Issue Type: Bug > Components: Dependencies >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 5.0.x, 5.x > > > The dependency doesn't seem to have any direct usage in our codebase. > The only reference to how it might be used was found in CASSANDRA-12790. > Considering we also deprecate in 5.0 and remove metrics-reporter-config as > part of CASSANDRA-18743, I do not see a reason not to remove this one too. > We should probably take the same approach as CASSANDRA-18743 - deprecate in > 5.0 and remove in 5.1. ML thread is to be opened too. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18772) Remove dependency on commons-codec
[ https://issues.apache.org/jira/browse/CASSANDRA-18772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755257#comment-17755257 ] Ekaterina Dimitrova commented on CASSANDRA-18772: - I removed commons-codec on trunk based [branch|https://github.com/apache/cassandra/compare/trunk...ekaterinadimitrova2:cassandra:18772-trunk], and I am running CI [here|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2481/workflows/6f261d27-dafd-4fad-b0e8-2e89a07d7f02] before sending mail to the ML, just in case something explodes... Let's see what happens. > Remove dependency on commons-codec > -- > > Key: CASSANDRA-18772 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18772 > Project: Cassandra > Issue Type: Bug > Components: Dependencies >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 5.0.x, 5.x > > > The dependency doesn't seem to have any direct usage in our codebase. > The only reference to how it might be used was found in CASSANDRA-12790. > Considering we also deprecate in 5.0 and remove metrics-reporter-config as > part of CASSANDRA-18743, I do not see a reason not to remove this one too. > We should probably take the same approach as CASSANDRA-18743 - deprecate in > 5.0 and remove in 5.1. ML thread is to be opened too. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18772) Remove dependency on commons-codec
[
https://issues.apache.org/jira/browse/CASSANDRA-18772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755256#comment-17755256
]
Ekaterina Dimitrova commented on CASSANDRA-18772:
-
{quote}I'll do some more digging to find a robust solution.
{quote}
That would be great, thanks :)
> Remove dependency on commons-codec
> --
>
> Key: CASSANDRA-18772
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18772
> Project: Cassandra
> Issue Type: Bug
> Components: Dependencies
>Reporter: Ekaterina Dimitrova
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 5.0.x, 5.x
>
>
> The dependency doesn't seem to have any direct usage in our codebase.
> The only reference to how it might be used was found in CASSANDRA-12790.
> Considering we also deprecate in 5.0 and remove metrics-reporter-config as
> part of CASSANDRA-18743, I do not see a reason not to remove this one too.
> We should probably take the same approach as CASSANDRA-18743 - deprecate in
> 5.0 and remove in 5.1. ML thread is to be opened too.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18772) Remove dependency on commons-codec
[ https://issues.apache.org/jira/browse/CASSANDRA-18772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755254#comment-17755254 ] Maxim Muzafarov commented on CASSANDRA-18772: - I was thinking about how we could find other dependencies that are no longer used, and how we could find them during the build. One I've found: https://docs.jboss.org/tattletale/userguide/1.2/en-US/html/ant.html https://tattletale.jboss.org/ I'll do some more digging to find a robust solution. > Remove dependency on commons-codec > -- > > Key: CASSANDRA-18772 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18772 > Project: Cassandra > Issue Type: Bug > Components: Dependencies >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 5.0.x, 5.x > > > The dependency doesn't seem to have any direct usage in our codebase. > The only reference to how it might be used was found in CASSANDRA-12790. > Considering we also deprecate in 5.0 and remove metrics-reporter-config as > part of CASSANDRA-18743, I do not see a reason not to remove this one too. > We should probably take the same approach as CASSANDRA-18743 - deprecate in > 5.0 and remove in 5.1. ML thread is to be opened too. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
